Re: d7be102f29 ("cfg80211: initialize regulatory keys/database later"): kernel BUG at crypto/asymmetric_keys/public_key.c:80!

2017-11-27 Thread Linus Torvalds
On Mon, Nov 27, 2017 at 3:25 PM, David Howells wrote: > > This function has a list of requisite parameters for the caller: .. and so what? When you call "free()", that has a requisite parameter: the data to free. If you don't supply it, we should BUG_ON(), right? No. Instead we do the sane thin

Re: d7be102f29 ("cfg80211: initialize regulatory keys/database later"): kernel BUG at crypto/asymmetric_keys/public_key.c:80!

2017-11-27 Thread Kees Cook
On Mon, Nov 27, 2017 at 3:25 PM, David Howells wrote: > Linus Torvalds wrote: > >> I'm not seeing why it would ever be ok to do BUG_ON() instead of just >> returning an error, though. > > This function has a list of requisite parameters for the caller: > > BUG_ON(!pkey); <-- You

Re: d7be102f29 ("cfg80211: initialize regulatory keys/database later"): kernel BUG at crypto/asymmetric_keys/public_key.c:80!

2017-11-27 Thread David Howells
Linus Torvalds wrote: > I'm not seeing why it would ever be ok to do BUG_ON() instead of just > returning an error, though. This function has a list of requisite parameters for the caller: BUG_ON(!pkey); <-- You need the public key to use, BUG_ON(!sig); BUG_ON(!

Re: d7be102f29 ("cfg80211: initialize regulatory keys/database later"): kernel BUG at crypto/asymmetric_keys/public_key.c:80!

2017-11-27 Thread Johannes Berg
; regulatory keys/database later") > > The attached 'dmesg.xz' doesn't actually match the kernel or the > report. Very odd. > > > [8.602885] kernel BUG at crypto/asymmetric_keys/public_key.c:80! > > In that reported kernel, that is > > 80

Re: d7be102f29 ("cfg80211: initialize regulatory keys/database later"): kernel BUG at crypto/asymmetric_keys/public_key.c:80!

2017-11-27 Thread Linus Torvalds
27;t actually match the kernel or the report. Very odd. > [8.602885] kernel BUG at crypto/asymmetric_keys/public_key.c:80! In that reported kernel, that is 80 BUG_ON(!sig->digest); so the public key signature has no digest. > [8.607873] Call Trace: > [

d7be102f29 ("cfg80211: initialize regulatory keys/database later"): kernel BUG at crypto/asymmetric_keys/public_key.c:80!

2017-11-25 Thread Fengguang Wu
| 0 | 12 | +---+++ [8.602885] kernel BUG at crypto/asymmetric_keys/public_key.c:80! [8.604548] invalid opcode: [#1] [8.605140] Modules linked in: [8.605603] CPU: 0 PID: 1 Comm: s

Re: kernel BUG at crypto/asymmetric_keys/public_key.c:80

2017-11-23 Thread Johannes Berg
On Thu, 2017-11-23 at 09:47 -0800, Florian Fainelli wrote: > Absolutely, please find it enclosed. Thanks. This is a bit odd. I didn't think the most likely reason is that you have CONFIG_CRYPTO_SHA256=m but everything else built-in. Thus, when loading the certificate, there's no way to calcula

Re: kernel BUG at crypto/asymmetric_keys/public_key.c:80

2017-11-23 Thread Florian Fainelli
PHY fixed-0:02: attached PHY driver [Generic PHY] (mii_bus:phy_addr=fixed-0:02, irq=POLL) [1.779876] DSA: tree 0 setup [1.782864] Starfighter 2 top: 4.00, core: 2.00 base: 0xf0b8, IRQs: 67, 68 [ 1.790540] brcmstb-waketimer f0417580.waketimer: setting system clock to 1970-01-0

Re: kernel BUG at crypto/asymmetric_keys/public_key.c:80

2017-11-23 Thread Johannes Berg
On Wed, 2017-11-22 at 15:07 -0800, Florian Fainelli wrote: > On 11/22/2017 10:42 AM, Johannes Berg wrote: > > On Wed, 2017-11-22 at 19:29 +0100, Arend van Spriel wrote: > > > + Johannes > > > > > > >>> BUG_ON(!sig->digest); > > > BUG_ON(!sig->s); > > > > I *think* this is the same b

Re: kernel BUG at crypto/asymmetric_keys/public_key.c:80

2017-11-22 Thread Florian Fainelli
On 11/22/2017 10:42 AM, Johannes Berg wrote: > On Wed, 2017-11-22 at 19:29 +0100, Arend van Spriel wrote: >> + Johannes >> >> >>> BUG_ON(!sig->digest); >> BUG_ON(!sig->s); > > I *think* this is the same bug that was reported before, then this > should fix it: > > https://git.kernel.

Re: kernel BUG at crypto/asymmetric_keys/public_key.c:80

2017-11-22 Thread Johannes Berg
On Wed, 2017-11-22 at 19:29 +0100, Arend van Spriel wrote: > + Johannes > > >>> BUG_ON(!sig->digest); > BUG_ON(!sig->s); I *think* this is the same bug that was reported before, then this should fix it: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git/commit/?id=d7be10

Re: kernel BUG at crypto/asymmetric_keys/public_key.c:80

2017-11-22 Thread Arend van Spriel
database [1.809390] [ cut here ] [1.814020] kernel BUG at crypto/asymmetric_keys/public_key.c:80! [1.820123] Internal error: Oops - BUG: 0 [#1] SMP ARM [1.825273] Modules linked in: [1.828341] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.14.0-12995

kernel BUG at crypto/asymmetric_keys/public_key.c:80

2017-11-22 Thread Florian Fainelli
] [1.814020] kernel BUG at crypto/asymmetric_keys/public_key.c:80! [1.820123] Internal error: Oops - BUG: 0 [#1] SMP ARM [1.825273] Modules linked in: [1.828341] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.14.0-12995-g0c86a6bd85ff #15 [1.836096] Hardware name: Broadcom STB