Re: kernfs: can read/write method grow buffer size?

2019-03-29 Thread Pavel Machek
Hi! > > > Yes, and cpufreq governors too list available governosrs as space > > > separated list. > > > Maybe the "one value per file" rule was thought-of only after these > > > were merged? > > > > For small numbers of things, like /sys/power/state, which was the first > > file to use this

Re: kernfs: can read/write method grow buffer size?

2019-03-29 Thread Pavel Machek
> On Fri, Mar 29, 2019 at 09:48:23AM +0100, Marek Behun wrote: > > > pavel@amd:~/cip$ cat /sys/power/state > > > freeze mem disk > > > pavel@amd:~/cip$ cat /sys/class/leds/phy0-led/trigger > > > none bluetooth-power rfkill-any rfkill-none kbd-scrolllock kbd-numlock > > > kbd-capslock kbd-kanalock

Re: kernfs: can read/write method grow buffer size?

2019-03-29 Thread Greg Kroah-Hartman
On Fri, Mar 29, 2019 at 11:24:36AM +0100, Greg Kroah-Hartman wrote: > On Fri, Mar 29, 2019 at 09:48:23AM +0100, Marek Behun wrote: > > > pavel@amd:~/cip$ cat /sys/power/state > > > freeze mem disk > > > pavel@amd:~/cip$ cat /sys/class/leds/phy0-led/trigger > > > none bluetooth-power rfkill-any

Re: kernfs: can read/write method grow buffer size?

2019-03-29 Thread Greg Kroah-Hartman
On Fri, Mar 29, 2019 at 09:48:23AM +0100, Marek Behun wrote: > > pavel@amd:~/cip$ cat /sys/power/state > > freeze mem disk > > pavel@amd:~/cip$ cat /sys/class/leds/phy0-led/trigger > > none bluetooth-power rfkill-any rfkill-none kbd-scrolllock kbd-numlock > > kbd-capslock kbd-kanalock

Re: kernfs: can read/write method grow buffer size?

2019-03-29 Thread Marek Behun
> pavel@amd:~/cip$ cat /sys/power/state > freeze mem disk > pavel@amd:~/cip$ cat /sys/class/leds/phy0-led/trigger > none bluetooth-power rfkill-any rfkill-none kbd-scrolllock kbd-numlock > kbd-capslock kbd-kanalock kbd-shiftlock kbd-altgrlock kbd-ctrllock > kbd-altlock kbd-shiftllock

Re: kernfs: can read/write method grow buffer size?

2019-03-29 Thread Pavel Machek
On Fri 2019-03-29 07:22:53, Greg Kroah-Hartman wrote: > On Fri, Mar 29, 2019 at 04:09:22AM +0100, Marek Behun wrote: > > Hello Tejun and Greg, > > > > kernfs_fop_open/read/write allocates a buffer for the ->read, ->write, > > or ->seq_read methods. This buffer is either preallocated or allocated

Re: kernfs: can read/write method grow buffer size?

2019-03-29 Thread Greg Kroah-Hartman
On Fri, Mar 29, 2019 at 07:51:07AM +0100, Marek Behun wrote: > > If this is just for kernfs, and you have your own filesystem, sure, we > > can probably do something here. But if this is for sysfs, no, you all > > need to keep to the "one value per file" rule that we have there > > please. > >

Re: kernfs: can read/write method grow buffer size?

2019-03-29 Thread Marek Behun
> If this is just for kernfs, and you have your own filesystem, sure, we > can probably do something here. But if this is for sysfs, no, you all > need to keep to the "one value per file" rule that we have there > please. Greg, the file satisfies the "one value per file" rule. That value is the

Re: kernfs: can read/write method grow buffer size?

2019-03-29 Thread Greg Kroah-Hartman
On Fri, Mar 29, 2019 at 04:09:22AM +0100, Marek Behun wrote: > Hello Tejun and Greg, > > kernfs_fop_open/read/write allocates a buffer for the ->read, ->write, > or ->seq_read methods. This buffer is either preallocated or allocated > on the spot, with minimum size being PAGE_SIZE, if

kernfs: can read/write method grow buffer size?

2019-03-28 Thread Marek Behun
Hello Tejun and Greg, kernfs_fop_open/read/write allocates a buffer for the ->read, ->write, or ->seq_read methods. This buffer is either preallocated or allocated on the spot, with minimum size being PAGE_SIZE, if ->atomic_write_len is not given. There is a question/problem currently in the