Re: kprobes string reading broken on s390

2020-06-06 Thread Christoph Hellwig
On Fri, Jun 05, 2020 at 07:44:33PM +0200, Sven Schnelle wrote: > > Thanks for fixing! > > This report can be a good changelog. > > Please resend it with Fixed tag as Christoph said. > > Which SHA1 should the Fixes tag carry? The one from linux-next? Oh, I thought it had hit mainline already. If

Re: kprobes string reading broken on s390

2020-06-05 Thread Sven Schnelle
Masami, On Sat, Jun 06, 2020 at 01:58:06AM +0900, Masami Hiramatsu wrote: > Hi Sven, > > On Fri, 5 Jun 2020 15:25:41 +0200 > Christoph Hellwig wrote: > > > Yes, this looks correct. You probably want to write a small changelog > > and add a Fixes tag, though. > > > > On Fri, Jun 05, 2020 at

Re: kprobes string reading broken on s390

2020-06-05 Thread Masami Hiramatsu
Hi Sven, On Fri, 5 Jun 2020 15:25:41 +0200 Christoph Hellwig wrote: > Yes, this looks correct. You probably want to write a small changelog > and add a Fixes tag, though. > > On Fri, Jun 05, 2020 at 01:05:34PM +0200, Sven Schnelle wrote: > > Hi Christoph, > > > > with the latest linux-next i

Re: kprobes string reading broken on s390

2020-06-05 Thread Christoph Hellwig
Yes, this looks correct. You probably want to write a small changelog and add a Fixes tag, though. On Fri, Jun 05, 2020 at 01:05:34PM +0200, Sven Schnelle wrote: > Hi Christoph, > > with the latest linux-next i noticed that some tests in the > ftrace test suites are failing on s390, namely: >

kprobes string reading broken on s390

2020-06-05 Thread Sven Schnelle
Hi Christoph, with the latest linux-next i noticed that some tests in the ftrace test suites are failing on s390, namely: [FAIL] Kprobe event symbol argument [FAIL] Kprobe event with comm arguments The following doesn't work anymore: cd /sys/kernel/tracing echo 'p:testprobe _do_fork comm=$comm