Re: kref refcounting breakage in mainline

2007-03-19 Thread Randy Dunlap
On Thu, 15 Mar 2007 07:54:14 -0700 Greg KH wrote: > On Thu, Mar 15, 2007 at 11:19:20AM +0100, Mike Galbraith wrote: > > On Thu, 2007-03-15 at 01:06 -0700, Greg KH wrote: > > > > > That's good. But why don't we have a module name for this driver? > > > > > > And if we don't have a module name,

Re: kref refcounting breakage in mainline

2007-03-19 Thread Randy Dunlap
On Thu, 15 Mar 2007 07:54:14 -0700 Greg KH wrote: On Thu, Mar 15, 2007 at 11:19:20AM +0100, Mike Galbraith wrote: On Thu, 2007-03-15 at 01:06 -0700, Greg KH wrote: That's good. But why don't we have a module name for this driver? And if we don't have a module name, why would

Re: kref refcounting breakage in mainline

2007-03-15 Thread Greg KH
On Thu, Mar 15, 2007 at 11:19:20AM +0100, Mike Galbraith wrote: > On Thu, 2007-03-15 at 01:06 -0700, Greg KH wrote: > > > That's good. But why don't we have a module name for this driver? > > > > And if we don't have a module name, why would there be a symlink to > > remove? That's what is

Re: kref refcounting breakage in mainline

2007-03-15 Thread Mike Galbraith
On Thu, 2007-03-15 at 09:32 +0100, Mike Galbraith wrote: > On Thu, 2007-03-15 at 01:06 -0700, Greg KH wrote: > > > That's good. But why don't we have a module name for this driver? > > > > And if we don't have a module name, why would there be a symlink to > > remove? That's what is keeping

Re: kref refcounting breakage in mainline

2007-03-15 Thread Mike Galbraith
On Thu, 2007-03-15 at 01:06 -0700, Greg KH wrote: > That's good. But why don't we have a module name for this driver? > > And if we don't have a module name, why would there be a symlink to > remove? That's what is keeping your module from unloading, right? Ya got me, but according to my

Re: kref refcounting breakage in mainline

2007-03-15 Thread Greg KH
On Thu, Mar 15, 2007 at 08:53:07AM +0100, Mike Galbraith wrote: > On Wed, 2007-03-14 at 22:27 -0700, Greg KH wrote: > > > But can you try this version instead? > > It exploded in strcmp(). Unfortunately, the full oops didn't make it to > either console or serial console. > > [ 30.783048]

Re: kref refcounting breakage in mainline

2007-03-15 Thread Mike Galbraith
On Wed, 2007-03-14 at 22:27 -0700, Greg KH wrote: > But can you try this version instead? It exploded in strcmp(). Unfortunately, the full oops didn't make it to either console or serial console. [ 30.783048] ipmi message handler version 39.1 [ 30.787632] ipmi device interface [

Re: kref refcounting breakage in mainline

2007-03-15 Thread Mike Galbraith
On Wed, 2007-03-14 at 22:27 -0700, Greg KH wrote: But can you try this version instead? It exploded in strcmp(). Unfortunately, the full oops didn't make it to either console or serial console. [ 30.783048] ipmi message handler version 39.1 [ 30.787632] ipmi device interface [

Re: kref refcounting breakage in mainline

2007-03-15 Thread Greg KH
On Thu, Mar 15, 2007 at 08:53:07AM +0100, Mike Galbraith wrote: On Wed, 2007-03-14 at 22:27 -0700, Greg KH wrote: But can you try this version instead? It exploded in strcmp(). Unfortunately, the full oops didn't make it to either console or serial console. [ 30.783048] ipmi message

Re: kref refcounting breakage in mainline

2007-03-15 Thread Mike Galbraith
On Thu, 2007-03-15 at 01:06 -0700, Greg KH wrote: That's good. But why don't we have a module name for this driver? And if we don't have a module name, why would there be a symlink to remove? That's what is keeping your module from unloading, right? Ya got me, but according to my debug

Re: kref refcounting breakage in mainline

2007-03-15 Thread Mike Galbraith
On Thu, 2007-03-15 at 09:32 +0100, Mike Galbraith wrote: On Thu, 2007-03-15 at 01:06 -0700, Greg KH wrote: That's good. But why don't we have a module name for this driver? And if we don't have a module name, why would there be a symlink to remove? That's what is keeping your module

Re: kref refcounting breakage in mainline

2007-03-15 Thread Greg KH
On Thu, Mar 15, 2007 at 11:19:20AM +0100, Mike Galbraith wrote: On Thu, 2007-03-15 at 01:06 -0700, Greg KH wrote: That's good. But why don't we have a module name for this driver? And if we don't have a module name, why would there be a symlink to remove? That's what is keeping your

Re: kref refcounting breakage in mainline

2007-03-14 Thread Greg KH
On Sat, Mar 10, 2007 at 04:44:06PM +0100, Mike Galbraith wrote: > On Wed, 2007-03-07 at 06:39 +0100, Mike Galbraith wrote: > > On Tue, 2007-03-06 at 13:04 -0800, Greg KH wrote: > > > On Tue, Mar 06, 2007 at 06:43:22AM +0100, Mike Galbraith wrote: > > > > On Mon, 2007-03-05 at 16:25 -0800, Greg KH

Re: kref refcounting breakage in mainline

2007-03-14 Thread Greg KH
On Sat, Mar 10, 2007 at 04:44:06PM +0100, Mike Galbraith wrote: On Wed, 2007-03-07 at 06:39 +0100, Mike Galbraith wrote: On Tue, 2007-03-06 at 13:04 -0800, Greg KH wrote: On Tue, Mar 06, 2007 at 06:43:22AM +0100, Mike Galbraith wrote: On Mon, 2007-03-05 at 16:25 -0800, Greg KH wrote:

Re: kref refcounting breakage in mainline

2007-03-10 Thread Mike Galbraith
P.S. forgot to include diagnostic log. Kobject c0644890 is the source of my woes. Printk's come below WARN_ON(is_ipmi_si_kobj). Post-tinker log is huge, and probably not interesting. [ 30.397160] kobject ipmi_devintf: registering. parent: , set: module [ 30.404033] kobject_uevent_env [

Re: kref refcounting breakage in mainline

2007-03-10 Thread Mike Galbraith
On Wed, 2007-03-07 at 06:39 +0100, Mike Galbraith wrote: > On Tue, 2007-03-06 at 13:04 -0800, Greg KH wrote: > > On Tue, Mar 06, 2007 at 06:43:22AM +0100, Mike Galbraith wrote: > > > On Mon, 2007-03-05 at 16:25 -0800, Greg KH wrote: > > > > > > > Mike, I've reverted this patch, and I don't see

Re: kref refcounting breakage in mainline

2007-03-10 Thread Mike Galbraith
On Wed, 2007-03-07 at 06:39 +0100, Mike Galbraith wrote: On Tue, 2007-03-06 at 13:04 -0800, Greg KH wrote: On Tue, Mar 06, 2007 at 06:43:22AM +0100, Mike Galbraith wrote: On Mon, 2007-03-05 at 16:25 -0800, Greg KH wrote: Mike, I've reverted this patch, and I don't see any references

Re: kref refcounting breakage in mainline

2007-03-10 Thread Mike Galbraith
P.S. forgot to include diagnostic log. Kobject c0644890 is the source of my woes. Printk's come below WARN_ON(is_ipmi_si_kobj). Post-tinker log is huge, and probably not interesting. [ 30.397160] kobject ipmi_devintf: registering. parent: NULL, set: module [ 30.404033] kobject_uevent_env

Re: kref refcounting breakage in mainline

2007-03-06 Thread Mike Galbraith
On Tue, 2007-03-06 at 13:04 -0800, Greg KH wrote: > On Tue, Mar 06, 2007 at 06:43:22AM +0100, Mike Galbraith wrote: > > On Mon, 2007-03-05 at 16:25 -0800, Greg KH wrote: > > > > > Mike, I've reverted this patch, and I don't see any references leaking. > > > And, as your patch released the

Re: kref refcounting breakage in mainline

2007-03-06 Thread Greg KH
On Tue, Mar 06, 2007 at 06:43:22AM +0100, Mike Galbraith wrote: > On Mon, 2007-03-05 at 16:25 -0800, Greg KH wrote: > > > Mike, I've reverted this patch, and I don't see any references leaking. > > And, as your patch released the reference on the driver, and the > > module_add_driver() call would

Re: kref refcounting breakage in mainline

2007-03-06 Thread Mel Gorman
On (05/03/07 16:25), Greg KH didst pronounce: > On Fri, Mar 02, 2007 at 12:58:33AM -0800, Andrew Morton wrote: > > > > -mm has a debugging patch which warns when atomic_dec_and_test() takes an > > atomic_t negative > >

Re: kref refcounting breakage in mainline

2007-03-06 Thread Mel Gorman
On (05/03/07 16:25), Greg KH didst pronounce: On Fri, Mar 02, 2007 at 12:58:33AM -0800, Andrew Morton wrote: -mm has a debugging patch which warns when atomic_dec_and_test() takes an atomic_t negative

Re: kref refcounting breakage in mainline

2007-03-06 Thread Greg KH
On Tue, Mar 06, 2007 at 06:43:22AM +0100, Mike Galbraith wrote: On Mon, 2007-03-05 at 16:25 -0800, Greg KH wrote: Mike, I've reverted this patch, and I don't see any references leaking. And, as your patch released the reference on the driver, and the module_add_driver() call would not

Re: kref refcounting breakage in mainline

2007-03-06 Thread Mike Galbraith
On Tue, 2007-03-06 at 13:04 -0800, Greg KH wrote: On Tue, Mar 06, 2007 at 06:43:22AM +0100, Mike Galbraith wrote: On Mon, 2007-03-05 at 16:25 -0800, Greg KH wrote: Mike, I've reverted this patch, and I don't see any references leaking. And, as your patch released the reference on the

Re: kref refcounting breakage in mainline

2007-03-05 Thread Mike Galbraith
On Mon, 2007-03-05 at 16:25 -0800, Greg KH wrote: > Mike, I've reverted this patch, and I don't see any references leaking. > And, as your patch released the reference on the driver, and the > module_add_driver() call would not grab a reference to the driver, only > the module kobject, I don't

Re: kref refcounting breakage in mainline

2007-03-05 Thread Greg KH
On Fri, Mar 02, 2007 at 12:58:33AM -0800, Andrew Morton wrote: > > -mm has a debugging patch which warns when atomic_dec_and_test() takes an > atomic_t negative > (ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.20/2.6.20-mm2/broken-out/detect-atomic-counter-underflows.patch). >

Re: kref refcounting breakage in mainline

2007-03-05 Thread Greg KH
On Fri, Mar 02, 2007 at 12:58:33AM -0800, Andrew Morton wrote: -mm has a debugging patch which warns when atomic_dec_and_test() takes an atomic_t negative (ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.20/2.6.20-mm2/broken-out/detect-atomic-counter-underflows.patch).

Re: kref refcounting breakage in mainline

2007-03-05 Thread Mike Galbraith
On Mon, 2007-03-05 at 16:25 -0800, Greg KH wrote: Mike, I've reverted this patch, and I don't see any references leaking. And, as your patch released the reference on the driver, and the module_add_driver() call would not grab a reference to the driver, only the module kobject, I don't see

Re: kref refcounting breakage in mainline

2007-03-02 Thread Greg KH
On Fri, Mar 02, 2007 at 12:58:33AM -0800, Andrew Morton wrote: > > -mm has a debugging patch which warns when atomic_dec_and_test() takes an > atomic_t negative > (ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.20/2.6.20-mm2/broken-out/detect-atomic-counter-underflows.patch). >

kref refcounting breakage in mainline

2007-03-02 Thread Andrew Morton
-mm has a debugging patch which warns when atomic_dec_and_test() takes an atomic_t negative (ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.20/2.6.20-mm2/broken-out/detect-atomic-counter-underflows.patch). When it is applied to current mainline, a simple `rmmod ipw2200'

kref refcounting breakage in mainline

2007-03-02 Thread Andrew Morton
-mm has a debugging patch which warns when atomic_dec_and_test() takes an atomic_t negative (ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.20/2.6.20-mm2/broken-out/detect-atomic-counter-underflows.patch). When it is applied to current mainline, a simple `rmmod ipw2200'

Re: kref refcounting breakage in mainline

2007-03-02 Thread Greg KH
On Fri, Mar 02, 2007 at 12:58:33AM -0800, Andrew Morton wrote: -mm has a debugging patch which warns when atomic_dec_and_test() takes an atomic_t negative (ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.20/2.6.20-mm2/broken-out/detect-atomic-counter-underflows.patch).