Re: linux-next: Fixes tag needs some work in the scsi-fixes tree

2020-09-03 Thread Martin K. Petersen
Stephen, > Fixes: 320e77acb3 scsi: mpt3sas: Irq poll to avoid CPU hard lockups > Fixes: a6ffd5bf681 scsi: megaraid_sas: Call disable_irq from process IRQ > poll Ah, my regex missed the short SHAs due to the missing description quotation marks. Fixed my script and fixed up the commits.

linux-next: Fixes tag needs some work in the scsi-fixes tree

2020-09-03 Thread Stephen Rothwell
Hi all, In commit b614d55b970d ("scsi: mpt3sas: Don't call disable_irq from IRQ poll handler") Fixes tag Fixes: 320e77acb3 scsi: mpt3sas: Irq poll to avoid CPU hard lockups has these problem(s): - SHA1 should be at least 12 digits long In commit d2af39141eea ("scsi: megaraid_sas:

Re: linux-next: Fixes tag needs some work in the scsi-fixes tree

2020-06-24 Thread Stephen Rothwell
Hi SeongJae, On Wed, 24 Jun 2020 09:14:47 +0200 SeongJae Park wrote: > > Oops, sorry for the mistake. I will send the fixed version in reply to this. Unless Martin says otherwise, I am not sure it is worth fixing. Just remember for next time. -- Cheers, Stephen Rothwell pgpQ6W27QwTmT.pgp

Re: linux-next: Fixes tag needs some work in the scsi-fixes tree

2020-06-24 Thread SeongJae Park
On Wed, 24 Jun 2020 17:07:42 +1000 Stephen Rothwell wrote: > > [-- Attachment #1: Type: text/plain, Size: 385 bytes --] > > Hi all, > > In commit > > 46da547e21d6 ("scsi: lpfc: Avoid another null dereference in > lpfc_sli4_hba_unset()") > > Fixes tag > > Fixes: 1ffdd2c0440d ("scsi:

linux-next: Fixes tag needs some work in the scsi-fixes tree

2020-06-24 Thread Stephen Rothwell
Hi all, In commit 46da547e21d6 ("scsi: lpfc: Avoid another null dereference in lpfc_sli4_hba_unset()") Fixes tag Fixes: 1ffdd2c0440d ("scsi: lpfc: resolve static checker warning inlpfc_sli4_hba_unset") has these problem(s): - Subject does not match target commit subject Just use

Re: linux-next: Fixes tag needs some work in the scsi-fixes tree

2020-05-11 Thread Martin K. Petersen
Stephen, > Fixes: 4910b524ac9 ("scsi: qla2xxx: Add support for setting port speed") > > has these problem(s): > > - SHA1 should be at least 12 digits long I'm pretty good at spotting 8-digit SHAs but the 11 digits tripped me up in this case. I refined the SHA validation logic in my commit

linux-next: Fixes tag needs some work in the scsi-fixes tree

2020-05-08 Thread Stephen Rothwell
Hi all, In commit 0f3b2f3fb5dc ("scsi: qla2xxx: Do not log message when reading port speed via sysfs") Fixes tag Fixes: 4910b524ac9 ("scsi: qla2xxx: Add support for setting port speed") has these problem(s): - SHA1 should be at least 12 digits long Can be fixed by setting

Re: linux-next: Fixes tag needs some work in the scsi-fixes tree

2019-02-06 Thread Martin K. Petersen
Vaibhav, > Martin, should I resend the patch with this fixed ? No need, I fixed it up yesterday. -- Martin K. Petersen Oracle Linux Engineering

Re: linux-next: Fixes tag needs some work in the scsi-fixes tree

2019-02-05 Thread Stephen Rothwell
Hi Vaibhav, On Wed, 06 Feb 2019 09:25:12 +0530 Vaibhav Jain wrote: > > Martin, should I resend the patch with this fixed ? I wouldn't bother, it is a really picky report (I almost didn't send it) :-) Consider it just a reminder for next time. -- Cheers, Stephen Rothwell pgpwFIft3qTrz.pgp

Re: linux-next: Fixes tag needs some work in the scsi-fixes tree

2019-02-05 Thread Vaibhav Jain
Stephen Rothwell writes: > Hi Martin, > > In commit > > bb61b843ffd4 ("scsi: cxlflash: Prevent deadlock when adapter probe fails") > > Fixes tag > > Fixes: c21e0bbfc485("cxlflash: Base support for IBM CXL Flash Adapter") > > has these problem(s): > > - missing space between the SHA1 and

linux-next: Fixes tag needs some work in the scsi-fixes tree

2019-02-05 Thread Stephen Rothwell
Hi Martin, In commit bb61b843ffd4 ("scsi: cxlflash: Prevent deadlock when adapter probe fails") Fixes tag Fixes: c21e0bbfc485("cxlflash: Base support for IBM CXL Flash Adapter") has these problem(s): - missing space between the SHA1 and the subject -- Cheers, Stephen Rothwell

linux-next: Fixes tag needs some work in the scsi-fixes tree

2019-01-29 Thread Stephen Rothwell
Hi all, In commit b63195698dea ("scsi: zfcp: fix sysfs block queue limit output for max_segment_size") Fixes tag Fixes: 50c2e9107f ("scsi: introduce a max_segment_size host_template parameters") has these problem(s): - SHA1 should be at least 12 digits long -- Cheers, Stephen

linux-next: Fixes tag needs some work in the scsi-fixes tree

2019-01-22 Thread Stephen Rothwell
Hi Martin, In commit a8cf59a6692c ("scsi: communicate max segment size to the DMA mapping code") Fixes tag Fixes: 50c2e9107f ("scsi: introduce a max_segment_size host_template parameters") has these problem(s): - SHA1 should be at least 12 digits long -- Cheers, Stephen Rothwell