Re: md= broken. Found problem. Can't fix it. : (

2001-01-22 Thread Ingo Oeser
On Sat, Jan 20, 2001 at 11:28:51PM +0100, Andi Kleen wrote: > On Sat, Jan 20, 2001 at 04:58:56PM -0500, Sandy Harris wrote: > > I suspect that I've misunderstood some constraint here. Perhaps the more complex > > code you posted is necessary, but I'd like to know why. > > strtok is not reentrant

Re: md= broken. Found problem. Can't fix it. : (

2001-01-22 Thread Ingo Oeser
On Sat, Jan 20, 2001 at 11:28:51PM +0100, Andi Kleen wrote: On Sat, Jan 20, 2001 at 04:58:56PM -0500, Sandy Harris wrote: I suspect that I've misunderstood some constraint here. Perhaps the more complex code you posted is necessary, but I'd like to know why. strtok is not reentrant and

Re: md= broken. Found problem. Can't fix it. : (

2001-01-20 Thread Dave Cinege
Douglas Gilbert wrote: > > Dave, > Look at the dmesg output and check that your > "Kernel command line:" is what you think it > is. Some older versions of lilo truncate it. > Here is mine (which is what I expected): > > Kernel command line: auto BOOT_IMAGE=lin240 ro root=803

Re: md= broken. Found problem. Can't fix it. : (

2001-01-20 Thread Dave Cinege
Sandy Harris wrote: > Looks to me like this parsing code unnecessarily and rather clumsily > re-invents strtok The original parsing code is this: if ((str = strchr(str, ',')) != NULL) str++; Which effectivly steps through

Re: md= broken. Found problem. Can't fix it. : (

2001-01-20 Thread Andi Kleen
On Sat, Jan 20, 2001 at 04:58:56PM -0500, Sandy Harris wrote: > I suspect that I've misunderstood some constraint here. Perhaps the more complex > code you posted is necessary, but I'd like to know why. strtok is not reentrant and cannot be nested this way without saving __strtok. strsep would

Re: md= broken. Found problem. Can't fix it. : (

2001-01-20 Thread Sandy Harris
Dave Cinege wrote: > > ... 'md=' for each device on > the cmdline, but unfortuantly it's broken. > > Between a few emails to mingo and several wasted hours, I've managed to figure > out the problem. However I don't know how to fix it; it *should* > be working from what I can see. > > My only

md= broken. Found problem. Can't fix it. : (

2001-01-20 Thread Dave Cinege
I have multiple Linux hosts on a SAN, making autodetect of raid devices dangerous. This problem should be solved by specing an 'md=' for each device on the cmdline, but unfortuantly it's broken. Between a few emails to mingo and several wasted hours, I've managed to figure out the problem.

md= broken. Found problem. Can't fix it. : (

2001-01-20 Thread Dave Cinege
I have multiple Linux hosts on a SAN, making autodetect of raid devices dangerous. This problem should be solved by specing an 'md=' for each device on the cmdline, but unfortuantly it's broken. Between a few emails to mingo and several wasted hours, I've managed to figure out the problem.

Re: md= broken. Found problem. Can't fix it. : (

2001-01-20 Thread Sandy Harris
Dave Cinege wrote: ... 'md=' for each device on the cmdline, but unfortuantly it's broken. Between a few emails to mingo and several wasted hours, I've managed to figure out the problem. However I don't know how to fix it; it *should* be working from what I can see. My only guess

Re: md= broken. Found problem. Can't fix it. : (

2001-01-20 Thread Andi Kleen
On Sat, Jan 20, 2001 at 04:58:56PM -0500, Sandy Harris wrote: I suspect that I've misunderstood some constraint here. Perhaps the more complex code you posted is necessary, but I'd like to know why. strtok is not reentrant and cannot be nested this way without saving __strtok. strsep would

Re: md= broken. Found problem. Can't fix it. : (

2001-01-20 Thread Dave Cinege
Sandy Harris wrote: Looks to me like this parsing code unnecessarily and rather clumsily re-invents strtok The original parsing code is this: if ((str = strchr(str, ',')) != NULL) str++; Which effectivly steps through

Re: md= broken. Found problem. Can't fix it. : (

2001-01-20 Thread Dave Cinege
Douglas Gilbert wrote: Dave, Look at the dmesg output and check that your "Kernel command line:" is what you think it is. Some older versions of lilo truncate it. Here is mine (which is what I expected): Kernel command line: auto BOOT_IMAGE=lin240 ro root=803 scsihosts=imm:advansys:a