Re: mm, we use rcu access task_struct in mm_match_cgroup(), but not use rcu free in free_task_struct()

2017-05-24 Thread Michal Hocko
On Wed 24-05-17 16:04:20, Xishi Qiu wrote: > On 2017/5/24 15:49, Vlastimil Babka wrote: > > > On 05/24/2017 06:40 AM, Xishi Qiu wrote: > >> On 2017/5/24 9:40, Xishi Qiu wrote: > >> > >>> Hi, I find we use rcu access task_struct in mm_match_cgroup(), but not use > >>> rcu free in free_task_struct()

Re: mm, we use rcu access task_struct in mm_match_cgroup(), but not use rcu free in free_task_struct()

2017-05-24 Thread Xishi Qiu
On 2017/5/24 15:49, Vlastimil Babka wrote: > On 05/24/2017 06:40 AM, Xishi Qiu wrote: >> On 2017/5/24 9:40, Xishi Qiu wrote: >> >>> Hi, I find we use rcu access task_struct in mm_match_cgroup(), but not use >>> rcu free in free_task_struct(), is it right? >>> >>> Here is the backtrace. > > Can yo

Re: mm, we use rcu access task_struct in mm_match_cgroup(), but not use rcu free in free_task_struct()

2017-05-24 Thread Vlastimil Babka
On 05/24/2017 06:40 AM, Xishi Qiu wrote: > On 2017/5/24 9:40, Xishi Qiu wrote: > >> Hi, I find we use rcu access task_struct in mm_match_cgroup(), but not use >> rcu free in free_task_struct(), is it right? >> >> Here is the backtrace. Can you post the whole oops, including kernel version etc? Is

Re: mm, we use rcu access task_struct in mm_match_cgroup(), but not use rcu free in free_task_struct()

2017-05-23 Thread Xishi Qiu
On 2017/5/24 9:40, Xishi Qiu wrote: > Hi, I find we use rcu access task_struct in mm_match_cgroup(), but not use > rcu free in free_task_struct(), is it right? > > Here is the backtrace. > > PID: 2133 TASK: 881fe3353300 CPU: 2 COMMAND: "CPU 15/KVM" > #0 [881fe276b528] machine_kexec

mm, we use rcu access task_struct in mm_match_cgroup(), but not use rcu free in free_task_struct()

2017-05-23 Thread Xishi Qiu
Hi, I find we use rcu access task_struct in mm_match_cgroup(), but not use rcu free in free_task_struct(), is it right? Here is the backtrace. PID: 2133 TASK: 881fe3353300 CPU: 2 COMMAND: "CPU 15/KVM" #0 [881fe276b528] machine_kexec at 8105280b #1 [881fe276b588] crash_k