[PATCH 3.11 56/66] mm: fix BUG in __split_huge_page_pmd

2013-11-01 Thread Greg Kroah-Hartman
3.11-stable review patch. If anyone has any objections, please let me know. -- From: Hugh Dickins commit 750e8165f5e87b6a142be953640eabb13a9d350a upstream. Occasionally we hit the BUG_ON(pmd_trans_huge(*pmd)) at the end of __split_huge_page_pmd(): seen when doing

[PATCH 3.10 46/54] mm: fix BUG in __split_huge_page_pmd

2013-11-01 Thread Greg Kroah-Hartman
3.10-stable review patch. If anyone has any objections, please let me know. -- From: Hugh Dickins commit 750e8165f5e87b6a142be953640eabb13a9d350a upstream. Occasionally we hit the BUG_ON(pmd_trans_huge(*pmd)) at the end of __split_huge_page_pmd(): seen when doing

[PATCH 3.10 46/54] mm: fix BUG in __split_huge_page_pmd

2013-11-01 Thread Greg Kroah-Hartman
3.10-stable review patch. If anyone has any objections, please let me know. -- From: Hugh Dickins hu...@google.com commit 750e8165f5e87b6a142be953640eabb13a9d350a upstream. Occasionally we hit the BUG_ON(pmd_trans_huge(*pmd)) at the end of __split_huge_page_pmd(): seen when

[PATCH 3.11 56/66] mm: fix BUG in __split_huge_page_pmd

2013-11-01 Thread Greg Kroah-Hartman
3.11-stable review patch. If anyone has any objections, please let me know. -- From: Hugh Dickins hu...@google.com commit 750e8165f5e87b6a142be953640eabb13a9d350a upstream. Occasionally we hit the BUG_ON(pmd_trans_huge(*pmd)) at the end of __split_huge_page_pmd(): seen when

[PATCH 3.8 81/81] mm: fix BUG in __split_huge_page_pmd

2013-10-29 Thread Kamal Mostafa
3.8.13.12 -stable review patch. If anyone has any objections, please let me know. -- From: Hugh Dickins commit 750e8165f5e87b6a142be953640eabb13a9d350a upstream. Occasionally we hit the BUG_ON(pmd_trans_huge(*pmd)) at the end of __split_huge_page_pmd(): seen when doing

[PATCH 3.8 81/81] mm: fix BUG in __split_huge_page_pmd

2013-10-29 Thread Kamal Mostafa
3.8.13.12 -stable review patch. If anyone has any objections, please let me know. -- From: Hugh Dickins hu...@google.com commit 750e8165f5e87b6a142be953640eabb13a9d350a upstream. Occasionally we hit the BUG_ON(pmd_trans_huge(*pmd)) at the end of __split_huge_page_pmd(): seen

Re: mm: fix BUG in __split_huge_page_pmd

2013-10-15 Thread Andrea Arcangeli
On Tue, Oct 15, 2013 at 04:16:23PM -0400, Naoya Horiguchi wrote: > On Tue, Oct 15, 2013 at 09:44:28PM +0200, Andrea Arcangeli wrote: > > On Tue, Oct 15, 2013 at 03:28:50PM -0400, Naoya Horiguchi wrote: > > > On Tue, Oct 15, 2013 at 08:55:10PM +0200, Andrea Arcangeli wrote: > > > > On Tue, Oct 15,

Re: mm: fix BUG in __split_huge_page_pmd

2013-10-15 Thread Naoya Horiguchi
On Tue, Oct 15, 2013 at 09:44:28PM +0200, Andrea Arcangeli wrote: > On Tue, Oct 15, 2013 at 03:28:50PM -0400, Naoya Horiguchi wrote: > > On Tue, Oct 15, 2013 at 08:55:10PM +0200, Andrea Arcangeli wrote: > > > On Tue, Oct 15, 2013 at 10:53:10AM -0700, Hugh Dickins wrote: > > > > I'm afraid Andrea's

Re: mm: fix BUG in __split_huge_page_pmd

2013-10-15 Thread Andrea Arcangeli
On Tue, Oct 15, 2013 at 03:28:50PM -0400, Naoya Horiguchi wrote: > On Tue, Oct 15, 2013 at 08:55:10PM +0200, Andrea Arcangeli wrote: > > On Tue, Oct 15, 2013 at 10:53:10AM -0700, Hugh Dickins wrote: > > > I'm afraid Andrea's mail about concurrent madvises gives me far more > > > to think about

Re: mm: fix BUG in __split_huge_page_pmd

2013-10-15 Thread Naoya Horiguchi
On Tue, Oct 15, 2013 at 08:55:10PM +0200, Andrea Arcangeli wrote: > On Tue, Oct 15, 2013 at 10:53:10AM -0700, Hugh Dickins wrote: > > I'm afraid Andrea's mail about concurrent madvises gives me far more > > to think about than I have time for: seems to get into problems he > > knows a lot about

Re: mm: fix BUG in __split_huge_page_pmd

2013-10-15 Thread Andrea Arcangeli
On Tue, Oct 15, 2013 at 10:53:10AM -0700, Hugh Dickins wrote: > I'm afraid Andrea's mail about concurrent madvises gives me far more > to think about than I have time for: seems to get into problems he > knows a lot about but I'm unfamiliar with. If this patch looks good > for now on its own,

Re: mm: fix BUG in __split_huge_page_pmd

2013-10-15 Thread Hugh Dickins
On Tue, 15 Oct 2013, Kirill A. Shutemov wrote: > Andrea Arcangeli wrote: > > Hi Hugh, > > > > On Tue, Oct 15, 2013 at 04:08:28AM -0700, Hugh Dickins wrote: > > > Occasionally we hit the BUG_ON(pmd_trans_huge(*pmd)) at the end of > > > __split_huge_page_pmd(): seen when doing

Re: mm: fix BUG in __split_huge_page_pmd

2013-10-15 Thread Andrea Arcangeli
On Tue, Oct 15, 2013 at 05:48:27PM +0300, Kirill A. Shutemov wrote: > Andrea Arcangeli wrote: > > Hi Hugh, > > > > On Tue, Oct 15, 2013 at 04:08:28AM -0700, Hugh Dickins wrote: > > > Occasionally we hit the BUG_ON(pmd_trans_huge(*pmd)) at the end of > > > __split_huge_page_pmd(): seen when doing

Re: mm: fix BUG in __split_huge_page_pmd

2013-10-15 Thread Kirill A. Shutemov
Andrea Arcangeli wrote: > Hi Hugh, > > On Tue, Oct 15, 2013 at 04:08:28AM -0700, Hugh Dickins wrote: > > Occasionally we hit the BUG_ON(pmd_trans_huge(*pmd)) at the end of > > __split_huge_page_pmd(): seen when doing madvise(,,MADV_DONTNEED). > > > > It's invalid: we don't always have down_write

Re: mm: fix BUG in __split_huge_page_pmd

2013-10-15 Thread Andrea Arcangeli
On Tue, Oct 15, 2013 at 02:32:54PM +0300, Kirill A. Shutemov wrote: > Hugh Dickins wrote: > > Occasionally we hit the BUG_ON(pmd_trans_huge(*pmd)) at the end of > > __split_huge_page_pmd(): seen when doing madvise(,,MADV_DONTNEED). > > > > It's invalid: we don't always have down_write of mmap_sem

Re: mm: fix BUG in __split_huge_page_pmd

2013-10-15 Thread Andrea Arcangeli
Hi Hugh, On Tue, Oct 15, 2013 at 04:08:28AM -0700, Hugh Dickins wrote: > Occasionally we hit the BUG_ON(pmd_trans_huge(*pmd)) at the end of > __split_huge_page_pmd(): seen when doing madvise(,,MADV_DONTNEED). > > It's invalid: we don't always have down_write of mmap_sem there: > a racing

RE: mm: fix BUG in __split_huge_page_pmd

2013-10-15 Thread Kirill A. Shutemov
Hugh Dickins wrote: > Occasionally we hit the BUG_ON(pmd_trans_huge(*pmd)) at the end of > __split_huge_page_pmd(): seen when doing madvise(,,MADV_DONTNEED). > > It's invalid: we don't always have down_write of mmap_sem there: > a racing do_huge_pmd_wp_page() might have copied-on-write to another

mm: fix BUG in __split_huge_page_pmd

2013-10-15 Thread Hugh Dickins
Occasionally we hit the BUG_ON(pmd_trans_huge(*pmd)) at the end of __split_huge_page_pmd(): seen when doing madvise(,,MADV_DONTNEED). It's invalid: we don't always have down_write of mmap_sem there: a racing do_huge_pmd_wp_page() might have copied-on-write to another huge page before our

mm: fix BUG in __split_huge_page_pmd

2013-10-15 Thread Hugh Dickins
Occasionally we hit the BUG_ON(pmd_trans_huge(*pmd)) at the end of __split_huge_page_pmd(): seen when doing madvise(,,MADV_DONTNEED). It's invalid: we don't always have down_write of mmap_sem there: a racing do_huge_pmd_wp_page() might have copied-on-write to another huge page before our

RE: mm: fix BUG in __split_huge_page_pmd

2013-10-15 Thread Kirill A. Shutemov
Hugh Dickins wrote: Occasionally we hit the BUG_ON(pmd_trans_huge(*pmd)) at the end of __split_huge_page_pmd(): seen when doing madvise(,,MADV_DONTNEED). It's invalid: we don't always have down_write of mmap_sem there: a racing do_huge_pmd_wp_page() might have copied-on-write to another

Re: mm: fix BUG in __split_huge_page_pmd

2013-10-15 Thread Andrea Arcangeli
Hi Hugh, On Tue, Oct 15, 2013 at 04:08:28AM -0700, Hugh Dickins wrote: Occasionally we hit the BUG_ON(pmd_trans_huge(*pmd)) at the end of __split_huge_page_pmd(): seen when doing madvise(,,MADV_DONTNEED). It's invalid: we don't always have down_write of mmap_sem there: a racing

Re: mm: fix BUG in __split_huge_page_pmd

2013-10-15 Thread Andrea Arcangeli
On Tue, Oct 15, 2013 at 02:32:54PM +0300, Kirill A. Shutemov wrote: Hugh Dickins wrote: Occasionally we hit the BUG_ON(pmd_trans_huge(*pmd)) at the end of __split_huge_page_pmd(): seen when doing madvise(,,MADV_DONTNEED). It's invalid: we don't always have down_write of mmap_sem there:

Re: mm: fix BUG in __split_huge_page_pmd

2013-10-15 Thread Kirill A. Shutemov
Andrea Arcangeli wrote: Hi Hugh, On Tue, Oct 15, 2013 at 04:08:28AM -0700, Hugh Dickins wrote: Occasionally we hit the BUG_ON(pmd_trans_huge(*pmd)) at the end of __split_huge_page_pmd(): seen when doing madvise(,,MADV_DONTNEED). It's invalid: we don't always have down_write of

Re: mm: fix BUG in __split_huge_page_pmd

2013-10-15 Thread Andrea Arcangeli
On Tue, Oct 15, 2013 at 05:48:27PM +0300, Kirill A. Shutemov wrote: Andrea Arcangeli wrote: Hi Hugh, On Tue, Oct 15, 2013 at 04:08:28AM -0700, Hugh Dickins wrote: Occasionally we hit the BUG_ON(pmd_trans_huge(*pmd)) at the end of __split_huge_page_pmd(): seen when doing

Re: mm: fix BUG in __split_huge_page_pmd

2013-10-15 Thread Hugh Dickins
On Tue, 15 Oct 2013, Kirill A. Shutemov wrote: Andrea Arcangeli wrote: Hi Hugh, On Tue, Oct 15, 2013 at 04:08:28AM -0700, Hugh Dickins wrote: Occasionally we hit the BUG_ON(pmd_trans_huge(*pmd)) at the end of __split_huge_page_pmd(): seen when doing madvise(,,MADV_DONTNEED).

Re: mm: fix BUG in __split_huge_page_pmd

2013-10-15 Thread Andrea Arcangeli
On Tue, Oct 15, 2013 at 10:53:10AM -0700, Hugh Dickins wrote: I'm afraid Andrea's mail about concurrent madvises gives me far more to think about than I have time for: seems to get into problems he knows a lot about but I'm unfamiliar with. If this patch looks good for now on its own, let's

Re: mm: fix BUG in __split_huge_page_pmd

2013-10-15 Thread Naoya Horiguchi
On Tue, Oct 15, 2013 at 08:55:10PM +0200, Andrea Arcangeli wrote: On Tue, Oct 15, 2013 at 10:53:10AM -0700, Hugh Dickins wrote: I'm afraid Andrea's mail about concurrent madvises gives me far more to think about than I have time for: seems to get into problems he knows a lot about but I'm

Re: mm: fix BUG in __split_huge_page_pmd

2013-10-15 Thread Andrea Arcangeli
On Tue, Oct 15, 2013 at 03:28:50PM -0400, Naoya Horiguchi wrote: On Tue, Oct 15, 2013 at 08:55:10PM +0200, Andrea Arcangeli wrote: On Tue, Oct 15, 2013 at 10:53:10AM -0700, Hugh Dickins wrote: I'm afraid Andrea's mail about concurrent madvises gives me far more to think about than I have

Re: mm: fix BUG in __split_huge_page_pmd

2013-10-15 Thread Naoya Horiguchi
On Tue, Oct 15, 2013 at 09:44:28PM +0200, Andrea Arcangeli wrote: On Tue, Oct 15, 2013 at 03:28:50PM -0400, Naoya Horiguchi wrote: On Tue, Oct 15, 2013 at 08:55:10PM +0200, Andrea Arcangeli wrote: On Tue, Oct 15, 2013 at 10:53:10AM -0700, Hugh Dickins wrote: I'm afraid Andrea's mail

Re: mm: fix BUG in __split_huge_page_pmd

2013-10-15 Thread Andrea Arcangeli
On Tue, Oct 15, 2013 at 04:16:23PM -0400, Naoya Horiguchi wrote: On Tue, Oct 15, 2013 at 09:44:28PM +0200, Andrea Arcangeli wrote: On Tue, Oct 15, 2013 at 03:28:50PM -0400, Naoya Horiguchi wrote: On Tue, Oct 15, 2013 at 08:55:10PM +0200, Andrea Arcangeli wrote: On Tue, Oct 15, 2013 at