Re: mm: fix typo of cache_alloc_zspage()

Hello, On (12/29/16 18:34), Xishi Qiu wrote: > Hi, Minchan and Sergey, > > OK, but I will have a vacation soon, so could you just add > that typo in your patch? or I will resend v3 several days later. works for me. the patch is trivial, so I definitely can wait for v3. if there is a chance to

Re: mm: fix typo of cache_alloc_zspage()

Hello, On (12/29/16 18:34), Xishi Qiu wrote: > Hi, Minchan and Sergey, > > OK, but I will have a vacation soon, so could you just add > that typo in your patch? or I will resend v3 several days later. works for me. the patch is trivial, so I definitely can wait for v3. if there is a chance to

Re: mm: fix typo of cache_alloc_zspage()

On 2016/12/29 15:56, Minchan Kim wrote: > On Thu, Dec 29, 2016 at 04:34:03PM +0900, Sergey Senozhatsky wrote: >> Hello, >> >> On (12/29/16 15:59), Minchan Kim wrote: >> [..] I don't know... do we want to have it as a separate patch? may be we can fold it into some other patch someday

Re: mm: fix typo of cache_alloc_zspage()

On 2016/12/29 15:56, Minchan Kim wrote: > On Thu, Dec 29, 2016 at 04:34:03PM +0900, Sergey Senozhatsky wrote: >> Hello, >> >> On (12/29/16 15:59), Minchan Kim wrote: >> [..] I don't know... do we want to have it as a separate patch? may be we can fold it into some other patch someday

Re: mm: fix typo of cache_alloc_zspage()

On (12/29/16 16:56), Minchan Kim wrote: > > for instance, we can have Xishi's fix up as part of this "fix documentation > > typos" patch. which can be counted in as trivial. > > Xishi, Could you send your patch with fixing ones Sergey pointed out > if Sergey doesn't mind? I don't. Reviewed-by:

Re: mm: fix typo of cache_alloc_zspage()

On (12/29/16 16:56), Minchan Kim wrote: > > for instance, we can have Xishi's fix up as part of this "fix documentation > > typos" patch. which can be counted in as trivial. > > Xishi, Could you send your patch with fixing ones Sergey pointed out > if Sergey doesn't mind? I don't. Reviewed-by:

Re: mm: fix typo of cache_alloc_zspage()

On Thu, Dec 29, 2016 at 04:34:03PM +0900, Sergey Senozhatsky wrote: > Hello, > > On (12/29/16 15:59), Minchan Kim wrote: > [..] > > > I don't know... do we want to have it as a separate patch? > > > may be we can fold it into some other patch someday later. > > > > Xishi spent his time to make

Re: mm: fix typo of cache_alloc_zspage()

On Thu, Dec 29, 2016 at 04:34:03PM +0900, Sergey Senozhatsky wrote: > Hello, > > On (12/29/16 15:59), Minchan Kim wrote: > [..] > > > I don't know... do we want to have it as a separate patch? > > > may be we can fold it into some other patch someday later. > > > > Xishi spent his time to make

[PATCH V2] mm: fix typo of cache_alloc_zspage()

Delete extra semicolon, it was introduced in 3783689 zsmalloc: introduce zspage structure Signed-off-by: Xishi Qiu --- mm/zsmalloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c index 9cc3c0b..2d6c92e 100644 ---

[PATCH V2] mm: fix typo of cache_alloc_zspage()

Delete extra semicolon, it was introduced in 3783689 zsmalloc: introduce zspage structure Signed-off-by: Xishi Qiu --- mm/zsmalloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c index 9cc3c0b..2d6c92e 100644 --- a/mm/zsmalloc.c +++

Re: mm: fix typo of cache_alloc_zspage()

Hello, On (12/29/16 15:59), Minchan Kim wrote: [..] > > I don't know... do we want to have it as a separate patch? > > may be we can fold it into some other patch someday later. > > Xishi spent his time to make the patch(review,create/send). And I want to > give a credit to him. :) sure, I

Re: mm: fix typo of cache_alloc_zspage()

Hello, On (12/29/16 15:59), Minchan Kim wrote: [..] > > I don't know... do we want to have it as a separate patch? > > may be we can fold it into some other patch someday later. > > Xishi spent his time to make the patch(review,create/send). And I want to > give a credit to him. :) sure, I

Re: mm: fix typo of cache_alloc_zspage()

Hi Sergey, On Thu, Dec 29, 2016 at 03:52:05PM +0900, Sergey Senozhatsky wrote: > On (12/29/16 15:44), Minchan Kim wrote: > > On Thu, Dec 29, 2016 at 10:06:47AM +0800, Xishi Qiu wrote: > > > Signed-off-by: Xishi Qiu > > > --- > > > mm/zsmalloc.c | 2 +- > > > 1 file changed,

Re: mm: fix typo of cache_alloc_zspage()

Hi Sergey, On Thu, Dec 29, 2016 at 03:52:05PM +0900, Sergey Senozhatsky wrote: > On (12/29/16 15:44), Minchan Kim wrote: > > On Thu, Dec 29, 2016 at 10:06:47AM +0800, Xishi Qiu wrote: > > > Signed-off-by: Xishi Qiu > > > --- > > > mm/zsmalloc.c | 2 +- > > > 1 file changed, 1 insertion(+), 1

Re: mm: fix typo of cache_alloc_zspage()

On (12/29/16 15:44), Minchan Kim wrote: > On Thu, Dec 29, 2016 at 10:06:47AM +0800, Xishi Qiu wrote: > > Signed-off-by: Xishi Qiu > > --- > > mm/zsmalloc.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c > > index

Re: mm: fix typo of cache_alloc_zspage()

On (12/29/16 15:44), Minchan Kim wrote: > On Thu, Dec 29, 2016 at 10:06:47AM +0800, Xishi Qiu wrote: > > Signed-off-by: Xishi Qiu > > --- > > mm/zsmalloc.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c > > index 9cc3c0b..2d6c92e

Re: mm: fix typo of cache_alloc_zspage()

On Thu, Dec 29, 2016 at 10:06:47AM +0800, Xishi Qiu wrote: > Signed-off-by: Xishi Qiu > --- > mm/zsmalloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c > index 9cc3c0b..2d6c92e 100644 > --- a/mm/zsmalloc.c > +++

Re: mm: fix typo of cache_alloc_zspage()

On Thu, Dec 29, 2016 at 10:06:47AM +0800, Xishi Qiu wrote: > Signed-off-by: Xishi Qiu > --- > mm/zsmalloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c > index 9cc3c0b..2d6c92e 100644 > --- a/mm/zsmalloc.c > +++ b/mm/zsmalloc.c > @@

mm: fix typo of cache_alloc_zspage()

Signed-off-by: Xishi Qiu --- mm/zsmalloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c index 9cc3c0b..2d6c92e 100644 --- a/mm/zsmalloc.c +++ b/mm/zsmalloc.c @@ -364,7 +364,7 @@ static struct zspage

mm: fix typo of cache_alloc_zspage()

Signed-off-by: Xishi Qiu --- mm/zsmalloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c index 9cc3c0b..2d6c92e 100644 --- a/mm/zsmalloc.c +++ b/mm/zsmalloc.c @@ -364,7 +364,7 @@ static struct zspage *cache_alloc_zspage(struct zs_pool *pool,