Re: [PATCH 1/9] kbuild: remove unneeded mkdir for external modules_install

2021-04-07 Thread Masahiro Yamada
a/Makefile b/Makefile > index ed8bd815e8a3..0e06db5ed9d8 100644 > --- a/Makefile > +++ b/Makefile > @@ -1779,10 +1779,8 @@ $(MODORDER): descend > PHONY += modules_install > modules_install: _emodinst_ _emodinst_post > > -install-dir := $(if $(INSTALL_MOD_DIR),$(INSTALL_MOD_DIR),extr

[PATCH 1/9] kbuild: remove unneeded mkdir for external modules_install

2021-03-31 Thread Masahiro Yamada
+= modules_install modules_install: _emodinst_ _emodinst_post -install-dir := $(if $(INSTALL_MOD_DIR),$(INSTALL_MOD_DIR),extra) PHONY += _emodinst_ _emodinst_: - $(Q)mkdir -p $(MODLIB)/$(install-dir) $(Q)$(MAKE) -f $(srctree)/scripts/Makefile.modinst PHONY += _emodinst_post

Re: [PATCH] Revert "modsign: Abort modules_install when signing fails"

2019-03-16 Thread Masahiro Yamada
On Sat, Mar 16, 2019 at 1:25 AM Douglas Anderson wrote: > > This reverts commit caf6fe91ddf62a96401e21e9b7a07227440f4185. > > The commit was fine but is no longer needed as of commit 3a2429e1faf4 > ("kbuild: change if_changed_rule for multi-line recipe"). Let's go > back to using ";" to be

[PATCH] Revert "modsign: Abort modules_install when signing fails"

2019-03-15 Thread Douglas Anderson
This reverts commit caf6fe91ddf62a96401e21e9b7a07227440f4185. The commit was fine but is no longer needed as of commit 3a2429e1faf4 ("kbuild: change if_changed_rule for multi-line recipe"). Let's go back to using ";" to be consistent. For some discussion, see:

Re: [PATCH] kbuild: Speed up install, modules_install and kernelrelease

2019-03-11 Thread Doug Anderson
ith less complexity. > > > > > > > > Specifically I observed that by timing the parsing stage of the > > > > Makefile by adding statements like this to the beginning and end of > > > > the Makefile: > > > > ZZZ := $(shell echo "$$(dat

Re: [PATCH] kbuild: Speed up install, modules_install and kernelrelease

2019-03-08 Thread Masahiro Yamada
> the Makefile: > > > ZZZ := $(shell echo "$$(date '+%T.%N'): ..." >> /tmp/timing.txt) > > > > > > ...that three targets were spending 3 seconds each parsing the > > > Makefile in my environment (building a Chrome OS kernel with clang) > &

Re: [PATCH] kbuild: Speed up install, modules_install and kernelrelease

2019-03-08 Thread Doug Anderson
e of the > > Makefile by adding statements like this to the beginning and end of > > the Makefile: > > ZZZ := $(shell echo "$$(date '+%T.%N'): ..." >> /tmp/timing.txt) > > > > ...that three targets were spending 3 seconds each parsing the > > Makef

Re: [PATCH] kbuild: Speed up install, modules_install and kernelrelease

2019-03-08 Thread Guenter Roeck
xt) > > ...that three targets were spending 3 seconds each parsing the > Makefile in my environment (building a Chrome OS kernel with clang) > when it felt like they ought to be quick. These were: install, > modules_install and kernelrelease > > I saw timings that

[PATCH] kbuild: Speed up install, modules_install and kernelrelease

2019-03-08 Thread Douglas Anderson
this to the beginning and end of the Makefile: ZZZ := $(shell echo "$$(date '+%T.%N'): ..." >> /tmp/timing.txt) ...that three targets were spending 3 seconds each parsing the Makefile in my environment (building a Chrome OS kernel with clang) when it felt like they ought to b

Re: make modules_install install is failing

2019-03-04 Thread Tobin C. Harding
On Tue, Feb 05, 2019 at 11:30:53AM +0530, Bharath Vedartham wrote: > Hi all, > > I am unable to execute make modules_install install. > I get the following error: Could you show the complete commands you are trying please thanks, Tobin.

make modules_install install is failing

2019-02-04 Thread Bharath Vedartham
Hi all, I am unable to execute make modules_install install. I get the following error: ln: target 'linux-00096-gd1aa1a8/source' is not a directory Makefile:1281: recipe for target '_modinst_' failed make[1]: *** [_modinst_] Error 1 Makefile:296: recipe for target '__build_one_by_one' failed

Re: [PATCH v2] modules_install: warn when missing System.map file

2018-09-09 Thread Masahiro Yamada
2018-09-07 8:37 GMT+09:00 Randy Dunlap : > From: Randy Dunlap > > If there is no System.map file for "make modules_install", > scripts/depmod.sh will silently exit with success, having done > nothing. Since this is an unexpected situation, change it to > report a

Re: [PATCH v2] modules_install: warn when missing System.map file

2018-09-09 Thread Masahiro Yamada
2018-09-07 8:37 GMT+09:00 Randy Dunlap : > From: Randy Dunlap > > If there is no System.map file for "make modules_install", > scripts/depmod.sh will silently exit with success, having done > nothing. Since this is an unexpected situation, change it to > report a

[PATCH v2] modules_install: warn when missing System.map file

2018-09-06 Thread Randy Dunlap
From: Randy Dunlap If there is no System.map file for "make modules_install", scripts/depmod.sh will silently exit with success, having done nothing. Since this is an unexpected situation, change it to report a Warning for the missing file. The behavior is not changed except for t

[PATCH v2] modules_install: warn when missing System.map file

2018-09-06 Thread Randy Dunlap
From: Randy Dunlap If there is no System.map file for "make modules_install", scripts/depmod.sh will silently exit with success, having done nothing. Since this is an unexpected situation, change it to report a Warning for the missing file. The behavior is not changed except for t

Re: [PATCH] kbuild: modules_install: Warn if System.map file is not found

2018-09-05 Thread Randy Dunlap
On 09/05/2018 12:17 AM, Masahiro Yamada wrote: > Hi Randy, > > 2018-09-01 7:33 GMT+09:00 Randy Dunlap : >> From: Randy Dunlap >> >> If there is no System.map file for "make modules_install", >> scripts/depmod.sh will silently exit w

Re: [PATCH] kbuild: modules_install: Warn if System.map file is not found

2018-09-05 Thread Randy Dunlap
On 09/05/2018 12:17 AM, Masahiro Yamada wrote: > Hi Randy, > > 2018-09-01 7:33 GMT+09:00 Randy Dunlap : >> From: Randy Dunlap >> >> If there is no System.map file for "make modules_install", >> scripts/depmod.sh will silently exit w

Re: [PATCH] kbuild: modules_install: Warn if System.map file is not found

2018-09-05 Thread Masahiro Yamada
Hi Randy, 2018-09-01 7:33 GMT+09:00 Randy Dunlap : > From: Randy Dunlap > > If there is no System.map file for "make modules_install", > scripts/depmod.sh will silently exit with success, having done > nothing. Since this is an unexpected situation, change

Re: [PATCH] kbuild: modules_install: Warn if System.map file is not found

2018-09-05 Thread Masahiro Yamada
Hi Randy, 2018-09-01 7:33 GMT+09:00 Randy Dunlap : > From: Randy Dunlap > > If there is no System.map file for "make modules_install", > scripts/depmod.sh will silently exit with success, having done > nothing. Since this is an unexpected situation, change

[PATCH] kbuild: modules_install: Warn if System.map file is not found

2018-08-31 Thread Randy Dunlap
From: Randy Dunlap If there is no System.map file for "make modules_install", scripts/depmod.sh will silently exit with success, having done nothing. Since this is an unexpected situation, change it to report a Warning for the missing file. The behavior is not changed except for t

[PATCH] kbuild: modules_install: Warn if System.map file is not found

2018-08-31 Thread Randy Dunlap
From: Randy Dunlap If there is no System.map file for "make modules_install", scripts/depmod.sh will silently exit with success, having done nothing. Since this is an unexpected situation, change it to report a Warning for the missing file. The behavior is not changed except for t

Re: [PATCH v4] modules_install: make missing $DEPMOD a Warning instead of an Error

2018-08-31 Thread Masahiro Yamada
2018-08-29 4:59 GMT+09:00 Randy Dunlap : > From: Randy Dunlap > > When $DEPMOD is not found, only print a warning instead of exiting > with an error message and error status: > > Warning: 'make modules_install' requires /sbin/depmod. Please install it. > This is probabl

Re: [PATCH v4] modules_install: make missing $DEPMOD a Warning instead of an Error

2018-08-31 Thread Masahiro Yamada
2018-08-29 4:59 GMT+09:00 Randy Dunlap : > From: Randy Dunlap > > When $DEPMOD is not found, only print a warning instead of exiting > with an error message and error status: > > Warning: 'make modules_install' requires /sbin/depmod. Please install it. > This is probabl

Re: [PATCH v3] modules_install: make missing $DEPMOD a warning instead of an error

2018-08-28 Thread Masahiro Yamada
; > > Added for v4. Thanks. >> BTW, if System.map is missing, depmod is silently skipped. >> >> >> I think if System.map is missing, a user is doing something wrong, >> but you could do like this: >> >> $ make mrproper >>[snip] &g

Re: [PATCH v3] modules_install: make missing $DEPMOD a warning instead of an error

2018-08-28 Thread Masahiro Yamada
; > > Added for v4. Thanks. >> BTW, if System.map is missing, depmod is silently skipped. >> >> >> I think if System.map is missing, a user is doing something wrong, >> but you could do like this: >> >> $ make mrproper >>[snip] &g

[PATCH v4] modules_install: make missing $DEPMOD a Warning instead of an Error

2018-08-28 Thread Randy Dunlap
From: Randy Dunlap When $DEPMOD is not found, only print a warning instead of exiting with an error message and error status: Warning: 'make modules_install' requires /sbin/depmod. Please install it. This is probably in the kmod package. Change the Error to a Warning because "not all

[PATCH v4] modules_install: make missing $DEPMOD a Warning instead of an Error

2018-08-28 Thread Randy Dunlap
From: Randy Dunlap When $DEPMOD is not found, only print a warning instead of exiting with an error message and error status: Warning: 'make modules_install' requires /sbin/depmod. Please install it. This is probably in the kmod package. Change the Error to a Warning because "not all

Re: [PATCH v3] modules_install: make missing $DEPMOD a warning instead of an error

2018-08-28 Thread Randy Dunlap
; Could you add the motivation of this change > (as Nikolaus reported) ? > > Without the reason recorded in git-log, > somebody may wonder why this commit is useful. > Added for v4. > >> Warning: 'make modules_install' requires /sbin/depmod. Please install it. >&

Re: [PATCH v3] modules_install: make missing $DEPMOD a warning instead of an error

2018-08-28 Thread Randy Dunlap
; Could you add the motivation of this change > (as Nikolaus reported) ? > > Without the reason recorded in git-log, > somebody may wonder why this commit is useful. > Added for v4. > >> Warning: 'make modules_install' requires /sbin/depmod. Please install it. >&

Re: [PATCH v3] modules_install: make missing $DEPMOD a warning instead of an error

2018-08-23 Thread Masahiro Yamada
d in git-log, somebody may wonder why this commit is useful. > Warning: 'make modules_install' requires /sbin/depmod. Please install it. > This is probably in the kmod package. > > Signed-off-by: Randy Dunlap > Fixes: 934193a654c1 ("kbuild: verify that $DEPMOD is installe

Re: [PATCH v3] modules_install: make missing $DEPMOD a warning instead of an error

2018-08-23 Thread Masahiro Yamada
d in git-log, somebody may wonder why this commit is useful. > Warning: 'make modules_install' requires /sbin/depmod. Please install it. > This is probably in the kmod package. > > Signed-off-by: Randy Dunlap > Fixes: 934193a654c1 ("kbuild: verify that $DEPMOD is installe

Re: [PATCH v3] modules_install: make missing $DEPMOD a warning instead of an error

2018-08-23 Thread H. Nikolaus Schaller
Hi Randy, > Am 23.08.2018 um 20:13 schrieb Randy Dunlap : > > From: Randy Dunlap > > When $DEPMOD is not found, only print a warning instead of exiting > with an error message and error status. > > Warning: 'make modules_install' requires /sbin/depmod. Please instal

Re: [PATCH v3] modules_install: make missing $DEPMOD a warning instead of an error

2018-08-23 Thread H. Nikolaus Schaller
Hi Randy, > Am 23.08.2018 um 20:13 schrieb Randy Dunlap : > > From: Randy Dunlap > > When $DEPMOD is not found, only print a warning instead of exiting > with an error message and error status. > > Warning: 'make modules_install' requires /sbin/depmod. Please instal

[PATCH v3] modules_install: make missing $DEPMOD a warning instead of an error

2018-08-23 Thread Randy Dunlap
From: Randy Dunlap When $DEPMOD is not found, only print a warning instead of exiting with an error message and error status. Warning: 'make modules_install' requires /sbin/depmod. Please install it. This is probably in the kmod package. Signed-off-by: Randy Dunlap Fixes: 934193a654c1

[PATCH v3] modules_install: make missing $DEPMOD a warning instead of an error

2018-08-23 Thread Randy Dunlap
From: Randy Dunlap When $DEPMOD is not found, only print a warning instead of exiting with an error message and error status. Warning: 'make modules_install' requires /sbin/depmod. Please install it. This is probably in the kmod package. Signed-off-by: Randy Dunlap Fixes: 934193a654c1

Re: [PATCH v2] modules_install: make missing $DEPMOD a warning instead of error

2018-08-23 Thread Greg KH
On Thu, Aug 23, 2018 at 10:52:39AM -0700, Randy Dunlap wrote: > From: Randy Dunlap > > When $DEPMOD is not found, only print a warning instead of exiting > with an error message and error status. > > Warning: 'make modules_install' requires /sbin/depmod. Please install it.

Re: [PATCH v2] modules_install: make missing $DEPMOD a warning instead of error

2018-08-23 Thread Greg KH
On Thu, Aug 23, 2018 at 10:52:39AM -0700, Randy Dunlap wrote: > From: Randy Dunlap > > When $DEPMOD is not found, only print a warning instead of exiting > with an error message and error status. > > Warning: 'make modules_install' requires /sbin/depmod. Please install it.

[PATCH v2] modules_install: make missing $DEPMOD a warning instead of error

2018-08-23 Thread Randy Dunlap
From: Randy Dunlap When $DEPMOD is not found, only print a warning instead of exiting with an error message and error status. Warning: 'make modules_install' requires /sbin/depmod. Please install it. This is probably in the kmod package. Signed-off-by: Randy Dunlap --- v2: add missing "e

[PATCH v2] modules_install: make missing $DEPMOD a warning instead of error

2018-08-23 Thread Randy Dunlap
From: Randy Dunlap When $DEPMOD is not found, only print a warning instead of exiting with an error message and error status. Warning: 'make modules_install' requires /sbin/depmod. Please install it. This is probably in the kmod package. Signed-off-by: Randy Dunlap --- v2: add missing "e

[PATCH 3.12 06/84] kbuild: Do not run modules_install and install in paralel

2016-10-17 Thread Jiri Slaby
bae..832dd3d27f39 100644 --- a/Makefile +++ b/Makefile @@ -476,6 +476,12 @@ ifeq ($(KBUILD_EXTMOD),) endif endif endif +# install and module_install need also be processed one by one +ifneq ($(filter install,$(MAKECMDGOALS)),) +ifneq ($(filter module

[PATCH 3.12 06/84] kbuild: Do not run modules_install and install in paralel

2016-10-17 Thread Jiri Slaby
($(KBUILD_EXTMOD),) endif endif endif +# install and module_install need also be processed one by one +ifneq ($(filter install,$(MAKECMDGOALS)),) +ifneq ($(filter modules_install,$(MAKECMDGOALS)),) + mixed-targets := 1 +endif +endif ifeq ($(mixed-targets

[PATCH 4.4 15/73] kbuild: Do not run modules_install and install in paralel

2016-09-28 Thread Greg Kroah-Hartman
kefile @@ -495,6 +495,12 @@ ifeq ($(KBUILD_EXTMOD),) endif endif endif +# install and module_install need also be processed one by one +ifneq ($(filter install,$(MAKECMDGOALS)),) +ifneq ($(filter modules_install,$(MAKECMDGOALS)),) + mixed-targets :=

[PATCH 4.4 15/73] kbuild: Do not run modules_install and install in paralel

2016-09-28 Thread Greg Kroah-Hartman
+# install and module_install need also be processed one by one +ifneq ($(filter install,$(MAKECMDGOALS)),) +ifneq ($(filter modules_install,$(MAKECMDGOALS)),) + mixed-targets := 1 +endif +endif ifeq ($(mixed-targets),1) # ===

Re: [PATCH] kbuild: Do not run modules_install and install in paralel

2015-12-10 Thread Michal Marek
3,6 +503,12 @@ ifeq ($(KBUILD_EXTMOD),) >> endif >> endif >> endif >> +# install and module_install need also be processed one by one >> +ifneq ($(filter install,$(MAKECMDGOALS)),) >> +ifneq ($(filter mod

Re: [PATCH] kbuild: Do not run modules_install and install in paralel

2015-12-10 Thread Michal Marek
e483 100644 >> --- a/Makefile >> +++ b/Makefile >> @@ -503,6 +503,12 @@ ifeq ($(KBUILD_EXTMOD),) >> endif >> endif >> endif >> +# install and module_install need also be processed one by one >> +ifneq ($(filter install,$(MAKE

Re: [PATCH] kbuild: Do not run modules_install and install in paralel

2015-12-09 Thread Andy Lutomirski
module_install need also be processed one by one > +ifneq ($(filter install,$(MAKECMDGOALS)),) > +ifneq ($(filter modules_install,$(MAKECMDGOALS)),) > + mixed-targets := 1 > +endif > +endif > > ifeq ($(mixed-targets),1) > # ===

Re: [PATCH] kbuild: Do not run modules_install and install in paralel

2015-12-09 Thread Andy Lutomirski
> endif > endif > endif > +# install and module_install need also be processed one by one > +ifneq ($(filter install,$(MAKECMDGOALS)),) > +ifneq ($(filter modules_install,$(MAKECMDGOALS)),) > +

[PATCH 11/27] modsign: Abort modules_install when signing fails [ver #7]

2015-08-05 Thread David Howells
From: David Woodhouse Signed-off-by: David Woodhouse Signed-off-by: David Howells --- scripts/Makefile.modinst |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/Makefile.modinst b/scripts/Makefile.modinst index e48a4e9d8868..07650eeaaf06 100644 ---

[PATCH 11/27] modsign: Abort modules_install when signing fails [ver #7]

2015-08-05 Thread David Howells
From: David Woodhouse david.woodho...@intel.com Signed-off-by: David Woodhouse david.woodho...@intel.com Signed-off-by: David Howells dhowe...@redhat.com --- scripts/Makefile.modinst |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/Makefile.modinst

[PATCH 09/27] modsign: Abort modules_install when signing fails

2015-07-17 Thread David Howells
From: David Woodhouse Signed-off-by: David Woodhouse Signed-off-by: David Howells --- scripts/Makefile.modinst |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/Makefile.modinst b/scripts/Makefile.modinst index e48a4e9d8868..07650eeaaf06 100644 ---

[PATCH 09/27] modsign: Abort modules_install when signing fails

2015-07-17 Thread David Howells
From: David Woodhouse david.woodho...@intel.com Signed-off-by: David Woodhouse david.woodho...@intel.com Signed-off-by: David Howells dhowe...@redhat.com --- scripts/Makefile.modinst |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/Makefile.modinst

[PATCH 09/20] modsign: Abort modules_install when signing fails [ver #5]

2015-05-28 Thread David Howells
From: David Woodhouse Signed-off-by: David Woodhouse Signed-off-by: David Howells --- scripts/Makefile.modinst |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/Makefile.modinst b/scripts/Makefile.modinst index e48a4e9d8868..07650eeaaf06 100644 ---

[PATCH 09/20] modsign: Abort modules_install when signing fails [ver #5]

2015-05-28 Thread David Howells
From: David Woodhouse david.woodho...@intel.com Signed-off-by: David Woodhouse david.woodho...@intel.com Signed-off-by: David Howells dhowe...@redhat.com --- scripts/Makefile.modinst |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/Makefile.modinst

[PATCH 9/8] modsign: Abort modules_install when signing fails

2015-05-19 Thread David Woodhouse
Signed-off-by: David Woodhouse --- scripts/Makefile.modinst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/Makefile.modinst b/scripts/Makefile.modinst index e48a4e9..07650ee 100644 --- a/scripts/Makefile.modinst +++ b/scripts/Makefile.modinst @@ -22,7 +22,7 @@

Re: [PATCH 1/4] modsign: Abort modules_install when signing fails

2015-05-19 Thread Mimi Zohar
On Tue, 2015-05-19 at 12:57 +, Woodhouse, David wrote: > On Tue, 2015-05-19 at 07:45 -0400, Mimi Zohar wrote: > > > > /bin/sh: line 1: 22771 Segmentation fault (core dumped) > > scripts/sign-file "sha256" "pkcs11:manufacturer=piv_II;id=%01" > > ./signing_key.x509 /lib/modules/4.1.0-rc1

Re: [PATCH 1/4] modsign: Abort modules_install when signing fails

2015-05-19 Thread Woodhouse, David
On Tue, 2015-05-19 at 07:45 -0400, Mimi Zohar wrote: > > /bin/sh: line 1: 22771 Segmentation fault (core dumped) > scripts/sign-file "sha256" "pkcs11:manufacturer=piv_II;id=%01" > ./signing_key.x509 /lib/modules/4.1.0-rc1 > -test+/kernel/net/ipv6/netfilter/ip6table_filter.ko >

Re: [PATCH 1/4] modsign: Abort modules_install when signing fails

2015-05-19 Thread Mimi Zohar
On Tue, 2015-05-19 at 06:40 +, Woodhouse, David wrote: > On Mon, 2015-05-18 at 21:29 -0400, Mimi Zohar wrote: > > On Fri, 2015-05-15 at 17:52 +0100, David Woodhouse wrote: > > > Signed-off-by: David Woodhouse > > With this patch, as expected the modules_in

Re: [PATCH 1/4] modsign: Abort modules_install when signing fails

2015-05-19 Thread Woodhouse, David
On Mon, 2015-05-18 at 21:29 -0400, Mimi Zohar wrote: > On Fri, 2015-05-15 at 17:52 +0100, David Woodhouse wrote: > > Signed-off-by: David Woodhouse > > I assume the patch descriptions will be added before being upstreamed. This patch aborts modules_install whe

Re: [PATCH 1/4] modsign: Abort modules_install when signing fails

2015-05-19 Thread Woodhouse, David
On Mon, 2015-05-18 at 21:29 -0400, Mimi Zohar wrote: On Fri, 2015-05-15 at 17:52 +0100, David Woodhouse wrote: Signed-off-by: David Woodhouse david.woodho...@intel.com I assume the patch descriptions will be added before being upstreamed. This patch aborts modules_install when signing

Re: [PATCH 1/4] modsign: Abort modules_install when signing fails

2015-05-19 Thread Mimi Zohar
On Tue, 2015-05-19 at 06:40 +, Woodhouse, David wrote: On Mon, 2015-05-18 at 21:29 -0400, Mimi Zohar wrote: On Fri, 2015-05-15 at 17:52 +0100, David Woodhouse wrote: Signed-off-by: David Woodhouse david.woodho...@intel.com With this patch, as expected the modules_install aborted

Re: [PATCH 1/4] modsign: Abort modules_install when signing fails

2015-05-19 Thread Mimi Zohar
On Tue, 2015-05-19 at 12:57 +, Woodhouse, David wrote: On Tue, 2015-05-19 at 07:45 -0400, Mimi Zohar wrote: /bin/sh: line 1: 22771 Segmentation fault (core dumped) scripts/sign-file sha256 pkcs11:manufacturer=piv_II;id=%01 ./signing_key.x509 /lib/modules/4.1.0-rc1

[PATCH 9/8] modsign: Abort modules_install when signing fails

2015-05-19 Thread David Woodhouse
Signed-off-by: David Woodhouse david.woodho...@intel.com --- scripts/Makefile.modinst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/Makefile.modinst b/scripts/Makefile.modinst index e48a4e9..07650ee 100644 --- a/scripts/Makefile.modinst +++ b/scripts/Makefile.modinst

Re: [PATCH 1/4] modsign: Abort modules_install when signing fails

2015-05-19 Thread Woodhouse, David
On Tue, 2015-05-19 at 07:45 -0400, Mimi Zohar wrote: /bin/sh: line 1: 22771 Segmentation fault (core dumped) scripts/sign-file sha256 pkcs11:manufacturer=piv_II;id=%01 ./signing_key.x509 /lib/modules/4.1.0-rc1 -test+/kernel/net/ipv6/netfilter/ip6table_filter.ko

Re: [PATCH 1/4] modsign: Abort modules_install when signing fails

2015-05-18 Thread Mimi Zohar
/$(notdir $@) ; \ > -$(mod_sign_cmd) $(2)/$(notdir $@) $(patsubst %,|| true,$(KBUILD_EXTMOD)) > ; \ > +$(mod_sign_cmd) $(2)/$(notdir $@) $(patsubst %,|| true,$(KBUILD_EXTMOD)) > && \ > $(mod_compress_cmd) $(2)/$(notdir $@) With this patch, as expected the mo

Re: [PATCH 1/4] modsign: Abort modules_install when signing fails

2015-05-18 Thread Mimi Zohar
$@) ; \ -$(mod_sign_cmd) $(2)/$(notdir $@) $(patsubst %,|| true,$(KBUILD_EXTMOD)) ; \ +$(mod_sign_cmd) $(2)/$(notdir $@) $(patsubst %,|| true,$(KBUILD_EXTMOD)) \ $(mod_compress_cmd) $(2)/$(notdir $@) With this patch, as expected the modules_install aborted on failure. Is there any way

[PATCH 1/4] modsign: Abort modules_install when signing fails

2015-05-15 Thread David Woodhouse
Signed-off-by: David Woodhouse --- scripts/Makefile.modinst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/Makefile.modinst b/scripts/Makefile.modinst index e48a4e9..07650ee 100644 --- a/scripts/Makefile.modinst +++ b/scripts/Makefile.modinst @@ -22,7 +22,7 @@

[PATCH 1/4] modsign: Abort modules_install when signing fails

2015-05-15 Thread David Woodhouse
Signed-off-by: David Woodhouse david.woodho...@intel.com --- scripts/Makefile.modinst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/Makefile.modinst b/scripts/Makefile.modinst index e48a4e9..07650ee 100644 --- a/scripts/Makefile.modinst +++ b/scripts/Makefile.modinst

Re: [PATCH 2/3] kbuild: handle module compression while running 'make modules_install'.

2014-10-12 Thread Andev
On Sun, Oct 12, 2014 at 12:40 PM, Willy Tarreau wrote: > Hi, > > On Sun, Oct 12, 2014 at 11:50:59AM -0400, Andev wrote: >> Hello Bertrand, >> >> Does this need any user space support? Cos currently on a debian >> testing box(powerpc) enabling this options causes a boot hang while >> mounting the

Re: [PATCH 2/3] kbuild: handle module compression while running 'make modules_install'.

2014-10-12 Thread Willy Tarreau
Hi, On Sun, Oct 12, 2014 at 11:50:59AM -0400, Andev wrote: > Hello Bertrand, > > Does this need any user space support? Cos currently on a debian > testing box(powerpc) enabling this options causes a boot hang while > mounting the root file system. I suspect that your module-ini-tools/kmod are

Re: [PATCH 2/3] kbuild: handle module compression while running 'make modules_install'.

2014-10-12 Thread Andev
), the following table > shows observed disk space gain based on the allmodconfig .config : > >| time| >+-+-+ >| manual .ko | make |

Re: [PATCH 2/3] kbuild: handle module compression while running 'make modules_install'.

2014-10-12 Thread Andev
based on the allmodconfig .config : | time| +-+-+ | manual .ko | make | size | percent | compression | modules_install | | gain

Re: [PATCH 2/3] kbuild: handle module compression while running 'make modules_install'.

2014-10-12 Thread Willy Tarreau
Hi, On Sun, Oct 12, 2014 at 11:50:59AM -0400, Andev wrote: Hello Bertrand, Does this need any user space support? Cos currently on a debian testing box(powerpc) enabling this options causes a boot hang while mounting the root file system. I suspect that your module-ini-tools/kmod are built

Re: [PATCH 2/3] kbuild: handle module compression while running 'make modules_install'.

2014-10-12 Thread Andev
On Sun, Oct 12, 2014 at 12:40 PM, Willy Tarreau w...@1wt.eu wrote: Hi, On Sun, Oct 12, 2014 at 11:50:59AM -0400, Andev wrote: Hello Bertrand, Does this need any user space support? Cos currently on a debian testing box(powerpc) enabling this options causes a boot hang while mounting the

Re: [PATCH 2/3] kbuild: handle module compression while running 'make modules_install'.

2014-08-20 Thread Rusty Russell
following table > shows observed disk space gain based on the allmodconfig .config : > >| time| >+-+-+ >| manual .ko | make |

Re: [PATCH 2/3] kbuild: handle module compression while running 'make modules_install'.

2014-08-20 Thread Rusty Russell
Andi Kleen writes: >> I understand your concern about this, but does is make sense to not use >> -9 when then following files use gzip or other compression tools with -9 : > > Just because someone else makes mistakes doesn't mean that you should > make them too. To be fair, you didn't provide

Re: [PATCH 2/3] kbuild: handle module compression while running 'make modules_install'.

2014-08-20 Thread Rusty Russell
Andi Kleen a...@firstfloor.org writes: I understand your concern about this, but does is make sense to not use -9 when then following files use gzip or other compression tools with -9 : Just because someone else makes mistakes doesn't mean that you should make them too. To be fair, you

Re: [PATCH 2/3] kbuild: handle module compression while running 'make modules_install'.

2014-08-20 Thread Rusty Russell
on the allmodconfig .config : | time| +-+-+ | manual .ko | make | size | percent | compression | modules_install | | gain

Re: [PATCH 2/3] kbuild: handle module compression while running 'make modules_install'.

2014-08-19 Thread Andi Kleen
> I understand your concern about this, but does is make sense to not use > -9 when then following files use gzip or other compression tools with -9 : Just because someone else makes mistakes doesn't mean that you should make them too. -Andi -- To unsubscribe from this list: send the line

[PATCH 2/3] kbuild: handle module compression while running 'make modules_install'.

2014-08-19 Thread Bertrand Jacquin
time| +-+-+ | manual .ko | make | size | percent | compression | modules_install | | gain +-+-+--+ -| | 18.61s | 378M | GZIP | 3m16s |

Re: [PATCH 2/3] kbuild: handle module compression while running 'make modules_install'.

2014-08-19 Thread Bertrand Jacquin
Hi, D'ar meurzh 19 a viz Eost 2014 e 19 eur 55, « Rusty Russell » he deus skrivet : > Andi Kleen writes: > > Bertrand Jacquin writes: > >> > >> +# CONFIG_MODULE_COMPRESS, if defined, will cause module to be compressed > >> +# after they are installed in agreement with

Re: [PATCH 2/3] kbuild: handle module compression while running 'make modules_install'.

2014-08-19 Thread Rusty Russell
Andi Kleen writes: > Bertrand Jacquin writes: >> >> +# CONFIG_MODULE_COMPRESS, if defined, will cause module to be compressed >> +# after they are installed in agreement with CONFIG_MODULE_COMPRESS_GZIP >> +# or CONFIG_MODULE_COMPRESS_XZ. >> + >> +mod_compress_cmd = true >> +ifdef

Re: [PATCH 2/3] kbuild: handle module compression while running 'make modules_install'.

2014-08-19 Thread Bertrand Jacquin
Hi, D'ar meurzh 19 a viz Eost 2014 e 15 eur 17, « Andi Kleen » he deus skrivet : > Bertrand Jacquin writes: > > > > +# CONFIG_MODULE_COMPRESS, if defined, will cause module to be compressed > > +# after they are installed in agreement with CONFIG_MODULE_COMPRESS_GZIP > > +# or

Re: [PATCH 2/3] kbuild: handle module compression while running 'make modules_install'.

2014-08-19 Thread Andi Kleen
Bertrand Jacquin writes: > > +# CONFIG_MODULE_COMPRESS, if defined, will cause module to be compressed > +# after they are installed in agreement with CONFIG_MODULE_COMPRESS_GZIP > +# or CONFIG_MODULE_COMPRESS_XZ. > + > +mod_compress_cmd = true > +ifdef CONFIG_MODULE_COMPRESS > + ifdef

Re: [PATCH 2/3] kbuild: handle module compression while running 'make modules_install'.

2014-08-19 Thread Andi Kleen
I understand your concern about this, but does is make sense to not use -9 when then following files use gzip or other compression tools with -9 : Just because someone else makes mistakes doesn't mean that you should make them too. -Andi -- To unsubscribe from this list: send the line

Re: [PATCH 2/3] kbuild: handle module compression while running 'make modules_install'.

2014-08-19 Thread Andi Kleen
Bertrand Jacquin be...@meleeweb.net writes: +# CONFIG_MODULE_COMPRESS, if defined, will cause module to be compressed +# after they are installed in agreement with CONFIG_MODULE_COMPRESS_GZIP +# or CONFIG_MODULE_COMPRESS_XZ. + +mod_compress_cmd = true +ifdef CONFIG_MODULE_COMPRESS +

Re: [PATCH 2/3] kbuild: handle module compression while running 'make modules_install'.

2014-08-19 Thread Bertrand Jacquin
Hi, D'ar meurzh 19 a viz Eost 2014 e 15 eur 17, « Andi Kleen » he deus skrivet : Bertrand Jacquin be...@meleeweb.net writes: +# CONFIG_MODULE_COMPRESS, if defined, will cause module to be compressed +# after they are installed in agreement with CONFIG_MODULE_COMPRESS_GZIP +# or

Re: [PATCH 2/3] kbuild: handle module compression while running 'make modules_install'.

2014-08-19 Thread Rusty Russell
Andi Kleen a...@firstfloor.org writes: Bertrand Jacquin be...@meleeweb.net writes: +# CONFIG_MODULE_COMPRESS, if defined, will cause module to be compressed +# after they are installed in agreement with CONFIG_MODULE_COMPRESS_GZIP +# or CONFIG_MODULE_COMPRESS_XZ. + +mod_compress_cmd =

Re: [PATCH 2/3] kbuild: handle module compression while running 'make modules_install'.

2014-08-19 Thread Bertrand Jacquin
Hi, D'ar meurzh 19 a viz Eost 2014 e 19 eur 55, « Rusty Russell » he deus skrivet : Andi Kleen a...@firstfloor.org writes: Bertrand Jacquin be...@meleeweb.net writes: +# CONFIG_MODULE_COMPRESS, if defined, will cause module to be compressed +# after they are installed in agreement with

[PATCH 2/3] kbuild: handle module compression while running 'make modules_install'.

2014-08-19 Thread Bertrand Jacquin
| +-+-+ | manual .ko | make | size | percent | compression | modules_install | | gain +-+-+--+ -| | 18.61s | 378M | GZIP | 3m16s | 3m37s

[PATCH 2/3] kbuild: handle module compression while running 'make modules_install'.

2014-08-16 Thread Bertrand Jacquin
time| +-+-+ | manual .ko | make | size | percent | compression | modules_install | | gain +-+-+--+ -| | 18.61s | 378M | GZIP | 3m16s | 3m37s | 102M | 73.41% XZ | 5m22s |

[PATCH 2/3] kbuild: handle module compression while running 'make modules_install'.

2014-08-16 Thread Bertrand Jacquin
| +-+-+ | manual .ko | make | size | percent | compression | modules_install | | gain +-+-+--+ -| | 18.61s | 378M | GZIP | 3m16s | 3m37s | 102M | 73.41% XZ | 5m22s | 5m39s

Re: [PATCH] kbuild: Do not run modules_install and install in paralel

2014-07-07 Thread Michal Marek
;>>>> +++ b/Makefile >>>>> @@ -503,6 +503,12 @@ ifeq ($(KBUILD_EXTMOD),) >>>>> endif >>>>> endif >>>>> endif >>>>> +# install and module_install need also be processed one by one >>>

Re: [PATCH] kbuild: Do not run modules_install and install in paralel

2014-07-07 Thread Michal Marek
modules_install,$(MAKECMDGOALS)),) + mixed-targets := 1 +endif +endif Note that this version does not enforce the ordering, it just avoids the interleaved execution. It can be added if desired. Hmm. This will fix 'make modules_install install' but will not fix 'make

Re: [PATCH] kbuild: Do not run modules_install and install in paralel

2014-07-04 Thread Andy Lutomirski
gt;>>> 1 file changed, 6 insertions(+) >>>> >>>> diff --git a/Makefile b/Makefile >>>> index 7680d7c..7e5e483 100644 >>>> --- a/Makefile >>>> +++ b/Makefile >>>> @@ -503,6 +503,12 @@ ifeq ($(KBUILD_EXTMOD),) >>>>

Re: [PATCH] kbuild: Do not run modules_install and install in paralel

2014-07-04 Thread Michal Marek
t; index 7680d7c..7e5e483 100644 >>> --- a/Makefile >>> +++ b/Makefile >>> @@ -503,6 +503,12 @@ ifeq ($(KBUILD_EXTMOD),) >>> endif >>> endif >>> endif >>> +# install and module_install need also be processe

Re: [PATCH] kbuild: Do not run modules_install and install in paralel

2014-07-04 Thread Michal Marek
),) endif endif endif +# install and module_install need also be processed one by one +ifneq ($(filter install,$(MAKECMDGOALS)),) +ifneq ($(filter modules_install,$(MAKECMDGOALS)),) + mixed-targets := 1 +endif +endif Note

Re: [PATCH] kbuild: Do not run modules_install and install in paralel

2014-07-04 Thread Andy Lutomirski
--- a/Makefile +++ b/Makefile @@ -503,6 +503,12 @@ ifeq ($(KBUILD_EXTMOD),) endif endif endif +# install and module_install need also be processed one by one +ifneq ($(filter install,$(MAKECMDGOALS)),) +ifneq ($(filter modules_install,$(MAKECMDGOALS

Re: [PATCH] kbuild: Do not run modules_install and install in paralel

2014-06-13 Thread Andy Lutomirski
3,6 +503,12 @@ ifeq ($(KBUILD_EXTMOD),) >> endif >> endif >> endif >> +# install and module_install need also be processed one by one >> +ifneq ($(filter install,$(MAKECMDGOALS)),) >> +ifneq ($(filter modules_install,$(MAKECMDGOALS)),)

Re: [PATCH] kbuild: Do not run modules_install and install in paralel

2014-06-13 Thread Michal Marek
module_install need also be processed one by one > +ifneq ($(filter install,$(MAKECMDGOALS)),) > +ifneq ($(filter modules_install,$(MAKECMDGOALS)),) > + mixed-targets := 1 > +endif > +endif Note that this version does not enforce the ordering, it ju

[PATCH] kbuild: Do not run modules_install and install in paralel

2014-06-13 Thread Michal Marek
7680d7c..7e5e483 100644 --- a/Makefile +++ b/Makefile @@ -503,6 +503,12 @@ ifeq ($(KBUILD_EXTMOD),) endif endif endif +# install and module_install need also be processed one by one +ifneq ($(filter install,$(MAKECMDGOALS)),) +ifneq ($(filter modules_install

  1   2   3   >