[PATCH 4.9 061/102] net: check before dereferencing netdev_ops during busy poll

From: Josh Elsasser init_dummy_netdev() leaves its netdev_ops pointer zeroed. This leads to a NULL pointer dereference when sk_busy_loop fires against an iwlwifi wireless adapter and checks napi->dev->netdev_ops->ndo_busy_poll. Avoid this by ensuring napi->dev->netdev_ops is valid before

[PATCH 4.4 46/73] net: check before dereferencing netdev_ops during busy poll

From: Josh Elsasser init_dummy_netdev() leaves its netdev_ops pointer zeroed. This leads to a NULL pointer dereference when sk_busy_loop fires against an iwlwifi wireless adapter and checks napi->dev->netdev_ops->ndo_busy_poll. Avoid this by ensuring napi->dev->netdev_ops is valid before

Re: net: check before dereferencing netdev_ops during busy poll

On Jul 1, 2019, at 11:03 AM, Matteo Croce wrote: > Josh, as you are the original author, can you please resend it to -stable? > Feel free to add this tag: > > Tested-by: Matteo Croce For sure. Resent with your Tested-by, along with a second patch that applies to the 4.4.y LTS kernel. I'm

Re: net: check before dereferencing netdev_ops during busy poll

On Mon, Jul 1, 2019 at 7:53 PM Greg Kroah-Hartman wrote: > > On Sat, Jun 29, 2019 at 09:39:39PM +0200, Matteo Croce wrote: > > On Sat, Jun 29, 2019 at 9:45 AM Greg Kroah-Hartman > > wrote: > > > > > > On Fri, Jun 28, 2019 at 07:03:01PM -0700, Josh Elsasser wrote: > > > > On Jun 28, 2019, at 3:55

Re: net: check before dereferencing netdev_ops during busy poll

On Sat, Jun 29, 2019 at 09:39:39PM +0200, Matteo Croce wrote: > On Sat, Jun 29, 2019 at 9:45 AM Greg Kroah-Hartman > wrote: > > > > On Fri, Jun 28, 2019 at 07:03:01PM -0700, Josh Elsasser wrote: > > > On Jun 28, 2019, at 3:55 PM, Sasha Levin wrote: > > > > > > > What's the upstream commit id? >

Re: net: check before dereferencing netdev_ops during busy poll

On Fri, Jun 28, 2019 at 06:34:58PM +0200, Matteo Croce wrote: > Hi, > > Is there any reason for this panic fix not being applied in stable? > > https://lore.kernel.org/netdev/20180313053248.13654-1-jelsas...@appneta.com/T/ I can't apply patches from random urls :)

Re: net: check before dereferencing netdev_ops during busy poll

On Sat, Jun 29, 2019 at 9:45 AM Greg Kroah-Hartman wrote: > > On Fri, Jun 28, 2019 at 07:03:01PM -0700, Josh Elsasser wrote: > > On Jun 28, 2019, at 3:55 PM, Sasha Levin wrote: > > > > > What's the upstream commit id? > > > > The commit wasn't needed upstream, as I only sent the original patch

Re: net: check before dereferencing netdev_ops during busy poll

On Fri, Jun 28, 2019 at 07:03:01PM -0700, Josh Elsasser wrote: > On Jun 28, 2019, at 3:55 PM, Sasha Levin wrote: > > > What's the upstream commit id? > > The commit wasn't needed upstream, as I only sent the original patch after > 79e7fff47b7b ("net: remove support for per driver

Re: net: check before dereferencing netdev_ops during busy poll

On Jun 28, 2019, at 3:55 PM, Sasha Levin wrote: > What's the upstream commit id? The commit wasn't needed upstream, as I only sent the original patch after 79e7fff47b7b ("net: remove support for per driver ndo_busy_poll()") had made the fix unnecessary in Linus' tree. May've gotten lost in the

Re: net: check before dereferencing netdev_ops during busy poll

On Fri, Jun 28, 2019 at 06:34:58PM +0200, Matteo Croce wrote: Hi, Is there any reason for this panic fix not being applied in stable? https://lore.kernel.org/netdev/20180313053248.13654-1-jelsas...@appneta.com/T/ What's the upstream commit id? -- Thanks, Sasha

net: check before dereferencing netdev_ops during busy poll

Hi, Is there any reason for this panic fix not being applied in stable? https://lore.kernel.org/netdev/20180313053248.13654-1-jelsas...@appneta.com/T/ It seems that linux 4.9.184 has the bug too. Regards, -- Matteo Croce per aspera ad upstream

Re: [PATCH v2 1/1] net: check before dereferencing netdev_ops during busy poll

From: Josh Elsasser Date: Mon, 12 Mar 2018 22:32:00 -0700 > init_dummy_netdev() leaves its netdev_ops pointer zeroed. This leads > to a NULL pointer dereference when sk_busy_loop fires against an iwlwifi > wireless adapter and checks napi->dev->netdev_ops->ndo_busy_poll. >

Re: [PATCH v2 1/1] net: check before dereferencing netdev_ops during busy poll

From: Josh Elsasser Date: Mon, 12 Mar 2018 22:32:00 -0700 > init_dummy_netdev() leaves its netdev_ops pointer zeroed. This leads > to a NULL pointer dereference when sk_busy_loop fires against an iwlwifi > wireless adapter and checks napi->dev->netdev_ops->ndo_busy_poll. > > Avoid this by

Re: [PATCH v2 1/1] net: check before dereferencing netdev_ops during busy poll

On 03/12/2018 10:32 PM, Josh Elsasser wrote: init_dummy_netdev() leaves its netdev_ops pointer zeroed. This leads to a NULL pointer dereference when sk_busy_loop fires against an iwlwifi wireless adapter and checks napi->dev->netdev_ops->ndo_busy_poll. Avoid this by ensuring

Re: [PATCH v2 1/1] net: check before dereferencing netdev_ops during busy poll

On 03/12/2018 10:32 PM, Josh Elsasser wrote: init_dummy_netdev() leaves its netdev_ops pointer zeroed. This leads to a NULL pointer dereference when sk_busy_loop fires against an iwlwifi wireless adapter and checks napi->dev->netdev_ops->ndo_busy_poll. Avoid this by ensuring

[PATCH v2 1/1] net: check before dereferencing netdev_ops during busy poll

init_dummy_netdev() leaves its netdev_ops pointer zeroed. This leads to a NULL pointer dereference when sk_busy_loop fires against an iwlwifi wireless adapter and checks napi->dev->netdev_ops->ndo_busy_poll. Avoid this by ensuring napi->dev->netdev_ops is valid before following the pointer,

[PATCH v2 1/1] net: check before dereferencing netdev_ops during busy poll

init_dummy_netdev() leaves its netdev_ops pointer zeroed. This leads to a NULL pointer dereference when sk_busy_loop fires against an iwlwifi wireless adapter and checks napi->dev->netdev_ops->ndo_busy_poll. Avoid this by ensuring napi->dev->netdev_ops is valid before following the pointer,