Re: [SIL2review] [PATCH] objtool: Use value of intended enum to compile with clang

2017-12-10 Thread Nicholas Mc Guire
On Sun, Dec 10, 2017 at 07:35:00PM +0100, Lukas Bulwahn wrote: > Just use the right value and avoid an implicit conversion between the two > enumeration types that just happened to work in this case. It seems that > this must have just been overlooked in the new implementation of objtool > in commi

objtool: Use value of intended enum to compile with clang

2017-12-10 Thread Lukas Bulwahn
Hi, Please include this patch in tools/objtool to properly compile with clang-5.0. I successfully compiled this patch (make defconfig && make) on top of tag next-20171208 from linux-next with clang-5.0.0 and gcc (Debian 7.2.0-16) 7.2.0, but I did not test anything further than that. Exact compil

[PATCH] objtool: Use value of intended enum to compile with clang

2017-12-10 Thread Lukas Bulwahn
Just use the right value and avoid an implicit conversion between the two enumeration types that just happened to work in this case. It seems that this must have just been overlooked in the new implementation of objtool in commit baa41469a7b9 ("objtool: Implement stack validation 2.0"). I found th