Re: percpu irq APIs and perf

2015-12-14 Thread maxime.rip...@free-electrons.com
Hi, On Fri, Dec 11, 2015 at 05:50:22PM +0530, Vineet Gupta wrote: > >> (2) It seems that disabling autoen by default for percpu irq makes sense as > >> evident from drivers/net/ethernet/marvell/mvneta.c where users want to > >> control > >> this. However the comment there is misleading > >> > >>

Re: percpu irq APIs and perf

2015-12-14 Thread maxime.rip...@free-electrons.com
Hi, On Fri, Dec 11, 2015 at 05:50:22PM +0530, Vineet Gupta wrote: > >> (2) It seems that disabling autoen by default for percpu irq makes sense as > >> evident from drivers/net/ethernet/marvell/mvneta.c where users want to > >> control > >> this. However the comment there is misleading > >> > >>

Re: percpu irq APIs and perf

2015-12-13 Thread Vineet Gupta
On Friday 11 December 2015 11:28 PM, Marc Zyngier wrote: >>> But auto-enabling cannot be done from a single CPU. It can only be done >>> >> from the core that is going to be delivered that interrupt. This >>> >> requires access to registers that are simply not available to other CPUs. >> > >> >

Re: percpu irq APIs and perf

2015-12-13 Thread Vineet Gupta
On Friday 11 December 2015 11:28 PM, Marc Zyngier wrote: >>> But auto-enabling cannot be done from a single CPU. It can only be done >>> >> from the core that is going to be delivered that interrupt. This >>> >> requires access to registers that are simply not available to other CPUs. >> > >> >

Re: percpu irq APIs and perf

2015-12-11 Thread Marc Zyngier
Vineet, On 11/12/15 12:20, Vineet Gupta wrote: > Hi Marc, > > On Friday 11 December 2015 04:53 PM, Marc Zyngier wrote: >> On Fri, 11 Dec 2015 05:26:02 + >>> I think we can make percpu irq API a bit easier to use. >>> >>> (1) First thing which request_percpu_irq() does is check for >>>

Re: percpu irq APIs and perf

2015-12-11 Thread Vineet Gupta
Hi Marc, On Friday 11 December 2015 04:53 PM, Marc Zyngier wrote: > On Fri, 11 Dec 2015 05:26:02 + >> I think we can make percpu irq API a bit easier to use. >> >> (1) First thing which request_percpu_irq() does is check for >> irq_settings_is_per_cpu_devid(). Thus irq_set_percpu_devid() can

Re: percpu irq APIs and perf

2015-12-11 Thread Marc Zyngier
On Fri, 11 Dec 2015 05:26:02 + Vineet Gupta wrote: Hi Vineet, > Hi Marc, > > On Thursday 10 December 2015 03:26 PM, Marc Zyngier wrote: > > Hi Vinnet, > > > > On 10/12/15 09:25, Vineet Gupta wrote: > >> Hi Marc / Daniel / Jason, > >> > >> I had a couple of questions about percpu irq API,

Re: percpu irq APIs and perf

2015-12-11 Thread Vineet Gupta
Hi Marc, On Friday 11 December 2015 04:53 PM, Marc Zyngier wrote: > On Fri, 11 Dec 2015 05:26:02 + >> I think we can make percpu irq API a bit easier to use. >> >> (1) First thing which request_percpu_irq() does is check for >> irq_settings_is_per_cpu_devid(). Thus irq_set_percpu_devid() can

Re: percpu irq APIs and perf

2015-12-11 Thread Marc Zyngier
On Fri, 11 Dec 2015 05:26:02 + Vineet Gupta wrote: Hi Vineet, > Hi Marc, > > On Thursday 10 December 2015 03:26 PM, Marc Zyngier wrote: > > Hi Vinnet, > > > > On 10/12/15 09:25, Vineet Gupta wrote: > >> Hi Marc / Daniel / Jason, > >> > >> I had a couple of

Re: percpu irq APIs and perf

2015-12-11 Thread Marc Zyngier
Vineet, On 11/12/15 12:20, Vineet Gupta wrote: > Hi Marc, > > On Friday 11 December 2015 04:53 PM, Marc Zyngier wrote: >> On Fri, 11 Dec 2015 05:26:02 + >>> I think we can make percpu irq API a bit easier to use. >>> >>> (1) First thing which request_percpu_irq() does is check for >>>

Re: percpu irq APIs and perf

2015-12-10 Thread Vineet Gupta
Hi Marc, On Thursday 10 December 2015 03:26 PM, Marc Zyngier wrote: > Hi Vinnet, > > On 10/12/15 09:25, Vineet Gupta wrote: >> Hi Marc / Daniel / Jason, >> >> I had a couple of questions about percpu irq API, hopefully you can help >> answer. >> >> On ARM, how do u handle requesting per cpu IRQs

Re: percpu irq APIs and perf

2015-12-10 Thread Marc Zyngier
Hi Vinnet, On 10/12/15 09:25, Vineet Gupta wrote: > Hi Marc / Daniel / Jason, > > I had a couple of questions about percpu irq API, hopefully you can help > answer. > > On ARM, how do u handle requesting per cpu IRQs - specifically usage > of request_percpu_irq() / enable_percpu_irq() API. >

percpu irq APIs and perf

2015-12-10 Thread Vineet Gupta
Hi Marc / Daniel / Jason, I had a couple of questions about percpu irq API, hopefully you can help answer. On ARM, how do u handle requesting per cpu IRQs - specifically usage of request_percpu_irq() / enable_percpu_irq() API. It seems, for using them, we obviously need to explicitly set irq as

Re: percpu irq APIs and perf

2015-12-10 Thread Marc Zyngier
Hi Vinnet, On 10/12/15 09:25, Vineet Gupta wrote: > Hi Marc / Daniel / Jason, > > I had a couple of questions about percpu irq API, hopefully you can help > answer. > > On ARM, how do u handle requesting per cpu IRQs - specifically usage > of request_percpu_irq() / enable_percpu_irq() API. >

percpu irq APIs and perf

2015-12-10 Thread Vineet Gupta
Hi Marc / Daniel / Jason, I had a couple of questions about percpu irq API, hopefully you can help answer. On ARM, how do u handle requesting per cpu IRQs - specifically usage of request_percpu_irq() / enable_percpu_irq() API. It seems, for using them, we obviously need to explicitly set irq as

Re: percpu irq APIs and perf

2015-12-10 Thread Vineet Gupta
Hi Marc, On Thursday 10 December 2015 03:26 PM, Marc Zyngier wrote: > Hi Vinnet, > > On 10/12/15 09:25, Vineet Gupta wrote: >> Hi Marc / Daniel / Jason, >> >> I had a couple of questions about percpu irq API, hopefully you can help >> answer. >> >> On ARM, how do u handle requesting per cpu IRQs