>>> This introduces a compile warning.
>>
>> How do you think about to show the exact message you get?
>
> I can't actually compile it myself.
It seems that I can understand your feedback also a bit better
since I received the information from a background process
like "kbuild test robot".
Will
Hi Markus,
[auto build test WARNING on pinctrl/for-next]
[also build test WARNING on v4.4-rc5 next-20151218]
url:
https://github.com/0day-ci/linux/commits/SF-Markus-Elfring/pinctrl-adi2-Use-a-signed-return-type-for-adi_gpio_irq_startup/20151220-010253
base:
https://git.kernel.org/pub/scm
On Sat, Dec 19, 2015 at 09:40:27PM +0100, SF Markus Elfring wrote:
> > This introduces a compile warning.
>
> How do you think about to show the exact message you get?
>
I can't actually compile it myself.
>
> > These functions are supposed to return 1 if there is an IRQ pending.
> > Change th
> This introduces a compile warning.
How do you think about to show the exact message you get?
> These functions are supposed to return 1 if there is an IRQ pending.
> Change the -EINVAL to 0.
Is there any more source code clean-up needed around the comment "FIXME"
in the affected function?
Re
This introduces a compile warning. These functions are supposed to
return 1 if there is an IRQ pending. Change the -EINVAL to 0.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo
From: Markus Elfring
Date: Sat, 19 Dec 2015 17:55:39 +0100
The return type "unsigned int" was used by the adi_gpio_irq_startup()
function despite of the aspect that it will eventually return a negative
error code.
Improve this implementation detail by deletion of the type modifier then.
This iss
6 matches
Mail list logo
