Re: pinctrl-sx150x.c broken in 4.11

2017-05-12 Thread Linus Walleij
On Thu, May 11, 2017 at 7:51 PM, Tony Lindgren wrote: > * Nikita Yushchenko [170511 10:01]: >> Well that's exactly what patch from my first mail in this thread does. >> This indeed fixes my case, but I don't know if it is correct in generic >> case. > > OK, yeah I just looked it up as I was not

Re: pinctrl-sx150x.c broken in 4.11

2017-05-11 Thread Nikita Yushchenko
>>> Maybe create_pinctrl() could check if the pin controller device >>> for a potential hog points to the device itself and bail out >>> if that's not the case? >> >> Well that's exactly what patch from my first mail in this thread does. >> This indeed fixes my case, but I don't know if it is corre

Re: pinctrl-sx150x.c broken in 4.11

2017-05-11 Thread Tony Lindgren
* Nikita Yushchenko [170511 10:01]: > >>> Hmm maybe yeah. I don't quite follow the above the "pinctrl-0 property > >>> of sx150x device tree node, is misinterpreted as hog" part though. > >> > >> sx150x is i2c-gpio device. It has 16 GPIO lines that are communicated > >> with via i2c bus, and an i

Re: pinctrl-sx150x.c broken in 4.11

2017-05-11 Thread Nikita Yushchenko
>>> Hmm maybe yeah. I don't quite follow the above the "pinctrl-0 property >>> of sx150x device tree node, is misinterpreted as hog" part though. >> >> sx150x is i2c-gpio device. It has 16 GPIO lines that are communicated >> with via i2c bus, and an interrupt line. >> >> Interrupt line is typicall

Re: pinctrl-sx150x.c broken in 4.11

2017-05-11 Thread Tony Lindgren
* Nikita Yushchenko [170511 09:27]: > > Hmm maybe yeah. I don't quite follow the above the "pinctrl-0 property > > of sx150x device tree node, is misinterpreted as hog" part though. > > sx150x is i2c-gpio device. It has 16 GPIO lines that are communicated > with via i2c bus, and an interrupt lin

Re: pinctrl-sx150x.c broken in 4.11

2017-05-11 Thread Nikita Yushchenko
> Hmm maybe yeah. I don't quite follow the above the "pinctrl-0 property > of sx150x device tree node, is misinterpreted as hog" part though. sx150x is i2c-gpio device. It has 16 GPIO lines that are communicated with via i2c bus, and an interrupt line. Interrupt line is typically connected to So

Re: pinctrl-sx150x.c broken in 4.11

2017-05-11 Thread Tony Lindgren
* Linus Walleij [170511 00:26]: > On Wed, May 10, 2017 at 9:32 PM, Nikita Yushchenko > wrote: > > > Looks like recent pinctrl changes - possibly commit 99e4f67508e1 > > ("pinctrl: core: Use delayed work for hogs") - breaks pinctrl-sx150x > > driver in all setups where it has any pinctrl settings

Re: pinctrl-sx150x.c broken in 4.11

2017-05-11 Thread Linus Walleij
On Wed, May 10, 2017 at 9:32 PM, Nikita Yushchenko wrote: > Looks like recent pinctrl changes - possibly commit 99e4f67508e1 > ("pinctrl: core: Use delayed work for hogs") - breaks pinctrl-sx150x > driver in all setups where it has any pinctrl settings in device tree. > > AFAIU, pinctrl-sx150x is

pinctrl-sx150x.c broken in 4.11

2017-05-10 Thread Nikita Yushchenko
Hi Looks like recent pinctrl changes - possibly commit 99e4f67508e1 ("pinctrl: core: Use delayed work for hogs") - breaks pinctrl-sx150x driver in all setups where it has any pinctrl settings in device tree. AFAIU, pinctrl-sx150x is not a real pinctrl/pinmux driver, but it uses pinctrl subsystem