Re: possible deadlock in send_sigio (2)

2021-02-01 Thread Dmitry Vyukov
On Fri, Jan 29, 2021 at 6:36 PM syzbot wrote: > > syzbot suspects this issue was fixed by commit: > > commit 8d1ddb5e79374fb277985a6b3faa2ed8631c5b4c > Author: Boqun Feng > Date: Thu Nov 5 06:23:51 2020 + > > fcntl: Fix potential deadlock in send_sig{io, urg}() > > bisection log:

Re: possible deadlock in send_sigio (2)

2021-01-29 Thread syzbot
syzbot suspects this issue was fixed by commit: commit 8d1ddb5e79374fb277985a6b3faa2ed8631c5b4c Author: Boqun Feng Date: Thu Nov 5 06:23:51 2020 + fcntl: Fix potential deadlock in send_sig{io, urg}() bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=17455db4d0 start

Re: possible deadlock in send_sigio (2)

2020-11-04 Thread syzbot
syzbot has bisected this issue to: commit e918188611f073063415f40fae568fa4d86d9044 Author: Boqun Feng Date: Fri Aug 7 07:42:20 2020 + locking: More accurate annotations for read_lock() bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=15fbef3250 start commit:

Re: possible deadlock in send_sigio (2)

2020-11-04 Thread syzbot
syzbot has found a reproducer for the following issue on: HEAD commit:4ef8451b Merge tag 'perf-tools-for-v5.10-2020-11-03' of gi.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1321012a50 kernel config:

possible deadlock in send_sigio (2)

2020-09-09 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:dff9f829 Add linux-next specific files for 20200908 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=17521b3590 kernel config: https://syzkaller.appspot.com/x/.config?x=37b3426c77bda44c dashboard

Re: possible deadlock in send_sigio

2020-06-15 Thread Waiman Long
On 6/15/20 8:13 PM, Boqun Feng wrote: Hi Matthew, On Mon, Jun 15, 2020 at 01:40:46PM -0700, Matthew Wilcox wrote: On Mon, Jun 15, 2020 at 01:13:51PM -0400, Waiman Long wrote: On 6/15/20 12:49 PM, Matthew Wilcox wrote: On Fri, Jun 12, 2020 at 03:01:01PM +0800, Boqun Feng wrote: On the archs

Re: possible deadlock in send_sigio

2020-06-15 Thread Boqun Feng
Hi Matthew, On Mon, Jun 15, 2020 at 01:40:46PM -0700, Matthew Wilcox wrote: > On Mon, Jun 15, 2020 at 01:13:51PM -0400, Waiman Long wrote: > > On 6/15/20 12:49 PM, Matthew Wilcox wrote: > > > On Fri, Jun 12, 2020 at 03:01:01PM +0800, Boqun Feng wrote: > > > > On the archs using QUEUED_RWLOCKS,

Re: possible deadlock in send_sigio

2020-06-15 Thread Matthew Wilcox
On Mon, Jun 15, 2020 at 01:13:51PM -0400, Waiman Long wrote: > On 6/15/20 12:49 PM, Matthew Wilcox wrote: > > On Fri, Jun 12, 2020 at 03:01:01PM +0800, Boqun Feng wrote: > > > On the archs using QUEUED_RWLOCKS, read_lock() is not always a recursive > > > read lock, actually it's only recursive if

Re: possible deadlock in send_sigio

2020-06-15 Thread Waiman Long
On 6/15/20 12:49 PM, Matthew Wilcox wrote: On Fri, Jun 12, 2020 at 03:01:01PM +0800, Boqun Feng wrote: On the archs using QUEUED_RWLOCKS, read_lock() is not always a recursive read lock, actually it's only recursive if in_interrupt() is true. So change the annotation accordingly to catch more

Re: possible deadlock in send_sigio

2020-06-15 Thread Matthew Wilcox
On Fri, Jun 12, 2020 at 03:01:01PM +0800, Boqun Feng wrote: > On the archs using QUEUED_RWLOCKS, read_lock() is not always a recursive > read lock, actually it's only recursive if in_interrupt() is true. So > change the annotation accordingly to catch more deadlocks. [...] > +#ifdef

Re: possible deadlock in send_sigio

2020-06-15 Thread Waiman Long
On 6/12/20 3:01 AM, Boqun Feng wrote: On Fri, Jun 12, 2020 at 07:55:26AM +0800, Boqun Feng wrote: Hi Peter and Waiman, On Thu, Jun 11, 2020 at 12:09:59PM -0400, Waiman Long wrote: On 6/11/20 10:22 AM, Peter Zijlstra wrote: On Thu, Jun 11, 2020 at 09:51:29AM -0400, Waiman Long wrote: There

Re: possible deadlock in send_sigio

2020-06-12 Thread Boqun Feng
On Fri, Jun 12, 2020 at 07:55:26AM +0800, Boqun Feng wrote: > Hi Peter and Waiman, > > On Thu, Jun 11, 2020 at 12:09:59PM -0400, Waiman Long wrote: > > On 6/11/20 10:22 AM, Peter Zijlstra wrote: > > > On Thu, Jun 11, 2020 at 09:51:29AM -0400, Waiman Long wrote: > > > > > > > There was an old

Re: possible deadlock in send_sigio

2020-06-11 Thread Waiman Long
On 6/11/20 7:55 PM, Boqun Feng wrote: Hi Peter and Waiman, On Thu, Jun 11, 2020 at 12:09:59PM -0400, Waiman Long wrote: On 6/11/20 10:22 AM, Peter Zijlstra wrote: On Thu, Jun 11, 2020 at 09:51:29AM -0400, Waiman Long wrote: There was an old lockdep patch that I think may address the issue,

Re: possible deadlock in send_sigio

2020-06-11 Thread Boqun Feng
Hi Peter and Waiman, On Thu, Jun 11, 2020 at 12:09:59PM -0400, Waiman Long wrote: > On 6/11/20 10:22 AM, Peter Zijlstra wrote: > > On Thu, Jun 11, 2020 at 09:51:29AM -0400, Waiman Long wrote: > > > > > There was an old lockdep patch that I think may address the issue, but was > > > not merged at

Re: possible deadlock in send_sigio

2020-06-11 Thread Eric W. Biederman
Waiman Long writes: > On 4/4/20 1:55 AM, syzbot wrote: >> Hello, >> >> syzbot found the following crash on: >> >> HEAD commit:bef7b2a7 Merge tag 'devicetree-for-5.7' of git://git.kerne.. >> git tree: upstream >> console output: https://syzkaller.appspot.com/x/log.txt?x=15f39c5de0

Re: possible deadlock in send_sigio

2020-06-11 Thread Waiman Long
On 6/11/20 10:22 AM, Peter Zijlstra wrote: On Thu, Jun 11, 2020 at 09:51:29AM -0400, Waiman Long wrote: There was an old lockdep patch that I think may address the issue, but was not merged at the time. I will need to dig it out and see if it can be adapted to work in the current kernel. It

Re: possible deadlock in send_sigio

2020-06-11 Thread Peter Zijlstra
On Thu, Jun 11, 2020 at 09:51:29AM -0400, Waiman Long wrote: > There was an old lockdep patch that I think may address the issue, but was > not merged at the time. I will need to dig it out and see if it can be > adapted to work in the current kernel. It may take some time. Boqun was working on

Re: possible deadlock in send_sigio

2020-06-11 Thread Waiman Long
On 6/11/20 3:43 AM, Dmitry Vyukov wrote: On Thu, Jun 11, 2020 at 4:33 AM Waiman Long wrote: On 4/4/20 1:55 AM, syzbot wrote: Hello, syzbot found the following crash on: HEAD commit:bef7b2a7 Merge tag 'devicetree-for-5.7' of git://git.kerne.. git tree: upstream console output:

Re: possible deadlock in send_sigio

2020-06-11 Thread Dmitry Vyukov
On Thu, Jun 11, 2020 at 4:33 AM Waiman Long wrote: > > On 4/4/20 1:55 AM, syzbot wrote: > > Hello, > > > > syzbot found the following crash on: > > > > HEAD commit:bef7b2a7 Merge tag 'devicetree-for-5.7' of git://git.kerne.. > > git tree: upstream > > console output:

Re: possible deadlock in send_sigio

2020-06-10 Thread Waiman Long
On 4/4/20 1:55 AM, syzbot wrote: Hello, syzbot found the following crash on: HEAD commit:bef7b2a7 Merge tag 'devicetree-for-5.7' of git://git.kerne.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=15f39c5de0 kernel config: