Re: powerpc/nvram: Move an assignment for the variable "ret" in dev_nvram_write()

2017-01-20 Thread Tyrel Datwyler
On 01/19/2017 11:08 PM, SF Markus Elfring wrote: >> I think you really could have squashed patches 1-3 into a single patch >> that returns directly after any failure. > > Thanks for your constructive feedback. > > I have got software development concerns around such patch squashing. > > >> At

Re: powerpc/nvram: Move an assignment for the variable "ret" in dev_nvram_write()

2017-01-20 Thread Tyrel Datwyler
On 01/19/2017 11:08 PM, SF Markus Elfring wrote: >> I think you really could have squashed patches 1-3 into a single patch >> that returns directly after any failure. > > Thanks for your constructive feedback. > > I have got software development concerns around such patch squashing. > > >> At

Re: powerpc/nvram: Move an assignment for the variable "ret" in dev_nvram_write()

2017-01-19 Thread SF Markus Elfring
> I think you really could have squashed patches 1-3 into a single patch > that returns directly after any failure. Thanks for your constructive feedback. I have got software development concerns around such patch squashing. > At this point you might as well remove that label and move the

Re: powerpc/nvram: Move an assignment for the variable "ret" in dev_nvram_write()

2017-01-19 Thread SF Markus Elfring
> I think you really could have squashed patches 1-3 into a single patch > that returns directly after any failure. Thanks for your constructive feedback. I have got software development concerns around such patch squashing. > At this point you might as well remove that label and move the

Re: [PATCH 3/8] powerpc/nvram: Move an assignment for the variable "ret" in dev_nvram_write()

2017-01-19 Thread Tyrel Datwyler
On 01/19/2017 08:56 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 19 Jan 2017 15:55:36 +0100 > > A local variable was set to an error code before a concrete error situation > was detected. Thus move the corresponding assignment into an if branch

Re: [PATCH 3/8] powerpc/nvram: Move an assignment for the variable "ret" in dev_nvram_write()

2017-01-19 Thread Tyrel Datwyler
On 01/19/2017 08:56 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 19 Jan 2017 15:55:36 +0100 > > A local variable was set to an error code before a concrete error situation > was detected. Thus move the corresponding assignment into an if branch > to indicate a software

[PATCH 3/8] powerpc/nvram: Move an assignment for the variable "ret" in dev_nvram_write()

2017-01-19 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 19 Jan 2017 15:55:36 +0100 A local variable was set to an error code before a concrete error situation was detected. Thus move the corresponding assignment into an if branch to indicate a software failure there. This issue was

[PATCH 3/8] powerpc/nvram: Move an assignment for the variable "ret" in dev_nvram_write()

2017-01-19 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 19 Jan 2017 15:55:36 +0100 A local variable was set to an error code before a concrete error situation was detected. Thus move the corresponding assignment into an if branch to indicate a software failure there. This issue was detected by using the Coccinelle