Re: ptrace warning due to "cgroup: get rid of cgroup_freezer_frozen_exit()"

2019-05-08 Thread Roman Gushchin
Hello, Oleg! On Wed, May 08, 2019 at 05:25:36PM +0200, Oleg Nesterov wrote: > On 05/07, Roman Gushchin wrote: > > > > --- a/kernel/signal.c > > +++ b/kernel/signal.c > > @@ -2484,9 +2484,6 @@ bool get_signal(struct ksignal *ksig) > > sigdelset(>pending.signal, SIGKILL); > >

Re: ptrace warning due to "cgroup: get rid of cgroup_freezer_frozen_exit()"

2019-05-08 Thread Oleg Nesterov
On 05/07, Roman Gushchin wrote: > > --- a/kernel/signal.c > +++ b/kernel/signal.c > @@ -2484,9 +2484,6 @@ bool get_signal(struct ksignal *ksig) > sigdelset(>pending.signal, SIGKILL); > recalc_sigpending(); > current->jobctl &= ~JOBCTL_TRAP_FREEZE;

Re: ptrace warning due to "cgroup: get rid of cgroup_freezer_frozen_exit()"

2019-05-08 Thread Qian Cai
On Tue, 2019-05-07 at 21:37 +, Roman Gushchin wrote: > Can you, please, try if the following patch fixes the problem? It works great. > -- > > diff --git a/kernel/signal.c b/kernel/signal.c > index 16b72f4f14df..bf2f268f1386 100644 > --- a/kernel/signal.c > +++ b/kernel/signal.c > @@

Re: ptrace warning due to "cgroup: get rid of cgroup_freezer_frozen_exit()"

2019-05-07 Thread Roman Gushchin
On Tue, May 07, 2019 at 04:04:22PM -0400, Qian Cai wrote: > LTP ptrace01 test case triggers a warning below. Looks at ptrace_stop() calls > cgroup_enter_frozen() there in the cgroup v2 freezer. > > [ 8373.336330] WARNING: CPU: 56 PID: 67026 at kernel/cgroup/cgroup.c:6008 > cgroup_exit+0x2a9/0x2f0

ptrace warning due to "cgroup: get rid of cgroup_freezer_frozen_exit()"

2019-05-07 Thread Qian Cai
LTP ptrace01 test case triggers a warning below. Looks at ptrace_stop() calls cgroup_enter_frozen() there in the cgroup v2 freezer. [ 8373.336330] WARNING: CPU: 56 PID: 67026 at kernel/cgroup/cgroup.c:6008 cgroup_exit+0x2a9/0x2f0 [ 8373.345001] Modules linked in: brd ext4 crc16 mbcache jbd2