Re: refcounting problems with ibm_acpi but acpi=off

2007-08-07 Thread Henrique de Moraes Holschuh
On Tue, 07 Aug 2007, Pavel Machek wrote: > > > --- a/drivers/acpi/ibm_acpi.c > > > +++ b/drivers/acpi/ibm_acpi.c > > > @@ -2695,6 +2695,9 @@ static void acpi_ibm_exit(void) > > > { > > > int i; > > > > > > + if (acpi_disabled) > > > + return; > > > + > > > for (i = ARRAY_SIZE(ibms) -

Re: refcounting problems with ibm_acpi but acpi=off

2007-08-07 Thread Pavel Machek
Hi! > > --- a/drivers/acpi/ibm_acpi.c > > +++ b/drivers/acpi/ibm_acpi.c > > @@ -2695,6 +2695,9 @@ static void acpi_ibm_exit(void) > > { > > int i; > > > > + if (acpi_disabled) > > + return; > > + > > for (i = ARRAY_SIZE(ibms) - 1; i >= 0; i--) > > ibm_exit(&ibms[

Re: refcounting problems with ibm_acpi but acpi=off

2007-08-07 Thread Henrique de Moraes Holschuh
On Tue, 07 Aug 2007, Pavel Machek wrote: > Perhaps this is needed? > Pavel > > diff --git a/drivers/acpi/ibm_acpi.c b/drivers/acpi/ibm_acpi.c > index a664f2b..654a124 100644 > --- a/drivers/acpi/ibm_acpi.c > +++ b/drivers/acpi/ibm_acpi.

refcounting problems with ibm_acpi but acpi=off

2007-08-07 Thread Pavel Machek
Hi! I get this nastyness in syslog if I compile ibm_acpi into kernel, then boot with acpi=off. floppy0: no floppy controllers found loop: module loaded WARNING: at lib/kref.c:33 kref_get() [] kref_get+0x40/0x50 [] kobject_get+0xf/0x20 [] get_driver+0xe/0x20 [] driver_remove_file+0x13/0x40 []

Re: refcounting problems with ibm_acpi but acpi=off

2007-08-07 Thread Pavel Machek
Hi! > I get this nastyness in syslog if I compile ibm_acpi into kernel, then > boot with acpi=off. > Perhaps this is needed? Indeed the patch fixes it. Signed-off-by: Pavel Machek <[EMAIL PROTECTED]> > > diff --git a/drivers/acpi/ibm_acpi.c b/drivers/acpi/ibm_acpi.c > index a664f2b..654a124 10