Re: short-circuit and over-current IRQs

2021-02-01 Thread Mark Brown
On Sat, Jan 30, 2021 at 04:43:46PM +0100, AngeloGioacchino Del Regno wrote: > Il 29/01/21 10:14, Matti Vaittinen ha scritto: Please delete unneeded context from mails when replying. Doing this makes it much easier to find your reply in the message, helping ensure it won't be missed by people

Re: short-circuit and over-current IRQs

2021-01-31 Thread Matti Vaittinen
On Sat, 2021-01-30 at 16:43 +0100, AngeloGioacchino Del Regno wrote: > Il 29/01/21 10:14, Matti Vaittinen ha scritto: > > On Thu, 2021-01-28 at 12:10 +, Mark Brown wrote: > > > On Thu, Jan 28, 2021 at 09:23:08AM +, Vaittinen, Matti wrote: > > > > On Wed, 2021-01-27 at 16:32 +, Mark

Re: short-circuit and over-current IRQs

2021-01-30 Thread AngeloGioacchino Del Regno
Il 29/01/21 10:14, Matti Vaittinen ha scritto: On Thu, 2021-01-28 at 12:10 +, Mark Brown wrote: On Thu, Jan 28, 2021 at 09:23:08AM +, Vaittinen, Matti wrote: On Wed, 2021-01-27 at 16:32 +, Mark Brown wrote: Note that the events the API currently has are expected to be for the

Re: short-circuit and over-current IRQs

2021-01-28 Thread Vaittinen, Matti
On Thu, 2021-01-28 at 12:10 +, Mark Brown wrote: > On Thu, Jan 28, 2021 at 09:23:08AM +, Vaittinen, Matti wrote: > > On Wed, 2021-01-27 at 16:32 +, Mark Brown wrote: > > > Note that the events the API currently has are expected to be for > > > the > > > actual error conditions, not

Re: short-circuit and over-current IRQs

2021-01-28 Thread Mark Brown
On Thu, Jan 28, 2021 at 09:23:08AM +, Vaittinen, Matti wrote: > On Wed, 2021-01-27 at 16:32 +, Mark Brown wrote: > > Note that the events the API currently has are expected to be for the > > actual error conditions, not for the warning ones - indicating that > > the > > voltage is out of

Re: short-circuit and over-current IRQs

2021-01-28 Thread Vaittinen, Matti
On Wed, 2021-01-27 at 16:32 +, Mark Brown wrote: > On Wed, Jan 27, 2021 at 03:34:46PM +0100, AngeloGioacchino Del Regno > wrote: > > Il 27/01/21 13:56, Matti Vaittinen ha scritto: > > > I can only speak for BD9576MUF - which has two limits for > > > monitored > > > entity

Re: short-circuit and over-current IRQs

2021-01-27 Thread Mark Brown
On Wed, Jan 27, 2021 at 03:34:46PM +0100, AngeloGioacchino Del Regno wrote: > Il 27/01/21 13:56, Matti Vaittinen ha scritto: > > I can only speak for BD9576MUF - which has two limits for monitored > > entity (temperature/voltage). One limit being 'warning' limit (or > > 'detection' as data-sheet

Re: short-circuit and over-current IRQs

2021-01-27 Thread Vaittinen, Matti
On Wed, 2021-01-27 at 15:34 +0100, AngeloGioacchino Del Regno wrote: > Il 27/01/21 13:56, Matti Vaittinen ha scritto: > > Hello Mark, > > > > Hey Matti, hey Mark! > > > Nice to hear from you. :) > > > > On Wed, 2021-01-27 at 12:27 +, Mark Brown wrote: > > > On Wed, Jan 27, 2021 at

Re: short-circuit and over-current IRQs

2021-01-27 Thread AngeloGioacchino Del Regno
Il 27/01/21 13:56, Matti Vaittinen ha scritto: Hello Mark, Hey Matti, hey Mark! Nice to hear from you. :) On Wed, 2021-01-27 at 12:27 +, Mark Brown wrote: On Wed, Jan 27, 2021 at 12:01:55PM +, Vaittinen, Matti wrote: Anyways - I was wondering if this is common thing amongst many

Re: short-circuit and over-current IRQs

2021-01-27 Thread Matti Vaittinen
Hello Mark, Nice to hear from you. :) On Wed, 2021-01-27 at 12:27 +, Mark Brown wrote: > On Wed, Jan 27, 2021 at 12:01:55PM +, Vaittinen, Matti wrote: > > > Anyways - I was wondering if this is common thing amongst many > > PMICs? > > If yes - then, perhaps some generally useful

Re: short-circuit and over-current IRQs

2021-01-27 Thread Mark Brown
On Wed, Jan 27, 2021 at 12:01:55PM +, Vaittinen, Matti wrote: > Anyways - I was wondering if this is common thing amongst many PMICs? > If yes - then, perhaps some generally useful regulator helper could be > added to help implementing the IRQ disabling + scheduling worker to > check status

short-circuit and over-current IRQs

2021-01-27 Thread Vaittinen, Matti
Hi dee Ho peeps, I just noticed the 390af53e04114f790d60b63802a4de9d815ade03 ("regulator: qcom-labibb: Implement short-circuit and over-current IRQs") in regulator tree. No worries - I haven't hit any problem with it :] I've been working with ROHM BD9576MUF - which implements wa

[PATCH v4 5/7] regulator: qcom-labibb: Implement short-circuit and over-current IRQs

2021-01-19 Thread AngeloGioacchino Del Regno
Short-Circuit Protection (SCP) and Over-Current Protection (OCP) are very important for regulators like LAB and IBB, which are designed to provide from very small to relatively big amounts of current to the device (normally, a display). Now that this regulator supports both voltage setting and

[PATCH v3 5/7] regulator: qcom-labibb: Implement short-circuit and over-current IRQs

2021-01-17 Thread AngeloGioacchino Del Regno
Short-Circuit Protection (SCP) and Over-Current Protection (OCP) are very important for regulators like LAB and IBB, which are designed to provide from very small to relatively big amounts of current to the device (normally, a display). Now that this regulator supports both voltage setting and

Re: [PATCH v2 5/7] regulator: qcom-labibb: Implement short-circuit and over-current IRQs

2021-01-17 Thread AngeloGioacchino Del Regno
Il 15/01/21 06:31, Bjorn Andersson ha scritto: On Wed 13 Jan 13:42 CST 2021, AngeloGioacchino Del Regno wrote: Short-Circuit Protection (SCP) and Over-Current Protection (OCP) are very important for regulators like LAB and IBB, which are designed to provide from very small to relatively big

Re: [PATCH v2 5/7] regulator: qcom-labibb: Implement short-circuit and over-current IRQs

2021-01-14 Thread Bjorn Andersson
On Wed 13 Jan 13:42 CST 2021, AngeloGioacchino Del Regno wrote: > Short-Circuit Protection (SCP) and Over-Current Protection (OCP) are > very important for regulators like LAB and IBB, which are designed to > provide from very small to relatively big amounts of current to the > device (normally,

[PATCH v2 5/7] regulator: qcom-labibb: Implement short-circuit and over-current IRQs

2021-01-13 Thread AngeloGioacchino Del Regno
Short-Circuit Protection (SCP) and Over-Current Protection (OCP) are very important for regulators like LAB and IBB, which are designed to provide from very small to relatively big amounts of current to the device (normally, a display). Now that this regulator supports both voltage setting and

Re: [PATCH 5/7] regulator: qcom-labibb: Implement short-circuit and over-current IRQs

2021-01-13 Thread Mark Brown
On Tue, Jan 12, 2021 at 06:49:53PM +0100, AngeloGioacchino Del Regno wrote: > I would go for keeping the current binding for the aforementioned reasons. > Before I go on sending a V2, I would like to know your opinion. > Do you agree? Sure. signature.asc Description: PGP signature

Re: [PATCH 5/7] regulator: qcom-labibb: Implement short-circuit and over-current IRQs

2021-01-12 Thread AngeloGioacchino Del Regno
Il 12/01/21 18:29, Mark Brown ha scritto: On Mon, Jan 11, 2021 at 10:06:18PM +0100, AngeloGioacchino Del Regno wrote: ...which was already a requirement before I touched it. Now, this leaves two options here: 1. Keep the of_get_irq way, or 2. Move the interrupts, change the documentation

Re: [PATCH 5/7] regulator: qcom-labibb: Implement short-circuit and over-current IRQs

2021-01-12 Thread Mark Brown
On Mon, Jan 11, 2021 at 10:06:18PM +0100, AngeloGioacchino Del Regno wrote: > ...which was already a requirement before I touched it. > Now, this leaves two options here: > 1. Keep the of_get_irq way, or > 2. Move the interrupts, change the documentation (currently, only > pmi8998.dtsi) and also

Re: [PATCH 5/7] regulator: qcom-labibb: Implement short-circuit and over-current IRQs

2021-01-11 Thread AngeloGioacchino Del Regno
Il 11/01/21 20:23, AngeloGioacchino Del Regno ha scritto: Il 11/01/21 20:14, AngeloGioacchino Del Regno ha scritto: Il 11/01/21 14:57, Mark Brown ha scritto: On Sat, Jan 09, 2021 at 02:29:19PM +0100, AngeloGioacchino Del Regno wrote: +    /* If the regulator is not enabled, this is a fake

Re: [PATCH 5/7] regulator: qcom-labibb: Implement short-circuit and over-current IRQs

2021-01-11 Thread AngeloGioacchino Del Regno
Il 11/01/21 20:14, AngeloGioacchino Del Regno ha scritto: Il 11/01/21 14:57, Mark Brown ha scritto: On Sat, Jan 09, 2021 at 02:29:19PM +0100, AngeloGioacchino Del Regno wrote: +    /* If the regulator is not enabled, this is a fake event */ +    if (!ops->is_enabled(vreg->rdev)) +   

Re: [PATCH 5/7] regulator: qcom-labibb: Implement short-circuit and over-current IRQs

2021-01-11 Thread AngeloGioacchino Del Regno
Il 11/01/21 14:57, Mark Brown ha scritto: On Sat, Jan 09, 2021 at 02:29:19PM +0100, AngeloGioacchino Del Regno wrote: + /* If the regulator is not enabled, this is a fake event */ + if (!ops->is_enabled(vreg->rdev)) + return 0; Or handling the interrupt raced with a

Re: [PATCH 5/7] regulator: qcom-labibb: Implement short-circuit and over-current IRQs

2021-01-11 Thread Mark Brown
On Sat, Jan 09, 2021 at 02:29:19PM +0100, AngeloGioacchino Del Regno wrote: > + /* If the regulator is not enabled, this is a fake event */ > + if (!ops->is_enabled(vreg->rdev)) > + return 0; Or handling the interrupt raced with a disable initiated from elsewhere. Does the

[PATCH 5/7] regulator: qcom-labibb: Implement short-circuit and over-current IRQs

2021-01-09 Thread AngeloGioacchino Del Regno
Short-Circuit Protection (SCP) and Over-Current Protection (OCP) are very important for regulators like LAB and IBB, which are designed to provide from very small to relatively big amounts of current to the device (normally, a display). Now that this regulator supports both voltage setting and