Re: similar files: fusbh200-hcd.c and fotg210-hcd.c

On Tue, Sep 15, 2015 at 6:50 PM, Felipe Balbi wrote: > Hi, > > On Tue, Sep 15, 2015 at 06:41:55PM +0200, Peter Senna Tschudin wrote: >> On Tue, Sep 15, 2015 at 4:33 PM, Felipe Balbi wrote: >> > On Mon, Sep 14, 2015 at 07:50:02PM +0200, Peter Senna Tschudin wrote: >> >> On Mon, Sep 14, 2015 at

Re: similar files: fusbh200-hcd.c and fotg210-hcd.c

On Tue, Sep 15, 2015 at 6:50 PM, Felipe Balbi wrote: > Hi, > > On Tue, Sep 15, 2015 at 06:41:55PM +0200, Peter Senna Tschudin wrote: >> On Tue, Sep 15, 2015 at 4:33 PM, Felipe Balbi wrote: >> > On Mon, Sep 14, 2015 at 07:50:02PM +0200, Peter Senna Tschudin wrote: >>

Re: similar files: fusbh200-hcd.c and fotg210-hcd.c

Hi, On Tue, Sep 15, 2015 at 06:41:55PM +0200, Peter Senna Tschudin wrote: > On Tue, Sep 15, 2015 at 4:33 PM, Felipe Balbi wrote: > > On Mon, Sep 14, 2015 at 07:50:02PM +0200, Peter Senna Tschudin wrote: > >> On Mon, Sep 14, 2015 at 5:01 PM, Felipe Balbi wrote: > >> > On Sat, Sep 12, 2015 at

Re: similar files: fusbh200-hcd.c and fotg210-hcd.c

On Tue, Sep 15, 2015 at 4:33 PM, Felipe Balbi wrote: > On Mon, Sep 14, 2015 at 07:50:02PM +0200, Peter Senna Tschudin wrote: >> On Mon, Sep 14, 2015 at 5:01 PM, Felipe Balbi wrote: >> > On Sat, Sep 12, 2015 at 03:14:50PM +0200, Peter Senna Tschudin wrote: >> >> >> Should these files be

Re: similar files: fusbh200-hcd.c and fotg210-hcd.c

On Mon, Sep 14, 2015 at 07:50:02PM +0200, Peter Senna Tschudin wrote: > On Mon, Sep 14, 2015 at 5:01 PM, Felipe Balbi wrote: > > On Sat, Sep 12, 2015 at 03:14:50PM +0200, Peter Senna Tschudin wrote: > >> >> Should these files be consolidated? And if so how? > >> > if you can find an easy way,

Re: similar files: fusbh200-hcd.c and fotg210-hcd.c

On Tue, Sep 15, 2015 at 4:33 PM, Felipe Balbi wrote: > On Mon, Sep 14, 2015 at 07:50:02PM +0200, Peter Senna Tschudin wrote: >> On Mon, Sep 14, 2015 at 5:01 PM, Felipe Balbi wrote: >> > On Sat, Sep 12, 2015 at 03:14:50PM +0200, Peter Senna Tschudin wrote: >> >> >>

Re: similar files: fusbh200-hcd.c and fotg210-hcd.c

Hi, On Tue, Sep 15, 2015 at 06:41:55PM +0200, Peter Senna Tschudin wrote: > On Tue, Sep 15, 2015 at 4:33 PM, Felipe Balbi wrote: > > On Mon, Sep 14, 2015 at 07:50:02PM +0200, Peter Senna Tschudin wrote: > >> On Mon, Sep 14, 2015 at 5:01 PM, Felipe Balbi wrote: > >> >

Re: similar files: fusbh200-hcd.c and fotg210-hcd.c

On Mon, Sep 14, 2015 at 07:50:02PM +0200, Peter Senna Tschudin wrote: > On Mon, Sep 14, 2015 at 5:01 PM, Felipe Balbi wrote: > > On Sat, Sep 12, 2015 at 03:14:50PM +0200, Peter Senna Tschudin wrote: > >> >> Should these files be consolidated? And if so how? > >> > if you can find an

Re: similar files: fusbh200-hcd.c and fotg210-hcd.c

On Mon, Sep 14, 2015 at 5:01 PM, Felipe Balbi wrote: > On Sat, Sep 12, 2015 at 03:14:50PM +0200, Peter Senna Tschudin wrote: >> >> Should these files be consolidated? And if so how? >> > if you can find an easy way, that would be a very, very welcome patch. >> >> Is the ideal solution to

Re: similar files: fusbh200-hcd.c and fotg210-hcd.c

On Sat, Sep 12, 2015 at 03:14:50PM +0200, Peter Senna Tschudin wrote: > >> Should these files be consolidated? And if so how? > > if you can find an easy way, that would be a very, very welcome patch. > > Is the ideal solution to consolidate both fusbh200-hcd.c and > fotg210-hcd.c in a single

Re: similar files: fusbh200-hcd.c and fotg210-hcd.c

On Sat, Sep 12, 2015 at 03:14:50PM +0200, Peter Senna Tschudin wrote: > >> Should these files be consolidated? And if so how? > > if you can find an easy way, that would be a very, very welcome patch. > > Is the ideal solution to consolidate both fusbh200-hcd.c and > fotg210-hcd.c in a single

Re: similar files: fusbh200-hcd.c and fotg210-hcd.c

On Mon, Sep 14, 2015 at 5:01 PM, Felipe Balbi wrote: > On Sat, Sep 12, 2015 at 03:14:50PM +0200, Peter Senna Tschudin wrote: >> >> Should these files be consolidated? And if so how? >> > if you can find an easy way, that would be a very, very welcome patch. >> >> Is the ideal

Re: similar files: fusbh200-hcd.c and fotg210-hcd.c

>> Should these files be consolidated? And if so how? > if you can find an easy way, that would be a very, very welcome patch. Is the ideal solution to consolidate both fusbh200-hcd.c and fotg210-hcd.c in a single module? If this is the case, how to detect at run time which version of the hw is

Re: similar files: fusbh200-hcd.c and fotg210-hcd.c

>> Should these files be consolidated? And if so how? > if you can find an easy way, that would be a very, very welcome patch. Is the ideal solution to consolidate both fusbh200-hcd.c and fotg210-hcd.c in a single module? If this is the case, how to detect at run time which version of the hw is

Re: similar files: fusbh200-hcd.c and fotg210-hcd.c

On Mon, Sep 07, 2015 at 04:47:45PM +0200, Peter Senna Tschudin wrote: > I executed a clone detection tool* on drivers source code and I found > that the files > > drivers/usb/host/fusbh200-hcd.c > > and > > drivers/usb/host/fotg210-hcd.c > > are very similar. The main difference between the

Re: similar files: fusbh200-hcd.c and fotg210-hcd.c

On Mon, Sep 07, 2015 at 04:47:45PM +0200, Peter Senna Tschudin wrote: > I executed a clone detection tool* on drivers source code and I found > that the files > > drivers/usb/host/fusbh200-hcd.c > > and > > drivers/usb/host/fotg210-hcd.c > > are very similar. The main difference between the

similar files: fusbh200-hcd.c and fotg210-hcd.c

I executed a clone detection tool* on drivers source code and I found that the files drivers/usb/host/fusbh200-hcd.c and drivers/usb/host/fotg210-hcd.c are very similar. The main difference between the two files are replacing the string 'USBH20' by 'OTG21' and some white space fixes. Some

similar files: fusbh200-hcd.c and fotg210-hcd.c

I executed a clone detection tool* on drivers source code and I found that the files drivers/usb/host/fusbh200-hcd.c and drivers/usb/host/fotg210-hcd.c are very similar. The main difference between the two files are replacing the string 'USBH20' by 'OTG21' and some white space fixes. Some