Re: slub: don't panic for memcg kmem cache creation failure

2019-06-29 Thread Shakeel Butt
On Sat, Jun 29, 2019 at 7:05 AM Alexey Dobriyan wrote: > > > - if (flags & SLAB_PANIC) > > - panic("Cannot create slab %s size=%u realsize=%u order=%u > > offset=%u flags=%lx\n", > > - s->name, s->size, s->size, > > - oo_order(s->oo),

Re: slub: don't panic for memcg kmem cache creation failure

2019-06-29 Thread Alexey Dobriyan
> - if (flags & SLAB_PANIC) > - panic("Cannot create slab %s size=%u realsize=%u order=%u > offset=%u flags=%lx\n", > - s->name, s->size, s->size, > - oo_order(s->oo), s->offset, (unsigned long)flags); This is wrong. Without SLAB_PANIC

Re: [PATCH] slub: Don't panic for memcg kmem cache creation failure

2019-06-21 Thread David Rientjes
On Wed, 19 Jun 2019, Shakeel Butt wrote: > Currently for CONFIG_SLUB, if a memcg kmem cache creation is failed and > the corresponding root kmem cache has SLAB_PANIC flag, the kernel will > be crashed. This is unnecessary as the kernel can handle the creation > failures of memcg kmem caches.

Re: [PATCH] slub: Don't panic for memcg kmem cache creation failure

2019-06-20 Thread Michal Hocko
On Thu 20-06-19 07:44:27, Shakeel Butt wrote: > On Wed, Jun 19, 2019 at 10:50 PM Michal Hocko wrote: > > > > On Wed 19-06-19 16:25:14, Shakeel Butt wrote: > > > Currently for CONFIG_SLUB, if a memcg kmem cache creation is failed and > > > the corresponding root kmem cache has SLAB_PANIC flag, the

Re: [PATCH] slub: Don't panic for memcg kmem cache creation failure

2019-06-20 Thread Dave Hansen
On 6/20/19 7:44 AM, Shakeel Butt wrote: >> I am wondering whether SLAB_PANIC makes sense in general though. Why is >> it any different from any other essential early allocations? We tend to >> not care about allocation failures for those on bases that the system >> must be in a broken state to

Re: [PATCH] slub: Don't panic for memcg kmem cache creation failure

2019-06-20 Thread Shakeel Butt
On Wed, Jun 19, 2019 at 10:50 PM Michal Hocko wrote: > > On Wed 19-06-19 16:25:14, Shakeel Butt wrote: > > Currently for CONFIG_SLUB, if a memcg kmem cache creation is failed and > > the corresponding root kmem cache has SLAB_PANIC flag, the kernel will > > be crashed. This is unnecessary as the

Re: [PATCH] slub: Don't panic for memcg kmem cache creation failure

2019-06-19 Thread Michal Hocko
On Wed 19-06-19 16:25:14, Shakeel Butt wrote: > Currently for CONFIG_SLUB, if a memcg kmem cache creation is failed and > the corresponding root kmem cache has SLAB_PANIC flag, the kernel will > be crashed. This is unnecessary as the kernel can handle the creation > failures of memcg kmem caches.

[PATCH] slub: Don't panic for memcg kmem cache creation failure

2019-06-19 Thread Shakeel Butt
Currently for CONFIG_SLUB, if a memcg kmem cache creation is failed and the corresponding root kmem cache has SLAB_PANIC flag, the kernel will be crashed. This is unnecessary as the kernel can handle the creation failures of memcg kmem caches. Additionally CONFIG_SLAB does not implement this