Re: generic one-shot bug (was Re: sparc generic time / clockevents)

2007-02-25 Thread Thomas Gleixner
On Sat, 2007-02-24 at 21:13 -0800, David Miller wrote: > As I suspected, the one-shot code wasn't very well tested and I'd be > the one to debug this thing on sparc64 :-) > > When a timer exceeds the timer period, the one-shot handling code does > the following loop: > > for (;;) { >

generic one-shot bug (was Re: sparc generic time / clockevents)

2007-02-24 Thread David Miller
As I suspected, the one-shot code wasn't very well tested and I'd be the one to debug this thing on sparc64 :-) When a timer exceeds the timer period, the one-shot handling code does the following loop: for (;;) { ktime_t next = ktime_add(dev->next_event, tick_period);

Re: sparc generic time / clockevents

2007-02-23 Thread David Miller
From: john stultz <[EMAIL PROTECTED]> Date: Fri, 23 Feb 2007 16:53:27 -0800 > On Fri, 2007-02-23 at 16:34 -0800, David Miller wrote: > > + .shift = 16, > > > > These shift selections all seem rather arbitrary. > > > > If it's not an arbitrary selection, it would be nice to have some >

Re: sparc generic time / clockevents

2007-02-23 Thread john stultz
On Fri, 2007-02-23 at 16:34 -0800, David Miller wrote: > From: john stultz <[EMAIL PROTECTED]> > Date: Fri, 23 Feb 2007 11:51:18 -0800 > > > Yea. I actually have some in-progress patches from Peter Keilty that > > convert ia64 and sparc64 time_interpolators to clocksources, then > > removes the ti

Re: sparc generic time / clockevents

2007-02-23 Thread David Miller
From: john stultz <[EMAIL PROTECTED]> Date: Fri, 23 Feb 2007 11:51:18 -0800 > Yea. I actually have some in-progress patches from Peter Keilty that > convert ia64 and sparc64 time_interpolators to clocksources, then > removes the time_interpolator code. > > The ia64 conversion is more complicated

Re: sparc generic time / clockevents

2007-02-23 Thread Peter Keilty
john stultz wrote: On Fri, 2007-02-23 at 01:55 -0800, David Miller wrote: From: Thomas Gleixner <[EMAIL PROTECTED]> Date: Fri, 23 Feb 2007 10:56:18 +0100 On Fri, 2007-02-23 at 01:25 -0800, David Miller wrote: Yes, all you need is to omit the CLOCK_EVT_FEAT_PERIODIC flag when y

Re: sparc generic time / clockevents

2007-02-23 Thread john stultz
On Fri, 2007-02-23 at 01:55 -0800, David Miller wrote: > From: Thomas Gleixner <[EMAIL PROTECTED]> > Date: Fri, 23 Feb 2007 10:56:18 +0100 > > > On Fri, 2007-02-23 at 01:25 -0800, David Miller wrote: > > > > Yes, all you need is to omit the CLOCK_EVT_FEAT_PERIODIC flag when you > > > > register yo

Re: sparc generic time / clockevents

2007-02-23 Thread David Miller
From: Thomas Gleixner <[EMAIL PROTECTED]> Date: Fri, 23 Feb 2007 10:56:18 +0100 > On Fri, 2007-02-23 at 01:25 -0800, David Miller wrote: > > > Yes, all you need is to omit the CLOCK_EVT_FEAT_PERIODIC flag when you > > > register your device. > > > > Thanks a lot Thomas. > > > > I noticed while d

sparc generic time / clockevents [ was Re: NO_HZ: timer interrupt stuck ]

2007-02-23 Thread Thomas Gleixner
David, On Fri, 2007-02-23 at 01:25 -0800, David Miller wrote: > > Yes, all you need is to omit the CLOCK_EVT_FEAT_PERIODIC flag when you > > register your device. > > Thanks a lot Thomas. > > I noticed while doing this work that the generic clock code is > incompatible with the time interpolat