Re: spin_lock error in arch/i386/kernel/time.c on APM resume

2005-03-15 Thread George Anzinger
Pavel Machek wrote: Hi! I agree. Still in all that follows, no one has addressed the apparent race described above. The reason the system reported the errors that started this thread is that the APM restore code was trying to read the cmos clock (I assume to set the xtime clock) WHILE the

Re: spin_lock error in arch/i386/kernel/time.c on APM resume

2005-03-15 Thread George Anzinger
Pavel Machek wrote: Hi! I agree. Still in all that follows, no one has addressed the apparent race described above. The reason the system reported the errors that started this thread is that the APM restore code was trying to read the cmos clock (I assume to set the xtime clock) WHILE the

Re: spin_lock error in arch/i386/kernel/time.c on APM resume

2005-03-14 Thread Pavel Machek
Hi! > >>I agree. Still in all that follows, no one has addressed the apparent > >>race described above. The reason the system reported the errors that > >>started this thread is that the APM restore code was trying to read the > >>cmos clock (I assume to set the xtime clock) WHILE the timer

Re: spin_lock error in arch/i386/kernel/time.c on APM resume

2005-03-14 Thread George Anzinger
Pavel Machek wrote: Hi! And more... That this occures implies we are attempting to update the cmos clock on resume seems wrong. One would presume that the time is wrong at this time and we are about to save that wrong time. Possibly the APM code should change time_status to STA_UNSYNC on the

Re: spin_lock error in arch/i386/kernel/time.c on APM resume

2005-03-14 Thread George Anzinger
Pavel Machek wrote: Hi! And more... That this occures implies we are attempting to update the cmos clock on resume seems wrong. One would presume that the time is wrong at this time and we are about to save that wrong time. Possibly the APM code should change time_status to STA_UNSYNC on the

Re: spin_lock error in arch/i386/kernel/time.c on APM resume

2005-03-14 Thread Pavel Machek
Hi! I agree. Still in all that follows, no one has addressed the apparent race described above. The reason the system reported the errors that started this thread is that the APM restore code was trying to read the cmos clock (I assume to set the xtime clock) WHILE the timer interrupt

Re: spin_lock error in arch/i386/kernel/time.c on APM resume

2005-03-13 Thread Pavel Machek
Hi! > >>And more... That this occures implies we are attempting to update the cmos > >>clock on resume seems wrong. One would presume that the time is wrong at > >>this > >>time and we are about to save that wrong time. Possibly the APM code > >>should > >>change time_status to STA_UNSYNC on

Re: spin_lock error in arch/i386/kernel/time.c on APM resume

2005-03-13 Thread Pavel Machek
Hi! And more... That this occures implies we are attempting to update the cmos clock on resume seems wrong. One would presume that the time is wrong at this time and we are about to save that wrong time. Possibly the APM code should change time_status to STA_UNSYNC on the way into the

Re: spin_lock error in arch/i386/kernel/time.c on APM resume

2005-03-12 Thread Lee Revell
On Sat, 2005-03-12 at 07:56 -0800, George Anzinger wrote: > J. Bruce Fields wrote: > > On APM resume this morning on my Thinkpad X31, I got a "spin_lock is > > already locked" error; see below. This doesn't happen on every resume, > > though it's happened before. The kernel is 2.6.11 plus a

Re: spin_lock error in arch/i386/kernel/time.c on APM resume

2005-03-12 Thread Barry K. Nathan
On Sat, Mar 12, 2005 at 07:56:10AM -0800, George Anzinger wrote: > Yesterday's night mare, todays bug :( Actually, I think people have been hitting this bug for a few months on Fedora Core, so it's not really *today's* bug... This might be the first time it's getting discussed on LKML though. (I

Re: spin_lock error in arch/i386/kernel/time.c on APM resume

2005-03-12 Thread George Anzinger
Zwane Mwaikambo wrote: On Sat, 12 Mar 2005, George Anzinger wrote: I agree. Still in all that follows, no one has addressed the apparent race described above. The reason the system reported the errors that started this thread is that the APM restore code was trying to read the cmos clock (I

Re: spin_lock error in arch/i386/kernel/time.c on APM resume

2005-03-12 Thread Zwane Mwaikambo
On Sat, 12 Mar 2005, George Anzinger wrote: > I agree. Still in all that follows, no one has addressed the apparent race > described above. The reason the system reported the errors that started this > thread is that the APM restore code was trying to read the cmos clock (I > assume to set the

Re: spin_lock error in arch/i386/kernel/time.c on APM resume

2005-03-12 Thread George Anzinger
Zwane Mwaikambo wrote: On Sat, 12 Mar 2005, George Anzinger wrote: Looks like we need the irq on the read clock also. This is true both before and after the prior cmos_time changes. The attached replaces the patch I sent yesterday. For those wanting to fix the kernel with out those patches, all

Re: spin_lock error in arch/i386/kernel/time.c on APM resume

2005-03-12 Thread Venkatesh Pallipadi
On Sat, Mar 12, 2005 at 09:46:54AM -0700, Zwane Mwaikambo wrote: > On Sat, 12 Mar 2005, Venkatesh Pallipadi wrote: > > > On Sat, Mar 12, 2005 at 09:25:13AM -0700, Zwane Mwaikambo wrote: > > > > How about this patch? Also fixes one other use of rtc_lock in > > acpi/sleep/proc.c > > > > rtc_lock

Re: spin_lock error in arch/i386/kernel/time.c on APM resume

2005-03-12 Thread Zwane Mwaikambo
On Sat, 12 Mar 2005, Venkatesh Pallipadi wrote: > On Sat, Mar 12, 2005 at 09:25:13AM -0700, Zwane Mwaikambo wrote: > > On Sat, 12 Mar 2005, George Anzinger wrote: > > > > > And more... That this occures implies we are attempting to update the cmos > > > clock on resume seems wrong. One would

Re: spin_lock error in arch/i386/kernel/time.c on APM resume

2005-03-12 Thread Venkatesh Pallipadi
On Sat, Mar 12, 2005 at 09:25:13AM -0700, Zwane Mwaikambo wrote: > On Sat, 12 Mar 2005, George Anzinger wrote: > > > And more... That this occures implies we are attempting to update the cmos > > clock on resume seems wrong. One would presume that the time is wrong at > > this > > time and we

Re: spin_lock error in arch/i386/kernel/time.c on APM resume

2005-03-12 Thread Zwane Mwaikambo
On Sat, 12 Mar 2005, George Anzinger wrote: > Looks like we need the irq on the read clock also. This is true both before > and after the prior cmos_time changes. > > The attached replaces the patch I sent yesterday. > > For those wanting to fix the kernel with out those patches, all that is

Re: spin_lock error in arch/i386/kernel/time.c on APM resume

2005-03-12 Thread George Anzinger
J. Bruce Fields wrote: On APM resume this morning on my Thinkpad X31, I got a "spin_lock is already locked" error; see below. This doesn't happen on every resume, though it's happened before. The kernel is 2.6.11 plus a bunch of (hopefully unrelated...) NFS patches. Any ideas? Yesterday's night

spin_lock error in arch/i386/kernel/time.c on APM resume

2005-03-12 Thread J. Bruce Fields
On APM resume this morning on my Thinkpad X31, I got a "spin_lock is already locked" error; see below. This doesn't happen on every resume, though it's happened before. The kernel is 2.6.11 plus a bunch of (hopefully unrelated...) NFS patches. Any ideas? --Bruce Fields Mar 12 07:07:29 puzzle

spin_lock error in arch/i386/kernel/time.c on APM resume

2005-03-12 Thread J. Bruce Fields
On APM resume this morning on my Thinkpad X31, I got a spin_lock is already locked error; see below. This doesn't happen on every resume, though it's happened before. The kernel is 2.6.11 plus a bunch of (hopefully unrelated...) NFS patches. Any ideas? --Bruce Fields Mar 12 07:07:29 puzzle

Re: spin_lock error in arch/i386/kernel/time.c on APM resume

2005-03-12 Thread George Anzinger
J. Bruce Fields wrote: On APM resume this morning on my Thinkpad X31, I got a spin_lock is already locked error; see below. This doesn't happen on every resume, though it's happened before. The kernel is 2.6.11 plus a bunch of (hopefully unrelated...) NFS patches. Any ideas? Yesterday's night

Re: spin_lock error in arch/i386/kernel/time.c on APM resume

2005-03-12 Thread Zwane Mwaikambo
On Sat, 12 Mar 2005, George Anzinger wrote: Looks like we need the irq on the read clock also. This is true both before and after the prior cmos_time changes. The attached replaces the patch I sent yesterday. For those wanting to fix the kernel with out those patches, all that is needed

Re: spin_lock error in arch/i386/kernel/time.c on APM resume

2005-03-12 Thread Venkatesh Pallipadi
On Sat, Mar 12, 2005 at 09:25:13AM -0700, Zwane Mwaikambo wrote: On Sat, 12 Mar 2005, George Anzinger wrote: And more... That this occures implies we are attempting to update the cmos clock on resume seems wrong. One would presume that the time is wrong at this time and we are about

Re: spin_lock error in arch/i386/kernel/time.c on APM resume

2005-03-12 Thread Zwane Mwaikambo
On Sat, 12 Mar 2005, Venkatesh Pallipadi wrote: On Sat, Mar 12, 2005 at 09:25:13AM -0700, Zwane Mwaikambo wrote: On Sat, 12 Mar 2005, George Anzinger wrote: And more... That this occures implies we are attempting to update the cmos clock on resume seems wrong. One would presume that

Re: spin_lock error in arch/i386/kernel/time.c on APM resume

2005-03-12 Thread Venkatesh Pallipadi
On Sat, Mar 12, 2005 at 09:46:54AM -0700, Zwane Mwaikambo wrote: On Sat, 12 Mar 2005, Venkatesh Pallipadi wrote: On Sat, Mar 12, 2005 at 09:25:13AM -0700, Zwane Mwaikambo wrote: How about this patch? Also fixes one other use of rtc_lock in acpi/sleep/proc.c rtc_lock is held during

Re: spin_lock error in arch/i386/kernel/time.c on APM resume

2005-03-12 Thread George Anzinger
Zwane Mwaikambo wrote: On Sat, 12 Mar 2005, George Anzinger wrote: Looks like we need the irq on the read clock also. This is true both before and after the prior cmos_time changes. The attached replaces the patch I sent yesterday. For those wanting to fix the kernel with out those patches, all

Re: spin_lock error in arch/i386/kernel/time.c on APM resume

2005-03-12 Thread Zwane Mwaikambo
On Sat, 12 Mar 2005, George Anzinger wrote: I agree. Still in all that follows, no one has addressed the apparent race described above. The reason the system reported the errors that started this thread is that the APM restore code was trying to read the cmos clock (I assume to set the

Re: spin_lock error in arch/i386/kernel/time.c on APM resume

2005-03-12 Thread George Anzinger
Zwane Mwaikambo wrote: On Sat, 12 Mar 2005, George Anzinger wrote: I agree. Still in all that follows, no one has addressed the apparent race described above. The reason the system reported the errors that started this thread is that the APM restore code was trying to read the cmos clock (I

Re: spin_lock error in arch/i386/kernel/time.c on APM resume

2005-03-12 Thread Barry K. Nathan
On Sat, Mar 12, 2005 at 07:56:10AM -0800, George Anzinger wrote: Yesterday's night mare, todays bug :( Actually, I think people have been hitting this bug for a few months on Fedora Core, so it's not really *today's* bug... This might be the first time it's getting discussed on LKML though. (I

Re: spin_lock error in arch/i386/kernel/time.c on APM resume

2005-03-12 Thread Lee Revell
On Sat, 2005-03-12 at 07:56 -0800, George Anzinger wrote: J. Bruce Fields wrote: On APM resume this morning on my Thinkpad X31, I got a spin_lock is already locked error; see below. This doesn't happen on every resume, though it's happened before. The kernel is 2.6.11 plus a bunch of