Re: staging: rtl8723bs: bug or pointless if else ?

2018-06-28 Thread Joe Perches
On Thu, 2018-06-28 at 11:34 +0200, Bastien Nocera wrote: > On Thu, 2018-06-28 at 10:22 +0200, Hans de Goede wrote: > > On 28-06-18 09:43, Michael Straube wrote: > > > ret = rtw_resume_process(padapter) > > > Is this a bug or is the if else construct just pointless? > > It probably is just

Re: staging: rtl8723bs: bug or pointless if else ?

2018-06-28 Thread Joe Perches
On Thu, 2018-06-28 at 11:34 +0200, Bastien Nocera wrote: > On Thu, 2018-06-28 at 10:22 +0200, Hans de Goede wrote: > > On 28-06-18 09:43, Michael Straube wrote: > > > ret = rtw_resume_process(padapter) > > > Is this a bug or is the if else construct just pointless? > > It probably is just

Re: staging: rtl8723bs: bug or pointless if else ?

2018-06-28 Thread Hans de Goede
Hi, On 28-06-18 17:00, Michael Straube wrote: On 06/28/18 11:34, Bastien Nocera wrote: On Thu, 2018-06-28 at 10:22 +0200, Hans de Goede wrote: Hi, On 28-06-18 09:43, Michael Straube wrote: Hi, I stumbled upon the following if else construct in

Re: staging: rtl8723bs: bug or pointless if else ?

2018-06-28 Thread Hans de Goede
Hi, On 28-06-18 17:00, Michael Straube wrote: On 06/28/18 11:34, Bastien Nocera wrote: On Thu, 2018-06-28 at 10:22 +0200, Hans de Goede wrote: Hi, On 28-06-18 09:43, Michael Straube wrote: Hi, I stumbled upon the following if else construct in

Re: staging: rtl8723bs: bug or pointless if else ?

2018-06-28 Thread Michael Straube
On 06/28/18 11:34, Bastien Nocera wrote: On Thu, 2018-06-28 at 10:22 +0200, Hans de Goede wrote: Hi, On 28-06-18 09:43, Michael Straube wrote: Hi, I stumbled upon the following if else construct in drivers/staging/rtl8723bs/os_dep/sdio_intf.c:618 if (pwrpriv->bInternalAutoSuspend)

Re: staging: rtl8723bs: bug or pointless if else ?

2018-06-28 Thread Michael Straube
On 06/28/18 11:34, Bastien Nocera wrote: On Thu, 2018-06-28 at 10:22 +0200, Hans de Goede wrote: Hi, On 28-06-18 09:43, Michael Straube wrote: Hi, I stumbled upon the following if else construct in drivers/staging/rtl8723bs/os_dep/sdio_intf.c:618 if (pwrpriv->bInternalAutoSuspend)

Re: staging: rtl8723bs: bug or pointless if else ?

2018-06-28 Thread Greg Kroah-Hartman
On Thu, Jun 28, 2018 at 09:43:47AM +0200, Michael Straube wrote: > Hi, > > I stumbled upon the following if else construct in > drivers/staging/rtl8723bs/os_dep/sdio_intf.c:618 > > if (pwrpriv->bInternalAutoSuspend) > { > ret = rtw_resume_process(padapter); >

Re: staging: rtl8723bs: bug or pointless if else ?

2018-06-28 Thread Greg Kroah-Hartman
On Thu, Jun 28, 2018 at 09:43:47AM +0200, Michael Straube wrote: > Hi, > > I stumbled upon the following if else construct in > drivers/staging/rtl8723bs/os_dep/sdio_intf.c:618 > > if (pwrpriv->bInternalAutoSuspend) > { > ret = rtw_resume_process(padapter); >

Re: staging: rtl8723bs: bug or pointless if else ?

2018-06-28 Thread Bastien Nocera
On Thu, 2018-06-28 at 10:22 +0200, Hans de Goede wrote: > Hi, > > On 28-06-18 09:43, Michael Straube wrote: > > Hi, > > > > I stumbled upon the following if else construct in > > drivers/staging/rtl8723bs/os_dep/sdio_intf.c:618 > > > > if (pwrpriv->bInternalAutoSuspend) > > {

Re: staging: rtl8723bs: bug or pointless if else ?

2018-06-28 Thread Bastien Nocera
On Thu, 2018-06-28 at 10:22 +0200, Hans de Goede wrote: > Hi, > > On 28-06-18 09:43, Michael Straube wrote: > > Hi, > > > > I stumbled upon the following if else construct in > > drivers/staging/rtl8723bs/os_dep/sdio_intf.c:618 > > > > if (pwrpriv->bInternalAutoSuspend) > > {

Re: staging: rtl8723bs: bug or pointless if else ?

2018-06-28 Thread Hans de Goede
Hi, On 28-06-18 09:43, Michael Straube wrote: Hi, I stumbled upon the following if else construct in drivers/staging/rtl8723bs/os_dep/sdio_intf.c:618     if (pwrpriv->bInternalAutoSuspend)     {     ret = rtw_resume_process(padapter);     }     else     {

Re: staging: rtl8723bs: bug or pointless if else ?

2018-06-28 Thread Hans de Goede
Hi, On 28-06-18 09:43, Michael Straube wrote: Hi, I stumbled upon the following if else construct in drivers/staging/rtl8723bs/os_dep/sdio_intf.c:618     if (pwrpriv->bInternalAutoSuspend)     {     ret = rtw_resume_process(padapter);     }     else     {

staging: rtl8723bs: bug or pointless if else ?

2018-06-28 Thread Michael Straube
Hi, I stumbled upon the following if else construct in drivers/staging/rtl8723bs/os_dep/sdio_intf.c:618 if (pwrpriv->bInternalAutoSuspend) { ret = rtw_resume_process(padapter); } else { if (pwrpriv->wowlan_mode ||

staging: rtl8723bs: bug or pointless if else ?

2018-06-28 Thread Michael Straube
Hi, I stumbled upon the following if else construct in drivers/staging/rtl8723bs/os_dep/sdio_intf.c:618 if (pwrpriv->bInternalAutoSuspend) { ret = rtw_resume_process(padapter); } else { if (pwrpriv->wowlan_mode ||