Re: subdevice config into pointer (was Re: [PATCH 1/4] v4l2: device_register_subdev_nodes: allow calling multiple times)

2017-03-03 Thread Pavel Machek
Hi! > > > > > Making the sub-device bus configuration a pointer should be in a > > > > > separate > > > > > patch. It makes sense since the entire configuration is not valid for > > > > > all > > > > > sub-devices attached to the ISP anymore. I think it originally was a > > > > > separate patch,

Re: subdevice config into pointer (was Re: [PATCH 1/4] v4l2: device_register_subdev_nodes: allow calling multiple times)

2017-03-02 Thread Pavel Machek
Hi! > > > static int isp_fwnode_parse(struct device *dev, struct fwnode_handle > > > *fwn, > > > > > > struct isp_async_subdev *isd) > > > > > > { > > > > > > - struct isp_bus_cfg *buscfg = &isd->bus; > > > + struct isp_bus_cfg *buscfg; > > > > > > struct v4l2_fwno

Re: subdevice config into pointer (was Re: [PATCH 1/4] v4l2: device_register_subdev_nodes: allow calling multiple times)

2017-03-02 Thread Sakari Ailus
Hi Laurent, On Thu, Mar 02, 2017 at 08:39:51PM +0200, Laurent Pinchart wrote: > Hi Sakari, > > On Thursday 02 Mar 2017 16:16:17 Sakari Ailus wrote: > > On Thu, Mar 02, 2017 at 10:07:27AM +0100, Pavel Machek wrote: > > > Hi! > > > > > > > Making the sub-device bus configuration a pointer should b

Re: subdevice config into pointer (was Re: [PATCH 1/4] v4l2: device_register_subdev_nodes: allow calling multiple times)

2017-03-02 Thread Laurent Pinchart
Hi Sakari, On Thursday 02 Mar 2017 16:16:17 Sakari Ailus wrote: > On Thu, Mar 02, 2017 at 10:07:27AM +0100, Pavel Machek wrote: > > Hi! > > > > > Making the sub-device bus configuration a pointer should be in a > > > separate patch. It makes sense since the entire configuration is not > > > valid

Re: subdevice config into pointer (was Re: [PATCH 1/4] v4l2: device_register_subdev_nodes: allow calling multiple times)

2017-03-02 Thread Sakari Ailus
Hi Pavel, On Thu, Mar 02, 2017 at 03:58:08PM +0100, Pavel Machek wrote: > Hi! > > > > > Making the sub-device bus configuration a pointer should be in a > > > > separate > > > > patch. It makes sense since the entire configuration is not valid for > > > > all > > > > sub-devices attached to the

Re: subdevice config into pointer (was Re: [PATCH 1/4] v4l2: device_register_subdev_nodes: allow calling multiple times)

2017-03-02 Thread Pavel Machek
Hi! > > > Making the sub-device bus configuration a pointer should be in a separate > > > patch. It makes sense since the entire configuration is not valid for all > > > sub-devices attached to the ISP anymore. I think it originally was a > > > separate patch, but they probably have been merged at

Re: subdevice config into pointer (was Re: [PATCH 1/4] v4l2: device_register_subdev_nodes: allow calling multiple times)

2017-03-02 Thread Sakari Ailus
Hi Pavel, On Thu, Mar 02, 2017 at 10:07:27AM +0100, Pavel Machek wrote: > Hi! > > > Making the sub-device bus configuration a pointer should be in a separate > > patch. It makes sense since the entire configuration is not valid for all > > sub-devices attached to the ISP anymore. I think it origi

subdevice config into pointer (was Re: [PATCH 1/4] v4l2: device_register_subdev_nodes: allow calling multiple times)

2017-03-02 Thread Pavel Machek
Hi! > Making the sub-device bus configuration a pointer should be in a separate > patch. It makes sense since the entire configuration is not valid for all > sub-devices attached to the ISP anymore. I think it originally was a > separate patch, but they probably have been merged at some point. I c