Re: the usage of DEBUG_DRIVER seems ambiguous

2007-03-09 Thread Stefan Richter
Robert P. J. Day wrote: > On Fri, 9 Mar 2007, Artem Bityutskiy wrote: >> Randy Dunlap wrote: >> > The ones in drivers/net/ are just local driver debug controls. >> > They happen to have the same name as a (likely newer) kconfig symbol. >> > >> > Is there a real problem that needs to be fixed? >>

Re: the usage of DEBUG_DRIVER seems ambiguous

2007-03-09 Thread Robert P. J. Day
On Fri, 9 Mar 2007, Artem Bityutskiy wrote: > Randy Dunlap wrote: > > > it's clearly a configuration variable, but it's also being used by > > > itself in a few drivers/net/ source files. is that deliberate? > > > > The ones in drivers/net/ are just local driver debug controls. > > They happen

Re: the usage of DEBUG_DRIVER seems ambiguous

2007-03-09 Thread Artem Bityutskiy
Randy Dunlap wrote: it's clearly a configuration variable, but it's also being used by itself in a few drivers/net/ source files. is that deliberate? The ones in drivers/net/ are just local driver debug controls. They happen to have the same name as a (likely newer) kconfig symbol. Is

Re: the usage of DEBUG_DRIVER seems ambiguous

2007-03-09 Thread Artem Bityutskiy
Randy Dunlap wrote: it's clearly a configuration variable, but it's also being used by itself in a few drivers/net/ source files. is that deliberate? The ones in drivers/net/ are just local driver debug controls. They happen to have the same name as a (likely newer) kconfig symbol. Is

Re: the usage of DEBUG_DRIVER seems ambiguous

2007-03-09 Thread Robert P. J. Day
On Fri, 9 Mar 2007, Artem Bityutskiy wrote: Randy Dunlap wrote: it's clearly a configuration variable, but it's also being used by itself in a few drivers/net/ source files. is that deliberate? The ones in drivers/net/ are just local driver debug controls. They happen to have the

Re: the usage of DEBUG_DRIVER seems ambiguous

2007-03-09 Thread Stefan Richter
Robert P. J. Day wrote: On Fri, 9 Mar 2007, Artem Bityutskiy wrote: Randy Dunlap wrote: The ones in drivers/net/ are just local driver debug controls. They happen to have the same name as a (likely newer) kconfig symbol. Is there a real problem that needs to be fixed? Renaming them

Re: the usage of DEBUG_DRIVER seems ambiguous

2007-03-08 Thread Robert P. J. Day
On Thu, 8 Mar 2007, Randy Dunlap wrote: > On Wed, 7 Mar 2007 19:44:41 -0500 (EST) Robert P. J. Day wrote: > > > > > the usage of the DEBUG_DRIVER preprocessor variable is a big > > confusing: > > > > $ $ grep -rw DEBUG_DRIVER * > > drivers/net/sunlance.c:#undef DEBUG_DRIVER > >

Re: the usage of DEBUG_DRIVER seems ambiguous

2007-03-08 Thread Randy Dunlap
On Wed, 7 Mar 2007 19:44:41 -0500 (EST) Robert P. J. Day wrote: > > the usage of the DEBUG_DRIVER preprocessor variable is a big > confusing: > > $ $ grep -rw DEBUG_DRIVER * > drivers/net/sunlance.c:#undef DEBUG_DRIVER > drivers/net/a2065.c:#ifdef DEBUG_DRIVER > drivers/net/a2065.c:#ifdef

Re: the usage of DEBUG_DRIVER seems ambiguous

2007-03-08 Thread Randy Dunlap
On Wed, 7 Mar 2007 19:44:41 -0500 (EST) Robert P. J. Day wrote: the usage of the DEBUG_DRIVER preprocessor variable is a big confusing: $ $ grep -rw DEBUG_DRIVER * drivers/net/sunlance.c:#undef DEBUG_DRIVER drivers/net/a2065.c:#ifdef DEBUG_DRIVER drivers/net/a2065.c:#ifdef

Re: the usage of DEBUG_DRIVER seems ambiguous

2007-03-08 Thread Robert P. J. Day
On Thu, 8 Mar 2007, Randy Dunlap wrote: On Wed, 7 Mar 2007 19:44:41 -0500 (EST) Robert P. J. Day wrote: the usage of the DEBUG_DRIVER preprocessor variable is a big confusing: $ $ grep -rw DEBUG_DRIVER * drivers/net/sunlance.c:#undef DEBUG_DRIVER drivers/net/a2065.c:#ifdef

the usage of DEBUG_DRIVER seems ambiguous

2007-03-07 Thread Robert P. J. Day
the usage of the DEBUG_DRIVER preprocessor variable is a big confusing: $ $ grep -rw DEBUG_DRIVER * drivers/net/sunlance.c:#undef DEBUG_DRIVER drivers/net/a2065.c:#ifdef DEBUG_DRIVER drivers/net/a2065.c:#ifdef DEBUG_DRIVER drivers/net/7990.c:#ifdef DEBUG_DRIVER drivers/net/7990.c:#ifdef

the usage of DEBUG_DRIVER seems ambiguous

2007-03-07 Thread Robert P. J. Day
the usage of the DEBUG_DRIVER preprocessor variable is a big confusing: $ $ grep -rw DEBUG_DRIVER * drivers/net/sunlance.c:#undef DEBUG_DRIVER drivers/net/a2065.c:#ifdef DEBUG_DRIVER drivers/net/a2065.c:#ifdef DEBUG_DRIVER drivers/net/7990.c:#ifdef DEBUG_DRIVER drivers/net/7990.c:#ifdef