Re: thinkpad_acpi: define _sta only when needed

2008-01-16 Thread Henrique de Moraes Holschuh
On Wed, 16 Jan 2008, Johannes Weiner wrote: > > Johannes, thanks for the patches, but NAK. A similar group of patches that > > clean up the _sta and heander file (kills it, actually) has already been > > sent to Len Brown to be merged for 2.6.25. > > Sorry, I missed to check his tree in advance.

Re: thinkpad_acpi: define _sta only when needed

2008-01-16 Thread Johannes Weiner
Hi Henrique, Henrique de Moraes Holschuh <[EMAIL PROTECTED]> writes: > On Wed, 16 Jan 2008, Johannes Weiner wrote: >> Define _sta() helper conditionally; also remove its prototype from >> the internal header and also some other unneeded ones. >> >> This function is only needed when the bay or

Re: thinkpad_acpi: define _sta only when needed

2008-01-16 Thread Henrique de Moraes Holschuh
On Wed, 16 Jan 2008, Johannes Weiner wrote: > Define _sta() helper conditionally; also remove its prototype from > the internal header and also some other unneeded ones. > > This function is only needed when the bay or the dock subdriver is > enabled. Otherwise, gcc complains about an unused

thinkpad_acpi: define _sta only when needed

2008-01-16 Thread Johannes Weiner
Define _sta() helper conditionally; also remove its prototype from the internal header and also some other unneeded ones. This function is only needed when the bay or the dock subdriver is enabled. Otherwise, gcc complains about an unused static function. -- To unsubscribe from this list: send

thinkpad_acpi: define _sta only when needed

2008-01-16 Thread Johannes Weiner
Define _sta() helper conditionally; also remove its prototype from the internal header and also some other unneeded ones. This function is only needed when the bay or the dock subdriver is enabled. Otherwise, gcc complains about an unused static function. -- To unsubscribe from this list: send

Re: thinkpad_acpi: define _sta only when needed

2008-01-16 Thread Henrique de Moraes Holschuh
On Wed, 16 Jan 2008, Johannes Weiner wrote: Define _sta() helper conditionally; also remove its prototype from the internal header and also some other unneeded ones. This function is only needed when the bay or the dock subdriver is enabled. Otherwise, gcc complains about an unused static

Re: thinkpad_acpi: define _sta only when needed

2008-01-16 Thread Johannes Weiner
Hi Henrique, Henrique de Moraes Holschuh [EMAIL PROTECTED] writes: On Wed, 16 Jan 2008, Johannes Weiner wrote: Define _sta() helper conditionally; also remove its prototype from the internal header and also some other unneeded ones. This function is only needed when the bay or the dock

Re: thinkpad_acpi: define _sta only when needed

2008-01-16 Thread Henrique de Moraes Holschuh
On Wed, 16 Jan 2008, Johannes Weiner wrote: Johannes, thanks for the patches, but NAK. A similar group of patches that clean up the _sta and heander file (kills it, actually) has already been sent to Len Brown to be merged for 2.6.25. Sorry, I missed to check his tree in advance. And if