Re: udf: Prevent write-unsupported filesystem to be remounted read-write

2019-01-23 Thread Kevin Weidemann
Hello, On Wednesday 22 January 2019 14:22 Jan Kara wrote > The kernel is 5.0-rc3. What kernel were you testing with? I don't remember exactly, but it was probably in the 4.20 line, as far as I can tell. The test case was a Veracrypt-compatible container file mounted with cryptsetup using |the --r

Re: udf: Prevent write-unsupported filesystem to be remounted read-write

2019-01-22 Thread Jan Kara
Hello, On Mon 14-01-19 11:30:11, Jan Kara wrote: > On Mon 14-01-19 01:33:30, Kevin Weidemann wrote: > > this is RE the patch 8515b9edf7a0c9dcf1ad218ccc783700db217336 (Upstream > > commit a9ad01bc759df79b0012f43ee52164391e31cd96) in 4.18.20. > > > > I have an issue with UDF. I used to be able to c

Re: udf: Prevent write-unsupported filesystem to be remounted read-write

2019-01-15 Thread Jan Kara
On Tue 15-01-19 11:50:41, Pali Rohár wrote: > On Tuesday 15 January 2019 10:45:55 Jan Kara wrote: > > On Tue 15-01-19 09:48:32, Pali Rohár wrote: > > > On Tuesday 15 January 2019 09:41:19 Jan Kara wrote: > > > > On Tue 15-01-19 09:31:11, Pali Rohár wrote: > > > > > On Monday 14 January 2019 19:07:3

Re: udf: Prevent write-unsupported filesystem to be remounted read-write

2019-01-15 Thread Pali Rohár
On Tuesday 15 January 2019 10:45:55 Jan Kara wrote: > On Tue 15-01-19 09:48:32, Pali Rohár wrote: > > On Tuesday 15 January 2019 09:41:19 Jan Kara wrote: > > > On Tue 15-01-19 09:31:11, Pali Rohár wrote: > > > > On Monday 14 January 2019 19:07:35 Michael Sabolish wrote: > > > > > I can try and make

Re: udf: Prevent write-unsupported filesystem to be remounted read-write

2019-01-15 Thread Jan Kara
On Tue 15-01-19 09:48:32, Pali Rohár wrote: > On Tuesday 15 January 2019 09:41:19 Jan Kara wrote: > > On Tue 15-01-19 09:31:11, Pali Rohár wrote: > > > On Monday 14 January 2019 19:07:35 Michael Sabolish wrote: > > > > I can try and make a pull-request for udftune, and I can just copy the > > > >

Re: udf: Prevent write-unsupported filesystem to be remounted read-write

2019-01-15 Thread Pali Rohár
On Tuesday 15 January 2019 09:41:19 Jan Kara wrote: > On Tue 15-01-19 09:31:11, Pali Rohár wrote: > > On Monday 14 January 2019 19:07:35 Michael Sabolish wrote: > > > I can try and make a pull-request for udftune, and I can just copy the > > > API for tune2fs. It would work something like: > > >

Re: udf: Prevent write-unsupported filesystem to be remounted read-write

2019-01-15 Thread Jan Kara
On Tue 15-01-19 09:31:11, Pali Rohár wrote: > On Monday 14 January 2019 19:07:35 Michael Sabolish wrote: > > I can try and make a pull-request for udftune, and I can just copy the API > > for tune2fs. It would work something like: > > > > udftune -O read-only device(to set read-only

Re: udf: Prevent write-unsupported filesystem to be remounted read-write

2019-01-15 Thread Pali Rohár
On Monday 14 January 2019 19:07:35 Michael Sabolish wrote: > I can try and make a pull-request for udftune, and I can just copy the API > for tune2fs. It would work something like: > > udftune -O read-only device(to set read-only access type) > > or: > > udftune -O ^read-only devic

Re: udf: Prevent write-unsupported filesystem to be remounted read-write

2019-01-14 Thread Michael Sabolish
I can try and make a pull-request for udftune, and I can just copy the API for tune2fs. It would work something like: udftune -O read-only device(to set read-only access type) or: udftune -O ^read-only device (to clear read-only access type (aka set rw)) > On Jan 14, 20

Re: udf: Prevent write-unsupported filesystem to be remounted read-write

2019-01-14 Thread Kevin Weidemann
On Monday 14 January 2019 at 16:12 Pali Rohár wrote: > So you should not use -m dvd for hard disks. > > Also DVDs have block size of 2048 bytes and UDF mandates that medium > block size matches UDF block size. Linux versions >= 4.11 do not have > problems with it, but other operating systems enforc

Re: udf: Prevent write-unsupported filesystem to be remounted read-write

2019-01-14 Thread Pali Rohár
On Monday 14 January 2019 11:30:11 Jan Kara wrote: > On Mon 14-01-19 01:33:30, Kevin Weidemann wrote: > > I have an issue with UDF. I used to be able to create a UDF fs in a way > > that is very similar to this: > > > > `# mkudffs --label= -m dvd -b 512 /dev/mapper/cryptdev1` Hi Kevin! You sh

Re: udf: Prevent write-unsupported filesystem to be remounted read-write

2019-01-14 Thread Jan Kara
On Mon 14-01-19 13:00:23, Pali Rohár wrote: > On Monday 14 January 2019 11:30:11 Jan Kara wrote: > > > As for the case of remounting as rw if the UDF is ro but the device is > > > rw, I am not sure what the best idea is to deal with this. If this new > > > behavior doesn't count as a regression, i

Re: udf: Prevent write-unsupported filesystem to be remounted read-write

2019-01-14 Thread Pali Rohár
Hello! On Monday 14 January 2019 11:30:11 Jan Kara wrote: > > As for the case of remounting as rw if the UDF is ro but the device is > > rw, I am not sure what the best idea is to deal with this. If this new > > behavior doesn't count as a regression, is there any way to end up with a > > UDF fil

Re: udf: Prevent write-unsupported filesystem to be remounted read-write

2019-01-14 Thread Jan Kara
), but the writes end up being invisibly > discarded That's a bug. I'll fix it. Thanks for reporting this! > To me, B) sounds just like the kind of issue that the commit, that I > mentioned above, promised to fix. Actually A) is what the commit a9ad01bc75 "udf: Prevent wr

Re: udf: Prevent write-unsupported filesystem to be remounted read-write

2019-01-13 Thread Kevin Weidemann
Hello, this is RE the patch 8515b9edf7a0c9dcf1ad218ccc783700db217336 (Upstream commit a9ad01bc759df79b0012f43ee52164391e31cd96) in 4.18.20. I have an issue with UDF. I used to be able to create a UDF fs in a way that is very similar to this: `# mkudffs --label= -m dvd -b 512 /dev/mapper/cr

[PATCH 4.18 032/171] udf: Prevent write-unsupported filesystem to be remounted read-write

2018-11-19 Thread Greg Kroah-Hartman
4.18-stable review patch. If anyone has any objections, please let me know. -- From: Jan Kara [ Upstream commit a9ad01bc759df79b0012f43ee52164391e31cd96 ] There are certain filesystem features which we support for reading but not for writing. We properly refuse to mount such f

[PATCH 4.19 039/205] udf: Prevent write-unsupported filesystem to be remounted read-write

2018-11-19 Thread Greg Kroah-Hartman
4.19-stable review patch. If anyone has any objections, please let me know. -- From: Jan Kara [ Upstream commit a9ad01bc759df79b0012f43ee52164391e31cd96 ] There are certain filesystem features which we support for reading but not for writing. We properly refuse to mount such f

[PATCH AUTOSEL 4.19 52/57] udf: Prevent write-unsupported filesystem to be remounted read-write

2018-11-04 Thread Sasha Levin
From: Jan Kara [ Upstream commit a9ad01bc759df79b0012f43ee52164391e31cd96 ] There are certain filesystem features which we support for reading but not for writing. We properly refuse to mount such filesystems read-write however for some features (such as read-only partitions), we don't check for

[PATCH AUTOSEL 4.18 43/45] udf: Prevent write-unsupported filesystem to be remounted read-write

2018-11-04 Thread Sasha Levin
From: Jan Kara [ Upstream commit a9ad01bc759df79b0012f43ee52164391e31cd96 ] There are certain filesystem features which we support for reading but not for writing. We properly refuse to mount such filesystems read-write however for some features (such as read-only partitions), we don't check for