Re: uio regression in 4.18-rc1 due to "uio: Prevent device destruction while fds are open"

2018-06-20 Thread Hamish Martin
Hi Mike, Thanks for reporting this problem with my patch. To be honest I'm possibly out of my depth here. I gather doing things like sleeping and memory allocation are a big no-no when under spin_lock and I take your point that it is not realistic to expect all the callouts from the various

Re: uio regression in 4.18-rc1 due to "uio: Prevent device destruction while fds are open"

2018-06-20 Thread Hamish Martin
Hi Mike, Thanks for reporting this problem with my patch. To be honest I'm possibly out of my depth here. I gather doing things like sleeping and memory allocation are a big no-no when under spin_lock and I take your point that it is not realistic to expect all the callouts from the various

uio regression in 4.18-rc1 due to "uio: Prevent device destruction while fds are open"

2018-06-20 Thread Mike Christie
Hi Hamish, I am hitting a regression with your patch: commit a93e7b331568227500186a465fee3c2cb5dffd1f Author: Hamish Martin Date: Mon May 14 13:32:23 2018 +1200 uio: Prevent device destruction while fds are open The problem is the addition of spin_lock_irqsave in uio_write. This leads

uio regression in 4.18-rc1 due to "uio: Prevent device destruction while fds are open"

2018-06-20 Thread Mike Christie
Hi Hamish, I am hitting a regression with your patch: commit a93e7b331568227500186a465fee3c2cb5dffd1f Author: Hamish Martin Date: Mon May 14 13:32:23 2018 +1200 uio: Prevent device destruction while fds are open The problem is the addition of spin_lock_irqsave in uio_write. This leads