Re: unparseable, undocumented /sys/class/drm/.../pstate

2014-06-24 Thread Greg KH
On Tue, Jun 24, 2014 at 10:06:06AM +1000, Ben Skeggs wrote: > > But, as I said on IRC yesterday, let's just move this to debugfs to > save this waste of time argument, and move on. I like that idea, great plan :) greg k-h -- To unsubscribe from this list: send the line "unsubscribe

Re: unparseable, undocumented /sys/class/drm/.../pstate

2014-06-24 Thread Greg KH
On Tue, Jun 24, 2014 at 10:06:06AM +1000, Ben Skeggs wrote: But, as I said on IRC yesterday, let's just move this to debugfs to save this waste of time argument, and move on. I like that idea, great plan :) greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-kernel in

Re: unparseable, undocumented /sys/class/drm/.../pstate

2014-06-23 Thread Ben Skeggs
On Tue, Jun 24, 2014 at 6:26 AM, Greg KH wrote: > On Mon, Jun 23, 2014 at 04:18:39PM -0400, Ilia Mirkin wrote: >> On Mon, Jun 23, 2014 at 4:15 PM, Pavel Machek wrote: >> > Hi! >> > >> >> >> >> > I guess better interface would be something like >> >> >> >> > >> >> >> >> > pstate/07/core_clock_min

Re: unparseable, undocumented /sys/class/drm/.../pstate

2014-06-23 Thread Ilia Mirkin
On Mon, Jun 23, 2014 at 4:26 PM, Greg KH wrote: > On Mon, Jun 23, 2014 at 04:18:39PM -0400, Ilia Mirkin wrote: >> On Mon, Jun 23, 2014 at 4:15 PM, Pavel Machek wrote: >> > Hi! >> > >> >> >> >> > I guess better interface would be something like >> >> >> >> > >> >> >> >> > pstate/07/core_clock_min

Re: unparseable, undocumented /sys/class/drm/.../pstate

2014-06-23 Thread Greg KH
On Mon, Jun 23, 2014 at 04:18:39PM -0400, Ilia Mirkin wrote: > On Mon, Jun 23, 2014 at 4:15 PM, Pavel Machek wrote: > > Hi! > > > >> >> >> > I guess better interface would be something like > >> >> >> > > >> >> >> > pstate/07/core_clock_min > >> >> >> > core_clock_max > >> >> >> >

Re: unparseable, undocumented /sys/class/drm/.../pstate

2014-06-23 Thread Ilia Mirkin
On Mon, Jun 23, 2014 at 4:15 PM, Pavel Machek wrote: > Hi! > >> >> >> > I guess better interface would be something like >> >> >> > >> >> >> > pstate/07/core_clock_min >> >> >> > core_clock_max >> >> >> > memory_clock_min >> >> >> > memory_clock_max >> >> >> > >> >>

Re: unparseable, undocumented /sys/class/drm/.../pstate

2014-06-23 Thread Pavel Machek
Hi! > >> >> > I guess better interface would be something like > >> >> > > >> >> > pstate/07/core_clock_min > >> >> > core_clock_max > >> >> > memory_clock_min > >> >> > memory_clock_max > >> >> > > >> >> > and then pstate/active containing just the number of active

Re: unparseable, undocumented /sys/class/drm/.../pstate

2014-06-23 Thread Greg KH
On Mon, Jun 23, 2014 at 12:40:43PM -0400, Ilia Mirkin wrote: > On Mon, Jun 23, 2014 at 12:36 PM, Greg KH wrote: > > On Mon, Jun 23, 2014 at 12:18:51PM -0400, Ilia Mirkin wrote: > >> On Mon, Jun 23, 2014 at 12:07 PM, Greg KH wrote: > >> > On Sun, Jun 22, 2014 at 10:12:14PM -0400, Ilia Mirkin

Re: unparseable, undocumented /sys/class/drm/.../pstate

2014-06-23 Thread Greg KH
On Mon, Jun 23, 2014 at 07:46:03PM +0200, Martin Peres wrote: > Le 23/06/2014 18:40, Ilia Mirkin a écrit : > >On Mon, Jun 23, 2014 at 12:36 PM, Greg KH wrote: > >>On Mon, Jun 23, 2014 at 12:18:51PM -0400, Ilia Mirkin wrote: > >>A list of valid "values" that a file can be in is fine if you just

Re: unparseable, undocumented /sys/class/drm/.../pstate

2014-06-23 Thread Ilia Mirkin
On Mon, Jun 23, 2014 at 2:00 PM, Martin Peres wrote: > Le 23/06/2014 19:56, Ilia Mirkin a écrit : > >> On Mon, Jun 23, 2014 at 1:46 PM, Martin Peres >> wrote: >>> >>> Le 23/06/2014 18:40, Ilia Mirkin a écrit : On Mon, Jun 23, 2014 at 12:36 PM, Greg KH wrote: > > > On

Re: unparseable, undocumented /sys/class/drm/.../pstate

2014-06-23 Thread Martin Peres
Le 23/06/2014 19:56, Ilia Mirkin a écrit : On Mon, Jun 23, 2014 at 1:46 PM, Martin Peres wrote: Le 23/06/2014 18:40, Ilia Mirkin a écrit : On Mon, Jun 23, 2014 at 12:36 PM, Greg KH wrote: On Mon, Jun 23, 2014 at 12:18:51PM -0400, Ilia Mirkin wrote: A list of valid "values" that a file can

Re: unparseable, undocumented /sys/class/drm/.../pstate

2014-06-23 Thread Ilia Mirkin
On Mon, Jun 23, 2014 at 1:46 PM, Martin Peres wrote: > Le 23/06/2014 18:40, Ilia Mirkin a écrit : >> >> On Mon, Jun 23, 2014 at 12:36 PM, Greg KH wrote: >>> >>> On Mon, Jun 23, 2014 at 12:18:51PM -0400, Ilia Mirkin wrote: >>> A list of valid "values" that a file can be in is fine if you just

Re: unparseable, undocumented /sys/class/drm/.../pstate

2014-06-23 Thread Martin Peres
Le 23/06/2014 18:40, Ilia Mirkin a écrit : On Mon, Jun 23, 2014 at 12:36 PM, Greg KH wrote: On Mon, Jun 23, 2014 at 12:18:51PM -0400, Ilia Mirkin wrote: A list of valid "values" that a file can be in is fine if you just then write one value back to that file. That's the one exception, but a

Re: unparseable, undocumented /sys/class/drm/.../pstate

2014-06-23 Thread Ilia Mirkin
On Mon, Jun 23, 2014 at 12:36 PM, Greg KH wrote: > On Mon, Jun 23, 2014 at 12:18:51PM -0400, Ilia Mirkin wrote: >> On Mon, Jun 23, 2014 at 12:07 PM, Greg KH wrote: >> > On Sun, Jun 22, 2014 at 10:12:14PM -0400, Ilia Mirkin wrote: >> >> On Sat, Jun 21, 2014 at 3:45 PM, Greg KH wrote: >> >> > On

Re: unparseable, undocumented /sys/class/drm/.../pstate

2014-06-23 Thread Greg KH
On Mon, Jun 23, 2014 at 12:18:51PM -0400, Ilia Mirkin wrote: > On Mon, Jun 23, 2014 at 12:07 PM, Greg KH wrote: > > On Sun, Jun 22, 2014 at 10:12:14PM -0400, Ilia Mirkin wrote: > >> On Sat, Jun 21, 2014 at 3:45 PM, Greg KH wrote: > >> > On Sat, Jun 21, 2014 at 02:22:59PM -0400, Ilia Mirkin

Re: unparseable, undocumented /sys/class/drm/.../pstate

2014-06-23 Thread Ilia Mirkin
On Mon, Jun 23, 2014 at 12:07 PM, Greg KH wrote: > On Sun, Jun 22, 2014 at 10:12:14PM -0400, Ilia Mirkin wrote: >> On Sat, Jun 21, 2014 at 3:45 PM, Greg KH wrote: >> > On Sat, Jun 21, 2014 at 02:22:59PM -0400, Ilia Mirkin wrote: >> >> On Sat, Jun 21, 2014 at 2:02 PM, Pavel Machek wrote: >> >> >

Re: unparseable, undocumented /sys/class/drm/.../pstate

2014-06-23 Thread Greg KH
On Sun, Jun 22, 2014 at 10:12:14PM -0400, Ilia Mirkin wrote: > On Sat, Jun 21, 2014 at 3:45 PM, Greg KH wrote: > > On Sat, Jun 21, 2014 at 02:22:59PM -0400, Ilia Mirkin wrote: > >> On Sat, Jun 21, 2014 at 2:02 PM, Pavel Machek wrote: > >> > Hi! > >> > > >> > AFAICT, pstate file will contain

Re: unparseable, undocumented /sys/class/drm/.../pstate

2014-06-23 Thread Ilia Mirkin
On Mon, Jun 23, 2014 at 9:02 AM, Pavel Machek wrote: > On Sun 2014-06-22 22:12:14, Ilia Mirkin wrote: >> On Sat, Jun 21, 2014 at 3:45 PM, Greg KH wrote: >> > On Sat, Jun 21, 2014 at 02:22:59PM -0400, Ilia Mirkin wrote: >> >> On Sat, Jun 21, 2014 at 2:02 PM, Pavel Machek wrote: >> >> > Hi! >> >>

Re: unparseable, undocumented /sys/class/drm/.../pstate

2014-06-23 Thread Pavel Machek
On Sun 2014-06-22 22:12:14, Ilia Mirkin wrote: > On Sat, Jun 21, 2014 at 3:45 PM, Greg KH wrote: > > On Sat, Jun 21, 2014 at 02:22:59PM -0400, Ilia Mirkin wrote: > >> On Sat, Jun 21, 2014 at 2:02 PM, Pavel Machek wrote: > >> > Hi! > >> > > >> > AFAICT, pstate file will contain something like >

Re: unparseable, undocumented /sys/class/drm/.../pstate

2014-06-23 Thread Ilia Mirkin
On Mon, Jun 23, 2014 at 9:02 AM, Pavel Machek pa...@ucw.cz wrote: On Sun 2014-06-22 22:12:14, Ilia Mirkin wrote: On Sat, Jun 21, 2014 at 3:45 PM, Greg KH g...@kroah.com wrote: On Sat, Jun 21, 2014 at 02:22:59PM -0400, Ilia Mirkin wrote: On Sat, Jun 21, 2014 at 2:02 PM, Pavel Machek

Re: unparseable, undocumented /sys/class/drm/.../pstate

2014-06-23 Thread Greg KH
On Sun, Jun 22, 2014 at 10:12:14PM -0400, Ilia Mirkin wrote: On Sat, Jun 21, 2014 at 3:45 PM, Greg KH g...@kroah.com wrote: On Sat, Jun 21, 2014 at 02:22:59PM -0400, Ilia Mirkin wrote: On Sat, Jun 21, 2014 at 2:02 PM, Pavel Machek pa...@ucw.cz wrote: Hi! AFAICT, pstate file will

Re: unparseable, undocumented /sys/class/drm/.../pstate

2014-06-23 Thread Ilia Mirkin
On Mon, Jun 23, 2014 at 12:07 PM, Greg KH g...@kroah.com wrote: On Sun, Jun 22, 2014 at 10:12:14PM -0400, Ilia Mirkin wrote: On Sat, Jun 21, 2014 at 3:45 PM, Greg KH g...@kroah.com wrote: On Sat, Jun 21, 2014 at 02:22:59PM -0400, Ilia Mirkin wrote: On Sat, Jun 21, 2014 at 2:02 PM, Pavel

Re: unparseable, undocumented /sys/class/drm/.../pstate

2014-06-23 Thread Greg KH
On Mon, Jun 23, 2014 at 12:18:51PM -0400, Ilia Mirkin wrote: On Mon, Jun 23, 2014 at 12:07 PM, Greg KH g...@kroah.com wrote: On Sun, Jun 22, 2014 at 10:12:14PM -0400, Ilia Mirkin wrote: On Sat, Jun 21, 2014 at 3:45 PM, Greg KH g...@kroah.com wrote: On Sat, Jun 21, 2014 at 02:22:59PM -0400,

Re: unparseable, undocumented /sys/class/drm/.../pstate

2014-06-23 Thread Ilia Mirkin
On Mon, Jun 23, 2014 at 12:36 PM, Greg KH g...@kroah.com wrote: On Mon, Jun 23, 2014 at 12:18:51PM -0400, Ilia Mirkin wrote: On Mon, Jun 23, 2014 at 12:07 PM, Greg KH g...@kroah.com wrote: On Sun, Jun 22, 2014 at 10:12:14PM -0400, Ilia Mirkin wrote: On Sat, Jun 21, 2014 at 3:45 PM, Greg KH

Re: unparseable, undocumented /sys/class/drm/.../pstate

2014-06-23 Thread Martin Peres
Le 23/06/2014 18:40, Ilia Mirkin a écrit : On Mon, Jun 23, 2014 at 12:36 PM, Greg KH g...@kroah.com wrote: On Mon, Jun 23, 2014 at 12:18:51PM -0400, Ilia Mirkin wrote: A list of valid values that a file can be in is fine if you just then write one value back to that file. That's the one

Re: unparseable, undocumented /sys/class/drm/.../pstate

2014-06-23 Thread Ilia Mirkin
On Mon, Jun 23, 2014 at 1:46 PM, Martin Peres martin.pe...@free.fr wrote: Le 23/06/2014 18:40, Ilia Mirkin a écrit : On Mon, Jun 23, 2014 at 12:36 PM, Greg KH g...@kroah.com wrote: On Mon, Jun 23, 2014 at 12:18:51PM -0400, Ilia Mirkin wrote: A list of valid values that a file can be in is

Re: unparseable, undocumented /sys/class/drm/.../pstate

2014-06-23 Thread Ilia Mirkin
On Mon, Jun 23, 2014 at 2:00 PM, Martin Peres martin.pe...@free.fr wrote: Le 23/06/2014 19:56, Ilia Mirkin a écrit : On Mon, Jun 23, 2014 at 1:46 PM, Martin Peres martin.pe...@free.fr wrote: Le 23/06/2014 18:40, Ilia Mirkin a écrit : On Mon, Jun 23, 2014 at 12:36 PM, Greg KH

Re: unparseable, undocumented /sys/class/drm/.../pstate

2014-06-23 Thread Martin Peres
Le 23/06/2014 19:56, Ilia Mirkin a écrit : On Mon, Jun 23, 2014 at 1:46 PM, Martin Peres martin.pe...@free.fr wrote: Le 23/06/2014 18:40, Ilia Mirkin a écrit : On Mon, Jun 23, 2014 at 12:36 PM, Greg KH g...@kroah.com wrote: On Mon, Jun 23, 2014 at 12:18:51PM -0400, Ilia Mirkin wrote: A list

Re: unparseable, undocumented /sys/class/drm/.../pstate

2014-06-23 Thread Greg KH
On Mon, Jun 23, 2014 at 07:46:03PM +0200, Martin Peres wrote: Le 23/06/2014 18:40, Ilia Mirkin a écrit : On Mon, Jun 23, 2014 at 12:36 PM, Greg KH g...@kroah.com wrote: On Mon, Jun 23, 2014 at 12:18:51PM -0400, Ilia Mirkin wrote: A list of valid values that a file can be in is fine if you just

Re: unparseable, undocumented /sys/class/drm/.../pstate

2014-06-23 Thread Greg KH
On Mon, Jun 23, 2014 at 12:40:43PM -0400, Ilia Mirkin wrote: On Mon, Jun 23, 2014 at 12:36 PM, Greg KH g...@kroah.com wrote: On Mon, Jun 23, 2014 at 12:18:51PM -0400, Ilia Mirkin wrote: On Mon, Jun 23, 2014 at 12:07 PM, Greg KH g...@kroah.com wrote: On Sun, Jun 22, 2014 at 10:12:14PM

Re: unparseable, undocumented /sys/class/drm/.../pstate

2014-06-23 Thread Pavel Machek
Hi! I guess better interface would be something like pstate/07/core_clock_min core_clock_max memory_clock_min memory_clock_max and then pstate/active containing just the number of active state? Could we just say that the format of

Re: unparseable, undocumented /sys/class/drm/.../pstate

2014-06-23 Thread Ilia Mirkin
On Mon, Jun 23, 2014 at 4:15 PM, Pavel Machek pa...@ucw.cz wrote: Hi! I guess better interface would be something like pstate/07/core_clock_min core_clock_max memory_clock_min memory_clock_max and then pstate/active containing just

Re: unparseable, undocumented /sys/class/drm/.../pstate

2014-06-23 Thread Greg KH
On Mon, Jun 23, 2014 at 04:18:39PM -0400, Ilia Mirkin wrote: On Mon, Jun 23, 2014 at 4:15 PM, Pavel Machek pa...@ucw.cz wrote: Hi! I guess better interface would be something like pstate/07/core_clock_min core_clock_max memory_clock_min

Re: unparseable, undocumented /sys/class/drm/.../pstate

2014-06-23 Thread Ilia Mirkin
On Mon, Jun 23, 2014 at 4:26 PM, Greg KH g...@kroah.com wrote: On Mon, Jun 23, 2014 at 04:18:39PM -0400, Ilia Mirkin wrote: On Mon, Jun 23, 2014 at 4:15 PM, Pavel Machek pa...@ucw.cz wrote: Hi! I guess better interface would be something like pstate/07/core_clock_min

Re: unparseable, undocumented /sys/class/drm/.../pstate

2014-06-23 Thread Ben Skeggs
On Tue, Jun 24, 2014 at 6:26 AM, Greg KH g...@kroah.com wrote: On Mon, Jun 23, 2014 at 04:18:39PM -0400, Ilia Mirkin wrote: On Mon, Jun 23, 2014 at 4:15 PM, Pavel Machek pa...@ucw.cz wrote: Hi! I guess better interface would be something like pstate/07/core_clock_min

Re: unparseable, undocumented /sys/class/drm/.../pstate

2014-06-23 Thread Pavel Machek
On Sun 2014-06-22 22:12:14, Ilia Mirkin wrote: On Sat, Jun 21, 2014 at 3:45 PM, Greg KH g...@kroah.com wrote: On Sat, Jun 21, 2014 at 02:22:59PM -0400, Ilia Mirkin wrote: On Sat, Jun 21, 2014 at 2:02 PM, Pavel Machek pa...@ucw.cz wrote: Hi! AFAICT, pstate file will contain something

Re: unparseable, undocumented /sys/class/drm/.../pstate

2014-06-22 Thread Ilia Mirkin
On Sat, Jun 21, 2014 at 3:45 PM, Greg KH wrote: > On Sat, Jun 21, 2014 at 02:22:59PM -0400, Ilia Mirkin wrote: >> On Sat, Jun 21, 2014 at 2:02 PM, Pavel Machek wrote: >> > Hi! >> > >> > AFAICT, pstate file will contain something like >> > >> > 07: core 100 MHz memory 123 MHz * >> > 08: core

Re: unparseable, undocumented /sys/class/drm/.../pstate

2014-06-22 Thread Ilia Mirkin
On Sat, Jun 21, 2014 at 3:45 PM, Greg KH g...@kroah.com wrote: On Sat, Jun 21, 2014 at 02:22:59PM -0400, Ilia Mirkin wrote: On Sat, Jun 21, 2014 at 2:02 PM, Pavel Machek pa...@ucw.cz wrote: Hi! AFAICT, pstate file will contain something like 07: core 100 MHz memory 123 MHz * 08: core

Re: unparseable, undocumented /sys/class/drm/.../pstate

2014-06-21 Thread Greg KH
On Sat, Jun 21, 2014 at 02:22:59PM -0400, Ilia Mirkin wrote: > On Sat, Jun 21, 2014 at 2:02 PM, Pavel Machek wrote: > > Hi! > > > > AFAICT, pstate file will contain something like > > > > 07: core 100 MHz memory 123 MHz * > > 08: core 100-200 MHz memory 123 MHz > > > > ...which does not look

Re: unparseable, undocumented /sys/class/drm/.../pstate

2014-06-21 Thread Ilia Mirkin
On Sat, Jun 21, 2014 at 2:50 PM, Pavel Machek wrote: > On Sat 2014-06-21 14:22:59, Ilia Mirkin wrote: >> On Sat, Jun 21, 2014 at 2:02 PM, Pavel Machek wrote: >> > Hi! >> > >> > AFAICT, pstate file will contain something like >> > >> > 07: core 100 MHz memory 123 MHz * >> > 08: core 100-200 MHz

Re: unparseable, undocumented /sys/class/drm/.../pstate

2014-06-21 Thread Pavel Machek
On Sat 2014-06-21 14:22:59, Ilia Mirkin wrote: > On Sat, Jun 21, 2014 at 2:02 PM, Pavel Machek wrote: > > Hi! > > > > AFAICT, pstate file will contain something like > > > > 07: core 100 MHz memory 123 MHz * > > 08: core 100-200 MHz memory 123 MHz > > > > ...which does not look exactly like

Re: unparseable, undocumented /sys/class/drm/.../pstate

2014-06-21 Thread Ilia Mirkin
On Sat, Jun 21, 2014 at 2:02 PM, Pavel Machek wrote: > Hi! > > AFAICT, pstate file will contain something like > > 07: core 100 MHz memory 123 MHz * > 08: core 100-200 MHz memory 123 MHz > > ...which does not look exactly like one-value-per-file, and I'm pretty > sure userspace will get it wrong

unparseable, undocumented /sys/class/drm/.../pstate

2014-06-21 Thread Pavel Machek
Hi! AFAICT, pstate file will contain something like 07: core 100 MHz memory 123 MHz * 08: core 100-200 MHz memory 123 MHz ...which does not look exactly like one-value-per-file, and I'm pretty sure userspace will get it wrong if it tries to parse it. Plus, I don't see required documentation in

unparseable, undocumented /sys/class/drm/.../pstate

2014-06-21 Thread Pavel Machek
Hi! AFAICT, pstate file will contain something like 07: core 100 MHz memory 123 MHz * 08: core 100-200 MHz memory 123 MHz ...which does not look exactly like one-value-per-file, and I'm pretty sure userspace will get it wrong if it tries to parse it. Plus, I don't see required documentation in

Re: unparseable, undocumented /sys/class/drm/.../pstate

2014-06-21 Thread Ilia Mirkin
On Sat, Jun 21, 2014 at 2:02 PM, Pavel Machek pa...@ucw.cz wrote: Hi! AFAICT, pstate file will contain something like 07: core 100 MHz memory 123 MHz * 08: core 100-200 MHz memory 123 MHz ...which does not look exactly like one-value-per-file, and I'm pretty sure userspace will get it

Re: unparseable, undocumented /sys/class/drm/.../pstate

2014-06-21 Thread Pavel Machek
On Sat 2014-06-21 14:22:59, Ilia Mirkin wrote: On Sat, Jun 21, 2014 at 2:02 PM, Pavel Machek pa...@ucw.cz wrote: Hi! AFAICT, pstate file will contain something like 07: core 100 MHz memory 123 MHz * 08: core 100-200 MHz memory 123 MHz ...which does not look exactly like

Re: unparseable, undocumented /sys/class/drm/.../pstate

2014-06-21 Thread Ilia Mirkin
On Sat, Jun 21, 2014 at 2:50 PM, Pavel Machek pa...@ucw.cz wrote: On Sat 2014-06-21 14:22:59, Ilia Mirkin wrote: On Sat, Jun 21, 2014 at 2:02 PM, Pavel Machek pa...@ucw.cz wrote: Hi! AFAICT, pstate file will contain something like 07: core 100 MHz memory 123 MHz * 08: core 100-200

Re: unparseable, undocumented /sys/class/drm/.../pstate

2014-06-21 Thread Greg KH
On Sat, Jun 21, 2014 at 02:22:59PM -0400, Ilia Mirkin wrote: On Sat, Jun 21, 2014 at 2:02 PM, Pavel Machek pa...@ucw.cz wrote: Hi! AFAICT, pstate file will contain something like 07: core 100 MHz memory 123 MHz * 08: core 100-200 MHz memory 123 MHz ...which does not look exactly