On 07/30/2012 10:12 AM, Paolo Bonzini wrote:
> Il 30/07/2012 01:50, Rusty Russell ha scritto:
>>> Also, being the first user of chained scatterlist doesn't exactly give
>>> me warm fuzzies.
>>
>> We're far from the first user: they've been in the kernel for well over
>> 7 years. They were
Il 30/07/2012 01:50, Rusty Russell ha scritto:
>> Also, being the first user of chained scatterlist doesn't exactly give
>> me warm fuzzies.
>
> We're far from the first user: they've been in the kernel for well over
> 7 years. They were introduced for the block layer, but they tended to
>
Il 30/07/2012 01:50, Rusty Russell ha scritto:
Also, being the first user of chained scatterlist doesn't exactly give
me warm fuzzies.
We're far from the first user: they've been in the kernel for well over
7 years. They were introduced for the block layer, but they tended to
ignore
On 07/30/2012 10:12 AM, Paolo Bonzini wrote:
Il 30/07/2012 01:50, Rusty Russell ha scritto:
Also, being the first user of chained scatterlist doesn't exactly give
me warm fuzzies.
We're far from the first user: they've been in the kernel for well over
7 years. They were introduced for the
On Fri, 27 Jul 2012 10:11:26 +0200, Paolo Bonzini wrote:
> Il 27/07/2012 08:27, Rusty Russell ha scritto:
> >> > +int virtqueue_add_buf_sg(struct virtqueue *_vq,
> >> > + struct scatterlist *sg_out,
> >> > + unsigned int out,
> >> > +
On Fri, 27 Jul 2012 10:11:26 +0200, Paolo Bonzini pbonz...@redhat.com wrote:
Il 27/07/2012 08:27, Rusty Russell ha scritto:
+int virtqueue_add_buf_sg(struct virtqueue *_vq,
+ struct scatterlist *sg_out,
+ unsigned int out,
+
Il 27/07/2012 08:27, Rusty Russell ha scritto:
>> > +int virtqueue_add_buf_sg(struct virtqueue *_vq,
>> > + struct scatterlist *sg_out,
>> > + unsigned int out,
>> > + struct scatterlist *sg_in,
>> > + unsigned int in,
>> > +
On Thu, 26 Jul 2012 15:05:39 +0200, Paolo Bonzini wrote:
> Il 26/07/2012 09:58, Paolo Bonzini ha scritto:
> >
> >> > Please CC me on the "convert to sg copy-less" patches, It looks
> >> > interesting
> > Sure.
>
> Well, here is the gist of it (note it won't apply on any public tree,
> hence no
On Thu, 26 Jul 2012 15:05:39 +0200, Paolo Bonzini pbonz...@redhat.com wrote:
Il 26/07/2012 09:58, Paolo Bonzini ha scritto:
Please CC me on the convert to sg copy-less patches, It looks
interesting
Sure.
Well, here is the gist of it (note it won't apply on any public tree,
hence
Il 27/07/2012 08:27, Rusty Russell ha scritto:
+int virtqueue_add_buf_sg(struct virtqueue *_vq,
+ struct scatterlist *sg_out,
+ unsigned int out,
+ struct scatterlist *sg_in,
+ unsigned int in,
+
Il 26/07/2012 09:58, Paolo Bonzini ha scritto:
>
>> > Please CC me on the "convert to sg copy-less" patches, It looks interesting
> Sure.
Well, here is the gist of it (note it won't apply on any public tree,
hence no SoB yet). It should be split in multiple changesets and you
can make more
Il 26/07/2012 09:56, Boaz Harrosh ha scritto:
>> > In the meanwhile, we still have a bug to fix, and we need to choose
>> > between Sen Wang's v1 (sg_set_page) or v2 (value assignment). I'm still
>> > leaning more towards v2, if only because I already tested that one myself.
>
> It's your call,
On 07/26/2012 10:23 AM, Paolo Bonzini wrote:
>
> In the meanwhile, we still have a bug to fix, and we need to choose
> between Sen Wang's v1 (sg_set_page) or v2 (value assignment). I'm still
> leaning more towards v2, if only because I already tested that one myself.
>
It's your call, you
Il 25/07/2012 23:04, Boaz Harrosh ha scritto:
>> That not all architectures have ARCH_HAS_SG_CHAIN (though all those I
>> care about do). So I need to go through all architectures and make sure
>> they use for_each_sg, or at least to change ARCH_HAS_SG_CHAIN to a
>> Kconfig define so that
Il 25/07/2012 23:04, Boaz Harrosh ha scritto:
That not all architectures have ARCH_HAS_SG_CHAIN (though all those I
care about do). So I need to go through all architectures and make sure
they use for_each_sg, or at least to change ARCH_HAS_SG_CHAIN to a
Kconfig define so that dependencies
On 07/26/2012 10:23 AM, Paolo Bonzini wrote:
In the meanwhile, we still have a bug to fix, and we need to choose
between Sen Wang's v1 (sg_set_page) or v2 (value assignment). I'm still
leaning more towards v2, if only because I already tested that one myself.
It's your call, you know
Il 26/07/2012 09:56, Boaz Harrosh ha scritto:
In the meanwhile, we still have a bug to fix, and we need to choose
between Sen Wang's v1 (sg_set_page) or v2 (value assignment). I'm still
leaning more towards v2, if only because I already tested that one myself.
It's your call, you know
Il 26/07/2012 09:58, Paolo Bonzini ha scritto:
Please CC me on the convert to sg copy-less patches, It looks interesting
Sure.
Well, here is the gist of it (note it won't apply on any public tree,
hence no SoB yet). It should be split in multiple changesets and you
can make more
On 07/25/2012 11:06 PM, Paolo Bonzini wrote:
> Il 25/07/2012 21:16, Boaz Harrosh ha scritto:
>> The picture confused me. It looked like the first element is the
>> virtio_scsi_cmd_req
>> not an sgilist-element that points to the struct's buffer.
>>
>> In that case then yes your plan of making a
Il 25/07/2012 21:16, Boaz Harrosh ha scritto:
> The picture confused me. It looked like the first element is the
> virtio_scsi_cmd_req
> not an sgilist-element that points to the struct's buffer.
>
> In that case then yes your plan of making a two-elements fragment that points
> to the
>
On 07/25/2012 08:43 PM, Paolo Bonzini wrote:
> Il 25/07/2012 17:28, Boaz Harrosh ha scritto:
>>> 1) what I get is a scsi_cmnd which contains an N-element scatterlist.
>>>
>>> 2) virtio-scsi has to build the "packet" that is passed to the hardware
>>> (it does not matter that the hardware is
Il 25/07/2012 17:28, Boaz Harrosh ha scritto:
>> 1) what I get is a scsi_cmnd which contains an N-element scatterlist.
>>
>> 2) virtio-scsi has to build the "packet" that is passed to the hardware
>> (it does not matter that the hardware is virtual). This packet (per
>> virtio-scsi spec) has an
On 07/25/2012 05:17 PM, Paolo Bonzini wrote:
> Il 25/07/2012 15:26, Boaz Harrosh ha scritto:
In SCSI land most LLDs should support chaining just by virtu of using the
for_each_sg macro. That all it takes. Your code above does support it.
>>>
>>> Yes, it supports it but still has to undo
Il 25/07/2012 15:26, Boaz Harrosh ha scritto:
>>> In SCSI land most LLDs should support chaining just by virtu of using the
>>> for_each_sg macro. That all it takes. Your code above does support it.
>>
>> Yes, it supports it but still has to undo them before passing to virtio.
>>
>> What my LLD
Il 25/07/2012 17:28, Boaz Harrosh ha scritto:
1) what I get is a scsi_cmnd which contains an N-element scatterlist.
2) virtio-scsi has to build the packet that is passed to the hardware
(it does not matter that the hardware is virtual). This packet (per
virtio-scsi spec) has an N+1-element
On 07/25/2012 08:43 PM, Paolo Bonzini wrote:
Il 25/07/2012 17:28, Boaz Harrosh ha scritto:
1) what I get is a scsi_cmnd which contains an N-element scatterlist.
2) virtio-scsi has to build the packet that is passed to the hardware
(it does not matter that the hardware is virtual). This
Il 25/07/2012 21:16, Boaz Harrosh ha scritto:
The picture confused me. It looked like the first element is the
virtio_scsi_cmd_req
not an sgilist-element that points to the struct's buffer.
In that case then yes your plan of making a two-elements fragment that points
to the
original
On 07/25/2012 11:06 PM, Paolo Bonzini wrote:
Il 25/07/2012 21:16, Boaz Harrosh ha scritto:
The picture confused me. It looked like the first element is the
virtio_scsi_cmd_req
not an sgilist-element that points to the struct's buffer.
In that case then yes your plan of making a
Il 25/07/2012 15:26, Boaz Harrosh ha scritto:
In SCSI land most LLDs should support chaining just by virtu of using the
for_each_sg macro. That all it takes. Your code above does support it.
Yes, it supports it but still has to undo them before passing to virtio.
What my LLD does is add a
On 07/25/2012 05:17 PM, Paolo Bonzini wrote:
Il 25/07/2012 15:26, Boaz Harrosh ha scritto:
In SCSI land most LLDs should support chaining just by virtu of using the
for_each_sg macro. That all it takes. Your code above does support it.
Yes, it supports it but still has to undo them before
30 matches
Mail list logo