Re: w1_therm_read_bin: suspicious usage of flush_signals()

2007-06-14 Thread Evgeniy Polyakov
On Thu, Jun 14, 2007 at 10:10:07PM -0700, Roland McGrath ([EMAIL PROTECTED]) wrote: > > Well, it can be uninterruptible sleep, but why? > > It is not allowed to return to userspace until transaction is completed, > > so having uninterruptible sleep will result in exactly same lost of > > signals.

Re: w1_therm_read_bin: suspicious usage of flush_signals()

2007-06-14 Thread Roland McGrath
> Well, it can be uninterruptible sleep, but why? > It is not allowed to return to userspace until transaction is completed, > so having uninterruptible sleep will result in exactly same lost of > signals. Delay, not loss. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" i

Re: w1_therm_read_bin: suspicious usage of flush_signals()

2007-06-14 Thread Evgeniy Polyakov
On Thu, Jun 14, 2007 at 09:24:39PM +0400, Oleg Nesterov ([EMAIL PROTECTED]) wrote: > drivers/w1/slaves/w1_therm.c:w1_therm_read_bin() > > while (tm) { > tm = msleep_interruptible(tm); > if (signal_pending(current)) > flush_signals(current);

w1_therm_read_bin: suspicious usage of flush_signals()

2007-06-14 Thread Oleg Nesterov
drivers/w1/slaves/w1_therm.c:w1_therm_read_bin() while (tm) { tm = msleep_interruptible(tm); if (signal_pending(current)) flush_signals(current); } current is user-space task, yes? this looks just wrong, could you please exp