Re: [PATCH] watchdog: Add Broadcom BCM2708 watchdog timer driver

2013-03-26 Thread Stephen Warren
On 03/24/2013 08:12 AM, Lubomir Rintel wrote: > On Fri, 2013-03-22 at 20:24 -0600, Stephen Warren wrote: > > Thank you for your response! > >> On 03/22/2013 06:55 AM, Lubomir Rintel wrote: >>> Signed-off-by: Lubomir Rintel >> A couple of general comments: >> >> 1) >> >> This driver touches the

Re: [PATCH] watchdog: Add Broadcom BCM2708 watchdog timer driver

2013-03-26 Thread Stephen Warren
On 03/24/2013 08:12 AM, Lubomir Rintel wrote: > On Fri, 2013-03-22 at 20:24 -0600, Stephen Warren wrote: > > Thank you for your response! > >> On 03/22/2013 06:55 AM, Lubomir Rintel wrote: >>> Signed-off-by: Lubomir Rintel >> I'm curious where you got the documentation to write this driver; thi

Re: watchdog: Add Broadcom BCM2708 watchdog timer driver

2013-03-24 Thread Guenter Roeck
On Sun, Mar 24, 2013 at 03:06:59PM +0100, Lubomir Rintel wrote: > On Fri, 2013-03-22 at 06:56 -0700, Guenter Roeck wrote: > > Thank you for your response! > > On Fri Mar 22 09:56:01 EDT 2013, Guenter Roeck wrote: > > On Fri, Mar 22, 2013 at 12:55:07PM -, Lubomir Rintel wrote: > ... > > > + wr

Re: [PATCH] watchdog: Add Broadcom BCM2708 watchdog timer driver

2013-03-24 Thread Lubomir Rintel
On Fri, 2013-03-22 at 20:24 -0600, Stephen Warren wrote: Thank you for your response! > On 03/22/2013 06:55 AM, Lubomir Rintel wrote: > > Signed-off-by: Lubomir Rintel > > A commit description would be useful. I'll add a more descriptive one in next patch revision. > > arch/arm/configs/bcm28

Re: [PATCH] watchdog: Add Broadcom BCM2708 watchdog timer driver

2013-03-24 Thread Lubomir Rintel
On Fri, 2013-03-22 at 19:46 +0100, Arend van Spriel wrote: Thanks for your response! > On 03/22/2013 01:55 PM, Lubomir Rintel wrote: > > Signed-off-by: Lubomir Rintel > > Cc: Stephen Warren > > Cc: Wim Van Sebroeck > > Cc: linux-rpi-ker...@lists.infradead.org > > Cc: linux-watch...@vger.kernel

Re: watchdog: Add Broadcom BCM2708 watchdog timer driver

2013-03-24 Thread Lubomir Rintel
On Fri, 2013-03-22 at 06:56 -0700, Guenter Roeck wrote: Thank you for your response! On Fri Mar 22 09:56:01 EDT 2013, Guenter Roeck wrote: > On Fri, Mar 22, 2013 at 12:55:07PM -, Lubomir Rintel wrote: ... > > + writel_relaxed(PM_PASSWORD | (cur & PM_RSTC_WRCFG_CLR) | > > + PM_RS

Re: [PATCH] watchdog: Add Broadcom BCM2708 watchdog timer driver

2013-03-22 Thread Stephen Warren
On 03/22/2013 06:55 AM, Lubomir Rintel wrote: > Signed-off-by: Lubomir Rintel A commit description would be useful. > arch/arm/configs/bcm2835_defconfig |4 + > drivers/watchdog/Kconfig | 11 +++ > drivers/watchdog/Makefile |1 + > drivers/watchdog/bcm2835_wdt.c

Re: [PATCH] watchdog: Add Broadcom BCM2708 watchdog timer driver

2013-03-22 Thread Arend van Spriel
On 03/22/2013 01:55 PM, Lubomir Rintel wrote: > Signed-off-by: Lubomir Rintel > Cc: Stephen Warren > Cc: Wim Van Sebroeck > Cc: linux-rpi-ker...@lists.infradead.org > Cc: linux-watch...@vger.kernel.org > --- > arch/arm/configs/bcm2835_defconfig |4 + > drivers/watchdog/Kconfig |

Re: watchdog: Add Broadcom BCM2708 watchdog timer driver

2013-03-22 Thread Guenter Roeck
On Fri, Mar 22, 2013 at 12:55:07PM -, Lubomir Rintel wrote: > Signed-off-by: Lubomir Rintel > Cc: Stephen Warren > Cc: Wim Van Sebroeck > Cc: linux-rpi-ker...@lists.infradead.org > Cc: linux-watch...@vger.kernel.org > > --- > arch/arm/configs/bcm2835_defconfig |4 + > drivers/watchdog/K

[PATCH] watchdog: Add Broadcom BCM2708 watchdog timer driver

2013-03-22 Thread Lubomir Rintel
Signed-off-by: Lubomir Rintel Cc: Stephen Warren Cc: Wim Van Sebroeck Cc: linux-rpi-ker...@lists.infradead.org Cc: linux-watch...@vger.kernel.org --- arch/arm/configs/bcm2835_defconfig |4 + drivers/watchdog/Kconfig | 11 +++ drivers/watchdog/Makefile |1 + drivers/