Re: [PATCH] x86/mm: Limit 2/4M size calculation to x86_32

2012-09-07 Thread Stefan Bader
On 31.08.2012 18:41, H. Peter Anvin wrote: > I'm not saying we shouldn't patch the regression, but this house of cards > *needs* to be replaced with something robust and correct by construction. Could that patch then get applied? Though I got some feedback, that the description might be not

Re: [PATCH] x86/mm: Limit 2/4M size calculation to x86_32

2012-09-07 Thread Stefan Bader
On 31.08.2012 18:41, H. Peter Anvin wrote: I'm not saying we shouldn't patch the regression, but this house of cards *needs* to be replaced with something robust and correct by construction. Could that patch then get applied? Though I got some feedback, that the description might be not really

Re: [PATCH] x86/mm: Limit 2/4M size calculation to x86_32

2012-08-31 Thread Stefan Bader
On 08/31/2012 09:41 AM, H. Peter Anvin wrote: I'm not saying we shouldn't patch the regression, but this house of cards *needs* to be replaced with something robust and correct by construction. Then I did misunderstand/-interpret you about the former part and we actually are agreeing on the

Re: [PATCH] x86/mm: Limit 2/4M size calculation to x86_32

2012-08-31 Thread H. Peter Anvin
rom 1d5cc3971716a039c91abc18cb6f9bcbe5dde490 Mon Sep 17 00:00:00 2001 >From: Stefan Bader >Date: Fri, 13 Jul 2012 15:16:33 +0200 >Subject: [PATCH] x86/mm: Limit 2/4M size calculation to x86_32 > >commit 722bc6b (x86/mm: Fix the size calculation of mapping tables) >did modify the ex

[PATCH] x86/mm: Limit 2/4M size calculation to x86_32

2012-08-31 Thread Stefan Bader
nsidered. -Stefan >From 1d5cc3971716a039c91abc18cb6f9bcbe5dde490 Mon Sep 17 00:00:00 2001 From: Stefan Bader Date: Fri, 13 Jul 2012 15:16:33 +0200 Subject: [PATCH] x86/mm: Limit 2/4M size calculation to x86_32 commit 722bc6b (x86/mm: Fix the size calculation of mapping tables) did modify the extra space calculation for mapp

[PATCH] x86/mm: Limit 2/4M size calculation to x86_32

2012-08-31 Thread Stefan Bader
Mon Sep 17 00:00:00 2001 From: Stefan Bader stefan.ba...@canonical.com Date: Fri, 13 Jul 2012 15:16:33 +0200 Subject: [PATCH] x86/mm: Limit 2/4M size calculation to x86_32 commit 722bc6b (x86/mm: Fix the size calculation of mapping tables) did modify the extra space calculation for mapping tables

Re: [PATCH] x86/mm: Limit 2/4M size calculation to x86_32

2012-08-31 Thread H. Peter Anvin
+0200 Subject: [PATCH] x86/mm: Limit 2/4M size calculation to x86_32 commit 722bc6b (x86/mm: Fix the size calculation of mapping tables) did modify the extra space calculation for mapping tables in order to make up for the first 2/4M memory range using 4K pages. However this setup is only used when

Re: [PATCH] x86/mm: Limit 2/4M size calculation to x86_32

2012-08-31 Thread Stefan Bader
On 08/31/2012 09:41 AM, H. Peter Anvin wrote: I'm not saying we shouldn't patch the regression, but this house of cards *needs* to be replaced with something robust and correct by construction. Then I did misunderstand/-interpret you about the former part and we actually are agreeing on the

Re: x86/mm: Limit 2/4M size calculation to x86_32

2012-07-31 Thread Avi Kivity
On 07/31/2012 12:48 PM, Stefan Bader wrote: > On 25.07.2012 15:40, Avi Kivity wrote: >> On 07/25/2012 04:24 PM, Stefan Bader wrote: > ... > ifdef CONFIG_X86_32 > /* > * Don't use a large page for the first 2/4MB of memory > * because there are often

Re: x86/mm: Limit 2/4M size calculation to x86_32

2012-07-31 Thread Stefan Bader
On 25.07.2012 15:40, Avi Kivity wrote: > On 07/25/2012 04:24 PM, Stefan Bader wrote: ... ifdef CONFIG_X86_32 /* * Don't use a large page for the first 2/4MB of memory * because there are often fixed size MTRRs in there * and

Re: x86/mm: Limit 2/4M size calculation to x86_32

2012-07-31 Thread Stefan Bader
On 25.07.2012 15:40, Avi Kivity wrote: On 07/25/2012 04:24 PM, Stefan Bader wrote: ... ifdef CONFIG_X86_32 /* * Don't use a large page for the first 2/4MB of memory * because there are often fixed size MTRRs in there * and overlapping MTRRs into large

Re: x86/mm: Limit 2/4M size calculation to x86_32

2012-07-31 Thread Avi Kivity
On 07/31/2012 12:48 PM, Stefan Bader wrote: On 25.07.2012 15:40, Avi Kivity wrote: On 07/25/2012 04:24 PM, Stefan Bader wrote: ... ifdef CONFIG_X86_32 /* * Don't use a large page for the first 2/4MB of memory * because there are often fixed size MTRRs in there

Re: x86/mm: Limit 2/4M size calculation to x86_32

2012-07-25 Thread Avi Kivity
On 07/25/2012 04:24 PM, Stefan Bader wrote: >>> ... >>> ifdef CONFIG_X86_32 >>> /* >>> * Don't use a large page for the first 2/4MB of memory >>> * because there are often fixed size MTRRs in there >>> * and overlapping MTRRs into large pages can cause >>>

Re: x86/mm: Limit 2/4M size calculation to x86_32

2012-07-25 Thread Stefan Bader
;>>>> From: Stefan Bader >>>>> Date: Fri, 13 Jul 2012 15:16:33 +0200 >>>>> Subject: [PATCH] x86/mm: Limit 2/4M size calculation to x86_32 >>>>> >>>>> commit 722bc6b (x86/mm: Fix the size calculation of mapping tables) >

Re: x86/mm: Limit 2/4M size calculation to x86_32

2012-07-25 Thread Avi Kivity
ri, 13 Jul 2012 15:16:33 +0200 >>>> Subject: [PATCH] x86/mm: Limit 2/4M size calculation to x86_32 >>>> >>>> commit 722bc6b (x86/mm: Fix the size calculation of mapping tables) >>>> did modify the extra space calculation for mapping tables in order &

Re: x86/mm: Limit 2/4M size calculation to x86_32

2012-07-25 Thread Stefan Bader
On 25.07.2012 12:44, Avi Kivity wrote: > On 07/24/2012 06:52 PM, Cong Wang wrote: > >>> From 6b679d1af20656929c0e829f29eed60b0a86a74f Mon Sep 17 00:00:00 2001 >>> From: Stefan Bader >>> Date: Fri, 13 Jul 2012 15:16:33 +0200 >>> Subject: [PATCH] x86

Re: x86/mm: Limit 2/4M size calculation to x86_32

2012-07-25 Thread Avi Kivity
On 07/24/2012 06:52 PM, Cong Wang wrote: >> From 6b679d1af20656929c0e829f29eed60b0a86a74f Mon Sep 17 00:00:00 2001 >> From: Stefan Bader >> Date: Fri, 13 Jul 2012 15:16:33 +0200 >> Subject: [PATCH] x86/mm: Limit 2/4M size calculation to x86_32 >> >>

Re: x86/mm: Limit 2/4M size calculation to x86_32

2012-07-25 Thread Avi Kivity
On 07/24/2012 06:52 PM, Cong Wang wrote: From 6b679d1af20656929c0e829f29eed60b0a86a74f Mon Sep 17 00:00:00 2001 From: Stefan Bader stefan.ba...@canonical.com Date: Fri, 13 Jul 2012 15:16:33 +0200 Subject: [PATCH] x86/mm: Limit 2/4M size calculation to x86_32 commit 722bc6b (x86/mm: Fix

Re: x86/mm: Limit 2/4M size calculation to x86_32

2012-07-25 Thread Stefan Bader
On 25.07.2012 12:44, Avi Kivity wrote: On 07/24/2012 06:52 PM, Cong Wang wrote: From 6b679d1af20656929c0e829f29eed60b0a86a74f Mon Sep 17 00:00:00 2001 From: Stefan Bader stefan.ba...@canonical.com Date: Fri, 13 Jul 2012 15:16:33 +0200 Subject: [PATCH] x86/mm: Limit 2/4M size calculation

Re: x86/mm: Limit 2/4M size calculation to x86_32

2012-07-25 Thread Avi Kivity
: [PATCH] x86/mm: Limit 2/4M size calculation to x86_32 commit 722bc6b (x86/mm: Fix the size calculation of mapping tables) did modify the extra space calculation for mapping tables in order to make up for the first 2/4M memory range using 4K pages. However this setup is only used when compiling

Re: x86/mm: Limit 2/4M size calculation to x86_32

2012-07-25 Thread Stefan Bader
, 13 Jul 2012 15:16:33 +0200 Subject: [PATCH] x86/mm: Limit 2/4M size calculation to x86_32 commit 722bc6b (x86/mm: Fix the size calculation of mapping tables) did modify the extra space calculation for mapping tables in order to make up for the first 2/4M memory range using 4K pages. However

Re: x86/mm: Limit 2/4M size calculation to x86_32

2012-07-25 Thread Avi Kivity
On 07/25/2012 04:24 PM, Stefan Bader wrote: ... ifdef CONFIG_X86_32 /* * Don't use a large page for the first 2/4MB of memory * because there are often fixed size MTRRs in there * and overlapping MTRRs into large pages can cause * slowdowns.

Re: x86/mm: Limit 2/4M size calculation to x86_32

2012-07-24 Thread Cong Wang
0] [mem 0x77e0-0x77e87fff] page 4k > > Attached patch would fix this if you agree with it. Thanks. > > -Stefan > > > From 6b679d1af20656929c0e829f29eed60b0a86a74f Mon Sep 17 00:00:00 2001 > From: Stefan Bader > Date: Fri, 13 Jul 2012 15:16:33 +0200 > Subject: [PATCH] x86

Re: x86/mm: Limit 2/4M size calculation to x86_32

2012-07-24 Thread Cong Wang
] page 4k Attached patch would fix this if you agree with it. Thanks. -Stefan From 6b679d1af20656929c0e829f29eed60b0a86a74f Mon Sep 17 00:00:00 2001 From: Stefan Bader stefan.ba...@canonical.com Date: Fri, 13 Jul 2012 15:16:33 +0200 Subject: [PATCH] x86/mm: Limit 2/4M size calculation to x86_32

Re: x86/mm: Limit 2/4M size calculation to x86_32

2012-07-19 Thread Stefan Bader
:00:00 2001 From: Stefan Bader Date: Fri, 13 Jul 2012 15:16:33 +0200 Subject: [PATCH] x86/mm: Limit 2/4M size calculation to x86_32 commit 722bc6b (x86/mm: Fix the size calculation of mapping tables) did modify the extra space calculation for mapping tables in order to make up for the first 2/4M

Re: x86/mm: Limit 2/4M size calculation to x86_32

2012-07-19 Thread Stefan Bader
:00:00 2001 From: Stefan Bader stefan.ba...@canonical.com Date: Fri, 13 Jul 2012 15:16:33 +0200 Subject: [PATCH] x86/mm: Limit 2/4M size calculation to x86_32 commit 722bc6b (x86/mm: Fix the size calculation of mapping tables) did modify the extra space calculation for mapping tables in order to make

Re: x86/mm: Limit 2/4M size calculation to x86_32

2012-07-15 Thread Stefan Bader
On 07/13/2012 11:12 AM, Yinghai Lu wrote: On Fri, Jul 13, 2012 at 6:41 AM, Stefan Bader wrote: I was bisecting a problem on 64bit where any attempt to cause a crash kernel to boot would hang. The bisect ended up on commit 722bc6b (x86/mm: Fix the size calculation of mapping tables) and

Re: x86/mm: Limit 2/4M size calculation to x86_32

2012-07-15 Thread Stefan Bader
On 07/13/2012 11:12 AM, Yinghai Lu wrote: On Fri, Jul 13, 2012 at 6:41 AM, Stefan Bader stefan.ba...@canonical.com wrote: I was bisecting a problem on 64bit where any attempt to cause a crash kernel to boot would hang. The bisect ended up on commit 722bc6b (x86/mm: Fix the size calculation of

Re: x86/mm: Limit 2/4M size calculation to x86_32

2012-07-13 Thread Yinghai Lu
On Fri, Jul 13, 2012 at 6:41 AM, Stefan Bader wrote: > I was bisecting a problem on 64bit where any attempt to cause a crash kernel > to > boot would hang. The bisect ended up on commit 722bc6b (x86/mm: Fix the size > calculation of mapping tables) and somehow, looking at the calling function >

x86/mm: Limit 2/4M size calculation to x86_32

2012-07-13 Thread Stefan Bader
6b679d1af20656929c0e829f29eed60b0a86a74f Mon Sep 17 00:00:00 2001 From: Stefan Bader Date: Fri, 13 Jul 2012 15:16:33 +0200 Subject: [PATCH] x86/mm: Limit 2/4M size calculation to x86_32 commit 722bc6b (x86/mm: Fix the size calculation of mapping tables) did modify the extra space calculation for mapping tables

x86/mm: Limit 2/4M size calculation to x86_32

2012-07-13 Thread Stefan Bader
6b679d1af20656929c0e829f29eed60b0a86a74f Mon Sep 17 00:00:00 2001 From: Stefan Bader stefan.ba...@canonical.com Date: Fri, 13 Jul 2012 15:16:33 +0200 Subject: [PATCH] x86/mm: Limit 2/4M size calculation to x86_32 commit 722bc6b (x86/mm: Fix the size calculation of mapping tables) did modify the extra space

Re: x86/mm: Limit 2/4M size calculation to x86_32

2012-07-13 Thread Yinghai Lu
On Fri, Jul 13, 2012 at 6:41 AM, Stefan Bader stefan.ba...@canonical.com wrote: I was bisecting a problem on 64bit where any attempt to cause a crash kernel to boot would hang. The bisect ended up on commit 722bc6b (x86/mm: Fix the size calculation of mapping tables) and somehow, looking at