Re: x86_64: Bug in new out of line put_user()

2005-04-22 Thread Alexander Nyberg
Brian, thanks for seeing this. (me goes hiding...) The labels after the last put_user patch were misplaced so exceptions on the real mov instructions would not be handled. Index: test/arch/x86_64/lib/putuser.S === ---

Re: x86_64: Bug in new out of line put_user()

2005-04-22 Thread Alexander Nyberg
Brian, thanks for seeing this. (me goes hiding...) The labels after the last put_user patch were misplaced so exceptions on the real mov instructions would not be handled. Index: test/arch/x86_64/lib/putuser.S === ---

Re: x86_64: Bug in new out of line put_user()

2005-04-21 Thread Brian Gerst
Alexander Nyberg wrote: The new out of line put_user() assembly on x86_64 changes %rcx without telling GCC about it causing things like: http://bugme.osdl.org/show_bug.cgi?id=4515 See to it that %rcx is not changed (made it consistent with get_user()). Signed-off-by: Alexander Nyberg <[EMAIL

Re: x86_64: Bug in new out of line put_user()

2005-04-21 Thread Nicolas Boichat
Hello Alexander, I have other kind of problems with this patch... With 2.6.12-rc2 + your patch, when I run OpenOffice (a 32-bit application), I get this in dmesg : Unable to handle kernel paging request at 2d9280b0 RIP: {__put_user_4+32} PGD 0 Oops: 0002 [1] SMP CPU 0 Modules linked

Re: x86_64: Bug in new out of line put_user()

2005-04-21 Thread Nicolas Boichat
Hello, On Thu, 2005-04-21 at 01:10 +0200, Alexander Nyberg wrote: > The new out of line put_user() assembly on x86_64 changes %rcx without > telling GCC about it causing things like: > > http://bugme.osdl.org/show_bug.cgi?id=4515 Thank you, this patch fixes the message queue problem. Best

Re: x86_64: Bug in new out of line put_user()

2005-04-21 Thread Andi Kleen
On Thu, Apr 21, 2005 at 01:10:09AM +0200, Alexander Nyberg wrote: > The new out of line put_user() assembly on x86_64 changes %rcx without > telling GCC about it causing things like: > > http://bugme.osdl.org/show_bug.cgi?id=4515 > > See to it that %rcx is not changed (made it consistent with

Re: x86_64: Bug in new out of line put_user()

2005-04-21 Thread Andi Kleen
On Thu, Apr 21, 2005 at 01:10:09AM +0200, Alexander Nyberg wrote: The new out of line put_user() assembly on x86_64 changes %rcx without telling GCC about it causing things like: http://bugme.osdl.org/show_bug.cgi?id=4515 See to it that %rcx is not changed (made it consistent with

Re: x86_64: Bug in new out of line put_user()

2005-04-21 Thread Nicolas Boichat
Hello, On Thu, 2005-04-21 at 01:10 +0200, Alexander Nyberg wrote: The new out of line put_user() assembly on x86_64 changes %rcx without telling GCC about it causing things like: http://bugme.osdl.org/show_bug.cgi?id=4515 Thank you, this patch fixes the message queue problem. Best

Re: x86_64: Bug in new out of line put_user()

2005-04-21 Thread Nicolas Boichat
Hello Alexander, I have other kind of problems with this patch... With 2.6.12-rc2 + your patch, when I run OpenOffice (a 32-bit application), I get this in dmesg : Unable to handle kernel paging request at 2d9280b0 RIP: 801f5d70{__put_user_4+32} PGD 0 Oops: 0002 [1] SMP CPU 0

Re: x86_64: Bug in new out of line put_user()

2005-04-21 Thread Brian Gerst
Alexander Nyberg wrote: The new out of line put_user() assembly on x86_64 changes %rcx without telling GCC about it causing things like: http://bugme.osdl.org/show_bug.cgi?id=4515 See to it that %rcx is not changed (made it consistent with get_user()). Signed-off-by: Alexander Nyberg [EMAIL

x86_64: Bug in new out of line put_user()

2005-04-20 Thread Alexander Nyberg
The new out of line put_user() assembly on x86_64 changes %rcx without telling GCC about it causing things like: http://bugme.osdl.org/show_bug.cgi?id=4515 See to it that %rcx is not changed (made it consistent with get_user()). Signed-off-by: Alexander Nyberg <[EMAIL PROTECTED]> Index:

x86_64: Bug in new out of line put_user()

2005-04-20 Thread Alexander Nyberg
The new out of line put_user() assembly on x86_64 changes %rcx without telling GCC about it causing things like: http://bugme.osdl.org/show_bug.cgi?id=4515 See to it that %rcx is not changed (made it consistent with get_user()). Signed-off-by: Alexander Nyberg [EMAIL PROTECTED] Index: