Re: [PATCH] WorkStruct: Implement generic UP cmpxchg() where an

2006-12-10 Thread Nick Piggin
Hi Linux, [EMAIL PROTECTED] wrote: Even if ARM is able to handle any arbitrary C code between the load locked and store conditional API, other architectures can not by definition. Maybe so, but I think you and Linus are missing the middle ground. Nobdy argued against adding nice arch

Re: [PATCH] ucb1400_ts depends SND_AC97_BUS

2006-12-10 Thread Randy Dunlap
On Sun, 10 Dec 2006 22:55:25 -0500 (EST) Nicolas Pitre wrote: On Sat, 9 Dec 2006, Randy Dunlap wrote: On Sat, 09 Dec 2006 22:17:55 -0500 (EST) Nicolas Pitre wrote: Please consider what SND_CONFIG_AC97_BUS corresponds to. It is sound/pci/ac97/ac97_bus.c and if you look into this

Re: Linux portability bugs

2006-12-10 Thread Chuck Ebbert
In-Reply-To: [EMAIL PROTECTED] On Fri, 1 Dec 2006 22:39:01 -0800, mariusn wrote: I am a graduate student at University of Washington, building a tool automatically discover portability bugs in system-level code written in C. My definition of portability is at the data layout level,

Re: PAE/NX without performance drain?

2006-12-10 Thread Chuck Ebbert
In-Reply-To: [EMAIL PROTECTED] On Sat, 09 Dec 2006 15:39:30 -0500, John Richard Moser wrote: Is it possible to give some other way to get the hardware NX bit working in 32-bit mode, without the apparently massive performance penalty of HIGHMEM64? If your hardware can run the x86_64 kernel,

Re: [Patch](memory hotplug) Fix compile error for i386 with NUMA config

2006-12-10 Thread Yasunori Goto
Hi David-san. On Sat, 9 Dec 2006, Yasunori Goto wrote: Hello. This patch is to fix compile error when config memory hotplug with numa on i386. The cause of compile error was missing of arch_add_memory(), remove_memory(), and memory_add_physaddr_to_nid() when NUMA config is

Re: PAE/NX without performance drain?

2006-12-10 Thread John Richard Moser
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Chuck Ebbert wrote: In-Reply-To: [EMAIL PROTECTED] On Sat, 09 Dec 2006 15:39:30 -0500, John Richard Moser wrote: Is it possible to give some other way to get the hardware NX bit working in 32-bit mode, without the apparently massive

Re: workqueue deadlock

2006-12-10 Thread Srivatsa Vaddagiri
On Sun, Dec 10, 2006 at 09:26:16AM +0100, Ingo Molnar wrote: something like the pseudocode further below - when applied to a data structure it has semantics and scalability close to that of preempt_disable(), but it is still preemptible and the lock is specific. Ingo, The psuedo-code

Re: optimalisation for strlcpy (lib/string.c)

2006-12-10 Thread Clemens Koller
Hi, Adrian Friends! Like the other patch (by that other person), I think it is faster to not do a strlen first. There are PowerPC architectures, where a strlen is a matter of a single instruction of the CPU. Quote: PowerPC 405 and 440 instruction sets offer the powerful Determine Left-Most

Re: PAE/NX without performance drain?

2006-12-10 Thread Randy Dunlap
On Sun, 10 Dec 2006 23:58:00 -0500 John Richard Moser wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Chuck Ebbert wrote: In-Reply-To: [EMAIL PROTECTED] On Sat, 09 Dec 2006 15:39:30 -0500, John Richard Moser wrote: Is it possible to give some other way to get the

Re: workqueue deadlock

2006-12-10 Thread Srivatsa Vaddagiri
On Sun, Dec 10, 2006 at 04:16:00AM -0800, Andrew Morton wrote: One quite different way of addressing all of this is to stop using stop_machine_run() for hotplug synchronisation and switch to the swsusp freezer infrastructure: all kernel threads and user processes need to stop and park

Re: [PATCH 4/6] MTHCA driver (infiniband) use new pci interfaces

2006-12-10 Thread Grant Grundler
On Mon, Dec 11, 2006 at 02:55:39PM +1100, Benjamin Herrenschmidt wrote: On Fri, 2006-12-08 at 10:22 -0800, Stephen Hemminger wrote: plain text document attachment (mthca-rbc.patch) Use new pci interfaces to set read request tuning values Untested because of lack of hardware. Sorry...I

Re: workqueue deadlock

2006-12-10 Thread Andrew Morton
On Mon, 11 Dec 2006 11:15:45 +0530 Srivatsa Vaddagiri [EMAIL PROTECTED] wrote: On Sun, Dec 10, 2006 at 04:16:00AM -0800, Andrew Morton wrote: One quite different way of addressing all of this is to stop using stop_machine_run() for hotplug synchronisation and switch to the swsusp freezer

Re: workqueue deadlock

2006-12-10 Thread Ingo Molnar
* Andrew Morton [EMAIL PROTECTED] wrote: { int cpu = raw_smp_processor_id(); /* * Interrupts/softirqs are hotplug-safe: */ if (in_interrupt()) return;

Re: [patch 2.6.19-git] rts-rs5c372 updates: more chips, alarm, 12hr mode, etc

2006-12-10 Thread Voipio Riku
Update the rtc-rs5c372 driver: I suspect the issue wasn't that mode 1 didn't work on that board; the original code to fetch the trim was broken. If mode 1 really won't work, that's almost certainly a bug in that board's I2C driver. It was not related to trim fetching. Yes, it very likely

Re: [RFC] [PATCH] virtual memmap on sparsemem v3 [2/4] generic virtual mem_map on sparsemem

2006-12-10 Thread KAMEZAWA Hiroyuki
On Sat, 9 Dec 2006 22:17:00 +0900 KAMEZAWA Hiroyuki [EMAIL PROTECTED] wrote: I'll renew this in the next week. Hi, this is a fix patch. Sorry for my carelessness. I'll post next add-on patch against the next -mm which will be shipped. What I have now are - pfn_valid() optimization - memory

Re: workqueue deadlock

2006-12-10 Thread Dipankar Sarma
On Sun, Dec 10, 2006 at 03:18:38PM +0100, Rafael J. Wysocki wrote: On Sunday, 10 December 2006 13:16, Andrew Morton wrote: On Sun, 10 Dec 2006 12:49:43 +0100 Hm, currently we're using the CPU hotplug to disable the nonboot CPUs before the freezer is called. ;-) However, we're now trying

Re: [patch] lockdep: fix possible races while disabling lock-debugging

2006-12-10 Thread Ingo Molnar
* Jarek Poplawski [EMAIL PROTECTED] wrote: @@ -567,12 +601,10 @@ static noinline int print_circular_bug_t if (debug_locks_silent) return 0; - /* hash_lock unlocked by the header */ - __raw_spin_lock(hash_lock); this.class = check_source-class; if

[patch] lockdep: fix possible race while disabling lock-debugging, restore fix

2006-12-10 Thread Ingo Molnar
* Jarek Poplawski [EMAIL PROTECTED] wrote: ... @@ -1212,7 +1244,8 @@ register_lock_class(struct lockdep_map * hash_head = classhashentry(key); raw_local_irq_save(flags); - __raw_spin_lock(hash_lock); + if (!graph_lock()) ! raw_local_irq_restore(flags); +

Re: [patch] net: dev_watchdog() locking fix

2006-12-10 Thread Andrew Morton
On Sat, 09 Dec 2006 14:02:05 -0800 (PST) David Miller [EMAIL PROTECTED] wrote: From: Herbert Xu [EMAIL PROTECTED] Date: Sat, 9 Dec 2006 10:59:52 +1100 On Fri, Dec 08, 2006 at 03:19:02PM -0800, Andrew Morton wrote: Like this? /* don't get messages out of order, and no

Re: [patch] net: dev_watchdog() locking fix

2006-12-10 Thread Herbert Xu
On Sun, Dec 10, 2006 at 11:45:08PM -0800, Andrew Morton wrote: It spits a nasty during bringup e1000: eth0: e1000_probe: Intel(R) PRO/1000 Network Connection forcedeth.c: Reverse Engineered nForce ethernet driver. Version 0.59. netconsole: device eth0 not up yet, forcing it e1000: eth0:

Re: [Patch](memory hotplug) Fix compile error for i386 with NUMA config

2006-12-10 Thread David Rientjes
On Mon, 11 Dec 2006, Yasunori Goto wrote: No. Other arch's arch_add_memory() and remove_memory() have been already used for NUMA case too. But i386 didn't do it because just contig_page_data is used. Current NODE_DATA() macro is defined both case appropriately. So, this #ifdef is

Re: [patch] net: dev_watchdog() locking fix

2006-12-10 Thread Ingo Molnar
* Herbert Xu [EMAIL PROTECTED] wrote: It spits a nasty during bringup e1000: eth0: e1000_probe: Intel(R) PRO/1000 Network Connection forcedeth.c: Reverse Engineered nForce ethernet driver. Version 0.59. netconsole: device eth0 not up yet, forcing it e1000: eth0: e1000_watchdog: NIC

Re: [PATCH] WorkStruct: Implement generic UP cmpxchg() where an

2006-12-10 Thread Linus Torvalds
On Sun, 10 Dec 2006, [EMAIL PROTECTED] wrote: While I agree that LL/SC can't be part of the kernel API for people to get arbitrarily clever with in the device driver du jour, they are *very* nice abstractions for shrinking the arch-specific code size. I'm not sure. The thing is, it's

Re: [PATCH] WorkStruct: Implement generic UP cmpxchg() where an

2006-12-10 Thread linux
atomic_ll() / atomic_sc() with the restriction that they cannot be nested, you cannot write any C code between them, and may only call into some specific set of atomic_llsc_xxx primitives, operating on the address given to ll, and must not have more than a given number of instructions

Re: [PATCH] WorkStruct: Implement generic UP cmpxchg() where an

2006-12-10 Thread Nick Piggin
[EMAIL PROTECTED] wrote: atomic_ll() / atomic_sc() with the restriction that they cannot be nested, you cannot write any C code between them, and may only call into some specific set of atomic_llsc_xxx primitives, operating on the address given to ll, and must not have more than a given number

Re: Hostap_cs shared irq oops

2006-12-10 Thread Len Brown
On Saturday 09 December 2006 23:42, SuD wrote: Hi, I recently upgraded to kernel 2.6.18.2 and noticed these problems: - I realized that having CONFIG_ISA=y makes it always crash when i insert the card (complains about unexpected LVT TMR interrupt). So i disabled Isa. - Hostap_cs gets a

Re: [PATCH v3 13/13] Kconfig/Makefile

2006-12-10 Thread Roland Dreier
+++ b/drivers/infiniband/hw/cxgb3/locking.txt Should be in Documentation/infiniband/. Docs go in the Documentation/ dir, not in drivers/ dir. Or put it in a comment in the appropriate header, if you want to keep it close to the driver source... - To unsubscribe from this list: send the

Re: [PATCH] WorkStruct: Implement generic UP cmpxchg() where an

2006-12-10 Thread Nick Piggin
Hi "Linux", [EMAIL PROTECTED] wrote: Even if ARM is able to handle any arbitrary C code between the "load locked" and store conditional API, other architectures can not by definition. Maybe so, but I think you and Linus are missing the middle ground. Nobdy argued against adding nice arch

Re: [PATCH] ucb1400_ts depends SND_AC97_BUS

2006-12-10 Thread Randy Dunlap
On Sun, 10 Dec 2006 22:55:25 -0500 (EST) Nicolas Pitre wrote: > On Sat, 9 Dec 2006, Randy Dunlap wrote: > > > On Sat, 09 Dec 2006 22:17:55 -0500 (EST) Nicolas Pitre wrote: > > > > > Please consider what SND_CONFIG_AC97_BUS corresponds to. It is > > > sound/pci/ac97/ac97_bus.c and if you look

Re: Linux portability bugs

2006-12-10 Thread Chuck Ebbert
In-Reply-To: <[EMAIL PROTECTED]> On Fri, 1 Dec 2006 22:39:01 -0800, mariusn wrote: > I am a graduate student at University of Washington, building a tool > automatically discover portability bugs in system-level code written > in C. My definition of "portability" is at the data layout level, >

Re: PAE/NX without performance drain?

2006-12-10 Thread Chuck Ebbert
In-Reply-To: <[EMAIL PROTECTED]> On Sat, 09 Dec 2006 15:39:30 -0500, John Richard Moser wrote: > Is it possible to give some other way to get the hardware NX bit working > in 32-bit mode, without the apparently massive performance penalty of > HIGHMEM64? If your hardware can run the x86_64

Re: [Patch](memory hotplug) Fix compile error for i386 with NUMA config

2006-12-10 Thread Yasunori Goto
Hi David-san. > On Sat, 9 Dec 2006, Yasunori Goto wrote: > > > Hello. > > > > This patch is to fix compile error when config memory hotplug > > with numa on i386. > > > > The cause of compile error was missing of arch_add_memory(), > > remove_memory(), > > and memory_add_physaddr_to_nid()

Re: PAE/NX without performance drain?

2006-12-10 Thread John Richard Moser
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Chuck Ebbert wrote: > In-Reply-To: <[EMAIL PROTECTED]> > > On Sat, 09 Dec 2006 15:39:30 -0500, John Richard Moser wrote: > >> Is it possible to give some other way to get the hardware NX bit working >> in 32-bit mode, without the apparently

Re: workqueue deadlock

2006-12-10 Thread Srivatsa Vaddagiri
On Sun, Dec 10, 2006 at 09:26:16AM +0100, Ingo Molnar wrote: > something like the pseudocode further below - when applied to a data > structure it has semantics and scalability close to that of > preempt_disable(), but it is still preemptible and the lock is specific. Ingo, The

Re: optimalisation for strlcpy (lib/string.c)

2006-12-10 Thread Clemens Koller
Hi, Adrian & Friends! Like the other patch (by that other person), I think it is faster to not do a strlen first. There are PowerPC architectures, where a strlen is a matter of a single instruction of the CPU. Quote: "PowerPC 405 and 440 instruction sets offer the powerful Determine

Re: PAE/NX without performance drain?

2006-12-10 Thread Randy Dunlap
On Sun, 10 Dec 2006 23:58:00 -0500 John Richard Moser wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > > > Chuck Ebbert wrote: > > In-Reply-To: <[EMAIL PROTECTED]> > > > > On Sat, 09 Dec 2006 15:39:30 -0500, John Richard Moser wrote: > > > >> Is it possible to give some other way

Re: workqueue deadlock

2006-12-10 Thread Srivatsa Vaddagiri
On Sun, Dec 10, 2006 at 04:16:00AM -0800, Andrew Morton wrote: > One quite different way of addressing all of this is to stop using > stop_machine_run() for hotplug synchronisation and switch to the swsusp > freezer infrastructure: all kernel threads and user processes need to stop > and park

Re: [PATCH 4/6] MTHCA driver (infiniband) use new pci interfaces

2006-12-10 Thread Grant Grundler
On Mon, Dec 11, 2006 at 02:55:39PM +1100, Benjamin Herrenschmidt wrote: > On Fri, 2006-12-08 at 10:22 -0800, Stephen Hemminger wrote: > > plain text document attachment (mthca-rbc.patch) > > Use new pci interfaces to set read request tuning values > > Untested because of lack of hardware.

Re: workqueue deadlock

2006-12-10 Thread Andrew Morton
> On Mon, 11 Dec 2006 11:15:45 +0530 Srivatsa Vaddagiri <[EMAIL PROTECTED]> > wrote: > On Sun, Dec 10, 2006 at 04:16:00AM -0800, Andrew Morton wrote: > > One quite different way of addressing all of this is to stop using > > stop_machine_run() for hotplug synchronisation and switch to the swsusp

Re: workqueue deadlock

2006-12-10 Thread Ingo Molnar
* Andrew Morton <[EMAIL PROTECTED]> wrote: > > > > > > { > > > > > > int cpu = raw_smp_processor_id(); > > > > > > /* > > > > > > * Interrupts/softirqs are hotplug-safe: > > > > > > */ > > > > > > if (in_interrupt()) > > > > > >

Re: [patch 2.6.19-git] rts-rs5c372 updates: more chips, alarm, 12hr mode, etc

2006-12-10 Thread Voipio Riku
> Update the rtc-rs5c372 driver: > I suspect the > issue wasn't that "mode 1" didn't work on that board; the original > code to fetch the trim was broken. If "mode 1" really won't work, > that's almost certainly a bug in that board's I2C driver. It was not related to trim fetching. Yes, it very

Re: [RFC] [PATCH] virtual memmap on sparsemem v3 [2/4] generic virtual mem_map on sparsemem

2006-12-10 Thread KAMEZAWA Hiroyuki
On Sat, 9 Dec 2006 22:17:00 +0900 KAMEZAWA Hiroyuki <[EMAIL PROTECTED]> wrote: > I'll renew this in the next week. > Hi, this is a fix patch. Sorry for my carelessness. I'll post next add-on patch against the next -mm which will be shipped. What I have now are - pfn_valid() optimization -

Re: workqueue deadlock

2006-12-10 Thread Dipankar Sarma
On Sun, Dec 10, 2006 at 03:18:38PM +0100, Rafael J. Wysocki wrote: > On Sunday, 10 December 2006 13:16, Andrew Morton wrote: > > On Sun, 10 Dec 2006 12:49:43 +0100 > > Hm, currently we're using the CPU hotplug to disable the nonboot CPUs before > the freezer is called. ;-) > > However, we're now

Re: [patch] lockdep: fix possible races while disabling lock-debugging

2006-12-10 Thread Ingo Molnar
* Jarek Poplawski <[EMAIL PROTECTED]> wrote: > > @@ -567,12 +601,10 @@ static noinline int print_circular_bug_t > > if (debug_locks_silent) > > return 0; > > > > - /* hash_lock unlocked by the header */ > > - __raw_spin_lock(_lock); > > this.class = check_source->class;

[patch] lockdep: fix possible race while disabling lock-debugging, restore fix

2006-12-10 Thread Ingo Molnar
* Jarek Poplawski <[EMAIL PROTECTED]> wrote: > ... > > @@ -1212,7 +1244,8 @@ register_lock_class(struct lockdep_map * > > hash_head = classhashentry(key); > > > > raw_local_irq_save(flags); > > - __raw_spin_lock(_lock); > > + if (!graph_lock()) > > !

Re: [patch] net: dev_watchdog() locking fix

2006-12-10 Thread Andrew Morton
On Sat, 09 Dec 2006 14:02:05 -0800 (PST) David Miller <[EMAIL PROTECTED]> wrote: > From: Herbert Xu <[EMAIL PROTECTED]> > Date: Sat, 9 Dec 2006 10:59:52 +1100 > > > On Fri, Dec 08, 2006 at 03:19:02PM -0800, Andrew Morton wrote: > > > > > > Like this? > > > > > > /* don't get messages out of

Re: [patch] net: dev_watchdog() locking fix

2006-12-10 Thread Herbert Xu
On Sun, Dec 10, 2006 at 11:45:08PM -0800, Andrew Morton wrote: > > It spits a nasty during bringup > > e1000: eth0: e1000_probe: Intel(R) PRO/1000 Network Connection > forcedeth.c: Reverse Engineered nForce ethernet driver. Version 0.59. > netconsole: device eth0 not up yet, forcing it > e1000:

Re: [Patch](memory hotplug) Fix compile error for i386 with NUMA config

2006-12-10 Thread David Rientjes
On Mon, 11 Dec 2006, Yasunori Goto wrote: > No. > Other arch's arch_add_memory() and remove_memory() have been already > used for NUMA case too. But i386 didn't do it because just > contig_page_data is used. > Current NODE_DATA() macro is defined both case appropriately. > So, this #ifdef is

Re: [patch] net: dev_watchdog() locking fix

2006-12-10 Thread Ingo Molnar
* Herbert Xu <[EMAIL PROTECTED]> wrote: > > It spits a nasty during bringup > > > > e1000: eth0: e1000_probe: Intel(R) PRO/1000 Network Connection > > forcedeth.c: Reverse Engineered nForce ethernet driver. Version 0.59. > > netconsole: device eth0 not up yet, forcing it > > e1000: eth0:

Re: [PATCH] WorkStruct: Implement generic UP cmpxchg() where an

2006-12-10 Thread Linus Torvalds
On Sun, 10 Dec 2006, [EMAIL PROTECTED] wrote: > > While I agree that LL/SC can't be part of the kernel API for people to > get arbitrarily clever with in the device driver du jour, they are *very* > nice abstractions for shrinking the arch-specific code size. I'm not sure. The thing is, it's

Re: [PATCH] WorkStruct: Implement generic UP cmpxchg() where an

2006-12-10 Thread linux
> atomic_ll() / atomic_sc() with the restriction that they cannot be > nested, you cannot write any C code between them, and may only call > into some specific set of atomic_llsc_xxx primitives, operating on > the address given to ll, and must not have more than a given number > of

Re: [PATCH] WorkStruct: Implement generic UP cmpxchg() where an

2006-12-10 Thread Nick Piggin
[EMAIL PROTECTED] wrote: atomic_ll() / atomic_sc() with the restriction that they cannot be nested, you cannot write any C code between them, and may only call into some specific set of atomic_llsc_xxx primitives, operating on the address given to ll, and must not have more than a given number

Re: Hostap_cs shared irq oops

2006-12-10 Thread Len Brown
On Saturday 09 December 2006 23:42, SuD wrote: > Hi, I recently upgraded to kernel 2.6.18.2 and noticed these problems: > - I realized that having CONFIG_ISA=y makes it always crash when i > insert the card (complains about unexpected LVT TMR interrupt). So i > disabled Isa. > - Hostap_cs gets

Re: [PATCH v3 13/13] Kconfig/Makefile

2006-12-10 Thread Roland Dreier
> > +++ b/drivers/infiniband/hw/cxgb3/locking.txt > Should be in Documentation/infiniband/. > Docs go in the Documentation/ dir, not in drivers/ dir. Or put it in a comment in the appropriate header, if you want to keep it close to the driver source... - To unsubscribe from this list: send