Re: [PATCH] NAND: nandsim bad block injection

2007-01-02 Thread Artem Bityutskiy
On Sun, 2006-12-31 at 20:43 +0530, Vijay Kumar wrote: Artem Bityutskiy writes: 1. Suppose we decided to emulate an erase failure for a certain eraseblock. Then the MTD user re-tries the operation and succeeds. Shouldn't we start always returning erase errors for this eraseblock

doubts on file_pos_write()

2007-01-02 Thread Oliver Neukum
Hi, as loff_t is a 64 bit value, it seems to me to a simple assignment in file_pos_write() means that the offset can be turned into garbage doing concurrent reads with shared fds around the 4GB limit on 32 bit architectures. Comments? Regards Oliver - To unsubscribe from

Re: [PATCH 2.6.19] Adding branch to remove possible unnecessary inst

2007-01-02 Thread Jens Axboe
On Sun, Dec 31 2006, yc_zhou wrote: Function blk_queue_bounce_limit using dma flag to determine whether assigned a certain value for member of request_queue_t. But the assignment is unconditionally after the flag is set. It introduce possible unnecessary instructions. Your patch is white

Re: 2.6.20-rc2+: CFQ halving disk throughput.

2007-01-02 Thread Jens Axboe
On Mon, Jan 01 2007, Mark Lord wrote: Rene Herman wrote: Tejun Heo wrote: Everything seems fine in the dmesg. Performance degradation is probably some other issue in -rc kernel. I'm suspecting recently fixed block layer bug. If it's still the same in the next -rc, please report. In

Re: 2.6.20 regression: suspend to disk no more works

2007-01-02 Thread Andrey Borzenkov
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Tuesday 02 January 2007 02:28, Rafael J. Wysocki wrote: Hi, On Monday, 1 January 2007 20:44, Andrey Borzenkov wrote: In *the same* configuration STD now fails with Cannot find swap device. The reason is changes in kernel/power/swap.c. In

Re: 2.6.20-rc2+: CFQ halving disk throughput.

2007-01-02 Thread Jens Axboe
On Mon, Jan 01 2007, Andrew Morton wrote: On Mon, 01 Jan 2007 23:46:58 +0100 Rene Herman [EMAIL PROTECTED] wrote: Everything seems fine in the dmesg. Performance degradation is probably some other issue in -rc kernel. I'm suspecting recently fixed block layer bug. If it's still the

Re: Cut power to a USB port?

2007-01-02 Thread Greg KH
On Mon, Jan 01, 2007 at 03:56:25PM -0500, Andrew Barr wrote: I have a simple question perhaps someone can help me with here... I have one of those simple LED keyboard lamps that get their power from the USB port. Is there some way in Linux, using files under /sys I would imagine, to cut

Re: [2.6 patch] net/irda/: proper prototypes

2007-01-02 Thread David Miller
From: Adrian Bunk [EMAIL PROTECTED] Date: Mon, 18 Dec 2006 04:46:26 +0100 This patch adds proper prototypes for some functions in include/net/irda/irda.h Signed-off-by: Adrian Bunk [EMAIL PROTECTED] ... +struct net_device; +struct packet_type; + +void irda_proc_register(void); +void

Re: [PATCH 4/8] UML - audio driver formatting

2007-01-02 Thread Richard Knutsson
Randy Dunlap wrote: On Tue, 02 Jan 2007 02:52:33 +0100 Richard Knutsson wrote: Jeff Dike wrote: Whitespace and style fixes. Signed-off-by: Jeff Dike [EMAIL PROTECTED] -- arch/um/drivers/hostaudio_kern.c | 160 +-- 1 file changed, 73

Re: selinux networking: sleeping functin called from invalid context in 2.6.20-rc[12]

2007-01-02 Thread Adam J. Richter
On Sun, Dec 24, 2006 at 04:25:11PM -0800, Andrew Morton wrote: On Mon, 25 Dec 2006 05:21:24 +0800 Adam J. Richter [EMAIL PROTECTED] wrote: Under 2.6.20-rc1 and 2.6.20-rc2, I get the following complaint for several network programs running on my system: [ 156.381868] BUG: sleeping

Re: [PATCH] DocBook/HTML: Generate chapter/section level TOCs for functions

2007-01-02 Thread Pavel Pisa
On Tuesday 02 January 2007 01:41, Randy Dunlap wrote: On Sun, 31 Dec 2006 02:27:46 +0100 Pavel Pisa wrote: Simple increase of section TOC level generation significantly enhances navigation experience through generated kernel API documentation. This change restores back state from SGML

Re: [PATCH] include/linux/slab.h: new KFREE() macro.

2007-01-02 Thread Christoph Hellwig
On Mon, Jan 01, 2007 at 11:23:20PM +0200, Pekka Enberg wrote: NAK until you have actual callers for it. CONFIG_SLAB_DEBUG already catches use after free and double-free so I don't see the point of this. And CONFIG_SLAB_DEBUG actually finds them for real using poisoning, unlike setting the

Re: Patch i386: Relocatable kernel support causes instant reboot

2007-01-02 Thread Jean Delvare
Hi Vivek, On Tue, 2 Jan 2007 11:41:47 +0530, Vivek Goyal wrote: Segher had suggested to use .section command to specifically mark .text.head section as AX (allocatable and executable) to solve the problem. Can you please try the attached patch to see if it solves your problem. Thanks

Re: Open letter to Linux kernel developers (was Re: Binary Drivers)

2007-01-02 Thread Bernd Petrovitsch
On Tue, 2007-01-02 at 16:30 +1000, Trent Waddington wrote: [...] I think you're repeating a myth that has become a common part of hacker lore in recent years. It's caused by how little we know about software patents. The myth is that if you release source code which violates someone's patent

Re: 2.6.19-rc5: grub is much slower resuming from suspend-to-disk than in 2.6.18

2007-01-02 Thread Stefan Seyfried
On Sat, Dec 16, 2006 at 08:05:24PM +0100, Lee Garrett wrote: Andrey Borzenkov wrote: [...] This is rather funny; in 2.6.19-rc5 grub is *really* slow loading kernel when I switch on the system after suspend to disk. Actually, after kernel has been loaded, the whole resuming (up to the

Re: [PATCH] Print sysrq-m messages with KERN_INFO priority

2007-01-02 Thread Alan
On Mon, 1 Jan 2007 23:37:43 -0500 Theodore Tso [EMAIL PROTECTED] wrote: Is this patch a consistency thing? The goal of the patch was to avoid filling /var/log/messages huge amounts of sysrq text. Some of the sysrq commands, especially sysrq-m and sysrq-t emit a truly vast amount of

Re: [PATCH] quiet MMCONFIG related printks

2007-01-02 Thread Alan
On Mon, 1 Jan 2007 21:01:38 -0800 Jesse Barnes [EMAIL PROTECTED] wrote: Using MMCONFIG for PCI config space access is simply an optimization, not a requirement. Therefore, when it can't be used, there's no need for Some hardware reqires MCFG. In addition this is an error, a real error on the

Re: 2.6.20-rc2+: CFQ halving disk throughput.

2007-01-02 Thread Rene Herman
Jens Axboe wrote: On Mon, Jan 01 2007, Andrew Morton wrote: The patch would appear to need this fix: --- a/block/cfq-iosched.c~a +++ a/block/cfq-iosched.c @@ -592,7 +592,7 @@ static int cfq_allow_merge(request_queue if (cfqq == RQ_CFQQ(rq)) return 1; - return 1; +

Re: Suspend problems on 2.6.20-rc2-git1

2007-01-02 Thread Pavel Machek
Hi! Secondly, if you try and suspend manually it claims there is no swap device available when there clearly is: [EMAIL PROTECTED] rob]# cat /proc/swaps FilenameTypeSizeUsed Priority /dev/mapper/VolGroup00-LogVol01

Re: Open letter to Linux kernel developers (was Re: Binary Drivers)

2007-01-02 Thread Alan
I think you're repeating a myth that has become a common part of hacker lore in recent years. It's caused by how little we know about software patents. The myth is that if you release source code which violates someone's patent that is somehow worse than if you release binaries that violate

Re: 2.6.20 regression: suspend to disk no more works

2007-01-02 Thread Pavel Machek
Hi! While 'echo a:b /sys/power/resume' before suspend is a workaround, this still breaks perfectly valid setup that worked before. Also 'echo a:b /sys/power/resume' is actually wrong - we are not going to resume at this point; but there is no way to just tell kernel use this device

Re: s2disk curiosity :)

2007-01-02 Thread Stefan Seyfried
On Mon, Dec 18, 2006 at 11:14:51AM +0100, Paolo Ornati wrote: On Mon, 18 Dec 2006 10:36:24 +0100 Stefan Seyfried [EMAIL PROTECTED] wrote: It depends on the BIOS. Many BIOSes have a setting where you can set the power fail mode to on, off or as before. Ok, I've found the BIOS setting:

Re: [PATCH] cdrom: longer timeout for Read Track Info command

2007-01-02 Thread Alan
On Mon, 1 Jan 2007 18:36:24 -0800 Jeremy Higdon [EMAIL PROTECTED] wrote: I have a DVD combo drive and a CD in which the READ TRACK INFORMATION command (implemented in the cdrom_get_track_info() function) takes about 7 seconds to run. The current implementation of cdrom_get_track_info() uses

Re: [PATCH] net: ifb error path loop fix

2007-01-02 Thread Jarek Poplawski
On 02-01-2007 08:51, David Miller wrote: From: Mariusz Kozlowski [EMAIL PROTECTED] Date: Tue, 2 Jan 2007 00:55:51 +0100 On error we should start freeing resources at [i-1] not [i-2]. Signed-off-by: Mariusz Kozlowski [EMAIL PROTECTED] Patch applied, thanks Mariusz. diff -upr

Re: [PATCH] net: ifb error path loop fix

2007-01-02 Thread Mariusz Kozlowski
Hello David, One could argue from a defensive programming perspective that this bug comes from the fact that the ifb_init_one() loop advances state before checking for errors ('i' is advanced before the 'err' check due to the loop construct), and that's why the error recovery code had to be

Re: 2.6.19-rc5: grub is much slower resuming from suspend-to-disk than in 2.6.18

2007-01-02 Thread Xavier Bestel
On Tue, 2007-01-02 at 11:05 +0100, Stefan Seyfried wrote: On Sat, Dec 16, 2006 at 08:05:24PM +0100, Lee Garrett wrote: Andrey Borzenkov wrote: [...] This is rather funny; in 2.6.19-rc5 grub is *really* slow loading kernel when I switch on the system after suspend to disk. Actually,

Re: [patch] remove redundant iov segment check

2007-01-02 Thread Christoph Hellwig
I wonder if it wouldn't be better to make this change as part of a larger change that moves towards an explicit iovec container struct rather than bare 'struct iov *' and 'nr_segs' arguments. The struct could have a flag that expressed whether the elements had been checked. A helper

CONFIG_PHYSICAL_ALIGN limited to 4M?

2007-01-02 Thread Rene Herman
Good day. A while ago it was remarked on list here that keeping the kernel 4M aligned physically might be a performance win if the added 1M (it normally loads at 1M) meant it would fit on one 4M aligned hugepage instead of 2 and since that time I've been doing such. In fact, while I was at

2.6.20-rc3: bt878/bttv: Unknown symbols, despite being defined in module depended on

2007-01-02 Thread Leonard Norrgard
This seems a bit odd. As the bt878 module loads, I get the following error messages, despite definitions in the bttv module that bt878 depends on: # egrep '(bttv_read_gpio|bttv_write_gpio|bttv_gpio_enable)' /var/log/dmesg bt878: Unknown symbol bttv_read_gpio bt878: Unknown symbol bttv_write_gpio

Re: [PATCH] incorrect error handling inside generic_file_direct_write

2007-01-02 Thread 'Christoph Hellwig'
On Fri, Dec 15, 2006 at 10:53:18AM -0800, Chen, Kenneth W wrote: Christoph Hellwig wrote on Friday, December 15, 2006 2:44 AM So we're doing the sync_page_range once in __generic_file_aio_write with i_mutex held. mutex_lock(inode-i_mutex); - ret =

Re: [patch] fix data corruption bug in __block_write_full_page()

2007-01-02 Thread Christoph Hellwig
On Fri, Dec 29, 2006 at 01:19:46PM +0100, Ingo Molnar wrote: i've extended the tracer in -rt to trace all relevant pagetable, pagecache, buffer-cache and IO events and coupled the tracer to your test.c code. The corruption happens here: test-2126 0 3756170us+: trace_page (cf20ebd8

Re: Open letter to Linux kernel developers (was Re: Binary Drivers)

2007-01-02 Thread Trent Waddington
On 1/2/07, Bernd Petrovitsch [EMAIL PROTECTED] wrote: While this is true (at last in theory), there is one difference in practice: It is *much* easier to prove a/the patent violation if you have (original?) source code than to reverse engineer the assembler dump of the compiled code and prove

[PATCH] ppc: prom of_node_(get|put) cleanup

2007-01-02 Thread Mariusz Kozlowski
Hello, This patch removes redundant argument checks for of_node_get() and of_node_put(). Signed-off-by: Mariusz Kozlowski [EMAIL PROTECTED] arch/powerpc/kernel/prom.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff -upr

Re: Device does not have a release() function

2007-01-02 Thread Vitaly Bordug
Avuton, Thanks for this report, Please excuse me if this has already been discussed. Anything else that's needed please let me know. kernel: Linux version 2.6.20-rc2 ([EMAIL PROTECTED]) (gcc version 4.1.1 (Gentoo 4.1.1-r3)) #6 SMP PREEMPT Thu Dec 28 21:07:58 PST 2006 Spotted this in

[PATCH] ppc: cpm2_pic of_node_get cleanup

2007-01-02 Thread Mariusz Kozlowski
Hello, This patch removes redundant argument check for of_node_get(). Signed-off-by: Mariusz Kozlowski [EMAIL PROTECTED] arch/powerpc/sysdev/cpm2_pic.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff -upr linux-2.6.20-rc2-mm1-a/arch/powerpc/sysdev/cpm2_pic.c

[PATCH] ppc: vio of_node_put cleanup

2007-01-02 Thread Mariusz Kozlowski
Hello, This patch removes redundant argument check for of_node_put(). Signed-off-by: Mariusz Kozlowski [EMAIL PROTECTED] arch/powerpc/kernel/vio.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff -upr linux-2.6.20-rc2-mm1-a/arch/powerpc/kernel/vio.c

[PATCH] ppc: i8259 of_node_get cleanup

2007-01-02 Thread Mariusz Kozlowski
Hello, This patch removes redundant argument check for of_node_get(). Signed-off-by: Mariusz Kozlowski [EMAIL PROTECTED] arch/powerpc/sysdev/i8259.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff -upr linux-2.6.20-rc2-mm1-a/arch/powerpc/sysdev/i8259.c

[PATCH] libata: fix combined mode (was Re: Happy New Year (and v2.6.20-rc3 released))

2007-01-02 Thread Alan
This is a slight variant on the patch I posted December 16th to fix libata combined mode handling. The only real change is that we now correctly also reserve BAR1,2,4. That is basically a neatness issue. Jeff was unhappy about two things 1. That it didn't work in the case of one channel native

[PATCH] ppc: ipic of_node_get cleanup

2007-01-02 Thread Mariusz Kozlowski
Hello, No need for ?: because of_node_get() can handle NULL argument. Signed-off-by: Mariusz Kozlowski [EMAIL PROTECTED] arch/powerpc/sysdev/ipic.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -upr linux-2.6.20-rc2-mm1-a/arch/powerpc/sysdev/ipic.c

Re: 2.6.19 and up to 2.6.20-rc2 Ethernet problems x86_64

2007-01-02 Thread Jarek Poplawski
On Sat, Dec 30, 2006 at 02:21:15AM +, Sid Boyce wrote: Jarek Poplawski wrote: On 28-12-2006 04:23, Sid Boyce wrote: I first saw the problem on the 64x2 box after upgrading to 2.6.19. The network appeared OK with ifconfig and route -n, but I had no network access. Pinging any other box,

[PATCH] ppc: mpic of_node_get cleanup

2007-01-02 Thread Mariusz Kozlowski
Hello, No need for ?: because of_node_get() can handle NULL argument. Signed-off-by: Mariusz Kozlowski [EMAIL PROTECTED] arch/powerpc/sysdev/mpic.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -upr linux-2.6.20-rc2-mm1-a/arch/powerpc/sysdev/mpic.c

Re: 2.6.19.1, sata_sil: sata dvd writer doesn't work

2007-01-02 Thread Tejun Heo
Hello, Harald Dunkel wrote: Hi Tejun, After the patch was applied (using 2.6.19.1 instead of 2.6.19, hope you don't mind) I could play a DVD once. Unfortunately this was not reproducible, using the same DVD. I have attached the requested log files for the good and the last bad session.

[PATCH] video: pvrusb2-hdw kfree cleanup

2007-01-02 Thread Mariusz Kozlowski
Hello, This patch removes redundant argument check for kfree(). drivers/media/video/pvrusb2/pvrusb2-hdw.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff -upr linux-2.6.20-rc2-mm1-a/drivers/media/video/pvrusb2/pvrusb2-hdw.c

Re: 2.6.20-rc2+: CFQ halving disk throughput.

2007-01-02 Thread Jens Axboe
On Tue, Jan 02 2007, Rene Herman wrote: Jens Axboe wrote: On Mon, Jan 01 2007, Andrew Morton wrote: The patch would appear to need this fix: --- a/block/cfq-iosched.c~a +++ a/block/cfq-iosched.c @@ -592,7 +592,7 @@ static int cfq_allow_merge(request_queue if (cfqq == RQ_CFQQ(rq))

[PATCH] ppc: qe_lib of_node_get cleanup

2007-01-02 Thread Mariusz Kozlowski
Hello, No need for ?: as of_node_get() can handle NULL argument. Signed-off-by: Mariusz Kozlowski [EMAIL PROTECTED] arch/powerpc/sysdev/qe_lib/qe_ic.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -upr linux-2.6.20-rc2-mm1-a/arch/powerpc/sysdev/qe_lib/qe_ic.c

Re: The Input Layer and the Serial Port

2007-01-02 Thread David Greaves
Loye Young wrote: Basically, I need the scanner to act like another keyboard. Scan a code, see the numbers. Depends, do you want to get the job done or play with drivers? If the former then get yourself to eBay and buy a brand new PS/2 barcode reader for circa $10-$20 that plugs between the

Re: Open letter to Linux kernel developers (was Re: Binary Drivers)

2007-01-02 Thread Bernd Petrovitsch
On Tue, 2007-01-02 at 21:26 +1000, Trent Waddington wrote: On 1/2/07, Bernd Petrovitsch [EMAIL PROTECTED] wrote: While this is true (at last in theory), there is one difference in practice: It is *much* easier to prove a/the patent violation if you have (original?) source code than to

Re: [PATCH] libata: fix combined mode (was Re: Happy New Year (and v2.6.20-rc3 released))

2007-01-02 Thread Alessandro Suardi
On 1/2/07, Alan [EMAIL PROTECTED] wrote: This is a slight variant on the patch I posted December 16th to fix libata combined mode handling. The only real change is that we now correctly also reserve BAR1,2,4. That is basically a neatness issue. Jeff was unhappy about two things 1. That it

Re: [patch] fix data corruption bug in __block_write_full_page()

2007-01-02 Thread Ingo Molnar
[Cc:-ed lkml] * Christoph Hellwig [EMAIL PROTECTED] wrote: On Fri, Dec 29, 2006 at 01:19:46PM +0100, Ingo Molnar wrote: i've extended the tracer in -rt to trace all relevant pagetable, pagecache, buffer-cache and IO events and coupled the tracer to your test.c code. The corruption

Re: 2.6.20-rc2+: CFQ halving disk throughput.

2007-01-02 Thread Jens Axboe
On Tue, Jan 02 2007, Jens Axboe wrote: On Tue, Jan 02 2007, Rene Herman wrote: Jens Axboe wrote: On Mon, Jan 01 2007, Andrew Morton wrote: The patch would appear to need this fix: --- a/block/cfq-iosched.c~a +++ a/block/cfq-iosched.c @@ -592,7 +592,7 @@ static int

Re: 2.6.19-rc5: grub is much slower resuming from suspend-to-disk than in 2.6.18

2007-01-02 Thread Stefan Seyfried
On Tue, Jan 02, 2007 at 11:58:03AM +0100, Xavier Bestel wrote: On Tue, 2007-01-02 at 11:05 +0100, Stefan Seyfried wrote: On Sat, Dec 16, 2006 at 08:05:24PM +0100, Lee Garrett wrote: I had the same problem (/boot on reiserfs, grub hanging for ages after resume with 2.6.19), but in

[PATCH] isdn: capi kfree_skb cleanup

2007-01-02 Thread Mariusz Kozlowski
Hello, This patch removes redundant argument check for kfree_skb(). Signed-off-by: Mariusz Kozlowski [EMAIL PROTECTED] drivers/isdn/capi/capi.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -upr linux-2.6.20-rc2-mm1-a/drivers/isdn/capi/capi.c

Re: [patch] fix data corruption bug in __block_write_full_page()

2007-01-02 Thread Christoph Hellwig
On Tue, Jan 02, 2007 at 01:06:34PM +0100, Ingo Molnar wrote: Find it below - it's ontop of the tracer included in 2.6.20-rc2-rt3. it's very ad-hoc, based on Linus' test utility. I can write such a tracer in 30 minutes so i usually throw them away. I literally wrote dozens of tracer variants

[PATCH] fs: proc module_put cleanup

2007-01-02 Thread Mariusz Kozlowski
Hello, This patch removes redundant argument check for module_put(). Signed-off-by: Mariusz Kozlowski [EMAIL PROTECTED] fs/proc/inode.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff -upr linux-2.6.20-rc2-mm1-a/fs/proc/inode.c linux-2.6.20-rc2-mm1-b/fs/proc/inode.c

[patch] fs: sysfs kobject_put cleanup

2007-01-02 Thread Mariusz Kozlowski
Hello, This patch removes redundant argument checks for kobject_put(). Signed-off-by: Mariusz Kozlowski [EMAIL PROTECTED] fs/sysfs/bin.c |5 ++--- fs/sysfs/file.c |5 ++--- 2 files changed, 4 insertions(+), 6 deletions(-) diff -upr linux-2.6.20-rc2-mm1-a/fs/sysfs/bin.c

[PATCH] lib: kobject_put cleanup

2007-01-02 Thread Mariusz Kozlowski
Hello, This patch removes redundant argument checks for kobject_put(). Signed-off-by: Mariusz Kozlowski [EMAIL PROTECTED] lib/kobject.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff -upr linux-2.6.20-rc2-mm1-a/lib/kobject.c linux-2.6.20-rc2-mm1-b/lib/kobject.c

[PATCH] sound: aoa of_node_put and kfree cleanup

2007-01-02 Thread Mariusz Kozlowski
Hello, This patch removes redundant argument checks for of_node_put() and kfree(). Signed-off-by: Mariusz Kozlowski [EMAIL PROTECTED] sound/aoa/fabrics/snd-aoa-fabric-layout.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -upr

Re: Open letter to Linux kernel developers (was Re: Binary Drivers)

2007-01-02 Thread Theodore Tso
On Tue, Jan 02, 2007 at 09:26:14PM +1000, Trent Waddington wrote: The list of features which the driver supports is going to be sufficient evidence for 99% of patents that relate to computer graphics hardware. Nope, not necessarily. Recall that Patent Office has issued a patent on the concept

[PATCH] video: cpia module_put cleanup

2007-01-02 Thread Mariusz Kozlowski
Hello, No need for redundant argument check for module_put(). Signed-off-by: Mariusz Kozlowski [EMAIL PROTECTED] drivers/media/video/cpia.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff -upr linux-2.6.20-rc2-mm1-a/drivers/media/video/cpia.c

Re: [PATCH] video: pvrusb2-hdw kfree cleanup

2007-01-02 Thread Mariusz Kozlowski
Hello, This patch removes redundant argument check for kfree(). drivers/media/video/pvrusb2/pvrusb2-hdw.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) Signed-off-by: Mariusz Kozlowski [EMAIL PROTECTED] -- Regards, Mariusz Kozlowski - To

[PATCH] video: tvmixer module_put cleanup

2007-01-02 Thread Mariusz Kozlowski
Hello, This patch removes redundant argument check for module_put(). Signed-off-by: Mariusz Kozlowski [EMAIL PROTECTED] drivers/media/video/tvmixer.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff -upr linux-2.6.20-rc2-mm1-a/drivers/media/video/tvmixer.c

Re: [2.6 patch] net/irda/: proper prototypes

2007-01-02 Thread Adrian Bunk
On Tue, Jan 02, 2007 at 12:39:53AM -0800, David Miller wrote: From: Adrian Bunk [EMAIL PROTECTED] Date: Mon, 18 Dec 2006 04:46:26 +0100 This patch adds proper prototypes for some functions in include/net/irda/irda.h Signed-off-by: Adrian Bunk [EMAIL PROTECTED] ... +struct

[PATCH] net: af_netlink module_put cleanup

2007-01-02 Thread Mariusz Kozlowski
Hello, This patch removes redundant argument check for module_put(). Signed-off-by: Mariusz Kozlowski [EMAIL PROTECTED] net/netlink/af_netlink.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff -upr linux-2.6.20-rc2-mm1-a/net/netlink/af_netlink.c

Re: [PATCH] Open Firmware device tree virtual filesystem

2007-01-02 Thread Segher Boessenkool
It has proved a good idea in general as I can easily get an exact device-tree dump from users by asking for a tarball of /proc/device-tree and in some case, the data in there -is- binary (For example, the EDID properties for monitors left by video drivers, or things like that). Yes and with

Re: [PATCH] Open Firmware device tree virtual filesystem

2007-01-02 Thread Segher Boessenkool
There is one big problem: text representation is useless (to scripts etc.) unless it can be transformed back to binary; i.e., it has to be possible to reliably detect _how_ some property is represented into text, something that cannot be done with how openpromfs handles it. Text is text is text

Re: [PATCH] Open Firmware device tree virtual filesystem

2007-01-02 Thread Segher Boessenkool
So please do this crap right. I strongly agree. Nowadays, both powerpc and sparc use an in-memory copy of the tree (wether you use the flattened format during the trampoline from OF runtime to the kernel or not is a different matter, we created that for the sake of kexec and embedded devices

Re: [PATCH] Open Firmware device tree virtual filesystem

2007-01-02 Thread Segher Boessenkool
In addition, I haven't given on the idea one day of actually merging the powerpc and sparc implementation of a lot of that stuff. Mostly the device-tree accessors proper, the of_device/of_platform bits etc... into something like drivers/of1394 maybe. 1394? :-) Thus if i386 is going to

Re: [PATCH] Open Firmware device tree virtual filesystem

2007-01-02 Thread Segher Boessenkool
Except that none of the powerpc platforms can keep OF alive after the kernel has booted, which is why we do an in-memory copy of the tree. Adding that functionality hasn't gotten easier at all since we use the flattened tree for everything, heh. We have well defined interfaces to access that

Re: [PATCH] Open Firmware device tree virtual filesystem

2007-01-02 Thread Segher Boessenkool
IMHO, the directory entries in the filesystem should be in the form [EMAIL PROTECTED] (eg: /[EMAIL PROTECTED],0, pci is the node name, @ is the separator character defined by IEEE 1275, and 1f,0 is the unit-address, which are always guaranteed to be unique. They should be. The problem is buggy

Re: [PATCH] Open Firmware device tree virtual filesystem

2007-01-02 Thread Segher Boessenkool
Simple system tools should not need to interpret binary data in order to provide access to simple structured data like this, that's just stupid. I would agree with you if the data was properly typed in the first place but it's not, OF device tree properties are properly typed just fine --

Re: [PATCH] KVM: Improve interrupt response

2007-01-02 Thread Ingo Molnar
* Avi Kivity [EMAIL PROTECTED] wrote: From: Dor Laor [EMAIL PROTECTED] The current interrupt injection mechanism might delay an interrupt under the following circumstances: - if injection fails because the guest is not interruptible (rflags.IF clear, or after a 'mov ss' or 'sti'

Re: [PATCH] sound: aoa of_node_put and kfree cleanup

2007-01-02 Thread Johannes Berg
On Tue, 2007-01-02 at 13:50 +0100, Mariusz Kozlowski wrote: This patch removes redundant argument checks for of_node_put() and kfree(). Looks good to me, thanks. Signed-off-by: Mariusz Kozlowski [EMAIL PROTECTED] Acked-by: Johannes Berg [EMAIL PROTECTED]

Re: Open letter to Linux kernel developers (was Re: Binary Drivers)

2007-01-02 Thread Robert P. J. Day
On Tue, 2 Jan 2007, Theodore Tso wrote: I can very easily believe it. The US patent system and justice system in the US is completely and totally insane, and companies often feel they have to act accordingly. Remember this is the country that has issued multi-million dollar awards to people

Re: Patch i386: Relocatable kernel support causes instant reboot

2007-01-02 Thread Segher Boessenkool
Segher had suggested to use .section command to specifically mark .text.head section as AX (allocatable and executable) to solve the problem. Great to hear it works in real life too. Here, have a From: line (or how should this patch history be encoded?) :-) From: Segher Boessenkool [EMAIL

Re: [PATCH] libata: fix combined mode (was Re: Happy New Year (and v2.6.20-rc3 released))

2007-01-02 Thread Alan
Appears to work just fine here (compiles, boots and I'm typing this email :). The build warnings below seem new to me - but I guess they're harmless... They are harmless. For the 2.6.21 code base they will go away as well. - To unsubscribe from this list: send the line unsubscribe

[PATCH] slab: cache alloc cleanups

2007-01-02 Thread Pekka J Enberg
[Andrew, I have been unable to find a NUMA-capable tester for this patch, so can we please put this in to -mm for some exposure?] From: Pekka Enberg [EMAIL PROTECTED] This patch cleans up __cache_alloc and __cache_alloc_node functions. We no longer need to do NUMA_BUILD tricks and the UMA

Re: [PATCH] ppc: vio of_node_put cleanup

2007-01-02 Thread Segher Boessenkool
static void __devinit vio_dev_release(struct device *dev) { - if (dev-archdata.of_node) { - /* XXX should free TCE table */ - of_node_put(dev-archdata.of_node); - } + /* XXX should free TCE table */ + of_node_put(dev-archdata.of_node);

[BUG-RT] RTC has been stopped- long delay during boot, soft reboot-GRUB fails to call getrtsecs()

2007-01-02 Thread Remy Bohmer
Hello Ingo, I have discovered 3 problems that are likely all related to the same root-cause, likely to be caused by the RT-kernel. I use the 2.6.19-rt15 kernel, with the configuration attached to this mail. It is running on a standard x86, i945, Celeron 2.93 GHZ (=UP), Fedora Core 6 So, I have

regression: bluetooth oopses because of multiple kobject_add()

2007-01-02 Thread Pavel Machek
Hi! On 2.6.20-rc2, I got: This used to work before... certainly with 2.6.19. Running this multiple times seems to trigger it: #!/bin/bash # # Run tui on desktop machine, using t68i instead of a modem. # hciconfig hci0 name billionton hciconfig hci0 up hcid rfcomm unbind 1 # t68 rfcomm bind 1

mount --bind and /proc/mounts

2007-01-02 Thread Mark Hlawatschek
Hi, I'm using a shared root environment and therefore linked /etc/mtab to /proc/mounts. In addition I'm using --bind mount to make administration easier. Now I found the following behaviour: # mount -a is mounting all filesystems with bind options in the fstab everytime the command mount -a

Re: [patch 2.6.20-rc1 1/6] GPIO core

2007-01-02 Thread Pavel Machek
Hi! Should it instead say that's an (obviously unchecked) error? Saying it is an error would be okay by me. (Or Behaviour of these calls for GPIOs that can't be safely accessed without sleeping is undefined.). See the appended doc patch ... better? Yes, thanks.

Re: [PATCH] slab: cache alloc cleanups

2007-01-02 Thread Andy Whitcroft
Pekka J Enberg wrote: [Andrew, I have been unable to find a NUMA-capable tester for this patch, so can we please put this in to -mm for some exposure?] From: Pekka Enberg [EMAIL PROTECTED] This patch cleans up __cache_alloc and __cache_alloc_node functions. We no longer need to do

SATA problems

2007-01-02 Thread Pablo Sebastian Greco
First of all, thanks for everything, and my excuses if I'm doing anything wrong, this is my first lkml mail, but I've read all the faq, so should be OK. This is the machine with the problem: Intel ServerBoard S5000VSA Dual Core Xeon 2.66 (Intel(R) Xeon(TM) CPU 2.66GHz stepping 04) 4G Kingston

Re: [2.6 patch] drivers/scsi/scsi_error.c should #include scsi_transport_api.h

2007-01-02 Thread Christoph Hellwig
On Wed, Nov 29, 2006 at 06:16:24AM -0700, Matthew Wilcox wrote: On Wed, Nov 29, 2006 at 11:04:22AM +0100, Adrian Bunk wrote: +#include scsi_transport_api.h scsi_transport_api.h is a weird little file. It's not included by anything in the drivers/scsi directory, only

Re: [PATCH] Sun3 SCSI: Make sun3 scsi drivers compile/work again

2007-01-02 Thread Christoph Hellwig
On Sat, Dec 09, 2006 at 10:37:05AM +0100, Geert Uytterhoeven wrote: +#include initio.h This is definitly wrong. This is a header file for a specific driver. I suspect you want the old-EH definitions for SCSI_RESET_*/SCSI_ABORT_*? You're returning them from the EH routines which are plugged

Re: [PATCH] cdrom: longer timeout for Read Track Info command

2007-01-02 Thread Jens Axboe
On Tue, Jan 02 2007, Alan wrote: On Mon, 1 Jan 2007 18:36:24 -0800 Jeremy Higdon [EMAIL PROTECTED] wrote: I have a DVD combo drive and a CD in which the READ TRACK INFORMATION command (implemented in the cdrom_get_track_info() function) takes about 7 seconds to run. The current

Re: [FSAIO][PATCH 6/8] Enable asynchronous wait page and lock page

2007-01-02 Thread Christoph Hellwig
On Thu, Dec 28, 2006 at 08:17:17PM +0530, Suparna Bhattacharya wrote: I am really bad with names :( I tried using the _wq suffixes earlier and that seemed confusing to some, but if no one else objects I'm happy to use that. I thought aio_lock_page() might be misleading because it is

Re: [FSAIO][PATCH 7/8] Filesystem AIO read

2007-01-02 Thread Christoph Hellwig
On Thu, Dec 28, 2006 at 08:48:30PM +0530, Suparna Bhattacharya wrote: Yes, we can do that -- how about aio_restarted() as an alternate name ? Sounds fine to me. Pluse possible naming updates discussed in the last mail. Also do we really need to pass current-io_wait here? Isn't the

Re: problem with pata_hpt37x ...

2007-01-02 Thread Alan
On Tue, 2 Jan 2007 08:01:45 +0100 Herbert Poetzl [EMAIL PROTECTED] wrote: if you are interested in investigating this, please let me know what kind of data you would like to see and/or what kind of tests would be appreciated. I reviewed the 374 code a bit further to see what might be causing

Re: Device does not have a release() function

2007-01-02 Thread Avuton Olrich
On 1/2/07, Vitaly Bordug [EMAIL PROTECTED] wrote: Avuton, Thanks for this report, Please excuse me if this has already been discussed. Anything else that's needed please let me know. kernel: Linux version 2.6.20-rc2 ([EMAIL PROTECTED]) (gcc version 4.1.1 (Gentoo 4.1.1-r3)) #6 SMP PREEMPT

Re: 2.6.20-rc2+: CFQ halving disk throughput.

2007-01-02 Thread Mark Lord
Jens Axboe wrote: But surely one of (not sure which) sync+async or async+sync may also be okay? Or would it? Async merge to sync request should be ok. But I wonder what happens with hdparm, since it seems to trigger one of these tests. Very puzzling. I'll dive in and take a look. The code

Re: 2.6.20-rc2+: CFQ halving disk throughput.

2007-01-02 Thread Mark Lord
Jens Axboe wrote: On Tue, Jan 02 2007, Jens Axboe wrote: On Tue, Jan 02 2007, Rene Herman wrote: Jens Axboe wrote: On Mon, Jan 01 2007, Andrew Morton wrote: The patch would appear to need this fix: --- a/block/cfq-iosched.c~a +++ a/block/cfq-iosched.c @@ -592,7 +592,7 @@ static int

Re: 2.6.20-rc2+: CFQ halving disk throughput.

2007-01-02 Thread Jens Axboe
On Tue, Jan 02 2007, Mark Lord wrote: Jens Axboe wrote: On Tue, Jan 02 2007, Jens Axboe wrote: On Tue, Jan 02 2007, Rene Herman wrote: Jens Axboe wrote: On Mon, Jan 01 2007, Andrew Morton wrote: The patch would appear to need this fix: --- a/block/cfq-iosched.c~a +++

Re: Open letter to Linux kernel developers (was Re: Binary Drivers)

2007-01-02 Thread David Weinehall
On Tue, Jan 02, 2007 at 08:22:21AM -0500, Robert P. J. Day wrote: On Tue, 2 Jan 2007, Theodore Tso wrote: I can very easily believe it. The US patent system and justice system in the US is completely and totally insane, and companies often feel they have to act accordingly. Remember

Re: Open letter to Linux kernel developers (was Re: Binary Drivers)

2007-01-02 Thread Jens Axboe
On Tue, Jan 02 2007, David Weinehall wrote: On Tue, Jan 02, 2007 at 08:22:21AM -0500, Robert P. J. Day wrote: On Tue, 2 Jan 2007, Theodore Tso wrote: I can very easily believe it. The US patent system and justice system in the US is completely and totally insane, and companies

Re: error handling in sysfs, fill_read_buffer()

2007-01-02 Thread Alan Stern
On Tue, 2 Jan 2007, Oliver Neukum wrote: Hi, if a driver returns an error in fill_read_buffer(), the buffer will be marked as filled. Subsequent reads will return eof. But there is no data because of an error, not because it has been read. Not marking the buffer filled is the obvious fix.

Re: Cut power to a USB port?

2007-01-02 Thread Andrew Barr
On Tue, 2007-01-02 at 00:32 -0800, Greg KH wrote: On Mon, Jan 01, 2007 at 03:56:25PM -0500, Andrew Barr wrote: I have a simple question perhaps someone can help me with here... I have one of those simple LED keyboard lamps that get their power from the USB port. Is there some way in

Re: 2.6.19 and up to 2.6.20-rc2 Ethernet problems x86_64

2007-01-02 Thread Sid Boyce
Jarek Poplawski wrote: On Sat, Dec 30, 2006 at 02:21:15AM +, Sid Boyce wrote: Jarek Poplawski wrote: On 28-12-2006 04:23, Sid Boyce wrote: I first saw the problem on the 64x2 box after upgrading to 2.6.19. The network appeared OK with ifconfig and route -n, but I had no network access.

Re: 2.6.19 and up to 2.6.20-rc2 Ethernet problems x86_64

2007-01-02 Thread Sid Boyce
Jarek Poplawski wrote: On Sat, Dec 30, 2006 at 02:21:15AM +, Sid Boyce wrote: Jarek Poplawski wrote: On 28-12-2006 04:23, Sid Boyce wrote: I first saw the problem on the 64x2 box after upgrading to 2.6.19. The network appeared OK with ifconfig and route -n, but I had no network access.

Re: error handling in sysfs, fill_read_buffer()

2007-01-02 Thread Oliver Neukum
Am Dienstag, 2. Januar 2007 16:26 schrieb Alan Stern: On Tue, 2 Jan 2007, Oliver Neukum wrote: Hi, if a driver returns an error in fill_read_buffer(), the buffer will be marked as filled. Subsequent reads will return eof. But there is no data because of an error, not because it has

  1   2   3   4   5   6   7   8   >