Re: [PATCH] Fix get_order() [try #2]

2007-03-06 Thread H. Peter Anvin
David Howells wrote: From: David Howells <[EMAIL PROTECTED]> Provide an ilog2_up() that rounds its result up (ilog2() rounds down). Fix get_order() to use ilog2_up() not ilog2() to get the correct rounding. Adjust the documentation surrounding ilog2() and co. to indicate what rounding they

[PATCH 0/5] UML - hotplug fixes and cleanup

2007-03-06 Thread Jeff Dike
These patches can wait till after 2.6.21. Three of them are tidying patches of various sorts. The other two fix network interface and block device hotplug bugs. Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a

[PATCH 2/5] UML - print coredump limits

2007-03-06 Thread Jeff Dike
Print out core dump limits at boot time. This is to allow core dumps to be collected if something goes very wrong and to tell if a core dump isn't going to happen because of a resource limit. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/os-Linux/start_up.c | 25

[PATCH 1/5] UML - Mark tt-mode code for future removal

2007-03-06 Thread Jeff Dike
Mark some tt-mode-only code as such. Also cleaned up some formatting. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/sys-i386/ptrace_user.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) Index: linux-2.6.18-mm/arch/um/sys-i386/ptrace_user.c

[PATCH 5/5] UML - network interface hotplug error handling

2007-03-06 Thread Jeff Dike
This fixes a number of problems associated with network interface hotplug. The userspace initialization function can fail in some cases, but the failure was never passed back to eth_configure, which proceeded with the configuration. This results in a zombie device that is present, but can't

Re: [PATCH 8/8] Convert PDA into the percpu section

2007-03-06 Thread Jeremy Fitzhardinge
Andi Kleen wrote: > Sigh -- i had hoped this had settled down because it was a > merging nightmare last time. Ok. > > >> +#define percpu_to_op(op,var,val)\ >> +do {\ >> +typedef typeof(var) T__;

Re: [PATCH 8/8] Convert PDA into the percpu section

2007-03-06 Thread Andi Kleen
Sigh -- i had hoped this had settled down because it was a merging nightmare last time. Ok. > +#define percpu_to_op(op,var,val) \ > + do {\ > + typedef typeof(var) T__;\ > +

Re: [linux-usb-devel] khubd and ent:sda1 sucking CPU with reiser4 + USB HD

2007-03-06 Thread Alan Stern
On Tue, 6 Mar 2007, Eric Buddington wrote: > On Tue, Mar 06, 2007 at 10:36:20AM -0500, Alan Stern wrote: > > On Tue, 6 Mar 2007, Oliver Neukum wrote: > > > > > > Am Dienstag, 6. M??rz 2007 05:13 schrieb Eric Buddington: > > > > reiser4[khubd(163)]: commit_current_atom > > > >

Re: OOPS with 2.6.20 and 2.6.21-rc2 (mos7720)

2007-03-06 Thread Dirk Schoebel
...btw... another usb serial adapter (single port ftdi) works well, no OOPSes so.. maybe the error is less to search within usb-serial itself but more the interaction or the driver itself... Dirk. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

[PATCH] Fix get_order() [try #2]

2007-03-06 Thread David Howells
From: David Howells <[EMAIL PROTECTED]> Provide an ilog2_up() that rounds its result up (ilog2() rounds down). Fix get_order() to use ilog2_up() not ilog2() to get the correct rounding. Adjust the documentation surrounding ilog2() and co. to indicate what rounding they perform. Fix

Re: [RFC] div64_64 support

2007-03-06 Thread Stephen Hemminger
Don't count the existing Newton-Raphson out. It turns out that to get enough precision for 32 bits, only 4 iterations are needed. By unrolling those, it gets much better timing. Slightly gross test program (with original cubic wraparound bug fixed). --- /* Test and measure perf of cube root

Re: [RFC] Heads up on sys_fallocate()

2007-03-06 Thread Eric Sandeen
Jan Kara wrote: > On Tue 06-03-07 06:36:09, Ulrich Drepper wrote: >> Christoph Hellwig wrote: >>> fallocate with the whence argument and flags is already quite complicated, >>> I'd rather have another call for placement decisions, that would >>> be called on an fd to do placement decissions for

Re: [patch 26/26] Xen-paravirt_ops: Add the Xen virtual network device driver.

2007-03-06 Thread Chris Wright
* Christoph Hellwig ([EMAIL PROTECTED]) wrote: > Actually the right way to do it is in userspace, as all clustering > solutions do. That's whay everyone told the Xen folks by the just > refuse to rip this junk out. I'm ripping it out. - To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH 8/8] Convert PDA into the percpu section

2007-03-06 Thread Jeremy Fitzhardinge
Rusty Russell wrote: > Currently x86 (similar to x84-64) has a special per-cpu structure > called "i386_pda" which can be easily and efficiently referenced via > the %fs register. An ELF section is more flexible than a structure, > allowing any piece of code to use this area. Indeed, such a

Re: [RFC] div64_64 support II

2007-03-06 Thread David Miller
From: [EMAIL PROTECTED] (Dagfinn Ilmari Mannsåker) Date: Tue, 06 Mar 2007 18:43:14 +0100 > Andi Kleen <[EMAIL PROTECTED]> writes: > > > Actually on rereading this: is there really any Linux port > > that emulates multiplies in software? I thought that was only > > done on really small

Re: [RFC] Arp announce (for Xen)

2007-03-06 Thread Chris Wright
* Stephen Hemminger ([EMAIL PROTECTED]) wrote: > + case NETDEV_CHANGEADDR: > + /* Send gratuitous ARP in case of address change or new device > */ > + if (IN_DEV_ARP_ANNOUNCE(in_dev)) Conceptually right on, but it looks like improper hijacking of arp_announce sysctl.

Re: [PATCH] x86_64, i386: Add command line length to boot protocol

2007-03-06 Thread Dave Jones
On Tue, Mar 06, 2007 at 07:14:30PM +0100, Bernhard Walle wrote: > +cmdline_size: .long COMMAND_LINE_SIZE-1 #length of the command line, Why a long? It's unlikely that someone is going to have a command line bigger than 0x. Dave -- http://www.codemonkey.org.uk - To

Re: [PATCH] Fix get_order()

2007-03-06 Thread David Howells
H. Peter Anvin <[EMAIL PROTECTED]> wrote: > if (size <= (1UL << page_shift)) > return 0; > else > return __ilog2_u32(size-1)+1-page_shift; I think you're right. That'll also defend against the result of __ilog2_u32() being less than page_shift-1. I think

Re: [PATCH] Fix building kernel under Solaris

2007-03-06 Thread Deepak Saxena
SIGRETRACT I have -rt merged into my tree so this won't apply cleanly to mainline. ~Deepak On Mar 06 2007, at 10:09, Deepak Saxena was caught saying: > > Fix varous build breakages that occur when building on a Solaris system > (SunOS 4.8 to be exact) > > - No asm/types.h > > - lpptest

Re: [PATCH 6/8] Allow per-cpu variables to be page-aligned

2007-03-06 Thread Jeremy Fitzhardinge
Rusty Russell wrote: > Xen wants page-aligned GDT (and PDA must not cross a page-boundary, > but that doesn't happen at the moment since it's so close to start of > page). Let's allow page-alignment in general for per-cpu data. > > Because larger alignments can use more room, we increase the max

[GIT PATCH] HID and USB HID updates for 2.6.21-rc2

2007-03-06 Thread Jiri Kosina
Linus, could you please pull from 'for-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jikos/hid.git for-linus to receive fixes for HID core layer and USB HID layer. This update is needed to make the IOWarrior device driver (that got merged during merge 2.6.21 merge

Re: [PATCH 3/4] coredump: ELF-FDPIC: enable to omit anonymous shared memory

2007-03-06 Thread David Howells
Hugh Dickins <[EMAIL PROTECTED]> wrote: > > > Under precisely what NOMMU conditions? > > > > CONFIG_MMU=n. > > Believe it or not, I had just about grasped that subtlety. I was > rather expecting some helpful response along the lines of "we share > all the vmas across a fork" or "whenever we

Re: [PATCH 5/8] Cleanup GDT access

2007-03-06 Thread Jeremy Fitzhardinge
Rusty Russell wrote: > Now we have an explicit per-cpu GDT variable, we don't need to keep > the descriptors around to use them to find the GDT. Also remove the > cpu_pda() accessor: it's just a per-cpu variable. > Looks good. Signed-off-by: Jeremy Fitzhardinge <[EMAIL PROTECTED]> J - To

Re: Packet timestamps (was: Re: Network performance degradation from 2.6.11.12 to 2.6.16.20)

2007-03-06 Thread Vladimir B. Savkin
On Tue, Mar 06, 2007 at 04:16:24PM +0100, Eric Dumazet wrote: > > It would be better to name the tunable "disable_timestamps", default 0 of > course I agree. If networking maintainers are interested, I surely can prepare a patch. But IMO some way to force TSC usage on x86_64 will be even

Re: [RFC] div64_64 support II

2007-03-06 Thread Dagfinn Ilmari Mannsåker
Andi Kleen <[EMAIL PROTECTED]> writes: > Actually on rereading this: is there really any Linux port > that emulates multiplies in software? I thought that was only > done on really small microcontrollers or smart cards; but anything > 32bit+ that runs Linux should have hardware multiply,

[PATCH] x86_64, i386: Add command line length to boot protocol

2007-03-06 Thread Bernhard Walle
Because the command line is increased to 2048 characters after 2.6.21, it's not possible for boot loaders and userspace tools to determine the length of the command line the kernel can understand. The benefit of knowing the length is that users can be warned if the command line size is too long

Re: [PATCH 3/8] Use per-cpu variables for GDT, PDA

2007-03-06 Thread Jeremy Fitzhardinge
Rusty Russell wrote: > Allocating PDA and GDT at boot is a pain. Using simple per-cpu > variables adds happiness (although we need the GDT page-aligned for > Xen, see later). > Not just Xen. Apparently it leads to general goodness. > Finally, we can simply call it "cpu_gdt" rather than

Re: [patch v2] epoll use a single inode ...

2007-03-06 Thread Eric Dumazet
On Tuesday 06 March 2007 18:28, Eric Dumazet wrote: > On Tuesday 06 March 2007 18:19, Linus Torvalds wrote: > > > > Using reciprocal divides permits to change each divide by two > > > multiplies, less expensive on current CPUS. > > > > Are you sure? > > I am going to test this, but at least on

[PATCH] Fix building kernel under Solaris

2007-03-06 Thread Deepak Saxena
Fix varous build breakages that occur when building on a Solaris system (SunOS 4.8 to be exact) - No asm/types.h - lpptest doesn't make sense on a Solaris host (this should really be cross-built..) - Need to define __s32 and __s16 - Need to define Elf32_Section and Elf64_Section - Solaris

Re: [patch v2] epoll use a single inode ...

2007-03-06 Thread Davide Libenzi
On Tue, 6 Mar 2007, H. Peter Anvin wrote: > Eric Dumazet wrote: > > > > For epoll, I suspect this is harmless : Programs dont allocate epolls fd > > every milli second, but at startup only. > > > > For pipes/sockets, using a 64 bits would be problematic, because sprintf() > > uses a divide for

Re: CONFIG_SYSFS_DEPRECATED and similar issues

2007-03-06 Thread Lee Revell
On 3/6/07, Bill Davidsen <[EMAIL PROTECTED]> wrote: The other issue is to avoid "trap door" changes, which occur when a kernel change requires new user tools, and the user tools will not run with older kernels. CONFIG_SYSFS_DEPRECATED is on by default. So this upgrading the kernel does not

[patch 3/8] per backing_dev dirty and writeback page accounting

2007-03-06 Thread Miklos Szeredi
From: Andrew Morton <[EMAIL PROTECTED]> [EMAIL PROTECTED]: bugfix] Miklos Szeredi <[EMAIL PROTECTED]>: Changes: - updated to apply after clear_page_dirty_for_io() race fix This is needed for - balance_dirty_pages() deadlock fix - fuse dirty page accounting I have no idea how serious the

[patch 6/8] balance dirty pages from loop device

2007-03-06 Thread Miklos Szeredi
From: Miklos Szeredi <[EMAIL PROTECTED]> The function do_lo_send_aops() should call balance_dirty_pages_ratelimited() after each page similarly to generic_file_buffered_write(). Without this, writing the loop device directly (not through a filesystem) is very slow, and also slows the whole

[patch 1/8] fix race in clear_page_dirty_for_io()

2007-03-06 Thread Miklos Szeredi
From: Miklos Szeredi <[EMAIL PROTECTED]> Fix race in clear_page_dirty_for_io() as suggested by Linus. Split the page dirtying into two phases: 1) done for each dirtying attempt 2) done only when the page's dirty flag changed from clean to dirty For 1 a_ops->set_page_dirty() is used

[patch 2/8] update ctime and mtime for mmaped write

2007-03-06 Thread Miklos Szeredi
From: Miklos Szeredi <[EMAIL PROTECTED]> Changes: v2: o set AS_CMTIME flag in clear_page_dirty_for_io() too o don't clear AS_CMTIME in file_update_time() o check the dirty bit in the page tables v1: o moved check from __fput() to remove_vma(), which is more logical o changed set_page_dirty()

[patch 7/8] add filesystem subtype support

2007-03-06 Thread Miklos Szeredi
From: Miklos Szeredi <[EMAIL PROTECTED]> There's a slight problem with filesystem type representation in fuse based filesystems. >From the kernel's view, there are just two filesystem types: fuse and fuseblk. From the user's view there are lots of different filesystem types. The user is not

[patch 5/8] fix deadlock in throttle_vm_writeout

2007-03-06 Thread Miklos Szeredi
From: Miklos Szeredi <[EMAIL PROTECTED]> This deadlock is similar to the one in balance_dirty_pages, but instead of waiting in balance_dirty_pages after submitting a write request, it happens during a memory allocation for filesystem B before submitting a write request. It is easy to reproduce

[patch 8/8] consolidate generic_writepages and mpage_writepages fix

2007-03-06 Thread Miklos Szeredi
From: Miklos Szeredi <[EMAIL PROTECTED]> Fix NULL pointer dereference in __mpage_writepage. This probably doesn't matter in practice, but this is the original behavior. Signed-off-by: Miklos Szeredi <[EMAIL PROTECTED]> --- Index: linux/fs/mpage.c

[patch 4/8] fix deadlock in balance_dirty_pages

2007-03-06 Thread Miklos Szeredi
From: Miklos Szeredi <[EMAIL PROTECTED]> This deadlock happens, when dirty pages from one filesystem are written back through another filesystem. It easiest to demonstrate with fuse although it could affect looback mounts as well (see following patches). Let's call the filesystems A(bove) and

[patch 0/8] VFS/VM patches

2007-03-06 Thread Miklos Szeredi
There's a new patch, which fixes the race in clear_page_dirty_for_io() and cleans up the page dirtying logic. And the mmap mtime/ctime update patch has seen much improvement. The others are resends and fixes. I'm not resending the fuse writable mmap patches until the fate of the deadlock fixes

Re: Xen & VMI?

2007-03-06 Thread Jeremy Fitzhardinge
Ingo Molnar wrote: > * Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > > >>> My suggestion would be for Linux to make only a /single/ external >>> ABI promise: VMI. (and we can extend it with higher-level paravirt >>> ops, etc.) >>> >> "VMI" is not a promise, it's just three letters.

Re: bugs in kernel 2.6.21 (both two release candidates) and kernel 2.6.20

2007-03-06 Thread Linus Torvalds
[ Whitespace in your email fixed so that it's easier to read again ;^] On Tue, 6 Mar 2007, Uwe Bugla wrote: > > But please do not compare me with maintainers, especially never in this > life with the suboptimal one from linuxtv.org being in question. > > a. I ain't no maintainer Sure. The

Re: [PATCH] remove availability for PAGE_SIZE and friends (i386)

2007-03-06 Thread David Brown
Pfft, did I seriously screw that up... (/me failed) On 3/6/07, David M. Lloyd <[EMAIL PROTECTED]> wrote: On Tue, 2007-03-06 at 08:31 -0800, David Brown wrote: > +#define __KERNEL__ That's a #define, not an #ifdef... - DML diff --git a/include/asm-i386/page.h b/include/asm-i386/page.h

Re: [PATCH] Fix get_order()

2007-03-06 Thread H. Peter Anvin
David Howells wrote: From: David Howells <[EMAIL PROTECTED]> Fix get_order() to use ilog2() properly. Signed-Off-By: David Howells <[EMAIL PROTECTED]> --- include/asm-generic/page.h | 14 +++--- include/linux/log2.h | 20 ++-- 2 files changed, 29

Re: [DOC] The documentation for HID Simple Driver Interface 0.5.0

2007-03-06 Thread Marcel Holtmann
Hi Jiri, > > For me the task of converting HID reports into input events shouldn't be > > actually the job of the HID core layer. My understanding is that the HID > > core should support multiple transport layers. This is currently > > achieved through the hid_device abstraction and used by

Re: [2.6.21 patch] unconditionally enable SYSFS_DEPRECATED

2007-03-06 Thread Dan Williams
On Mon, 2007-03-05 at 17:56 -0800, Greg KH wrote: > On Mon, Mar 05, 2007 at 07:30:21PM -0600, Matt Mackall wrote: > > On Mon, Mar 05, 2007 at 04:07:22PM -0800, Greg KH wrote: > > > On Tue, Mar 06, 2007 at 12:40:52AM +0100, Adrian Bunk wrote: > > > > On Mon, Mar 05, 2007 at 10:58:13AM -0800, Greg

Re: [2.6.22 patch] the scheduled removal of OBSOLETE_OSS options

2007-03-06 Thread Adrian Bunk
On Tue, Mar 06, 2007 at 12:46:22PM -0500, Bill Davidsen wrote: > Adrian Bunk wrote: > >This patch contains the scheduled removal of the OBSOLETE_OSS options > >for 2.6.22. > > > If these are drivers for which there are thought to be useful ALSA > drivers, would it be reasonable to leave a stub

Re: [ANNOUNCE] RSDL completely fair starvation free interactive cpu scheduler

2007-03-06 Thread Bill Davidsen
Gene Heskett wrote: On Monday 05 March 2007, Nicolas Mailhot wrote: This looks like -mm stuff if you want it in 2.6.22 This needs to get to 2.6.21, it really is that big an improvement. As Con pointed out, for some workloads and desired behavour this is not as good as the existing

RE: [patch 1/1] network: add the missing phy_device speed information to phy_mii_ioctl

2007-03-06 Thread Shan Lu
I probably have misunderstood the code. Thanks very much for pointing this out. I don't have special reason to stick to this function. I just feel it very strange to miss the speed parameter and it has no reason to do so. As for why not SPEED_10, another function in the same file only update the

Re: [PATCH] highres: do not run the TIMER_SOFTIRQ after switching to highres mode

2007-03-06 Thread Linus Torvalds
On Tue, 6 Mar 2007, Thomas Gleixner wrote: > > /me pleads guilty ! > > Replacement patch below. Well, I already applied the original one that came through Andrew, so I really just wanted to note the coding style in general, and your fixed patch no longer applied ;) Also, you do end up

Re: [2.6.22 patch] the scheduled removal of OBSOLETE_OSS options

2007-03-06 Thread Bill Davidsen
Adrian Bunk wrote: This patch contains the scheduled removal of the OBSOLETE_OSS options for 2.6.22. If these are drivers for which there are thought to be useful ALSA drivers, would it be reasonable to leave a stub for a help file naming the driver which claims to support the hardware?

Re: get_order() broken !

2007-03-06 Thread David Howells
Linus Torvalds <[EMAIL PROTECTED]> wrote: > Yeah, I think the recent get_order() changes to change it to use ilog2() > are just crap. I actually looked at it when it went in, but I assumed that > it had been tested. I don't think it has. It had, it's just that the testing totally failed to

[PATCH] Fix get_order()

2007-03-06 Thread David Howells
From: David Howells <[EMAIL PROTECTED]> Fix get_order() to use ilog2() properly. Signed-Off-By: David Howells <[EMAIL PROTECTED]> --- include/asm-generic/page.h | 14 +++--- include/linux/log2.h | 20 ++-- 2 files changed, 29 insertions(+), 5 deletions(-)

Re: bugs in kernel 2.6.21 (both two release candidates) and kernel 2.6.20

2007-03-06 Thread Uwe Bugla
Original-Nachricht Datum: Sun, 4 Mar 2007 13:30:13 -0800 (PST) Von: Linus Torvalds <[EMAIL PROTECTED]> An: Uwe Bugla <[EMAIL PROTECTED]> CC: [EMAIL PROTECTED], linux-kernel@vger.kernel.org Betreff: Re: bugs in kernel 2.6.21 (both two release candidates) and kernel 2.6.20 > >

CONFIG_SYSFS_DEPRECATED and similar issues

2007-03-06 Thread Bill Davidsen
Just a few comments on changes like this in general. Prompted by, but not otherwise related to the subject. When any new feature in the kernel requires significant changes in userspace, attention should be given to documenting the user items which must change. Now "attention" doesn't mean

Re: [patch 1/1] network: add the missing phy_device speed information to phy_mii_ioctl

2007-03-06 Thread Andy Fleming
On Mar 2, 2007, at 11:42, Shan Lu wrote: Changelog: Function `phy_mii_ioctl' returns physical device's information based on user requests. When requested to return the basic mode control register information (BMCR), the original implementation only returns the physical device's duplex

Re: Xen & VMI?

2007-03-06 Thread Anthony Liguori
Nakajima, Jun wrote: Anthony Liguori wrote: Ingo Molnar wrote: * Gerd Hoffmann <[EMAIL PROTECTED]> wrote: So in the end you would still have two different hypervisor ABI's, the VMI ROM just hides that. oh, but that way i have cleverly pushed the problem out of

Re: [patch v2] epoll use a single inode ...

2007-03-06 Thread H. Peter Anvin
Linus Torvalds wrote: On Tue, 6 Mar 2007, Eric Dumazet wrote: Something like : [PATCH] : Use reciprocal divides in sprintf() Try this on Core 2, and I suspect that you'll find that the hardware is actually *faster* than doing the shift/test, function call and the two multiplies. Using

Re: [patch v2] epoll use a single inode ...

2007-03-06 Thread Eric Dumazet
On Tuesday 06 March 2007 18:19, Linus Torvalds wrote: > On Tue, 6 Mar 2007, Eric Dumazet wrote: > > Something like : > > > > [PATCH] : Use reciprocal divides in sprintf() > > Try this on Core 2, and I suspect that you'll find that the hardware is > actually *faster* than doing the shift/test,

Re: bugs in kernel 2.6.21 (both two release candidates) and kernel 2.6.20

2007-03-06 Thread Uwe Bugla
Original-Nachricht Datum: Sat, 3 Mar 2007 19:25:29 +0100 Von: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> An: "Uwe Bugla" <[EMAIL PROTECTED]> CC: [EMAIL PROTECTED], [EMAIL PROTECTED], linux-kernel@vger.kernel.org, Alan <[EMAIL PROTECTED]> Betreff: Re: bugs in kernel 2.6.21

Re: [RFC] BadRAM still not ready for inclusion ? (was: Re: Free Linux Driver Development!)

2007-03-06 Thread Lee Revell
On 3/4/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: It seems, that BadRAM is not being maintained very actively and the original author doesn`t seem to have the time pushing it into mainline, but i know it's actively being used by more then just a handful of people. Unfortunately there is

[PATCH] highres: do not run the TIMER_SOFTIRQ after switching to highres mode

2007-03-06 Thread Thomas Gleixner
On Tue, 2007-03-06 at 08:44 -0800, Linus Torvalds wrote: > This is just a coding style thing, but I thought I should really point it > out, because these kinds of things quite often result in nasty bugs simply > because the source code is so hard to read properly: /me pleads guilty !

Re: [patch v2] epoll use a single inode ...

2007-03-06 Thread Linus Torvalds
On Tue, 6 Mar 2007, Eric Dumazet wrote: > > Something like : > > [PATCH] : Use reciprocal divides in sprintf() Try this on Core 2, and I suspect that you'll find that the hardware is actually *faster* than doing the shift/test, function call and the two multiplies. > Using reciprocal

RE: Xen & VMI?

2007-03-06 Thread Nakajima, Jun
Anthony Liguori wrote: > Ingo Molnar wrote: >> * Gerd Hoffmann <[EMAIL PROTECTED]> wrote: >> > So in the end you would still have two different hypervisor ABI's, > the VMI ROM just hides that. oh, but that way i have cleverly pushed the problem out of Linux and into the

Re: Xen & VMI?

2007-03-06 Thread Ingo Molnar
* Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > > My suggestion would be for Linux to make only a /single/ external > > ABI promise: VMI. (and we can extend it with higher-level paravirt > > ops, etc.) > > "VMI" is not a promise, it's just three letters. It doesn't even mean > the same

Re: [patch v2] epoll use a single inode ...

2007-03-06 Thread H. Peter Anvin
Linus Torvalds wrote: However, this could be optimized. I think right now sprintf() uses a generic divide-by-base, but a divide by 8 and 16 can of course be handled with a shift, and divide by 10 can be replaced with a multiplication by 0x1999ULL on most architectures. Nope. You

Re: get_order() broken !

2007-03-06 Thread Linus Torvalds
On Tue, 6 Mar 2007, Benjamin Herrenschmidt wrote: > > Ok, maybe I have lots of shit in my eyes but it looks like get_order > in asm-generic/page.h is broken. > > AFAIK, get_order() should round up (and we have code here or there > assuming such). > > However, it seems to assume that ilog2

Re: [RFC] BadRAM still not ready for inclusion ? (was: Re: Free Linux Driver Development!)

2007-03-06 Thread Bill Davidsen
telling [EMAIL PROTECTED] wrote: Hello ! There's some really nice feature-patch named BadRAM at http://rick.vanrein.org/linux/badram/index.html for years now, being announced around 2000 on this list, voted for inclusion in 2.3.99. BadRAM let's you tell the kernel to skip certain regions of

Re: SATA resume slowness, e1000 MSI warning

2007-03-06 Thread Kok, Auke
Linus Torvalds wrote: On Tue, 6 Mar 2007, Thomas Gleixner wrote: SATA has another nice feature. Somehow there is an interrupt pending on the SATA controller, which comes in somewhere in the middle of resume. If it happens before the SATA code resumed, the SATA code ignores the interrupt and

Re: [patch v2] epoll use a single inode ...

2007-03-06 Thread Eric Dumazet
On Tuesday 06 March 2007 17:28, H. Peter Anvin wrote: > Eric Dumazet wrote: > > For epoll, I suspect this is harmless : Programs dont allocate epolls fd > > every milli second, but at startup only. > > > > For pipes/sockets, using a 64 bits would be problematic, because > > sprintf() uses a divide

Re: Xen & VMI?

2007-03-06 Thread Ingo Molnar
* Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > The whole point of pv_ops is to allow the hypervisors interfaces to > evolve at their own pace without having to constrain the core kernel's > development unfortunately that's a self-serving oxymoron, contradicted by real life ;) Pretty much

Re: [patch v2] epoll use a single inode ...

2007-03-06 Thread Linus Torvalds
On Tue, 6 Mar 2007, H. Peter Anvin wrote: > > That's true for *any* sprintf(), though. sprintf() converts all its arguments > to 64 bits. Well, it very much uses "do_div()", so that it can do a 64 / 32 -> (div64,mod32) divide, which is often faster than a full 64:64 divide. >

Re: [5/6] 2.6.21-rc2: known regressions

2007-03-06 Thread Ingo Molnar
* Linus Torvalds <[EMAIL PROTECTED]> wrote: > This is just a coding style thing, but I thought I should really point > it out, because these kinds of things quite often result in nasty bugs > simply because the source code is so hard to read properly: yeah, agreed. We'll fix this.

Re: [PATCH] remove availability for PAGE_SIZE and friends (i386)

2007-03-06 Thread David M. Lloyd
On Tue, 2007-03-06 at 08:31 -0800, David Brown wrote: > +#define __KERNEL__ That's a #define, not an #ifdef... - DML - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at

get_order() broken !

2007-03-06 Thread Benjamin Herrenschmidt
Ok, maybe I have lots of shit in my eyes but it looks like get_order in asm-generic/page.h is broken. AFAIK, get_order() should round up (and we have code here or there assuming such). However, it seems to assume that ilog2 rounds up, which it doesn't. It rounds down. At least the generic

[PATCH 2/3] e1000: FIX: firmware handover bits

2007-03-06 Thread Auke Kok
From: Bruce Allan <[EMAIL PROTECTED]> Upon code inspection it was spotted that the firmware handover bit get/set mismatched, which may have resulted in management issues on PCI-E adapters. Setting them correctly may fix some management issues such as arp routing etc. Signed-off-by: Auke Kok

Re: SATA resume slowness, e1000 MSI warning

2007-03-06 Thread Linus Torvalds
On Tue, 6 Mar 2007, Thomas Gleixner wrote: > > SATA has another nice feature. Somehow there is an interrupt pending on > the SATA controller, which comes in somewhere in the middle of resume. > If it happens before the SATA code resumed, the SATA code ignores the > interrupt and the interrupt

[PATCH 1/3] e1000: FIX: be ready for incoming irq at pci_request_irq

2007-03-06 Thread Auke Kok
From: Auke Kok <[EMAIL PROTECTED]> DEBUG_SHIRQ code exposed that e1000 was not ready for incoming interrupts after having called pci_request_irq. This obviously requires us to finish our software setup which assigns the irq handler before we request the irq. Signed-off-by: Auke Kok <[EMAIL

[PATCH 3/3] e1000: FIX: Stop raw interrupts disabled nag from RT

2007-03-06 Thread Auke Kok
From: Mark Huth <[EMAIL PROTECTED]> Current e1000_xmit_frame spews raw interrupt disabled nag messages when used with RT kernel patches. This patch uses spin_trylock_irqsave, which allows RT patches to properly manage the irq semantics. Signed-off-by: Mark Huth <[EMAIL PROTECTED]>

Re: [RFC] Heads up on sys_fallocate()

2007-03-06 Thread Eric Sandeen
Ulrich Drepper wrote: > Christoph Hellwig wrote: >> fallocate with the whence argument and flags is already quite complicated, >> I'd rather have another call for placement decisions, that would >> be called on an fd to do placement decissions for any further allocations >> (prealloc, write, etc)

Re: 2.6.20-rc4-mm1: PCI=n: drivers/net/3c59x.c compile error

2007-03-06 Thread Randy Dunlap
On Tue, 06 Mar 2007 19:15:12 +0300 Sergei Shtylyov wrote: > Hello. > > Greg KH wrote: > > >>>3x59x-fix-pci-resource-management.patch causes the following compile > >>>error with CONFIG_PCI=n: > > >>><-- snip --> > > >>>... > >>> CC drivers/net/3c59x.o >

Re: [5/6] 2.6.21-rc2: known regressions

2007-03-06 Thread Linus Torvalds
This is just a coding style thing, but I thought I should really point it out, because these kinds of things quite often result in nasty bugs simply because the source code is so hard to read properly: On Tue, 6 Mar 2007, Ingo Molnar wrote: > > -static void hrtimer_switch_to_hres(void) >

Re: Raid 10 Problems?

2007-03-06 Thread Bill Davidsen
Marc Perkel wrote: --- Jan Engelhardt <[EMAIL PROTECTED]> wrote: On Mar 4 2007 19:17, Marc Perkel wrote: Thanks - because of your suggestion I had found the instructions. But you have some interesting options set. -N nicearray -b internal -e 1.0 Are these important? -N? What's in a

[PATCH 5/6] UDF cleanup and fixes

2007-03-06 Thread Jan Kara
Make UDF work correctly for files larger than 1GB. As no extent can be longer than (1<<30)-blocksize bytes, we have to create several extents if a big hole is being created. As a side-effect, we now don't discard preallocated blocks when creating a hole. Signed-off-by: Jan Kara <[EMAIL

[PATCH 6/6] UDF cleanup and fixes

2007-03-06 Thread Jan Kara
We have to decrease link-count of the parent directory when removing a subdirectory. Signed-off-by: Jan Kara <[EMAIL PROTECTED]> diff -rupX /home/jack/.kerndiffexclude linux-2.6.20-5-large_file_fix/fs/udf/namei.c linux-2.6.20-6-rmdir_fix/fs/udf/namei.c ---

Re: Linux 2.6.19.2: maybe a bug inside the r8169 network driver (was Re: Linux 2.6.19.2: Freeze with CIFS mount)

2007-03-06 Thread Eric Lacombe
Hello, I've just triggered the bug again but _now_ without the nvidia proprietary module. Unfortunately, I hadn't enable the DEBUG options yet. Nevertheless, It seems that the bug was triggered when the NAS was going to awake and that 2 user applications wanted to access it during his

[PATCH 4/6] UDF cleanup and fixes

2007-03-06 Thread Jan Kara
Add a few assertions into udf_discard_prealloc() to check that the file is sane (mostly helps debugging further patches ;). Signed-off-by: Jan Kara <[EMAIL PROTECTED]> diff -rupX /home/jack/.kerndiffexclude linux-2.6.20-3-udf_buffer_handling/fs/udf/truncate.c

Re: Xen & VMI?

2007-03-06 Thread Jeremy Fitzhardinge
Ingo Molnar wrote: > i think you are missing my point. > > paravirt_ops is a Linux-internal abstraction that tries to make our life > easier but it has no relevance whatsoever to an external hypervisor - be > that Xen, VMWare/ESX or Windows/Longhorn. > Of course it has relevance. Linux is

[PATCH 1/6] UDF cleanup and fixes

2007-03-06 Thread Jan Kara
Use sector_t and loff_t for file offsets in UDF filesystem. Otherwise an overflow may occur for long files. Also make inode_bmap() return offset in the extent in number of blocks instead of number of bytes - for most callers this is more convenient. Signed-off-by: Jan Kara <[EMAIL PROTECTED]>

[PATCH 3/6] UDF cleanup and fixes

2007-03-06 Thread Jan Kara
Make UDF use get_bh() instead of directly accessing b_count and use brelse() instead of udf_release_data() which does just brelse()... Signed-off-by: Jan Kara <[EMAIL PROTECTED]> diff -rupX /home/jack/.kerndiffexclude linux-2.6.20-2-udf_extent_position_t/fs/udf/balloc.c

[PATCH 0/6] UDF cleanup and fixes

2007-03-06 Thread Jan Kara
Hello, the patches attached to six following emails implement some cleanup and fixes in the UDF code. The main two fixes are: 1) UDF now works correctly for files larger than 1GB. 2) Deleting a directory updates number of links to the parent directory correctly. See headers of

Re: [PATCH] ocfs2: fix module_init error handling

2007-03-06 Thread Akinobu Mita
2007/3/6, Joel Becker <[EMAIL PROTECTED]>: On Sun, Mar 04, 2007 at 10:34:43PM +0900, Akinobu Mita wrote: > From: Akinobu Mita <[EMAIL PROTECTED]> > Subject: [PATCH] ocfs2: fix module_init error handling > > Fix error handling in module_init and make module_init() return > correct error code.

Re: I2O block driver broken in kernel 2.6.19?

2007-03-06 Thread Enrico Scholz
Chuck Ebbert <[EMAIL PROTECTED]> writes: > Everything looks like it loads OK, but no block IO can be > done, not even reading the partition table: Same here with | 03:08.0 RAID bus controller: Adaptec (formerly DPT) SmartRAID V Controller (rev 01) | Subsystem: Adaptec (formerly DPT)

return negative number for unsigned long function in kernel

2007-03-06 Thread Chen, Dongliang
There are lots of functions in the Linux kernel that are declared as unsigned long, but the return value is negative integer while error occurred. An example of these functions is do_mmap_pgoff in mm/mmap.c, which is defined as: unsigned long do_mmap_pgoff() In this function, it returns

[PATCH] remove availability for PAGE_SIZE and friends (x86-64)

2007-03-06 Thread David Brown
Same patch as the i386 one only for the x86_64 architecture Thanks, - David Brown diff --git a/include/asm-x86_64/page.h b/include/asm-x86_64/page.h index 10f3461..c5f0097 100644 --- a/include/asm-x86_64/page.h +++ b/include/asm-x86_64/page.h @@ -1,6 +1,7 @@ #ifndef _X86_64_PAGE_H #define

[PATCH] remove availability for PAGE_SIZE and friends (ppc)

2007-03-06 Thread David Brown
Same patch as the i386 one only for ppc. Thanks, - David Brown diff --git a/include/asm-ppc/page.h b/include/asm-ppc/page.h index fe95c82..79d54af 100644 --- a/include/asm-ppc/page.h +++ b/include/asm-ppc/page.h @@ -3,6 +3,8 @@ #include +#ifdef __KERNEL__ + /* PAGE_SHIFT determines the page

Re: 2.6.20-rc4-mm1: PCI=n: drivers/net/3c59x.c compile error

2007-03-06 Thread Sergei Shtylyov
Hello. Greg KH wrote: 3x59x-fix-pci-resource-management.patch causes the following compile error with CONFIG_PCI=n: <-- snip --> ... CC drivers/net/3c59x.o /home/bunk/linux/kernel-2.6/linux-2.6.20-rc4-mm1/drivers/net/3c59x.c: In function 'vortex_init_one':

[PATCH -mm] serial: suppress RTS assertion with disabled CRTSCTS

2007-03-06 Thread Oleksiy Kebkal
This patch leaves RTS alone when CRTSCTS is not set. Current behaviour doesn't give any possibility to 1. preconfigure port setting, because open operation implies RTS assertion and initial serial port setting may be wrong. 2. realize peculiar serial flow control required by some hardware

[PATCH] remove availability for PAGE_SIZE and friends (i386)

2007-03-06 Thread David Brown
After a bit of discussion I found out that PAGE_SIZE really shouldn't be available for use at all by userspace. So here's a patch to move the __KERNEL__ define to include PAGE_SIZE and friends for i386. Thanks, - David Brown diff --git a/include/asm-i386/page.h b/include/asm-i386/page.h index

INIT IPI help

2007-03-06 Thread Jonathan M. McCune
Hello, I have Linux kernel 2.6.20-rc5 running on an AMD64 CPU, although I'm running an i386 (not amd64) kernel. I need to send an INIT inter-processor-interrupt from the BSP to all APs (there is one AP in my case since my system has a dual-core CPU). After using CPU-hotplug to disable CPU1, I

<    1   2   3   4   5   6   7   8   9   10   >