Re: [patch 2/13] signal/timer/event fds v6 - signalfd core ...

2007-03-19 Thread Davide Libenzi
On Tue, 20 Mar 2007, Oleg Nesterov wrote: > On 03/20, Oleg Nesterov wrote: > > > > On 03/19, Davide Libenzi wrote: > > > > > > I'd need a get_task_struct in any case in order to safely call > > > unlock_task_sighand(). At that point I'd prefer to just pass through the > > > struct pid*. I'll be

[QUICKLIST 1/5] Quicklists for page table pages V3

2007-03-19 Thread Christoph Lameter
Quicklists for page table pages V3 V2->V3 - Fix Kconfig issues by setting CONFIG_QUICKLIST explicitly and default to one quicklist if NR_QUICK is not set. - Fix i386 support. (Cannot mix PMD and PTE allocs.) - Discussion of V2. http://marc.info/?l=linux-kernel=117391339914767=2 V1->V2 - Add

Re: [PATCH v3] Race between cat /proc/kallsyms and rmmod

2007-03-19 Thread Rusty Russell
On Mon, 2007-03-19 at 17:33 +0300, Alexey Dobriyan wrote: > Iterating code of /proc/kallsyms calls module_get_kallsym() which grabs > and drops module_mutex internally and returns "struct module *", > module is removed, aforementioned "struct module *" is used in non-trivial > way. Hi Alexey,

Re: [PATCH] slab: deal with NULL pointers passed to kmem_cache_free

2007-03-19 Thread Andreas Steinmetz
Pekka J Enberg wrote: > From: Pekka Enberg <[EMAIL PROTECTED]> > > This changes kmem_cache_free() to deal with NULL objects passed to it. The > current behavior is inconsistent with kfree() so there are callers > passing NULL to kmem_cache_free(). > > Andreas, can you please confirm this fixes

Re: [patch 2/13] signal/timer/event fds v6 - signalfd core ...

2007-03-19 Thread Oleg Nesterov
On 03/20, Oleg Nesterov wrote: > > On 03/19, Davide Libenzi wrote: > > > > I'd need a get_task_struct in any case in order to safely call > > unlock_task_sighand(). At that point I'd prefer to just pass through the > > struct pid*. I'll be posting the new version for review as soon as I > >

2.6.20.3 NFS: BUG at fs/nfs/pagelist.c:339

2007-03-19 Thread Andreas Steinmetz
Got this from a nfs booted 2.6.20.3 x86 system (complete diskless boot): BUG: at fs/nfs/pagelist.c:339 nfs_scan_dirty() [] nfs_scan_dirty+0x17e/0x18a [] generic_writepages+0x224/0x2b6 [] nfs_wait_on_requests_locked+0x80/0x8e [] nfs_sync_mapping_wait+0x9d/0x14b [] __link_path_walk+0x854/0x943

Re: 2.6.20.3: kernel BUG at mm/slab.c:597 try#2

2007-03-19 Thread Gene Heskett
On Monday 19 March 2007, James Bottomley wrote: >On Mon, 2007-03-19 at 17:47 -0400, Gene Heskett wrote: >> James, could this also be the cause of a tar based backup going crazy >> and thinking all data is new under any 2.6.21-rc* kernel I've tested >> so far with amanda, which in my case uses tar?

Re: mm snapshot broken-out-2007-03-18-02-44.tar.gz uploaded

2007-03-19 Thread Andrew Morton
On Sun, 18 Mar 2007 19:35:48 +0100 Michal Piotrowski <[EMAIL PROTECTED]> wrote: > WARNING: could not find versions for .tmp_versions/built-in.mod > WARNING: could not find versions for .tmp_versions/built-in.mod > WARNING: could not find versions for .tmp_versions/built-in.mod > WARNING: could

Re: 2.6.20.3: kernel BUG at mm/slab.c:597 try#2

2007-03-19 Thread Andreas Steinmetz
Mike Christie wrote: > James Bottomley wrote: >> On Mon, 2007-03-19 at 12:49 -0500, Mike Christie wrote: I can't even say if the tapes are written correctly as I can't read them (one does not reboot production machines back to 2.4.x just to try to read a backup tape - I don't have

Re: 2.6.20.3: kernel BUG at mm/slab.c:597 try#2

2007-03-19 Thread Andreas Steinmetz
Mike Christie wrote: > Mike Christie wrote: >> James Bottomley wrote: >>> On Mon, 2007-03-19 at 12:49 -0500, Mike Christie wrote: > I can't even say if the tapes are written correctly as I can't read them > (one does not reboot production machines back to 2.4.x just to try to > read a

Re: [PATCH RESEND 2/2] Fix some kallsyms_lookup() vs rmmod races

2007-03-19 Thread Rusty Russell
On Mon, 2007-03-19 at 13:21 +0300, Alexey Dobriyan wrote: > I very much agree with proto-patch which _copies_ all relevant > information into caller-supplied structure, keeping module_mutex private. > Time to split it sanely. Indeed. The current interface needs to be ripped apart and put

Re: 2.6.21-rc3-mm2

2007-03-19 Thread Kay Sievers
On Mon, 2007-03-19 at 12:55 -0700, Andrew Morton wrote: > On Mon, 19 Mar 2007 12:17:24 -0700 > Randy Dunlap <[EMAIL PROTECTED]> wrote: > > > On Wed, 7 Mar 2007 20:19:15 -0800 Andrew Morton wrote: > > > > > > > >

Re: dst_ifdown breaks infiniband?

2007-03-19 Thread Alexey Kuznetsov
Hello! > This might work. Could you post a patch to better show what you mean to do? Here it is. ->neigh_destructor() is killed (not used), replaced with ->neigh_cleanup(), which is called when neighbor entry goes to dead state. At this point everything is still valid: neigh->dev, neigh->parms

Re: [PATCH RESEND 1/1] crypto API: RSA algorithm patch (kernel version 2.6.20.1)

2007-03-19 Thread Matt Mackall
On Mon, Mar 19, 2007 at 06:22:15PM +0200, Tasos Parisinos wrote: > +static inline _i32 rsa_max(_i32 x, _i32 y) > +{ > +return (x > y)? x: y; > +} We've got a max() already. Use tabs. > + > +/* > + * Module loading callback function > + * > + * Returns 0 on success or a negative value

RE: [PATCH] scsi: megaraid_sas - throttle io if cmds are in riskof being timed-out

2007-03-19 Thread Patro, Sumant
Thank you James. I will submit new patch that will throttle (if required) from eh_timed_out call back. Regards, Sumant -Original Message- From: James Bottomley [mailto:[EMAIL PROTECTED] Sent: Friday, March 16, 2007 3:23 PM To: Patro, Sumant Cc: [EMAIL PROTECTED];

Re: [patch 03/31] Fix user copy length in ipv6_sockglue.c

2007-03-19 Thread David Miller
From: Chris Wright <[EMAIL PROTECTED]> Date: Mon, 19 Mar 2007 15:01:25 -0700 > * Greg KH ([EMAIL PROTECTED]) wrote: > > From: Chris Wright <[EMAIL PROTECTED]> > > > > [IPV6] fix ipv6_getsockopt_sticky copy_to_user leak > > > > User supplied len < 0 can cause leak of kernel memory. > > Use

Re: [patch 2/13] signal/timer/event fds v6 - signalfd core ...

2007-03-19 Thread Oleg Nesterov
On 03/19, Davide Libenzi wrote: > > On Mon, 19 Mar 2007, Oleg Nesterov wrote: > > > On 03/19, Davide Libenzi wrote: > > > > > > On Mon, 19 Mar 2007, Eric W. Biederman wrote: > > > > > > > > +struct signalfd_ctx { > > > > > + struct list_head lnk; > > > > > + wait_queue_head_t wqh; > > >

Re: [PATCH RESEND] NET: Add packet sock option to return orig_dev to userspace when bonded

2007-03-19 Thread David Miller
I got it the first time, it's just very low priority and very deep in my backlog and I'm also about to be away for 3 days. I have it so you don't need to keep resending it. Thanks. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL

Re: [PATCH] ptrace needs PROC_FS

2007-03-19 Thread Roland McGrath
Thanks, that Kconfig change seems like the simplest solution for this. Thanks, Roland - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at

Re: [PATCH 00/22 take 3] UBI: Unsorted Block Images

2007-03-19 Thread Matt Mackall
On Mon, Mar 19, 2007 at 10:05:29PM +0100, Thomas Gleixner wrote: > On Mon, 2007-03-19 at 14:54 -0500, Matt Mackall wrote: > > > (UBI also has static volumes which LVM doesn't but that is an aside.) > > > > If a static volume is simply a non-dynamic volume, then device mapper > > can do that too.

Re: [patch 2/13] signal/timer/event fds v6 - signalfd core ...

2007-03-19 Thread Davide Libenzi
On Mon, 19 Mar 2007, Oleg Nesterov wrote: > On 03/19, Davide Libenzi wrote: > > > > On Mon, 19 Mar 2007, Eric W. Biederman wrote: > > > > > > +struct signalfd_ctx { > > > > + struct list_head lnk; > > > > + wait_queue_head_t wqh; > > > > + sigset_t sigmask; > > > > +

[PATCH] ptrace needs PROC_FS

2007-03-19 Thread Randy Dunlap
From: Randy Dunlap <[EMAIL PROTECTED]> CONFIG_PTRACE needs PROC_FS; with CONFIG_PROC_FS=n (x86_64): LD .tmp_vmlinux1 kernel/built-in.o: In function `ptrace_start': ptrace.c:(.text+0x300f9): undefined reference to `ptrace_may_attach' make: *** [.tmp_vmlinux1] Error 1 Signed-off-by: Randy

Re: [PATCH][1/5][resend] floppy.c: Initial (partial) CodingStyle cleanup

2007-03-19 Thread Jesper Juhl
On 19/03/07, Adrian Bunk <[EMAIL PROTECTED]> wrote: On Mon, Mar 19, 2007 at 07:18:38PM +0100, Jesper Juhl wrote: >... > The second reason is that indenting two tabs seems to make the most sense for > a few reasons; > a) not indenting at all is ugly, plain and simple. > void

Re: [PATCH] slab: deal with NULL pointers passed to kmem_cache_free

2007-03-19 Thread Jörn Engel
On Mon, 19 March 2007 14:10:38 -0700, Andrew Morton wrote: > > Would prefer to do: > > static inline void kmem_cache_free_if_not_null(struct kmem_cache *cachep, > void *objp) > { > if (objp) > kmem_cache_free(cachep, objp); > } >

Re: [linux-pm] [2/6] 2.6.21-rc2: known regressions

2007-03-19 Thread Jim Gettys
On Mon, 2007-03-19 at 16:33 -0400, Bill Davidsen wrote: > > What you say sounds good, assuming that the cost of a sleep is less than > the cost of the busy wait. But this may be hardware, the waits may be > very small and frequent, and if it's hitting a small hardware window > like retrace,

Re: [patch 03/31] Fix user copy length in ipv6_sockglue.c

2007-03-19 Thread Chris Wright
* Greg KH ([EMAIL PROTECTED]) wrote: > From: Chris Wright <[EMAIL PROTECTED]> > > [IPV6] fix ipv6_getsockopt_sticky copy_to_user leak > > User supplied len < 0 can cause leak of kernel memory. > Use unsigned compare instead. You can drop this one. It's dependent on a patch that is not in

Re: 2.6.20.3: kernel BUG at mm/slab.c:597 try#2

2007-03-19 Thread James Bottomley
On Mon, 2007-03-19 at 17:47 -0400, Gene Heskett wrote: > James, could this also be the cause of a tar based backup going crazy and > thinking all data is new under any 2.6.21-rc* kernel I've tested so far > with amanda, which in my case uses tar? I've tried the fedora patched > tar-1.15-1, and

Re: [PATCH] slab: deal with NULL pointers passed to kmem_cache_free

2007-03-19 Thread Matt Mackall
On Mon, Mar 19, 2007 at 02:41:00PM -0700, Andrew Morton wrote: > On Mon, 19 Mar 2007 23:25:36 +0200 (EET) > "Pekka Enberg" <[EMAIL PROTECTED]> wrote: > > > > > On 3/19/2007, "Andrew Morton" <[EMAIL PROTECTED]> wrote: > > > Would prefer to do: > > > > > > static inline void

Re: [PATCH 2/2] Replace pid_t in autofs with struct pid reference

2007-03-19 Thread Eric W. Biederman
"Serge E. Hallyn" <[EMAIL PROTECTED]> writes: > True, current->pid can probably always be legitimately taken as the pid > number in the current task's cloning namespace. But task->pid is > wrong. Agreed. > So if as you say it's worth caching (not saying I doubt you, just that I > haven't

Re: [PATCH] slab: deal with NULL pointers passed to kmem_cache_free

2007-03-19 Thread Matt Mackall
On Mon, Mar 19, 2007 at 02:16:01PM -0700, Christoph Lameter wrote: > On Mon, 19 Mar 2007, Matt Mackall wrote: > > > I think this sort of thing should work: > > > > a = kmalloc(...) > > b = kmem_cache_alloc(..) > > c = allocate_some_id(...) > > if (!a || !b || !c) { > >free_some_id(c) > >

Re: [patch 29/31] Input: i8042 - fix AUX IRQ delivery check

2007-03-19 Thread Chuck Ebbert
Dmitry Torokhov wrote: > On 3/19/07, Greg KH <[EMAIL PROTECTED]> wrote: >> -stable review patch. If anyone has any objections, please let us know. >> >> -- >> >> From: Dmitry Torokhov <[EMAIL PROTECTED]> >> >> Input: i8042 - fix AUX IRQ delivery check >> >> On boxes that do not

Re: Suspend to RAM doesn't work anymore in 2.6.21

2007-03-19 Thread Rafael J. Wysocki
Hi, On Monday, 19 March 2007 13:50, Tobias Doerffel wrote: > Hi, > > Suspend to RAM used to work fine on my computer (Intel Core Duo, 1 GB RAM, > Intel 82801G (ICH7-chipset) mainboard, NVIDIA-gfx-card, tg3-ethernet) up to > 2.6.20.3. But no matter which rc of 2.6.21 I use, suspend to RAM

[patch 08/31] adjust legacy IDE resource setting (v2)

2007-03-19 Thread Greg KH
-stable review patch. If anyone has any objections, please let us know. -- From: Jan Beulich <[EMAIL PROTECTED]> adjust legacy IDE resource setting (v2) The change to force legacy mode IDE channels' resources to fixed non-zero values confuses (at least some versions of) X,

[PATCH] x86_64 : Suppress __jiffies

2007-03-19 Thread Eric Dumazet
Hi Andi I was considering re-submiting patch to group together xtime_lock/xtime/jiffies in the same cache line. Before doing so, I believe the following cleanup patch could prepare the x86_64 port to be similar with other arches. Thank you [PATCH] x86_64 : Suppress __jiffies x86_64 arch

[patch 11/31] initialise pi_lock if CONFIG_RT_MUTEXES=N

2007-03-19 Thread Greg KH
-stable review patch. If anyone has any objections, please let us know. -- From: Zilvinas Valinskas <[EMAIL PROTECTED]> Fixes a bogus lockdep warning which causes lockdep to disable itself. Acked-by: Ingo Molnar <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL

Re: [patch 29/31] Input: i8042 - fix AUX IRQ delivery check

2007-03-19 Thread Dmitry Torokhov
On 3/19/07, Greg KH <[EMAIL PROTECTED]> wrote: -stable review patch. If anyone has any objections, please let us know. -- From: Dmitry Torokhov <[EMAIL PROTECTED]> Input: i8042 - fix AUX IRQ delivery check On boxes that do not implement AUX LOOP command we can not verify AUX

Re: BUG lapic: Can't boot on battery (2.6.21-rc{1,2,3,4})

2007-03-19 Thread Stefan Prechtel
2007/3/19, Thomas Gleixner <[EMAIL PROTECTED]>: On Mon, 2007-03-19 at 21:35 +0100, Stefan Prechtel wrote: >CPU0 CPU1 > 0: 28289 0 local-APIC-edge-fasteio timer > ... > LOC: 28237 28236 > > after a read: (I hope that is this what you want :-) >

[patch 18/31] Fix extraneous IPSEC larval SA creation

2007-03-19 Thread Greg KH
-stable review patch. If anyone has any objections, please let us know. -- From: Joy Latten <[EMAIL PROTECTED]> [XFRM]: Fix missing protocol comparison of larval SAs. I noticed that in xfrm_state_add we look for the larval SA in a few places without checking for protocol

[patch 22/31] Fix sparc64 hugepage bugs

2007-03-19 Thread Greg KH
-stable review patch. If anyone has any objections, please let us know. -- From: David Miller <[EMAIL PROTECTED]> [SPARC64]: Add missing HPAGE_MASK masks on address parameters. These pte loops all assume the passed in address is HPAGE aligned, make sure that is actually true.

[PATCH 2.6.22 3/3] Add LED trigger to libata core

2007-03-19 Thread Tony Vroon
The first user of ata_ac_issue_prot_with_ledtrigger, the ServerWorks Frodo/ Apple K2 driver. Used by the IDE LED trigger on G5 towers. Respin of an earlier patch, based on comments by Tejun Heo & Alan Cox. Signed-off-by: Tony Vroon <[EMAIL PROTECTED]> --- linux-2.6/drivers/ata/sata_svw.c.orig

[patch 07/31] IA64: fix NULL pointer in ia64/irq_chip-mask/unmask function

2007-03-19 Thread Greg KH
-stable review patch. If anyone has any objections, please let us know. -- From: KAMEZAWA Hiroyuki <[EMAIL PROTECTED]> [IA64] fix NULL pointer in ia64/irq_chip-mask/unmask function This patch fixes boot failure because irq_desc->mask() is NULL. - Added mask/unmask functions

[patch 14/31] hrtimer: prevent overrun DoS in hrtimer_forward()

2007-03-19 Thread Greg KH
-stable review patch. If anyone has any objections, please let us know. -- From: Thomas Gleixner <[EMAIL PROTECTED]> hrtimer_forward() does not check for the possible overflow of timer->expires. This can happen on 64 bit machines with large interval values and results

[patch 13/31] nfs: nfs_getattr() cant call nfs_sync_mapping_range() for non-regular files

2007-03-19 Thread Greg KH
-stable review patch. If anyone has any objections, please let us know. -- From: Trond Myklebust <[EMAIL PROTECTED]> Looks like we need a check in nfs_getattr() for a regular file. It makes no sense to call nfs_sync_mapping_range() on anything else. I think that should fix

[PATCH 2.6.22 2/3] Add LED trigger to libata core

2007-03-19 Thread Tony Vroon
This hooks up ata_ac_issue_prot_with_ledtrigger. Respin of an earlier patch, based on comments by Tejun Heo & Alan Cox. Signed-off-by: Tony Vroon <[EMAIL PROTECTED]> --- linux-2.6/include/linux/libata.h.orig 2007-03-19 21:15:04.0 + +++ linux-2.6/include/linux/libata.h

Re: [PATCH 00/22 take 3] UBI: Unsorted Block Images

2007-03-19 Thread Matt Mackall
On Mon, Mar 19, 2007 at 11:06:33PM +0200, Artem Bityutskiy wrote: > On Mon, 2007-03-19 at 14:54 -0500, Matt Mackall wrote: > > The issue is 14000 lines of patch to make a parallel subsystem. > > Parallel system exists since very long. One is > flash->SW_or_HW_FTL->all_blkdev_stuff. The other is

[RFC][PATCH 7/6] assorted fixes

2007-03-19 Thread Peter Zijlstra
Just taking out the MSB isn't enough to counter the clipping on 0 done by the stats counter accessors. Create some accessors that don't do that. Also, increase the period to about the side of memory (TODO, determine some upper bound here). This should give much more stable results. (Best would

Re: 2.6.20.3: kernel BUG at mm/slab.c:597 try#2

2007-03-19 Thread Gene Heskett
On Monday 19 March 2007, James Bottomley wrote: >On Mon, 2007-03-19 at 12:49 -0500, Mike Christie wrote: >> > I can't even say if the tapes are written correctly as I can't read >> > them (one does not reboot production machines back to 2.4.x just to >> > try to read a backup tape - I don't have

[PATCH 2.6.22 1/3] Add LED trigger to libata core

2007-03-19 Thread Tony Vroon
This adds an optional wrapper around ata_ac_issue_prot that triggers the LED layer. I plan to use this by allowing PMU LED control on G5 towers. My test platform is a PowerMac 7,3 (Dual G5 2.0GHz, June 2004) with a K2 (sata_svw) controller. Respin of an earlier patch, based on comments by Tejun

Re: [patch 00/31] 2.6.20-stable review

2007-03-19 Thread Greg KH
On Mon, Mar 19, 2007 at 02:36:47PM -0700, Greg KH wrote: > This is the start of the stable review cycle for the 2.6.20.4 release. A 2.6.20.4-rc1 patch is also availble at: kernel.org/pub/linux/kernel/v2.6/testing/patch-2.6.20.4-rc1.gz thanks, greg k-h - To unsubscribe from this list:

[patch 25/31] Input: i8042 - really suppress ACK/NAK during panic blink

2007-03-19 Thread Greg KH
-stable review patch. If anyone has any objections, please let us know. -- From: Dmitry Torokhov <[EMAIL PROTECTED]> Input: i8042 - really suppress ACK/NAK during panic blink On some boxes panic blink procedure manages to send both bytes to keyboard contoller before getting

[patch 24/31] IrDA: irttp_dup spin_lock initialisation

2007-03-19 Thread Greg KH
-stable review patch. If anyone has any objections, please let us know. -- From: Samuel Ortiz <[EMAIL PROTECTED]> Without this initialization one gets kernel BUG at kernel/rtmutex_common.h:80! This patch should also be included in the -stable kernel. Signed-off-by: G.

[patch 20/31] Fix ipv6 flow label inheritance

2007-03-19 Thread Greg KH
-stable review patch. If anyone has any objections, please let us know. -- From: Masayuki Nakagawa <[EMAIL PROTECTED]> [IPV6]: ipv6_fl_socklist is inadvertently shared. The ipv6_fl_socklist from listening socket is inadvertently shared with new socket created for connection.

[patch 21/31] Copy over mac_len when cloning an skb

2007-03-19 Thread Greg KH
-stable review patch. If anyone has any objections, please let us know. -- From: Alexey Dobriyan <[EMAIL PROTECTED]> [NET]: Copy mac_len in skb_clone() as well ANK says: "It is rarely used, that's wy it was not noticed. But in the places, where it is used, it should be

Re: [RFC][PATCH] Apple SMC driver (hardware monitoring and control)

2007-03-19 Thread Bob Copeland
On 3/14/07, Nicolas Boichat <[EMAIL PROTECTED]> wrote: Hello, I developed, a while ago, a driver the Apple System Management Controller, which provides an accelerometer (Apple Sudden Motion Sensor), light sensors, temperature sensors, keyboard backlight control and fan control on Intel-based

[patch 28/31] dio: invalidate clean pages before dio write

2007-03-19 Thread Greg KH
-stable review patch. If anyone has any objections, please let us know. -- From: Zach Brown <[EMAIL PROTECTED]> [PATCH] dio: invalidate clean pages before dio write This patch fixes a user-triggerable oops that was reported by Leonid Ananiev as archived at

[patch 31/31] UML - arch_prctl should set thread fs

2007-03-19 Thread Greg KH
-stable review patch. If anyone has any objections, please let us know. -- From: Jeff Dike <[EMAIL PROTECTED]> x86_64 needs some TLS fixes. What was missing was remembering the child thread id during clone and stuffing it into the child during each context switch. The %fs

[patch 30/31] fix deadlock in audit_log_task_context()

2007-03-19 Thread Greg KH
-stable review patch. If anyone has any objections, please let us know. -- From: Al Viro <[EMAIL PROTECTED]> [PATCH] fix deadlock in audit_log_task_context() GFP_KERNEL allocations in non-blocking context; fixed by killing an idiotic use of security_getprocattr(). Acked-by:

[patch 26/31] hda-intel - Fix codec probe with ATI controllers

2007-03-19 Thread Greg KH
-stable review patch. If anyone has any objections, please let us know. -- From: Takashi Iwai <[EMAIL PROTECTED]> [ALSA] hda-intel - Fix codec probe with ATI contorllers ATI controllers may have up to 4 codecs while ICH up to 3. Thus the earlier fix to change AZX_MAX_CODECS to

[patch 27/31] oom fix: prevent oom from killing a process with children/sibling unkillable

2007-03-19 Thread Greg KH
-stable review patch. If anyone has any objections, please let us know. -- From: Ankita Garg <[EMAIL PROTECTED]> [PATCH] oom fix: prevent oom from killing a process with children/sibling unkillable Looking at oom_kill.c, found that the intention to not kill the selected

Re: [PATCH] slab: deal with NULL pointers passed to kmem_cache_free

2007-03-19 Thread Andrew Morton
On Mon, 19 Mar 2007 23:25:36 +0200 (EET) "Pekka Enberg" <[EMAIL PROTECTED]> wrote: > > On 3/19/2007, "Andrew Morton" <[EMAIL PROTECTED]> wrote: > > Would prefer to do: > > > > static inline void kmem_cache_free_if_not_null(struct kmem_cache *cachep, > >

[patch 19/31] : Fix GFP_KERNEL with preemption disabled in fib_trie

2007-03-19 Thread Greg KH
-stable review patch. If anyone has any objections, please let us know. -- From: Robert Olsson <[EMAIL PROTECTED]> [IPV4]: Do not disable preemption in trie_leaf_remove(). Hello, Just discussed this Patrick... We have two users of trie_leaf_remove, fn_trie_flush and

[patch 29/31] Input: i8042 - fix AUX IRQ delivery check

2007-03-19 Thread Greg KH
-stable review patch. If anyone has any objections, please let us know. -- From: Dmitry Torokhov <[EMAIL PROTECTED]> Input: i8042 - fix AUX IRQ delivery check On boxes that do not implement AUX LOOP command we can not verify AUX IRQ delivery and must assume that it is wired

[patch 16/31] fix read past end of array in md/linear.c

2007-03-19 Thread Greg KH
-stable review patch. If anyone has any objections, please let us know. -- From: Andy Isaacson <[EMAIL PROTECTED]> When iterating through an array, one must be careful to test one's index variable rather than another similarly-named variable. The loop will read off the end of

[patch 23/31] Fix page allocation debugging on sparc64

2007-03-19 Thread Greg KH
-stable review patch. If anyone has any objections, please let us know. -- From: David Miller <[EMAIL PROTECTED]> [SPARC64]: Get DEBUG_PAGEALLOC working again. We have to make sure to use base-pagesize TLB entries even during the early transition period where we need TLB miss

[patch 15/31] fix MTIME_SEC_MAX on 32-bit

2007-03-19 Thread Greg KH
-stable review patch. If anyone has any objections, please let us know. -- From: Thomas Gleixner <[EMAIL PROTECTED]> The maximum seconds value we can handle on 32bit is LONG_MAX. Cc: Ingo Molnar <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>

[patch 10/31] EHCI: add delay to bus_resume before accessing ports

2007-03-19 Thread Greg KH
-stable review patch. If anyone has any objections, please let us know. -- From: Alan Stern <[EMAIL PROTECTED]> This patch (as870) adds a delay to ehci-hcd's bus_resume routine. Apparently there are controllers and/or BIOSes out there which need such a delay to get the ports

[patch 12/31] futex: PI state locking fix

2007-03-19 Thread Greg KH
-stable review patch. If anyone has any objections, please let us know. -- From: Ingo Molnar <[EMAIL PROTECTED]> Testing of -rt by IBM uncovered a locking bug in wake_futex_pi(): the PI state needs to be locked before we access it. Signed-off-by: Ingo Molnar <[EMAIL

[patch 17/31] r8169: fix a race between PCI probe and dev_open

2007-03-19 Thread Greg KH
-stable review patch. If anyone has any objections, please let us know. -- Initialize the timer with the rest of the private-struct. Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> Signed-off-by: Greg Kroah-Hartman <[EMAIL

[patch 04/31] gdth: fix oops in gdth_copy_cmd()

2007-03-19 Thread Greg KH
-stable review patch. If anyone has any objections, please let us know. -- Recent alterations to the gdth_fill_raw_cmd() path no longer set the sg_ranz field for zero transfer commands. However, this field is used lower down in the function to initialise ha->cmd_len to the size

[patch 05/31] NetLabel: Verify sensitivity level has a valid CIPSO mapping

2007-03-19 Thread Greg KH
-stable review patch. If anyone has any objections, please let us know. -- The current CIPSO engine has a problem where it does not verify that the given sensitivity level has a valid CIPSO mapping when the "std" CIPSO DOI type is used. The end result is that bad packets are

[patch 06/31] NETFILTER: nfnetlink_log: fix reference counting

2007-03-19 Thread Greg KH
-stable review patch. If anyone has any objections, please let us know. -- From: Michal Miroslaw <[EMAIL PROTECTED]> [NETFILTER]: nfnetlink_log: fix reference counting Fix reference counting (memory leak) problem in __nfulnl_send() and callers related to packet queueing.

[patch 09/31] mm: fix madvise infinine loop

2007-03-19 Thread Greg KH
-stable review patch. If anyone has any objections, please let us know. -- From: Nick Piggin <[EMAIL PROTECTED]> madvise(MADV_REMOVE) can go into an infinite loop or cause an oops if the call covers a region from the start of a vma, and extending past that vma. Signed-off-by:

[patch 02/31] Fix rtm_to_ifaddr() error return.

2007-03-19 Thread Greg KH
-stable review patch. If anyone has any objections, please let us know. -- From: Evgeniy Polyakov <[EMAIL PROTECTED]> [IPV4]: Fix rtm_to_ifaddr() error handling. Return negative error value (embedded in the pointer) instead of returning NULL. Signed-off-by: Evgeniy Polyakov

[patch 03/31] Fix user copy length in ipv6_sockglue.c

2007-03-19 Thread Greg KH
-stable review patch. If anyone has any objections, please let us know. -- From: Chris Wright <[EMAIL PROTECTED]> [IPV6] fix ipv6_getsockopt_sticky copy_to_user leak User supplied len < 0 can cause leak of kernel memory. Use unsigned compare instead. Signed-off-by: Chris

[patch 00/31] 2.6.20-stable review

2007-03-19 Thread Greg KH
This is the start of the stable review cycle for the 2.6.20.4 release. There are 31 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let us know. If anyone is a maintainer of the proper subsystem, and wants to add a

[patch 01/31] Fix another NULL pointer deref in ipv6_sockglue.c

2007-03-19 Thread Greg KH
-stable review patch. If anyone has any objections, please let us know. -- From: Olaf Kirch <[EMAIL PROTECTED]> [IPV6]: Fix for ipv6_setsockopt NULL dereference I came across this bug in http://bugzilla.kernel.org/show_bug.cgi?id=8155 Signed-off-by: Olaf Kirch <[EMAIL

[patch 01/31] Fix another NULL pointer deref in ipv6_sockglue.c

2007-03-19 Thread Greg KH
-stable review patch. If anyone has any objections, please let us know. -- From: Olaf Kirch <[EMAIL PROTECTED]> [IPV6]: Fix for ipv6_setsockopt NULL dereference I came across this bug in http://bugzilla.kernel.org/show_bug.cgi?id=8155 Signed-off-by: Olaf Kirch <[EMAIL

Re: [PATCH 00/22 take 3] UBI: Unsorted Block Images

2007-03-19 Thread Thomas Gleixner
On Mon, 2007-03-19 at 14:54 -0500, Matt Mackall wrote: > > (UBI also has static volumes which LVM doesn't but that is an aside.) > > If a static volume is simply a non-dynamic volume, then device mapper > can do that too. And countless other things. Which is not an aside. > UBI growing to do all

Re: [PATCH, take3] getrusage() : Fill ru_inblock and ru_oublock fields if possible

2007-03-19 Thread Andrew Morton
On Mon, 19 Mar 2007 17:37:23 +0300 Oleg Nesterov <[EMAIL PROTECTED]> wrote: > On 03/19, Eric Dumazet wrote: > > > > [...snip...] > > do { > > utime = cputime_add(utime, t->utime); > > @@ -2040,6 +2045,8 @@ static void k_getrusage(struct task_stru >

Re: [PATCH 0/2] wistron_btns: More keymaps

2007-03-19 Thread Dmitry Torokhov
On 3/15/07, Éric Piel <[EMAIL PROTECTED]> wrote: 03/14/2007 08:02 PM, Vojtech Pavlik wrote/a écrit: > On Wed, Mar 14, 2007 at 02:58:49PM -0400, Dmitry Torokhov wrote: > 2. I also have a concern about using KEY_SCREEN to signal toggling display on and off. I am CCing Vojtech - he must

Re: [PATCH] slab: deal with NULL pointers passed to kmem_cache_free

2007-03-19 Thread Pekka Enberg
On 3/19/2007, "Andrew Morton" <[EMAIL PROTECTED]> wrote: > Would prefer to do: > > static inline void kmem_cache_free_if_not_null(struct kmem_cache *cachep, > void *objp) > { > if (objp) > kmem_cache_free(cachep, objp); > } > >

Re: [PATCH 14 of 33] IB/ipath - fix port sharing on powerpc

2007-03-19 Thread Roland Dreier
> The port sharing feature mixed kernel virtual addresses as well as > physical addresses for the offset used to describe the mmap address to map > the InfiniPath hardware into user space. This had a conflict on powerpc. > The new scheme converts it to a physical address so it doesn't

Re: [PATCH 33 of 33] IB/ipath - fix drift between WCs in user and kernel space

2007-03-19 Thread Roland Dreier
For example this seems like it should go in 2.6.21 -- otherwise userspace verbs are completely broken with ipath, right? It's really my fault for breaking it, but I don't see why we want to release with a bug like that. - R. - To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH 12 of 33] IB/ipath - fix bad argument to clear_bit that trashed memory and/or crashed

2007-03-19 Thread Roland Dreier
Similarly -- shouldn't an obvious memory corruption fix be in 2.6.21? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at

Re: [PATCH 01 of 33] IB/ipath - add ability to set and clear IB local loopback

2007-03-19 Thread Roland Dreier
This patch format is somewhat inconvenient: > # HG changeset patch > # User Bryan O'Sullivan <[EMAIL PROTECTED]> I assume this is the real author of the patch (as opposed to the sender of the email)? git would prefer to see From: Bryan O'Sullivan <[EMAIL PROTECTED]> in the body of the

Re: [PATCH 2/2] Replace pid_t in autofs with struct pid reference

2007-03-19 Thread Serge E. Hallyn
Quoting Eric W. Biederman ([EMAIL PROTECTED]): > "Serge E. Hallyn" <[EMAIL PROTECTED]> writes: > > >> > >> >> Index: 2.6.20/fs/autofs4/waitq.c > >> >> === > >> >> --- 2.6.20.orig/fs/autofs4/waitq.c > >> >> +++

Re: [PATCH 00 of 33] Set of ipath patches for 2.6.22

2007-03-19 Thread Roland Dreier
Are these really all for 2.6.22? Some of them seem like bugfixes that you would want in 2.6.21... - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

Re: 2.6.21-rc1: known regressions (v2) (part 1)

2007-03-19 Thread Rafael J. Wysocki
On Monday, 19 March 2007 16:32, Pavel Machek wrote: > > > >> > > > I have the same problem on my IBM X60s on rc1 and rc2. Can't resume > > >> > > > from RAM, can't suspend to disk. It is possible to revert all the > > >> > > > changes to ACPI and test it? > > >> > > > > >> > > This is with

Re: [PATCH] slab: deal with NULL pointers passed to kmem_cache_free

2007-03-19 Thread Christoph Lameter
On Mon, 19 Mar 2007, Matt Mackall wrote: > I think this sort of thing should work: > > a = kmalloc(...) > b = kmem_cache_alloc(..) > c = allocate_some_id(...) > if (!a || !b || !c) { >free_some_id(c) >kmem_cache_free(c) this requires the specification of a kmem_cache structure and

Re: [PATCH 00/22 take 3] UBI: Unsorted Block Images

2007-03-19 Thread Thomas Gleixner
On Mon, 2007-03-19 at 15:12 -0500, Matt Mackall wrote: > > Should we export block devices with 16/32/64/128 KiB size ? > > Sure, why not? Simply because we want to have the ability to write fine grained in order to write data safe to FLASH. If we export those large sizes we lose this ability and

Oops when mounting cdrom

2007-03-19 Thread Roman Garifullin
[1.] Oops when mounting cdrom [2.] When trying to `mount /dev/cdrom /media/cdrom` kernel crashes [3.] kernel [4.] [4.1] cat /proc/version Linux version 2.6.20.3 ([EMAIL PROTECTED]) (gcc version 3.4.6) #1 SMP Tue Mar 20 00:47:28 YEKT 2007 [4.2] AP_FIRMWARE_NVRAM=y CONFIG_HOSTAP_PLX=m

Re: 2.6.20.3: kernel BUG at mm/slab.c:597 try#2

2007-03-19 Thread Mike Christie
Mike Christie wrote: > James Bottomley wrote: >> On Mon, 2007-03-19 at 12:49 -0500, Mike Christie wrote: I can't even say if the tapes are written correctly as I can't read them (one does not reboot production machines back to 2.4.x just to try to read a backup tape - I don't have

Re: [PATCH 00/22 take 3] UBI: Unsorted Block Images

2007-03-19 Thread Artem Bityutskiy
On Mon, 2007-03-19 at 14:54 -0500, Matt Mackall wrote: > The issue is 14000 lines of patch to make a parallel subsystem. Parallel system exists since very long. One is flash->SW_or_HW_FTL->all_blkdev_stuff. The other is MTD->JFFS2. Think about _why_ there are 2 of them. Hint - reliability,

Re: [PATCH] slab: deal with NULL pointers passed to kmem_cache_free

2007-03-19 Thread Andrew Morton
On Mon, 19 Mar 2007 15:49:46 -0500 Matt Mackall <[EMAIL PROTECTED]> wrote: > On Mon, Mar 19, 2007 at 10:08:03AM -0700, Christoph Lameter wrote: > > On Mon, 19 Mar 2007, Pekka J Enberg wrote: > > > > > This changes kmem_cache_free() to deal with NULL objects passed to it. > > > The > > >

Re: is RSDL an "unfair" scheduler too?

2007-03-19 Thread Bill Davidsen
Bill Huey (hui) wrote: On Sun, Mar 18, 2007 at 06:24:40AM +0100, Willy Tarreau wrote: Dunno. I guess a lot of people would like to then manage the classes, which would be painful as hell. Sure ! I wouldn't like people to point the finger on Linux saying "hey look, they can't write a good

Re: mm snapshot broken-out-2007-03-18-02-44.tar.gz uploaded

2007-03-19 Thread Andrew Morton
On Mon, 19 Mar 2007 20:23:40 +0100 Michal Piotrowski <[EMAIL PROTECTED]> wrote: > [EMAIL PROTECTED] napisał(a): > > The mm snapshot broken-out-2007-03-18-02-44.tar.gz has been uploaded to > > > > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/mm/broken-out-2007-03-18-02-44.tar.gz > >

Re: [PATCH] slab: deal with NULL pointers passed to kmem_cache_free

2007-03-19 Thread Matt Mackall
On Mon, Mar 19, 2007 at 10:08:03AM -0700, Christoph Lameter wrote: > On Mon, 19 Mar 2007, Pekka J Enberg wrote: > > > This changes kmem_cache_free() to deal with NULL objects passed to it. The > > current behavior is inconsistent with kfree() so there are callers > > passing NULL to

Re: [patch 13/26] Xen-paravirt_ops: Consistently wrap paravirt ops callsites to make them patchable

2007-03-19 Thread Andi Kleen
> It's inability to handle sequences like the above sounds to me like > a very good argument to _not_ merge the unwinder back into the tree. The unwinder can handle it fine, it is just that gcc right now cannot be taught to generate correct unwind tables for it. If paravirt ops is widely used i

Re: Wanted: simple, safe x86 stack overflow detection

2007-03-19 Thread Eric W. Biederman
Avi Kivity <[EMAIL PROTECTED]> writes: > I don't understand why interrupt latency suffers. Sure, the interrupt that's > being masked is delayed, but on the other hand the interrupt that's doing the > masking is not. We're moving the latency from the first interrupt to the > second, probably

Re: RSDL v0.31

2007-03-19 Thread Al Boldi
Mark Lord wrote: > Al Boldi wrote: > >.. > > Mike, I'm not saying RSDL is perfect, but v0.31 is by far better than > > mainline. Try this easy test: > > > > startx with the vesa driver > > run reflect from the mesa5.0-demos > > load 5 cpu-hogs > > start moving the mouse > > > > On my desktop,

<    1   2   3   4   5   6   7   8   9   10   >