Re: Pagecache: find_or_create_page does not call a proper page allocator function

2007-04-24 Thread Hugh Dickins
On Tue, 24 Apr 2007, Christoph Lameter wrote: On Tue, 24 Apr 2007, Hugh Dickins wrote: Or Christoph may prevail in persuading there's no such problem. This is pointless. NUMA allocations can only be controlled for the highest zone. If we switch to a lower zone then we allocate on a

Re: [Intel IOMMU][patch 1/8] ACPI support for Intel Virtualization Technology for Directed I/O

2007-04-24 Thread Ashok Raj
On Tue, Apr 24, 2007 at 08:50:48PM +0200, Andi Kleen wrote: + +LIST_HEAD(dmar_drhd_units); +LIST_HEAD(dmar_rmrr_units); Comment describing what lock protects those lists? In fact there seems to be no locking. What about hotplug? There is no support to handle an IOMMU hotplug at this

Re: Pagecache: find_or_create_page does not call a proper page allocator function

2007-04-24 Thread Andrew Morton
On Tue, 24 Apr 2007 13:12:42 -0700 (PDT) Christoph Lameter [EMAIL PROTECTED] wrote: On Tue, 24 Apr 2007, Andrew Morton wrote: A highmem page can have buffers??? yep. Take a 4k page which is stored in four discontiguous 1k disk blocks. The data at page_buffers(page) is the sole

suspend2 merge (was Re: [Suspend2-devel] Re: CFS and suspend2: hang in atomic copy)

2007-04-24 Thread Pavel Machek
Hi! From subsequent emails, I think you already got your answer, but just in case... Yes, if you enabled Replace swsusp by default and you already had it set up for getting swsusp to resume. If not, and you're using an initrd/ramfs, you'll need to modify it to echo

Re: [patch 1/4] Ignore stolen time in the softlockup watchdog

2007-04-24 Thread Jeremy Fitzhardinge
Jeremy Fitzhardinge wrote: Andrew Morton wrote: Well, it _is_ mysterious. Did you try to locate the code which failed? I got lost in macros and include files, and gave up very very easily. Stop hiding, Ingo. OK, I've managed to reproduce it. Removing the

Re: [PATCH] kthread: Enhance kthread_stop to abort interruptible sleeps

2007-04-24 Thread Oleg Nesterov
On 04/24, Eric W. Biederman wrote: I don't know if this is the problem but it certainly needs to be fixed. I guess you will re-submit these patches soon. May I suggest you to put this + spin_lock_irq(tsk-sighand-siglock); + signal_wake_up(tsk, 1); +

Re: Pagecache: find_or_create_page does not call a proper page allocator function

2007-04-24 Thread Christoph Lameter
On Tue, 24 Apr 2007, Hugh Dickins wrote: On Tue, 24 Apr 2007, Christoph Lameter wrote: On Tue, 24 Apr 2007, Hugh Dickins wrote: Or Christoph may prevail in persuading there's no such problem. This is pointless. NUMA allocations can only be controlled for the highest zone. If we

Re: [Intel IOMMU][patch 7/8] Support for legacy ISA devices

2007-04-24 Thread Arjan van de Ven
Andi Kleen wrote: On Tuesday 24 April 2007 08:03:06 Ashok Raj wrote: Floppy disk drivers dont work well with DMA remapping. What is the problem? You can't allocate mappings 16MB? floppy doesn't use the DMA mapping API :) that's the problem - To unsubscribe from this list: send the line

Re: [Intel IOMMU][patch 8/8] Preserve some Virtual Address when devices cannot address entire range.

2007-04-24 Thread Ashok Raj
On Tue, Apr 24, 2007 at 09:33:15PM +0200, Andi Kleen wrote: On Tuesday 24 April 2007 08:03:07 Ashok Raj wrote: Some devices may not support entire 64bit DMA. In a situation where such devices are co-located in a shared domain, we need to ensure there is some address space reserved for

Re: [patch 1/4] Ignore stolen time in the softlockup watchdog

2007-04-24 Thread Andrew Morton
On Tue, 24 Apr 2007 13:24:24 -0700 Jeremy Fitzhardinge [EMAIL PROTECTED] wrote: Jeremy Fitzhardinge wrote: Andrew Morton wrote: Well, it _is_ mysterious. Did you try to locate the code which failed? I got lost in macros and include files, and gave up very very easily. Stop

Re: [PATCH 3/7] Universal battery class

2007-04-24 Thread Anton Vorontsov
Hello Pavel, On Tue, Apr 24, 2007 at 09:28:46PM +0200, Pavel Machek wrote: Hi! Signed-off-by: Anton Vorontsov [EMAIL PROTECTED] Yes please. Generic battery support is badly needed. I'm glad you like it, thanks for the review! Also I've done some code split. It removes all #ifdefs from

Re: [ANNOUNCE] UidBind LSM 0.2

2007-04-24 Thread Casey Schaufler
--- Gerhard Mack [EMAIL PROTECTED] wrote: On Tue, 24 Apr 2007, Roberto De Ioris wrote: Hi all, this is the second release for UidBind LSM: http://projects.unbit.it/uidbind/ UidBind allows call to bind() function only to the uid defined in a configfs tree. It is now

Re: [Intel IOMMU][patch 7/8] Support for legacy ISA devices

2007-04-24 Thread Ashok Raj
On Tue, Apr 24, 2007 at 09:31:09PM +0200, Andi Kleen wrote: On Tuesday 24 April 2007 08:03:06 Ashok Raj wrote: Floppy disk drivers dont work well with DMA remapping. What is the problem? You can't allocate mappings 16MB? No.. these drivers dont call DMA mapping api's.. thats the problem.

Re: [PATCH 3/7] Universal battery class

2007-04-24 Thread Pavel Machek
Hi! Signed-off-by: Anton Vorontsov [EMAIL PROTECTED] Yes please. Generic battery support is badly needed. I'm glad you like it, thanks for the review! Also I've done some code split. It removes all #ifdefs from battery.c, and also separates core from sysfs and leds. If there

Re: Pagecache: find_or_create_page does not call a proper page allocator function

2007-04-24 Thread Andrew Morton
On Tue, 24 Apr 2007 13:30:33 -0700 (PDT) Christoph Lameter [EMAIL PROTECTED] wrote: If the system has both high memory and normal memory then only allocations to highmemory are subject to memory policies etc etc. The block device allocations would be in zone normal/dma and thus be

[PATCH] use mutex instead of semaphore in DMA pool handler

2007-04-24 Thread Matthias Kaehlcke
the DMA pool handler uses a semaphore as mutex. use the mutex API instead of the (binary) semaphore Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED] -- diff --git a/drivers/base/dmapool.c b/drivers/base/dmapool.c index cd467c9..9406259 100644 --- a/drivers/base/dmapool.c +++

Re: suspend2 merge (was Re: [Suspend2-devel] Re: CFS and suspend2: hang in atomic copy)

2007-04-24 Thread Linus Torvalds
On Tue, 24 Apr 2007, Pavel Machek wrote: Well, current uswsusp code can do most of stuff suspend2 can do, with 20% (or so) of kernel code. Btw, this is a totally inane argument. If the code just moved somewhere else, it's not less code. You compare complete subsystems against complete

[PATCH 1/3] MMC: OMAP: Add missing ´\n´

2007-04-24 Thread Carlos Aguiar
This patch add a missing '\n' at the end of the 'cover is open' string in mmc_omap_switch_handler(). Signed-off-by: Arnaud Patard [EMAIL PROTECTED] Signed-off-by: Tony Lindgren [EMAIL PROTECTED] Index: linux-2.6.20/drivers/mmc/omap.c

Re: [Intel IOMMU][patch 4/8] Supporting Zero Length Reads in Intel IOMMU.

2007-04-24 Thread Ashok Raj
On Tue, Apr 24, 2007 at 09:28:11PM +0200, Andi Kleen wrote: On Tuesday 24 April 2007 08:03:03 Ashok Raj wrote: PCI specs permit zero length reads (ZLR) even if the mapping for that region is write only. Support for this feature is indicated by the presence of a bit in the DMAR

Re: Pagecache: find_or_create_page does not call a proper page allocator function

2007-04-24 Thread Christoph Lameter
On Tue, 24 Apr 2007, Andrew Morton wrote: I would say that the filesystem is broke if it has such expectations regardless of page migration. Others disagree ;) The filesystem has *told* the core kernel what its allocation constraints are by setting up mapping_gfp_mask(). If the core

Re: BUG: Null pointer dereference in fs/open.c

2007-04-24 Thread Peter Osterlund
On Mon, 23 Apr 2007, Andrew Morton wrote: Try this: --- a/drivers/block/pktcdvd.c~packet-fix-error-handling +++ a/drivers/block/pktcdvd.c @@ -777,7 +777,8 @@ static int pkt_generic_packet(struct pkt rq-cmd_flags |= REQ_QUIET; blk_execute_rq(rq-q, pd-bdev-bd_disk, rq,

Re: [patch 1/4] Ignore stolen time in the softlockup watchdog

2007-04-24 Thread Jeremy Fitzhardinge
Andrew Morton wrote: On Tue, 24 Apr 2007 13:00:49 -0700 Jeremy Fitzhardinge [EMAIL PROTECTED] wrote: Andrew Morton wrote: Well, it _is_ mysterious. Did you try to locate the code which failed? I got lost in macros and include files, and gave up very very easily. Stop hiding,

[PATCH 2/3] MMC: OMAP: Fix omap to use MMC_POWER_ON

2007-04-24 Thread Carlos Aguiar
As discussed earlier on LKML: http://lkml.org/lkml/2006/5/4/44 Signed-off-by: Tony Lindgren [EMAIL PROTECTED] Index: linux-2.6.20/drivers/mmc/omap.c === --- linux-2.6.20.orig/drivers/mmc/omap.c2007-04-24 15:22:12.0

[PATCH 3/3] MMC: OMAP: Clean up omap set_ios and make MMC_POWER_ON work

2007-04-24 Thread Carlos Aguiar
Move divisor calculation into a separate function and re-arrange the init order to make MMC_POWER_ON work. Signed-off-by: Tony Lindgren [EMAIL PROTECTED] Index: linux-2.6.20/drivers/mmc/omap.c === ---

Re: [patch 1/4] Ignore stolen time in the softlockup watchdog

2007-04-24 Thread Jeremy Fitzhardinge
Andrew Morton wrote: It's weird. And I don't think the locking selftest code calls sched_clock() (or any other time-related thing) at all, does it? I guess it ends up going through the scheduler, which does use it. But... shrug J - To unsubscribe from this list: send the line

RE: suspend2 merge (was Re: [Suspend2-devel] Re: CFS and suspend2: hang in atomic copy)

2007-04-24 Thread Hua Zhong
This whole notion that kernel lines of code is somehow different is a stupid and idiotic _disease_ that is spread by microkernel people and people who have been brainwashed by them. I think a lot of people are tired of this argument, but I am glad you speak up (as you did last year wrt s2ram).

Re: [patch 1/4] Ignore stolen time in the softlockup watchdog

2007-04-24 Thread Daniel Walker
On Tue, 2007-04-24 at 13:24 -0700, Jeremy Fitzhardinge wrote: And sched_clock's use of local_irq_save/restore appears to be absolutely correct, so I think it must be triggering a bug in either the self-tests or lockdep itself. Why does sched_clock need to disable interrupts? Daniel - To

Re: Pagecache: find_or_create_page does not call a proper page allocator function

2007-04-24 Thread Andrew Morton
On Tue, 24 Apr 2007 13:44:50 -0700 (PDT) Christoph Lameter [EMAIL PROTECTED] wrote: On Tue, 24 Apr 2007, Andrew Morton wrote: I would say that the filesystem is broke if it has such expectations regardless of page migration. Others disagree ;) The filesystem has *told* the

Re: suspend2 merge (was Re: [Suspend2-devel] Re: CFS and suspend2: hang in atomic copy)

2007-04-24 Thread Ingo Molnar
* Linus Torvalds [EMAIL PROTECTED] wrote: I have not a frigging clue whether that is the case in suspend2 vs uswsusp, but I object to this idiotic argument of counting kernel code. That's simply not a valid argument. It never was. the raw linecount appears to be the following:

Re: [patch 1/7] libata: check for AN support

2007-04-24 Thread Kristen Carlson Accardi
Check to see if an ATAPI device supports Asynchronous Notification. If so, enable it. changes from last version: * fix typo in ata_id_has_AN and make word 76 test more clear * If we fail to set the AN feature, just print a warning and continue Signed-off-by: Kristen Carlson Accardi [EMAIL

[PATCH 0/3] Aligning omap.c from Linux-OMAP to mainline kernel

2007-04-24 Thread Carlos Aguiar
Hi Pierre, Find in this series the pending patches from Linux-OMAP to mainline for drivers/mmc/omap.c The patches series was applied against Linus' tree 2.6.21-rc7-git6. Anyway, it was tested on OMAP H2 (using omap_h2_1610_defconfig available on linus' tree). BR, Carlos. -- Carlos Eduardo

Re: Pagecache: find_or_create_page does not call a proper page allocator function

2007-04-24 Thread Christoph Lameter
On Tue, 24 Apr 2007, Andrew Morton wrote: Then I think we should disable page migration for allocations that do not allow access to the policy zone. That would fix it. Can't we use mapping_gfp_mask() when allocating the destination page? There is no point in migrating something if you

Re: [patch 1/4] Ignore stolen time in the softlockup watchdog

2007-04-24 Thread Ingo Molnar
* Daniel Walker [EMAIL PROTECTED] wrote: On Tue, 2007-04-24 at 13:24 -0700, Jeremy Fitzhardinge wrote: And sched_clock's use of local_irq_save/restore appears to be absolutely correct, so I think it must be triggering a bug in either the self-tests or lockdep itself. Why does

Re: [Intel IOMMU][patch 4/8] Supporting Zero Length Reads in Intel IOMMU.

2007-04-24 Thread David Miller
From: Andi Kleen [EMAIL PROTECTED] Date: Tue, 24 Apr 2007 21:28:11 +0200 On Tuesday 24 April 2007 08:03:03 Ashok Raj wrote: PCI specs permit zero length reads (ZLR) even if the mapping for that region is write only. Support for this feature is indicated by the presence of a bit in

Re: [Intel IOMMU][patch 3/8] Generic hardware support for Intel IOMMU.

2007-04-24 Thread Ashok Raj
On Tue, Apr 24, 2007 at 09:27:08PM +0200, Andi Kleen wrote: On Tuesday 24 April 2007 08:03:02 Ashok Raj wrote: +#ifdef CONFIG_DMAR +#ifdef CONFIG_SMP +static void dmar_msi_set_affinity(unsigned int irq, cpumask_t mask) Why does it need an own interrupt type? Problem is its MSI type

Re: [patch 1/4] Ignore stolen time in the softlockup watchdog

2007-04-24 Thread Daniel Walker
On Tue, 2007-04-24 at 22:59 +0200, Ingo Molnar wrote: * Daniel Walker [EMAIL PROTECTED] wrote: On Tue, 2007-04-24 at 13:24 -0700, Jeremy Fitzhardinge wrote: And sched_clock's use of local_irq_save/restore appears to be absolutely correct, so I think it must be triggering a bug in

[RFC] [PATCH] cpufreq: allow full selection of default governors

2007-04-24 Thread William Heimbigner
The following patches should allow selection of conservative, powersave, and ondemand in the kernel configuration. William Heimbigner [EMAIL PROTECTED] diff -uprN -X linux-2.6.21-rc7-git6/Documentation/dontdiff linux-2.6.21-rc7-git6/drivers/cpufreq/Kconfig

Re: [PATCH 1/2] Handle kernelcore= boot parameter in common code to avoid boot problem on IA64

2007-04-24 Thread Andrew Morton
On Tue, 24 Apr 2007 19:00:52 +0100 (IST) Mel Gorman [EMAIL PROTECTED] wrote: When kernelcore boot option is specified, kernel can't boot up on ia64 because of an infinite loop. In addition, the parsing code can be handled in an architecture-independent manner. This patch patches uses

'Scheduler Economy' prototype patch for CFS

2007-04-24 Thread Ingo Molnar
* Ingo Molnar [EMAIL PROTECTED] wrote: but the point I'm trying to make is that X shouldn't get more CPU-time because it's more important (it's not: and as noted earlier, thinking that it's more important skews the problem and makes for too *much* scheduling). X should get more CPU

Re: [PATCH 0/3] Aligning omap.c from Linux-OMAP to mainline kernel

2007-04-24 Thread Tony Lindgren
* Carlos Aguiar [EMAIL PROTECTED] [070424 21:01]: Hi Pierre, Find in this series the pending patches from Linux-OMAP to mainline for drivers/mmc/omap.c The patches series was applied against Linus' tree 2.6.21-rc7-git6. Anyway, it was tested on OMAP H2 (using omap_h2_1610_defconfig

Re: [RFC] [PATCH] cpufreq: allow full selection of default governors

2007-04-24 Thread Dave Jones
On Tue, Apr 24, 2007 at 09:03:23PM +, William Heimbigner wrote: The following patches should allow selection of conservative, powersave, and ondemand in the kernel configuration. This has been rejected several times already. Ondemand and conservative isn't a viable governor for all

Re: [Intel IOMMU][patch 8/8] Preserve some Virtual Address when devices cannot address entire range.

2007-04-24 Thread Andi Kleen
On Tuesday 24 April 2007 22:33:04 Ashok Raj wrote: With PCIE there is some benefit to keep dma addr low for performance reasons, since it will use 32bit Transaction level packets instead of 64bit. This reservation is only required if we have some legacy device under a p2p where its

Re: [PATCH 04/25] xen: Add XEN config options

2007-04-24 Thread Andi Kleen
Shouldn't this be after the change that adds arch/i386/xen/Kconfig? Otherwise you break bisects It should be OK. The series should build and run at each patch (though I have to admit I haven't tested this). In general I've been adding config options for each feature as the

Re: [RFC] [PATCH] cpufreq: allow full selection of default governors

2007-04-24 Thread Robert P. J. Day
On Tue, 24 Apr 2007, William Heimbigner wrote: The following patches should allow selection of conservative, powersave, and ondemand in the kernel configuration. William Heimbigner [EMAIL PROTECTED] diff -uprN -X linux-2.6.21-rc7-git6/Documentation/dontdiff

[PATCH] cxacru: Cleanup sysfs attribute code

2007-04-24 Thread Simon Arlott
This changes the format of unknown status values to be less verbose and uses an array instead of several different snprintf calls. Since only enum values are assigned to it, poll_state is changed from int to enum. Use abs() for dB values instead of two almost identical return lines.

Re: [patch 1/4] Ignore stolen time in the softlockup watchdog

2007-04-24 Thread Andrew Morton
On Tue, 24 Apr 2007 22:59:18 +0200 Ingo Molnar [EMAIL PROTECTED] wrote: * Daniel Walker [EMAIL PROTECTED] wrote: On Tue, 2007-04-24 at 13:24 -0700, Jeremy Fitzhardinge wrote: And sched_clock's use of local_irq_save/restore appears to be absolutely correct, so I think it must be

Re: [Intel IOMMU][patch 6/8] Doc updates for Intel Virtualization Technology for Directed I/O.

2007-04-24 Thread Markus Rechberger
On 4/23/07, Ashok Raj [EMAIL PROTECTED] wrote: Document Intel IOMMU driver boot option. Signed-off-by: Ashok Raj [EMAIL PROTECTED] Signed-off-by: Shaohua Li [EMAIL PROTECTED] Index: linux-2.6.21-rc5/Documentation/Intel-IOMMU.txt

Re: [patch 1/4] Ignore stolen time in the softlockup watchdog

2007-04-24 Thread Andi Kleen
On Tuesday 24 April 2007 22:52:27 Daniel Walker wrote: On Tue, 2007-04-24 at 13:24 -0700, Jeremy Fitzhardinge wrote: And sched_clock's use of local_irq_save/restore appears to be absolutely correct, so I think it must be triggering a bug in either the self-tests or lockdep itself. Why

Re: [PATCH] kthread: Enhance kthread_stop to abort interruptible sleeps

2007-04-24 Thread Eric W. Biederman
Oleg Nesterov [EMAIL PROTECTED] writes: On 04/24, Eric W. Biederman wrote: I don't know if this is the problem but it certainly needs to be fixed. I guess you will re-submit these patches soon. May I suggest you to put this +spin_lock_irq(tsk-sighand-siglock); +

Serial console problem in 2.6.21-rc7-mm1 and earlier

2007-04-24 Thread Christoph Lameter
On Tue, 24 Apr 2007, Andrew Morton wrote: Nothing special apart from the usual problem with serial not accepting characters that we had for awhile now. I wasn't aware of that one. I use a serial console on my x86_84 box. For a while now I can see all output but I cannot type any

Re: [Intel IOMMU][patch 8/8] Preserve some Virtual Address when devices cannot address entire range.

2007-04-24 Thread David Miller
From: Andi Kleen [EMAIL PROTECTED] Date: Tue, 24 Apr 2007 23:12:54 +0200 We already have a couple of other IOMMU architectures who essentially have the same problem. Have you checked how they solve this? Sparc64, for one, only uses 32-bit IOMMU addresses. And we simply don't try to handle

Re: Pagecache: find_or_create_page does not call a proper page allocator function

2007-04-24 Thread Andrew Morton
On Tue, 24 Apr 2007 13:58:35 -0700 (PDT) Christoph Lameter [EMAIL PROTECTED] wrote: On Tue, 24 Apr 2007, Andrew Morton wrote: Then I think we should disable page migration for allocations that do not allow access to the policy zone. That would fix it. Can't we use

Re: suspend2 merge (was Re: [Suspend2-devel] Re: CFS and suspend2: hang in atomic copy)

2007-04-24 Thread Pavel Machek
Hi! Well, current uswsusp code can do most of stuff suspend2 can do, with 20% (or so) of kernel code. Btw, this is a totally inane argument. If the code just moved somewhere else, it's not less code. It is not just moved. It is in userspace, where we can use liblzf / gcrypt / ( and

Re: [PATCH 06/25] xen: Core Xen implementation

2007-04-24 Thread Andi Kleen
On Monday 23 April 2007 23:56:44 Jeremy Fitzhardinge wrote: Core Xen Implementation This patch is a rollup of all the core pieces of the Xen implementation, including booting, memory management, interrupts, time and so on. The patch is definitely too big. +#ifdef CONFIG_XEN +/* Xen only

Re: [RFC] [PATCH] cpufreq: allow full selection of default governors

2007-04-24 Thread Chuck Ebbert
Dave Jones wrote: On Tue, Apr 24, 2007 at 09:03:23PM +, William Heimbigner wrote: The following patches should allow selection of conservative, powersave, and ondemand in the kernel configuration. This has been rejected several times already. Ondemand and conservative isn't a

Re: [Intel IOMMU][patch 6/8] Doc updates for Intel Virtualization Technology for Directed I/O.

2007-04-24 Thread Ashok Raj
On Tue, Apr 24, 2007 at 11:17:55PM +0200, Markus Rechberger wrote: +We also allocate gaurd pages with each mapping, so we can attempt to catch +any overflow that might happen. + guess you probably mean guard tables here... So there is a good chance i can be The Governor of California :-)

Re: Pagecache: find_or_create_page does not call a proper page allocator function

2007-04-24 Thread Christoph Lameter
On Tue, 24 Apr 2007, Andrew Morton wrote: mapping_gfp_mask if a pretty foul thing. Adding struct page (*alloc_page)(struct address_space *mapping); to address_space_operations would be a quite nice cleanup. Ummm... If things would be that simple... I think we need struct page

Re: [REPORT] cfs-v4 vs sd-0.44

2007-04-24 Thread William Lee Irwin III
On Mon, Apr 23, 2007 at 05:59:06PM -0700, Li, Tong N wrote: I don't know if we've discussed this or not. Since both CFS and SD claim to be fair, I'd like to hear more opinions on the fairness aspect of these designs. In areas such as OS, networking, and real-time, fairness, and its more

Re: [patch 2/7] genhd: expose AN to user space

2007-04-24 Thread Kristen Carlson Accardi
Allow user space to determine if a disk supports Asynchronous Notification of media changes. This is done by adding a new sysfs file capability_flags, which is documented in (insert file name). This sysfs file will export all disk capabilities flags to user space. We also define a new flag to

Re: [Intel IOMMU][patch 8/8] Preserve some Virtual Address when devices cannot address entire range.

2007-04-24 Thread Roland Dreier
My suggestion would be to allocate top-down in the 32-bit IOMMU space. I think that's good for normal things, but it's not unreasonable to want to map 4 GB of memory at once for an Infiniband device. So maybe we would want some heuristics about the size of the mapping being requested or the

Re: [patch 1/4] Ignore stolen time in the softlockup watchdog

2007-04-24 Thread Daniel Walker
On Tue, 2007-04-24 at 23:20 +0200, Andi Kleen wrote: On Tuesday 24 April 2007 22:52:27 Daniel Walker wrote: On Tue, 2007-04-24 at 13:24 -0700, Jeremy Fitzhardinge wrote: And sched_clock's use of local_irq_save/restore appears to be absolutely correct, so I think it must be triggering a

Re: [patch 5/7] genhd: send async notification on media change

2007-04-24 Thread Kristen Carlson Accardi
Send an uevent to user space to indicate that a media change event has occurred. Changes from last version: * use get/put_device to increment reference count on the device struct Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] Index: 2.6-git/block/genhd.c

Re: [Intel IOMMU][patch 8/8] Preserve some Virtual Address when devices cannot address entire range.

2007-04-24 Thread Ashok Raj
On Tue, Apr 24, 2007 at 02:23:51PM -0700, David Miller wrote: From: Andi Kleen [EMAIL PROTECTED] Date: Tue, 24 Apr 2007 23:12:54 +0200 We already have a couple of other IOMMU architectures who essentially have the same problem. Have you checked how they solve this? Sparc64, for one,

Re: [patch 7/7] libata: send event when AN received

2007-04-24 Thread Kristen Carlson Accardi
When we get an SDB FIS with the 'N' bit set, we should send an event to user space to indicate that there has been a media change. This will be done via the block device. changed from last version: * Make sure that port_addr is within ATA_MAX_DEVICES Signed-off-by: Kristen Carlson Accardi

Re: [Intel IOMMU][patch 8/8] Preserve some Virtual Address when devices cannot address entire range.

2007-04-24 Thread David Miller
From: Roland Dreier [EMAIL PROTECTED] Date: Tue, 24 Apr 2007 14:32:42 -0700 My suggestion would be to allocate top-down in the 32-bit IOMMU space. I think that's good for normal things, but it's not unreasonable to want to map 4 GB of memory at once for an Infiniband device. That's what

Re: [Intel IOMMU][patch 8/8] Preserve some Virtual Address when devices cannot address entire range.

2007-04-24 Thread David Miller
From: Ashok Raj [EMAIL PROTECTED] Date: Tue, 24 Apr 2007 14:38:35 -0700 Its not clear if we have a very generic device breakage.. most devices on these platforms are going to be more recent, (except maybe some legacy fd)... I'm not so sure, there are some modern sound cards that have a

[PATCH] cancel_delayed_work: use del_timer() instead of del_timer_sync()

2007-04-24 Thread Oleg Nesterov
del_timer_sync() buys nothing for cancel_delayed_work(), but it is less efficient since it locks the timer unconditionally, and may wait for the completion of the delayed_work_timer_fn(). cancel_delayed_work() == 0 means: before this patch: work-func may still be running

Re: [RFC][PATCH] ChunkFS: fs fission for faster fsck

2007-04-24 Thread Amit Gud
Nikita Danilov wrote: Maybe I failed to describe the problem presicely. Suppose that all chunks have been checked. After that, for every inode I0 having continuations I1, I2, ... In, one has to check that every logical block is presented in at most one of these inodes. For this one has to read

old ISA DMA bug in 2.6.12?

2007-04-24 Thread Bob Tracy
I was enjoying yet another session of beating my head against the wall trying to do useful things with old hardware :-), and managed to cause a kernel panic by simply trying to mount a cdrom in the context of a DSL-N installation. The SCSI host adapter is an Adaptec AHA-1542B, and when I try to

Re: [Intel IOMMU][patch 8/8] Preserve some Virtual Address when devices cannot address entire range.

2007-04-24 Thread Andi Kleen
On Tuesday 24 April 2007 23:50:26 David Miller wrote: From: Ashok Raj [EMAIL PROTECTED] Date: Tue, 24 Apr 2007 14:38:35 -0700 Its not clear if we have a very generic device breakage.. most devices on these platforms are going to be more recent, (except maybe some legacy fd)... I'm

Re: [RFC] [PATCH] cpufreq: allow full selection of default governors

2007-04-24 Thread Nish Aravamudan
On 4/24/07, Dave Jones [EMAIL PROTECTED] wrote: On Tue, Apr 24, 2007 at 09:03:23PM +, William Heimbigner wrote: The following patches should allow selection of conservative, powersave, and ondemand in the kernel configuration. This has been rejected several times already. Ondemand and

Re: [ANNOUNCE] UidBind LSM 0.2

2007-04-24 Thread Gerhard Mack
On Tue, 24 Apr 2007, Casey Schaufler wrote: --- Gerhard Mack [EMAIL PROTECTED] wrote: On Tue, 24 Apr 2007, Roberto De Ioris wrote: Hi all, this is the second release for UidBind LSM: http://projects.unbit.it/uidbind/ UidBind allows call to bind() function only to

Re: [REPORT] cfs-v4 vs sd-0.44

2007-04-24 Thread Bernd Eckenfels
In article [EMAIL PROTECTED] you wrote: Could you explain for the audience the technical definition of fairness and what sorts of error metrics are commonly used? There seems to be some disagreement, and you're neutral enough of an observer that your statement would help. And while we are at

[02/17] Fix page allocation flags in grow_dev_page()

2007-04-24 Thread clameter
Grow dev page simply passes GFP_NOFS to find_or_create_page. This means the allocation of radix tree nodes is done with GFP_NOFS and the allocation of a new page is done using GFP_NOFS. The mapping has a flags field that contains the necessary allocation flags for the page cache allocation. These

[03/17] Fix: find_or_create_page does not spread memory.

2007-04-24 Thread clameter
The find_or_create function calls alloc_page with the gfp_mask passed to it which is derived from the mappings gfp mask. So the allocation flags are right (assuming my bugfix to fs/buffer.c is applied). However, we call a alloc_page instead of page_cache_alloc in find_or_create_page. This means

[10/17] Variable Order Page Cache: Add clearing and flushing function

2007-04-24 Thread clameter
Add a flushing and clearing function for higher order pages. These are provisional and will likely have to be optimized. Signed-off-by: Christoph Lameter [EMAIL PROTECTED] --- fs/libfs.c |4 ++-- include/linux/highmem.h | 12 include/linux/pagemap.h | 25

[09/17] Convert PAGE_CACHE_xxx - page_cache_xxx function calls

2007-04-24 Thread clameter
This transforms the page cache code to use page_cache_xxx calls. Patch could be more complete. Signed-off-by: Christoph Lameter [EMAIL PROTECTED] --- fs/buffer.c | 99 +--- fs/libfs.c | 13 +++-- fs/mpage.c

[08/17] Define functions for page cache handling

2007-04-24 Thread clameter
We use the macros PAGE_CACHE_SIZE PAGE_CACHE_SHIFT PAGE_CACHE_MASK and PAGE_CACHE_ALIGN in various places in the kernel. These are useful if one only want to support one page size in the page cache. This patch provides a set of functions in order to provide the ability to define new page size in

[06/17] Fix up handling of Compound head pages

2007-04-24 Thread clameter
Compound pages can be on the LRU. This means that the page pointer to the head page is on a pagevec. In that case we need full LRU processing for the page in release_pages(). The check for compound pages in release_pages() was introduced by Nick Piggin to make sure that the page count in tail

[07/17] vmstat.c: Support accounting for compound pages

2007-04-24 Thread clameter
Compound pages must increment the counters in terms of base pages. If we detect a compound page then add the number of base pages that a compound page has to the counter. This will avoid numerous changes in the VM to fix up page accounting as we add more support for compound pages. Also fix up

[05/17] More compound page features

2007-04-24 Thread clameter
Add a couple of more compound functions to avoid having to duplicate code in various places. Signed-off-by: Christoph Lameter [EMAIL PROTECTED] --- include/linux/mm.h | 15 +++ 1 file changed, 15 insertions(+) Index: linux-2.6.21-rc7/include/linux/mm.h

[04/17] Free up page-private for compound pages

2007-04-24 Thread clameter
If we add a new flag so that we can distinguish between the first page and the tail pages then we can avoid to use page-private in the first page. page-private == page for the first page, so there is no real information in there. Freeing up page-private makes the use of compound pages more

Re: suspend2 merge (was Re: [Suspend2-devel] Re: CFS and suspend2: hang in atomic copy)

2007-04-24 Thread Ray Lee
On 4/24/07, Pavel Machek [EMAIL PROTECTED] wrote: so, while it's probably apples to oranges, uswsusp seems to be larger, while there's at least one feature that it is missing. (We are talking save 100% memory here). As I said, that one feature is doable in uswsusp, too. It is 200 lines. It

[01/17] Remove open coded implementation of memclear_highpage flush

2007-04-24 Thread clameter
There are a series of open coded reimplementation of memclear_highpage_flush all over the page cache code. Call memclear_highpage_flush in those locations. Consolidates code and eases maintenance. [There seems to be a better patch in mm. This patch here is just to make things work against 2.6.21

[00/17] Large Blocksize Support V3

2007-04-24 Thread clameter
V2-V3 - More restructuring - It actually works! - Add XFS support - Fix up UP support - Work out the direct I/O issues - Add CONFIG_LARGE_BLOCKSIZE. Off by default which makes the inlines revert back to constants. Disabled for 32bit and HIGHMEM configurations. This also allows a gradual

[17/17] xfs: Variable order page cache support

2007-04-24 Thread clameter
From: David Chinner [EMAIL PROTECTED] Patch is attached that converts the XFS data path to use large order page cache pages. I haven't tested this on a real system yet but it works on UML. I've tested it with fsx and it seems to do everything it is supposed to. Data is actually written to the

[16/17] ext2: Variable order page cache support

2007-04-24 Thread clameter
This adds variable page size support. It is then possible to mount filesystems that have a larger blocksize than the page size. F.e. the following is possible on x86_64 and i386 that have only a 4k page size. mke2fs -b 16384 /dev/hdd2 Ignore warning about too large block size mount

[11/17] Readahead support for the variable order page cache

2007-04-24 Thread clameter
Readahead is now dependent on the page size. For larger page sizes we want less readahead. Add a parameter to max_sane_readahead specifying the page order and update the code in mm/readahead.c to be aware of variant page sizes. Mark the 2M readahead constant as a potential future problem.

[12/17] Variable Page Cache Size: Fix up reclaim counters

2007-04-24 Thread clameter
We can now reclaim larger pages. Adjust the VM counters to deal with it. Signed-off-by: Christoph Lameter [EMAIL PROTECTED] --- mm/vmscan.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) Index: linux-2.6.21-rc7/mm/vmscan.c

[13/17] set_blocksize: Allow to set a larger block size than PAGE_SIZE

2007-04-24 Thread clameter
set_blocksize is changed to allow to specify a blocksize larger than a page. If that occurs then we switch the device to use compound pages. Signed-off-by: Christoph Lameter [EMAIL PROTECTED] --- fs/block_dev.c | 22 +++--- fs/buffer.c|2 +- fs/inode.c |5 +

[14/17] Add VM_BUG_ONs to check for correct page order

2007-04-24 Thread clameter
Before we start changing the page order we better get some debugging in there that trips us up whenever a wrong order page shows up in a mapping. This will be helpful for converting new filesystems to utilize higher orders. Signed-off-by: Christoph Lameter [EMAIL PROTECTED] --- mm/filemap.c |

[15/17] ramfs: Variable order page cache support

2007-04-24 Thread clameter
The simplest file system to use is ramfs. Add a mount parameter that specifies the page order of the pages that ramfs should use. If the order is greater than zero then disable mmap functionality. This could be removed if the VM would be changes to support faulting higher order pages but for now

Re: [Intel IOMMU][patch 8/8] Preserve some Virtual Address when devices cannot address entire range.

2007-04-24 Thread Ashok Raj
On Wed, Apr 25, 2007 at 12:03:57AM +0200, Andi Kleen wrote: On Tuesday 24 April 2007 23:50:26 David Miller wrote: From: Ashok Raj [EMAIL PROTECTED] Date: Tue, 24 Apr 2007 14:38:35 -0700 Its not clear if we have a very generic device breakage.. most devices on these platforms are

Re: [RFC] [PATCH] cpufreq: allow full selection of default governors

2007-04-24 Thread William Heimbigner
On Tue, 24 Apr 2007, Dave Jones wrote: On Tue, Apr 24, 2007 at 09:03:23PM +, William Heimbigner wrote: The following patches should allow selection of conservative, powersave, and ondemand in the kernel configuration. This has been rejected several times already. Ondemand and conservative

Re: SMP lockup in virtualized environment

2007-04-24 Thread Chris Snook
LAPLACE Cyprien wrote: An example: in kernel/pid.c:alloc_pid(), if one of the guest CPUs is descheduled when holding the pidmap_lock, what happens to the other guest CPUs who want to alloc/free pids ? Are they blocked too ? Yup. This is where it's really nice to have directed yields, where

[PATCH] ohci1394: Fix mistake in printk message.

2007-04-24 Thread Simon Arlott
Fix the attempting to setting message in ohci1394. Signed-off-by: Simon Arlott [EMAIL PROTECTED] --- drivers/ieee1394/ohci1394.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/ieee1394/ohci1394.c b/drivers/ieee1394/ohci1394.c index 628130a..107b272 100644 ---

Re: [08/17] Define functions for page cache handling

2007-04-24 Thread Eric Dumazet
[EMAIL PROTECTED] a écrit : --- linux-2.6.21-rc7.orig/include/linux/fs.h2007-04-24 11:31:49.0 -0700 +++ linux-2.6.21-rc7/include/linux/fs.h 2007-04-24 11:37:21.0 -0700 @@ -435,6 +435,11 @@ struct address_space { struct inode*host; /* owner:

Re: [RFC 4/8] Enhance fallback functions in libs to support higher order pages

2007-04-24 Thread Matt Mackall
On Fri, Apr 20, 2007 at 12:10:43PM -0700, Christoph Lameter wrote: On Fri, 20 Apr 2007, Dave Kleikamp wrote: On Fri, 2007-04-20 at 12:05 +0100, Mel Gorman wrote: comments about missing page_cache_size() covered elsewhere. However, I note that Dave Kleikamp might be interested in this

Re: [Intel IOMMU][patch 8/8] Preserve some Virtual Address when devices cannot address entire range.

2007-04-24 Thread Alan Cox
On Tue, 24 Apr 2007 14:50:26 -0700 (PDT) David Miller [EMAIL PROTECTED] wrote: From: Ashok Raj [EMAIL PROTECTED] Date: Tue, 24 Apr 2007 14:38:35 -0700 Its not clear if we have a very generic device breakage.. most devices on these platforms are going to be more recent, (except maybe some

MontaVista spam

2007-04-24 Thread Pavel Roskin
Mr Ready, If you want to invite Linux kernel developers to your webinar, please ask your secretary to send individual invitations. I'm sure you can do it as the CTO of MontaVista Software. Please don't pay spammers. Nobody likes them, especially those who are subjected to spam as a result of

<    1   2   3   4   5   6   7   8   9   10   >