Re: [PATCH] Fix a bad bug in read_cache_page_async()

2007-05-09 Thread David Howells
Glauber de Oliveira Costa <[EMAIL PROTECTED]> wrote: > any reason for not simply returning page here? Not particularly. David - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [patch 3/3] clockevents: Fix resume logic - updated version

2007-05-09 Thread Thomas Gleixner
On Wed, 2007-05-09 at 13:45 +0200, Rafael J. Wysocki wrote: > On Wednesday, 9 May 2007 10:59, Thomas Gleixner wrote: > > On Wed, 2007-05-09 at 01:31 -0700, Andrew Morton wrote: > > > > I suspect I just tested the wrong thing yesterday. Let me recheck just > > > > these patches against 2.6.21. > >

Re: [PATCH] Fix a bad bug in read_cache_page_async()

2007-05-09 Thread Nick Piggin
On Wed, May 09, 2007 at 01:02:01PM +0100, David Howells wrote: > Fix a bad bug in read_cache_page_async() introduced in commit: > > 6fe6900e1e5b6fa9e5c59aa5061f244fe3f467e2 > > This adds: > > mark_page_accessed(page) > > into the error handling path in read_cache_page_async(). In

Re: [rfc] lock bitops

2007-05-09 Thread Nick Piggin
On Wed, May 09, 2007 at 04:08:41PM +0400, Nikita Danilov wrote: > Nick Piggin writes: > > Hi, > > [...] > > > > > /** > > + * clear_bit_unlock - Clears a bit in memory with release > > + * @nr: Bit to clear > > + * @addr: Address to start counting from > > + * > > + * clear_bit() is

Re: [patch 128/197] freezer: add try_to_freeze calls to all kernel threads

2007-05-09 Thread Gautham R Shenoy
Hi Stefan, On Wed, May 09, 2007 at 02:06:05PM +0200, Stefan Richter wrote: > Pavel Machek wrote: > >> > Add try_to_freeze() calls to the remaining kernel threads that do not > >> > call > >> > try_to_freeze() already, although they set PF_NOFREEZE. > >> > > >> > In the future we are going to

Re: [patch 2/9] lguest: the guest code

2007-05-09 Thread Pekka Enberg
Hi Rusty, On 5/9/07, Rusty Russell <[EMAIL PROTECTED]> wrote: Hmm, where would the error go? Let it propagate: scan_devices -> lguest_bus_init -> do_initcalls. We probably don't want to panic() if bus_register and device_register fail there either. - To unsubscribe from this list:

Re: [PATCH 2/2] leds:arch/sh/boards/landisk LEDs supports

2007-05-09 Thread Richard Purdie
On Wed, 2007-05-09 at 20:42 +0900, kogiidena wrote: > >As far as I can tell, the existing timer trigger can do everything the > >blink trigger can (and more besides). > I want to blink LED in the initial state. Are you after to set that per LED or would some standard configurable default for all

Re: [patch 7/9] lguest: the net driver

2007-05-09 Thread Rusty Russell
On Wed, 2007-05-09 at 22:00 +1000, Herbert Xu wrote: > Hi Rusty: > > On Wed, May 09, 2007 at 09:55:25PM +1000, Rusty Russell wrote: > > > > NO_CSUM because it really doesn't need a checksum. The > > LGUEST_NET_F_NOCSUM is only set for local inter-guest networking. If > > some guest were to

Re: [rfc] lock bitops

2007-05-09 Thread Nikita Danilov
Nick Piggin writes: > Hi, [...] > > /** > + * clear_bit_unlock - Clears a bit in memory with release > + * @nr: Bit to clear > + * @addr: Address to start counting from > + * > + * clear_bit() is atomic and may not be reordered. It does s/clear_bit/clear_bit_unlock/ ? > + *

Re: [PATCH 1/5] fallocate() implementation in i86, x86_64 and powerpc

2007-05-09 Thread Amit K. Arora
On Wed, May 09, 2007 at 09:37:22PM +1000, Paul Mackerras wrote: > Suparna Bhattacharya writes: > > > > Of course the interface used by an application program would have the > > > fd first. Glibc can do the translation. > > > > I think that was understood. > > OK, then what does it matter what

Re: [patch 128/197] freezer: add try_to_freeze calls to all kernel threads

2007-05-09 Thread Stefan Richter
Pavel Machek wrote: >> > Add try_to_freeze() calls to the remaining kernel threads that do not call >> > try_to_freeze() already, although they set PF_NOFREEZE. >> > >> > In the future we are going to replace PF_NOFREEZE with a set of flags that >> > will be set to indicate in which situations

Re: [PATCH] Fix a bad bug in read_cache_page_async()

2007-05-09 Thread Glauber de Oliveira Costa
page = __read_cache_page(mapping, index, filler, data); if (IS_ERR(page)) - goto out; + goto error; any reason for not simply returning page here? page = ERR_PTR(err); + goto error; same -- Glauber de Oliveira Costa.

Re: Fwd: [ASoC] Mic record is not working with wm9713 ASoC driver

2007-05-09 Thread Liam Girdwood
It's probably best to keep this thread on alsa-dev otherwise things start to get confusing when cross posting occurs. Liam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at

[KJ PATCH] Replacing alloc_pages(gfp,0) with alloc_page(gfp) in arch/i386/mm/pgtable.c.

2007-05-09 Thread Shani Moideen
Hi, Replacing alloc_pages(gfp,0) with alloc_page(gfp) in arch/i386/mm/pgtable.c. Signed-off-by: Shani Moideen <[EMAIL PROTECTED]> diff --git a/arch/i386/mm/pgtable.c b/arch/i386/mm/pgtable.c index fa0cfbd..5d2b0fb 100644 --- a/arch/i386/mm/pgtable.c +++ b/arch/i386/mm/pgtable.c @@ -191,9

[PATCH] Fix a bad bug in read_cache_page_async()

2007-05-09 Thread David Howells
Fix a bad bug in read_cache_page_async() introduced in commit: 6fe6900e1e5b6fa9e5c59aa5061f244fe3f467e2 This adds: mark_page_accessed(page) into the error handling path in read_cache_page_async(). In such a case, 'page' holds the error code. Signed-off-by: David Howells

Re: [patch 7/9] lguest: the net driver

2007-05-09 Thread Herbert Xu
Hi Rusty: On Wed, May 09, 2007 at 09:55:25PM +1000, Rusty Russell wrote: > > NO_CSUM because it really doesn't need a checksum. The > LGUEST_NET_F_NOCSUM is only set for local inter-guest networking. If > some guest were to route the packets outside the machine, this would be > an issue,

Re: [PATCH 1/5] fallocate() implementation in i86, x86_64 and powerpc

2007-05-09 Thread Martin Schwidefsky
On 5/9/07, Paul Mackerras <[EMAIL PROTECTED]> wrote: Suparna Bhattacharya writes: > > Of course the interface used by an application program would have the > > fd first. Glibc can do the translation. > > I think that was understood. OK, then what does it matter what the glibc/kernel interface

[PATCH 2/3] rtc:rtc-rs5c313.c : rtc_time value are fixed.

2007-05-09 Thread kogiidena
The following patch is a patch that corrects an initial value of suruct rtc_ time. please apply. Signed-off-by: kogiidena <[EMAIL PROTECTED]> --- diff -urpN OLD/drivers/rtc/rtc-rs5c313.c NEW/drivers/rtc/rtc-rs5c313.c --- OLD/drivers/rtc/rtc-rs5c313.c 2007-05-08 19:42:05.0 +0900 +++

[PATCH 3/3] rtc:rtc-rs5c313.c : add error handling toavoidhardware hangup.

2007-05-09 Thread kogiidena
It is a patch that adds error processing. Hanging up by an infinite loop is evaded. Please apply. Signed-off-by: kogiidena <[EMAIL PROTECTED]> --- diff -urpN OLD/drivers/rtc/rtc-rs5c313.c NEW/drivers/rtc/rtc-rs5c313.c --- OLD/drivers/rtc/rtc-rs5c313.c 2007-05-08 19:52:11.0 +0900 +++

Re: [SOLVED] Serial buffer corruption [was Re: FTDI usb-serial possible bug]

2007-05-09 Thread Gene Heskett
On Saturday 05 May 2007, Oliver Neukum wrote: You are included this time David because 3 messages I posted this morning, whose text should resemble this one, the first of those 3, were also /dev/nulled. this is BS when I can't even discuss a patch in the same manner as others can. So whats

[KJ PATCH] Replacing alloc_pages(gfp,0) with alloc_page(gfp) in arch/i386/mm/pageattr.c.

2007-05-09 Thread Shani Moideen
Hi, Replacing alloc_pages(gfp,0) with alloc_page(gfp) in arch/i386/mm/pageattr.c. Signed-off-by: Shani Moideen <[EMAIL PROTECTED]> diff --git a/arch/i386/mm/pageattr.c b/arch/i386/mm/pageattr.c index 412ebbd..12f7f14 100644 --- a/arch/i386/mm/pageattr.c +++ b/arch/i386/mm/pageattr.c @@

[PATCH 1/3] rtc:rtc-rs5c313.c : error and warning are fixed.

2007-05-09 Thread kogiidena
The following patch is a patch that corrects the compile error and warning. Please apply. Signed-off-by: kogiidena <[EMAIL PROTECTED]> --- diff -urpN OLD/drivers/rtc/Kconfig NEW/drivers/rtc/Kconfig --- OLD/drivers/rtc/Kconfig 2007-05-07 12:12:02.0 +0900 +++ NEW/drivers/rtc/Kconfig

Re: [patch 2/9] lguest: the guest code

2007-05-09 Thread Rusty Russell
On Wed, 2007-05-09 at 13:16 +0300, Pekka Enberg wrote: > Hi Rusty, > > On 5/9/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > > +static void add_lguest_device(unsigned int index) > > +{ > > + struct lguest_device *new; > > + > > + lguest_devices[index].status |=

Re: [patch 7/9] lguest: the net driver

2007-05-09 Thread Rusty Russell
On Wed, 2007-05-09 at 20:12 +1000, Herbert Xu wrote: > [EMAIL PROTECTED] wrote: > > > > + if (desc->features & LGUEST_NET_F_NOCSUM) > > + dev->features |= NETIF_F_NO_CSUM; > > Any reason why you're using NO_CSUM here instead of HW_CSUM? > Practically there is no difference but

[PATCH 6/6] IB/ehca: disable scaling code by default, bump version number

2007-05-09 Thread Joachim Fenkes
- Scaling code is still considered experimental, so disable it by default - Increase version to SVNEHCA_0023 Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]> --- drivers/infiniband/hw/ehca/ehca_main.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 4/6] IB/ehca: remove _irqsave, move #ifdef

2007-05-09 Thread Joachim Fenkes
- In ehca_process_eq(), we're IRQ safe throughout the whole function, so we don't need another _irqsave in the middle of flight. - take_over_work() is only called by comp_pool_callback(), so it can move into the same #ifdef block. Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]> ---

[PATCH 3/6] IB/ehca: Fix AQP0/1 QP number

2007-05-09 Thread Joachim Fenkes
From: Hoang-Nam Nguyen <[EMAIL PROTECTED]> AQP0/1 should report qp_num={0|1} and the actual QP# should be stored in struct ehca_qp, not the other way round. Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]> --- drivers/infiniband/hw/ehca/ehca_qp.c |5 +++-- 1 files changed, 3 insertions(+),

[PATCH 1/6] IB/ehca: Serialize hypervisor calls in ehca_register_mr()

2007-05-09 Thread Joachim Fenkes
From: Stefan Roscher <[EMAIL PROTECTED]> Some pSeries hypervisor versions show a race condition in the allocate MR hCall. Serialize this call per adapter to circumvent this problem. Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]> --- drivers/infiniband/hw/ehca/ehca_classes.h |1 +

[PATCH 5/6] IB/ehca: beautify sysfs attribute code, fix compiler warnings

2007-05-09 Thread Joachim Fenkes
eHCA's sysfs attributes are now being created via sysfs_create_group(), making the process neatly table-driven. The return value is checked, thus fixing a few compiler warnings. Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]> --- drivers/infiniband/hw/ehca/ehca_main.c | 86

[PATCH 2/6] IB/ehca: correctly set GRH mask bit in ehca_modify_qp()

2007-05-09 Thread Joachim Fenkes
The driver needs to always supply the "GRH present" flag to the hypervisor, whether it's true or false. Not supplying it (i.e. not setting the corresponding mask bit) amounts to a "perhaps", which we don't want. Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]> ---

Re: [PATCH 2/2] leds:arch/sh/boards/landisk LEDs supports

2007-05-09 Thread kogiidena
Hi Richard-san >As far as I can tell, the existing timer trigger can do everything the >blink trigger can (and more besides). I want to blink LED in the initial state. Because that of "the existing timer trigger" was impossible, I made "BLINK". I thought about another solution. Can the change

Re: [patch 3/3] clockevents: Fix resume logic - updated version

2007-05-09 Thread Rafael J. Wysocki
On Wednesday, 9 May 2007 10:59, Thomas Gleixner wrote: > On Wed, 2007-05-09 at 01:31 -0700, Andrew Morton wrote: > > > I suspect I just tested the wrong thing yesterday. Let me recheck just > > > these patches against 2.6.21. > > > > yup, same hang with just these three: > > > > origin > >

Re: [PATCH 1/5] fallocate() implementation in i86, x86_64 and powerpc

2007-05-09 Thread Paul Mackerras
Suparna Bhattacharya writes: > > Of course the interface used by an application program would have the > > fd first. Glibc can do the translation. > > I think that was understood. OK, then what does it matter what the glibc/kernel interface is, as long as it works? It's only a minor point;

[PATCH] small cleanup in gpt partition handling

2007-05-09 Thread Olaf Hering
Remove unused argument in is_pmbr_valid() Remove unneeded initialization of local variable legacy_mbr Compile-tested. Signed-off-by: Olaf Hering <[EMAIL PROTECTED]> --- fs/partitions/efi.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) --- a/fs/partitions/efi.c +++

Re: [patch] CFS scheduler, -v10

2007-05-09 Thread Al Boldi
Ingo Molnar wrote: > > i'm pleased to announce release -v10 of the CFS scheduler patchset. > (The main goal of CFS is to implement "desktop scheduling" with as > high quality as technically possible.) Thanks! I like this one a lot. There is one workload that is still handled a bit strange,

Re: [patches] [PATCH] [21/22] x86_64: Extend bzImage protocol for relocatable bzImage

2007-05-09 Thread Eric W. Biederman
Gerd Hoffmann <[EMAIL PROTECTED]> writes: > Hi, > >> Since the whole point is to detect the case where we don't have >> a screen at all it makes sense to check several additional variables >> and make certain that they are all 0. Agreed? > > Like in the attached patch? Looks good to me. >

Re: [PATCH 0/9] Kconfig: cleanup s390 v2.

2007-05-09 Thread Martin Schwidefsky
On Mon, 2007-04-23 at 10:45 -0700, Andrew Morton wrote: > > Andrew: I plan to add patches 1-5 to the for-andrew branch of the > > git390 repository if that is fine with you. The only thing that will > > be missing in the tree is the patch that disables wireless for s390. > > The code does compile

[patch] Add the device IDs for A MD/ATI SB700

2007-05-09 Thread Henry Su
From: [EMAIL PROTECTED] Adding the device ID for AMD/ATI SB700. Signed-off-by:henry su <[EMAIL PROTECTED]> -- --- linux-2.6.21.1.orig/include/linux/pci_ids.h 2007-05-10 06:30:23.0 +0800 +++ linux-2.6.21.1/include/linux/pci_ids.h 2007-05-10

Re: [PATCH 1/5] fallocate() implementation in i86, x86_64 and powerpc

2007-05-09 Thread Suparna Bhattacharya
On Wed, May 09, 2007 at 08:50:44PM +1000, Paul Mackerras wrote: > Suparna Bhattacharya writes: > > > > This looks like it will have the same problem on s390 as > > > sys_sync_file_range. Maybe the prototype should be: > > > > > > asmlinkage long sys_fallocate(loff_t offset, loff_t len, int fd,

Re: nbd problem.

2007-05-09 Thread Rogier Wolff
On Tue, May 08, 2007 at 01:33:52PM -0700, Satyam Sharma wrote: > On 5/8/07, Rogier Wolff <[EMAIL PROTECTED]> wrote: > > > >Hi, > > > >The nbd client still reliably hangs when I use it. Someone suggested to use http://git.kernel.org/?p=linux/kernel/git/axboe/linux-2.6-block.git;a=summary and

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS

2007-05-09 Thread Lennert Buytenhek
On Wed, May 09, 2007 at 12:35:40PM +0200, Mikael Pettersson wrote: > > > Does that mean that the Debian ARM people have their heads so far > > > up their collective asses that they think that every form of change > > > is bad and are unable to accept that some forms of change might be > > > for

Re: [PATCH 3/3] AFS: Implement basic file write support

2007-05-09 Thread David Howells
Andrew Morton <[EMAIL PROTECTED]> wrote: > set_page_dirty() will set I_DIRTY_PAGES only. ie: the inode has dirty > pagecache data. > > To tell the VFS that the inode itself is dirty one needs to run > mark_inode_dirty(). But what's the difference in this case? I don't need to write the inode

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS

2007-05-09 Thread Lennert Buytenhek
On Wed, May 09, 2007 at 11:35:03AM +0200, Marcus Better wrote: > > Does that mean that the Debian ARM people have their heads so far > > up their collective asses that they think that every form of change > > is bad and are unable to accept that some forms of change might be > > for the better? >

Re: [SOLVED] Serial buffer corruption [was Re: FTDI usb-serial possible bug]

2007-05-09 Thread Gene Heskett
On Saturday 05 May 2007, Oliver Neukum wrote: >Am Samstag, 5. Mai 2007 20:08 schrieb Antonino Ingargiola: >> Now I don't want to abuse your kindness, but I (personally) would be >> *really* interested in a similar fix for the FTDI usb-serial driver, >> because many measurements I do use an FTDI

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS

2007-05-09 Thread Tomasz Chmielewski
On Wed, 9 May 2007 11:35:03 +0200, Marcus Better wrote: Lennert Buytenhek wrote: > Does that mean that the Debian ARM people have their heads so far > up their collective asses that they think that every form of change > is bad and are unable to accept that some forms of change might be > for

Fwd: [ASoC] Mic record is not working with wm9713 ASoC driver

2007-05-09 Thread Nobin Mathew
-- Forwarded message -- From: Nobin Mathew <[EMAIL PROTECTED]> Date: May 9, 2007 4:25 PM Subject: Re: [ASoC] Mic record is not working with wm9713 ASoC driver To: Liam Girdwood <[EMAIL PROTECTED]> Liam i got the mail. I am not setting any audio paths in my machine driver On

Re: [patch 8/9] lguest: the block driver

2007-05-09 Thread Jens Axboe
On Wed, May 09 2007, Pekka J Enberg wrote: > On Wed, 9 May 2007, Jens Axboe wrote: > > Lets do it after it is merged, as not to create a hold-up point for > > lguest. Once it's in, I'll fix it up. > > Ok. Seems pointless, though, as it's only a matter of: Yes I'm very well aware of that, my

Re: [patches] [PATCH] [21/22] x86_64: Extend bzImage protocol for relocatable bzImage

2007-05-09 Thread Eric W. Biederman
"H. Peter Anvin" <[EMAIL PROTECTED]> writes: > yhlu wrote: >> so the kexec tools need to scan the pci devices list, and find out how >> to set real_mode.isVGA and orig_video_mode, also need to parse the >> comand line about vga console. > > BTW, welcome to the hell of bypassing setup. Well in

Re: [PATCH 1/5] fallocate() implementation in i86, x86_64 and powerpc

2007-05-09 Thread Paul Mackerras
Suparna Bhattacharya writes: > > This looks like it will have the same problem on s390 as > > sys_sync_file_range. Maybe the prototype should be: > > > > asmlinkage long sys_fallocate(loff_t offset, loff_t len, int fd, int mode) > > Yes, but the trouble is that there was a contrary viewpoint

Re: 2.6.21-mm2 -- Compile error : include/linux/power_supply.h:125: error: field ‘changed_work’ has incomplete type

2007-05-09 Thread Anton Vorontsov
On Wed, May 09, 2007 at 03:43:34AM -0700, Miles Lane wrote: > CC drivers/power/power_supply_core.o > In file included from drivers/power/power_supply_core.c:18: > include/linux/power_supply.h:125: error: field 'changed_work' has > incomplete type > drivers/power/power_supply_core.c: In

Re: [patch 128/197] freezer: add try_to_freeze calls to all kernel threads

2007-05-09 Thread Pavel Machek
Hi! > > Add try_to_freeze() calls to the remaining kernel threads that do not call > > try_to_freeze() already, although they set PF_NOFREEZE. > > > > In the future we are going to replace PF_NOFREEZE with a set of flags that > > will be set to indicate in which situations the task should not be

Re: [ASoC] Mic record is not working with wm9713 ASoC driver

2007-05-09 Thread Liam Girdwood
On Wed, 2007-05-09 at 14:48 +0530, Nobin Mathew wrote: > I am trying to record mic with AsoC wm9713 driver. My Mic is connected "Mic > 1". I've replied to this duplicate post on alsa-dev. Liam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [ASoC] Mic record is not working with wm9713 ASoC driver

2007-05-09 Thread Nobin Mathew
Liam Sorry for disturbing you again, I could not find that reply on alsa devel mailing list Can u send that to me Thanks On 5/9/07, Liam Girdwood <[EMAIL PROTECTED]> wrote: On Wed, 2007-05-09 at 14:48 +0530, Nobin Mathew wrote: > I am trying to record mic with AsoC wm9713 driver. My Mic is

Re: [patch 128/197] freezer: add try_to_freeze calls to all kernel threads

2007-05-09 Thread Stefan Richter
[EMAIL PROTECTED] wrote: > From: Rafael J. Wysocki <[EMAIL PROTECTED]> > > Add try_to_freeze() calls to the remaining kernel threads that do not call > try_to_freeze() already, although they set PF_NOFREEZE. > > In the future we are going to replace PF_NOFREEZE with a set of flags that > will be

Re: [patch 8/9] lguest: the block driver

2007-05-09 Thread Pekka J Enberg
On Wed, 9 May 2007, Jens Axboe wrote: > Lets do it after it is merged, as not to create a hold-up point for > lguest. Once it's in, I'll fix it up. Ok. Seems pointless, though, as it's only a matter of: Pekka From: Jens Axboe <[EMAIL PROTECTED]> Add a new

Re: [SOLVED] Serial buffer corruption [was Re: FTDI usb-serial possible bug]

2007-05-09 Thread Gene Heskett
On Saturday 05 May 2007, Oliver Neukum wrote: >Am Samstag, 5. Mai 2007 20:08 schrieb Antonino Ingargiola: >> Now I don't want to abuse your kindness, but I (personally) would be >> *really* interested in a similar fix for the FTDI usb-serial driver, >> because many measurements I do use an FTDI

Re: 2.6.21-mm2 -- Compile error: include/linux/power_supply.h:125: error: field ‘changed_work’ has incomplete type

2007-05-09 Thread Miles Lane
CC drivers/power/power_supply_core.o In file included from drivers/power/power_supply_core.c:18: include/linux/power_supply.h:125: error: field 'changed_work' has incomplete type drivers/power/power_supply_core.c: In function 'power_supply_changed_work':

Re: [PATCH 3/3] AFS: Implement basic file write support

2007-05-09 Thread Andrew Morton
On Wed, 09 May 2007 11:25:47 +0100 David Howells <[EMAIL PROTECTED]> wrote: > > > + set_page_dirty(page); > > > + > > > + if (PageDirty(page)) > > > + _debug("dirtied"); > > > + > > > + return 0; > > > +} > > > > One would normally run mark_inode_dirty() after any i_size_write()? > >

Re: [2.6.21] kernel panic

2007-05-09 Thread folkert
Hi, > > OK, I think the patch below should solve this. I am pretty surprised > > though that this bug wasn't triggered/reported by anyone anytime sooner, > > it has been there for ages too (but ok, the race window should be pretty > > small and hiddev is usually not high-throughput interface).

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS

2007-05-09 Thread Mikael Pettersson
On Wed, 9 May 2007 11:35:03 +0200, Marcus Better wrote: > Lennert Buytenhek wrote: > > Does that mean that the Debian ARM people have their heads so far > > up their collective asses that they think that every form of change > > is bad and are unable to accept that some forms of change might be >

Re: [PATCH 7/10] i386 sg: add support for chaining scatterlists

2007-05-09 Thread Jens Axboe
On Wed, May 09 2007, Herbert Xu wrote: > Jens Axboe <[EMAIL PROTECTED]> wrote: > > > > diff --git a/include/asm-i386/scatterlist.h b/include/asm-i386/scatterlist.h > > index d7e45a8..794b68c 100644 > > --- a/include/asm-i386/scatterlist.h > > +++ b/include/asm-i386/scatterlist.h > > @@ -8,8 +8,11

Re: [patch 8/9] lguest: the block driver

2007-05-09 Thread Jens Axboe
On Wed, May 09 2007, Pekka Enberg wrote: > On 5/9/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > >+/* Jens gave me this nice helper to end all chunks of a request. */ > >+static void end_entire_request(struct request *req, int uptodate) > >+{ > >+ if (end_that_request_first(req,

Re: [PATCH 7/10] i386 sg: add support for chaining scatterlists

2007-05-09 Thread Jens Axboe
On Wed, May 09 2007, Andrew Morton wrote: > On Wed, 09 May 2007 20:03:29 +1000 Herbert Xu <[EMAIL PROTECTED]> wrote: > > > Jens Axboe <[EMAIL PROTECTED]> wrote: > > > > > > diff --git a/include/asm-i386/scatterlist.h > > > b/include/asm-i386/scatterlist.h > > > index d7e45a8..794b68c 100644 > >

Re: retry [PATCH] partition : add support for sysv68 partitions

2007-05-09 Thread Wouter Verhelst
On Tue, May 08, 2007 at 10:21:12PM +0200, Geert Uytterhoeven wrote: > Hi Philippe, > On Fri, 13 Apr 2007, Philippe De Muyter wrote: > > Add support for the Motorola sysv68 disk partition table (slices in motorola > > doc). > > > > Signed-off-by: Philippe De Muyter <[EMAIL PROTECTED]> > > >

Re: Long file names in VFAT broken with iocharset=utf8

2007-05-09 Thread Andrey Borzenkov
On Monday 07 May 2007, Roland Kuhn wrote: > Hi! > > On 7 May 2007, at 20:27, OGAWA Hirofumi wrote: > > Roland Kuhn <[EMAIL PROTECTED]> writes: > >> PATH_MAX specifically counts _bytes_ not characters, so UTF-8 does > >> not matter. ISTR that PATH_MAX was 256 at some point, but I just > >> quickly

Re: [GIT PATCHES] V4L/DVB updates

2007-05-09 Thread Mauro Carvalho Chehab
Hi Geert, Em Qua, 2007-05-09 às 08:30 +0200, Geert Uytterhoeven escreveu: > On Fri, 27 Apr 2007, Mauro Carvalho Chehab wrote: > > A short changelog: > > > >- New drivers: > > ivtv driver for Hauppauge PVR series and similar boards; > > Can we please have proper Kconfig dependencies

Re: [PATCH 1/2] LogFS proper

2007-05-09 Thread Jörn Engel
On Tue, 8 May 2007 17:01:01 -0700, Greg KH wrote: > On Wed, May 09, 2007 at 01:10:09AM +0200, J??rn Engel wrote: > > > > The remaining question is how to deal with kernel-only code that uses > > be64. Convert that to __be64 as well? Or introduce be64 in > > include/linix/types.h instead? > > I

Re: D-Link DFE-580TX 4 port NIC problems

2007-05-09 Thread Andrew Morton
On Wed, 9 May 2007 12:01:42 +0200 Mario Doering <[EMAIL PROTECTED]> wrote: > Hello, > > we have a D-Link DFE-580TX 4 port network card in our main router. > > It works pretty well most of the time, even though an error > message pops up in dmesg every now and then (sometimes once a day >

Re: [PATCH 3/3] AFS: Implement basic file write support

2007-05-09 Thread David Howells
Andrew Morton <[EMAIL PROTECTED]> wrote: > > + BUG_ON(i_size > 0x); // TODO: use 64-bit store > > You're sure this isn't user-triggerable? Hmmm... I'm not. I'll whip up a patch for this. > kmap_atomic() could be used here and is better. Yeah. It used to have something that slept

Re: [PATCH] doc: volatile considered evil

2007-05-09 Thread David Rientjes
On Wed, 9 May 2007, Alan Cox wrote: > When Might You Need volatile ? > -- > > When you are implementing the locking primitives on a new platform. When > you are implementing the I/O and atomic prmitives on a new platform. Also > in inline gcc assembler where

Re: [PATCH 7/10] i386 sg: add support for chaining scatterlists

2007-05-09 Thread Herbert Xu
On Wed, May 09, 2007 at 03:19:15AM -0700, Andrew Morton wrote: > > > BTW, the crypto layer's scatterlist already has a chaining mechanism > > using the existing structure. The only difference is that the chained > > pointer is stored inside the 'struct page *' rather than a new pointer. > > >

Re: [patch 7/9] lguest: the net driver

2007-05-09 Thread Herbert Xu
[EMAIL PROTECTED] wrote: > > + if (desc->features & LGUEST_NET_F_NOCSUM) > + dev->features |= NETIF_F_NO_CSUM; Any reason why you're using NO_CSUM here instead of HW_CSUM? Practically there is no difference but NO_CSUM could be treated differently in future and I'm not sure

Re: [patch 8/9] lguest: the block driver

2007-05-09 Thread Pekka Enberg
On 5/9/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: +/* Jens gave me this nice helper to end all chunks of a request. */ +static void end_entire_request(struct request *req, int uptodate) +{ + if (end_that_request_first(req, uptodate, req->hard_nr_sectors)) + BUG(); +

Re: [PATCH] Intel IXP4xx network drivers v.3 - QMGR

2007-05-09 Thread Lennert Buytenhek
On Tue, May 08, 2007 at 06:59:36PM +0200, Krzysztof Halasa wrote: > >> There may be up to 6 Ethernet ports (not sure about hardware > >> status, not yet supported even by Intel) - 7 queues * 128 entries > >> each = ~ 3.5 KB. Add 2 long queues (RX) for HSS and something > >> for TX, and then

Re: [ASoC] Mic record is not working with wm9713 ASoC driver

2007-05-09 Thread Andrew Morton
On Wed, 9 May 2007 14:48:54 +0530 "Nobin Mathew" <[EMAIL PROTECTED]> wrote: > I am trying to record mic with AsoC wm9713 driver. My Mic is connected "Mic > 1". > > My settings > > 'Mic A Source' -> "Mic 1" > 'Mic Boost (+20dB)' [on] > 'Capture' [on] > 'Left Capture Source' "Mic 1" > 'Right

Re: [2.6.21] kernel panic

2007-05-09 Thread Jiri Kosina
On Mon, 7 May 2007, Jiri Kosina wrote: > OK, I think the patch below should solve this. I am pretty surprised > though that this bug wasn't triggered/reported by anyone anytime sooner, > it has been there for ages too (but ok, the race window should be pretty > small and hiddev is usually not

Re: [PATCH 7/10] i386 sg: add support for chaining scatterlists

2007-05-09 Thread Andrew Morton
On Wed, 09 May 2007 20:03:29 +1000 Herbert Xu <[EMAIL PROTECTED]> wrote: > Jens Axboe <[EMAIL PROTECTED]> wrote: > > > > diff --git a/include/asm-i386/scatterlist.h b/include/asm-i386/scatterlist.h > > index d7e45a8..794b68c 100644 > > --- a/include/asm-i386/scatterlist.h > > +++

D-Link DFE-580TX 4 port NIC problems

2007-05-09 Thread Mario Doering
Hello, we have a D-Link DFE-580TX 4 port network card in our main router. It works pretty well most of the time, even though an error message pops up in dmesg every now and then (sometimes once a day sometimes once every few hours). But every few weeks those error messages increase rapidly,

Re: [patch 2/9] lguest: the guest code

2007-05-09 Thread Pekka Enberg
Hi Rusty, On 5/9/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: +static void add_lguest_device(unsigned int index) +{ + struct lguest_device *new; + + lguest_devices[index].status |= LGUEST_DEVICE_S_ACKNOWLEDGE; + new = kmalloc(sizeof(struct lguest_device), GFP_KERNEL); +

[patch 9/9] lguest: the documentation, example launcher

2007-05-09 Thread akpm
From: Rusty Russell <[EMAIL PROTECTED]> A brief document describing how to use lguest. Because lguest doesn't have an ABI we also include an example launcher in the Documentation directory. [EMAIL PROTECTED]: Fix up nat example in documentation] Signed-off-by: Rusty Russell <[EMAIL PROTECTED]>

Re: [PATCH 1/5] fallocate() implementation in i86, x86_64 and powerpc

2007-05-09 Thread Suparna Bhattacharya
On Fri, May 04, 2007 at 02:41:50PM +1000, Paul Mackerras wrote: > Andrew Morton writes: > > > On Thu, 26 Apr 2007 23:33:32 +0530 "Amit K. Arora" <[EMAIL PROTECTED]> > > wrote: > > > > > This patch implements the fallocate() system call and adds support for > > > i386, x86_64 and powerpc. > > >

Re: [PATCH 7/10] i386 sg: add support for chaining scatterlists

2007-05-09 Thread Herbert Xu
Jens Axboe <[EMAIL PROTECTED]> wrote: > > diff --git a/include/asm-i386/scatterlist.h b/include/asm-i386/scatterlist.h > index d7e45a8..794b68c 100644 > --- a/include/asm-i386/scatterlist.h > +++ b/include/asm-i386/scatterlist.h > @@ -8,8 +8,11 @@ struct scatterlist { > unsigned int

Re: Bogus section mismatch errors?

2007-05-09 Thread Paul Mundt
On Tue, May 08, 2007 at 01:52:20PM +0200, Sam Ravnborg wrote: > On Tue, May 08, 2007 at 12:17:59PM +0100, Russell King wrote: > > WARNING: mm/built-in.o - Section mismatch: > > reference to .init.text: from .text between 'kmem_cache_create' (at offset > > 0x1bd94) > > and 'cache_reap' > >

[ALSA PATCH] alsa-git merge request

2007-05-09 Thread Jaroslav Kysela
Linus, please pull from [the linus branch at]: master.kernel.org:/pub/scm/linux/kernel/git/perex/alsa.git linus gitweb interface: http://www.kernel.org/git/?p=linux/kernel/git/perex/alsa.git The GNU patch is available at:

Re: Please revert 5adc55da4a7758021bcc374904b0f8b076508a11 (PCI_MULTITHREAD_PROBE)

2007-05-09 Thread Greg KH
On Tue, May 08, 2007 at 02:41:54PM -0700, David Miller wrote: > From: Linus Torvalds <[EMAIL PROTECTED]> > Date: Tue, 8 May 2007 13:01:21 -0700 (PDT) > > > In fact, there is nothing wrong with having *both* a synchronous part, and > > an async part: > > > > .probe = mydriver_setup, > >

Re: [SOLVED] Serial buffer corruption [was Re: FTDI usb-serial possible bug]

2007-05-09 Thread Antonino Ingargiola
2007/5/6, Antonino Ingargiola <[EMAIL PROTECTED]>: 2007/5/5, Oliver Neukum <[EMAIL PROTECTED]>: > Am Samstag, 5. Mai 2007 20:08 schrieb Antonino Ingargiola: > > Now I don't want to abuse your kindness, but I (personally) would be > > *really* interested in a similar fix for the FTDI usb-serial

[patch 7/9] lguest: the net driver

2007-05-09 Thread akpm
From: Rusty Russell <[EMAIL PROTECTED]> Lguest net driver A simple net driver for lguest. Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> Cc: Andi Kleen <[EMAIL PROTECTED]> Cc: Jeff Garzik <[EMAIL PROTECTED]> Acked-by: James Morris <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL

[patch 8/9] lguest: the block driver

2007-05-09 Thread akpm
From: Rusty Russell <[EMAIL PROTECTED]> Lguest block driver A simple block driver for lguest. Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> Cc: Andi Kleen <[EMAIL PROTECTED]> Cc: Jens Axboe <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/block/Makefile

[patch 5/9] lguest: the Makefile and Kconfig

2007-05-09 Thread akpm
From: Rusty Russell <[EMAIL PROTECTED]> This is the Kconfig and Makefile to allow lguest to actually be compiled. Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> Cc: Andi Kleen <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/Kconfig |2 ++

[patch 4/9] lguest: the asm offsets

2007-05-09 Thread akpm
From: Rusty Russell <[EMAIL PROTECTED]> This is the structure offsets required by lg.ko's switcher.S. Unfortunately we don't have infrastructure for private asm-offsets creation. Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> Cc: Andi Kleen <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton

[patch 6/9] lguest: the console driver

2007-05-09 Thread akpm
From: Rusty Russell <[EMAIL PROTECTED]> A simple console driver for lguest. Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> Cc: Andi Kleen <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/char/Makefile |1 drivers/char/hvc_lguest.c | 99

[patch 2/9] lguest: the guest code

2007-05-09 Thread akpm
From: Rusty Russell <[EMAIL PROTECTED]> lguest is a simple hypervisor for Linux on Linux. Unlike kvm it doesn't need VT/SVM hardware. Unlike Xen it's simply "modprobe and go". Unlike both, it's 5000 lines and self-contained. Performance is ok, but not great (-30% on kernel compile). But

lguest re-review

2007-05-09 Thread Andrew Morton
Some concern was expressed over the lguest review status, so I shall send the patches out again for people to review, to test, to make observations about the author's personal appearance, etc. I'll plan on sending these patches off to Linus in a week's time, assuming all goes well. Thanks. - To

[patch 1/9] lguest: export symbols for lguest as a module

2007-05-09 Thread akpm
From: Rusty Russell <[EMAIL PROTECTED]> lguest does some fairly lowlevel things to support a host, which normal modules don't need: math_state_restore: When the guest triggers a Device Not Available fault, we need to be able to restore the FPU __put_task_struct: We need

Re: Please revert 5adc55da4a7758021bcc374904b0f8b076508a11 (PCI_MULTITHREAD_PROBE)

2007-05-09 Thread Greg KH
On Tue, May 08, 2007 at 06:38:46PM +0200, Cornelia Huck wrote: > On Tue, 8 May 2007 08:27:34 -0700 (PDT), > Linus Torvalds <[EMAIL PROTECTED]> wrote: > > > And no, we should not do it at the device core level. In fact, I don't > > think we should do it at that level at all. > > > > I'm pretty

Re: 2.6.21-mm1+hotfix -- Slab corruption -- Last user: [](cryptomgr_probe+0x6c/0x9a)

2007-05-09 Thread Miles Lane
On 5/8/07, Herbert Xu <[EMAIL PROTECTED]> wrote: On Mon, May 07, 2007 at 11:57:28AM -0700, Miles Lane wrote: > [ 118.442018] ieee80211_crypt: registered algorithm 'WEP' > [ 118.514572] ADDRCONF(NETDEV_CHANGE): eth1: link becomes ready > [ 118.514664] Slab corruption: size-256 start=c6aabe98,

Re: Please revert 5adc55da4a7758021bcc374904b0f8b076508a11 (PCI_MULTITHREAD_PROBE)

2007-05-09 Thread Greg KH
On Tue, May 08, 2007 at 01:58:10PM -0700, David Miller wrote: > From: Greg KH <[EMAIL PROTECTED]> > Date: Tue, 8 May 2007 07:07:53 -0700 > > > Only if it ends up working properly. The commit you reference above > > (which removed the PCI_MULTITHREAD_PROBE option), is fine, pci > > multi-threaded

Re: Please revert 5adc55da4a7758021bcc374904b0f8b076508a11 (PCI_MULTITHREAD_PROBE)

2007-05-09 Thread Greg KH
On Tue, May 08, 2007 at 02:15:54PM -0700, David Miller wrote: > From: Linus Torvalds <[EMAIL PROTECTED]> > Date: Tue, 8 May 2007 08:27:34 -0700 (PDT) > > > Threading at the bus level just inevitably means things like random > > numbers for devices depending on some timing/scheduling issue.

Re: [RFC/PATCH] doc: volatile considered evil

2007-05-09 Thread Johannes Stezenbach
On Tue, May 08, 2007, Jonathan Corbet wrote: > > I just took a shot at turning this into something more like a normal > document: > > http://lwn.net/Articles/233479/ I think the "jiffies variable is special" part misses the "for stupid legacy reasons" explanation. According to the other

Re: [linux-usb-devel] Bug creating USB endpoints in 2.6.20.x (kernel bug 8198)

2007-05-09 Thread Tejun Heo
[adding back linux-usb-devel. please don't drop cc] [also adding lkml and Greg K-H] Chris Rankin wrote: > --- Tejun Heo <[EMAIL PROTECTED]> wrote: >> Okay, here's patch against 2.6.20.11. Let's hope we're not chasing >> something which is already fixed. > > Hooray! The trick was to trace the

<    1   2   3   4   5   6   7   8   9   10   >