Re: NOHZ: local_softirq_pending 08

2007-05-29 Thread Rafał Bilski
Hi! A lot of NOHZ: local_softirq_pending 08 messages (about 100) and then suddenly stoped to show. I have 2.6.21.1. I checked .2 and .3 changelogs but I don't see anything about this message. What does it mean? Is 08 IRQ number? 8: 2XT-PIC-XTrtc Please CC me.

Re: stuff ready to be deleted?

2007-05-29 Thread Jan Engelhardt
On May 28 2007 18:25, Robert P. J. Day wrote: On Mon, 28 May 2007, Jan Engelhardt wrote: currently, the list contains the items: * 4 Traffic policing CONFIG_NET_SCHED? CONFIG_NET_ACT_POLICE? Neither seems marked as deprecated/obsoleted in Kconfig. the traffic policing entry in that

Re: [patch] CFS scheduler, -v14

2007-05-29 Thread Ingo Molnar
* Li Yu [EMAIL PROTECTED] wrote: Ingo Molnar wrote: i'm pleased to announce release -v14 of the CFS scheduler patchset. The CFS patch against v2.6.22-rc2, v2.6.21.1 or v2.6.20.10 can be downloaded from the usual place: http://people.redhat.com/mingo/cfs-scheduler/ I tried

[PATCH 1/2] [AGPGART] intel_agp: cleanup intel private data

2007-05-29 Thread Wang Zhenyu
[AGPGART] intel_agp: cleanup intel private data A single private gart data is used by all drivers, this makes it clean. Eric Anholt wrote the original patch. Signed-off-by: Wang Zhenyu [EMAIL PROTECTED] --- drivers/char/agp/intel-agp.c | 193 -- 1 files

[PATCH 2/2] [AGPGART] intel_agp: use table for device probe

2007-05-29 Thread Wang Zhenyu
[PATCH 2/2] [AGPGART] intel_agp: use table for device probe Remove big switch to make things clear. Eric Anholt was the original author. Signed-off-by: Wang Zhenyu [EMAIL PROTECTED] --- drivers/char/agp/intel-agp.c | 324 -- 1 files changed, 122

[PATCH] binfmt_flat: minimum support for the Blackfin relocations

2007-05-29 Thread Bryan Wu
From: Bernd Schmidt [EMAIL PROTECTED] This just adds minimum support for the Blackfin relocations, since we don't have enough space in each reloc. The idea is to store a value with one relocation so that subsequent ones can access it. Signed-off-by: Bernd Schmidt [EMAIL PROTECTED] Signed-off-by:

[PATCH/RFC] Is it OK for 'read' to return nuls for a file that never had nuls in it?

2007-05-29 Thread Neil Brown
It appears that there is a race when reading from a file that is concurrently being truncated. It is possible to read a number of bytes that matches the size of the file before the truncate, but the actual bytes are all nuls - values that had never been in the file. Below is a simple C program

Re: What causes iowait other than waiting for i/o?

2007-05-29 Thread Satyam Sharma
Hi Bill, On 5/29/07, Bill Davidsen [EMAIL PROTECTED] wrote: I recently noted that my system was spending a lot of time in i/o wait when doing some tasks which I thought didn't involve i/o, as noted by the lack of disk light activity most of the time. I thought of network, certainly the NIC had

[PATCH/RFC] Is it OK for 'read' to return nuls for a file that never had nuls in it?

2007-05-29 Thread Neil Brown
[resending with correct To address - please reply to this one] It appears that there is a race when reading from a file that is concurrently being truncated. It is possible to read a number of bytes that matches the size of the file before the truncate, but the actual bytes are all nuls -

Re: [PATCH/RFC] Is it OK for 'read' to return nuls for a file that never had nuls in it?

2007-05-29 Thread Nick Piggin
Neil Brown wrote: [resending with correct To address - please reply to this one] It appears that there is a race when reading from a file that is concurrently being truncated. It is possible to read a number of bytes that matches the size of the file before the truncate, but the actual bytes

Re: [RFD] BIO_RW_BARRIER - what it means for devices, filesystems, and dm/md.

2007-05-29 Thread Jeremy Higdon
On Mon, May 28, 2007 at 02:48:45PM +1000, Timothy Shimmin wrote: I'm taking it that the FUA write will just guarantee that that particular write has made it to disk on i/o completion (and no write cache flush is done). Correct. It only applies to that one write command. jeremy - To

man-pages-2.51 is released

2007-05-29 Thread Michael Kerrisk
Gidday, I just released man-pages-2.51. This release is now available for download at: http://www.kernel.org/pub/linux/docs/manpages or ftp://ftp.kernel.org/pub/linux/docs/manpages or mirrors: ftp://ftp.XX.kernel.org/pub/linux/docs/manpages and soon at:

Re: pcmcia resume 60 second hang. Re: [patch 00/69] -stable review

2007-05-29 Thread Kay Sievers
On 5/25/07, Linus Torvalds [EMAIL PROTECTED] wrote: On Fri, 25 May 2007, Pavel Machek wrote: 2) we need to preload firmware during _suspend_. I AM TELLING THAT TO PEOPLE FOR FIVE YEARS NOW. And people aren't listening. Have you thought about _why_? The thing is, it should just work. Even

Re: [PATCH/RFC] Is it OK for 'read' to return nuls for a file that never had nuls in it?

2007-05-29 Thread Neil Brown
On Tuesday May 29, [EMAIL PROTECTED] wrote: Questions: - Is this a problem, and should it be fixed (I think yes). I think you are right. That's encouraging - thanks. - Is the patch appropriate, and does it have no negative consequences?. (Obviously some comments

Re: 2.6.22-rc2-mm1

2007-05-29 Thread Cornelia Huck
On Mon, 28 May 2007 00:41:19 +0200, Kay Sievers [EMAIL PROTECTED] wrote: Cornelia, in the patch is: + if (dev-kobj.parent == dev-class-subsys.kobj) + return 0; which will skip the creation of the device-link, right? ...and this is certainly broken. Argl. Could those folks

Re: [PATCH/RFC] Is it OK for 'read' to return nuls for a file that never had nuls in it?

2007-05-29 Thread Nick Piggin
Neil Brown wrote: On Tuesday May 29, [EMAIL PROTECTED] wrote: Questions: - Is this a problem, and should it be fixed (I think yes). I think you are right. That's encouraging - thanks. - Is the patch appropriate, and does it have no negative consequences?. (Obviously some

Re: [NFS] [PATCH] NFSD: fix uninitialized variable

2007-05-29 Thread Matt Keenan
young dave wrote: Hi, Given what you said above, I don't see gcc, on its best day, will ever know enough to validate that that variable is indeed always initialized. So I would vote for silencing it on those grounds. I agree too. How about this one: diff -dur linux/fs/nfsd/nfs4acl.c

Re: [BUG] signal: multithread program returns with wrong errno on receiving SIGSTOP

2007-05-29 Thread Roland McGrath
Your fix seems like the only way to go. From skimming all the ERESTART* uses, I think that in all cases (except for n_tty.c:job_control before your patch), TIF_SIGPENDING is indeed set when a thread returns -ERESTART*. But it makes me realize that there is a danger of leaking a -ERESTART* return

Re: [PATCH] libata: implement ata_wait_after_reset()

2007-05-29 Thread Tejun Heo
Jeff Garzik wrote: Tejun Heo wrote: -msleep(150); +/* wait a while before checking status */ +ata_wait_after_reset(ap, deadline); [...] -msleep(150); +/* wait a while before checking status */ +ata_wait_after_reset(ap, deadline); /* Before we perform post

Re: stuff ready to be deleted?

2007-05-29 Thread Geert Uytterhoeven
On Mon, 28 May 2007, Robert P. J. Day wrote: i'm trying to keep track of kernel janitor projects that involve removing dead content from the tree: http://fsdev.net/wiki/index.php?title=Kernel_Janitor%27s_Todo_List currently, the list contains the items: [...] * 11 Macintosh

Re: [2.6.21.1] soft lockup when removing netconsole module

2007-05-29 Thread Andrew Morton
On Sat, 26 May 2007 17:40:12 +0200 Folkert van Heusden [EMAIL PROTECTED] wrote: When trying to remove the netconsole module, I got the following kernel output after a while (couple of minutes iirc): [525720.117293] BUG: soft lockup detected on CPU#1! [525720.117353] [c1004d53]

Re: 2.6.22-rc2-mm1

2007-05-29 Thread Kay Sievers
On Mon, 2007-05-28 at 19:22 +0200, Cornelia Huck wrote: On Mon, 28 May 2007 00:41:19 +0200, Kay Sievers [EMAIL PROTECTED] wrote: Cornelia, in the patch is: + if (dev-kobj.parent == dev-class-subsys.kobj) + return 0; which will skip the creation of the device-link,

Re: [PATCH] Fix potential memory leak in tipc_named_node_up()

2007-05-29 Thread Jesper Juhl
On 29/05/07, Björn Steinbrink [EMAIL PROTECTED] wrote: On 2007.05.28 22:58:08 +0200, Jesper Juhl wrote: There seems to be a memory leak in net/tipc/name_distr.c::tipc_named_node_up() The function, with comments, is this : void tipc_named_node_up(unsigned long node) { struct

Re: [BUG] signal: multithread program returns with wrong errno on receiving SIGSTOP

2007-05-29 Thread Andrew Morton
On Mon, 28 May 2007 11:32:00 +0900 Satoru Takeuchi [EMAIL PROTECTED] wrote: Hi, I found a bug on signal subsystem. If there is some multithread program and one of the thread is blocking on the system call, it returns with wrong errno on receiving SIGSTOP and following SIGCONT. Arch

Re: [BUG] signal: multithread program returns with wrong errno on receiving SIGSTOP

2007-05-29 Thread Roland McGrath
Off hand I think it can happen on all 2.6 kernels in theory. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [patch] CFS scheduler, -v14

2007-05-29 Thread Ingo Molnar
* Ingo Molnar [EMAIL PROTECTED] wrote: [...] in update_stats_enqueue(), It seem that these statements in two brances of if (p-load_weight NICE_0_LOAD) are same, is it on purpose? what do you mean? you are right indeed. Mike Galbraith has sent a cleanup patch that removes that

Re: [RFC] LZO de/compression support - take 6

2007-05-29 Thread Michael-Luke Jones
On 28 May 2007, at 18:11, Adrian Bunk wrote: I have not seen any explanations: - Why did the upstream author write the code that way? Apparently due to his requirement for extreme portability. The original code was designed to work on everything from 16-bit DOS through CRAY supercomputers

Re: [BUG] signal: multithread program returns with wrong errno on receiving SIGSTOP

2007-05-29 Thread Satoru Takeuchi
Hi Andrew, What kernel versions is this occurring on? 2.6.22-rc3 is. Satoru At Tue, 29 May 2007 01:03:15 -0700, Andrew Morton wrote: On Mon, 28 May 2007 11:32:00 +0900 Satoru Takeuchi [EMAIL PROTECTED] wrote: Hi, I found a bug on signal subsystem. If there is some multithread

Makefile question (was [RFC] LZO de/compression support - take 6)

2007-05-29 Thread Michael-Luke Jones
On 28 May 2007, at 15:34, Nitin Gupta wrote: diff --git a/lib/Kconfig b/lib/Kconfig index 2e7ae6b..eb95eaa 100644 --- a/lib/Kconfig +++ b/lib/Kconfig @@ -64,6 +64,12 @@ config ZLIB_INFLATE config ZLIB_DEFLATE tristate +config LZO1X_COMPRESS + tristate + +config LZO1X_DECOMPRESS +

Re: stuff ready to be deleted?

2007-05-29 Thread Robert P. J. Day
On Tue, 29 May 2007, Jan Engelhardt wrote: On May 28 2007 18:25, Robert P. J. Day wrote: On Mon, 28 May 2007, Jan Engelhardt wrote: currently, the list contains the items: * 4 Traffic policing CONFIG_NET_SCHED? CONFIG_NET_ACT_POLICE? Neither seems marked as

Re: [PATCH] ARM/ARM26: Enable arbitary speed tty ioctls and split input/output speed

2007-05-29 Thread Alan Cox
I think Alan's per-arch patch was dependent upon an earlier patch. He fooled everyone by sending them out in random order, without sequence Sorry about that - I forgot to do it initially so it didn't get ordered sanely +struct termios_2 { struct termios2 so I also sneaked in a typo.

Re: double exclamation (!!) suckage in the kernel

2007-05-29 Thread Bodo Eggert
On Sat, 26 May 2007, Al Viro wrote: On Sat, May 26, 2007 at 06:38:07PM +0200, Bodo Eggert wrote: Not exactly, if(foo) is the same as if( (int) foo), which is not guaranteed to result in non-null values for non-null pointers. RTFStandard. ... and don´t forget half of it untill you look up

Re: stuff ready to be deleted?

2007-05-29 Thread Alan Cox
On Mon, 28 May 2007 18:24:55 -0400 Bill Davidsen [EMAIL PROTECTED] wrote: Oliver Pinter wrote: + open sound system Why? OSS supports some hardware ALSA doesn't, it's maintained by an independent commercial company (4Front) so maintenance isn't an issue, and it's portable to many

Re: pcmcia resume 60 second hang. Re: [patch 00/69] -stable review

2007-05-29 Thread Romano Giannetti
On Sun, 2007-05-27 at 19:44 +0100, Matthew Garrett wrote: Anyway. I've tested the following patch on a dual-core x86. No obvious issues yet, but I'll try to put it through a few hundred cycles. [patch to disable freezer deleted] First of all, excuse me for being a quite lousy tester. Could

Re: [NFS] [PATCH] NFSD: fix uninitialized variable

2007-05-29 Thread young dave
Hi, matt embarrassed :) below resend it. diff -dur linux/fs/nfsd/nfs4acl.c linux.new/fs/nfsd/nfs4acl.c --- linux/fs/nfsd/nfs4acl.c 2007-05-29 12:28:29.0 + +++ linux.new/fs/nfsd/nfs4acl.c 2007-05-29 16:32:26.0 + @@ -183,8 +183,6 @@ summarize_posix_acl(struct posix_acl

Re: stuff ready to be deleted?

2007-05-29 Thread David Miller
From: Robert P. J. Day [EMAIL PROTECTED] Date: Tue, 29 May 2007 04:20:24 -0400 (EDT) On Tue, 29 May 2007, Jan Engelhardt wrote: On May 28 2007 18:25, Robert P. J. Day wrote: On Mon, 28 May 2007, Jan Engelhardt wrote: currently, the list contains the items: * 4 Traffic

Re: stuff ready to be deleted?

2007-05-29 Thread David Miller
From: Alan Cox [EMAIL PROTECTED] Date: Tue, 29 May 2007 09:34:02 +0100 On Mon, 28 May 2007 18:24:55 -0400 Bill Davidsen [EMAIL PROTECTED] wrote: Oliver Pinter wrote: + open sound system Why? OSS supports some hardware ALSA doesn't, it's maintained by an independent

Re: [PATCH] add a trivial patch style checker

2007-05-29 Thread Andy Whitcroft
Jan Engelhardt wrote: On May 27 2007 18:11, Andy Whitcroft wrote: + +my $P = $0; + +my $V = '0.01'; + +use Getopt::Long qw(:config no_auto_abbrev); [...] +sub top_of_kernel_tree { +if ((-f COPYING) (-f CREDITS) (-f Kbuild) +(-f MAINTAINERS) (-f Makefile) (-f README) +

Re: [PATCH] add a trivial patch style checker

2007-05-29 Thread Andy Whitcroft
Andi Kleen wrote: Andy Whitcroft [EMAIL PROTECTED] writes: + +# no BUG() or BUG_ON() +if ($line =~ /\b(BUG|BUG_ON)\b/) { +print Try to use WARN_ON Recovery code rather than BUG() or BUG_ON()\n; Just outlawing BUG_ON doesn't seem like a good idea to me.

[PATCH] Update Documentation/block/barrier.txt

2007-05-29 Thread Geert Uytterhoeven
Documentation/block/barrier.txt is not in sync with the actual code: - blk_queue_ordered() no longer has a gfp_mask parameter - blk_queue_ordered_locked() no longer exists - sd_prepare_flush() looks slightly different Signed-off-by: Geert Uytterhoeven [EMAIL PROTECTED] ---

Re: [RFD] BIO_RW_BARRIER - what it means for devices, filesystems, and dm/md.

2007-05-29 Thread Stefan Bader
2007/5/25, Neil Brown [EMAIL PROTECTED]: BIO_RW_FAILFAST: means low-level driver shouldn't do much (or no) error recovery. Mainly used by mutlipath targets to avoid long SCSI recovery. This should just be propagated when passing requests on. Is it much or no? Would it be reasonable to use

Re: [PATCH 1/2] [AGPGART] intel_agp: cleanup intel private data

2007-05-29 Thread Christoph Hellwig
On Tue, May 29, 2007 at 02:20:05PM +0800, Wang Zhenyu wrote: +static struct _intel_private { + struct pci_dev *pcidev; /* device one */ volatile u8 __iomem *registers; + volatile u32 __iomem *gtt; /* I915G */ Neither of these should be volatile. - To unsubscribe

Re: [PATCH 2/2] [AGPGART] intel_agp: use table for device probe

2007-05-29 Thread Christoph Hellwig
On Tue, May 29, 2007 at 02:21:25PM +0800, Wang Zhenyu wrote: +static const struct intel_driver_description { + unsigned int chip_id; + unsigned int gmch_chip_id; + char *name; + struct agp_bridge_driver *driver; + struct agp_bridge_driver *gmch_driver; The two should be

Re: [dm-devel] Re: [RFD] BIO_RW_BARRIER - what it means for devices, filesystems, and dm/md.

2007-05-29 Thread Stefan Bader
2007/5/28, Alasdair G Kergon [EMAIL PROTECTED]: On Mon, May 28, 2007 at 11:30:32AM +1000, Neil Brown wrote: 1/ A BIO_RW_BARRIER request should never fail with -EOPNOTSUP. The device-mapper position has always been that we require a zero-length BIO_RW_BARRIER (i.e. containing no data to

Re: [PATCH] AFS: Implement file locking

2007-05-29 Thread David Howells
J. Bruce Fields [EMAIL PROTECTED] wrote: You can contrive examples of applications that would be correct given the standard fcntl behavior, but that would deadlock on a system that didn't allow read locks to jump the queue in the above situation. Yes, but you can also contrive starvation if

[PATCH](memory hotplug) Fix unnecessary calling of init_currenty_empty_zone()

2007-05-29 Thread Yasunori Goto
Hello. This patch is to fix unnecessary calling of init_currently_empty_zone(). zone-present_pages is updated in online_pages(). But, __add_zone() can be called twice or more before calling online_pages(). So, init_currenty_empty_zone() can be called unnecessary times. It is cause of memory leak

Re: [patch 7/7] ps3: FLASH ROM Storage Driver

2007-05-29 Thread Christoph Hellwig
On Fri, May 25, 2007 at 10:36:14AM +0200, [EMAIL PROTECTED] wrote: Add a FLASH ROM Storage Driver for the PS3: - Implemented as a misc character device driver - Uses a fixed 256 KiB buffer allocated from boot memory as the hypervisor requires the writing of aligned 256 KiB blocks

Re: [patch 6/7] ps3: ROM Storage Driver

2007-05-29 Thread Christoph Hellwig
On Sun, May 27, 2007 at 08:18:43AM +1000, Benjamin Herrenschmidt wrote: linux/highmem.h is not included to get the kmap_* prototypes. Beside, I don't see the point of using kmap on ppc64... So what should I use instead? you don't need to map ... the linear mapping is there

Re: [patch 7/7] ps3: FLASH ROM Storage Driver

2007-05-29 Thread Geert Uytterhoeven
On Tue, 29 May 2007, Christoph Hellwig wrote: On Fri, May 25, 2007 at 10:36:14AM +0200, [EMAIL PROTECTED] wrote: Add a FLASH ROM Storage Driver for the PS3: - Implemented as a misc character device driver - Uses a fixed 256 KiB buffer allocated from boot memory as the hypervisor

Re: [patch] CFS scheduler, -v14

2007-05-29 Thread Balbir Singh
Hi, Ingo, +static clock_t task_utime(struct task_struct *p) +{ + /* + * Use CFS's precise accounting, if available: + */ + if (!has_rt_policy(p) !(sysctl_sched_load_smoothing 128)) + return nsec_to_clock_t(p-sum_exec_runtime); I wonder if this leads to

Re: [patch] CFS scheduler, -v14

2007-05-29 Thread Balbir Singh
On Mon, May 28, 2007 at 01:07:48PM +0200, Ingo Molnar wrote: * Balbir Singh [EMAIL PROTECTED] wrote: Ingo Molnar wrote: i found an accounting bug in this: it didnt sum up threads correctly. The patch below fixes this. The stime == 0 problem is still there though. Ingo

Re: Makefile question (was [RFC] LZO de/compression support - take 6)

2007-05-29 Thread Satyam Sharma
On 5/29/07, Michael-Luke Jones [EMAIL PROTECTED] wrote: On 28 May 2007, at 15:34, Nitin Gupta wrote: diff --git a/lib/Kconfig b/lib/Kconfig index 2e7ae6b..eb95eaa 100644 --- a/lib/Kconfig +++ b/lib/Kconfig @@ -64,6 +64,12 @@ config ZLIB_INFLATE config ZLIB_DEFLATE tristate

[PATCH 1/2] Char: vt, use kzalloc

2007-05-29 Thread Jiri Slaby
vt, use kzalloc Signed-off-by: Jiri Slaby [EMAIL PROTECTED] --- commit daa738839b831a78b895ad9cec1da0157e4b1be7 tree 039d7b54429bd8256f59e493f17e43947a2f173e parent 1a5e44385253ef9a193badf768f40543af6996ca author Jiri Slaby [EMAIL PROTECTED] Sun, 27 May 2007 09:49:53 +0200 committer Jiri Slaby

[PATCH 2/2] Char: vt, use ARRAY_SIZE

2007-05-29 Thread Jiri Slaby
vt, use ARRAY_SIZE Signed-off-by: Jiri Slaby [EMAIL PROTECTED] --- commit 4be166037b1ccf8a639aef015a224941de7dcf0a tree 68cf3d32232a23963fbfd15d0831b89ea7123b92 parent daa738839b831a78b895ad9cec1da0157e4b1be7 author Jiri Slaby [EMAIL PROTECTED] Sun, 27 May 2007 10:13:41 +0200 committer Jiri

[PATCH 1/1] Char: Kconfig, mxser_new: remove experimental comment

2007-05-29 Thread Jiri Slaby
Kconfig, mxser_new: remove experimental comment Signed-off-by: Jiri Slaby [EMAIL PROTECTED] --- commit 70591fd7231ee9767b813b052ff5b6123c8963b9 tree 0a686cee41b4f9f5e964b36a9001e3c0b03dc29d parent 1a5e44385253ef9a193badf768f40543af6996ca author Jiri Slaby [EMAIL PROTECTED] Mon, 28 May 2007

Re: [ckrm-tech] [RFC] [PATCH 0/3] Add group fairness to CFS

2007-05-29 Thread William Lee Irwin III
William Lee Irwin III wrote: Lag should be considered in lieu of load because lag On Sun, May 27, 2007 at 11:29:51AM +1000, Peter Williams wrote: What's the definition of lag here? Lag is the deviation of a task's allocated CPU time from the CPU time it would be granted by the ideal fair

Re: [patch 6/7] ps3: ROM Storage Driver

2007-05-29 Thread Christoph Hellwig
[Note that all scsi lldds should go to linux-scsi] +config PS3_ROM + tristate PS3 ROM Storage Driver + depends on PPC_PS3 BLK_DEV_SR + select PS3_STORAGE + default y please don't put any default y statements in. +#define DEVICE_NAME ps3rom + +#define

Re: [patch 6/7] ps3: ROM Storage Driver

2007-05-29 Thread Christoph Hellwig
On Fri, May 25, 2007 at 11:04:29PM +0200, Arnd Bergmann wrote: On Friday 25 May 2007, Geert Uytterhoeven wrote: What is the problem? Is there infrastructure missing in the CD-ROM layer? As the CD/DVD/BD part just accepts SCSI/ATAPI commands (except for plain read/write), I was

Re: [patch 7/7] ps3: FLASH ROM Storage Driver

2007-05-29 Thread Christoph Hellwig
On Tue, May 29, 2007 at 11:57:52AM +0200, Geert Uytterhoeven wrote: On Tue, 29 May 2007, Christoph Hellwig wrote: On Fri, May 25, 2007 at 10:36:14AM +0200, [EMAIL PROTECTED] wrote: Add a FLASH ROM Storage Driver for the PS3: - Implemented as a misc character device driver - Uses a

Re: Makefile question (was [RFC] LZO de/compression support - take 6)

2007-05-29 Thread Michael-Luke Jones
On 29 May 2007, at 11:41, Satyam Sharma wrote: This is syntactically correct (and wouldn't produce any build errors), but it's quite ... strange, still. Why would I even want to /build/ the compress code if all I selected was the decompress option? Apologies, you gave me the answer I was

Re: [patch 6/7] ps3: ROM Storage Driver

2007-05-29 Thread Geert Uytterhoeven
On Tue, 29 May 2007, Christoph Hellwig wrote: [Note that all scsi lldds should go to linux-scsi] I'll Cc linux-scsi next time. + sgpnt = cmd-request_buffer; + active = 1; + for (k = 0, req_len = 0, act_len = 0; k cmd-use_sg; ++k, ++sgpnt) { + if (active) { +

[PATCH] merge dst_discard in out into one, removed a duplicate function

2007-05-29 Thread rae l
On 5/28/07, Jan Engelhardt [EMAIL PROTECTED] wrote: Uhm, just replace every invocation of dst_discard_in/_out() directly by dst_discard ... don't add macros for that. merge dst_discard in out into one, this removed a duplicate function. Signed-off-by: Denis Cheng [EMAIL PROTECTED] --- Is

Re: Linux v2.6.22-rc3

2007-05-29 Thread Tejun Heo
Hello, Gregor. Gregor Jasny wrote: [ 18.639188] ata_piix :00:07.1: version 2.11 [ 18.639718] scsi0 : ata_piix [ 18.640189] scsi1 : ata_piix [ 18.640541] ata1: PATA max UDMA/33 cmd 0x000101f0 ctl 0x000103f6 bmdma 0x00010860 irq 14 [ 18.641148] ata2: PATA max UDMA/33 cmd

Re: [PATCH] merge dst_discard in out into one, removed a duplicate function

2007-05-29 Thread Patrick McHardy
rae l wrote: merge dst_discard in out into one, this removed a duplicate function. Your patch is whitespace damaged, please fix your mailer and resend *once*. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo

Re: [AppArmor 01/41] Pass struct vfsmount to the inode_create LSMhook

2007-05-29 Thread Tetsuo Handa
Hello. Crispin Cowan wrote: AppArmor actually does something similar to this, by mediating all of the ways that you can make an alias to a file. These are: * Symbolic links: these actually don't work for making aliases with respect to LSM-based security systems such as AppArmor,

Re: Makefile question (was [RFC] LZO de/compression support - take 6)

2007-05-29 Thread Satyam Sharma
On 5/29/07, Michael-Luke Jones [EMAIL PROTECTED] wrote: On 29 May 2007, at 11:41, Satyam Sharma wrote: This is syntactically correct (and wouldn't produce any build errors), but it's quite ... strange, still. Why would I even want to /build/ the compress code if all I selected was the

Re: [2.6.21.1] resume doesn't run suspended kernel?

2007-05-29 Thread Pavel Machek
Hi! Yup. Don't we do something like this for the (ACPI-based) suspend to RAM already? Yeah, I was thinking about this overnight too. It should be doable. In addition to what we already do, I think you'd want: - to copy the assembly to do the copying to a safe page; - to put the

Re: [RFC][PATCH][EXPERIMENTAL] Make kernel threads nonfreezable by default

2007-05-29 Thread Pavel Machek
Hi! Index: linux-2.6.22-rc3/Documentation/power/kernel_threads.txt === --- linux-2.6.22-rc3.orig/Documentation/power/kernel_threads.txt +++ linux-2.6.22-rc3/Documentation/power/kernel_threads.txt @@ -1,13 +1,22 @@

Re: [patch 6/7] ps3: ROM Storage Driver

2007-05-29 Thread Benjamin Herrenschmidt
On Tue, 2007-05-29 at 13:11 +0200, Geert Uytterhoeven wrote: This looks very inefficient. Just set sg_tablesize of your driver to 1 to avoid getting mutiple segments. The disadvantage of setting sg_tablesize = 1 is that the driver will get small requests (PAGE_SIZE) most of the time,

Re: fs periodic check (was Re: 2.6.22-rc1 killed my ext3 filesystem cleanly unmounted)

2007-05-29 Thread Pavel Machek
Hi! Right. Could we get more helpful message here? 'Filesystem check on next boot on AC power'? So (check deferred; on battery) wasn't explicit enough? I guess I assumed that users would understand that the opposite of on battery was on AC power. I guess I could say (check defferred

Re: fs periodic check (was Re: 2.6.22-rc1 killed my ext3 filesystem cleanly unmounted)

2007-05-29 Thread Pavel Machek
On Tue 2007-05-29 13:05:29, Neil Brown wrote: On Monday May 28, [EMAIL PROTECTED] wrote: On Thu, May 24, 2007 at 05:39:11PM +, Pavel Machek wrote: Right. Could we get more helpful message here? 'Filesystem check on next boot on AC power'? So (check deferred; on battery) wasn't

Re: [RFC] LZO de/compression support - take 6

2007-05-29 Thread Adrian Bunk
On Tue, May 29, 2007 at 09:08:27AM +0100, Michael-Luke Jones wrote: On 28 May 2007, at 18:11, Adrian Bunk wrote: I have not seen any explanations: - Why did the upstream author write the code that way? Apparently due to his requirement for extreme portability. The original code was

Seeding /dev/random not working

2007-05-29 Thread M Macnair
In brief: Adding entropy by writing to /dev/[u]random doesn't appear to be working. I am aware that the reported available entropy (via /proc/sys/kernel/random/entropy_avail) will not increase; the symptom is /dev/random keeps spitting out the same numbers. I have two embedded boards (one ARM,

Re: [PATCH] add a trivial patch style checker

2007-05-29 Thread Heiko Carstens
On Tue, May 29, 2007 at 04:23:45AM +0200, Andi Kleen wrote: Possible further checks that might make sense: - panic() anywhere in drivers/* A driver should be allowed to panic. E.g. if it detects that due to a firmware or driver bug memory corruption happened. IMHO the best thing to do then is

Re: pcmcia resume 60 second hang. Re: [patch 00/69] -stable review

2007-05-29 Thread Rafael J. Wysocki
On Tuesday, 29 May 2007 08:55, Kay Sievers wrote: On 5/25/07, Linus Torvalds [EMAIL PROTECTED] wrote: On Fri, 25 May 2007, Pavel Machek wrote: 2) we need to preload firmware during _suspend_. I AM TELLING THAT TO PEOPLE FOR FIVE YEARS NOW. And people aren't listening. Have you

Re: software suspend doesn't work with 2.6.22-rc3

2007-05-29 Thread Rafael J. Wysocki
On Tuesday, 29 May 2007 02:39, Herbert Xu wrote: On Mon, May 28, 2007 at 08:21:29PM +0200, Rafael J. Wysocki wrote: Well, it looks like we have to fix this one separately. Can you please tell me what to do to make cryptd run? If you build it as a module then just loading it should be

Re: [2.6.21.1] resume doesn't run suspended kernel?

2007-05-29 Thread Rafael J. Wysocki
On Tuesday, 29 May 2007 13:29, Pavel Machek wrote: Hi! Yup. Don't we do something like this for the (ACPI-based) suspend to RAM already? Yeah, I was thinking about this overnight too. It should be doable. In addition to what we already do, I think you'd want: - to copy the

Re: pcmcia resume 60 second hang. Re: [patch 00/69] -stable review

2007-05-29 Thread Michael-Luke Jones
Rafael J. Wysocki wrote: On Tuesday, 29 May 2007 08:55, Kay Sievers wrote: The shiny userspace firmware loading causes problems since it exists, every second box has problems with it, in all sorts of situations. If people are still sold to the idea of userspace firmware loading, why don't we

Re: [RFC] LZO de/compression support - take 6

2007-05-29 Thread Nitin Gupta
On 5/29/07, Adrian Bunk [EMAIL PROTECTED] wrote: On Tue, May 29, 2007 at 09:08:27AM +0100, Michael-Luke Jones wrote: On 28 May 2007, at 18:11, Adrian Bunk wrote: I have not seen any explanations: - Why did the upstream author write the code that way? Apparently due to his requirement for

Re: [RFC][PATCH][EXPERIMENTAL] Make kernel threads nonfreezable by default

2007-05-29 Thread Rafael J. Wysocki
Hi, On Tuesday, 29 May 2007 13:31, Pavel Machek wrote: Hi! Index: linux-2.6.22-rc3/Documentation/power/kernel_threads.txt === --- linux-2.6.22-rc3.orig/Documentation/power/kernel_threads.txt +++

Re: pcmcia resume 60 second hang. Re: [patch 00/69] -stable review

2007-05-29 Thread Rafael J. Wysocki
On Tuesday, 29 May 2007 14:00, Michael-Luke Jones wrote: Rafael J. Wysocki wrote: On Tuesday, 29 May 2007 08:55, Kay Sievers wrote: The shiny userspace firmware loading causes problems since it exists, every second box has problems with it, in all sorts of situations. If people are still

Re: [PATCH] Update Documentation/block/barrier.txt

2007-05-29 Thread Tejun Heo
Geert Uytterhoeven wrote: Documentation/block/barrier.txt is not in sync with the actual code: - blk_queue_ordered() no longer has a gfp_mask parameter - blk_queue_ordered_locked() no longer exists - sd_prepare_flush() looks slightly different Signed-off-by: Geert Uytterhoeven [EMAIL

Re: [2.6.21.1] resume doesn't run suspended kernel?

2007-05-29 Thread Nigel Cunningham
Hi. On Tue, 2007-05-29 at 14:03 +0200, Rafael J. Wysocki wrote: On Tuesday, 29 May 2007 13:29, Pavel Machek wrote: Hi! Yup. Don't we do something like this for the (ACPI-based) suspend to RAM already? Yeah, I was thinking about this overnight too. It should be doable.

Re: Block devices and barriers

2007-05-29 Thread Tejun Heo
Hello, Neil Brown wrote: but I can't find a way to actually trigger the calling of ps3disk_issue_flush() and ps3disk_prepare_flush(). 1. My prepare_flush_fn() routine should be called from queue_flush(), which is in turn called by start_ordered(). start_ordered() is called by

[PATCH] mutex_unlock() later in seq_lseek()

2007-05-29 Thread Alexey Dobriyan
All manipulations with struct seq_file::version are done under struct seq_file::lock except one introduced in commit d6b7a781c51c91dd054e5c437885205592faac21 aka [PATCH] Speed up /proc/pid/maps Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED] --- fs/seq_file.c |2 +- 1 file changed, 1

Re: [2.6.21.1] resume doesn't run suspended kernel?

2007-05-29 Thread Pavel Machek
On Tue 2007-05-29 14:03:07, Rafael J. Wysocki wrote: On Tuesday, 29 May 2007 13:29, Pavel Machek wrote: Hi! Yup. Don't we do something like this for the (ACPI-based) suspend to RAM already? Yeah, I was thinking about this overnight too. It should be doable. In

Re: [PATCH] AFS: Implement file locking

2007-05-29 Thread David Howells
J. Bruce Fields [EMAIL PROTECTED] wrote: At the moment, yes. Don't the POSIX and flock lock-handling routines in the kernel normally do that anyway? No, they'd upgrade in that case. I just checked. The OpenAFS server supports neither lock upgrading nor lock downgrading. Attempts to do

Re: [PATCH] IB/ehca: Refactor maybe missed event code

2007-05-29 Thread Joachim Fenkes
Roland Dreier [EMAIL PROTECTED] wrote on 24.05.2007 19:40:39: This isn't fixing anything is it? I think it's 2.6.23 material; correct me if I'm wrong. Right, it doesn't fix things, just coalesces some code. Joachim - To unsubscribe from this list: send the line unsubscribe linux-kernel in

[1/4] 2.6.22-rc3: known regressions

2007-05-29 Thread Michal Piotrowski
Hi all, Here is a list of some known regressions in 2.6.22-rc3. Feel free to add new regressions/remove fixed etc. http://kernelnewbies.org/known_regressions Unclassified Subject: long freezes on thinkpad t60 References : http://lkml.org/lkml/2007/5/24/100 Submitter : Miklos Szeredi

Re: [3/4] 2.6.22-rc3: known regressions

2007-05-29 Thread Michal Piotrowski
Hi all, Here is a list of some known regressions in 2.6.22-rc3. Feel free to add new regressions/remove fixed etc. http://kernelnewbies.org/known_regressions Suspend Subject: 2.6.22-rc1 suspend to RAM problem References :

Re: [4/4] 2.6.22-rc3: known regressions

2007-05-29 Thread Michal Piotrowski
Hi all, Here is a list of some known regressions in 2.6.22-rc3. Feel free to add new regressions/remove fixed etc. http://kernelnewbies.org/known_regressions V4L Subject: V4L ABI breakage References : http://lkml.org/lkml/2007/5/14/42 Submitter : Robert Fitzsimons [EMAIL PROTECTED]

[1/3] 2.6.22-rc3: known regressions with patches

2007-05-29 Thread Michal Piotrowski
Hi all, Here is a list of some known regressions in 2.6.22-rc3 with patches available. Feel free to add new regressions/remove fixed etc. http://kernelnewbies.org/known_regressions ARM Subject: arch/arm/plat-s3c24xx/devs.c build errors References : http://lkml.org/lkml/2007/5/28/18

Re: [2/3] 2.6.22-rc3: known regressions with patches

2007-05-29 Thread Michal Piotrowski
Hi all, Here is a list of some known regressions in 2.6.22-rc3 with patches available. Feel free to add new regressions/remove fixed etc. http://kernelnewbies.org/known_regressions Networking Subject: Oops with prism54 in 2.6.22-rc3 References : http://lkml.org/lkml/2007/5/26/54

Re: [3/3] 2.6.22-rc3: known regressions with patches

2007-05-29 Thread Michal Piotrowski
Hi all, Here is a list of some known regressions in 2.6.22-rc3 with patches available. Feel free to add new regressions/remove fixed etc. http://kernelnewbies.org/known_regressions Suspend Subject: software suspend doesn't work with 2.6.22-rc3 References :

Re: [2/4] 2.6.22-rc3: known regressions

2007-05-29 Thread Michal Piotrowski
Hi all, Here is a list of some known regressions in 2.6.22-rc3. Feel free to add new regressions/remove fixed etc. http://kernelnewbies.org/known_regressions Networking Subject: Network card not usable - sky2 References : http://bugzilla.kernel.org/show_bug.cgi?id=8539 Submitter : Ruben

Re: [RFC][PATCH][EXPERIMENTAL] Make kernel threads nonfreezable by default

2007-05-29 Thread Nigel Cunningham
Hi. On Tue, 2007-05-29 at 14:15 +0200, Rafael J. Wysocki wrote: Please have a look at the current version of the patch (appended). I have followed the Nigel's suggestion not to change the current behavior in this patch (I'll add a couple of patches removing the freezability from some kernel

Re: stuff ready to be deleted?

2007-05-29 Thread Finn Thain
On Tue, 29 May 2007, Geert Uytterhoeven wrote: On Mon, 28 May 2007, Robert P. J. Day wrote: i'm trying to keep track of kernel janitor projects that involve removing dead content from the tree: http://fsdev.net/wiki/index.php?title=Kernel_Janitor%27s_Todo_List currently, the

Re: pcmcia resume 60 second hang. Re: [patch 00/69] -stable review

2007-05-29 Thread Pavel Machek
Hi! I guess we should warn the driver authors, then; and decide what driver authors should do. Drivers really shouldn't do anythign at all. *) If I'm video4linux driver for grabbing screen, have been suspended, and someone asks me to read a frame, should I a) return

Re: [2/3] 2.6.22-rc3: known regressions with patches

2007-05-29 Thread Ben Collins
On Tue, 2007-05-29 at 14:53 +0200, Michal Piotrowski wrote: Subject: OOPS triggered by ip(8) deconfiguring a network interface References : http://bugzilla.kernel.org/show_bug.cgi?id=8491 Submitter : Ben Collins [EMAIL PROTECTED] Patch :

Re: [RFC][PATCH][EXPERIMENTAL] Make kernel threads nonfreezable by default

2007-05-29 Thread Pavel Machek
Hi! Well.. it can write anywhere it wants (filesystem or not) as long as the system is not going to be confused after resume by its caches not matching on-disk state. I'd prefer it not to write anywhere at all. OK Please have a look at the current version of the patch (appended). I

  1   2   3   4   5   6   7   8   9   10   >