Please pull for-2.6.23 branch of cell-2.6.git

2007-07-20 Thread Arnd Bergmann
Hi Linus, Please pull from master.kernel.org:/pub/scm/linux/kernel/git/arnd/cell-2.6.git for-2.6.23 This is a number of changes that fell through the cracks because it wasn't clear how we were going to merge it in the absence of paulus. Mostly bug fixes, except a few features that

Re: [RFC][-mm PATCH 2/8] Memory controller containers setup (v3)

2007-07-20 Thread Paul Menage
On 7/20/07, Balbir Singh <[EMAIL PROTECTED]> wrote: +config CONTAINER_MEM_CONT + bool "Memory controller for containers" + select CONTAINERS Andrew asked me to not use "select" in Kconfig files due to some unspecified problems seen in the past, so my latest patchset makes the

blackfin - cmpxchg not atomic ?

2007-07-20 Thread Mathieu Desnoyers
Hello, I am currently passing through each architectures adding a cmpxchg_local() to each system.h, and I notice that you disable interrupts in your cmpxchg() implementation, why are you doing so ? Also, does you assembly stub _really_ modify memory atomically ? If yes, then there should be no

[2.6.21.1] totally hanging altough not crashed

2007-07-20 Thread Folkert van Heusden
Hi, One of my systems running 2.6.21.1 on a P4 with HT and 2GB of ram occasionally crashes. Not with an oops or panic, it just suddenly stops doing anything. It still lets you ping and it still forwards ip traffic but you can't login: not via ssh and not on the console - pressing enter brings the

Re: [IA64] Add mapping table between irq and vector

2007-07-20 Thread Andrew Morton
On Fri, 20 Jul 2007 13:17:28 -0700 Andrew Morton <[EMAIL PROTECTED]> wrote: > On Fri, 20 Jul 2007 19:59:17 GMT > Linux Kernel Mailing List wrote: > > > + BUG_ON(bind_irq_vector(irq, vector)); > > It's not good practice to do assert(expression-with-side-effects). Because > if someone wants

Re: [PATCH 02/10] Task Containers(V11): Add tasks file interface

2007-07-20 Thread James Morris
On Fri, 20 Jul 2007, [EMAIL PROTECTED] wrote: > +/* > + * Attach task with pid 'pid' to container 'cont'. Call with > + * container_mutex, may take task_lock of task > + */ > +static int attach_task_by_pid(struct container *cont, char *pidbuf) > +{ > + pid_t pid; > + struct task_struct

Re: [RFC][-mm PATCH 1/8] Memory controller resource counters (v3)

2007-07-20 Thread Paul Menage
On 7/20/07, Balbir Singh <[EMAIL PROTECTED]> wrote: + +ssize_t res_counter_read(struct res_counter *counter, int member, + const char __user *userbuf, size_t nbytes, loff_t *pos) +{ + unsigned long *val; + char buf[64], *s; + + s = buf; + val =

Re: Linux, tcpdump and vlan

2007-07-20 Thread Krzysztof Halasa
Ben Greear <[EMAIL PROTECTED]> writes: >> The net result is that dev_queue_xmit_nit() is called twice, once >> for dev=eth0.2 then for dev=eth0. > > Maybe binding to all isn't such a good idea then. Anyway I would expect the frame on eth0.2 and then on eth0 as well. Anything different is crazy.

Re: [IA64] Add mapping table between irq and vector

2007-07-20 Thread Andrew Morton
On Fri, 20 Jul 2007 19:59:17 GMT Linux Kernel Mailing List wrote: > + BUG_ON(bind_irq_vector(irq, vector)); It's not good practice to do assert(expression-with-side-effects). Because if someone wants to create a build which has all the assertions disabled, the resulting binary will not

Re: [linux-pm] Re: Hibernation considerations

2007-07-20 Thread Alan Stern
On Fri, 20 Jul 2007, Oliver Neukum wrote: > Am Freitag 20 Juli 2007 schrieb Alan Stern: > > Some drivers need the ability to schedule.  Some will need the ability > > to allocate memory (although GFP_ATOMIC is probably sufficient).  Some > > will need timers to run. > > Some will have to

Re: [PATCH] buggered kmalloc()

2007-07-20 Thread Dave Jones
On Fri, Jul 20, 2007 at 04:03:40PM +0100, Al Viro wrote: > Signed-off-by: Al Viro <[EMAIL PROTECTED]> > --- > diff --git a/drivers/scsi/iscsi_tcp.c b/drivers/scsi/iscsi_tcp.c > index aebcd5f..7829ab1 100644 > --- a/drivers/scsi/iscsi_tcp.c > +++ b/drivers/scsi/iscsi_tcp.c > @@ -1885,7

Re: [linux-pm] Re: Hibernation considerations

2007-07-20 Thread Oliver Neukum
Am Freitag 20 Juli 2007 schrieb Alan Stern: > Some drivers need the ability to schedule.  Some will need the ability > to allocate memory (although GFP_ATOMIC is probably sufficient).  Some > will need timers to run. Some will have to request firmware. It can add up to some megabytes. In

Re: Linux, tcpdump and vlan

2007-07-20 Thread Krzysztof Halasa
Another idea - perhaps we could make the software VLANs behave the same as hw ones? I.e., stripping the tag on RX while setting some magic skb field? The packets could go via main interface first (normal path, with eth_type_trans stripping the tag and setting protocol = some 802.1Q), netif_rx |

Re: [PATCH] FRV: Fix linkage problems

2007-07-20 Thread Roland McGrath
Acked-by: Roland McGrath <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[GIT PATCHES] V4L/DVB updates

2007-07-20 Thread Mauro Carvalho Chehab
Linus, Please pull from: ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/v4l-dvb.git master For the following: - Some cleanups on several drivers; - Some fixes on ivtv driver; - Remove some memory leaks on wm8775 and wm8739; - Add missing for userspace V4L2 API;

Re: [PATCH 5/7] I/OAT: Add support for MSI and MSI-X

2007-07-20 Thread Roland Dreier
> > Hmm, I see I don't understand what this driver is doing. > > What is a "struct ioatdma_device"? Is this driver requesting > > interrupts that come from the NIC or the IOAT DMA engine? > > I might have caused some confusion. You had asked if any drivers > support MSI but not MSI-X,

Re: drivers/edac: add mips and ppc visibility

2007-07-20 Thread Dave Jones
On Thu, Jul 19, 2007 at 05:59:16PM +, Linux Kernel wrote: > Gitweb: > http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=b113a3f7e85d7f97c8383a88a5bc7c2ea8daeb2f > Commit: b113a3f7e85d7f97c8383a88a5bc7c2ea8daeb2f > Parent:

[PATCH 07/10] Task Containers(V11): Automatic userspace notification of idle containers

2007-07-20 Thread menage
This patch adds the following files to the container filesystem: notify_on_release - configures/reports whether the container subsystem should attempt to run a release script when this container becomes unused release_agent - configures/reports the release agent to be used for this hierarchy

Re: [linux-pm] Re: Hibernation considerations

2007-07-20 Thread Alan Stern
On Fri, 20 Jul 2007, Milton Miller wrote: > > That's exactly my point. As far as I know nobody has done a survey, > > but I bet you'd find _many_ drivers are buggy either in this way or the > > converse (forcing an I/O request to fail immediately instead of waiting > > until the suspend is over

Re: [linux-pm] Re: Hibernation considerations

2007-07-20 Thread david
On Fri, 20 Jul 2007, Milton Miller wrote: On Jul 20, 2007, at 6:17 AM, Rafael J. Wysocki wrote: On Friday, 20 July 2007 01:07, [EMAIL PROTECTED] wrote: > On Thu, 19 Jul 2007, Rafael J. Wysocki wrote: > > On Thursday, 19 July 2007 17:46, Milton Miller wrote: > > > The currently identified

Re: build fix for x86_64...

2007-07-20 Thread H. Peter Anvin
Andi Kleen wrote: >> Obviously, this is not a panacea; if the original "struct foo" has also >> been introduced on 64 bits before the bug is caught, > > That's usually the case. There is already an established 64bit ABI > This is true. Kind of makes me wonder if the right thing is to

Re: [patch 1/3] m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible

2007-07-20 Thread Dmitry Torokhov
On 7/20/07, Adrian Bunk <[EMAIL PROTECTED]> wrote: On Fri, Jul 20, 2007 at 02:51:02PM -0400, Dmitry Torokhov wrote: > On 7/20/07, Adrian Bunk <[EMAIL PROTECTED]> wrote: >> On Fri, Jul 20, 2007 at 01:47:36PM -0400, Dmitry Torokhov wrote: >> > Hi Geert, >> > >> > On 7/20/07, Geert Uytterhoeven

Re: [patch] slub crashes with recent -git

2007-07-20 Thread Ingo Molnar
* Fernando Lopez-Lezcano <[EMAIL PROTECTED]> wrote: > On Thu, 2007-07-19 at 21:42 +0200, Ingo Molnar wrote: > > Linus, Christoph, > > > > recent slub commits in -git cause this bootup crash: > > > > Freeing unused kernel memory: 324k freed > > Write protecting the kernel read-only data:

RE: [PATCH 5/7] I/OAT: Add support for MSI and MSI-X

2007-07-20 Thread Waskiewicz Jr, Peter P
> Hmm, I see I don't understand what this driver is doing. > What is a "struct ioatdma_device"? Is this driver requesting > interrupts that come from the NIC or the IOAT DMA engine? I might have caused some confusion. You had asked if any drivers support MSI but not MSI-X, so I threw 2

[PATCH 10/10] Task Containers(V11): Simple task container debug info subsystem

2007-07-20 Thread menage
This example subsystem exports debugging information as an aid to diagnosing refcount leaks, etc, in the container framework. Signed-off-by: Paul Menage <[EMAIL PROTECTED]> --- include/linux/container_subsys.h |4 + init/Kconfig | 10 kernel/Makefile

[PATCH 03/10] Task Containers(V11): Add fork()/exit() hooks

2007-07-20 Thread menage
This patch adds the necessary hooks to the fork() and exit() paths to ensure that new children inherit their parent's container assignments, and that exiting processes release reference counts on their containers. Signed-off-by: Paul Menage <[EMAIL PROTECTED]> --- include/linux/container.h |

[PATCH 04/10] Task Containers(V11): Add container_clone() interface.

2007-07-20 Thread menage
This patch adds support for container_clone(), a way to create new containers intended to be used for systems such as namespace unsharing. A new subsystem callback, post_clone(), is added to allow subsystems to automatically configure cloned containers. Signed-off-by: Paul Menage <[EMAIL

[PATCH 06/10] Task Containers(V11): Shared container subsystem group arrays

2007-07-20 Thread menage
This patch replaces the struct css_group embedded in task_struct with a pointer; all tasks that have the same set of memberships across all hierarchies will share a css_group object, and will be linked via their css_groups field to the "tasks" list_head in the css_group. Assuming that many tasks

[PATCH 02/10] Task Containers(V11): Add tasks file interface

2007-07-20 Thread menage
This patch adds the per-directory "tasks" file for containerfs mounts; this allows the user to determine which tasks are members of a container by reading a container's "tasks", and to move a task into a container by writing its pid to its "tasks". Signed-off-by: Paul Menage <[EMAIL PROTECTED]>

[PATCH 05/10] Task Containers(V11): Add procfs interface

2007-07-20 Thread menage
This patch adds: /proc/containers - general system info /proc/*/container - per-task container membership info Signed-off-by: Paul Menage <[EMAIL PROTECTED]> --- fs/proc/base.c|7 ++ include/linux/container.h |2 kernel/container.c| 132

[PATCH 00/10] Task Containers(V11): Introduction

2007-07-20 Thread menage
This is an update to the task containers patchset. Changes since V10 (May 30th) include: - Based on 2.6.22-rc6-mm1 (minus existing container patches, see below) - Rolled in various fix/tidy patches contributed by akpm and others - Reorganisation of the mount/unmount code to use sget(); the new

[PATCH 09/10] Task Containers(V11): Example CPU accounting subsystem

2007-07-20 Thread menage
This example demonstrates how to use the generic container subsystem for a simple resource tracker that counts, for the processes in a container, the total CPU time used and the %CPU used in the last complete 10 second interval. Portions contributed by Balbir Singh <[EMAIL PROTECTED]>

[PATCH] Fix ZERO_OR_NULL_PTR(ZERO_SIZE_PTR)

2007-07-20 Thread Roland Dreier
The comparison with ZERO_SIZE_PTR in ZERO_OR_NULL_PTR() needs to be <= (not just <) so that ZERO_OR_NULL_PTR(ZERO_SIZE_PTR) is 1. Signed-off-by: Roland Dreier <[EMAIL PROTECTED]> --- I finally had time to reproduce Michael's crash and debug it. Linus's patch is part of the story -- it doesn't

Re: [RFC 1/4] CONFIG_STABLE: Define it

2007-07-20 Thread Chuck Ebbert
On 07/20/2007 12:36 PM, Stefan Richter wrote: +config STABLE + bool "Stable kernel" > > PS: Imagine the headlines at Slashdot, CNET et al when this gets in. I think this really should be called CONFIG_EXTRA_CHECKS. It's a lot clearer what that means... - To unsubscribe from

Problem after suspend to ram: NMI received for unknown reason b0.

2007-07-20 Thread Christian P. Schmidt
Hi all, I'm almost happy with my new laptop - I got like 90% of the things working the way I wanted, except the all-time dreaded suspend. Suspend to disk, using the suspend2 patchset, fails because the fingerprint reader on the USB bus apparently does not suspend. Well, I'll go into that later

Re: [linux-pm] Re: Hibernation considerations

2007-07-20 Thread Milton Miller
On Jul 20, 2007, at 1:17 PM, Alan Stern wrote: On Fri, 20 Jul 2007, Milton Miller wrote: On Jul 20, 2007, at 11:20 AM, Alan Stern wrote: On Fri, 20 Jul 2007, Milton Miller wrote: We can't do this unless we have frozen tasks (this way, or another) before carrying out the entire operation.

Re: [patch 1/3] m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible

2007-07-20 Thread Adrian Bunk
On Fri, Jul 20, 2007 at 02:51:02PM -0400, Dmitry Torokhov wrote: > On 7/20/07, Adrian Bunk <[EMAIL PROTECTED]> wrote: >> On Fri, Jul 20, 2007 at 01:47:36PM -0400, Dmitry Torokhov wrote: >> > Hi Geert, >> > >> > On 7/20/07, Geert Uytterhoeven <[EMAIL PROTECTED]> wrote: >> >> From: Geert

Re: [PATCH 5/7] I/OAT: Add support for MSI and MSI-X

2007-07-20 Thread Roland Dreier
> Both igb (recently posted) and ixgbe (also recently posted) support both > MSI and MSI-X. Right now when we try to request MSI-X vectors, if we > fail to acquire what we've asked for, we fall back to MSI support. If > MSI fails to initialize, we fall back to legacy interrupts. So it needs

Re: [PATCH] Fix DMA on Dreamcast

2007-07-20 Thread Andrew Morton
On Thu, 19 Jul 2007 20:30:34 +0100 "Adrian McMenamin" <[EMAIL PROTECTED]> wrote: > I think my first attempt to post this may have got lost in space somewhere. > > Signed-off by: Adrian McMenamin <[EMAIL PROTECTED]> Please provide a description of what problem this change is solving, and how it

Re: [PATCH] hugetlbfs read() support

2007-07-20 Thread Nick Piggin
Andrew Morton wrote: On Thu, 19 Jul 2007 08:51:49 -0700 Badari Pulavarty <[EMAIL PROTECTED]> wrote: + } + + offset += ret; + retval += ret; + len -= ret; + index += offset >> HPAGE_SHIFT; + offset &=

[PATCH] x86_64: Mark nmi_show_regs static

2007-07-20 Thread Josh Triplett
Nothing outside of arch/x86_64/kernel/nmi.c uses nmi_show_regs, so mark it static. Eliminates a sparse warning introduced in -rt: warning: symbol 'nmi_show_regs' was not declared. Should it be static? Signed-off-by: Josh Triplett <[EMAIL PROTECTED]> --- arch/x86_64/kernel/nmi.c |2 +- 1

[-rt PATCH] i386: Mark nmi_show_regs static

2007-07-20 Thread Josh Triplett
Nothing outside of arch/i386/kernel/nmi.c uses nmi_show_regs, so mark it static. Eliminates a sparse warning introduced in -rt: warning: symbol 'nmi_show_regs' was not declared. Should it be static? Signed-off-by: Josh Triplett <[EMAIL PROTECTED]> --- arch/i386/kernel/nmi.c |2 +- 1 files

Re: [patch 1/3] m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible

2007-07-20 Thread Dmitry Torokhov
On 7/20/07, Adrian Bunk <[EMAIL PROTECTED]> wrote: On Fri, Jul 20, 2007 at 01:47:36PM -0400, Dmitry Torokhov wrote: > Hi Geert, > > On 7/20/07, Geert Uytterhoeven <[EMAIL PROTECTED]> wrote: >> From: Geert Uytterhoeven <[EMAIL PROTECTED]> >> >> m68k/mac: Make mac_hid_mouse_emulate_buttons()

[PATCH] CFS: Mark print_cfs_stats static

2007-07-20 Thread Josh Triplett
sched_fair.c defines print_cfs_stats, and sched_debug.c uses it, but sched.c includes both sched_fair.c and sched_debug.c, so all the references to print_cfs_stats occur in the same compilation unit. Thus, mark print_cfs_stats static. Eliminates a sparse warning: warning: symbol

[PATCH] i386: Mark pit_clockevent static

2007-07-20 Thread Josh Triplett
Nothing outside of arch/i386/kernel/i8253.c uses pit_clockevent, so mark it static. Eliminates a sparse warning: warning: symbol 'pit_clockevent' was not declared. Should it be static? Signed-off-by: Josh Triplett <[EMAIL PROTECTED]> --- arch/i386/kernel/i8253.c |2 +- 1 files changed, 1

[PATCH] x86_64: include asm/bugs.h in bugs.c for check_bugs prototype

2007-07-20 Thread Josh Triplett
C files should include the header files that prototype their functions. Eliminates a sparse warning: warning: symbol 'check_bugs' was not declared. Should it be static? Signed-off-by: Josh Triplett <[EMAIL PROTECTED]> --- arch/x86_64/kernel/bugs.c |1 + 1 files changed, 1 insertions(+), 0

[PATCH] Mark sysrq_sched_debug_show static.

2007-07-20 Thread Josh Triplett
Only sched.c uses sysrq_sched_debug_show, and sched.c includes sched_debug.c, so all uses of sysrq_sched_debug_show occur in the same source file. Eliminates a sparse warning: warning: symbol 'sysrq_sched_debug_show' was not declared. Should it be static? Signed-off-by: Josh Triplett <[EMAIL

[PATCH] i386: include asm/bugs.h in bugs.c for check_bugs prototype

2007-07-20 Thread Josh Triplett
C files should include the header files that prototype their functions. Eliminates a sparse warning: warning: symbol 'check_bugs' was not declared. Should it be static? Signed-off-by: Josh Triplett <[EMAIL PROTECTED]> --- arch/i386/kernel/cpu/bugs.c |1 + 1 files changed, 1 insertions(+), 0

Re: [patch 1/3] m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible

2007-07-20 Thread Adrian Bunk
On Fri, Jul 20, 2007 at 01:47:36PM -0400, Dmitry Torokhov wrote: > Hi Geert, > > On 7/20/07, Geert Uytterhoeven <[EMAIL PROTECTED]> wrote: >> From: Geert Uytterhoeven <[EMAIL PROTECTED]> >> >> m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible >> >> drivers/char/keyboard.c: In

Re: [git patches] two warning fixes

2007-07-20 Thread Krzysztof Halasa
Linus Torvalds <[EMAIL PROTECTED]> writes: > More people *should* generally ask themselves: "was the warning worth it?" > and then, if the answer is "no", they shouldn't add code, they should > remove the thing that causes the warning in the first place. Sure. If a routine uses must_check yet

Re: build fix for x86_64...

2007-07-20 Thread Andreas Schwab
"H. Peter Anvin" <[EMAIL PROTECTED]> writes: > struct foo { > u32 bar; > compat_u64 baz; > u32 quux; > }; compat_u64 is only for use in CONFIG_COMPAT code. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg,

Re: [PATCH] kill DECLARE_MUTEX_LOCKED

2007-07-20 Thread Andrew Morton
On Fri, 20 Jul 2007 10:58:34 +0530 "Satyam Sharma" <[EMAIL PROTECTED]> wrote: > Well, probably not worth much, but: Ack. um. The time and effort which you put into reviewing a patch pretty much directly subtracts from the time and effort which I need to put into doing the same. So: worth lots

Re: [PATCH 1/1] i386: Geode's TSC is not neccessary to mark tu unstable

2007-07-20 Thread Andrew Morton
On 19 Jul 2007 15:56:51 +0200 Andi Kleen <[EMAIL PROTECTED]> wrote: > Juergen Beisert <[EMAIL PROTECTED]> writes: > > > Hi Andi, > > > > On Thursday 19 July 2007 11:25, Andi Kleen wrote: > > > On Thursday 19 July 2007 10:52:48 Juergen Beisert wrote: > > > > On Thursday 19 July 2007 10:22, Andi

Re: [linux-pm] Re: Hibernation considerations

2007-07-20 Thread Alan Stern
On Fri, 20 Jul 2007, Milton Miller wrote: > On Jul 20, 2007, at 11:20 AM, Alan Stern wrote: > > On Fri, 20 Jul 2007, Milton Miller wrote: > >>> We can't do this unless we have frozen tasks (this way, or another) > >>> before > >>> carrying out the entire operation. > >> > >> What can't we do?

[PATCH] Use descriptor's functions instead of inline assembly

2007-07-20 Thread Glauber de Oliveira Costa
This patch provides a new set of functions for managing the descriptor tables that can be used instead of putting the raw assembly in .c files. Remodeling of store_tr() suggested by Frederik Deweerdt. Signed-off-by: Glauber de Oliveira Costa <[EMAIL PROTECTED]> diff --git

Re: build fix for x86_64...

2007-07-20 Thread Andi Kleen
> Obviously, this is not a panacea; if the original "struct foo" has also > been introduced on 64 bits before the bug is caught, That's usually the case. There is already an established 64bit ABI -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a

RE: [PATCH 5/7] I/OAT: Add support for MSI and MSI-X

2007-07-20 Thread Waskiewicz Jr, Peter P
> -Original Message- > From: Roland Dreier [mailto:[EMAIL PROTECTED] > Sent: Friday, July 20, 2007 10:43 AM > To: Nelson, Shannon > Cc: [EMAIL PROTECTED]; linux-kernel@vger.kernel.org; > [EMAIL PROTECTED]; [EMAIL PROTECTED]; Williams, Dan J; Leech, > Christopher; Waskiewicz Jr, Peter P

RE: which signal is sent to freeze process?

2007-07-20 Thread Agarwal, Lomesh
Can you suggest a way I can debug the issue why I am getting EINTR error for system calls in resuming? What else can cause the system call failure with EINTR? -Original Message- From: Rafael J. Wysocki [mailto:[EMAIL PROTECTED] Sent: Friday, July 20, 2007 4:24 AM To: Agarwal, Lomesh Cc:

Re: [PATCH 1/2] run scripts/Lindent on it to match Documentation/CodingStyle

2007-07-20 Thread Matthew Wilcox
On Fri, Jul 20, 2007 at 06:36:02PM +0100, Simon Arlott wrote: > On 20/07/07 18:07, Matthew Wilcox wrote: > > sed -i -e 's/^\t* \(\w*:\)/ \1/' "$@" > > > > which will replace the leading tabs and spaces with one space. > > ... isn't the space thing a workaround for a "diff -p" bug? Yes. I

Re: [RFC] what should 'uptime' be on suspend?

2007-07-20 Thread Ken Moffat
On Fri, Jul 20, 2007 at 10:42:15AM -0700, Randy Dunlap wrote: > > man uptime: > uptime - tell how long the system has been running > > I claim that the system is not running when it is suspended, > so the suspension time should not be included in uptime. > So, maybe I shouldn't have put

Re: [patch 3/3] scsi: wd33c93 needs

2007-07-20 Thread Matthew Wilcox
On Fri, Jul 20, 2007 at 09:43:47PM +0400, Sergei Shtylyov wrote: > Hello Christoph: > > >>>+#include > > >>These days that should probably be . > > >Not at all, linux/irq.h is something entirely different. > >Actually, Not for enable/disable_irq. For request_irq, yes. This is

Re: [patch 1/3] m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible

2007-07-20 Thread Dmitry Torokhov
Hi Geert, On 7/20/07, Geert Uytterhoeven <[EMAIL PROTECTED]> wrote: From: Geert Uytterhoeven <[EMAIL PROTECTED]> m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible drivers/char/keyboard.c: In function 'kbd_keycode': drivers/char/keyboard.c:1142: error: implicit declaration of

Re: [patch 3/3] scsi: wd33c93 needs

2007-07-20 Thread Ralf Baechle
On Fri, Jul 20, 2007 at 06:33:59PM +0100, Christoph Hellwig wrote: > On Fri, Jul 20, 2007 at 06:31:32PM +0100, Ralf Baechle wrote: > > > +#include > > > > These days that should probably be . > > Not at all, linux/irq.h is something entirely different. Well, fine. But checkpatch.pl will

Re: build fix for x86_64...

2007-07-20 Thread H. Peter Anvin
Andreas Schwab wrote: > "H. Peter Anvin" <[EMAIL PROTECTED]> writes: > >> No, that would be bad. If compat_u64 is used to carry 32-bit ABIs >> forward into 64-bit space without needing compatibility hacks, then this >> would actually introduce ABI incompatibilities depending on CONFIG_COMPAT! >

Re: [PATCH 5/7] I/OAT: Add support for MSI and MSI-X

2007-07-20 Thread Roland Dreier
are there any devices that support MSI but not MSI-X? If not, is there any point in having code to support both? - R. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [patch 3/3] scsi: wd33c93 needs

2007-07-20 Thread Sergei Shtylyov
Hello Christoph: +#include These days that should probably be . Not at all, linux/irq.h is something entirely different. Actually, WBR, Sergei - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo

Re: build fix for x86_64...

2007-07-20 Thread Andreas Schwab
"H. Peter Anvin" <[EMAIL PROTECTED]> writes: > No, that would be bad. If compat_u64 is used to carry 32-bit ABIs > forward into 64-bit space without needing compatibility hacks, then this > would actually introduce ABI incompatibilities depending on CONFIG_COMPAT! But without CONFIG_COMPAT

Re: [RFC] what should 'uptime' be on suspend?

2007-07-20 Thread Randy Dunlap
On Fri, 20 Jul 2007 18:17:29 +0100 Ken Moffat wrote: > On Thu, Jul 19, 2007 at 10:42:22PM -0400, Bill Davidsen wrote: > > I just found a machine which will resume after suspend to memory, using > > the mainline kernel (no suspend2 patch). > > > > On resume I was looking at the uptime output,

Re: build fix for x86_64...

2007-07-20 Thread H. Peter Anvin
Andi Kleen wrote: > > That doesn't help for any old interfaces, like the one here. For those > still ifdefs are needed. Interfaces that use compat_u64 just use > a normal #ifdef CONFIG_COMPAT. > > Besides I have my doubts compat_u64 will be the solution > to these worries. We have hundreds of

Re: [patch 3/3] scsi: wd33c93 needs

2007-07-20 Thread Matthew Wilcox
On Fri, Jul 20, 2007 at 06:31:32PM +0100, Ralf Baechle wrote: > On Fri, Jul 20, 2007 at 06:40:46PM +0200, Geert Uytterhoeven wrote: > > +#include > > These days that should probably be . Go and read the comments at the top of linux/irq.h. And then report to Russell for your whipping. --

Re: [PATCH 1/2] run scripts/Lindent on it to match Documentation/CodingStyle

2007-07-20 Thread Simon Arlott
On 20/07/07 18:07, Matthew Wilcox wrote: > Of course, we can't add this flag to Lindent until it's widely > circulating amongst the distributions. Perhaps we can add this to > Lindent in the meantime: > > sed -i -e 's/^\t* \(\w*:\)/ \1/' "$@" > > which will replace the leading tabs and

Re: [patch] slub crashes with recent -git

2007-07-20 Thread Fernando Lopez-Lezcano
On Thu, 2007-07-19 at 21:42 +0200, Ingo Molnar wrote: > Linus, Christoph, > > recent slub commits in -git cause this bootup crash: > > Freeing unused kernel memory: 324k freed > Write protecting the kernel read-only data: 1294k Just curious, are the crashes even possible in 2.6.22.1? (I see

Re: [patch 3/3] scsi: wd33c93 needs

2007-07-20 Thread Christoph Hellwig
On Fri, Jul 20, 2007 at 06:31:32PM +0100, Ralf Baechle wrote: > > +#include > > These days that should probably be . Not at all, linux/irq.h is something entirely different. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED]

Re: [PATCH 1/2] run scripts/Lindent on it to match Documentation/CodingStyle

2007-07-20 Thread Matthew Wilcox
On Sun, Jul 15, 2007 at 10:53:45AM +0100, Simon Arlott wrote: > > - } else if (base_addr > 0x100) { /* Check a single specified location. */ > > + } else if (base_addr > 0x100) { /* Check a single specified location. */ > > What is Lit doing here?! It's changed "{/*" to "{/*"... > > > - }

[GIT PULL][RESEND] Late KVM Updates for the 2.6.23 merge window

2007-07-20 Thread Avi Kivity
Linus, Please pull from the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/avi/kvm.git for-linus to get the following changes: Avi Kivity (4): KVM: MMU: Store nx bit for large page shadows KVM: Fix memory slot management functions for guest smp KVM: x86

Re: [linux-pm] Re: Hibernation considerations

2007-07-20 Thread Milton Miller
On Jul 20, 2007, at 11:20 AM, Alan Stern wrote: On Fri, 20 Jul 2007, Milton Miller wrote: We can't do this unless we have frozen tasks (this way, or another) before carrying out the entire operation. What can't we do? We've already worked with the drivers to quesce the hardware and put

Re: [patch 3/3] scsi: wd33c93 needs

2007-07-20 Thread Ralf Baechle
On Fri, Jul 20, 2007 at 06:40:46PM +0200, Geert Uytterhoeven wrote: > --- a/drivers/scsi/wd33c93.c > +++ b/drivers/scsi/wd33c93.c > @@ -89,6 +89,8 @@ > #include > #include > > +#include These days that should probably be . Ralf - To unsubscribe from this list: send the line

Re: [linux-pm] Re: Hibernation considerations

2007-07-20 Thread Jeremy Maitin-Shepard
Milton Miller <[EMAIL PROTECTED]> writes: [snip] (7) how to avoid corrupting filesystems mounted by the hibernated kernel >>> >>> I didn't realize this was a discussion item. I thought the options were >>> clear, for some filesystem types you can mount them read-only, but for >>> ext3 (and

Re: build fix for x86_64...

2007-07-20 Thread Andi Kleen
On Friday 20 July 2007 19:03, H. Peter Anvin wrote: > Luck, Tony wrote: > > Which is better. But if we unconditionally set this CONFIG variable, > > then the code in fs/quota.c will have to read: > > > > #if defined(CONFIG_COMPAT) && defined(CONFIG_COMPAT_FOR_U64_ALIGNMENT) > > > > We can keep it

Re: [RFC] what should 'uptime' be on suspend?

2007-07-20 Thread Ken Moffat
On Thu, Jul 19, 2007 at 10:42:22PM -0400, Bill Davidsen wrote: > I just found a machine which will resume after suspend to memory, using > the mainline kernel (no suspend2 patch). > > On resume I was looking at the uptime output, and it was about six > minutes, FAR longer than the time since

Re: [PATCH] Use wbinvd() macro instead of raw inline assembly in .c files

2007-07-20 Thread H. Peter Anvin
Andi Kleen wrote: > On Friday 20 July 2007 00:55:40 Glauber de Oliveira Costa wrote: >> This patch uses the already-existant wbinvd() macro to replace >> raw assembly to perform this very same task in some .c files >> >> Signed-off-by: Glauber de Oliveira Costa <[EMAIL PROTECTED]> >> >> diff

Re: [patch 3/3] scsi: wd33c93 needs

2007-07-20 Thread Adrian Bunk
On Fri, Jul 20, 2007 at 11:48:57AM -0500, James Bottomley wrote: > On Fri, 2007-07-20 at 18:40 +0200, Geert Uytterhoeven wrote: > > plain text document attachment (m68k-wd33c93-needs-asm-irq.diff) > > wd33c93 SCSI needs on m68k > > > > drivers/scsi/wd33c93.c: In function 'wd33c93_host_reset': >

Re: [patches] [PATCH] [17/58] i386: Add L3 cache support to AMD CPUID4 emulation

2007-07-20 Thread Andreas Herrmann
I think, Joachim's patch (sent to [EMAIL PROTECTED] on June 14) should be added as well. I have attached his patch below. Regards, Andreas -- Operating | AMD Saxony Limited Liability Company & Co. KG, System | Wilschdorfer Landstr. 101, 01109 Dresden, Germany Research | Register Court

Re: TR: Neep help with my MMC driver ...

2007-07-20 Thread Nicolas Ferre
Pierre Ossman : On Fri, 20 Jul 2007 15:44:18 +0200 "Pierre Savary" <[EMAIL PROTECTED]> wrote: Hi, I permit me to send you a mail because I've seen on the net that you have work around MMC. Well, I am the maintainer ;) Also, you should include the LKML for these discussions. Linux

Re: [linux-pm] Re: Hibernation considerations

2007-07-20 Thread Milton Miller
On Jul 20, 2007, at 6:17 AM, Rafael J. Wysocki wrote: On Friday, 20 July 2007 01:07, [EMAIL PROTECTED] wrote: On Thu, 19 Jul 2007, Rafael J. Wysocki wrote: On Thursday, 19 July 2007 17:46, Milton Miller wrote: The currently identified problems under discussion include: (1) how to interact

Re: [PATCH 1/2] run scripts/Lindent on it to match Documentation/CodingStyle

2007-07-20 Thread Matthew Wilcox
On Sun, Jul 15, 2007 at 10:53:45AM +0100, Simon Arlott wrote: > Do people ever check what Lindent does? [...] > > -out1: > > + out1: > > NAK: A perfectly valid non-indented label is now indented by 6 spaces. I tracked down why indent does this. It's actually hard-coded to indent by 2 fewer

Re: [patch 3/3] scsi: wd33c93 needs

2007-07-20 Thread Geert Uytterhoeven
On Fri, 20 Jul 2007, James Bottomley wrote: > On Fri, 2007-07-20 at 18:40 +0200, Geert Uytterhoeven wrote: > > plain text document attachment (m68k-wd33c93-needs-asm-irq.diff) > > wd33c93 SCSI needs on m68k > > > > drivers/scsi/wd33c93.c: In function 'wd33c93_host_reset': > >

Re: build fix for x86_64...

2007-07-20 Thread H. Peter Anvin
Luck, Tony wrote: > > Which is better. But if we unconditionally set this CONFIG variable, then the > code in fs/quota.c will have to read: > > #if defined(CONFIG_COMPAT) && defined(CONFIG_COMPAT_FOR_U64_ALIGNMENT) > > We can keep it simpler if the Kconfig file does the conditional for us: >

Re: [patches] [PATCH] [17/58] i386: Add L3 cache support to AMD CPUID4 emulation

2007-07-20 Thread Andreas Herrmann
On Thu, Jul 19, 2007 at 11:55:02AM +0200, Andi Kleen wrote: > > With that an L3 cache is correctly reported in the cache information in /sys > > With fixes from Andreas Herrmann and Dean Gaudet > > Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> > > --- > arch/i386/kernel/cpu/intel_cacheinfo.c

Re: [GIT PULL] Trivial sh64 updates for 2.6.23-rc1

2007-07-20 Thread Jan Dittmer
Paul Mundt wrote: Paul Mundt (5): sh64: Wire up fallocate() syscall. sh64: Update cayman defconfig. sh64: Fix up PCI section mismatch warnings. sh64: Move entry point code to .text.head. sh64: Flag sh64_get_page() as __init_refok. Tangential question. Which is the

Re: [RFC 1/4] CONFIG_STABLE: Define it

2007-07-20 Thread Stefan Richter
Chris Snook wrote: > There are many different ways you can use it. If I'm writing a configurable > feature, I could make it depend on !CONFIG_STABLE, or I could ifdef my code > out > if CONFIG_STABLE is set, unless a more granular option is also set. The > maintainer of the code that uses

[PATCH] 80386 and 80486 cmpxchg64 and cmpxchg64_local fallback

2007-07-20 Thread Mathieu Desnoyers
Fall back on interrupt disable in cmpxchg8b on 80386 and 80486 Actually, on 386, cmpxchg and cmpxchg_local fall back on cmpxchg_386_u8/16/32: it disables interruptions around non atomic updates to mimic the cmpxchg behavior. The comment: /* Poor man's cmpxchg for 386. Unsuitable for SMP */ in

Re: build fix for x86_64...

2007-07-20 Thread Matthew Wilcox
On Fri, Jul 20, 2007 at 09:20:15AM -0700, Luck, Tony wrote: > Which is better. But if we unconditionally set this CONFIG variable, then the > code in fs/quota.c will have to read: > > #if defined(CONFIG_COMPAT) && defined(CONFIG_COMPAT_FOR_U64_ALIGNMENT) > > We can keep it simpler if the

Re: [patch 3/3] scsi: wd33c93 needs

2007-07-20 Thread James Bottomley
On Fri, 2007-07-20 at 18:40 +0200, Geert Uytterhoeven wrote: > plain text document attachment (m68k-wd33c93-needs-asm-irq.diff) > wd33c93 SCSI needs on m68k > > drivers/scsi/wd33c93.c: In function 'wd33c93_host_reset': > drivers/scsi/wd33c93.c:1582: error: implicit declaration of function >

[PATCH] Fix Lindent to not indent preprocessor comments so far

2007-07-20 Thread Matthew Wilcox
I recently ran Lindent over the AdvanSys driver and it moved the comments on #else and #endif lines way over to the right: #else /* ADVANSYS_DEBUG */ This doesn't match what I expect from kernel style, but it is documented. We just need another flag to indent to make

Re: [PATCH] [updated] PHY fixed driver: rework release path and update phy_id notation

2007-07-20 Thread Scott Wood
On Fri, Jul 20, 2007 at 12:57:02AM -0700, Andrew Morton wrote: > On Fri, 20 Jul 2007 11:50:39 +0400 Vitaly Bordug <[EMAIL PROTECTED]> wrote: > > On Thu, 19 Jul 2007 23:23:37 -0700 > > Andrew Morton wrote: > > > Shouldn't these be runtime options (ie: module parameters)? > > > > > I thought about

Re: [linux-pm] Re: Hibernation considerations

2007-07-20 Thread Alan Stern
On Fri, 20 Jul 2007 [EMAIL PROTECTED] wrote: > or the userspace helper functions that setup the instructions for the > hibernate warn you if you are telling it to mount a filesystem that it > knows is ext3 and is in use by the system going to sleep. One can argue that the ext3 implementation

[patch 3/3] scsi: wd33c93 needs

2007-07-20 Thread Geert Uytterhoeven
wd33c93 SCSI needs on m68k drivers/scsi/wd33c93.c: In function 'wd33c93_host_reset': drivers/scsi/wd33c93.c:1582: error: implicit declaration of function 'disable_irq' drivers/scsi/wd33c93.c:1603: error: implicit declaration of function 'enable_irq' The driver still compiles on MIPS

[patch 2/3] netdev: i82596 Ethernet needs

2007-07-20 Thread Geert Uytterhoeven
netdev: i82596 Ethernet needs on m68k drivers/net/82596.c: In function 'init_rx_bufs': drivers/net/82596.c:552: error: implicit declaration of function 'cache_clear' drivers/net/82596.c: In function 'i596_start_xmit': drivers/net/82596.c:1104: error: implicit declaration of function 'cache_push'

[patch 1/3] m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible

2007-07-20 Thread Geert Uytterhoeven
From: Geert Uytterhoeven <[EMAIL PROTECTED]> m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible drivers/char/keyboard.c: In function 'kbd_keycode': drivers/char/keyboard.c:1142: error: implicit declaration of function 'mac_hid_mouse_emulate_buttons' The forward declaration of

<    1   2   3   4   5   6   7   8   9   10   >