Re: [Linux-usb-users] [REGRESSION] 2.6.23-rc1: uhci_hcd. irq 4: nobody cared
On Sun, Jul 29, 2007 at 11:19:47AM -0400, Alan Stern wrote: > On Sun, 29 Jul 2007, Mark Hindley wrote: > > > Hi, > > > > I have just tried 2.6.23-rc1 on my Acer Aspire 1350. > > > > On boot I get the following error as the uhci_hcd module is loaded: > > > > Jul 28 18:23:20 mercury kernel: ACPI: PCI Interrupt :00:10.0[A] -> Link > > [LNKA] -> GSI 4 (level, low) -> IRQ 4 > > Jul 28 18:23:20 mercury kernel: uhci_hcd :00:10.0: UHCI Host Controller > > Jul 28 18:23:20 mercury kernel: uhci_hcd :00:10.0: new USB bus > > registered, assigned bus number 2 > > Jul 28 18:23:20 mercury kernel: irq 4: nobody cared (try booting with the > > "irqpoll" option) > > Did it work okay with older kernels? What does /proc/interrupts say in > both 2.6.23-rc1 and in a working kernel? No boot error with 2.6.22.1. On 2.6.22.1: CPU0 0: 12312XT-PIC-XTtimer 1:286XT-PIC-XTi8042 2: 0XT-PIC-XTcascade 4:434XT-PIC-XTuhci_hcd:usb2, [EMAIL PROTECTED]::01:00.0 5: 2000XT-PIC-XTyenta, uhci_hcd:usb3, wifi0 6: 3XT-PIC-XTfloppy 7: 3XT-PIC-XTparport0 8: 4XT-PIC-XTrtc 9: 0XT-PIC-XTuhci_hcd:usb4, VIA82XX-MODEM, VIA8233 10:843XT-PIC-XTacpi 11: 0XT-PIC-XTehci_hcd:usb1 12:123XT-PIC-XTi8042 14: 10951XT-PIC-XTide0 15: 53XT-PIC-XTide1 NMI:770 LOC: 120091 ERR: 0 MIS: 0 On 2.6.23-rc1: CPU0 0: 8616XT-PIC-XTtimer 1:183XT-PIC-XTi8042 2: 0XT-PIC-XTcascade 4: 8233XT-PIC-XTuhci_hcd:usb1, [EMAIL PROTECTED]::01:00.0 5: 4948XT-PIC-XTuhci_hcd:usb2, yenta, wifi0 6: 3XT-PIC-XTfloppy 7: 22XT-PIC-XTparport0 8: 4XT-PIC-XTrtc 9: 0XT-PIC-XTuhci_hcd:usb3, VIA82XX-MODEM, VIA8233 10:854XT-PIC-XTacpi 11: 0XT-PIC-XTehci_hcd:usb4 12:123XT-PIC-XTi8042 14: 12202XT-PIC-XTide0 15: 53XT-PIC-XTide1 NMI:809 LOC: 150284 ERR: 1 MIS: 0 Mark - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] drivers/bluetooth/hci_ldisc.c: fix possible NULL dereferences
Hi Eugene,
> Commit 22ad42033b7d2b3d7928fba9f89d1c7f8a3c9581 did not completely fix all
> the possible NULL dereferences. Besides hci_uart_close(), we also need to
> make sure that hdev is valid before calling hci_{unregister,free}_dev().
I don't see any issue. Without HCI_UART_PROTO_SET, the hdev will never
be registered. So no need to protect it twice.
Regards
Marcel
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [-mm patch] kernel/printk.c: make 2 variables static
On Sun, 29 Jul 2007 16:59:18 +0200 Adrian Bunk wrote:
> On Wed, Jul 25, 2007 at 04:03:04AM -0700, Andrew Morton wrote:
> >...
> > Changes since 2.6.22-rc6-mm1:
> >...
> > +slow-down-printk-during-boot.patch
> >...
> > Misc
> >...
>
> This patch makes two needlessly global variables static.
>
> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
Aye. Thanks.
> ---
> --- linux-2.6.23-rc1-mm1/kernel/printk.c.old 2007-07-26 22:40:09.0
> +0200
> +++ linux-2.6.23-rc1-mm1/kernel/printk.c 2007-07-26 22:40:50.0
> +0200
> @@ -166,8 +166,8 @@
>
> #ifdef CONFIG_BOOT_PRINTK_DELAY
>
> -unsigned int boot_delay; /* msecs delay after each printk during bootup */
> -unsigned long long printk_delay_msec; /* per msec, based on boot_delay */
> +static unsigned int boot_delay; /* msecs delay after each printk during
> bootup */
> +static unsigned long long printk_delay_msec; /* per msec, based on
> boot_delay */
>
> static int __init boot_delay_setup(char *str)
> {
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: Reading a bad sector does not report failure as 'read error' but hangs PC with 'Machine Check Exception'
> > HARDWARE ERROR > > CPU 0: Machine Check Exception: 4 Bank 4: > > b2070f0f > > TSC b7d4a144d0 > > This is not a software problem! > > Run through mcelog --ascii to decode and contact > your > > hardware vendor > > Kernel panic - not syncing: Machine check > > You should run this through mcelog as it suggests > and see what it shows. > The kernel should be handling this properly, > unless the drive problem > is causing the controller to do something bad. Note > that kernels 2.6.20 > and later use ADMA mode on the nForce4 SATA > controller whereas previous > versions used it essentially like a PATA controller, > so it is not > surprising that the behavior is different. How can I do this? I have installed mcelog but I cannot run it after the MCE error because the whole PC hangs. If I try it after a reboot with 'mcelog --k8 --ascii' or whatever parameter, there is no output at all. If I try to redirect the output to the syslog, nothing is in there because the computer stopped working and did not save the log anymore. Isn't it strange to say that the controller does something bad if there is just a bad sector on the drive that is reported and handled correctly in an older kernel (I have confirmed a bad sector on the drive using the Seatools software from Seagate)? In my opinion a kernel should not stop responding at all with a bad sector on the disk. I cannot change the controller's behavior and did all the updates there are to make in function, but the problem is introduced using the newer kernel series. Perhaps nobody has tried accessing a bad SATA drive before, to simulate such an error? If it helps I could try a different type of motherboard to see what happens there? (Asus M2NPV-VM) Regards, Hendrik Moody friends. Drama queens. Your life? Nope! - their life, your story. Play Sims Stories at Yahoo! Games. http://sims.yahoo.com/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Fix compilation for non CONFIG_HOTPLUG case
Hello.
Niklaus Giger wrote:
Fixes compilation issues for embedded boards which do not support HOTPLUG
Signed-off-by: Niklaus Giger <[EMAIL PROTECTED]>
diff --git a/drivers/base/core.c b/drivers/base/core.c
index 3599ab2..a09bfc8 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -24,7 +24,9 @@
#include "base.h"
#include "power/power.h"
+#ifdef CONFIG_HOTPLUG
extern const char *kobject_actions[];
+#endif
No need for #ifdef around extern declarations.
int (*platform_notify)(struct device * dev) = NULL;
int (*platform_notify_remove)(struct device * dev) = NULL;
@@ -306,11 +308,13 @@ static ssize_t store_uevent(struct device *dev, struct
device_attribute *attr,
const char *buf, size_t count)
{
size_t len = count;
+#ifdef CONFIG_HOTPLUG
enum kobject_action action;
-
+#endif
Please don't remove newline between the declaration block and the code.
if (len && buf[len-1] == '\n')
len--;
+#ifdef CONFIG_HOTPLUG
for (action = 0; action < KOBJ_MAX; action++) {
if (strncmp(kobject_actions[action], buf, len) != 0)
continue;
@@ -319,11 +323,14 @@ static ssize_t store_uevent(struct device *dev, struct
device_attribute *attr,
kobject_uevent(>kobj, action);
goto out;
Grr... cleanup style abuse -- ISO a mere return they used goto. :-/
}
+#endif
dev_err(dev, "uevent: unsupported action-string; this will "
"be ignored in a future kernel version\n");
kobject_uevent(>kobj, KOBJ_ADD);
+#ifdef CONFIG_HOTPLUG
out:
+#endif
Well, #ifdef'ing out label seems too much.
return count;
}
WBR, Sergei
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6 patch] unexport pm_power_off_prepare
On Sunday, 29 July 2007 16:59, Adrian Bunk wrote:
> This patch removes the unused EXPORT_SYMBOL(pm_power_off_prepare).
>
> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
Acked-by: Rafael J. Wysocki <[EMAIL PROTECTED]>
> ---
> --- linux-2.6.23-rc1-mm1/kernel/sys.c.old 2007-07-28 07:38:45.0
> +0200
> +++ linux-2.6.23-rc1-mm1/kernel/sys.c 2007-07-28 07:38:59.0 +0200
> @@ -104,7 +104,6 @@ EXPORT_SYMBOL(cad_pid);
> */
>
> void (*pm_power_off_prepare)(void);
> -EXPORT_SYMBOL(pm_power_off_prepare);
>
> static int set_one_prio(struct task_struct *p, int niceval, int error)
> {
>
>
>
--
"Premature optimization is the root of all evil." - Donald Knuth
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6 patch] drivers/base/power/: make 2 functions static
On Sunday, 29 July 2007 16:56, Adrian Bunk wrote:
> suspend_device() and resume_device() can now become static.
>
> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
>
> ---
Acked-by: Rafael J. Wysocki <[EMAIL PROTECTED]>
> drivers/base/power/power.h |6 --
> drivers/base/power/resume.c |2 +-
> drivers/base/power/suspend.c |2 +-
> 3 files changed, 2 insertions(+), 8 deletions(-)
>
> --- linux-2.6.23-rc1-mm1/drivers/base/power/power.h.old 2007-07-26
> 05:14:12.0 +0200
> +++ linux-2.6.23-rc1-mm1/drivers/base/power/power.h 2007-07-26
> 05:15:49.0 +0200
> @@ -55,12 +55,6 @@
>
> extern void dpm_resume(void);
> extern void dpm_power_up(void);
> -extern int resume_device(struct device *);
> -
> -/*
> - * suspend.c
> - */
> -extern int suspend_device(struct device *, pm_message_t);
>
> #else /* CONFIG_PM */
>
> --- linux-2.6.23-rc1-mm1/drivers/base/power/resume.c.old 2007-07-26
> 05:14:28.0 +0200
> +++ linux-2.6.23-rc1-mm1/drivers/base/power/resume.c 2007-07-26
> 05:14:39.0 +0200
> @@ -20,7 +20,7 @@
> *
> */
>
> -int resume_device(struct device * dev)
> +static int resume_device(struct device * dev)
> {
> int error = 0;
>
> --- linux-2.6.23-rc1-mm1/drivers/base/power/suspend.c.old 2007-07-26
> 05:16:00.0 +0200
> +++ linux-2.6.23-rc1-mm1/drivers/base/power/suspend.c 2007-07-26
> 05:16:17.0 +0200
> @@ -54,7 +54,7 @@
> * @state: Power state device is entering.
> */
>
> -int suspend_device(struct device * dev, pm_message_t state)
> +static int suspend_device(struct device * dev, pm_message_t state)
> {
> int error = 0;
>
>
>
>
--
"Premature optimization is the root of all evil." - Donald Knuth
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: TCP SACK issue, hung connection, tcpdump included
On Sun, 29 Jul 2007, Willy Tarreau wrote: > On Sun, Jul 29, 2007 at 12:28:04PM +0300, Ilpo Järvinen wrote: > > > [...snip...] > > > > > BTW, some information are missing. It would have been better if the trace > > > had been read with tcpdump -Svv. We would have got seq numbers and ttl. > > > Also, we do not know if there's a firewall between both sides. Sometimes, > > > some IDS identify attacks in crypted traffic and kill connections. It > > > might have been the case here, with the connection closed one way on an > > > intermediate firewall. > > > > Yeah, firewall or some other issue, I'd say it's quite unlikely a bug in > > TCP because behavior to both directions indicate client -> sender > > blackhole independently of each other... > > It would also be possible that something stupid between both ends simply > drops packets with the SACK option set. Also something which sometimes > happen is that some firewalls automatically translate sequence numbers > but not necessarily SACK values, which could pretty well lead to this > packet being received but ignored on the server side. ...One can toggle those off with /proc/sys/net/ipv4/tcp_dsack but I suspect DSACKs are not the cause because these retransmissions neither are making it through (there are many of them also earlier in the log, just quoted the easiest ones :-) ): > > > > 09:36:44.335591 IP CLIENT.50727 > SERVER.ssh: P 2991:3039(48) ack 18464 > > > > win > > > > 378 > > > > 09:38:44.351950 IP CLIENT.50727 > SERVER.ssh: P 2991:3039(48) ack 18464 > > > > win > > > > 378 > > > > 09:40:44.368172 IP CLIENT.50727 > SERVER.ssh: P 2991:3039(48) ack 18464 > > > > win > > > > 378 ...there are no SACKs involved in them, yet no cumulative ACK ever arrives from SERVER... -- i.
checkpatch.pl false positive on exported pointers
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable #563: FILE: drivers/scsi/iioc34x/iioc34x_sas.c:58: +EXPORT_SYMBOL(iioc34x_transport_template); drivers/scsi/iioc34x/iioc34x_sas.c:57 struct scsi_transport_template *iioc34x_transport_template; EXPORT_SYMBOL(iioc34x_transport_template); I suspect the script wants: EXPORT_SYMBOL(*iioc34x_transport_template); ...but that does not compile. Thanks, Dan - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6 patch] make kernel/power/main.c:suspend_enter() static
On Sunday, 29 July 2007 16:57, Adrian Bunk wrote:
> suspend_enter() can now become static.
>
> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
>
> ---
Acked-by: Rafael J. Wysocki <[EMAIL PROTECTED]>
> kernel/power/main.c |2 +-
> kernel/power/power.h |1 -
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> --- linux-2.6.23-rc1-mm1/kernel/power/power.h.old 2007-07-26
> 14:49:29.0 +0200
> +++ linux-2.6.23-rc1-mm1/kernel/power/power.h 2007-07-26 14:49:36.0
> +0200
> @@ -177,7 +177,6 @@
> unsigned int, char *);
>
> /* kernel/power/main.c */
> -extern int suspend_enter(suspend_state_t state);
> extern int suspend_devices_and_enter(suspend_state_t state);
> extern struct blocking_notifier_head pm_chain_head;
>
> --- linux-2.6.23-rc1-mm1/kernel/power/main.c.old 2007-07-26
> 14:49:44.0 +0200
> +++ linux-2.6.23-rc1-mm1/kernel/power/main.c 2007-07-26 14:50:05.0
> +0200
> @@ -120,7 +120,7 @@
> *
> * This function should be called after devices have been suspended.
> */
> -int suspend_enter(suspend_state_t state)
> +static int suspend_enter(suspend_state_t state)
> {
> int error = 0;
>
>
>
>
--
"Premature optimization is the root of all evil." - Donald Knuth
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [lm-sensors] [2.6 patch] make abituguru3_read_increment_offset() static
Adrian Bunk wrote:
abituguru3_read_increment_offset() can become static.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
Looks good, good catch.
Acked-by: Hans de Goede <[EMAIL PROTECTED]>
---
--- linux-2.6.23-rc1-mm1/drivers/hwmon/abituguru3.c.old 2007-07-26
08:56:33.0 +0200
+++ linux-2.6.23-rc1-mm1/drivers/hwmon/abituguru3.c 2007-07-26
08:57:00.0 +0200
@@ -691,8 +691,9 @@
/* Sensor settings are stored 1 byte per offset with the bytes
placed add consecutive offsets. */
-int abituguru3_read_increment_offset(struct abituguru3_data *data, u8 bank,
- u8 offset, u8 count, u8 *buf, int offset_count)
+static int abituguru3_read_increment_offset(struct abituguru3_data *data,
+ u8 bank, u8 offset, u8 count,
+ u8 *buf, int offset_count)
{
int i, x;
___
lm-sensors mailing list
[EMAIL PROTECTED]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] ac97/ac97_codec.c: make 2 functions stacic
Hello,
Fix sparc64 warnings.
sound/pci/ac97/ac97_patch.h:86: warning: 'snd_ac97_restore_status' declared
'static' but never defined
sound/pci/ac97/ac97_patch.h:87: warning: 'snd_ac97_restore_iec958' declared
'static' but never defined
Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]>
sound/pci/ac97/ac97_codec.c | 93823 -> 93837 (+14 bytes)
sound/pci/ac97/ac97_codec.o | 341841 -> 341841 (0 bytes)
sound/pci/ac97/ac97_codec.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- linux-2.6.23-rc1-mm1-a/sound/pci/ac97/ac97_codec.c 2007-07-26
13:07:39.0 +0200
+++ linux-2.6.23-rc1-mm1-b/sound/pci/ac97/ac97_codec.c 2007-07-29
17:53:23.0 +0200
@@ -2436,7 +2436,7 @@ EXPORT_SYMBOL(snd_ac97_suspend);
/*
* restore ac97 status
*/
-void snd_ac97_restore_status(struct snd_ac97 *ac97)
+static void snd_ac97_restore_status(struct snd_ac97 *ac97)
{
int i;
@@ -2457,7 +2457,7 @@ void snd_ac97_restore_status(struct snd_
/*
* restore IEC958 status
*/
-void snd_ac97_restore_iec958(struct snd_ac97 *ac97)
+static void snd_ac97_restore_iec958(struct snd_ac97 *ac97)
{
if (ac97->ext_id & AC97_EI_SPDIF) {
if (ac97->regs[AC97_EXTENDED_STATUS] & AC97_EA_SPDIF) {
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: TCP SACK issue, hung connection, tcpdump included
On Sun, Jul 29, 2007 at 12:28:04PM +0300, Ilpo Järvinen wrote:
(...)
> > > Limitation for 48 byte segments? You have to be kidding... :-) But yes,
> > > it seems that one of the directions is dropping packets for some reason
> > > though I would not assume MTU limitation... Or did you mean some other
> > > segment?
> >
> > No, I was talking about the 1448 bytes segments. But in fact I don't
> > believe it much because the SACKs are always retransmitted just afterwards.
>
> Ah, but it's ACKed correctly right below it...:
>
> [...snip...]
> > > > > 09:21:39.490740 IP SERVER.ssh > CLIENT.50727: P 18200:18464(264) ack
> > > > > 2991
> > > > > win 2728
> > > > > 09:21:39.490775 IP CLIENT.50727 > SERVER.ssh: . ack 18464 win 378
> > > > >
> > > > > 09:21:39.860245 IP SERVER.ssh > CLIENT.50727: . 12408:13856(1448) ack
> > > > > 2991
> > > > > win 2728
>
> ...segment below snd_una arrived => snd_una remains 18464, receiver
> generates a duplicate ACK:
>
> > > > > 09:21:39.860302 IP CLIENT.50727 > SERVER.ssh: . ack 18464 win 378
> > > > > > > > > {12408:13856} >
>
> The cumulative ACK field of it covers _everything_ below 18464 (i.e., it
> ACKs them), including the 1448 bytes in 12408:13856... In addition, the
> SACK block is DSACK information [RFC2883] telling explicitly the address
> of the received duplicate block. However, if this ACK doesn't reach the
> SERVER TCP, RTO is triggered and the first not yet cumulatively ACKed
> segment is retransmitted (I guess cumulative ACKs up to 12408 arrived
> without problems to the SERVER):
Oh yes, you're damn right. I did not notice that the ACK was higher than
the SACK, I'm more used to read traces with absolute rather than relative
seq/acks.
So I agree, it is this ACK which is lost between client and server,
reinforcing the supposition about the location of the capture (client side).
> [...snip...]
>
> > BTW, some information are missing. It would have been better if the trace
> > had been read with tcpdump -Svv. We would have got seq numbers and ttl.
> > Also, we do not know if there's a firewall between both sides. Sometimes,
> > some IDS identify attacks in crypted traffic and kill connections. It
> > might have been the case here, with the connection closed one way on an
> > intermediate firewall.
>
> Yeah, firewall or some other issue, I'd say it's quite unlikely a bug in
> TCP because behavior to both directions indicate client -> sender
> blackhole independently of each other...
It would also be possible that something stupid between both ends simply
drops packets with the SACK option set. Also something which sometimes
happen is that some firewalls automatically translate sequence numbers
but not necessarily SACK values, which could pretty well lead to this
packet being received but ignored on the server side.
I'm pretty sure that the same trace taken on the server side will reveal
the reason for the problem.
Willy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: nvidia installer DIW with 2.6.23-rc1
Jan Engelhardt wrote: > On Jul 29 2007 10:57, Gene Heskett wrote: >> /tmp/selfgz9678/NVIDIA-Linux-x86-100.14.11-pkg1/usr/src/nv/nv.c: In >> function >> ‘nvidia_init_module’: >> /tmp/selfgz9678/NVIDIA-Linux-x86-100.14.11-pkg1/usr/src/nv/nv.c:1326: >> error: >> too many arguments to function ‘kmem_cache_create’ ... > Fix the source until they have a fix. It seems to be > just an extra argument to kmem_cache_create that got removed. Gene, the last argument to kmem_cache_create has been removed. It should be a simple matter to delete it from the caller, since it already was unsupported by the callees in previous kernels. http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=20c2df83d25c6a95affe6157a4c9cac4cf5ffaac http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blobdiff;f=mm/slab.c;h=bde271c001ba33ef1f61dd0f563f74d319cd1f0e;hp=c3feeaab387537ef00aa2085b4f54f6d7e4abca0 -- Stefan Richter -=-=-=== -=== ===-= http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: RFT: updatedb "morning after" problem [was: Re: -mm merge plans for 2.6.23]
On 7/29/07, Rene Herman <[EMAIL PROTECTED]> wrote: > On 07/29/2007 05:20 PM, Ray Lee wrote: > This seems to be now fixing the different problem of swap-space filling up. > I'm quite willing to for now assume I've got plenty free. I was trying to point out that currently, as an example, memory that is linear in a process' space could be fragmented on disk when swapped out. That's today. Under a log-structured scheme, one could set it up such that something that was linear in RAM could be swapped out linearly on the drive, minimizing seeks on writeout, which will naturally minimize seeks on swap in of that same data. > > So, at some point when the system needs to fault those blocks that > > back in, it now has a linear span of sectors to read instead of asking > > the drive to bounce over twenty tracks for a hundred blocks. > > Moreover though -- what I know about log structure is that generally it > optimises for write (swapout) and might make read (swapin) worse due to > fragmentation that wouldn't happen with a regular fs structure. It looks like I'm not doing a very good job of explaining this, I'm afraid. Suffice it to say that a log structured swap would give optimization options that we don't have today. > I guess that cleaner that Alan mentioned might be involved there -- I don't > know how/what it would be doing. Then you should google on `log structured filesystem (primer OR introduction)` and read a few of the links that pop up. You might find it interesting. > I am very aware of the costs of seeks (on current magnetic media). Then perhaps you can just take it on faith -- log structured layouts are designed to help minimize seeks, read and write. Ray - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: 2.6.23-rc1-mm1
On Wed, 25 Jul 2007 04:03:04 -0700 Andrew Morton <[EMAIL PROTECTED]> wrote: > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc1/2.6.23-rc1-mm1/ > Hi, I get an oops when trying to mount an ISO file using the loopback device. If I revert the patch 'loop-use-unlocked_ioctl.patch' the mount works. Here's the oops: [ 85.697033] Unable to handle kernel NULL pointer dereference at 0100 RIP: [ 85.702528] [] lo_ioctl+0x25/0xaa0 [ 85.710066] PGD 73fd067 PUD 735b067 PMD 0 [ 85.714221] Oops: [1] PREEMPT SMP [ 85.718117] CPU 1 [ 85.720159] Modules linked in: [ 85.723242] Pid: 3976, comm: mount Not tainted 2.6.23-rc1-mm1 #4 [ 85.729247] RIP: 0010:[] [] lo_ioctl+0x25/0xaa0 [ 85.737011] RSP: 0018:8100076a3708 EFLAGS: 00010282 [ 85.742326] RAX: 80477860 RBX: fdfd RCX: 5310 [ 85.749459] RDX: 8100076a3b58 RSI: 5310 RDI: [ 85.756591] RBP: 8100076a3908 R08: 8100076a3b58 R09: 81000649da80 [ 85.763723] R10: R11: R12: 5310 [ 85.770856] R13: 8100076a3b58 R14: 5310 R15: [ 85.777988] FS: 2b4fab3a0e20() GS:810004017180() knlGS: [ 85.786081] CS: 0010 DS: ES: CR0: 8005003b [ 85.791829] CR2: 0100 CR3: 073d7000 CR4: 06e0 [ 85.798970] DR0: DR1: DR2: [ 85.806102] DR3: DR6: 0ff0 DR7: 0400 [ 85.813235] Process mount (pid: 3976, threadinfo 8100076a2000, task 8100062f66d0) [ 85.821413] Stack: 00020001 8100062f6e90 8100062f6e90 0013638a [ 85.829533] 80a78ef0 8100076a37b8 8025c690 [ 85.837020] 8100062f66d0 8100062f6e58 00020001 [ 85.844308] Call Trace: [ 85.846961] [] __lock_acquire+0x3d0/0x1170 [ 85.852715] [] mark_held_locks+0x3e/0x80 [ 85.858290] [] __mutex_lock_slowpath+0x1ca/0x330 [ 85.864565] [] mark_held_locks+0x3e/0x80 [ 85.870139] [] mutex_unlock+0x9/0x10 [ 85.875366] [] __mutex_unlock_slowpath+0xd9/0x1a0 [ 85.881720] [] trace_hardirqs_on+0xda/0x180 [ 85.887555] [] mutex_unlock+0x9/0x10 [ 85.892782] [] do_open+0x231/0x320 [ 85.897839] [] blkdev_driver_ioctl+0x43/0x90 [ 85.903758] [] blkdev_ioctl+0x2c9/0x780 [ 85.909247] [] trace_hardirqs_on_thunk+0x35/0x37 [ 85.915522] [] restore_args+0x0/0x30 [ 85.920751] [] kill_bdev+0x0/0x40 [ 85.925718] [] ioctl_by_bdev+0x34/0x50 [ 85.931119] [] isofs_fill_super+0x969/0xaf0 [ 85.936954] [] sget+0x3c/0x3f0 [ 85.941662] [] test_bdev_super+0x0/0x20 [ 85.947150] [] _spin_unlock+0x30/0x60 [ 85.952464] [] test_bdev_super+0x0/0x20 [ 85.957951] [] sget+0x3ea/0x3f0 [ 85.962747] [] strlcpy+0x4f/0x70 [ 85.967628] [] get_sb_bdev+0x15c/0x190 [ 85.973029] [] isofs_fill_super+0x0/0xaf0 [ 85.978693] [] isofs_get_sb+0x13/0x20 [ 85.984006] [] vfs_kern_mount+0x58/0xc0 [ 85.989494] [] do_mount+0x206/0x850 [ 85.994635] [] __mod_zone_page_state+0x21/0x90 [ 86.000729] [] rmqueue_bulk+0x90/0xb0 [ 86.006043] [] _spin_unlock+0x30/0x60 [ 86.011358] [] rmqueue_bulk+0x90/0xb0 [ 86.016673] [] get_page_from_freelist+0x395/0x500 [ 86.023026] [] trace_hardirqs_on+0xda/0x180 [ 86.028860] [] get_page_from_freelist+0x223/0x500 [ 86.035213] [] __alloc_pages+0x59/0x3a0 [ 86.040702] [] sigprocmask+0x38/0xf0 [ 86.045929] [] kmem_cache_alloc+0x98/0xd0 [ 86.051590] [] __get_free_pages+0x80/0x90 [ 86.057251] [] sys_mount+0x94/0xf0 [ 86.062305] [] trace_hardirqs_on_thunk+0x35/0x37 [ 86.068572] [] system_call+0x7e/0x83 [ 86.073799] [ 86.075296] INFO: lockdep is turned off. [ 86.079226] [ 86.079227] Code: 48 8b 87 00 01 00 00 49 89 d6 48 8b 18 48 8b 83 10 03 00 00 [ 86.088306] RIP [] lo_ioctl+0x25/0xaa0 [ 86.093734] RSP [ 86.097231] CR2: 0100 Cheers, Grant P.S. Here is my .config file: # # Automatically generated make config: don't edit # Linux kernel version: 2.6.23-rc1-mm1 # Thu Jul 26 20:18:53 2007 # CONFIG_X86_64=y CONFIG_64BIT=y CONFIG_X86=y CONFIG_GENERIC_TIME=y CONFIG_GENERIC_TIME_VSYSCALL=y CONFIG_GENERIC_CMOS_UPDATE=y CONFIG_ZONE_DMA32=y CONFIG_LOCKDEP_SUPPORT=y CONFIG_STACKTRACE_SUPPORT=y CONFIG_SEMAPHORE_SLEEPERS=y CONFIG_MMU=y CONFIG_ZONE_DMA=y CONFIG_QUICKLIST=y CONFIG_NR_QUICK=2 CONFIG_RWSEM_GENERIC_SPINLOCK=y CONFIG_GENERIC_HWEIGHT=y CONFIG_GENERIC_CALIBRATE_DELAY=y CONFIG_X86_CMPXCHG=y CONFIG_EARLY_PRINTK=y CONFIG_GENERIC_ISA_DMA=y CONFIG_GENERIC_IOMAP=y CONFIG_ARCH_MAY_HAVE_PC_FDC=y CONFIG_ARCH_POPULATES_NODE_MAP=y CONFIG_DMI=y CONFIG_AUDIT_ARCH=y CONFIG_GENERIC_BUG=y # CONFIG_ARCH_HAS_ILOG2_U32 is not set # CONFIG_ARCH_HAS_ILOG2_U64 is not set CONFIG_DEFCONFIG_LIST="/lib/modules/$UNAME_RELEASE/.config" # # General setup #
Re: [PATCH 0/3] core_pattern: cleaned up repost/continuing post of core_pattern enhancements
Hi Eugene, Eugene Teo [2007-07-29 21:03 +0800]: > >> Also, it is probably good to think how we can "drop privileges" while > >> piping > >> the core dump output to an external program. A malicious user can > >> potentially > >> use it as a possible backdoor since anything that is executed by > >> "|program" will > >> be executed with root privileges. > >> > > It was my understanding that apport already did this. > > I haven't looked at apport yet, but are you talking about the userspace > portion of > apport or the kernel changes in the Ubuntu kernel? Similarly to Neil's patches, the Ubuntu kernel calls the userspace helper as root, too. Apport drops privileges to the target process as soon as possible (there are a few things it needs to do before, like opening an fd to the crash file in /var/crash/ if that is only writeable by root). Martin -- Martin Pitthttp://www.piware.de Ubuntu Developer http://www.ubuntu.com Debian Developer http://www.debian.org signature.asc Description: Digital signature
Re: 2.6.23-rc1-mm1 compile error in function `acpi_pci_choose_state':
Berck E. Nash wrote: > drivers/built-in.o: In function `acpi_pci_choose_state': > pci-acpi.c:(.text+0xdccf): undefined reference to > `acpi_pm_device_sleep_state' > drivers/built-in.o: In function `pnpacpi_suspend': > core.c:(.text+0x35a7c): undefined reference to `acpi_pm_device_sleep_state' This patch should fix it : http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc1/2.6.23-rc1-mm1/hot-fixes/acpi-revert-d-states-branch-from-jun-17-to-jun-19-for-2623-rc1-mm1.patch - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: crash with 2.6.22.1 crash:ll_rw_blk.c blk_remove_plug()
On 7/22/07, walter harms <[EMAIL PROTECTED]> wrote: > hello all, > on my asus notebook tm620 there is a crash with 2.6.22 and 2.6.21 Did this happen when you were resuming from a suspend-to-ram/disk? [ I ask because I see swsusp in the trace below, linux-pm added to Cc: ] > > Using IPI Shortcut mode > WARNING: at block/ll_rw_blk.c:1575 blk_remove_plug() > [] blk_remove_plug+0x36/0x5a > [] __generic_unplug_device+0x14/0x1f > [] __make_request+0x39b/0x49c > [] generic_make_request+0x228/0x255 > [] submit_bio+0xa5/0xac > [] mempool_alloc+0x37/0xae > [] submit+0xc2/0x11d > [] bio_read_page+0x24/0x27 > [] swsusp_check+0x4f/0xaf > [] software_resume+0x5f/0x108 > [] kernel_init+0xb0/0x212 > [] ret_from_fork+0x6/0x1c > [] kernel_init+0x0/0x212 > [] kernel_init+0x0/0x212 > [] kernel_thread_helper+0x7/0x10 > === Surprising, that's a WARN_ON(!irqs_disabled()) but IRQs are disabled alright on that codepath. OTOH, __make_request() is heavily goto-driven, uses the non-save/restore variants of spin_lock_irq, and does not even balance locks / unlocks for some error paths ... gaah. >>> __make_request() must be called from process context, hence >>> spin_lock_irq() is perfectly already and the fastest way to go. And of >>> course the locking is balanced! So please save your 'gaah's for code >>> you actually took the time to try and understand. >> You're right, I didn't really look at that code for long (it even >> explicitly >> comments about what's going with the locking in there!) sorry about >> that. >> >> [ Off-topic: BTW does every call to __make_request() end up in >> blk_remove_plug()? Since you're explicitly making the assumption >> that it *must* be called from process context (and hence the use of >> the non-save/restore variants), you could consider putting a >> WARN_ON(irqs_disabled()) over there, and perhaps a WARN_ON >> (!spin_is_locked(queue_lock)) in blk_remove_plug() instead, and >> other such similar functions that currently have the !irqs_disabled >> check. This way you'd effectively cover _both_ the assertions, >> and in appropriate places -- just a suggestion. ] > > No, blk_remove_plug() will only be called for sync bios, or where we > have to wait for request allocation (which will unplug the device). > > __generic_make_request() already does a might_sleep() check, so it > should catch this already. > >>> But it does look like unbalanced irq disable/enable calls. I'd guess in >>> the suspend/resume path. Obviously something more esoteric, since this >>> is the first such report for 2.6.22, so like some not-very-used driver >>> for instance. >> Now that I do look at the codepath, it does seem surprising irqs were >> not disabled there. There are a bunch of calls to _other_ functions >> between the spin_lock_irq and the blk_remove_plug via >> __generic_unplug_device that would also have complained about >> !irqs_disabled. >> >> Walter, does this happen reproducibly? > > As I previously wrote, it's like some of the device power up or resume > routines that botch the irq enable/disable stuff. It'd be interesting to > start stripping down the config until the warning goes away - or enable > CONFIG_PM_DEBUG which may help as well. > hi ppl, here is the output of 2.6.21 with CONFIG_PM_DEBUG. i have disable edd,apm,acpi,smp,resume whatever i could to make thinks more easy. imho it shows nothing useful. re, wh 2.6.21.PM_DEBUG.gz Description: GNU Zip compressed data
Re: nvidia installer DIW with 2.6.23-rc1
On Sunday 29 July 2007 15:57:33 Gene Heskett wrote: > Is this a known problem? Do I need to report it to nvidia somehow? It > looks to me like it may be their problem, and I have submitted it, but if > anyone has a better idea, please advise. System is FC6, uptodate as of > yesterday. Gene, this happens almost every kernel version. You should know that binary drivers are OT for LKML, and if you want to report the problem you go through the [EMAIL PROTECTED] address clearly printed in the driver documentation, and on their website. (As it turns out, the fix is very easy and you could easily fix it yourself. Just run --extract-only on the installer and poke around the affected files, removing the extra "NULL" argument to kmem_cache_create().) -- Cheers, Alistair. 137/1 Warrender Park Road, Edinburgh, UK. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: IRQF_DISABLED problem
David Miller wrote: From: Arjan van de Ven <[EMAIL PROTECTED]> Date: Fri, 27 Jul 2007 13:11:56 -0700 On Thu, 2007-07-26 at 16:17 -0700, Linus Torvalds wrote: On Thu, 26 Jul 2007, Linus Torvalds wrote: (c) "one IRQF_DISABLED means that everything runs disabled". This is quite possibly buggy. (Side note: I'm not claiming this (or it's mirror image (d)) is really any better/worse than the current behaviour from a theoretical standpoint, but at least the current behaviour is _tested_, which makes it better in practice. So if we want to change this, I think we want to change it to something that is _obviously_ better). my personal preference would actually be to just never enable interrupts. It's the fastest solution obviously, the most friendly on stack and.. well simplest. Drivers no longer need to play some of the games that they do today. And while there is an argument that this may introduce a bit of latency... I'm not really convinced. If you have a "chirpy" serial controller with only a 1 byte fifo, even a quite reasonable interrupt handler can cause receive characters to get lost if you disable interrupts during the entirety of it's execution. It really is needed. And it's just plain rude to disable interrupts when it isn't absolutely necessary. Does anyone really use those serial controllers with no FIFO anymore? They've never been reliable for remotely high speeds.. -- Robert Hancock Saskatoon, SK, Canada To email, remove "nospam" from [EMAIL PROTECTED] Home Page: http://www.roberthancock.com/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [v4l-dvb-maintainer] [2.6 patch] make struct dvb_pll_fcv1236d static
Adrian Bunk wrote:
> struct dvb_pll_fcv1236d can become static.
>
> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
>
> ---
> --- linux-2.6.23-rc1-mm1/drivers/media/dvb/frontends/dvb-pll.c.old
> 2007-07-26 09:04:23.0 +0200
> +++ linux-2.6.23-rc1-mm1/drivers/media/dvb/frontends/dvb-pll.c
> 2007-07-26 09:04:32.0 +0200
> @@ -501,7 +501,7 @@
>
> /* Philips FCV1236D
> */
> -struct dvb_pll_desc dvb_pll_fcv1236d = {
> +static struct dvb_pll_desc dvb_pll_fcv1236d = {
> /* Bit_0: RF Input select
> * Bit_1: 0=digital, 1=analog
> */
>
Oops. I created that patch before the "dvb: remove static dependencies
on dvb-pll" patch was applied, but the fcv1236d patch didn't get merged
until after the fact. Thanks for the fix, Adrian. I'll apply this.
Regards,
Mike Krufky
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [RFC: 2.6 patch] remove the broken SCSI_ACORNSCSI_3 driver
On Sun, Jul 29, 2007 at 04:59:15PM +0200, Adrian Bunk wrote: > The SCSI_ACORNSCSI_3 driver: > - has been marked as BROKEN for more than one year and > - is still marked as BROKEN. > > Drivers that had been marked as BROKEN for such a long time seem to be > unlikely to be revived in the forseeable future. > > But if anyone wants to ever revive this driver, the code is still > present in the older kernel releases. NAK. I've had a patch to resurect it for some time. Notice that this merge window I applied some patches to the other acorn scsi drivers - once I get enough time to separate out the changes I'll be applying those patches. It's relatively low priority for me though. -- Russell King Linux kernel2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: RFT: updatedb "morning after" problem [was: Re: -mm merge plans for 2.6.23]
On 07/29/2007 05:20 PM, Ray Lee wrote: I understand what log structure is generally, but how does it help swapin? Look at the swap out case first. Right now, when swapping out the kernel places whatever it can wherever it can inside the swap space. The closer you are to filling your swap space, the more likely that those swapped out blocks will be all over place, rather than in one nice chunk. Contrast that with a log structured scheme, where the writeout happens to sequential spaces on the drive instead of scattered about. This seems to be now fixing the different problem of swap-space filling up. I'm quite willing to for now assume I've got plenty free. So, at some point when the system needs to fault those blocks that back in, it now has a linear span of sectors to read instead of asking the drive to bounce over twenty tracks for a hundred blocks. Moreover though -- what I know about log structure is that generally it optimises for write (swapout) and might make read (swapin) worse due to fragmentation that wouldn't happen with a regular fs structure. I guess that cleaner that Alan mentioned might be involved there -- I don't know how/what it would be doing. So, it eliminates the seeks. My laptop drive can read (huh, how odd, it got slower, need to retest in single user mode), hmm, let's go with about 25 MB/s. If we ask for a single block from each track, though, that'll drop to 4k * (1 second / seek time) which is about a megabyte a second if we're lucky enough to read from consecutive tracks. Even worse if it's not. Seeks are the enemy any time you need to hit the drive for anything, be it swapping or optimizing a database. I am very aware of the costs of seeks (on current magnetic media). Rene. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: TCP SACK issue, hung connection, tcpdump included
On Sun, Jul 29, 2007 at 06:59:26AM +0100, Darryl L. Miles wrote: > The problems start around time index 09:21:39.860302 when the CLIENT issues > a TCP packet with SACK option set (seemingly for a data segment which has > already been seen) from that point on the connection hangs. I'd say most likely scenario is the SERVER is behind a Cisco Pix firewall, which has known bugs in handling packets with sack option. By default the Cisco has sequence number randomization enabled, but it's a half-assed implementation which doesn't bother adjusting the sequence numbers inside sack options. This has been reported to Cisco, and they don't seem to care. As a workaround, you can do this: echo 0 > /proc/sys/net/ipv4/tcp_sack and it will probably fix it up. It'd be really nice, however, to have a per-route option for sack, similar to how we can clamp window scaling per route. Something like the below ip r a Phil - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Reading a bad sector does not report failure as 'read error' but hangs PC with 'Machine Check Exception'
Hendrik . wrote: Last night I discovered a problem in my RAID5 array and finally after a lot of tests I narrowed it down to a bad sector on one of the hard disks and some goofy kernels. I just yesterday build a new PC using an existing array of 5 disks in RAID 5. I did build the array with only 4 out of 5 disks in the system but the rebuild processes stopped over and over again apparently at the same position. At last I found out that the harddisk at the first SATA port had developed some bad sectors which made the kernel stop completely when it tried to read that sector with the following error on the screen: HARDWARE ERROR CPU 0: Machine Check Exception: 4 Bank 4: b2070f0f TSC b7d4a144d0 This is not a software problem! Run through mcelog --ascii to decode and contact your hardware vendor Kernel panic - not syncing: Machine check You should run this through mcelog as it suggests and see what it shows. The kernel should be handling this properly, unless the drive problem is causing the controller to do something bad. Note that kernels 2.6.20 and later use ADMA mode on the nForce4 SATA controller whereas previous versions used it essentially like a PATA controller, so it is not surprising that the behavior is different. -- Robert Hancock Saskatoon, SK, Canada To email, remove "nospam" from [EMAIL PROTECTED] Home Page: http://www.roberthancock.com/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
ttyS1: LSR safety check engaged! - misidentification?
Hi all, Ever since Kernel 2.6.21(rc) or so I'm plagued with this message, disabling my serial ports that have been working perfectly from 2.6.14 till that day (and are still doing so, given that I continuously remove the code from the source). Actually I cannot blame the code, but it seems that on both of my laptops the LSR is actually not readable. So, is there any plan to remove that piece of code again, or at least change it so it can be disabled conditionally? Regards, Christian - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] BLOCK=n , LGUEST=m/y compile error
Hi Rusty,
Lguest should depend on BLOCK too , without BLOCK set I get this error:
...
drivers/block/lguest_blk.c: In function 'end_entire_request':
drivers/block/lguest_blk.c:80: error: implicit declaration of function
'end_that_request_first'
drivers/block/lguest_blk.c:80: error: dereferencing pointer to incomplete type
drivers/block/lguest_blk.c:82: error: implicit declaration of function
'add_disk_randomness'
drivers/block/lguest_blk.c:82: error: dereferencing pointer to incomplete type
drivers/block/lguest_blk.c:83: error: implicit declaration of function
'blkdev_dequeue_request'
drivers/block/lguest_blk.c:84: error: implicit declaration of function
'end_that_request_last'
drivers/block/lguest_blk.c: In function 'lgb_irq':
drivers/block/lguest_blk.c:128: error: implicit declaration of function
'blk_start_queue'
drivers/block/lguest_blk.c:128: error: dereferencing pointer to incomplete type
drivers/block/lguest_blk.c: In function 'req_to_dma':
drivers/block/lguest_blk.c:148: error: implicit declaration of function
'rq_for_each_bio'
drivers/block/lguest_blk.c:148: error: expected ';' before '{' token
drivers/block/lguest_blk.c:145: warning: unused variable 'idx'
drivers/block/lguest_blk.c:145: warning: unused variable 'i'
drivers/block/lguest_blk.c: In function 'setup_req':
drivers/block/lguest_blk.c:185: error: dereferencing pointer to incomplete type
drivers/block/lguest_blk.c: In function 'do_write':
drivers/block/lguest_blk.c:202: error: dereferencing pointer to incomplete type
drivers/block/lguest_blk.c: In function 'do_read':
drivers/block/lguest_blk.c:215: error: dereferencing pointer to incomplete type
drivers/block/lguest_blk.c: In function 'do_lgb_request':
drivers/block/lguest_blk.c:234: error: implicit declaration of function
'elv_next_request'
drivers/block/lguest_blk.c:234: warning: assignment makes pointer from integer
without a cast
drivers/block/lguest_blk.c:239: error: dereferencing pointer to incomplete type
drivers/block/lguest_blk.c:246: error: implicit declaration of function
'blk_fs_request'
drivers/block/lguest_blk.c:247: error: dereferencing pointer to incomplete type
drivers/block/lguest_blk.c:248: error: dereferencing pointer to incomplete type
drivers/block/lguest_blk.c:253: error: implicit declaration of function
'rq_data_dir'
drivers/block/lguest_blk.c:260: error: implicit declaration of function
'blk_stop_queue'
drivers/block/lguest_blk.c: In function 'lguestblk_probe':
drivers/block/lguest_blk.c:304: error: implicit declaration of function
'register_blkdev'
drivers/block/lguest_blk.c:313: error: implicit declaration of function
'alloc_disk'
drivers/block/lguest_blk.c:313: warning: assignment makes pointer from integer
without a cast
drivers/block/lguest_blk.c:322: error: dereferencing pointer to incomplete type
drivers/block/lguest_blk.c:322: error: implicit declaration of function
'blk_init_queue'
drivers/block/lguest_blk.c:323: error: dereferencing pointer to incomplete type
drivers/block/lguest_blk.c:335: error: implicit declaration of function
'blk_queue_max_hw_segments'
drivers/block/lguest_blk.c:335: error: dereferencing pointer to incomplete type
drivers/block/lguest_blk.c:341: error: implicit declaration of function
'blk_queue_segment_boundary'
drivers/block/lguest_blk.c:341: error: dereferencing pointer to incomplete type
drivers/block/lguest_blk.c:349: error: dereferencing pointer to incomplete type
drivers/block/lguest_blk.c:360: error: dereferencing pointer to incomplete type
drivers/block/lguest_blk.c:373: error: dereferencing pointer to incomplete type
drivers/block/lguest_blk.c:374: error: dereferencing pointer to incomplete type
drivers/block/lguest_blk.c:375: error: dereferencing pointer to incomplete type
drivers/block/lguest_blk.c:376: error: dereferencing pointer to incomplete type
drivers/block/lguest_blk.c:378: error: implicit declaration of function
'set_capacity'
drivers/block/lguest_blk.c:379: error: implicit declaration of function
'add_disk'
drivers/block/lguest_blk.c:382: error: dereferencing pointer to incomplete type
drivers/block/lguest_blk.c:392: error: implicit declaration of function
'blk_cleanup_queue'
drivers/block/lguest_blk.c:392: error: dereferencing pointer to incomplete type
drivers/block/lguest_blk.c:394: error: implicit declaration of function
'put_disk'
drivers/block/lguest_blk.c:396: error: implicit declaration of function
'unregister_blkdev'
make[2]: *** [drivers/block/lguest_blk.o] Error 1
make[1]: *** [drivers/block] Error 2
Signed-off-by: Gabriel Craciunescu <[EMAIL PROTECTED]>
---
Documentation/lguest/lguest.txt |1 +
drivers/lguest/Kconfig |2 +-
2 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/Documentation/lguest/lguest.txt b/Documentation/lguest/lguest.txt
index 821617b..4e7408c 100644
--- a/Documentation/lguest/lguest.txt
+++ b/Documentation/lguest/lguest.txt
@@ -33,6 +33,7 @@ Running Lguest:
CONFIG_EXPERIMENTAL=y ("Prompt for development and/or
Re: Linus 2.6.23-rc1
On Sonntag, 29. Juli 2007, Kasper Sandberg wrote: > On Sun, 2007-07-29 at 01:41 +0200, Volker Armin Hemmann wrote: > > Hi, > > > > I never tried Con's patchset, for two reasons: > > I tried his 2.4 patches ones, and I never saw any improvements. So when > > people were reporting huge improvements with his SD scheduler, I compared > > that with the reports of huge improvements with his 2.4 kernel patches. > > Well thats a reason if there ever were one... > yes, it is. The fans claimed once lots of stuff that was not true for me. So why believing them 'now'? > > ... > > The second: too many patches. I only would have tried one or two, but the > > ck-patchset is a lot bigger.. and I am a little bit uneasy about that. > > so use only the scheduler? nobody forces you to do many things.. but which one is needed? http://www.kernel.org/pub/linux/kernel/people/ck/patches/2.6/2.6.22/2.6.22-ck1/patches/ six patches who start with 'sched-' and which one is needed? and which is not? Can I only use sched-staircase-deadline-cpu-scheduler.patch or do I need the others too? > Better than old vanilla yes, but than SD? well, you should give it a > try. > see above. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: RFT: updatedb "morning after" problem [was: Re: -mm merge plans for 2.6.23]
On 7/29/07, Rene Herman <[EMAIL PROTECTED]> wrote: > On 07/29/2007 04:58 PM, Ray Lee wrote: > > On 7/29/07, Rene Herman <[EMAIL PROTECTED]> wrote: > >> Right over my head. Why does log-structure help anything? > > > > Log structured disk layouts allow for better placement of writeout, so > > that you cn eliminate most or all seeks. Seeks are the enemy when > > trying to get full disk bandwidth. > > > > google on log structured disk layout, or somesuch, for details. > > I understand what log structure is generally, but how does it help swapin? Look at the swap out case first. Right now, when swapping out the kernel places whatever it can wherever it can inside the swap space. The closer you are to filling your swap space, the more likely that those swapped out blocks will be all over place, rather than in one nice chunk. Contrast that with a log structured scheme, where the writeout happens to sequential spaces on the drive instead of scattered about. So, at some point when the system needs to fault those blocks that back in, it now has a linear span of sectors to read instead of asking the drive to bounce over twenty tracks for a hundred blocks. So, it eliminates the seeks. My laptop drive can read (huh, how odd, it got slower, need to retest in single user mode), hmm, let's go with about 25 MB/s. If we ask for a single block from each track, though, that'll drop to 4k * (1 second / seek time) which is about a megabyte a second if we're lucky enough to read from consecutive tracks. Even worse if it's not. Seeks are the enemy any time you need to hit the drive for anything, be it swapping or optimizing a database. Ray - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
2.6.23-rc1-mm1 compile error in function `acpi_pci_choose_state':
drivers/built-in.o: In function `acpi_pci_choose_state': pci-acpi.c:(.text+0xdccf): undefined reference to `acpi_pm_device_sleep_state' drivers/built-in.o: In function `pnpacpi_suspend': core.c:(.text+0x35a7c): undefined reference to `acpi_pm_device_sleep_state' Config file attached. # # Automatically generated make config: don't edit # Linux kernel version: 2.6.23-rc1-mm1 # Sun Jul 29 09:14:48 2007 # CONFIG_X86_64=y CONFIG_64BIT=y CONFIG_X86=y CONFIG_GENERIC_TIME=y CONFIG_GENERIC_TIME_VSYSCALL=y CONFIG_GENERIC_CMOS_UPDATE=y CONFIG_ZONE_DMA32=y CONFIG_LOCKDEP_SUPPORT=y CONFIG_STACKTRACE_SUPPORT=y CONFIG_SEMAPHORE_SLEEPERS=y CONFIG_MMU=y CONFIG_ZONE_DMA=y CONFIG_QUICKLIST=y CONFIG_NR_QUICK=2 CONFIG_RWSEM_GENERIC_SPINLOCK=y CONFIG_GENERIC_HWEIGHT=y CONFIG_GENERIC_CALIBRATE_DELAY=y CONFIG_X86_CMPXCHG=y CONFIG_EARLY_PRINTK=y CONFIG_GENERIC_ISA_DMA=y CONFIG_GENERIC_IOMAP=y CONFIG_ARCH_MAY_HAVE_PC_FDC=y CONFIG_ARCH_POPULATES_NODE_MAP=y CONFIG_DMI=y CONFIG_AUDIT_ARCH=y CONFIG_GENERIC_BUG=y # CONFIG_ARCH_HAS_ILOG2_U32 is not set # CONFIG_ARCH_HAS_ILOG2_U64 is not set CONFIG_DEFCONFIG_LIST="/lib/modules/$UNAME_RELEASE/.config" # # General setup # CONFIG_EXPERIMENTAL=y CONFIG_LOCK_KERNEL=y CONFIG_INIT_ENV_ARG_LIMIT=32 CONFIG_LOCALVERSION="" CONFIG_LOCALVERSION_AUTO=y CONFIG_SWAP=y CONFIG_SWAP_PREFETCH=y CONFIG_SYSVIPC=y CONFIG_SYSVIPC_SYSCTL=y CONFIG_POSIX_MQUEUE=y CONFIG_BSD_PROCESS_ACCT=y CONFIG_BSD_PROCESS_ACCT_V3=y # CONFIG_TASKSTATS is not set # CONFIG_USER_NS is not set CONFIG_AUDIT=y # CONFIG_AUDITSYSCALL is not set CONFIG_IKCONFIG=y CONFIG_IKCONFIG_PROC=y CONFIG_LOG_BUF_SHIFT=16 # CONFIG_CONTAINERS is not set # CONFIG_SYSFS_DEPRECATED is not set # CONFIG_CONTAINER_NS is not set # CONFIG_RELAY is not set # CONFIG_BLK_DEV_INITRD is not set CONFIG_CC_OPTIMIZE_FOR_SIZE=y CONFIG_SYSCTL=y # CONFIG_EMBEDDED is not set CONFIG_UID16=y CONFIG_SYSCTL_SYSCALL=y CONFIG_KALLSYMS=y # CONFIG_KALLSYMS_ALL is not set # CONFIG_KALLSYMS_EXTRA_PASS is not set CONFIG_HOTPLUG=y CONFIG_PRINTK=y CONFIG_BUG=y CONFIG_ELF_CORE=y CONFIG_BASE_FULL=y CONFIG_FUTEX=y CONFIG_ANON_INODES=y CONFIG_EPOLL=y CONFIG_SIGNALFD=y CONFIG_TIMERFD=y CONFIG_EVENTFD=y CONFIG_SHMEM=y CONFIG_VM_EVENT_COUNTERS=y CONFIG_SLAB=y # CONFIG_SLUB is not set # CONFIG_SLOB is not set CONFIG_PROC_PAGE_MONITOR=y CONFIG_PROC_KPAGEMAP=y CONFIG_RT_MUTEXES=y # CONFIG_TINY_SHMEM is not set CONFIG_BASE_SMALL=0 CONFIG_MODULES=y CONFIG_MODULE_UNLOAD=y # CONFIG_MODULE_FORCE_UNLOAD is not set # CONFIG_MODVERSIONS is not set # CONFIG_MODULE_SRCVERSION_ALL is not set CONFIG_KMOD=y CONFIG_STOP_MACHINE=y CONFIG_BLOCK=y # CONFIG_BLK_DEV_IO_TRACE is not set CONFIG_BLK_DEV_BSG=y # # IO Schedulers # CONFIG_IOSCHED_NOOP=y # CONFIG_IOSCHED_AS is not set # CONFIG_IOSCHED_DEADLINE is not set CONFIG_IOSCHED_CFQ=y # CONFIG_DEFAULT_AS is not set # CONFIG_DEFAULT_DEADLINE is not set CONFIG_DEFAULT_CFQ=y # CONFIG_DEFAULT_NOOP is not set CONFIG_DEFAULT_IOSCHED="cfq" # # Processor type and features # # CONFIG_TICK_ONESHOT is not set CONFIG_X86_PC=y # CONFIG_X86_VSMP is not set # CONFIG_MK8 is not set # CONFIG_MPSC is not set CONFIG_MCORE2=y # CONFIG_GENERIC_CPU is not set CONFIG_X86_L1_CACHE_BYTES=64 CONFIG_X86_L1_CACHE_SHIFT=6 CONFIG_X86_INTERNODE_CACHE_BYTES=64 CONFIG_X86_TSC=y CONFIG_X86_GOOD_APIC=y # CONFIG_MICROCODE is not set CONFIG_X86_MSR=y CONFIG_X86_CPUID=y CONFIG_X86_HT=y CONFIG_X86_IO_APIC=y CONFIG_X86_LOCAL_APIC=y CONFIG_MTRR=y CONFIG_SMP=y # CONFIG_SCHED_SMT is not set CONFIG_SCHED_MC=y # CONFIG_PREEMPT_NONE is not set CONFIG_PREEMPT_VOLUNTARY=y # CONFIG_PREEMPT is not set CONFIG_PREEMPT_BKL=y # CONFIG_NUMA is not set CONFIG_ARCH_SPARSEMEM_ENABLE=y CONFIG_ARCH_FLATMEM_ENABLE=y CONFIG_SELECT_MEMORY_MODEL=y CONFIG_FLATMEM_MANUAL=y # CONFIG_DISCONTIGMEM_MANUAL is not set # CONFIG_SPARSEMEM_MANUAL is not set CONFIG_FLATMEM=y CONFIG_FLAT_NODE_MEM_MAP=y # CONFIG_SPARSEMEM_STATIC is not set CONFIG_SPLIT_PTLOCK_CPUS=4 CONFIG_RESOURCES_64BIT=y CONFIG_ZONE_DMA_FLAG=1 CONFIG_BOUNCE=y CONFIG_VIRT_TO_BUS=y CONFIG_NR_CPUS=2 CONFIG_PHYSICAL_ALIGN=0x20 # CONFIG_HOTPLUG_CPU is not set CONFIG_ARCH_ENABLE_MEMORY_HOTPLUG=y CONFIG_HPET_TIMER=y CONFIG_HPET_EMULATE_RTC=y CONFIG_IOMMU=y # CONFIG_CALGARY_IOMMU is not set CONFIG_SWIOTLB=y CONFIG_X86_MCE=y CONFIG_X86_MCE_INTEL=y # CONFIG_X86_MCE_AMD is not set # CONFIG_KEXEC is not set # CONFIG_CRASH_DUMP is not set # CONFIG_RELOCATABLE is not set CONFIG_PHYSICAL_START=0x20 # CONFIG_SECCOMP is not set # CONFIG_CC_STACKPROTECTOR is not set # CONFIG_HZ_100 is not set # CONFIG_HZ_250 is not set CONFIG_HZ_300=y # CONFIG_HZ_1000 is not set CONFIG_HZ=300 CONFIG_K8_NB=y CONFIG_GENERIC_HARDIRQS=y CONFIG_GENERIC_IRQ_PROBE=y CONFIG_ISA_DMA_API=y CONFIG_GENERIC_PENDING_IRQ=y # # Power management options # CONFIG_PM=y CONFIG_PM_LEGACY=y # CONFIG_PM_DEBUG is not set CONFIG_ACPI=y CONFIG_ACPI_PROCFS=y # CONFIG_ACPI_AC is not set # CONFIG_ACPI_BATTERY is not set CONFIG_ACPI_BUTTON=y # CONFIG_ACPI_FAN is not set # CONFIG_ACPI_DOCK is not set
Re: [Linux-usb-users] [REGRESSION] 2.6.23-rc1: uhci_hcd. irq 4: nobody cared
On Sun, 29 Jul 2007, Mark Hindley wrote: > Hi, > > I have just tried 2.6.23-rc1 on my Acer Aspire 1350. > > On boot I get the following error as the uhci_hcd module is loaded: > > Jul 28 18:23:20 mercury kernel: ACPI: PCI Interrupt :00:10.0[A] -> Link > [LNKA] -> GSI 4 (level, low) -> IRQ 4 > Jul 28 18:23:20 mercury kernel: uhci_hcd :00:10.0: UHCI Host Controller > Jul 28 18:23:20 mercury kernel: uhci_hcd :00:10.0: new USB bus > registered, assigned bus number 2 > Jul 28 18:23:20 mercury kernel: irq 4: nobody cared (try booting with the > "irqpoll" option) Did it work okay with older kernels? What does /proc/interrupts say in both 2.6.23-rc1 and in a working kernel? Alan Stern - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: nvidia installer DIW with 2.6.23-rc1
On Jul 29 2007 10:57, Gene Heskett wrote: > /tmp/selfgz9678/NVIDIA-Linux-x86-100.14.11-pkg1/usr/src/nv/nv.c: In >function > ‘nvidia_init_module’: > /tmp/selfgz9678/NVIDIA-Linux-x86-100.14.11-pkg1/usr/src/nv/nv.c:1326: >error: > too many arguments to function ‘kmem_cache_create’ >Is this a known problem? Do I need to report it to nvidia somehow? Well, you do not *need* to report it, just as you do not need to report kernel oopses or Windows crashes. They'll eventually stumble upon that themselves >It looks to me like it may be their problem, and I have submitted >it, but if anyone has a better idea, please advise. System is FC6, >uptodate as of yesterday. Better idea? Fix the source until they have a fix. It seems to be just an extra argument to kmem_cache_create that got removed. Jan --
Re: request for patches: showing mount options
[cc trim on purpose, just autofs interest here] On Jul 28 2007 14:45, Ian Kent wrote: > >Oh .. sorry, I wasn't paying enough attention. > >But now might be a good time to propose the removal of autofs and rename >autofs4 to autofs. I would need to provide some way to map autofs4 >module load requests to autofs for backward compatibility but haven't >thought about that yet. You could use EXPORT_SYMBOL in autofs.ko that autofs4.ko uses. Or write an autofs4.c that does try_module_get(autofs) on _init. Jan -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Reading a bad sector does not report failure as 'read error' but hangs PC with 'Machine Check Exception'
Last night I discovered a problem in my RAID5 array
and finally after a lot of tests I narrowed it down to
a bad sector on one of the hard disks and some goofy
kernels.
I just yesterday build a new PC using an existing
array of 5 disks in RAID 5. I did build the array with
only 4 out of 5 disks in the system but the rebuild
processes stopped over and over again apparently at
the same position. At last I found out that the
harddisk at the first SATA port had developed some bad
sectors which made the kernel stop completely when it
tried to read that sector with the following error on
the screen:
HARDWARE ERROR
CPU 0: Machine Check Exception: 4 Bank 4:
b2070f0f
TSC b7d4a144d0
This is not a software problem!
Run through mcelog --ascii to decode and contact your
hardware vendor
Kernel panic - not syncing: Machine check
Googling around made me check memory, upgrade the BIOS
and things like that but now i DO think that this IS a
software problem, which is in the linux kernel.
I was running the standard 2.6.20-16 kernel series
from Ubuntu Feisty Fawn (using the generic and server
built) and I built my own 2.6.22.1 but the problem
still persisted. When copying manually with dd_rescue
I was not able to copy past the bad sector or the MCE
error reappeared. Only when using the standard Ubuntu
Edgy Eft kernel (2.6.17-12-server) the problem went
away completely and the syslog was filled with normal
lines like:
Jul 28 22:58:26 mediaserver kernel: [ 6562.446868]
ata2: error=0x40 { UncorrectableError }
Jul 28 22:58:26 mediaserver kernel: [ 6562.446875] sd
1:0:0:0: SCSI error: return code = 0x802
Jul 28 22:58:26 mediaserver kernel: [ 6562.446880]
Additional sense: Unrecovered read error - auto
reallocate failed
Jul 28 22:58:26 mediaserver kernel: [ 6562.446887]
end_request: I/O error, dev sda, sector 205534870
So in the end I was able to copy my stuff off the bad
harddisk to a new disk (losing some bytes because of
my already dirty RAID5 array) but I do think this is a
kernel bug or at least strange behavior as an old
kernel is willing to continue operation on something
'minor' as a bad sector. In the end when I will start
scrubbing the drive array overnight a simple bad
sector on the array will take down the complete system
instead of just continuing with 1 faulty drive in the
array!
Some information about the hardware:
AMD Athlon 64 3000+
Asus A8N-E Deluxe motherboard
1 GB RAM
4 Seagate 7200.9 drives on the NVIDIA SATA controller
(sda ... sdd)
2 WD drives on the IDE controller (hda, hdc)
Running Feisty Fawn 64 bit Server edition
Faulty drive is /dev/sda and on thus on the first SATA
port. Changing this to a different port on the
motherboard gives the same lockup. There is also a SIL
3114 controller on the motherboard but I have not
tried to dd_rescue with the faulty drive on that
controller to see if it locks up the kernel.
Regards,
Hendrik van den Boogaard
Luggage? GPS? Comic books?
Check out fitting gifts for grads at Yahoo! Search
http://search.yahoo.com/search?fr=oni_on_mail=graduation+gifts=bz
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] usb-serial: Fix edgeport regression on non-EPiC devices
Fix serious regression on non-EPiC edgeport usb-serial devices. Baud
rate and MCR/LCR registers are not being written on these models due
to apparent copy-n-paste errors introduced with EPiC support.
Failure reported by Nick Pasich <[EMAIL PROTECTED]>.
Signed-off-by: Adam Kropelin <[EMAIL PROTECTED]>
--
Assuming this is a right and proper fix, it should go in the -stable
tree ASAP.
--- linux-2.6.22.1/drivers/usb/serial/io_edgeport.c 2007-07-10
14:56:30.0 -0400
+++ linux-2.6.22.1.new/drivers/usb/serial/io_edgeport.c 2007-07-29
09:45:18.0 -0400
@@ -2366,9 +2366,8 @@
int status;
unsigned char number = edge_port->port->number -
edge_port->port->serial->minor;
- if ((!edge_serial->is_epic) ||
- ((edge_serial->is_epic) &&
-(!edge_serial->epic_descriptor.Supports.IOSPSetBaudRate))) {
+ if (edge_serial->is_epic &&
+ !edge_serial->epic_descriptor.Supports.IOSPSetBaudRate) {
dbg("SendCmdWriteBaudRate - NOT Setting baud rate for port =
%d, baud = %d",
edge_port->port->number, baudRate);
return 0;
@@ -2461,18 +2460,16 @@
dbg("%s - write to %s register 0x%02x", (regNum == MCR) ? "MCR" :
"LCR", __FUNCTION__, regValue);
- if ((!edge_serial->is_epic) ||
- ((edge_serial->is_epic) &&
-(!edge_serial->epic_descriptor.Supports.IOSPWriteMCR) &&
-(regNum == MCR))) {
+ if (edge_serial->is_epic &&
+ !edge_serial->epic_descriptor.Supports.IOSPWriteMCR &&
+ regNum == MCR) {
dbg("SendCmdWriteUartReg - Not writing to MCR Register");
return 0;
}
- if ((!edge_serial->is_epic) ||
- ((edge_serial->is_epic) &&
-(!edge_serial->epic_descriptor.Supports.IOSPWriteLCR) &&
-(regNum == LCR))) {
+ if (edge_serial->is_epic &&
+ !edge_serial->epic_descriptor.Supports.IOSPWriteLCR &&
+ regNum == LCR) {
dbg ("SendCmdWriteUartReg - Not writing to LCR Register");
return 0;
}
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: Linus 2.6.23-rc1
hi Kasper, * Kasper Sandberg <[EMAIL PROTECTED]> wrote: > Im still not so keen about this, Ingo never did get CFS to match SD in > smoothness for 3d applications, where my test subjects are quake(s), > world of warcraft via wine, unreal tournament 2004. And this is > despite many patches he sent me to try and tweak it. [...] hey, i thought you vanished from the face of the earth :-) The last email i got from you was more than 2 months ago, where you said that you'll try the latest CFS version as soon as possible but that you were busy with work. I sent 2 more emails to you about new CFS versions but then stopped pestering you directly - work _does_ take precedence over games =B-) CFS v14, v15, v16, v17, v18 and v19 was released meanwhile, CFS v20 went upstream, there were no 3D related CFS regressions open for quite some time and because i never heard back from you i assumed everything's peachy. In any case i'm glad you found the time to try CFS again, so please let me know in what way it regresses. In your most recent emails you did not indicate what specific problem you are having (and you did not reply to my last emails from May) - are your old regression reports against CFS v13 from May still true as of v2.6.23-rc1? If they are, could you please indicate which specific report of yours describes it best and send me (or upload to some webspace) the specific .config you are using on your box, and the cfs-debug-info.sh snapshot taken when you are running your game. (make sure you have CONFIG_SCHED_DEBUG=y enabled, for highest quality debug output) You can pick the script up from: http://people.redhat.com/mingo/cfs-scheduler/tools/cfs-debug-info.sh Giving us that info would help us immensely with tracking down any CFS problem you might still be having. Or, if you feel adventurous enough to look into the internals of the kernel (which, considering your offer to take up SD maintenance, you must be ;-), here's my kernel latency tracer: http://people.redhat.com/mingo/latency-tracing-patches/ ( see: latency-tracer-v2.6.23-rc1-combo.patch ) the simplest way to use it is to enable CONFIG_WAKEUP_TIMING, to set /proc/sys/kernel/preempt_max_latency back to 0 (after bootup) and to thus measure raw worst-case scheduler latencies - if you regularly see the kernel report above say 1000 usecs latencies to the syslog, on a PREEMPT kernel then there's definitely something foul going on. For example, that's how i found an audio playback latency problem in an early version of CFS: (sshd-14614|#1): new 5 us maximum-latency wakeup. ( ogg123-6603 |#1): new 6 us maximum-latency wakeup. ( ogg123-6608 |#1): new 6 us maximum-latency wakeup. (sshd-14614|#1): new 10 us maximum-latency wakeup. ( ogg123-6607 |#0): new 15 us maximum-latency wakeup. (events/0-9|#0): new 789 us maximum-latency wakeup. ( ogg123-6603 |#0): new 2566 us maximum-latency wakeup. that 2.5 msecs latency in the ogg123 task was definitely the sign of a kernel bug. If plain WAKEUP_TIMING does not show anything suspicious, you can use the latency tracer in more advanced ways as well to trace the whole system and figure out the precise cause of your game latencies - i'll be glad to help with that if no simpler measure helps. [see trace-it.c for some of those details.] > [...] As far as im concerned, i may be forced to unofficially maintain > SD for my own systems(allthough lots in the gaming community is bound > to be interrested, as it does make games lots better) i'd encourage you to do it - in fact i already tried to prod Peter Williams into doing exactly that ;) The more reality checks a scheduler has, the better. [ Btw., after the obvious initial merging trouble it should be much easier to keep SD maintained against future upstream kernels due to the policy modularity that CFS introduces. (and which policy-modularity should also help reduce the size and complexity of the SD patch.) ] Thanks, Ingo - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[2.6 patch] mm/vmstat.c: cleanups
This patch contains the following cleanups:
- make the needlessly global setup_vmstat() static
- remove the unused refresh_vm_stats()
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
Acked-by: Christoph Lameter <[EMAIL PROTECTED]>
---
This patch has been sent on:
- 9 Jul 2007
mm/vmstat.c | 19 +--
1 file changed, 1 insertion(+), 18 deletions(-)
--- linux-2.6.22-rc6-mm1/mm/vmstat.c.old2007-07-05 16:54:39.0
+0200
+++ linux-2.6.22-rc6-mm1/mm/vmstat.c2007-07-08 22:27:26.0 +0200
@@ -353,23 +353,6 @@
}
}
-static void __refresh_cpu_vm_stats(void *dummy)
-{
- refresh_cpu_vm_stats(smp_processor_id());
-}
-
-/*
- * Consolidate all counters.
- *
- * Note that the result is less inaccurate but still inaccurate
- * if concurrent processes are allowed to run.
- */
-void refresh_vm_stats(void)
-{
- on_each_cpu(__refresh_cpu_vm_stats, NULL, 0, 1);
-}
-EXPORT_SYMBOL(refresh_vm_stats);
-
#endif
#ifdef CONFIG_NUMA
@@ -957,7 +940,7 @@
static struct notifier_block __cpuinitdata vmstat_notifier =
{ _cpuup_callback, NULL, 0 };
-int __init setup_vmstat(void)
+static int __init setup_vmstat(void)
{
int cpu;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[2.6 patch] mm/: remove unused exports
This patch removes the following unused EXPORT_SYMBOL's:
- migrate.c: migrate_page
- mmap.c: get_unmapped_area
- nommu.c: get_unmapped_area
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
This patch has been sent on:
- 13 Jul 2007
mm/migrate.c |1 -
mm/mmap.c|2 --
mm/nommu.c |2 --
3 files changed, 5 deletions(-)
--- linux-2.6.22-rc6-mm1/mm/migrate.c.old 2007-07-12 03:15:05.0
+0200
+++ linux-2.6.22-rc6-mm1/mm/migrate.c 2007-07-12 03:15:15.0 +0200
@@ -426,7 +426,6 @@
migrate_page_copy(newpage, page);
return 0;
}
-EXPORT_SYMBOL(migrate_page);
#ifdef CONFIG_BLOCK
/*
--- linux-2.6.22-rc6-mm1/mm/mmap.c.old 2007-07-12 03:20:19.0 +0200
+++ linux-2.6.22-rc6-mm1/mm/mmap.c 2007-07-12 03:20:33.0 +0200
@@ -1408,8 +1408,6 @@
return addr;
}
-EXPORT_SYMBOL(get_unmapped_area);
-
/* Look up the first VMA which satisfies addr < vm_end, NULL if none. */
struct vm_area_struct * find_vma(struct mm_struct * mm, unsigned long addr)
{
--- linux-2.6.22-rc6-mm1/mm/nommu.c.old 2007-07-12 03:20:41.0 +0200
+++ linux-2.6.22-rc6-mm1/mm/nommu.c 2007-07-12 03:20:57.0 +0200
@@ -1232,3 +1232,2 @@
}
-EXPORT_SYMBOL(get_unmapped_area);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[2.6 patch] mm/mempolicy.c: cleanups
This patch contains the following cleanups:
- every file should include the headers containing the prototypes for
its global functions
- make the follosing needlessly global functions static:
- migrate_to_node()
- do_mbind()
- sp_alloc()
- mpol_rebind_policy()
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
Acked-by: Christoph Lameter <[EMAIL PROTECTED]>
---
This patch has been sent on:
- 6 Jul 2007
include/linux/mempolicy.h |6 --
mm/mempolicy.c| 25 -
2 files changed, 16 insertions(+), 15 deletions(-)
--- linux-2.6.22-rc6-mm1/include/linux/mempolicy.h.old 2007-07-05
17:16:55.0 +0200
+++ linux-2.6.22-rc6-mm1/include/linux/mempolicy.h 2007-07-05
17:17:05.0 +0200
@@ -143,7 +143,6 @@
extern void numa_default_policy(void);
extern void numa_policy_init(void);
-extern void mpol_rebind_policy(struct mempolicy *pol, const nodemask_t *new);
extern void mpol_rebind_task(struct task_struct *tsk,
const nodemask_t *new);
extern void mpol_rebind_mm(struct mm_struct *mm, nodemask_t *new);
@@ -225,11 +224,6 @@
{
}
-static inline void mpol_rebind_policy(struct mempolicy *pol,
- const nodemask_t *new)
-{
-}
-
static inline void mpol_rebind_task(struct task_struct *tsk,
const nodemask_t *new)
{
--- linux-2.6.22-rc6-mm1/mm/mempolicy.c.old 2007-07-05 17:14:16.0
+0200
+++ linux-2.6.22-rc6-mm1/mm/mempolicy.c 2007-07-05 17:22:17.0 +0200
@@ -89,6 +89,7 @@
#include
#include
#include
+#include
#include
#include
@@ -110,6 +111,9 @@
.policy = MPOL_DEFAULT,
};
+static void mpol_rebind_policy(struct mempolicy *pol,
+ const nodemask_t *newmask);
+
/* Do sanity checking on a policy */
static int mpol_check_policy(int mode, nodemask_t *nodes)
{
@@ -459,7 +463,7 @@
}
/* Set the process memory policy */
-long do_set_mempolicy(int mode, nodemask_t *nodes)
+static long do_set_mempolicy(int mode, nodemask_t *nodes)
{
struct mempolicy *new;
@@ -519,8 +523,8 @@
}
/* Retrieve NUMA policy */
-long do_get_mempolicy(int *policy, nodemask_t *nmask,
- unsigned long addr, unsigned long flags)
+static long do_get_mempolicy(int *policy, nodemask_t *nmask,
+unsigned long addr, unsigned long flags)
{
int err;
struct mm_struct *mm = current->mm;
@@ -601,7 +605,8 @@
* Migrate pages from one node to a target node.
* Returns error or the number of pages not migrated.
*/
-int migrate_to_node(struct mm_struct *mm, int source, int dest, int flags)
+static int migrate_to_node(struct mm_struct *mm, int source, int dest,
+ int flags)
{
nodemask_t nmask;
LIST_HEAD(pagelist);
@@ -732,8 +737,9 @@
}
#endif
-long do_mbind(unsigned long start, unsigned long len,
- unsigned long mode, nodemask_t *nmask, unsigned long flags)
+static long do_mbind(unsigned long start, unsigned long len,
+unsigned long mode, nodemask_t *nmask,
+unsigned long flags)
{
struct vm_area_struct *vma;
struct mm_struct *mm = current->mm;
@@ -1466,8 +1472,8 @@
kmem_cache_free(sn_cache, n);
}
-struct sp_node *
-sp_alloc(unsigned long start, unsigned long end, struct mempolicy *pol)
+static struct sp_node *sp_alloc(unsigned long start, unsigned long end,
+ struct mempolicy *pol)
{
struct sp_node *n = kmem_cache_alloc(sn_cache, GFP_KERNEL);
@@ -1645,7 +1651,8 @@
}
/* Migrate a policy to a different set of nodes */
-void mpol_rebind_policy(struct mempolicy *pol, const nodemask_t *newmask)
+static void mpol_rebind_policy(struct mempolicy *pol,
+ const nodemask_t *newmask)
{
nodemask_t *mpolmask;
nodemask_t tmp;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[2.6 patch] mm/migrate.c: cleanups
This patch contains the following cleanups:
- every file should include the headers containing the prototypes for
its global functions
- make the needlessly global putback_lru_pages() static
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
Acked-by: Christoph Lameter <[EMAIL PROTECTED]>
---
This patch has been sent on:
- 6 Jul 2007
include/linux/migrate.h |2 --
mm/migrate.c|3 ++-
2 files changed, 2 insertions(+), 3 deletions(-)
--- linux-2.6.22-rc6-mm1/include/linux/migrate.h.old2007-07-05
17:10:01.0 +0200
+++ linux-2.6.22-rc6-mm1/include/linux/migrate.h2007-07-05
17:10:10.0 +0200
@@ -26,7 +26,6 @@
}
extern int isolate_lru_page(struct page *p, struct list_head *pagelist);
-extern int putback_lru_pages(struct list_head *l);
extern int migrate_page(struct address_space *,
struct page *, struct page *);
extern int migrate_pages(struct list_head *l, new_page_t x, unsigned long);
@@ -44,7 +43,6 @@
static inline int isolate_lru_page(struct page *p, struct list_head *list)
{ return -ENOSYS; }
-static inline int putback_lru_pages(struct list_head *l) { return 0; }
static inline int migrate_pages(struct list_head *l, new_page_t x,
unsigned long private) { return -ENOSYS; }
--- linux-2.6.22-rc6-mm1/mm/migrate.c.old 2007-07-05 17:10:16.0
+0200
+++ linux-2.6.22-rc6-mm1/mm/migrate.c 2007-07-05 17:11:43.0 +0200
@@ -28,6 +28,7 @@
#include
#include
#include
+#include
#include "internal.h"
@@ -101,7 +102,7 @@
*
* returns the number of pages put back.
*/
-int putback_lru_pages(struct list_head *l)
+static int putback_lru_pages(struct list_head *l)
{
struct page *page;
struct page *page2;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[2.6 patch] kernel/sched.c: make code static
This patch makes the following needlessly global code static:
- arch_reinit_sched_domains()
- struct attr_sched_mc_power_savings
- struct attr_sched_smt_power_savings
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
This patch has been sent on:
- 6 Jul 2007
include/linux/cpu.h |2 -
kernel/sched.c | 46 ++--
2 files changed, 23 insertions(+), 25 deletions(-)
--- linux-2.6.22-rc6-mm1/include/linux/cpu.h.old2007-07-05
16:13:11.0 +0200
+++ linux-2.6.22-rc6-mm1/include/linux/cpu.h2007-07-05 16:18:03.0
+0200
@@ -41,8 +41,6 @@
extern int cpu_add_sysdev_attr_group(struct attribute_group *attrs);
extern void cpu_remove_sysdev_attr_group(struct attribute_group *attrs);
-extern struct sysdev_attribute attr_sched_mc_power_savings;
-extern struct sysdev_attribute attr_sched_smt_power_savings;
extern int sched_create_sysfs_power_savings_entries(struct sysdev_class *cls);
#ifdef CONFIG_HOTPLUG_CPU
--- linux-2.6.22-rc6-mm1/kernel/sched.c.old 2007-07-05 16:11:34.0
+0200
+++ linux-2.6.22-rc6-mm1/kernel/sched.c 2007-07-05 16:30:40.0 +0200
@@ -6127,7 +6127,7 @@
}
#if defined(CONFIG_SCHED_MC) || defined(CONFIG_SCHED_SMT)
-int arch_reinit_sched_domains(void)
+static int arch_reinit_sched_domains(void)
{
int err;
@@ -6156,24 +6156,6 @@
return ret ? ret : count;
}
-int sched_create_sysfs_power_savings_entries(struct sysdev_class *cls)
-{
- int err = 0;
-
-#ifdef CONFIG_SCHED_SMT
- if (smt_capable())
- err = sysfs_create_file(>kset.kobj,
- _sched_smt_power_savings.attr);
-#endif
-#ifdef CONFIG_SCHED_MC
- if (!err && mc_capable())
- err = sysfs_create_file(>kset.kobj,
- _sched_mc_power_savings.attr);
-#endif
- return err;
-}
-#endif
-
#ifdef CONFIG_SCHED_MC
static ssize_t sched_mc_power_savings_show(struct sys_device *dev, char *page)
{
@@ -6184,8 +6166,8 @@
{
return sched_power_savings_store(buf, count, 0);
}
-SYSDEV_ATTR(sched_mc_power_savings, 0644, sched_mc_power_savings_show,
- sched_mc_power_savings_store);
+static SYSDEV_ATTR(sched_mc_power_savings, 0644, sched_mc_power_savings_show,
+ sched_mc_power_savings_store);
#endif
#ifdef CONFIG_SCHED_SMT
@@ -6198,8 +6180,26 @@
{
return sched_power_savings_store(buf, count, 1);
}
-SYSDEV_ATTR(sched_smt_power_savings, 0644, sched_smt_power_savings_show,
- sched_smt_power_savings_store);
+static SYSDEV_ATTR(sched_smt_power_savings, 0644, sched_smt_power_savings_show,
+ sched_smt_power_savings_store);
+#endif
+
+int sched_create_sysfs_power_savings_entries(struct sysdev_class *cls)
+{
+ int err = 0;
+
+#ifdef CONFIG_SCHED_SMT
+ if (smt_capable())
+ err = sysfs_create_file(>kset.kobj,
+ _sched_smt_power_savings.attr);
+#endif
+#ifdef CONFIG_SCHED_MC
+ if (!err && mc_capable())
+ err = sysfs_create_file(>kset.kobj,
+ _sched_mc_power_savings.attr);
+#endif
+ return err;
+}
#endif
/*
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[2.6 patch] mm/shmem.c: make 3 functions static
This patch makes three needlessly global functions static.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
This patch has been sent on:
- 6 Jul 2007
include/linux/mm.h | 15 ---
mm/shmem.c | 10 +-
2 files changed, 5 insertions(+), 20 deletions(-)
--- linux-2.6.22-rc6-mm1/include/linux/mm.h.old 2007-07-05 17:03:26.0
+0200
+++ linux-2.6.22-rc6-mm1/include/linux/mm.h 2007-07-05 17:03:45.0
+0200
@@ -707,9 +707,6 @@
extern void show_free_areas(void);
#ifdef CONFIG_SHMEM
-int shmem_set_policy(struct vm_area_struct *vma, struct mempolicy *new);
-struct mempolicy *shmem_get_policy(struct vm_area_struct *vma,
- unsigned long addr);
int shmem_lock(struct file *file, int lock, struct user_struct *user);
#else
static inline int shmem_lock(struct file *file, int lock,
@@ -717,18 +714,6 @@
{
return 0;
}
-
-static inline int shmem_set_policy(struct vm_area_struct *vma,
- struct mempolicy *new)
-{
- return 0;
-}
-
-static inline struct mempolicy *shmem_get_policy(struct vm_area_struct *vma,
-unsigned long addr)
-{
- return NULL;
-}
#endif
struct file *shmem_file_setup(char *name, loff_t size, unsigned long flags);
--- linux-2.6.22-rc6-mm1/mm/shmem.c.old 2007-07-05 17:04:00.0 +0200
+++ linux-2.6.22-rc6-mm1/mm/shmem.c 2007-07-05 17:06:27.0 +0200
@@ -1025,8 +1025,8 @@
return page;
}
-struct page *shmem_swapin(struct shmem_inode_info *info, swp_entry_t entry,
- unsigned long idx)
+static struct page *shmem_swapin(struct shmem_inode_info *info,
+swp_entry_t entry, unsigned long idx)
{
struct shared_policy *p = >policy;
int i, num;
@@ -1335,14 +1335,14 @@
}
#ifdef CONFIG_NUMA
-int shmem_set_policy(struct vm_area_struct *vma, struct mempolicy *new)
+static int shmem_set_policy(struct vm_area_struct *vma, struct mempolicy *new)
{
struct inode *i = vma->vm_file->f_path.dentry->d_inode;
return mpol_set_shared_policy(_I(i)->policy, vma, new);
}
-struct mempolicy *
-shmem_get_policy(struct vm_area_struct *vma, unsigned long addr)
+static struct mempolicy *shmem_get_policy(struct vm_area_struct *vma,
+ unsigned long addr)
{
struct inode *i = vma->vm_file->f_path.dentry->d_inode;
unsigned long idx;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[2.6 patch] i386: no need to make enable_cpu_hotplug a variable
As long as there's no write access to this variable there's no reason
to let gcc check it at runtime.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
This patch has been sent on:
- 6 Jul 2007
arch/i386/kernel/topology.c |2 --
include/asm-i386/cpu.h |2 +-
2 files changed, 1 insertion(+), 3 deletions(-)
--- linux-2.6.22-rc6-mm1/include/asm-i386/cpu.h.old 2007-07-04
20:29:25.0 +0200
+++ linux-2.6.22-rc6-mm1/include/asm-i386/cpu.h 2007-07-04 20:36:33.0
+0200
@@ -13,7 +13,7 @@
extern int arch_register_cpu(int num);
#ifdef CONFIG_HOTPLUG_CPU
extern void arch_unregister_cpu(int);
-extern int enable_cpu_hotplug;
+#define enable_cpu_hotplug 1
#else
#define enable_cpu_hotplug 0
#endif
--- linux-2.6.22-rc6-mm1/arch/i386/kernel/topology.c.old2007-07-04
20:30:12.0 +0200
+++ linux-2.6.22-rc6-mm1/arch/i386/kernel/topology.c2007-07-04
20:35:56.0 +0200
@@ -51,8 +51,6 @@
}
#ifdef CONFIG_HOTPLUG_CPU
-int enable_cpu_hotplug = 1;
-
void arch_unregister_cpu(int num) {
return unregister_cpu(_devices[num].cpu);
}
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[2.6 patch] ipc/shm.c: make 2 functions static
This patch makes two needlessly global functions static.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
This patch has been sent on:
- 6 Jul 2007
ipc/shm.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
--- linux-2.6.22-rc6-mm1/ipc/shm.c.old 2007-07-05 16:08:24.0 +0200
+++ linux-2.6.22-rc6-mm1/ipc/shm.c 2007-07-05 16:08:44.0 +0200
@@ -234,7 +234,7 @@
}
#ifdef CONFIG_NUMA
-int shm_set_policy(struct vm_area_struct *vma, struct mempolicy *new)
+static int shm_set_policy(struct vm_area_struct *vma, struct mempolicy *new)
{
struct file *file = vma->vm_file;
struct shm_file_data *sfd = shm_file_data(file);
@@ -244,7 +244,8 @@
return err;
}
-struct mempolicy *shm_get_policy(struct vm_area_struct *vma, unsigned long
addr)
+static struct mempolicy *shm_get_policy(struct vm_area_struct *vma,
+ unsigned long addr)
{
struct file *file = vma->vm_file;
struct shm_file_data *sfd = shm_file_data(file);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[2.6 patch] arch/i386/mm/discontig.c: make some variables static
This patch makes some needlessly global variables static. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- This patch has been sent on: - 6 Jul 2007 arch/i386/mm/discontig.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) --- linux-2.6.22-rc6-mm1/arch/i386/mm/discontig.c.old 2007-07-05 15:59:32.0 +0200 +++ linux-2.6.22-rc6-mm1/arch/i386/mm/discontig.c 2007-07-05 16:02:47.0 +0200 @@ -103,14 +103,14 @@ #define LARGE_PAGE_BYTES (PTRS_PER_PTE * PAGE_SIZE) -unsigned long node_remap_start_pfn[MAX_NUMNODES]; +static unsigned long node_remap_start_pfn[MAX_NUMNODES]; unsigned long node_remap_size[MAX_NUMNODES]; -unsigned long node_remap_offset[MAX_NUMNODES]; -void *node_remap_start_vaddr[MAX_NUMNODES]; +static unsigned long node_remap_offset[MAX_NUMNODES]; +static void *node_remap_start_vaddr[MAX_NUMNODES]; void set_pmd_pfn(unsigned long vaddr, unsigned long pfn, pgprot_t flags); -void *node_remap_end_vaddr[MAX_NUMNODES]; -void *node_remap_alloc_vaddr[MAX_NUMNODES]; +static void *node_remap_end_vaddr[MAX_NUMNODES]; +static void *node_remap_alloc_vaddr[MAX_NUMNODES]; static unsigned long kva_start_pfn; static unsigned long kva_pages; /* - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[2.6 patch] lib/ioremap.c should #include
Every file should include the headers containing the prototypes for its global functions (in this case ioremap_page_range()). Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Acked-by: Haavard Skinnemoen <[EMAIL PROTECTED]> --- This patch has been sent on: - 6 Jul 2007 --- linux-2.6.22-rc6-mm1/lib/ioremap.c.old 2007-07-03 05:02:10.0 +0200 +++ linux-2.6.22-rc6-mm1/lib/ioremap.c 2007-07-03 05:02:22.0 +0200 @@ -8,6 +8,7 @@ #include #include #include +#include #include #include - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[2.6 patch] kernel/audit.c: change the exports to EXPORT_SYMBOL_GPL
This patch changes some completely unused audit exports from EXPORT_SYMBOL to EXPORT_SYMBOL_GPL. They are still completely unused, but hopefully some of the theoretical code that might use it will appear in the kernel in the near future... Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Acked-by: Steve Grubb <[EMAIL PROTECTED]> --- This patch has been sent on: - 11 Dec 2006 --- linux-2.6.19-mm1/kernel/audit.c.old 2006-12-11 20:13:54.0 +0100 +++ linux-2.6.19-mm1/kernel/audit.c 2006-12-11 20:14:19.0 +0100 @@ -1209,7 +1209,7 @@ } } -EXPORT_SYMBOL(audit_log_start); -EXPORT_SYMBOL(audit_log_end); -EXPORT_SYMBOL(audit_log_format); -EXPORT_SYMBOL(audit_log); +EXPORT_SYMBOL_GPL(audit_log_start); +EXPORT_SYMBOL_GPL(audit_log_end); +EXPORT_SYMBOL_GPL(audit_log_format); +EXPORT_SYMBOL_GPL(audit_log); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[2.6 patch] fs/afs/: possible cleanups
This patch contains the following possible cleanups:
- make the following needlessly global functions static:
- rxrpc.c: afs_send_pages()
- vlocation.c: afs_vlocation_queue_for_updates()
- write.c: afs_writepages_region()
- make the following needlessly global variables static:
- mntpt.c: afs_mntpt_expiry_timeout
- proc.c: afs_vlocation_states[]
- server.c: afs_server_timeout
- vlocation.c: afs_vlocation_timeout
- vlocation.c: afs_vlocation_update_timeout
- #if 0 the following unused function:
- cell.c: afs_get_cell_maybe()
- #if 0 the following unused variables:
- callback.c: afs_vnode_update_timeout
- cmservice.c: struct afs_cm_workqueue
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
Acked-by: David Howells <[EMAIL PROTECTED]>
---
This patch has been sent on:
- 5 Jun 2007
fs/afs/callback.c |2 ++
fs/afs/cell.c |2 ++
fs/afs/cmservice.c |2 ++
fs/afs/internal.h |1 -
fs/afs/mntpt.c |2 +-
fs/afs/proc.c |2 +-
fs/afs/rxrpc.c |3 ++-
fs/afs/server.c|2 +-
fs/afs/vlocation.c |6 +++---
fs/afs/write.c |6 +++---
10 files changed, 17 insertions(+), 11 deletions(-)
--- linux-2.6.22-rc3-mm1/fs/afs/callback.c.old 2007-06-05 21:45:34.0
+0200
+++ linux-2.6.22-rc3-mm1/fs/afs/callback.c 2007-06-05 21:46:40.0
+0200
@@ -20,7 +20,9 @@
#include
#include "internal.h"
+#if 0
unsigned afs_vnode_update_timeout = 10;
+#endif /* 0 */
#define afs_breakring_space(server) \
CIRC_SPACE((server)->cb_break_head, (server)->cb_break_tail,\
--- linux-2.6.22-rc3-mm1/fs/afs/cell.c.old 2007-06-05 21:47:20.0
+0200
+++ linux-2.6.22-rc3-mm1/fs/afs/cell.c 2007-06-05 21:47:39.0 +0200
@@ -265,6 +265,7 @@
return cell;
}
+#if 0
/*
* try and get a cell record
*/
@@ -280,6 +281,7 @@
write_unlock(_cells_lock);
return cell;
}
+#endif /* 0 */
/*
* destroy a cell record
--- linux-2.6.22-rc3-mm1/fs/afs/cmservice.c.old 2007-06-05 21:48:06.0
+0200
+++ linux-2.6.22-rc3-mm1/fs/afs/cmservice.c 2007-06-05 21:48:19.0
+0200
@@ -16,7 +16,9 @@
#include "internal.h"
#include "afs_cm.h"
+#if 0
struct workqueue_struct *afs_cm_workqueue;
+#endif /* 0 */
static int afs_deliver_cb_init_call_back_state(struct afs_call *,
struct sk_buff *, bool);
--- linux-2.6.22-rc3-mm1/fs/afs/internal.h.old 2007-06-05 21:48:48.0
+0200
+++ linux-2.6.22-rc3-mm1/fs/afs/internal.h 2007-06-05 21:48:55.0
+0200
@@ -570,7 +570,6 @@
*/
extern const struct inode_operations afs_mntpt_inode_operations;
extern const struct file_operations afs_mntpt_file_operations;
-extern unsigned long afs_mntpt_expiry_timeout;
extern int afs_mntpt_check_symlink(struct afs_vnode *, struct key *);
extern void afs_mntpt_kill_timer(void);
--- linux-2.6.22-rc3-mm1/fs/afs/mntpt.c.old 2007-06-05 21:49:03.0
+0200
+++ linux-2.6.22-rc3-mm1/fs/afs/mntpt.c 2007-06-05 21:49:11.0 +0200
@@ -42,7 +42,7 @@
static LIST_HEAD(afs_vfsmounts);
static DECLARE_DELAYED_WORK(afs_mntpt_expiry_timer,
afs_mntpt_expiry_timed_out);
-unsigned long afs_mntpt_expiry_timeout = 10 * 60;
+static unsigned long afs_mntpt_expiry_timeout = 10 * 60;
/*
* check a symbolic link to see whether it actually encodes a mountpoint
--- linux-2.6.22-rc3-mm1/fs/afs/proc.c.old 2007-06-05 21:49:35.0
+0200
+++ linux-2.6.22-rc3-mm1/fs/afs/proc.c 2007-06-05 21:49:43.0 +0200
@@ -513,7 +513,7 @@
up_read(>vl_sem);
}
-const char afs_vlocation_states[][4] = {
+static const char afs_vlocation_states[][4] = {
[AFS_VL_NEW]= "New",
[AFS_VL_CREATING] = "Crt",
[AFS_VL_VALID] = "Val",
--- linux-2.6.22-rc3-mm1/fs/afs/rxrpc.c.old 2007-06-05 21:50:05.0
+0200
+++ linux-2.6.22-rc3-mm1/fs/afs/rxrpc.c 2007-06-05 21:50:19.0 +0200
@@ -239,7 +239,8 @@
/*
* attach the data from a bunch of pages on an inode to a call
*/
-int afs_send_pages(struct afs_call *call, struct msghdr *msg, struct kvec *iov)
+static int afs_send_pages(struct afs_call *call, struct msghdr *msg,
+ struct kvec *iov)
{
struct page *pages[8];
unsigned count, n, loop, offset, to;
--- linux-2.6.22-rc3-mm1/fs/afs/server.c.old2007-06-05 21:50:45.0
+0200
+++ linux-2.6.22-rc3-mm1/fs/afs/server.c2007-06-05 21:50:52.0
+0200
@@ -13,7 +13,7 @@
#include
#include "internal.h"
-unsigned afs_server_timeout = 10; /* server timeout in seconds */
+static unsigned afs_server_timeout = 10; /* server timeout in seconds */
static void afs_reap_server(struct work_struct *);
--- linux-2.6.22-rc3-mm1/fs/afs/vlocation.c.old 2007-06-05 21:51:17.0
+0200
+++ linux-2.6.22-rc3-mm1/fs/afs/vlocation.c 2007-06-05 21:51:55.0
+0200
@@ -15,8 +15,8 @@
#include
[RFC: 2.6 patch] allow disabling DNOTIFY without EMBEDDED
This patch allows disabling DNOTIFY with CONFIG_EMBEDDED=n. I'm currently running a kernel with dnotify disabled and I haven't run into any problem. Is there any popular application left that breaks without dnotify support in the kernel? Note that this patch does not remove dnotify support, it still defaults to "y", and the help text recommends enabling it. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- This patch has been sent on: - 1 Jul 2007 - 22 Jun 2007 --- linux-2.6.22-rc4-mm2/fs/Kconfig.old 2007-06-21 18:25:20.0 +0200 +++ linux-2.6.22-rc4-mm2/fs/Kconfig 2007-06-21 18:25:54.0 +0200 @@ -585,17 +585,17 @@ depends on XFS_QUOTA || QUOTA default y config DNOTIFY - bool "Dnotify support" if EMBEDDED + bool "Dnotify support" default y help Dnotify is a directory-based per-fd file change notification system that uses signals to communicate events to user-space. There exist superior alternatives, but some applications may still rely on dnotify. - Because of this, if unsure, say Y. + If unsure, say Y. config AUTOFS_FS tristate "Kernel automounter support" help - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[2.6 patch] drivers/scsi/constants.c: make 2 functions static
This patch makes two needlessly global functions static.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
This patch has been sent on:
- 24 Mar 2007
drivers/scsi/constants.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- linux-2.6.21-rc4-mm1/drivers/scsi/constants.c.old 2007-03-23
23:26:39.0 +0100
+++ linux-2.6.21-rc4-mm1/drivers/scsi/constants.c 2007-03-23
23:26:55.0 +0100
@@ -1235,7 +1235,7 @@
}
EXPORT_SYMBOL(scsi_print_sense_hdr);
-void
+static void
scsi_decode_sense_buffer(const unsigned char *sense_buffer, int sense_len,
struct scsi_sense_hdr *sshdr)
{
@@ -1258,7 +1258,7 @@
}
}
-void
+static void
scsi_decode_sense_extras(const unsigned char *sense_buffer, int sense_len,
struct scsi_sense_hdr *sshdr)
{
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[2.6 patch] remove fs/jffs2/ioctl.c
fs/jffs2/ioctl.c is already for so long in the "might be used later"
state that I doubt it will ever be actually used...
And if it will ever be used, reverting this patch will be trivial.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
fs/jffs2/Makefile |2 +-
fs/jffs2/dir.c |1 -
fs/jffs2/file.c |1 -
fs/jffs2/ioctl.c| 21 -
fs/jffs2/os-linux.h |3 ---
5 files changed, 1 insertion(+), 27 deletions(-)
--- linux-2.6.14-rc5-mm1-full/fs/jffs2/os-linux.h.old 2005-11-01
20:28:24.0 +0100
+++ linux-2.6.14-rc5-mm1-full/fs/jffs2/os-linux.h 2005-11-01
20:28:31.0 +0100
@@ -147,9 +147,6 @@
int jffs2_fsync(struct file *, struct dentry *, int);
int jffs2_do_readpage_unlock (struct inode *inode, struct page *pg);
-/* ioctl.c */
-int jffs2_ioctl(struct inode *, struct file *, unsigned int, unsigned long);
-
/* symlink.c */
extern struct inode_operations jffs2_symlink_inode_operations;
--- linux-2.6.14-rc5-mm1-full/fs/jffs2/dir.c.old2005-11-01
20:28:39.0 +0100
+++ linux-2.6.14-rc5-mm1-full/fs/jffs2/dir.c2005-11-01 20:28:43.0
+0100
@@ -41,7 +41,6 @@
{
.read = generic_read_dir,
.readdir = jffs2_readdir,
- .ioctl =jffs2_ioctl,
.fsync =jffs2_fsync
};
--- linux-2.6.14-rc5-mm1-full/fs/jffs2/Makefile.old 2005-11-01
20:31:23.0 +0100
+++ linux-2.6.14-rc5-mm1-full/fs/jffs2/Makefile 2005-11-01 20:31:41.0
+0100
@@ -6,7 +6,7 @@
obj-$(CONFIG_JFFS2_FS) += jffs2.o
-jffs2-y:= compr.o dir.o file.o ioctl.o nodelist.o malloc.o
+jffs2-y:= compr.o dir.o file.o nodelist.o malloc.o
jffs2-y+= read.o nodemgmt.o readinode.o write.o scan.o gc.o
jffs2-y+= symlink.o build.o erase.o background.o fs.o writev.o
jffs2-y+= super.o
--- linux-2.6.19-rc6-mm1/fs/jffs2/file.c.old2006-11-26 05:55:29.0
+0100
+++ linux-2.6.19-rc6-mm1/fs/jffs2/file.c2006-11-26 05:53:06.0
+0100
@@ -46,5 +46,4 @@
.write =do_sync_write,
.aio_write =generic_file_aio_write,
- .ioctl =jffs2_ioctl,
.mmap = generic_file_readonly_mmap,
.fsync =jffs2_fsync,
--- linux-2.6.23-rc1-mm1/fs/jffs2/ioctl.c 2007-07-09 01:32:17.0
+0200
+++ /dev/null 2006-09-19 00:45:31.0 +0200
@@ -1,21 +0,0 @@
-/*
- * JFFS2 -- Journalling Flash File System, Version 2.
- *
- * Copyright © 2001-2007 Red Hat, Inc.
- *
- * Created by David Woodhouse <[EMAIL PROTECTED]>
- *
- * For licensing information, see the file 'LICENCE' in this directory.
- *
- */
-
-#include
-
-int jffs2_ioctl(struct inode *inode, struct file *filp, unsigned int cmd,
- unsigned long arg)
-{
- /* Later, this will provide for lsattr.jffs2 and chattr.jffs2, which
- will include compression support etc. */
- return -ENOTTY;
-}
-
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[2.6 patch] parisc: "extern inline" -> "static inline"
"extern inline" will have different semantics with gcc 4.3,
and "static inline" is correct here.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
arch/parisc/lib/memcpy.c |4 ++--
include/asm-parisc/io.h|2 +-
include/asm-parisc/pci.h |2 +-
include/asm-parisc/pgtable.h | 32
include/asm-parisc/prefetch.h |4 ++--
include/asm-parisc/semaphore.h | 10 +-
include/asm-parisc/tlbflush.h |3 +--
7 files changed, 28 insertions(+), 29 deletions(-)
--- linux-2.6.14-rc5-mm1-full/arch/parisc/lib/memcpy.c.old 2005-10-30
01:58:43.0 +0200
+++ linux-2.6.14-rc5-mm1-full/arch/parisc/lib/memcpy.c 2005-10-30
01:59:11.0 +0200
@@ -158,12 +158,12 @@
#define stw(_s,_t,_o,_a,_e)def_store_insn(stw,"r",_s,_t,_o,_a,_e)
#ifdef CONFIG_PREFETCH
-extern inline void prefetch_src(const void *addr)
+static inline void prefetch_src(const void *addr)
{
__asm__("ldw 0(" s_space ",%0), %%r0" : : "r" (addr));
}
-extern inline void prefetch_dst(const void *addr)
+static inline void prefetch_dst(const void *addr)
{
__asm__("ldd 0(" d_space ",%0), %%r0" : : "r" (addr));
}
--- linux-2.6.14-rc5-mm1-full/include/asm-parisc/pci.h.old 2005-10-30
01:59:57.0 +0200
+++ linux-2.6.14-rc5-mm1-full/include/asm-parisc/pci.h 2005-10-30
02:00:01.0 +0200
@@ -193,7 +193,7 @@
extern void pcibios_register_hba(struct pci_hba_data *);
extern void pcibios_set_master(struct pci_dev *);
#else
-extern inline void pcibios_register_hba(struct pci_hba_data *x)
+static inline void pcibios_register_hba(struct pci_hba_data *x)
{
}
#endif
--- linux-2.6.14-rc5-mm1-full/include/asm-parisc/semaphore.h.old
2005-10-30 02:00:45.0 +0200
+++ linux-2.6.14-rc5-mm1-full/include/asm-parisc/semaphore.h2005-10-30
02:00:51.0 +0200
@@ -58,7 +58,7 @@
#define DECLARE_MUTEX(name) __DECLARE_SEMAPHORE_GENERIC(name,1)
#define DECLARE_MUTEX_LOCKED(name) __DECLARE_SEMAPHORE_GENERIC(name,0)
-extern inline void sema_init (struct semaphore *sem, int val)
+static inline void sema_init (struct semaphore *sem, int val)
{
*sem = (struct semaphore)__SEMAPHORE_INITIALIZER((*sem),val);
}
@@ -86,7 +86,7 @@
* interrupts while we're messing with the semaphore. Sorry.
*/
-extern __inline__ void down(struct semaphore * sem)
+static inline void down(struct semaphore * sem)
{
might_sleep();
spin_lock_irq(>sentry);
@@ -98,7 +98,7 @@
spin_unlock_irq(>sentry);
}
-extern __inline__ int down_interruptible(struct semaphore * sem)
+static inline int down_interruptible(struct semaphore * sem)
{
int ret = 0;
might_sleep();
@@ -116,3 +116,3 @@
*/
-extern __inline__ int down_trylock(struct semaphore * sem)
+static inline int down_trylock(struct semaphore * sem)
{
@@ -132,3 +132,3 @@
*/
-extern __inline__ void up(struct semaphore * sem)
+static inline void up(struct semaphore * sem)
{
--- linux-2.6.14-rc5-mm1-full/include/asm-parisc/tlbflush.h.old 2005-10-30
02:01:00.0 +0200
+++ linux-2.6.14-rc5-mm1-full/include/asm-parisc/tlbflush.h 2005-10-30
02:01:06.0 +0200
@@ -42,7 +42,7 @@
#endif
}
-extern __inline__ void flush_tlb_pgtables(struct mm_struct *mm, unsigned long
start, unsigned long end)
+static inline void flush_tlb_pgtables(struct mm_struct *mm, unsigned long
start, unsigned long end)
{
}
--- linux-2.6.18-rc4-mm1/include/asm-parisc/io.h.old2006-08-13
23:08:01.0 +0200
+++ linux-2.6.18-rc4-mm1/include/asm-parisc/io.h2006-08-13
23:08:15.0 +0200
@@ -128,7 +128,7 @@
/* Most machines react poorly to I/O-space being cacheable... Instead let's
* define ioremap() in terms of ioremap_nocache().
*/
-extern inline void __iomem * ioremap(unsigned long offset, unsigned long size)
+static inline void __iomem * ioremap(unsigned long offset, unsigned long size)
{
return __ioremap(offset, size, _PAGE_NO_CACHE);
}
--- linux-2.6.18-rc4-mm1/include/asm-parisc/prefetch.h.old 2006-08-13
23:08:25.0 +0200
+++ linux-2.6.18-rc4-mm1/include/asm-parisc/prefetch.h 2006-08-13
23:08:34.0 +0200
@@ -19,7 +19,7 @@
#ifdef CONFIG_PREFETCH
#define ARCH_HAS_PREFETCH
-extern inline void prefetch(const void *addr)
+static inline void prefetch(const void *addr)
{
__asm__("ldw 0(%0), %%r0" : : "r" (addr));
}
@@ -27,7 +27,7 @@
/* LDD is a PA2.0 addition. */
#ifdef CONFIG_PA20
#define ARCH_HAS_PREFETCHW
-extern inline void prefetchw(const void *addr)
+static inline void prefetchw(const void *addr)
{
__asm__("ldd 0(%0), %%r0" : : "r" (addr));
}
--- linux-2.6.23-rc1-mm1/include/asm-parisc/pgtable.h.old 2007-07-28
17:18:19.0 +0200
+++ linux-2.6.23-rc1-mm1/include/asm-parisc/pgtable.h 2007-07-28
17:18:40.0 +0200
@@ -325,27 +325,27 @@ static inline void pgd_clear(pgd_t *pgd)
* setup: the pgd is never bad, and a pmd always exists (as it's
[2.6 patch] include/linux/Kbuild: remove duplicate entries
This patch removes three headers from header-y that were also listed as unifdef-y. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- include/linux/Kbuild |3 --- 1 file changed, 3 deletions(-) --- linux-2.6.23-rc1-mm1/include/linux/Kbuild.old 2007-07-28 17:15:01.0 +0200 +++ linux-2.6.23-rc1-mm1/include/linux/Kbuild 2007-07-28 17:15:25.0 +0200 @@ -78,7 +78,6 @@ header-y += if_arcnet.h header-y += if_bonding.h header-y += if_cablemodem.h header-y += if_fc.h -header-y += if_fddi.h header-y += if.h header-y += if_hippi.h header-y += if_infiniband.h @@ -121,7 +120,6 @@ header-y += nl80211.h header-y += oom.h header-y += param.h header-y += pci_regs.h -header-y += personality.h header-y += pfkeyv2.h header-y += pg.h header-y += phantom.h @@ -159,7 +157,6 @@ header-y += video_decoder.h header-y += video_encoder.h header-y += videotext.h header-y += vt.h -header-y += wireless.h header-y += x25.h unifdef-y += acct.h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: RFT: updatedb "morning after" problem [was: Re: -mm merge plans for 2.6.23]
On 07/29/2007 04:58 PM, Ray Lee wrote: On 7/29/07, Rene Herman <[EMAIL PROTECTED]> wrote: On 07/29/2007 03:12 PM, Alan Cox wrote: More radically if anyone wants to do real researchy type work - how about log structured swap with a cleaner ? Right over my head. Why does log-structure help anything? Log structured disk layouts allow for better placement of writeout, so that you cn eliminate most or all seeks. Seeks are the enemy when trying to get full disk bandwidth. google on log structured disk layout, or somesuch, for details. I understand what log structure is generally, but how does it help swapin? Rene. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[2.6 patch] drivers/scsi/scsi_error.c should #include "scsi_transport_api.h"
Every file should #include the headers containing the prototypes for its global functions (in this case for scsi_schedule_eh()). Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- --- linux-2.6.23-rc1-mm1/drivers/scsi/scsi_error.c.old 2007-07-28 17:10:48.0 +0200 +++ linux-2.6.23-rc1-mm1/drivers/scsi/scsi_error.c 2007-07-28 17:10:51.0 +0200 @@ -37,6 +37,7 @@ #include "scsi_priv.h" #include "scsi_logging.h" +#include "scsi_transport_api.h" #define SENSE_TIMEOUT (10*HZ) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: How can we make page replacement smarter
Alan Cox wrote: Files are different. File content tends to be grouped in large related chunks, both logically in the file and on disk. Generally there is a lot more file data on a system than what fits in memory. Binary paging patterns don't always look like that unfortunately although I suspect we might want to be weighing towards paging out R/O file mapped pages earlier simply because they are bigger linear chunks A properly implemented use-once algorithm should be able to filter out the spatial locality of reference pages from the temporal locality of reference ones, though... -- Politics is the struggle between those who want to make their country the best in the world, and those who believe it already is. Each group calls the other unpatriotic. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[-mm patch] security/ cleanups
This patch contains the following cleanups that are now possible:
- remove the unused security_operations->inode_xattr_getsuffix
- remove the no longer used security_operations->unregister_security
- remove some no longer required exit code
- remove a bunch of no longer used exports
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
drivers/usb/core/usb.c |1
fs/exec.c|2 -
include/linux/security.h | 15 --
kernel/capability.c |4 --
mm/mmap.c|2 -
mm/nommu.c |1
security/commoncap.c | 21 --
security/dummy.c | 12
security/inode.c |8 -
security/security.c | 58 ---
security/selinux/hooks.c | 20 -
11 files changed, 1 insertion(+), 143 deletions(-)
--- linux-2.6.23-rc1-mm1/include/linux/security.h.old 2007-07-26
03:03:21.0 +0200
+++ linux-2.6.23-rc1-mm1/include/linux/security.h 2007-07-26
03:08:11.0 +0200
@@ -1136,10 +1136,6 @@ struct request_sock;
* allow module stacking.
* @name contains the name of the security module being stacked.
* @ops contains a pointer to the struct security_operations of the module
to stack.
- * @unregister_security:
- * remove a stacked module.
- * @name contains the name of the security module being unstacked.
- * @ops contains a pointer to the struct security_operations of the module
to unstack.
*
* @secid_to_secctx:
* Convert secid to security context.
@@ -1235,7 +1231,6 @@ struct security_operations {
int (*inode_getxattr) (struct dentry *dentry, char *name);
int (*inode_listxattr) (struct dentry *dentry);
int (*inode_removexattr) (struct dentry *dentry, char *name);
- const char *(*inode_xattr_getsuffix) (void);
int (*inode_getsecurity)(const struct inode *inode, const char *name,
void *buffer, size_t size, int err);
int (*inode_setsecurity)(struct inode *inode, const char *name, const
void *value, size_t size, int flags);
int (*inode_listsecurity)(struct inode *inode, char *buffer, size_t
buffer_size);
@@ -1325,8 +1320,6 @@ struct security_operations {
/* allow module stacking */
int (*register_security) (const char *name,
struct security_operations *ops);
- int (*unregister_security) (const char *name,
- struct security_operations *ops);
void (*d_instantiate) (struct dentry *dentry, struct inode *inode);
@@ -1407,9 +1400,7 @@ struct security_operations {
/* prototypes */
extern int security_init (void);
extern int register_security (struct security_operations *ops);
-extern int unregister_security (struct security_operations *ops);
extern int mod_reg_security(const char *name, struct security_operations
*ops);
-extern int mod_unreg_security (const char *name, struct security_operations
*ops);
extern struct dentry *securityfs_create_file(const char *name, mode_t mode,
struct dentry *parent, void *data,
const struct file_operations
*fops);
@@ -1490,7 +1481,6 @@ void security_inode_post_setxattr(struct
int security_inode_getxattr(struct dentry *dentry, char *name);
int security_inode_listxattr(struct dentry *dentry);
int security_inode_removexattr(struct dentry *dentry, char *name);
-const char *security_inode_xattr_getsuffix(void);
int security_inode_getsecurity(const struct inode *inode, const char *name,
void *buffer, size_t size, int err);
int security_inode_setsecurity(struct inode *inode, const char *name, const
void *value, size_t size, int flags);
int security_inode_listsecurity(struct inode *inode, char *buffer, size_t
buffer_size);
@@ -1879,11 +1869,6 @@ static inline int security_inode_removex
return cap_inode_removexattr(dentry, name);
}
-static inline const char *security_inode_xattr_getsuffix (void)
-{
- return NULL ;
-}
-
static inline int security_inode_getsecurity(const struct inode *inode, const
char *name, void *buffer, size_t size, int err)
{
return -EOPNOTSUPP;
--- linux-2.6.23-rc1-mm1/security/security.c.old2007-07-26
03:03:33.0 +0200
+++ linux-2.6.23-rc1-mm1/security/security.c2007-07-27 22:24:41.0
+0200
@@ -71,8 +71,7 @@ int __init security_init(void)
*
* This function is to allow a security module to register itself with the
* kernel security subsystem. Some rudimentary checking is done on the @ops
- * value passed to this function. A call to unregister_security() should be
- * done to remove this security_options structure from the kernel.
+ * value passed to this function.
*
* If there is already a security module registered with the kernel,
* an error will be returned. Otherwise 0 is returned on success.
@@ -94,31 +93,6 @@ int
[2.6.23 regression fix] acpi_ec_remove(): fix use-after-free
This patch fixes an obvious use-after-free introduced by
commit 837012ede14a8fc088be3682c964da7fc6af026b.
Spotted by the Coverity checker.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
--- linux-2.6.23-rc1-mm1/drivers/acpi/ec.c.old 2007-07-28 07:59:49.0
+0200
+++ linux-2.6.23-rc1-mm1/drivers/acpi/ec.c 2007-07-28 08:00:25.0
+0200
@@ -730,14 +730,14 @@
static int acpi_ec_remove(struct acpi_device *device, int type)
{
struct acpi_ec *ec;
- struct acpi_ec_query_handler *handler;
+ struct acpi_ec_query_handler *handler, *tmp;
if (!device)
return -EINVAL;
ec = acpi_driver_data(device);
mutex_lock(>lock);
- list_for_each_entry(handler, >list, node) {
+ list_for_each_entry_safe(handler, tmp, >list, node) {
list_del(>node);
kfree(handler);
}
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
acpi_battery_add(): use-after-free
The Coverity checker spotted the following use-after-free in
acpi_battery_add():
<-- snip -->
...
static int acpi_battery_add(struct acpi_device *device)
{
...
if (result) {
acpi_battery_remove_fs(device);
kfree(battery);
}
mutex_unlock(>mutex);
...
<-- snip -->
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[2.6 patch] unexport pm_power_off_prepare
This patch removes the unused EXPORT_SYMBOL(pm_power_off_prepare).
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
--- linux-2.6.23-rc1-mm1/kernel/sys.c.old 2007-07-28 07:38:45.0
+0200
+++ linux-2.6.23-rc1-mm1/kernel/sys.c 2007-07-28 07:38:59.0 +0200
@@ -104,7 +104,6 @@ EXPORT_SYMBOL(cad_pid);
*/
void (*pm_power_off_prepare)(void);
-EXPORT_SYMBOL(pm_power_off_prepare);
static int set_one_prio(struct task_struct *p, int niceval, int error)
{
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[2.6 patch] unexport fb_prepare_logo
The logo code is not and should not be used by modules. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- --- linux-2.6.23-rc1-mm1/drivers/video/fbmem.c.old 2007-07-28 07:48:45.0 +0200 +++ linux-2.6.23-rc1-mm1/drivers/video/fbmem.c 2007-07-28 07:49:09.0 +0200 @@ -1653,7 +1653,6 @@ EXPORT_SYMBOL(register_framebuffer); EXPORT_SYMBOL(unregister_framebuffer); EXPORT_SYMBOL(num_registered_fb); EXPORT_SYMBOL(registered_fb); -EXPORT_SYMBOL(fb_prepare_logo); EXPORT_SYMBOL(fb_show_logo); EXPORT_SYMBOL(fb_set_var); EXPORT_SYMBOL(fb_blank); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[-mm patch] kernel/pid.c: remove unused exports
On Wed, Jul 25, 2007 at 04:03:04AM -0700, Andrew Morton wrote:
>...
> Changes since 2.6.22-rc6-mm1:
>...
> +pid-namespaces-define-is_global_init-and-is_container_init.patch
>...
> pid namespaces
>...
This patch removes two unused exports.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
kernel/pid.c |2 --
1 file changed, 2 deletions(-)
--- linux-2.6.23-rc1-mm1/kernel/pid.c.old 2007-07-28 07:31:12.0
+0200
+++ linux-2.6.23-rc1-mm1/kernel/pid.c 2007-07-28 07:31:23.0 +0200
@@ -69,13 +69,11 @@ struct pid_namespace init_pid_ns = {
.last_pid = 0,
.child_reaper = _task
};
-EXPORT_SYMBOL(init_pid_ns);
int is_global_init(struct task_struct *tsk)
{
return tsk == init_pid_ns.child_reaper;
}
-EXPORT_SYMBOL(is_global_init);
/*
* Note: disable interrupts while the pidmap_lock is held as an
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[-mm patch] export v4l2_int_device_{,un}register
On Wed, Jul 25, 2007 at 04:03:04AM -0700, Andrew Morton wrote:
>...
> Changes since 2.6.22-rc6-mm1:
>...
> git-dvb.patch
>...
> git trees
>...
This patch fixes the following build error:
<-- snip -->
...
MODPOST 2135 modules
ERROR: "v4l2_int_device_register" [drivers/media/video/tcm825x.ko] undefined!
ERROR: "v4l2_int_device_unregister" [drivers/media/video/tcm825x.ko] undefined!
make[2]: *** [__modpost] Error 1
<-- snip -->
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
drivers/media/video/v4l2-int-device.c |2 ++
1 file changed, 2 insertions(+)
--- linux-2.6.23-rc1-mm1/drivers/media/video/v4l2-int-device.c.old
2007-07-27 14:03:33.0 +0200
+++ linux-2.6.23-rc1-mm1/drivers/media/video/v4l2-int-device.c 2007-07-27
14:04:03.0 +0200
@@ -101,6 +101,7 @@
return 0;
}
+EXPORT_SYMBOL_GPL(v4l2_int_device_register);
void v4l2_int_device_unregister(struct v4l2_int_device *d)
{
@@ -114,6 +115,7 @@
}
mutex_unlock();
}
+EXPORT_SYMBOL_GPL(v4l2_int_device_unregister);
/* Adapted from search_extable in extable.c. */
static v4l2_int_ioctl_func *find_ioctl(struct v4l2_int_slave *slave, int cmd,
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[-mm patch] kernel/printk.c: make 2 variables static
On Wed, Jul 25, 2007 at 04:03:04AM -0700, Andrew Morton wrote:
>...
> Changes since 2.6.22-rc6-mm1:
>...
> +slow-down-printk-during-boot.patch
>...
> Misc
>...
This patch makes two needlessly global variables static.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
--- linux-2.6.23-rc1-mm1/kernel/printk.c.old2007-07-26 22:40:09.0
+0200
+++ linux-2.6.23-rc1-mm1/kernel/printk.c2007-07-26 22:40:50.0
+0200
@@ -166,8 +166,8 @@
#ifdef CONFIG_BOOT_PRINTK_DELAY
-unsigned int boot_delay; /* msecs delay after each printk during bootup */
-unsigned long long printk_delay_msec; /* per msec, based on boot_delay */
+static unsigned int boot_delay; /* msecs delay after each printk during bootup
*/
+static unsigned long long printk_delay_msec; /* per msec, based on boot_delay
*/
static int __init boot_delay_setup(char *str)
{
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[2.6 patch] backlight: make 2 structs static
This patch makes two needlessly global structs static.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
drivers/video/backlight/backlight.c |2 +-
drivers/video/backlight/lcd.c |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--- linux-2.6.23-rc1-mm1/drivers/video/backlight/backlight.c.old
2007-07-26 21:56:23.0 +0200
+++ linux-2.6.23-rc1-mm1/drivers/video/backlight/backlight.c2007-07-26
21:56:31.0 +0200
@@ -164,7 +164,7 @@
return rc;
}
-struct class *backlight_class;
+static struct class *backlight_class;
static void bl_device_release(struct device *dev)
{
--- linux-2.6.23-rc1-mm1/drivers/video/backlight/lcd.c.old 2007-07-26
21:57:40.0 +0200
+++ linux-2.6.23-rc1-mm1/drivers/video/backlight/lcd.c 2007-07-26
22:18:23.0 +0200
@@ -149,7 +149,7 @@
return sprintf(buf, "%d\n", ld->props.max_contrast);
}
-struct class *lcd_class;
+static struct class *lcd_class;
static void lcd_device_release(struct device *dev)
{
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[2.6 patch] drivers/usb/serial/sierra.c: make 3 functions static
This patch makes three needlessly global functions static.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
drivers/usb/serial/sierra.c |7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
--- linux-2.6.23-rc1-mm1/drivers/usb/serial/sierra.c.old2007-07-26
21:52:27.0 +0200
+++ linux-2.6.23-rc1-mm1/drivers/usb/serial/sierra.c2007-07-26
21:53:20.0 +0200
@@ -45,7 +45,7 @@
DEVICE_INSTALLER = 2,
};
-int sierra_set_power_state(struct usb_device *udev, __u16 swiState)
+static int sierra_set_power_state(struct usb_device *udev, __u16 swiState)
{
int result;
dev_dbg(>dev, "%s", "SET POWER STATE");
@@ -60,7 +60,7 @@
return result;
}
-int sierra_set_ms_mode(struct usb_device *udev, __u16 eSocMode)
+static int sierra_set_ms_mode(struct usb_device *udev, __u16 eSocMode)
{
int result;
dev_dbg(>dev, "%s", "DEVICE MODE SWITCH");
@@ -75,7 +75,8 @@
return result;
}
-int sierra_probe(struct usb_interface *iface, const struct usb_device_id *id)
+static int sierra_probe(struct usb_interface *iface,
+ const struct usb_device_id *id)
{
int result;
struct usb_device *udev;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[-mm patch] USB: make dev_attr_authorized_default static
On Wed, Jul 25, 2007 at 04:03:04AM -0700, Andrew Morton wrote: >... > Changes since 2.6.22-rc6-mm1: >... > +gregkh-usb-usb-add-the-concept-of-default-authorization-to-usb-hosts.patch >... > USB tree updates >... dev_attr_authorized_default can become static. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- --- linux-2.6.23-rc1-mm1/drivers/usb/core/hcd.c.old 2007-07-26 21:50:30.0 +0200 +++ linux-2.6.23-rc1-mm1/drivers/usb/core/hcd.c 2007-07-26 21:50:45.0 +0200 @@ -717,9 +717,9 @@ return result; } -DEVICE_ATTR(authorized_default, 0644, - usb_host_authorized_default_show, - usb_host_authorized_default_store); +static DEVICE_ATTR(authorized_default, 0644, + usb_host_authorized_default_show, + usb_host_authorized_default_store); /* Group all the USB bus attributes */ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[2.6 patch] net/unix/af_unix.c: make code static
The following code can now become static:
- struct unix_socket_table
- unix_table_lock
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
include/net/af_unix.h | 29 -
net/unix/af_unix.c| 30 --
2 files changed, 28 insertions(+), 31 deletions(-)
--- linux-2.6.23-rc1-mm1/include/net/af_unix.h.old 2007-07-26
21:17:33.0 +0200
+++ linux-2.6.23-rc1-mm1/include/net/af_unix.h 2007-07-26 21:20:27.0
+0200
@@ -12,37 +12,8 @@
#define UNIX_HASH_SIZE 256
-extern struct hlist_head unix_socket_table[UNIX_HASH_SIZE + 1];
-extern spinlock_t unix_table_lock;
-
extern atomic_t unix_tot_inflight;
-static inline struct sock *first_unix_socket(int *i)
-{
- for (*i = 0; *i <= UNIX_HASH_SIZE; (*i)++) {
- if (!hlist_empty(_socket_table[*i]))
- return __sk_head(_socket_table[*i]);
- }
- return NULL;
-}
-
-static inline struct sock *next_unix_socket(int *i, struct sock *s)
-{
- struct sock *next = sk_next(s);
- /* More in this chain? */
- if (next)
- return next;
- /* Look for next non-empty chain. */
- for ((*i)++; *i <= UNIX_HASH_SIZE; (*i)++) {
- if (!hlist_empty(_socket_table[*i]))
- return __sk_head(_socket_table[*i]);
- }
- return NULL;
-}
-
-#define forall_unix_sockets(i, s) \
- for (s = first_unix_socket(&(i)); s; s = next_unix_socket(&(i),(s)))
-
struct unix_address {
atomic_trefcnt;
int len;
--- linux-2.6.23-rc1-mm1/net/unix/af_unix.c.old 2007-07-26 21:17:48.0
+0200
+++ linux-2.6.23-rc1-mm1/net/unix/af_unix.c 2007-07-26 21:20:24.0
+0200
@@ -118,14 +118,40 @@
int sysctl_unix_max_dgram_qlen __read_mostly = 10;
-struct hlist_head unix_socket_table[UNIX_HASH_SIZE + 1];
-DEFINE_SPINLOCK(unix_table_lock);
+static struct hlist_head unix_socket_table[UNIX_HASH_SIZE + 1];
+static DEFINE_SPINLOCK(unix_table_lock);
static atomic_t unix_nr_socks = ATOMIC_INIT(0);
#define unix_sockets_unbound (_socket_table[UNIX_HASH_SIZE])
#define UNIX_ABSTRACT(sk) (unix_sk(sk)->addr->hash != UNIX_HASH_SIZE)
+static struct sock *first_unix_socket(int *i)
+{
+ for (*i = 0; *i <= UNIX_HASH_SIZE; (*i)++) {
+ if (!hlist_empty(_socket_table[*i]))
+ return __sk_head(_socket_table[*i]);
+ }
+ return NULL;
+}
+
+static struct sock *next_unix_socket(int *i, struct sock *s)
+{
+ struct sock *next = sk_next(s);
+ /* More in this chain? */
+ if (next)
+ return next;
+ /* Look for next non-empty chain. */
+ for ((*i)++; *i <= UNIX_HASH_SIZE; (*i)++) {
+ if (!hlist_empty(_socket_table[*i]))
+ return __sk_head(_socket_table[*i]);
+ }
+ return NULL;
+}
+
+#define forall_unix_sockets(i, s) \
+ for (s = first_unix_socket(&(i)); s; s = next_unix_socket(&(i),(s)))
+
#ifdef CONFIG_SECURITY_NETWORK
static void unix_get_secdata(struct scm_cookie *scm, struct sk_buff *skb)
{
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[-mm patch] make scsi_host_link_pm_policy() static
On Wed, Jul 25, 2007 at 04:03:04AM -0700, Andrew Morton wrote:
>...
> Changes since 2.6.22-rc6-mm1:
>...
> +ata-ahci-alpm-expose-power-management-policy-option-to-users.patch
>...
> ata things
>...
scsi_host_link_pm_policy() can become static.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
--- linux-2.6.23-rc1-mm1/drivers/scsi/scsi_sysfs.c.old 2007-07-26
21:31:24.0 +0200
+++ linux-2.6.23-rc1-mm1/drivers/scsi/scsi_sysfs.c 2007-07-26
21:31:57.0 +0200
@@ -200,7 +200,7 @@
{ SHOST_MEDIUM_POWER, "medium_power" },
};
-const char *scsi_host_link_pm_policy(enum scsi_host_link_pm policy)
+static const char *scsi_host_link_pm_policy(enum scsi_host_link_pm policy)
{
int i;
char *name = NULL;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[2.6 patch] make nf_ct_ipv6_skip_exthdr() static
nf_ct_ipv6_skip_exthdr() can now become static.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
include/net/netfilter/ipv6/nf_conntrack_ipv6.h |3 ---
net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.c |4 ++--
2 files changed, 2 insertions(+), 5 deletions(-)
--- linux-2.6.23-rc1-mm1/include/net/netfilter/ipv6/nf_conntrack_ipv6.h.old
2007-07-26 20:17:47.0 +0200
+++ linux-2.6.23-rc1-mm1/include/net/netfilter/ipv6/nf_conntrack_ipv6.h
2007-07-26 20:17:53.0 +0200
@@ -7,9 +7,6 @@
extern struct nf_conntrack_l4proto nf_conntrack_l4proto_udp6;
extern struct nf_conntrack_l4proto nf_conntrack_l4proto_icmpv6;
-extern int nf_ct_ipv6_skip_exthdr(const struct sk_buff *skb, int start,
- u8 *nexthdrp, int len);
-
extern int nf_ct_frag6_init(void);
extern void nf_ct_frag6_cleanup(void);
extern struct sk_buff *nf_ct_frag6_gather(struct sk_buff *skb);
--- linux-2.6.23-rc1-mm1/net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.c.old
2007-07-26 20:18:03.0 +0200
+++ linux-2.6.23-rc1-mm1/net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.c
2007-07-26 20:18:27.0 +0200
@@ -86,8 +86,8 @@
*- Note also special handling of AUTH header. Thanks to IPsec wizards.
*/
-int nf_ct_ipv6_skip_exthdr(const struct sk_buff *skb, int start, u8 *nexthdrp,
- int len)
+static int nf_ct_ipv6_skip_exthdr(const struct sk_buff *skb, int start,
+ u8 *nexthdrp, int len)
{
u8 nexthdr = *nexthdrp;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[2.6 patch] make pktgen.c:get_ipsec_sa() static and non-inline
Non-static inline code usually doesn't makes sense.
In this case making is static and non-inline is the correct solution.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
--- linux-2.6.23-rc1-mm1/net/core/pktgen.c.old 2007-07-26 20:12:01.0
+0200
+++ linux-2.6.23-rc1-mm1/net/core/pktgen.c 2007-07-26 20:12:13.0
+0200
@@ -2156,8 +2156,7 @@
/* If there was already an IPSEC SA, we keep it as is, else
* we go look for it ...
*/
-inline
-void get_ipsec_sa(struct pktgen_dev *pkt_dev, int flow)
+static void get_ipsec_sa(struct pktgen_dev *pkt_dev, int flow)
{
struct xfrm_state *x = pkt_dev->flows[flow].x;
if (!x) {
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[-mm patch] MTD onenand_sim.c: make struct info static
On Wed, Jul 25, 2007 at 04:03:04AM -0700, Andrew Morton wrote:
>...
> Changes since 2.6.22-rc6-mm1:
>...
> git-mtd.patch
>...
> git trees
>...
This patch makes the needlessly global struct info static.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
--- linux-2.6.23-rc1-mm1/drivers/mtd/onenand/onenand_sim.c.old 2007-07-26
16:11:57.0 +0200
+++ linux-2.6.23-rc1-mm1/drivers/mtd/onenand/onenand_sim.c 2007-07-26
16:12:19.0 +0200
@@ -78,7 +78,7 @@
struct onenand_flashflash;
};
-struct onenand_info *info;
+static struct onenand_info *info;
#define DPRINTK(format, args...) \
do { \
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[-mm patch] e1000: #if 0 two functions
e1000_{read,write}_pci_cfg() are no longer used.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
This patch has been sent on:
- 1 Jul 2007
- 5 Jun 2007
drivers/net/e1000/e1000_hw.h |2 --
drivers/net/e1000/e1000_main.c |4
2 files changed, 4 insertions(+), 2 deletions(-)
--- linux-2.6.22-rc3-mm1/drivers/net/e1000/e1000_hw.h.old 2007-06-04
22:03:05.0 +0200
+++ linux-2.6.22-rc3-mm1/drivers/net/e1000/e1000_hw.h 2007-06-04
22:03:14.0 +0200
@@ -421,8 +421,6 @@ void e1000_tbi_adjust_stats(struct e1000
void e1000_get_bus_info(struct e1000_hw *hw);
void e1000_pci_set_mwi(struct e1000_hw *hw);
void e1000_pci_clear_mwi(struct e1000_hw *hw);
-void e1000_read_pci_cfg(struct e1000_hw *hw, uint32_t reg, uint16_t * value);
-void e1000_write_pci_cfg(struct e1000_hw *hw, uint32_t reg, uint16_t * value);
int32_t e1000_read_pcie_cap_reg(struct e1000_hw *hw, uint32_t reg, uint16_t
*value);
void e1000_pcix_set_mmrbc(struct e1000_hw *hw, int mmrbc);
int e1000_pcix_get_mmrbc(struct e1000_hw *hw);
--- linux-2.6.22-rc3-mm1/drivers/net/e1000/e1000_main.c.old 2007-06-04
22:03:24.0 +0200
+++ linux-2.6.22-rc3-mm1/drivers/net/e1000/e1000_main.c 2007-06-04
22:03:40.0 +0200
@@ -4888,6 +4888,8 @@ e1000_pci_clear_mwi(struct e1000_hw *hw)
pci_clear_mwi(adapter->pdev);
}
+#if 0
+
void
e1000_read_pci_cfg(struct e1000_hw *hw, uint32_t reg, uint16_t *value)
{
@@ -4904,6 +4906,8 @@ e1000_write_pci_cfg(struct e1000_hw *hw,
pci_write_config_word(adapter->pdev, reg, *value);
}
+#endif /* 0 */
+
int
e1000_pcix_get_mmrbc(struct e1000_hw *hw)
{
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[-mm patch] make struct sdio_dev_attrs[] static
On Wed, Jul 25, 2007 at 04:03:04AM -0700, Andrew Morton wrote:
>...
> Changes since 2.6.22-rc6-mm1:
>...
> git-mmc.patch
>...
> git trees
>...
sdio_dev_attrs[] can become static.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
--- linux-2.6.23-rc1-mm1/drivers/mmc/core/sdio_bus.c.old2007-07-26
16:09:20.0 +0200
+++ linux-2.6.23-rc1-mm1/drivers/mmc/core/sdio_bus.c2007-07-26
16:09:30.0 +0200
@@ -45,7 +45,7 @@
func->class, func->vendor, func->device);
}
-struct device_attribute sdio_dev_attrs[] = {
+static struct device_attribute sdio_dev_attrs[] = {
__ATTR_RO(class),
__ATTR_RO(vendor),
__ATTR_RO(device),
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[2.6 patch] make struct sony_nc_ids[] static
sony_nc_ids[] can become static.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
--- linux-2.6.23-rc1-mm1/drivers/misc/sony-laptop.c.old 2007-07-26
16:05:54.0 +0200
+++ linux-2.6.23-rc1-mm1/drivers/misc/sony-laptop.c 2007-07-26
16:06:05.0 +0200
@@ -845,7 +845,7 @@
};
/* SNC-only model map */
-struct dmi_system_id sony_nc_ids[] = {
+static struct dmi_system_id sony_nc_ids[] = {
{
.ident = "Sony Vaio FE Series",
.callback = sony_nc_C_enable,
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[2.6 patch] remove mm/filemap.c:file_send_actor()
This patch removes the no longer used file_send_actor().
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
include/linux/fs.h |1 -
mm/filemap.c | 20
2 files changed, 21 deletions(-)
--- linux-2.6.23-rc1-mm1/include/linux/fs.h.old 2007-07-26 14:57:09.0
+0200
+++ linux-2.6.23-rc1-mm1/include/linux/fs.h 2007-07-26 14:57:15.0
+0200
@@ -1776,7 +1776,6 @@
extern int generic_file_mmap(struct file *, struct vm_area_struct *);
extern int generic_file_readonly_mmap(struct file *, struct vm_area_struct *);
extern int file_read_actor(read_descriptor_t * desc, struct page *page,
unsigned long offset, unsigned long size);
-extern int file_send_actor(read_descriptor_t * desc, struct page *page,
unsigned long offset, unsigned long size);
int generic_write_checks(struct file *file, loff_t *pos, size_t *count, int
isblk);
extern ssize_t generic_file_aio_read(struct kiocb *, const struct iovec *,
unsigned long, loff_t);
extern ssize_t generic_file_aio_write(struct kiocb *, const struct iovec *,
unsigned long, loff_t);
--- linux-2.6.23-rc1-mm1/mm/filemap.c.old 2007-07-26 14:59:05.0
+0200
+++ linux-2.6.23-rc1-mm1/mm/filemap.c 2007-07-26 14:59:16.0 +0200
@@ -1205,26 +1205,6 @@
}
EXPORT_SYMBOL(generic_file_aio_read);
-int file_send_actor(read_descriptor_t * desc, struct page *page, unsigned long
offset, unsigned long size)
-{
- ssize_t written;
- unsigned long count = desc->count;
- struct file *file = desc->arg.data;
-
- if (size > count)
- size = count;
-
- written = file->f_op->sendpage(file, page, offset,
- size, >f_pos, sizeerror = written;
- written = 0;
- }
- desc->count = count - written;
- desc->written += written;
- return written;
-}
-
static ssize_t
do_readahead(struct address_space *mapping, struct file *filp,
pgoff_t index, unsigned long nr)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[2.6 patch] fs/nfsd/export.c: make 3 functions static
This patch makes the following needlessly global functions static:
- exp_get_by_name()
- exp_parent()
- exp_find()
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
fs/nfsd/export.c| 17 -
include/linux/nfsd/export.h | 11 ---
2 files changed, 8 insertions(+), 20 deletions(-)
--- linux-2.6.23-rc1-mm1/include/linux/nfsd/export.h.old2007-07-26
14:31:53.0 +0200
+++ linux-2.6.23-rc1-mm1/include/linux/nfsd/export.h2007-07-26
15:04:52.0 +0200
@@ -127,17 +127,9 @@
void nfsd_export_flush(void);
void exp_readlock(void);
void exp_readunlock(void);
-struct svc_export *exp_get_by_name(struct auth_domain *clp,
- struct vfsmount *mnt,
- struct dentry *dentry,
- struct cache_req *reqp);
struct svc_export *rqst_exp_get_by_name(struct svc_rqst *,
struct vfsmount *,
struct dentry *);
-struct svc_export *exp_parent(struct auth_domain *clp,
- struct vfsmount *mnt,
- struct dentry *dentry,
- struct cache_req *reqp);
struct svc_export *rqst_exp_parent(struct svc_rqst *,
struct vfsmount *mnt,
struct dentry *dentry);
@@ -157,9 +149,6 @@
{
cache_get(>h);
}
-extern struct svc_export *
-exp_find(struct auth_domain *clp, int fsid_type, u32 *fsidv,
-struct cache_req *reqp);
struct svc_export * rqst_exp_find(struct svc_rqst *, int, u32 *);
#endif /* __KERNEL__ */
--- linux-2.6.23-rc1-mm1/fs/nfsd/export.c.old 2007-07-26 14:32:17.0
+0200
+++ linux-2.6.23-rc1-mm1/fs/nfsd/export.c 2007-07-26 14:36:58.0
+0200
@@ -860,9 +860,9 @@
return exp_find_key(clp, FSID_NUM, fsidv, NULL);
}
-svc_export *
-exp_get_by_name(svc_client *clp, struct vfsmount *mnt, struct dentry *dentry,
- struct cache_req *reqp)
+static svc_export *exp_get_by_name(svc_client *clp, struct vfsmount *mnt,
+ struct dentry *dentry,
+ struct cache_req *reqp)
{
struct svc_export *exp, key;
int err;
@@ -886,9 +886,9 @@
/*
* Find the export entry for a given dentry.
*/
-struct svc_export *
-exp_parent(svc_client *clp, struct vfsmount *mnt, struct dentry *dentry,
- struct cache_req *reqp)
+static struct svc_export *exp_parent(svc_client *clp, struct vfsmount *mnt,
+struct dentry *dentry,
+struct cache_req *reqp)
{
svc_export *exp;
@@ -1213,9 +1213,8 @@
return err;
}
-struct svc_export *
-exp_find(struct auth_domain *clp, int fsid_type, u32 *fsidv,
-struct cache_req *reqp)
+static struct svc_export *exp_find(struct auth_domain *clp, int fsid_type,
+ u32 *fsidv, struct cache_req *reqp)
{
struct svc_export *exp;
struct svc_expkey *ek = exp_find_key(clp, fsid_type, fsidv, reqp);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[2.6 patch] mm/page_alloc.c: make code static
This patch makes needlessly global code static.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
mm/page_alloc.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- linux-2.6.23-rc1-mm1/mm/page_alloc.c.old2007-07-26 15:09:24.0
+0200
+++ linux-2.6.23-rc1-mm1/mm/page_alloc.c2007-07-26 15:11:16.0
+0200
@@ -142,7 +142,7 @@
static unsigned long __meminitdata node_boundary_end_pfn[MAX_NUMNODES];
#endif /* CONFIG_MEMORY_HOTPLUG_RESERVE */
unsigned long __initdata required_kernelcore;
- unsigned long __initdata required_movablecore;
+ static unsigned long __initdata required_movablecore;
unsigned long __meminitdata zone_movable_pfn[MAX_NUMNODES];
/* movable_zone is the "real" zone pages in ZONE_MOVABLE are taken from */
@@ -3686,7 +3686,7 @@
return max_pfn;
}
-unsigned long __init early_calculate_totalpages(void)
+static unsigned long __init early_calculate_totalpages(void)
{
int i;
unsigned long totalpages = 0;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: RFT: updatedb "morning after" problem [was: Re: -mm merge plans for 2.6.23]
On 7/29/07, Rene Herman <[EMAIL PROTECTED]> wrote: > On 07/29/2007 03:12 PM, Alan Cox wrote: > > More radically if anyone wants to do real researchy type work - how about > > log structured swap with a cleaner ? > > Right over my head. Why does log-structure help anything? Log structured disk layouts allow for better placement of writeout, so that you cn eliminate most or all seeks. Seeks are the enemy when trying to get full disk bandwidth. google on log structured disk layout, or somesuch, for details. Ray - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[2.6 patch] kernel/rtmutex-debug.c: cleanups
This patch contains the following cleanups:
- make the needlessly global variable rt_trace_on static
- remove the unused global function deadlock_trace_off()
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
This patch has been sent on:
- 1 Jul 2007
- 4 Apr 2007
--- linux-2.6.21-rc5-mm3/kernel/rtmutex-debug.c.old 2007-04-03
01:29:12.0 +0200
+++ linux-2.6.21-rc5-mm3/kernel/rtmutex-debug.c 2007-04-03 01:29:59.0
+0200
@@ -88,12 +88,7 @@
* into the tracing code when doing error printk or
* executing a BUG():
*/
-int rt_trace_on = 1;
-
-void deadlock_trace_off(void)
-{
- rt_trace_on = 0;
-}
+static int rt_trace_on = 1;
static void printk_task(struct task_struct *p)
{
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[2.6 patch] make kernel/power/main.c:suspend_enter() static
suspend_enter() can now become static.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
kernel/power/main.c |2 +-
kernel/power/power.h |1 -
2 files changed, 1 insertion(+), 2 deletions(-)
--- linux-2.6.23-rc1-mm1/kernel/power/power.h.old 2007-07-26
14:49:29.0 +0200
+++ linux-2.6.23-rc1-mm1/kernel/power/power.h 2007-07-26 14:49:36.0
+0200
@@ -177,7 +177,6 @@
unsigned int, char *);
/* kernel/power/main.c */
-extern int suspend_enter(suspend_state_t state);
extern int suspend_devices_and_enter(suspend_state_t state);
extern struct blocking_notifier_head pm_chain_head;
--- linux-2.6.23-rc1-mm1/kernel/power/main.c.old2007-07-26
14:49:44.0 +0200
+++ linux-2.6.23-rc1-mm1/kernel/power/main.c2007-07-26 14:50:05.0
+0200
@@ -120,7 +120,7 @@
*
* This function should be called after devices have been suspended.
*/
-int suspend_enter(suspend_state_t state)
+static int suspend_enter(suspend_state_t state)
{
int error = 0;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[-mm patch] fs/ecryptfs/: make code static
On Wed, Jul 25, 2007 at 04:03:04AM -0700, Andrew Morton wrote:
>...
> Changes since 2.6.22-rc6-mm1:
>...
> +ecryptfs-add-key-list-structure-search-keyring.patch
>...
> ecryptfs feature work
>...
This patch makes some needlessly global code static.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
fs/ecryptfs/crypto.c | 15 +--
fs/ecryptfs/ecryptfs_kernel.h | 10 ---
fs/ecryptfs/keystore.c| 43 +-
3 files changed, 29 insertions(+), 39 deletions(-)
--- linux-2.6.23-rc1-mm1/fs/ecryptfs/ecryptfs_kernel.h.old 2007-07-26
13:50:59.0 +0200
+++ linux-2.6.23-rc1-mm1/fs/ecryptfs/ecryptfs_kernel.h 2007-07-26
14:09:15.0 +0200
@@ -156,7 +156,6 @@
} token;
} __attribute__ ((packed));
-int ecryptfs_get_auth_tok_sig(char **sig, struct ecryptfs_auth_tok *auth_tok);
void ecryptfs_dump_auth_tok(struct ecryptfs_auth_tok *auth_tok);
extern void ecryptfs_to_hex(char *dst, char *src, size_t src_size);
extern void ecryptfs_from_hex(char *dst, char *src, int dst_size);
@@ -290,9 +289,6 @@
unsigned char cipher_name[ECRYPTFS_MAX_CIPHER_NAME_SIZE + 1];
};
-extern struct list_head key_tfm_list;
-extern struct mutex key_tfm_list_mutex;
-
/**
* This struct is to enable a mount-wide passphrase/salt combo. This
* is more or less a stopgap to provide similar functionality to other
@@ -520,9 +516,6 @@
void ecryptfs_destruct_mount_crypt_stat(
struct ecryptfs_mount_crypt_stat *mount_crypt_stat);
int ecryptfs_init_crypt_ctx(struct ecryptfs_crypt_stat *crypt_stat);
-int ecryptfs_crypto_api_algify_cipher_name(char **algified_name,
- char *cipher_name,
- char *chaining_modifier);
#define ECRYPTFS_LOWER_I_MUTEX_NOT_HELD 0
#define ECRYPTFS_LOWER_I_MUTEX_HELD 1
int ecryptfs_write_inode_size_to_metadata(struct file *lower_file,
@@ -563,13 +556,10 @@
struct ecryptfs_crypt_stat *crypt_stat,
struct dentry *ecryptfs_dentry,
size_t *len, size_t max);
-int process_request_key_err(long err_code);
int
ecryptfs_parse_packet_set(struct ecryptfs_crypt_stat *crypt_stat,
unsigned char *src, struct dentry *ecryptfs_dentry);
int ecryptfs_truncate(struct dentry *dentry, loff_t new_length);
-int ecryptfs_process_key_cipher(struct crypto_blkcipher **key_tfm,
- char *cipher_name, size_t *key_size);
int ecryptfs_inode_test(struct inode *inode, void *candidate_lower_inode);
int ecryptfs_inode_set(struct inode *inode, void *lower_inode);
void ecryptfs_init_inode(struct inode *inode, struct inode *lower_inode);
--- linux-2.6.23-rc1-mm1/fs/ecryptfs/crypto.c.old 2007-07-26
13:51:13.0 +0200
+++ linux-2.6.23-rc1-mm1/fs/ecryptfs/crypto.c 2007-07-26 13:59:12.0
+0200
@@ -123,9 +123,9 @@
return rc;
}
-int ecryptfs_crypto_api_algify_cipher_name(char **algified_name,
- char *cipher_name,
- char *chaining_modifier)
+static int ecryptfs_crypto_api_algify_cipher_name(char **algified_name,
+ char *cipher_name,
+ char *chaining_modifier)
{
int cipher_name_len = strlen(cipher_name);
int chaining_modifier_len = strlen(chaining_modifier);
@@ -1828,9 +1828,8 @@
* should be released by other functions, such as on a superblock put
* event, regardless of whether this function succeeds for fails.
*/
-int
-ecryptfs_process_key_cipher(struct crypto_blkcipher **key_tfm,
- char *cipher_name, size_t *key_size)
+static int ecryptfs_process_key_cipher(struct crypto_blkcipher **key_tfm,
+ char *cipher_name, size_t *key_size)
{
char dummy_key[ECRYPTFS_MAX_KEY_BYTES];
char *full_alg_name;
@@ -1874,8 +1873,8 @@
}
struct kmem_cache *ecryptfs_key_tfm_cache;
-struct list_head key_tfm_list;
-struct mutex key_tfm_list_mutex;
+static struct list_head key_tfm_list;
+static struct mutex key_tfm_list_mutex;
int ecryptfs_init_crypto(void)
{
--- linux-2.6.23-rc1-mm1/fs/ecryptfs/keystore.c.old 2007-07-26
14:01:08.0 +0200
+++ linux-2.6.23-rc1-mm1/fs/ecryptfs/keystore.c 2007-07-26 14:09:26.0
+0200
@@ -39,7 +39,7 @@
* determine the type of error, make appropriate log entries, and
* return an error code.
*/
-int process_request_key_err(long err_code)
+static int process_request_key_err(long err_code)
{
int rc = 0;
@@ -396,6 +396,27 @@
return rc;
}
+static int ecryptfs_get_auth_tok_sig(char **sig,
+struct ecryptfs_auth_tok *auth_tok)
+{
+ int rc = 0;
+
+ (*sig) = NULL;
+ switch (auth_tok->token_type) {
+
[-mm patch] make hugetlbfs_read() static
On Wed, Jul 25, 2007 at 04:03:04AM -0700, Andrew Morton wrote:
>...
> Changes since 2.6.22-rc6-mm1:
>...
> +hugetlbfs-read-support.patch
>...
> More MM things
>...
hugetlbfs_read() can become static.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
--- linux-2.6.23-rc1-mm1/fs/hugetlbfs/inode.c.old 2007-07-26
13:28:52.0 +0200
+++ linux-2.6.23-rc1-mm1/fs/hugetlbfs/inode.c 2007-07-26 13:29:30.0
+0200
@@ -217,8 +217,8 @@
* data. Its *very* similar to do_generic_mapping_read(), we can't use that
* since it has PAGE_CACHE_SIZE assumptions.
*/
-ssize_t
-hugetlbfs_read(struct file *filp, char __user *buf, size_t len, loff_t *ppos)
+static ssize_t hugetlbfs_read(struct file *filp, char __user *buf,
+ size_t len, loff_t *ppos)
{
struct address_space *mapping = filp->f_mapping;
struct inode *inode = mapping->host;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
nvidia installer DIW with 2.6.23-rc1
Greetings; I got around to building the 2.6.23-rc1 tree, updated to yesterday with git from the linus tree. The build was fairly clean, but when I rebooted to it, the latest nvidia installer fails, with these messages: nvidia-installer log file '/var/log/nvidia-installer.log' creation time: Sun Jul 29 10:14:04 2007 option status: license pre-accepted: false update : false force update: false expert : false uninstall : false driver info : false precompiled interfaces : true no ncurses color: false query latest version: false OpenGL header files : true no questions: false silent : false no recursion: false no backup : false kernel module only : false sanity : false add this kernel : false no runlevel check : false no network : false no ABI note : false no RPMs : false no kernel module: false force SELinux : default no X server check : false force tls : (not specified) X install prefix: (not specified) X library install path : (not specified) X module install path : (not specified) OpenGL install prefix : (not specified) OpenGL install libdir : (not specified) utility install prefix : (not specified) utility install libdir : (not specified) doc install prefix : (not specified) kernel name : (not specified) kernel include path : (not specified) kernel source path : (not specified) kernel output path : (not specified) kernel install path : (not specified) proc mount point: /proc ui : (not specified) tmpdir : /tmp ftp mirror : ftp://download.nvidia.com RPM file list : (not specified) [...] NVIDIA: calling KBUILD... make CC=cc KBUILD_OUTPUT=/lib/modules/2.6.23-rc1/build KBUILD_VERBOSE=1 -C / lib/modules/2.6.23-rc1/source SUBDIRS=/tmp/selfgz9678/NVIDIA-Linux-x86-100.1 4.11-pkg1/usr/src/nv modules make -C /lib/modules/2.6.23-rc1/build \ KBUILD_SRC=/usr/src/linux.git \ <---has softlink to linux-2.6.23-rc1 KBUILD_EXTMOD="/tmp/selfgz9678/NVIDIA-Linux-x86-100.14.11-pkg1/usr/src/nv" -f /usr/src/linux.git/Makefile modules test -e include/linux/autoconf.h -a -e include/config/auto.conf || ( \ echo; \ echo " ERROR: Kernel configuration is invalid."; \ echo " include/linux/autoconf.h or include/config/auto.conf are missing."; \ echo " Run 'make oldconfig && make prepare' on kernel src to fix it I've done the above, no effect [...] cc -Wp,-MD,/tmp/selfgz9678/NVIDIA-Linux-x86-100.14.11-pkg1/usr/src/nv/.nv. o.d -nostdinc -isystem /usr/lib/gcc/i386-redhat-linux/4.1.2/include -D__KER NEL__ -Iinclude -Iinclude2 -I/usr/src/linux.git/include -include include/lin ux/autoconf.h -I/tmp/selfgz9678/NVIDIA-Linux-x86-100.14.11-pkg1/usr/src/nv -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs -fno-strict-aliasing -fno-c ommon -Werror-implicit-function-declaration -Os -pipe -msoft-float -mregparm =3 -freg-struct-return -mpreferred-stack-boundary=2 -march=athlon -mtune=gen eric -ffreestanding -maccumulate-outgoing-args -DCONFIG_AS_CFI=1 -DCONFIG_AS _CFI_SIGNAL_FRAME=1 - I/usr/src/linux.git/include/asm-i386/mach-default -Iinclude/asm-i386/mach-de fault -fomit-frame-pointer -fno-stack-protector -Wdeclaration-after-statemen t -Wno-pointer-sign -I/tmp/selfgz9678/NVIDIA-Linux-x86-100.14.11-pkg1/usr/s rc/nv -Wall -Wimplicit -Wreturn-type -Wswitch -Wformat -Wchar-subscripts -Wp arentheses -Wpointer-arith -Wno-multichar -Werror -O -fno-common -msoft-floa t -MD -Wsign-compare -Wno-cast-qual -Wno-error -D_LOOSE_KERNEL_NAMES -D__KER NEL__ -DMODULE -DNVRM -DNV_VERSION_STRING=\"100.14.11\" -UDEBUG -U_DEBUG -DN DEBUG -DNV_SIGNAL_STRUCT_RLIM -DNV_MULTIPLE_BRIDGE_AGPGART_PRESENT -DNV_PCI_ GET_CLASS_PRESENT -DNV_SYSCTL_MAX_MAP_COUNT_PRESENT -DNV_PM_MESSAGE_T_PRESEN T -DNV_PCI_CHOOSE_STATE_PRESENT -DNV_VM_INSERT_PAGE_PRESENT -DNV_OLD_MM_KGDB _BREAKPOINT_PRESENT -DNV_REMAP_PFN_RANGE_PRESENT -DNV_CHANGE_PAGE_ATTR_PRESE NT -DNV_ACQUIRE_CONSOLE_SEM_PRESENT -DNV_VMAP_4_PRESENT -DMODULE -D"KBUILD_S TR(s)=#s" -D"KBUILD_BASENAME=KBUILD_STR(nv)" -D"KBUILD_MODNAME=KBUILD_STR(n vidia)" -c -o /tmp/selfgz9678/NVIDIA -Linux-x86-100.14.11-pkg1/usr/src/nv/nv.o /tmp/selfgz9678/NVIDIA-Linux-x86-1 00.14.11-pkg1/usr/src/nv/nv.c In file included from include/linux/list.h:9, from include/linux/preempt.h:12, from include/linux/spinlock.h:50,
[2.6 patch] #if 0 v9fs_fid_lookup_remove()
This patch #if 0's the unused v9fs_fid_lookup_remove().
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
fs/9p/fid.c |2 ++
fs/9p/fid.h |1 -
2 files changed, 2 insertions(+), 1 deletion(-)
--- linux-2.6.23-rc1-mm1/fs/9p/fid.h.old2007-07-26 13:22:00.0
+0200
+++ linux-2.6.23-rc1-mm1/fs/9p/fid.h2007-07-26 13:22:07.0 +0200
@@ -28,6 +28,5 @@
};
struct p9_fid *v9fs_fid_lookup(struct dentry *dentry);
-struct p9_fid *v9fs_fid_lookup_remove(struct dentry *dentry);
struct p9_fid *v9fs_fid_clone(struct dentry *dentry);
int v9fs_fid_add(struct dentry *dentry, struct p9_fid *fid);
--- linux-2.6.23-rc1-mm1/fs/9p/fid.c.old2007-07-26 13:22:22.0
+0200
+++ linux-2.6.23-rc1-mm1/fs/9p/fid.c2007-07-26 13:22:40.0 +0200
@@ -92,6 +92,7 @@
return fid;
}
+#if 0
struct p9_fid *v9fs_fid_lookup_remove(struct dentry *dentry)
{
struct p9_fid *fid;
@@ -107,6 +108,7 @@
return fid;
}
+#endif /* 0 */
/**
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[2.6 patch] make struct dvb_pll_fcv1236d static
struct dvb_pll_fcv1236d can become static.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
--- linux-2.6.23-rc1-mm1/drivers/media/dvb/frontends/dvb-pll.c.old
2007-07-26 09:04:23.0 +0200
+++ linux-2.6.23-rc1-mm1/drivers/media/dvb/frontends/dvb-pll.c 2007-07-26
09:04:32.0 +0200
@@ -501,7 +501,7 @@
/* Philips FCV1236D
*/
-struct dvb_pll_desc dvb_pll_fcv1236d = {
+static struct dvb_pll_desc dvb_pll_fcv1236d = {
/* Bit_0: RF Input select
* Bit_1: 0=digital, 1=analog
*/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[2.6 patch] drivers/i2c/i2c-core.c: make code static
After the i2c-isa removal some code can become static.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
drivers/i2c/i2c-core.c |7 +++
include/linux/i2c.h|2 --
2 files changed, 3 insertions(+), 6 deletions(-)
--- linux-2.6.23-rc1-mm1/include/linux/i2c.h.old2007-07-26
12:46:44.0 +0200
+++ linux-2.6.23-rc1-mm1/include/linux/i2c.h2007-07-26 12:46:53.0
+0200
@@ -35,8 +35,6 @@
#include/* for completion */
#include
-extern struct bus_type i2c_bus_type;
-
/* --- General options
*/
struct i2c_msg;
--- linux-2.6.23-rc1-mm1/drivers/i2c/i2c-core.c.old 2007-07-26
08:59:44.0 +0200
+++ linux-2.6.23-rc1-mm1/drivers/i2c/i2c-core.c 2007-07-26 09:01:42.0
+0200
@@ -190,7 +190,7 @@
{ },
};
-struct bus_type i2c_bus_type = {
+static struct bus_type i2c_bus_type = {
.name = "i2c",
.dev_attrs = i2c_dev_attrs,
.match = i2c_device_match,
@@ -201,7 +201,6 @@
.suspend= i2c_device_suspend,
.resume = i2c_device_resume,
};
-EXPORT_SYMBOL_GPL(i2c_bus_type);
/**
* i2c_new_device - instantiate an i2c device for use with a new style driver
@@ -285,7 +284,7 @@
/* I2C bus adapters -- one roots each I2C or SMBUS segment */
-void i2c_adapter_dev_release(struct device *dev)
+static void i2c_adapter_dev_release(struct device *dev)
{
struct i2c_adapter *adap = to_i2c_adapter(dev);
complete(>dev_released);
@@ -303,7 +302,7 @@
{ },
};
-struct class i2c_adapter_class = {
+static struct class i2c_adapter_class = {
.owner = THIS_MODULE,
.name = "i2c-adapter",
.dev_attrs = i2c_adapter_attrs,
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[2.6 patch] make abituguru3_read_increment_offset() static
abituguru3_read_increment_offset() can become static.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
--- linux-2.6.23-rc1-mm1/drivers/hwmon/abituguru3.c.old 2007-07-26
08:56:33.0 +0200
+++ linux-2.6.23-rc1-mm1/drivers/hwmon/abituguru3.c 2007-07-26
08:57:00.0 +0200
@@ -691,8 +691,9 @@
/* Sensor settings are stored 1 byte per offset with the bytes
placed add consecutive offsets. */
-int abituguru3_read_increment_offset(struct abituguru3_data *data, u8 bank,
- u8 offset, u8 count, u8 *buf, int offset_count)
+static int abituguru3_read_increment_offset(struct abituguru3_data *data,
+ u8 bank, u8 offset, u8 count,
+ u8 *buf, int offset_count)
{
int i, x;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] .gitignore update
On Jul 26 2007 16:15, Alexey Dobriyan wrote: > >Somehow I ended up with the following in tree: > > $ git status > ... > # Untracked files: > # (use "git add ..." to include in what will be committed) > # > # fs/proc/root.o.FuMxJQ > # net/ipv4/tcp_minisocks.o.geCDYR > >These are presumably temporary gcc files, which aren't interesting. But they should not be there by default! Or are they? Looks like an interrupted assembler stage or so. So I do not think *.o.* should be added. Jan -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[2.6 patch] radeon_driver_vblank_do_wait() static
radeon_driver_vblank_do_wait() can become static.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
--- linux-2.6.23-rc1-mm1/drivers/char/drm/radeon_irq.c.old 2007-07-26
08:49:12.0 +0200
+++ linux-2.6.23-rc1-mm1/drivers/char/drm/radeon_irq.c 2007-07-26
08:49:46.0 +0200
@@ -144,8 +144,8 @@
return ret;
}
-int radeon_driver_vblank_do_wait(struct drm_device * dev, unsigned int
*sequence,
-int crtc)
+static int radeon_driver_vblank_do_wait(struct drm_device * dev,
+ unsigned int *sequence, int crtc)
{
drm_radeon_private_t *dev_priv =
(drm_radeon_private_t *) dev->dev_private;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[2.6 patch] make drivers/acpi/event.c:acpi_event_seqnum static
This patch makes the needlessly global "acpi_event_seqnum" static.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
--- linux-2.6.23-rc1-mm1/drivers/acpi/event.c.old 2007-07-26
02:32:59.0 +0200
+++ linux-2.6.23-rc1-mm1/drivers/acpi/event.c 2007-07-26 02:33:07.0
+0200
@@ -108,7 +108,7 @@ static const struct file_operations acpi
};
#ifdef CONFIG_NET
-unsigned int acpi_event_seqnum;
+static unsigned int acpi_event_seqnum;
struct acpi_genl_event {
acpi_device_class device_class;
char bus_id[15];
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[2.6 patch] drivers/base/power/: make 2 functions static
suspend_device() and resume_device() can now become static.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
drivers/base/power/power.h |6 --
drivers/base/power/resume.c |2 +-
drivers/base/power/suspend.c |2 +-
3 files changed, 2 insertions(+), 8 deletions(-)
--- linux-2.6.23-rc1-mm1/drivers/base/power/power.h.old 2007-07-26
05:14:12.0 +0200
+++ linux-2.6.23-rc1-mm1/drivers/base/power/power.h 2007-07-26
05:15:49.0 +0200
@@ -55,12 +55,6 @@
extern void dpm_resume(void);
extern void dpm_power_up(void);
-extern int resume_device(struct device *);
-
-/*
- * suspend.c
- */
-extern int suspend_device(struct device *, pm_message_t);
#else /* CONFIG_PM */
--- linux-2.6.23-rc1-mm1/drivers/base/power/resume.c.old2007-07-26
05:14:28.0 +0200
+++ linux-2.6.23-rc1-mm1/drivers/base/power/resume.c2007-07-26
05:14:39.0 +0200
@@ -20,7 +20,7 @@
*
*/
-int resume_device(struct device * dev)
+static int resume_device(struct device * dev)
{
int error = 0;
--- linux-2.6.23-rc1-mm1/drivers/base/power/suspend.c.old 2007-07-26
05:16:00.0 +0200
+++ linux-2.6.23-rc1-mm1/drivers/base/power/suspend.c 2007-07-26
05:16:17.0 +0200
@@ -54,7 +54,7 @@
* @state: Power state device is entering.
*/
-int suspend_device(struct device * dev, pm_message_t state)
+static int suspend_device(struct device * dev, pm_message_t state)
{
int error = 0;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[2.6 patch] arch/i386/mach-es7000/es7000plat.c: cleanups
This patch contains the following cleanups:
- make some needlessly global functions static
- #if 0 the unused es7000_stop_cpu()
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
This patch has been sent on:
- 6 Jul 2007
arch/i386/mach-es7000/es7000plat.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
--- linux-2.6.22-rc6-mm1/arch/i386/mach-es7000/es7000plat.c.old 2007-07-05
15:49:14.0 +0200
+++ linux-2.6.22-rc6-mm1/arch/i386/mach-es7000/es7000plat.c 2007-07-05
15:50:33.0 +0200
@@ -45,11 +45,11 @@
* ES7000 Globals
*/
-volatile unsigned long *psai = NULL;
-struct mip_reg *mip_reg;
-struct mip_reg *host_reg;
-intmip_port;
-unsigned long mip_addr, host_addr;
+static volatile unsigned long *psai = NULL;
+static struct mip_reg *mip_reg;
+static struct mip_reg *host_reg;
+static int mip_port;
+static unsigned long mip_addr, host_addr;
/*
* GSI override for ES7000 platforms.
@@ -240,6 +240,7 @@
}
+#if 0
int
es7000_stop_cpu(int cpu)
{
@@ -259,6 +260,7 @@
return 0;
}
+#endif /* 0 */
void __init
es7000_sw_apic()
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[2.6 patch] i386 alternative.c: really stop MCEs during code patching
It's CONFIG_X86_MCE, not CONFIG_MCE. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- arch/i386/kernel/alternative.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- linux-2.6.23-rc1-mm1/arch/i386/kernel/alternative.c.old 2007-07-26 01:47:31.0 +0200 +++ linux-2.6.23-rc1-mm1/arch/i386/kernel/alternative.c 2007-07-26 01:47:52.0 +0200 @@ -379,7 +379,7 @@ void __init alternative_instructions(voi that might execute the to be patched code. Other CPUs are not running. */ stop_nmi(); -#ifdef CONFIG_MCE +#ifdef CONFIG_X86_MCE stop_mce(); #endif @@ -417,7 +417,7 @@ void __init alternative_instructions(voi local_irq_restore(flags); restart_nmi(); -#ifdef CONFIG_MCE +#ifdef CONFIG_X86_MCE restart_mce(); #endif } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[2.6 patch] arch/i386/mach-generic/probe.c: make struct apic_probe static
This patch makes the needlessly global struct apic_probe static.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
This patch has been sent on:
- 6 Jul 2007
--- linux-2.6.22-rc6-mm1/arch/i386/mach-generic/probe.c.old 2007-07-05
15:55:40.0 +0200
+++ linux-2.6.22-rc6-mm1/arch/i386/mach-generic/probe.c 2007-07-05
15:55:51.0 +0200
@@ -22,7 +22,7 @@
struct genapic *genapic = _default;
-struct genapic *apic_probe[] __initdata = {
+static struct genapic *apic_probe[] __initdata = {
_summit,
_bigsmp,
_es7000,
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[2.6 patch] sound/synth/util_mem.c: remove pointless check
The Coverity checker spotted that if anyone would call this function
with "prev == NULL", he would still get an Oops a few lines below.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
--- linux-2.6.22-rc6-mm1/sound/synth/util_mem.c.old 2007-07-24
19:37:50.0 +0200
+++ linux-2.6.22-rc6-mm1/sound/synth/util_mem.c 2007-07-24 19:38:37.0
+0200
@@ -112,15 +112,15 @@ __snd_util_memblk_new(struct snd_util_me
struct snd_util_memblk *blk;
blk = kmalloc(sizeof(struct snd_util_memblk) + hdr->block_extra_size,
GFP_KERNEL);
if (blk == NULL)
return NULL;
- if (! prev || prev == >block)
+ if (prev == >block)
blk->offset = 0;
else {
struct snd_util_memblk *p = get_memblk(prev);
blk->offset = p->offset + p->size;
}
blk->size = units;
list_add(>list, prev);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[2.6 patch] i386: remove -maccumulate-outgoing-args
Contrary to the comment "newer gccs do it by default", newer gcc
versions default to -maccumulate-outgoing-args only with
CONFIG_CC_OPTIMIZE_FOR_SIZE=n, and then only with some CPU settings.
Measured with an i386 defconfig, gcc 4.2.1 and kernel 2.6.23-rc1
("orig" is the plain kernel, "changed is with -maccumulate-outgoing-args
removed):
$ ls -la vmlinux*
-rwxrwxr-x 1 bunk bunk 6269713 2007-07-24 22:19 vmlinux.changed
-rwxrwxr-x 1 bunk bunk 6425361 2007-07-24 22:19 vmlinux.orig
$ size vmlinux.*
textdata bss dec hex filename
4493465 504108 614400 5611973 55a1c5 vmlinux.changed
4646160 504108 614400 5764668 57f63c vmlinux.orig
$
That's a 2.5% size increase that does for sure hurt small systems.
If the stack unwinder ever comes back and needs this as indicated in the
comment, adding it to the cflags when the user enabled the unwinder
should be a better option.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
--- linux-2.6.22-rc6-mm1/arch/i386/Makefile.old 2007-07-24 22:29:56.0
+0200
+++ linux-2.6.22-rc6-mm1/arch/i386/Makefile 2007-07-24 22:30:16.0
+0200
@@ -42,10 +42,6 @@
# temporary until string.h is fixed
cflags-y += -ffreestanding
-# this works around some issues with generating unwind tables in older gccs
-# newer gccs do it by default
-cflags-y += -maccumulate-outgoing-args
-
# Disable unit-at-a-time mode on pre-gcc-4.0 compilers, it makes gcc use
# a lot more stack due to the lack of sharing of stacklots:
CFLAGS += $(shell if [ $(call cc-version) -lt 0400 ] ;
then echo $(call cc-option,-fno-unit-at-a-time); fi ;)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[2.6 patch] drivers/net/cxgb3/xgmac.c: remove dead code
This patch removes dead code ("tx_xcnt" can never be != 0 at this place)
spotted by the Coverity checker.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
drivers/net/cxgb3/xgmac.c |5 +
1 file changed, 1 insertion(+), 4 deletions(-)
--- linux-2.6.22-rc6-mm1/drivers/net/cxgb3/xgmac.c.old 2007-07-24
13:55:33.0 +0200
+++ linux-2.6.22-rc6-mm1/drivers/net/cxgb3/xgmac.c 2007-07-24
13:57:06.0 +0200
@@ -510,38 +510,35 @@ int t3b2_mac_watchdog_task(struct cmac *
if (tx_mcnt == mac->tx_mcnt) {
tx_xcnt = (G_TXSPI4SOPCNT(t3_read_reg(adap,
A_XGM_TX_SPI4_SOP_EOP_CNT +
mac->offset)));
if (tx_xcnt == 0) {
t3_write_reg(adap, A_TP_PIO_ADDR,
A_TP_TX_DROP_CNT_CH0 + macidx(mac));
tx_tcnt = (G_TXDROPCNTCH0RCVD(t3_read_reg(adap,
A_TP_PIO_DATA)));
} else {
goto rxcheck;
}
} else {
mac->toggle_cnt = 0;
goto rxcheck;
}
- if (((tx_tcnt != mac->tx_tcnt) &&
-(tx_xcnt == 0) && (mac->tx_xcnt == 0)) ||
- ((mac->tx_mcnt == tx_mcnt) &&
-(tx_xcnt != 0) && (mac->tx_xcnt != 0))) {
+ if ((tx_tcnt != mac->tx_tcnt) && (mac->tx_xcnt == 0)) {
if (mac->toggle_cnt > 4) {
status = 2;
goto out;
} else {
status = 1;
goto out;
}
} else {
mac->toggle_cnt = 0;
goto rxcheck;
}
rxcheck:
if (rx_mcnt != mac->rx_mcnt)
rx_xcnt = (G_TXSPI4SOPCNT(t3_read_reg(adap,
A_XGM_RX_SPI4_SOP_EOP_CNT +
mac->offset)));
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: How can we make page replacement smarter
Rik van Riel wrote: > Al Boldi wrote: > > Good idea, but unless we understand the problems involved, we are bound > > to repeat it. So my first question would be: Why is swap-in so slow? > > > > As I have posted in other threads, swap-in of consecutive pages suffers > > a 2x slowdown wrt swap-out, whereas swap-in of random pages suffers over > > 6x slowdown. > > > > Because it is hard to quantify the expected swap-in speed for random > > pages, let's first tackle the swap-in of consecutive pages, which should > > be at least as fast as swap-out. So again, why is swap-in so slow? > > I suspect that this is a locality of reference issue. > > Anonymous memory can get jumbled up by repeated free and > malloc cycles of many smaller objects. The amount of > anonymous memory is often smaller than or roughly the same > size as system memory. Sounds exactly like the tmpfs problem. > Locality of refenence to anonymous memory tends to be > temporal in nature, with the same sets of pages being > accessed over and over again. > > Files are different. File content tends to be grouped > in large related chunks, both logically in the file and > on disk. Generally there is a lot more file data on a > system than what fits in memory. > > Locality of reference to file data tends to be spatial > in nature, with one file access leading up to the system > accessing "nearby" data. The data is not necessarily > touched again any time soon. > > > Once we understand this problem, we may be able to suggest a smart > > improvement. > > Like the one on http://linux-mm.org/PageoutFailureModes ? Interesting to see that there are known problems, but it doesn't seem to list the resume-from-disk swap-in slowdown. > I have the LRU lists split and am working on getting SEQ > replacement implemented for the anonymous pages. > > The most recent (untested) patches are attached. Applied against 2.6.22; the kernel crashes out on boot. Thanks! -- Al - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
