This one-liner patch fixes a bug in drivers/auxdisplay/cfag12864b.c
At cfag12864b_init(), the driver tries to kalloc some memory in the
variable cfag12864b_cache.
Then, as usual, it checks if the call failed. However, it checks
cfag12864b_buffer instead.
This patch changes the cfag12864b_buffer
On Fri, 17 Aug 2007, Herbert Xu wrote:
On Fri, Aug 17, 2007 at 01:43:27PM +1000, Paul Mackerras wrote:
The cost of doing so seems to me to be well down in the noise - 44
bytes of extra kernel text on a ppc64 G5 config, and I don't believe
the extra few cycles for the occasional extra
Hi, Pavel,
On Thu, 2007-08-16 at 12:26 +0200, Pavel Machek wrote:
Ping... is there some next version?
I'm stuck at the tools side currently. kexec-1.101 just won't load the
kernel properly, and kexec-testing from git does not know -j option. I
tried hand-patching it, but got lots of scary
David Griffith wrote:
On Thu, 16 Aug 2007, Clemens Ladisch wrote:
Please try amidi -d -p virtual and playing a .mid file to this port with
aplaymidi.
$ aplaymidi -p virtual castle2.mid
Invalid port virtual - No such file or directory
Sorry, the name of the correspondig sequencer port is
On Fri, Aug 17 2007, Neil Brown wrote:
On Thursday August 16, [EMAIL PROTECTED] wrote:
On Thu, Aug 16 2007, NeilBrown wrote:
Following are 5 patches which - I think - clean up various bits and pieces
in the block layer.
The only part that might be seen as a function change rather
Joe Perches wrote:
I've got a tree with a directory full of separate
MAINTAINER blocks that looks like:
00_file_description
3c359_network_driver
3c505_network_driver
3c59x_network_driver
3cr990_network_driver
...
zd1211rw_wireless_driver
zf_machz_watchdog
zr36067_video_for_linux_driver
Rene Herman wrote:
On 08/17/2007 03:58 AM, Alan Stern wrote:
On Fri, 17 Aug 2007, Rene Herman wrote:
On 08/16/2007 11:39 PM, Stefan Richter wrote:
Rene Herman wrote:
I personally don't think there's a whole lot wrong with more and
more expecting people who submit patches (for whom this
[ Cc: list heavily trimmed. ]
On Thu, 16 Aug 2007, Jeff Dike wrote:
On Wed, Aug 15, 2007 at 05:40:11PM -0700, Joe Perches wrote:
fs/hostfs/hostfs_user.c:if(attrs-ia_valid HOSTFS_ATTR_CTIME) ;
This one can be deleted, but I think I did it for documentation
reasons, to make it
On Thu, 16 Aug 2007, Linus Torvalds wrote:
On Fri, 17 Aug 2007, Paul Mackerras wrote:
I'm really surprised it's as much as a few K. I tried it on powerpc
and it only saved 40 bytes (10 instructions) for a G5 config.
One of the things that volatile generally screws up is a simple
Matt,
It's not easy to do direct performance comparisons between pmaps and
pagemap/kpagemap. However some close analyzes are still possible :)
1) code size
pmaps ~200 LOC
pagemap/kpagemap~300 LOC
2) dataset size
take for example my running firefox on Intel Core 2:
VSZ
On Fri, 17 Aug 2007 11:56:11 +0800 Ian Kent [EMAIL PROTECTED] wrote:
On Wed, 2007-08-15 at 14:31 +0800, Ian Kent wrote:
On Tue, 2007-08-14 at 10:17 -0400, Jeff Moyer wrote:
Ian Kent [EMAIL PROTECTED] writes:
After spending quite a bit of time trying to resolve this on more than
On Mon, Aug 13, 2007 at 06:30:00PM +0800, Fengguang Wu wrote:
On Sun, Aug 12, 2007 at 05:11:23PM +0800, Fengguang Wu wrote:
Miklos Szeredi [EMAIL PROTECTED] and me identified a writeback bug:
Basicly they are
- during the dd: ~16M
- after 30s: ~4M
- after 5s: ~4M
-
On Thu, 16 Aug 2007, NeilBrown wrote:
Every usage of rq_for_each_bio wraps a usage of
bio_for_each_segment, so these can be combined into
rq_for_each_segment.
We define struct req_iterator to hold the 'bio' and 'index' that
are needed for the double iteration.
---
Dear All,
The Red Hat Enterprise Linux 5 LSPP/EAL4 Certification Testsuite has
been released and can be found at http://ltp.sourceforge.net/ or
http://sourceforge.net/project/showfiles.php?group_id=3382. You can find
more details about this testsuite from 'lspp/README' contained in the
On Thu, 2007-08-16 at 14:29 -0700, Christoph Lameter wrote:
Is there any way to make the global limits on which the dirty rate
calculations are based cpuset specific?
A process is part of a cpuset and that cpuset has only a fraction of
memory of the whole system.
And only a fraction of
Petr wrote:
Please do not add comments inside functions.
I find this advice a bit odd. I am not aware of
any prohibition of comments inside functions.
As with comments outside functions, they should
serve a worthwhile purpose, of course. One might
debate whether this particular comment added
On Friday August 17, [EMAIL PROTECTED] wrote:
Please inspect the #block-2.6.24 branch to see the result.
I don't know where to look for this. I checked
http://git.kernel.org/?p=linux/kernel/git/axboe/linux-2.6-block.git
but they don't seem to be there.
??
That's where it is,
GolovaSteek skrev:
Hello!
I need use sleep with accurat timing.
I use 2.6.21 with rt-prempt patch.
with enabled rt_preempt, dyn_ticks, and local_apic
But
req.tv_nsec = 30;
req.tv_sec = 0;
nanosleep(req,NULL)
make pause around 310-330 microseconds.
How do you measure this?
If you want to
Satyam Sharma wrote:
#define atomic_read_volatile(v) \
({ \
forget((v)-counter);\
((v)-counter); \
})
where:
*vomit* :)
On Thu, 16 Aug 2007, Paul E. McKenney wrote:
On Fri, Aug 17, 2007 at 07:59:02AM +0800, Herbert Xu wrote:
On Thu, Aug 16, 2007 at 09:34:41AM -0700, Paul E. McKenney wrote:
The compiler can also reorder non-volatile accesses. For an example
patch that cares about this, please see:
Nick Piggin wrote:
I don't know why people would assume volatile of atomics. AFAIK, most
of the documentation is pretty clear that all the atomic stuff can be
reordered etc. except for those that modify and return a value.
Which documentation is there?
For driver authors, there is LDD3. It
Rusty Russell wrote:
On Thu, 2007-08-16 at 17:58 +0200, Laurent Vivier wrote:
[PATCH 3/3] introduce account modifiers mechanism in the kernel allowing a
module to modify the collected accounting for a given task. This
implementation
is based on the preempt_notifier. account_system_time() and
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Paul Jackson wrote:
Petr wrote:
Please do not add comments inside functions.
I find this advice a bit odd. I am not aware of
any prohibition of comments inside functions.
As with comments outside functions, they should
serve a worthwhile
On 8/16/07, Steven Whitehouse [EMAIL PROTECTED] wrote:
Hi,
On Thu, 2007-08-16 at 16:20 +0800, 程任全 wrote:
It seems that gfs2 cannot work well with Samba,
I'm using the gfs2 and the new cluster suite(cman with openais),
1. the testing environment is that 1 iscsi target and 2 cluster
2007/8/17, Michal Schmidt [EMAIL PROTECTED]:
GolovaSteek skrev:
Hello!
I need use sleep with accurat timing.
I use 2.6.21 with rt-prempt patch.
with enabled rt_preempt, dyn_ticks, and local_apic
But
req.tv_nsec = 30;
req.tv_sec = 0;
nanosleep(req,NULL)
make pause around
On Fri, 17 Aug 2007 11:25:46 +1000 Rusty Russell [EMAIL PROTECTED]
wrote:
diff -r 0730da2377be drivers/char/Kconfig
--- a/drivers/char/KconfigTue Aug 14 12:46:08 2007 +1000
+++ b/drivers/char/KconfigFri Aug 17 09:05:12 2007 +1000
@@ -568,10 +568,10 @@ config HVC_DRIVER
config
Mike Frysinger wrote:
Hmm, sort of, although I didn't think about the case of no real console
replacing the early console. The intention of the patch is to have a
smooth handover from the boot console to the real console. And, yes, if
no real console is ever registered the boot console keeps
On Aug 17 2007 11:44, GolovaSteek wrote:
How do you measure this?
If you want to have something done every 300 microseconds, you must not
sleep for 300 microseconds in each iteration, because you'd accumulate
errors. Use a periodic timer or use the current time to compute how long
to sleep
On 8/17/07, Larry Finger [EMAIL PROTECTED] wrote:
A new driver for the Broadcom BCM43xx devices has been written that uses
mac80211, rather than
softmac. The newest versions of the Broadcom firmware does not support all
the BCM devices.
Accordingly, a separate driver is being prepared that
On Fri, 17 Aug 2007 10:19:24 +0900,
Tejun Heo [EMAIL PROTECTED] wrote:
Alan Stern wrote:
This patch (as960) removes the error message and stack dump logged by
sysfs_remove_bin_file() when someone tries to remove a nonexistent
file. The warning doesn't seem to be needed, since none of the
On Thu, 2007-08-16 at 09:01 -0700, Paul E. McKenney wrote:
On Thu, Aug 16, 2007 at 04:25:07PM +0200, Peter Zijlstra wrote:
There seem to be some unbalanced rcu_read_{,un}lock() issues of late,
how about doing something like this:
This will break when rcu_read_lock() and
Stefan Richter wrote:
Nick Piggin wrote:
I don't know why people would assume volatile of atomics. AFAIK, most
of the documentation is pretty clear that all the atomic stuff can be
reordered etc. except for those that modify and return a value.
Which documentation is there?
On Thu, 16 Aug 2007 08:35:38 EDT, Neil Horman said:
Hey again-
Andrew requested that I repost this cleanly, after running the patch
through checkpatch. As requested here it is with the changelog.
Currently, there exists no method for a process to query the resource
limits of another
On Fri, 17 Aug 2007, Paul Mackerras wrote:
Herbert Xu writes:
On Fri, Aug 17, 2007 at 03:09:57PM +1000, Paul Mackerras wrote:
Herbert Xu writes:
Can you find an actual atomic_read code snippet there that is
broken without the volatile modifier?
There are some in
On Fri, 2007-08-17 at 09:35 +0200, Laurent Vivier wrote:
Rusty Russell wrote:
Hi Laurent,
Hi Rusty,
how are your puppies ?
They're getting a little fat, actually. Too many features ...
- remove PATCH 3, and add in task_struct a ktime vtime where we accumulate
guest time (by calling
Randy, Eric,
Thanks you very much!
There is only diffs in http://ftp.arm.linux.org.uk/pub/armlinux/kernel/git-cur/.
What's these diffs base on, Linus' kernel tree?
2007/8/16, eric miao [EMAIL PROTECTED]:
And if you purpose is only to download that tree, my suggestion is that
some of the git
On Fri, 17 Aug 2007, Nick Piggin wrote:
Satyam Sharma wrote:
#define atomic_read_volatile(v) \
({ \
forget((v)-counter); \
((v)-counter); \
Satyam Sharma wrote:
On Fri, 17 Aug 2007, Herbert Xu wrote:
On Fri, Aug 17, 2007 at 01:43:27PM +1000, Paul Mackerras wrote:
BTW, the sort of missing barriers that triggered this thread
aren't that subtle. It'll result in a simple lock-up if the
loop condition holds upon entry. At which
From: Pavel Emelianov [EMAIL PROTECTED]
Introduce generic structures and routines for resource accounting.
Each resource accounting container is supposed to aggregate it,
container_subsystem_state and its resource-specific members within.
Signed-off-by: Pavel Emelianov [EMAIL PROTECTED]
Allow tasks to migrate from one container to the other. We migrate
mm_struct's mem_container only when the thread group id migrates.
Signed-off-by: [EMAIL PROTECTED]
---
mm/memcontrol.c | 35 +++
1 file changed, 35 insertions(+)
diff -puN
Changelog for v6
1. Do a css_put() in the case of a race in allocating page containers
(YAMAMOTO Takashi)
Changelog for v5
1. Rename meta_page to page_container
2. Remove PG_metapage and use the lower bit of the page_container pointer
for locking
Changelog for v3
1. Fix a probable leak
Changelong
1. use depends instead of select in init/Kconfig
2. Port to v11
3. Clean up the usage of names (container files) for v11
Setup the memory container and add basic hooks and controls to integrate
and work with the container.
Signed-off-by: [EMAIL PROTECTED]
---
Here's version 6 of the memory controller (against 2.6.23-rc2-mm2).
The tests that were run has been included in the _Test Results section_ below.
Changelog since version 5
1. Ported to 2.6.23-rc2-mm2
2. Added a css_put() in the case of race between allocation of page_containers
(YAMAMOTO
From: Pavel Emelianov [EMAIL PROTECTED]
Out of memory handling for containers over their limit. A task from the
container over limit is chosen using the existing OOM logic and killed.
TODO:
1. As discussed in the OLS BOF session, consider implementing a user
space policy for OOM handling.
On Fri, 17 Aug 2007, Nick Piggin wrote:
Stefan Richter wrote:
[...]
Just use spinlocks if you're not absolutely clear about potential
races and memory ordering issues -- they're pretty cheap and simple.
I fully agree with this. As Paul Mackerras mentioned elsewhere,
a lot of authors
Make page_referenced() container aware. Without this patch, page_referenced()
can cause a page to be skipped while reclaiming pages. This patch
ensures that other containers do not hold pages in a particular container
hostage. It is required to ensure that shared pages are freed from a container
Choose if we want cached pages to be accounted or not. By default both
are accounted for. A new set of tunables are added.
echo -n 1 mem_control_type
switches the accounting to account for only mapped pages
echo -n 3 mem_control_type
switches the behaviour back
Signed-off-by: [EMAIL
Changelog since v3
1. Added reclaim retry logic to avoid being OOM'ed due to pages from
swap cache (coming in due to reclaim) don't overwhelm the container.
Changelog
1. Fix probable NULL pointer dereference based on review comments
by YAMAMOTO Takashi
Add the page_container to the per
On Friday 17 August 2007 05:42, Linus Torvalds wrote:
On Fri, 17 Aug 2007, Paul Mackerras wrote:
I'm really surprised it's as much as a few K. I tried it on powerpc
and it only saved 40 bytes (10 instructions) for a G5 config.
One of the things that volatile generally screws up is a simple
On Fri, 17 Aug 2007, Nick Piggin wrote:
Satyam Sharma wrote:
[...]
Granted, the above IS buggy code. But, the stated objective is to avoid
heisenbugs.
^^
Anyway, why are you making up code snippets that are buggy in other
ways in order to support this assertion being made
I agree that (1) one risks overdoing comments and (2) one should minimize
comments inside a function body.
But I read your earlier statement:
Please do not add comments inside functions.
as simply requesting no comments inside function bodies, without
exception. That seems to me to be too
Rusty Russell wrote:
On Fri, 2007-08-17 at 09:35 +0200, Laurent Vivier wrote:
Rusty Russell wrote:
Hi Laurent,
Hi Rusty,
how are your puppies ?
They're getting a little fat, actually. Too many features ...
- remove PATCH 3, and add in task_struct a ktime vtime where we accumulate
Satyam Sharma wrote:
On Fri, 17 Aug 2007, Nick Piggin wrote:
Sure, now
that I learned of these properties I can start to audit code and insert
barriers where I believe they are needed, but this simply means that
almost all occurrences of atomic_read will get barriers (unless there
already
Satyam Sharma wrote:
On Fri, 17 Aug 2007, Nick Piggin wrote:
Also, why would you want to make these insane accessors for atomic_t
types? Just make sure everybody knows the basics of barriers, and they
can apply that knowledge to atomic_t and all other lockless memory
accesses as well.
From: Pavel Emelianov [EMAIL PROTECTED]
Changelog for v5
1. Remove inclusion of memcontrol.h from mm_types.h
Changelog
As per Paul's review comments
1. Drop css_get() for the root memory container
2. Use mem_container_from_task() as an optimization instead of using
Satyam Sharma wrote:
On Fri, 17 Aug 2007, Nick Piggin wrote:
Satyam Sharma wrote:
[...]
Granted, the above IS buggy code. But, the stated objective is to avoid
heisenbugs.
^^
Anyway, why are you making up code snippets that are buggy in other
ways in order to support this
This call should return the virtual pid to the caller, just like
the sys_getpid()/sys_gettid() do, no the global one.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
Cc: Sukadev Bhattiprolu [EMAIL PROTECTED]
Cc: Oleg Nesterov [EMAIL PROTECTED]
When the pid comes from the userspace, the find_task_by_pid_ns()
should be used to find the task by pid in particular (usually the
current) namespace. These places were lost in earlier patches.
Think over: all these places work like this:
if (pid == 0)
task = current;
Show the amount of swapped out pages in /proc/pid/smaps.
Currently there's no way to know who is using the swap file.
A possible better way to support it is to add a new counter to struct_mm.
Or maybe not that important at all?
Signed-off-by: Fengguang Wu [EMAIL PROTECTED]
---
This patch addresses the issue with osize too small errors in mppe encryption.
The patch fixes the issue with wrong output buffer size being passed to ppp
decompression routine.
Signed-off-by: Konstantin Sharlaimov [EMAIL PROTECTED]
---
As pointed out by Suresh Mahalingam, the issue addressed by
Btw, at:
diff -uprN -X linux-2.6.22-base/Documentation/dontdiff
linux-2.6.22-base/security/smack/Kconfig
linux-2.6.22/security/smack/Kconfig
--- linux-2.6.22-base/security/smack/Kconfig1969-12-31
16:00:00.0 -0800
+++ linux-2.6.22/security/smack/Kconfig 2007-07-10 01:08:05.0
Satyam Sharma writes:
I wonder if this'll generate smaller and better code than _both_ the
other atomic_read_volatile() variants. Would need to build allyesconfig
on lots of diff arch's etc to test the theory though.
I'm sure it would be a tiny effect.
This whole thread is arguing about
On Fri, 17 Aug 2007, Nick Piggin wrote:
Satyam Sharma wrote:
On Fri, 17 Aug 2007, Nick Piggin wrote:
Sure, now
that I learned of these properties I can start to audit code and insert
barriers where I believe they are needed, but this simply means that
almost all
On Fri, 17 Aug 2007, Andi Kleen wrote:
On Friday 17 August 2007 05:42, Linus Torvalds wrote:
On Fri, 17 Aug 2007, Paul Mackerras wrote:
I'm really surprised it's as much as a few K. I tried it on powerpc
and it only saved 40 bytes (10 instructions) for a G5 config.
One of the
The function in question returns ERR_PTR-s to indicate the
error, while the caller checks for return value to be NULL.
Found during testing the OpenVZ kernel with pid namespaces.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
Cc: Sukadev
On Fri, 17 Aug 2007, Nick Piggin wrote:
Satyam Sharma wrote:
On Fri, 17 Aug 2007, Nick Piggin wrote:
Also, why would you want to make these insane accessors for atomic_t
types? Just make sure everybody knows the basics of barriers, and they
can apply that knowledge to atomic_t
On Fri, 17 Aug 2007, Paul Mackerras wrote:
Satyam Sharma writes:
I wonder if this'll generate smaller and better code than _both_ the
other atomic_read_volatile() variants. Would need to build allyesconfig
on lots of diff arch's etc to test the theory though.
I'm sure it would be a
On Aug 2 2007 20:33, Patrick McHardy wrote:
End result:
After loading nf_conntrack_ipv4.ko, everything works again (also with the
bad ff09b7). But I have to load it explicitly, and I think that
unfortunately breaks a lot of setups (such as mine) which assume ipv4
connection tracking is
On Fri, 17 Aug 2007, Nick Piggin wrote:
Satyam Sharma wrote:
[...]
The point is about *author expecations*. If people do expect atomic_read()
(or a variant thereof) to have volatile semantics, why not give them such
a variant?
Because they should be thinking about them in terms of
Various architectures may call bust_spinlocks() recursively (when calling die()
in
the context do an unresolved page fault); the function itself, however, doesn't
appear to be meant to be called in this manner. Nevertheless, this doesn't
appear to be a problem as long as bust_spinlocks(0) doesn't
Hi,
On May 10 2007 18:12, Jan Engelhardt wrote:
Subject: Re: [another git patch] move USB net drivers to drivers/net
Hi Jeff,
On May 9 2007 21:38, Jeff Garzik wrote:
diff --git a/drivers/net/Makefile b/drivers/net/Makefile
index 59c0459..c5d8423 100644
--- a/drivers/net/Makefile
+++
On Thu, Aug 16, 2007 at 06:26:35PM +0900, Takenori Nagano wrote:
Vivek Goyal wrote:
So for the time being I think we can put RAS tools on die notifier list
and if it runs into issues we can always think of creating a separate list.
Few things come to mind.
- Why there is a separate
I wrote:
Nick Piggin wrote:
You might find that these places that appear to need barriers are
buggy for other reasons anyway. Can you point to some in-tree code
we can have a look at?
I could, or could not, if I were through with auditing the code. I
remembered one case and posted it
On Aug 17 2007 01:06, Atsushi Nemoto wrote:
Add an MODULE_ALIAS() to make this platform driver hotplug-aware.
Signed-off-by: Atsushi Nemoto [EMAIL PROTECTED]
---
diff --git a/drivers/rtc/rtc-ds1742.c b/drivers/rtc/rtc-ds1742.c
index b2e5481..4bd22dc 100644
--- a/drivers/rtc/rtc-ds1742.c
+++
On Fri, Aug 17, 2007 at 04:09:26AM -0400, [EMAIL PROTECTED] wrote:
On Thu, 16 Aug 2007 08:35:38 EDT, Neil Horman said:
Hey again-
Andrew requested that I repost this cleanly, after running the patch
through checkpatch. As requested here it is with the changelog.
Currently, there
Nick Piggin wrote:
Stefan Richter wrote:
For architecture port authors, there is Documentation/atomic_ops.txt.
Driver authors also can learn something from that document, as it
indirectly documents the atomic_t and bitops APIs.
Semantics and Behavior of Atomic and Bitmask Operations is
GolovaSteek wrote:
2007/8/17, Michal Schmidt [EMAIL PROTECTED]:
GolovaSteek skrev:
Hello!
I need use sleep with accurat timing.
I use 2.6.21 with rt-prempt patch.
with enabled rt_preempt, dyn_ticks, and local_apic
But
req.tv_nsec = 30;
req.tv_sec = 0;
nanosleep(req,NULL)
Nick Piggin wrote:
Satyam Sharma wrote:
And we have driver / subsystem maintainers such as Stefan
coming up and admitting that often a lot of code that's written to use
atomic_read() does assume the read will not be elided by the compiler.
So these are broken on i386 and x86-64?
The
Hello,
our SLES production system
2.6.5-7.252-smp #1 SMP Tue Feb 14 11:11:04 UTC 2006 x86_64 x86_64 x86_64
stopped with the following messages in the log
Is this a known bug in this version and is it solved in the next versions.
As I wrote it is a production server so I can't change away from
On Fri, 17 Aug 2007, Andreas Moroder wrote:
our SLES production system 2.6.5-7.252-smp #1 SMP Tue Feb 14 11:11:04
UTC 2006 x86_64 x86_64 x86_64 stopped with the following messages in the
log Is this a known bug in this version and is it solved in the next
versions.
Hi,
this is
On Wed, 2007-08-15 at 18:08 -0400, Jeff Garzik wrote:
While upgrading nfs-utils on my NFSv4 file server (F7 x86-64
2.6.23-rc3), I got an oops on the NFSv4 client (FC6 x86-64 2.6.23-rc3),
and communications stopped.
I rebooted the client, and everything was fine again. Then, on the
KVM updates vtime in task_struct to allow account_guest_time() to modify user,
system and guest time in cpustat accordingly.
Index: kvm/drivers/kvm/Kconfig
===
--- kvm.orig/drivers/kvm/Kconfig2007-08-17 10:24:46.0
Satyam Sharma wrote:
On Fri, 17 Aug 2007, Nick Piggin wrote:
Satyam Sharma wrote:
It is very obvious. msleep calls schedule() (ie. sleeps), which is
always a barrier.
Probably you didn't mean that, but no, schedule() is not barrier because
it sleeps. It's a barrier because it's
David Howells wrote:
David Howells [EMAIL PROTECTED] wrote:
Yes. I found the major leak this morning. There may be a minor leak, but I'm
not convinced it's in the mmap stuff. See revised patch.
Oops. That was the old patch. Try this one instead.
Here are some changes to make it more
This is another way to compute guest time... I remove the account modifiers
mechanism and call directly account_guest_time() from account_system_time().
account_system_time() computes user, system and guest times according value
accumulated in vtime (a ktime_t) in task_struct by the virtual
On Aug 16 2007 10:21, Andy Whitcroft wrote:
+if ($line =~ /\bif\s*\([^\)]*\)\s*\;/) {
Heh, you are the second person to suggest this check today, do I detect
some ripped out hair due to one of these!
I've taken this idea and expanded it to cover if, for and while which
can all
Satyam Sharma wrote:
On Fri, 17 Aug 2007, Nick Piggin wrote:
I think they would both be equally ugly,
You think both these are equivalent in terms of looks:
|
while (!atomic_read(v)) { | while (!atomic_read_xxx(v)) {
...
On Fri, 2007-08-17 at 02:25 -0400, Chris Snook wrote:
The whole point of MAINTAINERS is to have one central repository for this
information, instead of scattering it throughout the various source files.
If
that file is getting too unwieldy (and I don't think it is) then I could
Stefan == Stefan Richter [EMAIL PROTECTED] writes:
Stefan There were some similar reports involving that status write
Stefan for unknown orb. I haven't found a way to reproduce it; I
Stefan noticed it only once in the logs here so far.
I get those all the time. Just do heavy ext3 I/O to the
On Fri, Aug 17 2007, Neil Brown wrote:
On Friday August 17, [EMAIL PROTECTED] wrote:
Please inspect the #block-2.6.24 branch to see the result.
I don't know where to look for this. I checked
http://git.kernel.org/?p=linux/kernel/git/axboe/linux-2.6-block.git
but they don't
Satyam Sharma wrote:
On Fri, 17 Aug 2007, Nick Piggin wrote:
Because they should be thinking about them in terms of barriers, over
which the compiler / CPU is not to reorder accesses or cache memory
operations, rather than special volatile accesses.
This is obviously just a taste thing.
On Fri, 17 Aug 2007, Nick Piggin wrote:
Satyam Sharma wrote:
On Fri, 17 Aug 2007, Nick Piggin wrote:
Satyam Sharma wrote:
It is very obvious. msleep calls schedule() (ie. sleeps), which is
always a barrier.
Probably you didn't mean that, but no, schedule() is not barrier
Hi all,
I've read where the onboard Marvell lan controller on
some Gigabyte boards don't work. I've got two systems
using the same Gigabyte board, on one the LAN works on
the other it dies like described by others. Here's
the systems:
Working system:
Gigabyte 965P-DS3 rev 3.3 (BIOS
On Fri, 17 Aug 2007, Nick Piggin wrote:
Satyam Sharma wrote:
[...]
You think both these are equivalent in terms of looks:
|
while (!atomic_read(v)) { | while (!atomic_read_xxx(v)) {
... |
Laurent Vivier wrote:
- remove PATCH 3, and add in task_struct a ktime vtime where we accumulate
guest time (by calling something like guest_enter() and guest_exit() from
the
virtualization engine), and when in account_system_time() we have cputime
vtime we substrate vtime from
Satyam Sharma wrote:
On Fri, 17 Aug 2007, Nick Piggin wrote:
Satyam Sharma wrote:
On Fri, 17 Aug 2007, Nick Piggin wrote:
Satyam Sharma wrote:
It is very obvious. msleep calls schedule() (ie. sleeps), which is
always a barrier.
Probably you didn't mean that, but no, schedule() is not
Laurent Vivier wrote:
KVM updates vtime in task_struct to allow account_guest_time() to modify user,
system and guest time in cpustat accordingly.
--- kvm.orig/drivers/kvm/Kconfig 2007-08-17 10:24:46.0 +0200
+++ kvm/drivers/kvm/Kconfig 2007-08-17 10:25:25.0 +0200
Avi Kivity wrote:
Laurent Vivier wrote:
- remove PATCH 3, and add in task_struct a ktime vtime where we
accumulate
guest time (by calling something like guest_enter() and guest_exit() from
the
virtualization engine), and when in account_system_time() we have cputime
vtime we
From: Rafael J. Wysocki [EMAIL PROTECTED]
During hibernation and suspend on x86_64 save CPU registers in the saved_context
structure rather than in a handful of separate variables.
Signed-off-by: Rafael J. Wysocki [EMAIL PROTECTED]
Looks-ok-to: Pavel Machek [EMAIL PROTECTED]
---
From: Rafael J. Wysocki [EMAIL PROTECTED]
pnpacpi_suspend() doesn't check the result returned by
acpi_pm_device_sleep_state() before passing it to acpi_bus_set_power(), which
may not be desirable. Make it select the target power state of the device
using its second argument if
1 - 100 of 678 matches
Mail list logo
