Re: build #337 failed for 2.6.24-rc1-gb1d08ac In function `usbnet_set_settings':

2007-11-07 Thread Adrian Bunk
On Wed, Nov 07, 2007 at 11:52:32PM +0100, Adrian Bunk wrote: > On Wed, Nov 07, 2007 at 02:34:52PM -0800, David Brownell wrote: > > > > But on the other hand, it seems that only the ASIX code will work > > > > right; the DM9601 and MCS7830 Kconfig is different/wrong. > > > > > > I'm not seeing the

Re: compat_sys_times() bogus until jiffies >= 0.

2007-11-07 Thread David Miller
From: Paul Mackerras <[EMAIL PROTECTED]> Date: Thu, 8 Nov 2007 16:15:51 +1100 > David Miller writes: > > > I can't see where x86 is doing this though, so perhaps for x86 > > glibc does make the negative value check. But I doubt it is > > checking the range 0x8000-0x, otherwise

Re: compat_sys_times() bogus until jiffies >= 0.

2007-11-07 Thread Andrew Morton
> On Thu, 8 Nov 2007 16:36:08 +1100 Paul Mackerras <[EMAIL PROTECTED]> wrote: > Andrew Morton writes: > > > Yup. But userspace will already have a fit if either the start or end time > > advanced into the glibc-thought-that-was-an-error range. > > Not nearly as much of a fit. The effect on x86

Re: [PATCH] fix incorrect test in trident_ac97_set(); sound/oss/trident.c

2007-11-07 Thread Muli Ben-Yehuda
On Wed, Nov 07, 2007 at 11:04:41AM -0800, Ray Lee wrote: > On Nov 7, 2007 10:50 AM, Roel Kluin <[EMAIL PROTECTED]> wrote: > > If count reaches zero, the loop ends, but the postfix decrement > > still subtracts: testing for 'count == 0' will not work. > > > > Signed-off-by: Roel Kluin <[EMAIL

Re: 2.6.34-rc1 eat my photo SD card :-(

2007-11-07 Thread Pierre Ossman
On Wed, 07 Nov 2007 15:37:46 -0800 Roland Dreier <[EMAIL PROTECTED]> wrote: > > mmc: Fix sg helper copy-and-paste error > > Commit 45711f1a ("[SG] Update drivers to use sg helpers") had the > following bogus change in drivers/mmc/card/queue.c: > > > - src_buf =

Re: [PATCH 1/2] Suppress A.OUT library support in ELF binfmt if !CONFIG_BINFMT_AOUT [try #3]

2007-11-07 Thread Adrian Bunk
On Wed, Nov 07, 2007 at 05:43:28PM +, David Howells wrote: > Suppress A.OUT library support in ELF binfmt if CONFIG_BINFMT_AOUT is not set. > > Not all architectures support the A.OUT binfmt, so the ELF binfmt should not > be permitted to go looking for A.OUT libraries to load in such a

2.6.24-rc2: Reported regressions from 2.6.23

2007-11-07 Thread Rafael J. Wysocki
This message contains a list of some regressions from 2.6.23 which have been reported since 2.6.24-rc1 was released and for which there are no fixes in the mainline that I know of.  If any of them have been fixed already, please let me know. If you know of any other unresolved regressions from

Re: [RFC] [PATCH 3/3] Recursive mtime for ext3

2007-11-07 Thread Theodore Tso
On Wed, Nov 07, 2007 at 03:36:05PM +0100, Jan Kara wrote: > > What if more than one application wants to use this facility? > > That should be fine - let's see: Each application keeps somewhere a time > when > it started a scan of a subtree (or it can actually remember a time when it > set the

Re: compat_sys_times() bogus until jiffies >= 0.

2007-11-07 Thread Andrew Morton
> On Wed, 7 Nov 2007 15:28:33 -0800 Andrew Morton <[EMAIL PROTECTED]> wrote: > > On Wed, 7 Nov 2007 14:47:22 -0800 David Brown <[EMAIL PROTECTED]> wrote: > > compat_sys_times() has bogus return until jiffies is >= 0. I discovered > > this running LTP within 5 minutes of booting. > > > > The

Re: [PATCH] pktcdvd: fix BUG caused by sysfs module reference semantics change

2007-11-07 Thread Jens Axboe
On Thu, Nov 08 2007, Tejun Heo wrote: > Greg KH wrote: > > On Thu, Nov 08, 2007 at 11:27:16AM +0900, Tejun Heo wrote: > >> pkt_setup_dev() expects module reference to be held on invocation. > >> This used to be true for sysfs callbacks but not anymore. Test and > >> grab module reference around

Re: [PATCH] pktcdvd: fix BUG caused by sysfs module reference semantics change

2007-11-07 Thread Tejun Heo
Greg KH wrote: > On Thu, Nov 08, 2007 at 11:27:16AM +0900, Tejun Heo wrote: >> pkt_setup_dev() expects module reference to be held on invocation. >> This used to be true for sysfs callbacks but not anymore. Test and >> grab module reference around pkt_setup_dev() in >> class_pktcdvd_store_add().

Re: build #337 failed for 2.6.24-rc1-gb1d08ac In function `usbnet_set_settings':

2007-11-07 Thread David Brownell
On Wednesday 07 November 2007, Adrian Bunk wrote: > On Wed, Nov 07, 2007 at 02:34:52PM -0800, David Brownell wrote: > > > > But on the other hand, it seems that only the ASIX code will work > > > > right; the DM9601 and MCS7830 Kconfig is different/wrong. > > > > > > I'm not seeing the problem. >

Re: [PATCH][VIRTIO] Fix vring_init() ring computations

2007-11-07 Thread Rusty Russell
On Thursday 08 November 2007 12:06:07 Anthony Liguori wrote: > Rusty Russell wrote: > > On Wednesday 07 November 2007 13:52:29 Anthony Liguori wrote: > >> This patch fixes a typo in vring_init(). > > > > Thanks, applied. > > > > I've put it in the new, experimental virtio git tree on

Re: compat_sys_times() bogus until jiffies >= 0.

2007-11-07 Thread Paul Mackerras
Andrew Morton writes: > Given all this stuff, the return value from sys_times() doesn't seem a > particularly useful or reliable kernel interface. I think the best thing would be to ignore any error from copy_to_user and always return the number of clock ticks. We should call

Re: [Bugme-new] [Bug 9319] New: National characters are not displayed under console.

2007-11-07 Thread H. Peter Anvin
This isn't a regression. It's an intentional default change. The default console mode changed from 8-bit legacy to UTF-8 in 2.6.24. Apparently this user is using a legacy character set (note that it's a Slackware machine), and isn't explicitly setting the character set via the appropriate

Re: is minimum udelay() not respected in preemptible SMP kernel-2.6.23?

2007-11-07 Thread Matt Mackall
On Thu, Nov 08, 2007 at 01:31:00AM +0100, Andi Kleen wrote: > On Thursday 08 November 2007 01:20, Matt Mackall wrote: > > On Wed, Nov 07, 2007 at 12:30:45PM -0800, Andrew Morton wrote: > > > Ow. Yes, from my reading delay_tsc() can return early (or after > > > heat-death-of-the-universe) if the

[Patch] Allocate sparse vmemmap block above 4G

2007-11-07 Thread Zou Nan hai
Resend the patch for more people to review On some single node x64 system with huge amount of physical memory e.g > 64G. the memmap size maybe very big. If the memmap is allocated from low pages, it may occupies too much memory below 4G. then swiotlb could fail to reserve bounce buffer under

Re: [PATCH] x86 - 32-bit ptrace emulation mishandles 6th arg

2007-11-07 Thread Roland McGrath
FYI, http://sourceware.org/systemtap/wiki/utrace/tests has details on the ptrace-tests suite we're collecting. A test I added there is how I noticed the PTRACE_GET_THREAD_AREA regression. A regression test for the ebp bug should be easy to add too. Thanks, Roland - To unsubscribe from this

Re: 2.6.24-rc1-gb4f5550 oops

2007-11-07 Thread Rafael J. Wysocki
On Monday, 5 of November 2007, Grant Wilson wrote: > Hi, > I got this oops on 2.6.24-rc1-641-gb4f5550: (1) Is this reproducible? (2) Did it happen previously on your system? > [18073.371126] Unable to handle kernel NULL pointer dereference at > 0120 RIP: > [18073.371134] []

Re: SC1200 failure in 2.6.23 and 2.6.24-rc1-git10

2007-11-07 Thread Denys Fedoryshchenko
I am using Gentoo (and it is custom build of linux, actually only busybox + kernel + uclibc and few other tools), hdparm is vanilla 7.7 I will try to compile now -rc2 to see if there any changes. With 16MB 2.6.24-rc1 works fine, 1GB working also with some errors in dmesg. And IF that all is

Re: compat_sys_times() bogus until jiffies >= 0.

2007-11-07 Thread David Miller
From: Andrew Morton <[EMAIL PROTECTED]> Date: Wed, 7 Nov 2007 15:28:33 -0800 > Perhaps this is a bug in glibc: it is interpreting the times() return value > in the same way as other syscalls. The problem is more likely that we are failing to invoke force_successful_syscall_return() here.

Re: [PATCH] x86 - 32-bit ptrace emulation mishandles 6th arg

2007-11-07 Thread Chuck Ebbert
On 11/07/2007 04:12 PM, Roland McGrath wrote: > Sure has my ACK. > I never really understood why my old patch was not taken 2.5 years ago. > > I forget the details, but I had to make some kind of trivial change to make it work in some corner cases. - To unsubscribe from this list: send the

Re: compat_sys_times() bogus until jiffies >= 0.

2007-11-07 Thread Andreas Schwab
Andrew Morton <[EMAIL PROTECTED]> writes: > diff -puN kernel/compat.c~a kernel/compat.c > --- a/kernel/compat.c~a > +++ a/kernel/compat.c > @@ -162,7 +162,8 @@ asmlinkage long compat_sys_times(struct > if (copy_to_user(tbuf, , sizeof(tmp))) > return -EFAULT; >

Patch]Add strict_goal parameter to __alloc_bootmem_core

2007-11-07 Thread Zou Nan hai
Resend the patch for more people to review. If __alloc_bootmem_core was given a goal, it will first try to allocate memory above that goal. If failed, it will try from the low pages. Sometimes we don't want this behavior, we want the goal to be strict. This patch introduce a strict_goal

Re: [PATCH][VIRTIO] Fix vring_init() ring computations

2007-11-07 Thread Anthony Liguori
Rusty Russell wrote: On Wednesday 07 November 2007 13:52:29 Anthony Liguori wrote: This patch fixes a typo in vring_init(). Thanks, applied. I've put it in the new, experimental virtio git tree on git.kernel.org. Hrm, perhaps you forgot to push? I don't see it in the tree

Re: Fwd: same problem with 2.6.24-rc2

2007-11-07 Thread Randy Dunlap
On Wed, 07 Nov 2007 21:32:43 -0300 (GFT) werner wrote: > On 7/Nov/2007 20:10 werner wrote .. > > With 2.6.23-rc2 is the same problem: it crashed at the beginning: EIP 060 > > c03fdea4 > > EFLAGS 00010212 EIP is at xor_sse_2+0x34/0x200 > > Again during the compilation was reclaimed that > >

Re: compat_sys_times() bogus until jiffies >= 0.

2007-11-07 Thread Andrew Morton
> On Wed, 07 Nov 2007 16:50:22 -0800 (PST) David Miller <[EMAIL PROTECTED]> > wrote: > From: Andrew Morton <[EMAIL PROTECTED]> > Date: Wed, 7 Nov 2007 15:28:33 -0800 > > > Perhaps this is a bug in glibc: it is interpreting the times() return value > > in the same way as other syscalls. > > The

Re: compat_sys_times() bogus until jiffies >= 0.

2007-11-07 Thread Andrew Morton
> On Thu, 08 Nov 2007 01:54:40 +0100 Andreas Schwab <[EMAIL PROTECTED]> wrote: > Andrew Morton <[EMAIL PROTECTED]> writes: > > > diff -puN kernel/compat.c~a kernel/compat.c > > --- a/kernel/compat.c~a > > +++ a/kernel/compat.c > > @@ -162,7 +162,8 @@ asmlinkage long compat_sys_times(struct > >

Re: build #337 failed for 2.6.24-rc1-gb1d08ac In function `usbnet_set_settings':

2007-11-07 Thread Adrian Bunk
On Wed, Nov 07, 2007 at 02:34:52PM -0800, David Brownell wrote: > > > But on the other hand, it seems that only the ASIX code will work > > > right; the DM9601 and MCS7830 Kconfig is different/wrong. > > > > I'm not seeing the problem. > > > > Which configuration will be handled wrongly? > >

Re: is minimum udelay() not respected in preemptible SMP kernel-2.6.23?

2007-11-07 Thread Andi Kleen
> But I think we'd be best off stashing a single bit somewhere and > checking it at migrate time (relatively infrequent) rather than > copying and zeroing out a potentially enormous affinity mask every > time we disable migration (often, and in fast paths). Perhaps adding > TASK_PINNED to the

Re: [poll] Is the megafreeze development model broken?

2007-11-07 Thread Adrian Bunk
On Wed, Nov 07, 2007 at 11:56:57PM +0100, ciol wrote: > Hi, I'd like to ask you a few questions: > > * Do you like the way linux distributions integrate the kernel? > > * Wouldn't you prefer they ship with the stable and still maintained > 2.6.16.X, while providing optionally the latest kernel

Re: SC1200 failure in 2.6.23 and 2.6.24-rc1-git10

2007-11-07 Thread Robert Hancock
Denys wrote: Finally i got full DMESG with 1GB card till end. Seems not readable too. .. ata1.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x2 frozen ata1.00: cmd c8/00:08:00:00:00/00:00:00:00:00/e0 tag 0 cdb 0x0 data 4096 in res 40/00:00:00:00:00/00:00:00:00:00/00 Emask 0x4

Re: Module init call vs symbols exporting race?

2007-11-07 Thread Rusty Russell
On Wednesday 07 November 2007 21:01:30 Jan Glauber wrote: > Hi Rusty, > > I've seen a symbol-resolving race on s390. The qeth module uses symbols > from qdio and although the loading order seems correct and the qdio > symbols should be available the following error appears: > > qdio: loading QDIO

[PATCH 1/2 take #2] libata: Support PIO polling-only hosts.

2007-11-07 Thread Paul Mundt
By default ata_host_activate() expects a valid IRQ in order to successfully register the host. This patch enables a special case for registering polling-only hosts that either don't have IRQs or have buggy IRQ generation (either in terms of handling or sensing), which otherwise work fine. Hosts

[PATCH] pktcdvd: fix BUG caused by sysfs module reference semantics change

2007-11-07 Thread Tejun Heo
pkt_setup_dev() expects module reference to be held on invocation. This used to be true for sysfs callbacks but not anymore. Test and grab module reference around pkt_setup_dev() in class_pktcdvd_store_add(). Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> Acked-by: Peter Osterlund <[EMAIL

Re: mm snapshot broken-out-2007-11-06-02-32 build failure - !CONFIG_PPC_ISERIES

2007-11-07 Thread Tony Breeds
On Thu, Nov 08, 2007 at 02:27:07AM +0530, Kamalesh Babulal wrote: > Hi Andrew, > > The kernel build fails with randconfig, with following error > > CC arch/powerpc/platforms/celleb/setup.o > arch/powerpc/platforms/celleb/setup.c:151: error: ‘generic_calibrate_decr’ > undeclared here (not

Re: compat_sys_times() bogus until jiffies >= 0.

2007-11-07 Thread David Brown
On Wed, Nov 07, 2007 at 03:28:33PM -0800, Andrew Morton wrote: On Wed, 7 Nov 2007 14:47:22 -0800 David Brown <[EMAIL PROTECTED]> wrote: will return '-1' to user space and set the negated clock_t value to errno. At minimum, perhaps it should return a sane errno value. RETURN VALUE

[PATCH RFC 1/7] x86: kill mk_pte_huge

2007-11-07 Thread Jeremy Fitzhardinge
It only has a single use, which can be trivially replaced. Signed-off-by: Jeremy Fitzhardinge <[EMAIL PROTECTED]> --- arch/x86/mm/init_64.c|3 +-- include/asm-x86/pgtable_64.h |9 - 2 files changed, 1 insertion(+), 11 deletions(-)

[PATCH RFC 0/7] Unify asm-x86/pgtable.h and page.h

2007-11-07 Thread Jeremy Fitzhardinge
NB: RFC ONLY. DO NOT APPLY. This series unifies many definitions in asm-x86/pgtable.h and page.h. Later in the series, I take advantage of some of the earlier infrastructure to simplify paravirt.h and bits of the Xen code. This patch applies on top of Glauber's 64-bit pvops unification, so it

Re: [PATCH] virtio config_ops refactoring

2007-11-07 Thread Anthony Liguori
Rusty Russell wrote: On Thursday 08 November 2007 04:30:50 Anthony Liguori wrote: I would prefer that the virtio API not expose a little endian standard. I'm currently converting config->get() ops to ioreadXX depending on the size which already does the endianness conversion for me so this just

Re: [kvm-devel] [PATCH 3/3] virtio PCI device

2007-11-07 Thread Avi Kivity
Anthony Liguori wrote: > This is a PCI device that implements a transport for virtio. It allows virtio > devices to be used by QEMU based VMMs like KVM or Xen. > > Didn't see support for dma. I think that with Amit's pvdma patches you can support dma-capable devices as well without too much

[PATCH 3/3] virtio PCI device

2007-11-07 Thread Anthony Liguori
This is a PCI device that implements a transport for virtio. It allows virtio devices to be used by QEMU based VMMs like KVM or Xen. Signed-off-by: Anthony Liguori <[EMAIL PROTECTED]> diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig index 9e33fc4..c81e0f3 100644 ---

Re: compat_sys_times() bogus until jiffies >= 0.

2007-11-07 Thread David Miller
From: Paul Mackerras <[EMAIL PROTECTED]> Date: Thu, 8 Nov 2007 15:59:12 +1100 > Not on powerpc. On powerpc the error indication is carried separately > in a condition register bit. So a force_successful_syscall_return() > call will make glibc automatically do the right thing without any > glibc

[PATCH] sysctl: Check length at deprecated_sysctl_warning.

2007-11-07 Thread Tetsuo Handa
Original patch assumed args->nlen < CTL_MAXNAME, but it can be false. Signed-off-by: Tetsuo Handa <[EMAIL PROTECTED]> --- linux-2.6.22-rc2.orig/kernel/sysctl.c 2007-11-08 10:38:17.0 +0900 +++ linux-2.6.22-rc2/kernel/sysctl.c2007-11-08 11:24:27.0 +0900 @@ -2609,6

Re: compat_sys_times() bogus until jiffies >= 0.

2007-11-07 Thread David Miller
From: Andrew Morton <[EMAIL PROTECTED]> Date: Wed, 7 Nov 2007 21:20:05 -0800 > Yup. But userspace will already have a fit if either the start or end time > advanced into the glibc-thought-that-was-an-error range. On x86 only. We could use force_successful_syscall_return() to make sure the

Re: compat_sys_times() bogus until jiffies >= 0.

2007-11-07 Thread Andrew Morton
> On Thu, 8 Nov 2007 12:53:57 +1100 Paul Mackerras <[EMAIL PROTECTED]> wrote: > Andrew Morton writes: > > > Given all this stuff, the return value from sys_times() doesn't seem a > > particularly useful or reliable kernel interface. > > I think the best thing would be to ignore any error from

Re: Use of virtio device IDs

2007-11-07 Thread Avi Kivity
Gregory Haskins wrote: > >> PCI means that you can reuse all of the platform's infrastructure for >> irq allocation, discovery, device hotplug, and management. >> > > Its tempting to use, yes. However, most of that infrastructure is > completely inappropriate for a PV implementation, IMHO.

Re: [kvm-devel] [PATCH 2/3] Put the virtio under the virtualization menu

2007-11-07 Thread Avi Kivity
Anthony Liguori wrote: > This patch moves virtio under the virtualization menu and changes virtio > devices to not claim to only be for lguest. > Perhaps the virt menu needs to be split into a host-side support menu and guest-side support menu. -- Do not meddle in the internals of kernels,

Re: 2.6.24-rc2 breaks nVidia MCP51 High Definition Audio

2007-11-07 Thread Takashi Iwai
At Wed, 7 Nov 2007 19:07:07 -0500 (EST), Gerhard Mack wrote: > > On Wed, 7 Nov 2007, Andrew Morton wrote: > > > Date: Wed, 7 Nov 2007 15:21:27 -0800 > > From: Andrew Morton <[EMAIL PROTECTED]> > > To: Gerhard Mack <[EMAIL PROTECTED]> > > Cc: linux-kernel@vger.kernel.org, Jaroslav Kysela <[EMAIL

Re: [PATCH 0/2] MN10300: Add the MN10300 architecture to Linux kernel [try #3]

2007-11-07 Thread Adrian Bunk
On Wed, Nov 07, 2007 at 05:43:23PM +, David Howells wrote: > > > These patches add the MEI/Panasonic MN10300/AM33 architecture to the Linux > kernel. > > The first patch suppresses AOUT support in the kernel if CONFIG_BINFMT_AOUT=n > and CONFIG_IA32_AOUT=n. MN10300 does not support the

Re: compat_sys_times() bogus until jiffies >= 0.

2007-11-07 Thread David Miller
From: Andrew Morton <[EMAIL PROTECTED]> Date: Wed, 7 Nov 2007 23:09:16 -0800 > I don't think that's a big problem? This syscall can (oddly) return any > 32-bit (64-bit) number and a smart application developer (after saying wtf) > would realise that he just can't check for errors and have

Re: LTP ustat01 test fails on NFSROOT

2007-11-07 Thread Kumar Gala
On Nov 2, 2007, at 9:28 AM, Kumar Gala wrote: On Thu, 25 Oct 2007, Trond Myklebust wrote: Could you please try the following patch? Cheers Trond Its a new month so I'll ping again about sending this fix upstream to linus for 2.6.24 :) ? - k Trond, any update on sending this to Linus

Re: [PATCH] sched: avoid large irq-latencies in smp-balancing

2007-11-07 Thread Gregory Haskins
Peter Zijlstra wrote: > Bah, missed a hunk > > --- > Subject: sched: avoid large irq-latencies in smp-balancing > > SMP balancing is done with IRQs disabled and can iterate the full rq. When rqs > are large this can cause large irq-latencies. Limit the nr of iterations on > each run. > >

Re: compat_sys_times() bogus until jiffies >= 0.

2007-11-07 Thread Paul Mackerras
Andrew Morton writes: > "the latter" is what my protopatch does isn't it? It wraps at 0x7fff. > It appears that glibc treats all of 0x8000-0x as an error. Not on powerpc. On powerpc the error indication is carried separately in a condition register bit. So a

Re: r8169: NFG in 2.6.24-rc2

2007-11-07 Thread Hans-Jürgen Koch
Am Wed, 07 Nov 2007 11:07:07 -0500 schrieb Mark Lord <[EMAIL PROTECTED]>: > My ASUS board has one of these: > > 01:00.0 Ethernet controller: Realtek Semiconductor Co., Ltd. > RTL8111/8168B PCI Express Gigabit Ethernet controller (rev 01) > Subsystem: ASUSTeK Computer Inc. Unknown device 81aa

Re: compat_sys_times() bogus until jiffies >= 0.

2007-11-07 Thread Paul Mackerras
David Miller writes: > I can't see where x86 is doing this though, so perhaps for x86 > glibc does make the negative value check. But I doubt it is > checking the range 0x8000-0x, otherwise mmap() would > be busted. At least for the INTERNAL_SYSCALL macro in glibc, the error check

<    3   4   5   6   7   8