[PATCH 1/4] arch/ia64: Drop unnecessary continue

2007-11-14 Thread Julia Lawall
From: Julia Lawall [EMAIL PROTECTED] Continue is not needed at the bottom of a loop. The semantic patch implementing this change is as follows: @@ statement S; @@ for (...;...;...) { ... if (...) - { S - continue; - } } Signed-off-by: Julia Lawall [EMAIL PROTECTED] --- diff -u -p

[PATCH 2/4] drivers/net: Drop unnecessary continue

2007-11-14 Thread Julia Lawall
From: Julia Lawall [EMAIL PROTECTED] Continue is not needed at the bottom of a loop. The semantic patch implementing this change is as follows: @@ statement S; @@ for (...;...;...) { ... if (...) - { S - continue; - } } Signed-off-by: Julia Lawall [EMAIL PROTECTED] --- diff -u -p

[PATCH 3/4] drivers/usb: Drop unnecessary continue

2007-11-14 Thread Julia Lawall
From: Julia Lawall [EMAIL PROTECTED] Continue is not needed at the bottom of a loop. The semantic patch implementing this change is as follows: @@ @@ for (...;...;...) { ... if (...) { ... - continue; } } Signed-off-by: Julia Lawall [EMAIL PROTECTED] --- diff -u -p -b -B

[PATCH 4/4] sound/pci: Drop unnecessary continue

2007-11-14 Thread Julia Lawall
From: Julia Lawall [EMAIL PROTECTED] Continue is not needed at the bottom of a loop. The semantic patch implementing this change is as follows: @@ @@ for (...;...;...) { ... if (...) { ... - continue; } } Signed-off-by: Julia Lawall [EMAIL PROTECTED] --- diff -u -p -b -B

Re: [PATCH] Align PCI memory regions to page size (4K) - Fix

2007-11-14 Thread Benjamin Herrenschmidt
On Tue, 2007-11-13 at 23:21 -0700, Grant Grundler wrote: So something like your hypervisor binds a special driver to a device that is to be reflected to a partition, at which point we are sure no other driver is using it, then that driver can call something in the pci layer that

Re: 2.6.24-rc2-mm1

2007-11-14 Thread Matthew Dharm
On Wed, Nov 14, 2007 at 06:33:39AM +0100, Gabriel C wrote: Matthew Dharm wrote: On Tue, Nov 13, 2007 at 07:49:24PM -0800, Greg KH wrote: Matt, are these the errors you were worried about with the patch we were just talking about tha tis in my tree? I can't tell from these logs.

[PATCH] HID: fix a potential bug in pointer casting

2007-11-14 Thread Li Zefan
Don't directly cast list_head * to foo *, this works only when list is the first member of struct foo, and we should not make the assumption how members are ordered in the structure. i.e. struct *f = (struct *f)pos will work if: struct foo { struct list_head list;

Re: [BUG] New Kernel Bugs

2007-11-14 Thread Russell King
On Tue, Nov 13, 2007 at 06:27:00PM -0800, Andrew Morton wrote: On Tue, 13 Nov 2007 17:55:51 -0800 (PST) David Miller [EMAIL PROTECTED] wrote: I've created [EMAIL PROTECTED] Let me just say - I'm astonished at how little spam gets though the vger lists. Considering how many times those

Re: [PATCH revised] enable make ARCH=x86 (and stay backward compatible)

2007-11-14 Thread Thomas Gleixner
Sam, On Tue, 13 Nov 2007, Sam Ravnborg wrote: Thomas - what is way forward here? I consider the patch serie ready to be applied and I leave it to you (x86 guys) to decide the way forward to mainline. cleanup - mm - linus or straight to linus. I'd like to see this merged right away, so we

Re: [patch 2.6.24-rc2 1/3] generic gpio -- gpio_chip support

2007-11-14 Thread David Brownell
On Tuesday 13 November 2007, Nick Piggin wrote: On Wednesday 14 November 2007 17:52, David Brownell wrote: On Tuesday 13 November 2007, Andrew Morton wrote: I'll highlight the point that such bitops shouldn't be preemption points. Disagree.  *everything* should be a preemption

Re: [PATCH] ipconfig.c : implement DHCP Class-identifier

2007-11-14 Thread Rainer Jochem
Corrected version below. +printk(KERN_INFO Sending class identifier \%s\\n, + vendor_class_identifier); Seems like useless noise. This information is only sent in the case that the option is actually used. And in this case it might be useful

Re: 2.6.24-rc2-mm1

2007-11-14 Thread Gabriel C
Matthew Dharm wrote: On Wed, Nov 14, 2007 at 06:33:39AM +0100, Gabriel C wrote: Matthew Dharm wrote: On Tue, Nov 13, 2007 at 07:49:24PM -0800, Greg KH wrote: Matt, are these the errors you were worried about with the patch we were just talking about tha tis in my tree? I can't tell from

Re: [PATCH 1/4] drivers/i2c: Drop redundant includes of moduleparam.h

2007-11-14 Thread Robert P. J. Day
On Wed, 14 Nov 2007, Julia Lawall wrote: From: Julia Lawall [EMAIL PROTECTED] Drop #include linux/moduleparam.h in files that also include #include linux/module.h. module.h includes moduleparam.h already. i'm not convinced that's a good idea. while module.h does currently (and

Re: [patch 3/3] arch_rebalance_pgtables call

2007-11-14 Thread Martin Schwidefsky
On Tue, 2007-11-13 at 23:33 +1100, Nick Piggin wrote: On Tuesday 13 November 2007 01:30, [EMAIL PROTECTED] wrote: From: Martin Schwidefsky [EMAIL PROTECTED] In order to change the layout of the page tables after an mmap has crossed the adress space limit of the current page table layout

Re: 2.6.24-rc2-mm1

2007-11-14 Thread Andrew Morton
On Wed, 14 Nov 2007 00:41:29 -0800 Andrew Morton [EMAIL PROTECTED] wrote: There's some kobject warning which comes out when gregkh-driver-kset-convert-block_subsys-to-use-kset_create.patch isn't applied. More bisecting coming up.. [ 11.863390] ACPI: AC Adapter [ACAD] (on-line) [

Re: [patch 2.6.24-rc2 1/3] generic gpio -- gpio_chip support

2007-11-14 Thread Nick Piggin
On Wednesday 14 November 2007 19:20, David Brownell wrote: On Tuesday 13 November 2007, Nick Piggin wrote: I mean, if you have a timing critical operation, then you should ensure you have priorities set correctly so that you simply don't get preempted. Which is why bitops like

Re: 2.6.24-rc2-mm1

2007-11-14 Thread Dave Young
On Nov 14, 2007 4:41 PM, Andrew Morton [EMAIL PROTECTED] wrote: On Wed, 14 Nov 2007 14:47:38 +0800 Dave Young [EMAIL PROTECTED] wrote: On Nov 14, 2007 2:38 PM, Andrew Morton [EMAIL PROTECTED] wrote: On Wed, 14 Nov 2007 14:18:39 +0800 Dave Young [EMAIL PROTECTED] wrote: Hi,

Re: [PATCH] Let 'make help' output info about includecheck

2007-11-14 Thread Jesper Juhl
On 14/11/2007, WANG Cong [EMAIL PROTECTED] wrote: On Mon, Nov 12, 2007 at 12:56:35AM +0100, Jesper Juhl wrote: From: Jesper Juhl [EMAIL PROTECTED] 'make includecheck' is useful and we want people to run it, so let 'make help' output information about its existence. Signed-off-by: Jesper

Re: [PATCH][RFC] kprobes: Add user entry-handler in kretprobes

2007-11-14 Thread Abhishek Sagar
On Nov 14, 2007 1:27 PM, Srinivasa Ds [EMAIL PROTECTED] wrote: 1) How do you map the entry_handler(which gets executed when a process enters the function) with each instance of return probe handler. I accept that entry_handler() will execute each time process enters the function, but to

Re: Posix file capabilities in 2.6.24rc2

2007-11-14 Thread Chris Friedhoff
Hello Serge, I wanted only to express what I observed. A yes it should confirms its ok. And yes, I haven't looked into the patches and the name and commentary of file-capabilities-clear-fcaps-on-inode-change.patch explains this already. I'm preparing to update my page

Re: 2.6.24-rc2-mm1 -- mkfs failing on variety of fs types

2007-11-14 Thread Andy Whitcroft
We seem to have some general problem with mkfs for all filesystems. I am seeing this across at least three test systems although most are unable to compile this kernel :(, even with the hotfix. Basically, all mkfs operations for any filsystem type are failing, ext2 reports this as short write,

Re: [PATCH] ipconfig.c : implement DHCP Class-identifier

2007-11-14 Thread Patrick McHardy
Rainer Jochem wrote: Corrected version below. + printk(KERN_INFO Sending class identifier \%s\\n, + vendor_class_identifier); Seems like useless noise. This information is only sent in the case that the option is actually used. And in this

Re: [patch 2.6.24-rc2 1/3] generic gpio -- gpio_chip support

2007-11-14 Thread David Brownell
On Tuesday 13 November 2007, Nick Piggin wrote: I'd be happy if, as originally presented, it were possible to just pass a raw_spinlock_t to spin_lock_irqsave() and friends. that's a spinlock type abstraction of PREEMPT_RT, not of mainline. Even when you're talking about the -rt

Re: 2.6.24-rc2-mm1

2007-11-14 Thread Andrew Morton
On Wed, 14 Nov 2007 14:47:38 +0800 Dave Young [EMAIL PROTECTED] wrote: On Nov 14, 2007 2:38 PM, Andrew Morton [EMAIL PROTECTED] wrote: On Wed, 14 Nov 2007 14:18:39 +0800 Dave Young [EMAIL PROTECTED] wrote: Hi, Boot failed on my machine. hand copy some messages. First with

Re: [patch 2.6.24-rc2 1/3] generic gpio -- gpio_chip support

2007-11-14 Thread Nick Piggin
On Wednesday 14 November 2007 19:37, David Brownell wrote: On Tuesday 13 November 2007, Nick Piggin wrote: Upstream, all spinlocks prevent preemption. I chose my wording carefully though. A preemption point is more than just a small region where preemption isn't allowed. It's one of

Re: [patch 3/3] arch_rebalance_pgtables call

2007-11-14 Thread Benjamin Herrenschmidt
On Wed, 2007-11-14 at 10:26 +0100, Martin Schwidefsky wrote: That patch allows processes to have different number of page table levels, 31 bit processes have 2 levels (2GB), normal 64 bit processes have 3 levels (4TB) and really big 64 bit processes can have 4 levels (8PB). The downgrade of a

Re: [PATCH 0/5][RFC] Physical PCI slot objects

2007-11-14 Thread Kenji Kaneshige
Matthew Wilcox : On Tue, Nov 13, 2007 at 03:33:14PM -0800, Kristen Carlson Accardi wrote: As far as being able to retrieve the slot number (which it seemed from the HP manageablity application perspective is the goal here), that information is available from userspace as well for at

Re: [patch 2.6.24-rc2 1/3] generic gpio -- gpio_chip support

2007-11-14 Thread Ingo Molnar
* David Brownell [EMAIL PROTECTED] wrote: Why do you want to use raw_spinlock_t? Already answered elsewhere in this thread ... I'll highlight the point that such bitops shouldn't be preemption points. raw_spinlock_t is a spinlock-internal implementation detail in the upstream

Re: [BUG] New Kernel Bugs

2007-11-14 Thread David Miller
From: Russell King [EMAIL PROTECTED] Date: Wed, 14 Nov 2007 09:55:07 + On Tue, Nov 13, 2007 at 05:55:51PM -0800, David Miller wrote: I've created [EMAIL PROTECTED] By doing so you've just said (implicitly) that you can not tolerate someone having a different opinion from your own. I

Re: [patch 2.6.24-rc2 1/3] generic gpio -- gpio_chip support

2007-11-14 Thread Haavard Skinnemoen
On Wed, 14 Nov 2007 00:37:57 -0800 David Brownell [EMAIL PROTECTED] wrote: Although another point is related to trivial: the data is being protected through an operation too trivial to be worth paying for any of that priority logic. But isn't there any way we can remove the lock from the

Re: [PATCH 2/2] [e1000 VLAN] Disable vlan hw accel when promiscuous mode

2007-11-14 Thread Patrick McHardy
Kok, Auke wrote: Patrick McHardy wrote: Kok, Auke wrote: Patrick McHardy wrote: I already posted a patch for this, not sure what happened to it. Auke, any news on merging the secondary unicast address support? I dropped the ball on that one. Care to resend it and send me one for e1000e as

Re: [PATCH] ipconfig.c : implement DHCP Class-identifier

2007-11-14 Thread Rainer Jochem
I don't think its very useful since you can simply get this information from /proc/cmdline in case something goes wrong, but if you insist at least give it a meaningful prefix. Added. The initialization is unnecessary. Removed. Should be = I think. Fixed. Regards, Rainer ---

Re: [PATCH] ipconfig.c : implement DHCP Class-identifier

2007-11-14 Thread Patrick McHardy
Rainer Jochem wrote: I don't think its very useful since you can simply get this information from /proc/cmdline in case something goes wrong, but if you insist at least give it a meaningful prefix. Added. The initialization is unnecessary. Removed. Should be = I think. Fixed.

Re: [BUG] New Kernel Bugs

2007-11-14 Thread Russell King
On Tue, Nov 13, 2007 at 05:55:51PM -0800, David Miller wrote: From: Andrew Morton [EMAIL PROTECTED] Date: Tue, 13 Nov 2007 14:32:01 -0800 On Tue, 13 Nov 2007 22:18:01 + Russell King [EMAIL PROTECTED] wrote: Find some other mailing list; I'm not hosting *nor* am I willing to run a

Re: 2.6.24-rc2: Network commit causes SLUB performance regression with tbench

2007-11-14 Thread Nick Piggin
On Wednesday 14 November 2007 17:37, David Miller wrote: From: Nick Piggin [EMAIL PROTECTED] I'm doing some oprofile runs now to see if I can get any more info. OK, in vanilla kernels, the page allocator definitely shows higher in the results (than with Herbert's patch reverted). 27516

Re: 2.6.24-rc2-mm1 -- mkfs failing on variety of fs types

2007-11-14 Thread Andrew Morton
On Wed, 14 Nov 2007 08:56:01 + Andy Whitcroft [EMAIL PROTECTED] wrote: We seem to have some general problem with mkfs for all filesystems. I am seeing this across at least three test systems although most are unable to compile this kernel :(, even with the hotfix. Basically, all mkfs

Re: [PATCH][RFC] kprobes: Add user entry-handler in kretprobes

2007-11-14 Thread Srinivasa Ds
Abhishek Sagar wrote: the entry handler is called with the appropriate return instance. I haven't put any explicit match test here for ri. The reason is that the correct ri would be passed to both the entry and return handlers as trampoline_handler() explicitly matches them to the correct task.

Re: [PATCH] ipconfig.c : implement DHCP Class-identifier

2007-11-14 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Wed, 14 Nov 2007 10:48:43 +0100 Rainer Jochem wrote: I don't think its very useful since you can simply get this information from /proc/cmdline in case something goes wrong, but if you insist at least give it a meaningful prefix. Added.

[PATCH] Fix the issue of fsldma driver's VIRT_TO_BUS dependence in Kconfig.

2007-11-14 Thread Zhang Wei
Remove virt_to_bus(), just using the saved phy address to match. Signed-off-by: Zhang Wei [EMAIL PROTECTED] --- drivers/dma/fsldma.c | 13 + 1 files changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c index 71e1c32..899b0c0 100644 ---

Re: [PATCH] - [12/15] - remove defconfig ptr comparisons to 0 - include/asm-x86

2007-11-14 Thread Thomas Gleixner
Joe, can you please CC the relevant maintainers on patches ? On Tue, 13 Nov 2007, Joe Perches wrote: Remove defconfig ptr comparison to 0 The memcpy from memory location 0 sure looks odd. The memcpy from 0 is completely bogus. I bet this should have been a memset(header, 0, ), which is

Re: 2.6.24-rc2: Network commit causes SLUB performance regression with tbench

2007-11-14 Thread Nick Piggin
On Wednesday 14 November 2007 09:27, Nick Piggin wrote: 2) Try removing NETIF_F_SG in drivers/net/loopback.c's dev-feastures setting. Will try that now. Doesn't help (with vanilla kernel -- Herbert's patch applied). data_len histogram drops to 0 and goes to len (I guess that's not

Re: uml doesn't work on 2.6.24-rc2

2007-11-14 Thread Miklos Szeredi
On Wed, Nov 14, 2007 at 12:32:43AM +0100, Miklos Szeredi wrote: UML doesn't run on 2.6.24-rc2 as host (config attached). Guest is 2.6.23-mm1, but I guess it's irrelevant. 2.6.23 as host was OK. When booting there are zillions of lines like this: arch_switch_tls failed, errno =

Re: [perfmon] Re: [perfmon2] perfmon2 merge news

2007-11-14 Thread Christoph Hellwig
On Wed, Nov 14, 2007 at 06:24:36PM +1100, Paul Mackerras wrote: Whose sentiment? Mine for example. The whole userspace interface is just on crack, and the code is full of complexities aswell. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to

Re: [perfmon] Re: [perfmon2] perfmon2 merge news

2007-11-14 Thread David Miller
Ok, I just got 4 freakin' bounces from all of these subscriber only perfmon etc. mailing lists. Please remove those lists from the CC: as it's pointless for those of us not on the lists to participate if those lists can't even see the feedback we are giving. - To unsubscribe from this list:

Re: Major mke2fs slowdown (reproducable, bisected)

2007-11-14 Thread Mel Gorman
On (13/11/07 16:54), Mel Gorman didst pronounce: fixes your problem As I write this, it occurs to me that it might be because your compile-job has created very long free-lists and searching them is causing problems. This indeed did appear to be the problem. When a basic compile-job was

Re: Major mke2fs slowdown (reproducable, bisected)

2007-11-14 Thread Mel Gorman
On (13/11/07 17:25), Andi Kleen didst pronounce: Alexey Dobriyan [EMAIL PROTECTED] writes: +/* Return the page with the lowest PFN in the list */ +static struct page *min_page(struct list_head *list) +{ + unsigned long min_pfn = -1UL; + struct page *min_page = NULL, *page;; +

[PATCH 0/6] A config option to compile out some namespaces code (v4)

2007-11-14 Thread Pavel Emelyanov
Change against v3: rebased on 2.6.24-rc2-mm1 There were some questions like do I need this on my cellphone in reply to different namespaces patches. Indeed, the namespaces are not useful for most of the embedded systems, but the code creating and releasing them weights a lot. So I propose to add

Problem with http access to stable git - linux-2.6.23.y

2007-11-14 Thread Richard MUSIL
I am experiencing problem when accessing 2.6.23.y stable git over http. In my config I have: [core] repositoryformatversion = 0 filemode = true bare = false logallrefupdates = true [remote origin] url =

[PATCH 1/6] Add the NAMESPACES config option

2007-11-14 Thread Pavel Emelyanov
The option is selectable if EMBEDDED is chosen only. When the EMBEDDED is off namespaces will be on. Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] --- diff --git a/init/Kconfig b/init/Kconfig index 96fba82..4ccc1a0 100644 --- a/init/Kconfig +++ b/init/Kconfig @@ -404,6 +404,15 @@ config

Re: [perfmon] Re: [perfmon2] perfmon2 merge news

2007-11-14 Thread Christoph Hellwig
On Wed, Nov 14, 2007 at 09:43:02PM +1100, Paul Mackerras wrote: Christoph Hellwig writes: Mine for example. The whole userspace interface is just on crack, and the code is full of complexities aswell. Could you give some _technical_ details of what you don't like? I've done this a

Re: 2.6.24-rc2: Network commit causes SLUB performance regression with tbench

2007-11-14 Thread David Miller
From: Nick Piggin [EMAIL PROTECTED] Date: Wed, 14 Nov 2007 09:27:39 +1100 OK, in vanilla kernels, the page allocator definitely shows higher in the results (than with Herbert's patch reverted). ... I can't see that these numbers show much useful, unfortunately. Thanks for all of this data

Re: [perfmon] Re: [perfmon2] perfmon2 merge news

2007-11-14 Thread David Miller
From: Christoph Hellwig [EMAIL PROTECTED] Date: Wed, 14 Nov 2007 11:00:09 + I've done this a gazillion times before, so maybe instead of beeing a lazy bastard you could look up mailinglist archive. It's not like this is the first discussion of perfmon. But to get start look at the

Re: [PATCH] module loader should not complain about unknown symbol

2007-11-14 Thread Jan Glauber
On Tue, 2007-11-13 at 13:52 +1100, Rusty Russell wrote: On Tuesday 13 November 2007 09:23:12 Rusty Russell wrote: Better might be to put in a waitqueue and wake it up whenever a module is deleted or changes status. Then use_module() can wait if strong_try_module_get() returns -EBUSY (up

Re: [perfmon] Re: [perfmon2] perfmon2 merge news

2007-11-14 Thread Paul Mackerras
Christoph Hellwig writes: Mine for example. The whole userspace interface is just on crack, and the code is full of complexities aswell. Could you give some _technical_ details of what you don't like? Paul. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: 2.6.24-rc2-mm1 -- mkfs failing on variety of fs types

2007-11-14 Thread Dmitry Monakhov
On 02:28 Wed 14 Nov , Andrew Morton wrote: On Wed, 14 Nov 2007 08:56:01 + Andy Whitcroft [EMAIL PROTECTED] wrote: [snip] We seem to have some general problem with mkfs for all filesystems. UUID: e9aa2dc4-dfc3-47e8-865b-693f28eac2e5 Initializing journal -

[PATCH 2/6] Move the UTS namespace under UTS_NS option

2007-11-14 Thread Pavel Emelyanov
Currently all the namespace management code is in the kernel/utsname.c file, so just compile it out and make stubs in the appropriate header. The init namespace itself is in init/version.c and is in the kernel all the time. Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] --- diff --git

[PATCH 4/6] Cleanup the code managed with the USER_NS option

2007-11-14 Thread Pavel Emelyanov
Make the user_namespace.o compilation depend on this option and move the init_user_ns into user.c file to make the kernel compile and work without the namespaces support. This make the user namespace code be organized similar to other namespaces'. Also mask the USER_NS option as depend on

Re: Strage buffer behaviour

2007-11-14 Thread Tomasz Chmielewski
Denys Vlasenko wrote: On Sunday 11 November 2007 11:33, Tino Keitel wrote: The dd command reads 100 MB from each partition two times in a row. It looks like sda1 and sda2 are not bufferd (the first 4 dd runs), but sda3 and sda4 are (the last 4 dd runs). The computer is a Mac mini with a 2,5

[PATCH 5/6] Cleanup the code managed with PID_NS option

2007-11-14 Thread Pavel Emelyanov
Just like with the user namespaces, move the namespace management code into the separate .c file and mark the (already existing) PID_NS option as depend on NAMESPACES Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] --- diff --git a/include/linux/pid.h b/include/linux/pid.h index

Re: 2.6.24-rc2: Network commit causes SLUB performance regression with tbench

2007-11-14 Thread Nick Piggin
On Wednesday 14 November 2007 22:10, David Miller wrote: From: Nick Piggin [EMAIL PROTECTED] Date: Wed, 14 Nov 2007 09:27:39 +1100 OK, in vanilla kernels, the page allocator definitely shows higher in the results (than with Herbert's patch reverted). ... I can't see that these numbers

[PATCH 6/6] Mark NET_NS with depends on NAMESPACES

2007-11-14 Thread Pavel Emelyanov
There's already an option controlling the net namespaces cloning code, so make it work the same way as all the other namespaces' options. Should I wait till the option itself gets to mainline and resend this patch to David? Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] --- diff --git

Re: [perfmon] Re: [perfmon2] perfmon2 merge news

2007-11-14 Thread Paul Mackerras
David Miller writes: This is my impression too, all of the things being done with a slew of system calls would be better served by real special files and appropriate fops. Special files and fops really only work well if you can coerce the interface into one where data flows predominantly one

Re: [perfmon] Re: [perfmon2] perfmon2 merge news

2007-11-14 Thread Paul Mackerras
Christoph Hellwig writes: int pfm_read_pmds(int fd, pfarg_pmd_t *pmds, int n) This is basically a read(2) (or for other syscalls a write) on something else than the file descriptor provided to the system call. No it's not basically a read(). It's more like a request/reply interface,

Re: [PATCH 0/5][RFC] Physical PCI slot objects

2007-11-14 Thread Kenji Kaneshige
Hi, I tried the series of patches and I encountered some problems. Since I don't have enough time to investigate them, I can only report them at present. My environment was ia64 machine with 64 hotplug slots (shpc pcie). Those slots can be handled by acpiphp too, though I have not tried it yet.

Re: 2.6.24-rc2: Network commit causes SLUB performance regression with tbench

2007-11-14 Thread Herbert Xu
On Wed, Nov 14, 2007 at 03:10:22AM -0800, David Miller wrote: So the thing that's being effected here in TCP is net/ipv4/tcp.c:select_size(), specifically the else branch: Thanks for the pointer. Indeed there is a bug in that area. I'm not sure whether it's causing the problem at hand but

2.6.24-rc2 XFS nfsd hang --- filldir change responsible?

2007-11-14 Thread Chris Wedgwood
On Tue, Nov 13, 2007 at 11:04:00PM -0800, Chris Wedgwood wrote: With 2.6.24-rc2 (amd64) I sometimes (usually but perhaps not always) see a hang when accessing some NFS exported XFS filesystems. Local access to these filesystems ahead of time works without problems. This does not occur with

Re: 2.6.24-rc2: Network commit causes SLUB performance regression with tbench

2007-11-14 Thread Nick Piggin
On Wednesday 14 November 2007 22:48, Herbert Xu wrote: On Wed, Nov 14, 2007 at 03:10:22AM -0800, David Miller wrote: So the thing that's being effected here in TCP is net/ipv4/tcp.c:select_size(), specifically the else branch: Thanks for the pointer. Indeed there is a bug in that area.

Re: [perfmon] Re: [perfmon2] perfmon2 merge news

2007-11-14 Thread David Miller
From: Nick Piggin [EMAIL PROTECTED] Date: Wed, 14 Nov 2007 10:49:48 +1100 On Wednesday 14 November 2007 22:44, Paul Mackerras wrote: David Miller writes: This is my impression too, all of the things being done with a slew of system calls would be better served by real special files

Re: [PATCH 2/2] sata_nv: fix ATAPI issues with memory over 4GB (v3)

2007-11-14 Thread Alan Cox
On Tue, 13 Nov 2007 22:15:51 -0600 Robert Hancock [EMAIL PROTECTED] wrote: This fixes some problems with ATAPI devices on nForce4 controllers in ADMA mode on systems with memory located above 4GB. We need to delay setting the 64-bit DMA mask until the PRD table and padding buffer are

Re: [perfmon] Re: [perfmon2] perfmon2 merge news

2007-11-14 Thread David Miller
From: Paul Mackerras [EMAIL PROTECTED] Date: Wed, 14 Nov 2007 23:03:24 +1100 You're suggesting that the behaviour of a read() should depend on what was in the buffer before the read? Gack! Surely you have better taste than that? Absolutely that's what I mean, it's atomic and gives you

Re: 2.6.24-rc2: Network commit causes SLUB performance regression with tbench

2007-11-14 Thread David Miller
From: Nick Piggin [EMAIL PROTECTED] Date: Wed, 14 Nov 2007 11:02:11 +1100 On Wednesday 14 November 2007 22:48, Herbert Xu wrote: On Wed, Nov 14, 2007 at 03:10:22AM -0800, David Miller wrote: So the thing that's being effected here in TCP is net/ipv4/tcp.c:select_size(), specifically the

Re: [patch 3/3] arch_rebalance_pgtables call

2007-11-14 Thread Martin Schwidefsky
On Wed, 2007-11-14 at 21:06 +1100, Benjamin Herrenschmidt wrote: On Wed, 2007-11-14 at 10:26 +0100, Martin Schwidefsky wrote: That patch allows processes to have different number of page table levels, 31 bit processes have 2 levels (2GB), normal 64 bit processes have 3 levels (4TB) and

Re: [PATCH 2/2] [e1000 VLAN] Disable vlan hw accel when promiscuous mode

2007-11-14 Thread Benny Amorsen
AK == Kok, Auke [EMAIL PROTECTED] writes: AK actually the impact can be quite negative, imagine doing a tcpdump AK on a 10gig interface with vlan's enabled - all of a sudden you AK might accidentally flood the system with a 100-fold increase in AK traffic and force the stack to dump all those

Re: [alsa-devel] [BUG] New Kernel Bugs

2007-11-14 Thread Rene Herman
On 14-11-07 11:07, David Miller wrote: Added Jaroslav and Takashi to the already extensive CC From: Russell King [EMAIL PROTECTED] So, when are you creating a replacement alsa-devel mailing list on vger? That's also subscribers-only. The operative term is alternative rather than

Re: [perfmon] Re: [perfmon2] perfmon2 merge news

2007-11-14 Thread Nick Piggin
On Wednesday 14 November 2007 22:44, Paul Mackerras wrote: David Miller writes: This is my impression too, all of the things being done with a slew of system calls would be better served by real special files and appropriate fops. Special files and fops really only work well if you can

Re: [perfmon] Re: [perfmon2] perfmon2 merge news

2007-11-14 Thread David Miller
From: Paul Mackerras [EMAIL PROTECTED] Date: Wed, 14 Nov 2007 22:44:56 +1100 For instance, if you have something that kind-of looks like read_pmds(int n, int *pmd_numbers, u64 *pmd_values); where the caller supplies an array of PMD numbers and the function returns their values (and

Re: [perfmon] Re: [perfmon2] perfmon2 merge news

2007-11-14 Thread David Miller
From: Paul Mackerras [EMAIL PROTECTED] Date: Wed, 14 Nov 2007 22:39:24 +1100 No it's not basically a read(). It's more like a request/reply interface, which a read()/write() interface doesn't handle very well. Yes it can, see my other reply. - To unsubscribe from this list: send the line

Re: [alsa-devel] [BUG] New Kernel Bugs

2007-11-14 Thread David Miller
From: Rene Herman [EMAIL PROTECTED] Date: Wed, 14 Nov 2007 12:46:24 +0100 [EMAIL PROTECTED] is not subscriber-only. Same as that arm list, it's _moderated_ for non-subscribers and given that I and other moderators have been doing our best to moderate quickly (I tend to stay logged in to

Re: Question about free/used memory on Linux

2007-11-14 Thread Pádraig Brady
Ravinandan Arakali (rarakali) wrote: Hi Vaidy, What do you think is the right way to get the memory usage of a process, I mean the actual physical memory used ? Basically, I'm interested in the incremental cost of a process, which means, I don't want to include the text segments of shared

Re: [PATCH] powerpc: Fix fs_enet module build

2007-11-14 Thread Jochen Friedrich
Hi David, This is truly ugly and creates an unnecessarily hard to maintain and complex driver. Please find a way to fix this for real, so that the PPC_CPM_NEW_BINDING ifdef is not necessary at all and things get built modular or not naturally as we handle things for other cases like this.

Re: [alsa-devel] [BUG] New Kernel Bugs

2007-11-14 Thread David Miller
From: David Miller [EMAIL PROTECTED] Date: Wed, 14 Nov 2007 03:56:57 -0800 (PST) The fact that it farts at me every time I post to this thread. See? I got another one and I have received at least 10 of the following over the past 2 days. That's rediculious. And because a human adds the

Re: [perfmon] Re: [perfmon2] perfmon2 merge news

2007-11-14 Thread Paul Mackerras
David Miller writes: The same way we handle some of the multicast getsockopt() calls. The parameters passed in are both inputs and outputs. For a read??!!! For the above example: struct pmd_info { int *pmd_numbers; u64 *pmd_values; int

Re: [PATCH] prom_find_machine_type typo breaks pSeries lpar boot

2007-11-14 Thread B. N. Poornima
Benjamin Herrenschmidt wrote: On Fri, 2005-06-03 at 14:25 -0500, Nathan Lynch wrote: Typo in prom_find_machine_type from Ben's recent patch ppc64: Fix result code handling in prom_init prevents pSeries LPAR systems from booting. Tested on a pSeries 570 and OpenPower 720 (both Power5 LPAR).

Re: Moderated list (Was: Re: [BUG] New Kernel Bugs)

2007-11-14 Thread Rene Herman
On 14-11-07 09:25, Takashi Iwai wrote: At Wed, 14 Nov 2007 04:01:31 -0800 (PST), David Miller wrote: From: David Miller [EMAIL PROTECTED] Date: Wed, 14 Nov 2007 03:56:57 -0800 (PST) The fact that it farts at me every time I post to this thread. See? I got another one and I have received at

Re: [perfmon] Re: [perfmon2] perfmon2 merge news

2007-11-14 Thread Nick Piggin
On Wednesday 14 November 2007 22:58, David Miller wrote: From: Nick Piggin [EMAIL PROTECTED] Date: Wed, 14 Nov 2007 10:49:48 +1100 On Wednesday 14 November 2007 22:44, Paul Mackerras wrote: David Miller writes: This is my impression too, all of the things being done with a slew of

[PATCH 3/6] Move the IPC namespace under IPC_NS option

2007-11-14 Thread Pavel Emelyanov
Currently the IPC namespace management code is spread over the ipc/*.c files. I moved this code into ipc/namespace.c file which is compiled out when needed. The linux/ipc_namespace.h file is used to store the prototypes of the functions in namespace.c and the stubs for NAMESPACES=n case. This is

Re: [BUG] New Kernel Bugs

2007-11-14 Thread Jiri Kosina
On Tue, 13 Nov 2007, Andrew Morton wrote: HID Kernel NULL pointer dereference at :usbhid:hiddev_ioctl+0x2f/0xabc http://bugzilla.kernel.org/show_bug.cgi?id=9216 Kernel: 2.6.23.1 Looks like this is a regression No

Re: [alsa-devel] [BUG] New Kernel Bugs

2007-11-14 Thread Rene Herman
On 14-11-07 12:56, David Miller wrote: From: Rene Herman [EMAIL PROTECTED] Date: Wed, 14 Nov 2007 12:46:24 +0100 [EMAIL PROTECTED] is not subscriber-only. Same as that arm list, it's _moderated_ for non-subscribers and given that I and other moderators have been doing our best to moderate

Re: [PATCH] ata_sg_setup_one vs ata_sg_setup?

2007-11-14 Thread Boaz Harrosh
On Wed, Nov 14 2007 at 6:40 +0200, Rusty Russell [EMAIL PROTECTED] wrote: Hi Jeff, Was looking through libata, and it seems to me that ata_sg_setup is a superset of ata_sg_setup_one. Am I missing something? Seems like it could be simplified. My machine never seems to do an

Re: [PATCH] Attempt to get eject failures back to ioctl(CDROMEJECT)

2007-11-14 Thread Jens Axboe
On Wed, Nov 14 2007, Rusty Russell wrote: Hi Jens, As you asked for some time ago. Of course, it turns out that the eject command ignores the error anyway, but it's nice that it now errors. Not entirely comfortable with this patch: there's a req-errors but that seems to have some

Re: [Pcihpd-discuss] [PATCH 2/5] Construct one fakephp slot per pci slot

2007-11-14 Thread Rolf Eike Beer
Alex Chiang wrote: Register one slot per slot, rather than one slot per function. Change the name of the slot to fake%d instead of the pci address. Signed-off-by: Alex Chiang [EMAIL PROTECTED] Signed-off-by: Matthew Wilcox [EMAIL PROTECTED] --- drivers/pci/hotplug/fakephp.c | 75

Re: [perfmon] Re: [perfmon2] perfmon2 merge news

2007-11-14 Thread Nick Piggin
On Wednesday 14 November 2007 23:07, David Miller wrote: From: Paul Mackerras [EMAIL PROTECTED] Date: Wed, 14 Nov 2007 23:03:24 +1100 You're suggesting that the behaviour of a read() should depend on what was in the buffer before the read? Gack! Surely you have better taste than that?

Re: [PATCH] Kallsyms Should Prefer Non Weak Symbols

2007-11-14 Thread Paulo Marques
Mathieu Desnoyers wrote: * Mathieu Desnoyers ([EMAIL PROTECTED]) wrote: [...] kallsyms returns the first symbol encountered, even though it is weak, when it should in fact return sys_ni_syscall. Is it a concern for anyone else out there ? Would it make sense to fix it ? I don't know if it is a

Moderated list (Was: Re: [BUG] New Kernel Bugs)

2007-11-14 Thread Takashi Iwai
At Wed, 14 Nov 2007 04:01:31 -0800 (PST), David Miller wrote: From: David Miller [EMAIL PROTECTED] Date: Wed, 14 Nov 2007 03:56:57 -0800 (PST) The fact that it farts at me every time I post to this thread. See? I got another one and I have received at least 10 of the following over

Re: libata/PATA: GPCMD_SET_STREAMING via SG_IO does nothing

2007-11-14 Thread Sebastian Kemper
On Wed, Nov 14, 2007 at 12:28:59AM +0100, Sebastian Kemper wrote: http://svn.mplayerhq.hu/mplayer/trunk/stream/stream_dvd.c?view=markup See dvd_set_speed(). The drive I'm using is an Optiarc DVD RW AD-7170A. With the old ATA driver dvd_set_speed() works, with libata it doesn't. Hello Alan,

[PATCH] 2.6.24-rc2-mm1 powerpc (iseries)- build failure - mm/stab.c

2007-11-14 Thread Kamalesh Babulal
Hi Andrew, The kernel builds fails with following error, with randconfig CC arch/powerpc/mm/stab.o arch/powerpc/mm/stab.c: In function ‘stab_initialize’: arch/powerpc/mm/stab.c:282: error: implicit declaration of function ‘HvCall1’ arch/powerpc/mm/stab.c:282: error: ‘HvCallBaseSetASR’

Re: [patch 2.6.24-rc2 1/3] generic gpio -- gpio_chip support

2007-11-14 Thread Thomas Gleixner
On Mon, 12 Nov 2007, David Brownell wrote: I'm still trying to understand what you've observed here. Is it the case that a single gpio operation went from 6.4 up to 11.2 usecs? That was a single bitbanged I2C bit transfer, with embedded udelay()s. I believe that was four gpio operations,

Re: [perfmon] Re: [perfmon2] perfmon2 merge news

2007-11-14 Thread Andi Kleen
Christoph Hellwig [EMAIL PROTECTED] writes: I've done this a gazillion times before, so maybe instead of beeing a lazy bastard you could look up mailinglist archive. It's not like this is the first discussion of perfmon. But to get start look at the systems calls, many of them are beasts

Re: 2.6.24-rc2 XFS nfsd hang

2007-11-14 Thread J. Bruce Fields
On Wed, Nov 14, 2007 at 09:43:40AM +0200, Benny Halevy wrote: I wonder if this is a similar hang to what Christian was seeing here: http://lkml.org/lkml/2007/11/13/319 Ah, thanks for noticing that. Christian Kujau, is /data an xfs partition? There are a bunch of xfs commits in

Re: Divide-by-zero in the 2.6.23 scheduler code

2007-11-14 Thread Peter Zijlstra
On Tue, 2007-11-13 at 20:14 -0500, Chuck Ebbert wrote: https://bugzilla.redhat.com/show_bug.cgi?id=340161 While I see the user has a divide by zero, I'm not understanding it. The problem code has been removed in 2.6.24. The below patch disables SCHED_FEAT_PRECISE_CPU_LOAD which causes the

  1   2   3   4   5   6   7   8   9   10   >