Regression [Was: Boot hang with stack protector on x86_64]

2008-02-22 Thread Sam Ravnborg
Hi Linus. On Fri, Feb 22, 2008 at 11:29:37AM +1100, James Morris wrote: I've been getting an immediate hang on boot since: e06b8b98da071f7dd78fb7822991694288047df0 kbuild: allow -fstack-protector to take effect This is on an x86_64 system (actually an Intel SDV -- so it might be

Remove duplicate code from sched_fair.c

2008-02-22 Thread Balbir Singh
yield_task_fair has some duplicate code, that can be replaced with rb_last(). This code reuses rb_next and removes the duplicate code. As a side effect, we don't do an rb_entry for each node as we walk along the path. Comments, flames? Description --- pick_task_entity() duplicates

Re: LSI Logic MegaRAID SATA 150-4 / LSI Logic New Generation RAID Device Drivers (MEGARAID_NEWGEN) problems (megaraid abort: scsi cmd:14600, do now own)

2008-02-22 Thread Andrew Morton
(cc's added) On Mon, 18 Feb 2008 21:09:22 -0500 David M. Strang [EMAIL PROTECTED] wrote: Greetings - A couple months back I purchased a LSI Logic MegaRAID ATA 150-4 controller, as well as 3 Seagate 500GB SATA-II hard drives to use in my system. Previously, I was using a pair of

Re: [PATCH 2.6.25-rc2 3/9] Kconfig: Improve init/Kconfig help descriptions - NAMESPACES

2008-02-22 Thread Pavel Emelyanov
Nick Andrew wrote: Rewrite the help descriptions for clarity, accuracy and consistency. Kernel config options affected: - NAMESPACES - UTS_NS - IPC_NS - USER_NS - PID_NS Signed-off-by: Nick Andrew [EMAIL PROTECTED] Acked-by: Pavel Emelyanov [EMAIL PROTECTED] but I also

Re: 2.6.25-rc2 Thinkpad T30 docking fails with oops.

2008-02-22 Thread Andrew Morton
On Tue, 19 Feb 2008 20:47:08 + Paul Martin [EMAIL PROTECTED] wrote: Now, this was working in 2.6.23, but is not in any later kernel. Previously reported, but I guess that the previous report was ignored due to the kernel being tainted. Not really. A lot of acpi-related bug reports get

Re: [PATCH sched-devel 0/7] CPU isolation extensions

2008-02-22 Thread Dmitry Adamushko
Hi Max, [ ... ] Last patch to the stop machine is potentially unsafe and is marked as experimental. Unfortunately it's currently the only option that allows dynamic module insertion/removal for above scenarios. I'm puzzled by the following part (can be a misunderstanding from my side)

Re: [PATCH 2/3] exporting capability name/code pairs (final)

2008-02-22 Thread Andrew G. Morgan
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 KaiGai, I've just tried to build this with a separate obj tree: make O=/path.../ ~ the build failed as follows: ~ CC security/dummy.o ~ CC security/inode.o ~ CAPSsecurity/cap_names.h /bin/sh: security/../scripts/mkcapnames.sh: No

Re: [LTP] [PATCH 1/8] Scaling msgmni to the amount of lowmem

2008-02-22 Thread Subrata Modak
On Fri, 2008-02-22 at 07:25 +0100, Nadia Derbey wrote: Subrata Modak wrote: Nadia Derbey wrote: Matt Helsley wrote: On Tue, 2008-02-19 at 18:16 +0100, Nadia Derbey wrote: snip +#define MAX_MSGQUEUES 16 /* MSGMNI as defined in linux/msg.h */ + It's not quite the

Re: ndiswrapper tainting

2008-02-22 Thread Romano Giannetti
On Thu, 2008-02-21 at 20:02 -0500, Pavel Roskin wrote: Hello! What are the chances that incorrect tainting of ndiswrapper will be fixed in 2.6.25? Please let's not turn it into another empty discussion. Seconded. Please. -- Sorry for the disclaimer --- ¡I cannot stop it! -- La

Re: [PATCH] macb: Fix speed setting

2008-02-22 Thread Haavard Skinnemoen
On Thu, 21 Feb 2008 17:41:05 +0100 Haavard Skinnemoen [EMAIL PROTECTED] wrote: From: Atsushi Nemoto [EMAIL PROTECTED] Fix NCFGR.SPD setting on 10Mbps. This bug was introduced by conversion to generic PHY layer in kernel 2.6.23. Signed-off-by: Atsushi Nemoto [EMAIL PROTECTED]

Re: acpi dsts loading and populate_rootfs

2008-02-22 Thread Thomas Renninger
On Fri, 2008-02-22 at 09:51 +0100, Thomas Renninger wrote: On Thu, 2008-02-21 at 19:46 +0100, Éric Piel wrote: 12/02/08 06:37, Christoph Hellwig wrote/a écrit: [skipping the populate_rootfs discussion as it seems you have a better handle on that than me] On Sun, Feb 10, 2008 at

Re: [PATCH] x86 ptrace: fix compat PTRACE_SETREGS

2008-02-22 Thread Ingo Molnar
* Roland McGrath [EMAIL PROTECTED] wrote: Simple typo fix for regression introduced by the user_regset changes. - ret = putreg(target, pos, *k++); + ret = putreg32(target, pos, *k++); - ret = putreg(target, pos, word); +

Re: Linux 2.6.24.1 - kernel does not boot; IRQ trouble?

2008-02-22 Thread Kay Sievers
On Tue, Feb 19, 2008 at 9:47 AM, Kay Sievers [EMAIL PROTECTED] wrote: On Feb 18, 2008 9:06 PM, Stephen Hemminger [EMAIL PROTECTED] wrote: On Mon, 18 Feb 2008 19:42:25 + (GMT) Chris Rankin [EMAIL PROTECTED] wrote: --- Stephen Hemminger [EMAIL PROTECTED] wrote: sysfs:

Re: [ofa-general] Re: Merging of completely unreviewed drivers

2008-02-22 Thread Adrian Bunk
On Thu, Feb 21, 2008 at 10:29:09PM -0800, Junio C Hamano wrote: Linus Torvalds [EMAIL PROTECTED] writes: So I'd be happier with warnings about deep indentation (but how do you count it? Will people then try to fake things out by using 4-space indents and then deep indentations will look

RE: [patch 1/2] x86, ptrace: support pebs in ds.c

2008-02-22 Thread Metzger, Markus T
-Original Message- From: Roland McGrath [mailto:[EMAIL PROTECTED] Sent: Donnerstag, 21. Februar 2008 22:00 Sorry I haven't replied in this thread sooner. Thanks for your comments. I hope we get this resolved quickly. For the user-level interface, we should not be hasty with cooking up

Re: acpi dsts loading and populate_rootfs

2008-02-22 Thread Thomas Renninger
On Thu, 2008-02-21 at 19:46 +0100, Éric Piel wrote: 12/02/08 06:37, Christoph Hellwig wrote/a écrit: [skipping the populate_rootfs discussion as it seems you have a better handle on that than me] On Sun, Feb 10, 2008 at 12:58:09PM +0100, Eric Piel wrote: And while we're at it the file

Re: [PATCH] ptrace: fix 2.6.25 ptrace_bts_config structure declaration

2008-02-22 Thread Ingo Molnar
* Dave Anderson [EMAIL PROTECTED] wrote: The 2.6.25 ptrace_bts_config structure in asm-x86/ptrace-abi.h is defined with u32 types: thanks, applied. Ingo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More

Re: Keyboard interrupt - request_irq()

2008-02-22 Thread Jiri Kosina
On Thu, 21 Feb 2008, Pioz wrote: I have a problem. I want handle the keyboard interrupt and for this purpose I have write this module (I have kernel 2.6.23): [ ... ] res = request_irq (1, irq_myhandler, IRQF_SHARED, bao, dev_id); [ ... ] The return value of request_irq() function

Hyperthreading performance oddities

2008-02-22 Thread belcampo
Hi all, I would like to be personally CC'ed the answers/comments posted to the list in response to my posting. I have following CPU vendor_id : GenuineIntel cpu family : 15 model : 4 model name : Intel(R) Pentium(R) 4 CPU 3.00GHz stepping: 1 cpu MHz :

Re: Regression [Was: Boot hang with stack protector on x86_64]

2008-02-22 Thread Ingo Molnar
* Sam Ravnborg [EMAIL PROTECTED] wrote: This is on an x86_64 system (actually an Intel SDV -- so it might be special). This is a regression. Can you please revert this commit. We can redo it wehn the -fstack-protector stuff are properly fixed in x86. No! James, could you please check

Re: [PATCH] Make sysctl a separate filesystem

2008-02-22 Thread Andi Kleen
Al Viro wrote: On Fri, Feb 15, 2008 at 12:35:23PM +0100, Mikael Pettersson wrote: Andi Kleen writes: Pavel Emelyanov [EMAIL PROTECTED] writes: this subdir; 3. sysctl inodes are now smaller than the procfs ones. That's always a good thing. Note: update your

Re: 2.6.25-rc1 xen pvops regression

2008-02-22 Thread Alan Cox
I'd been meaning to ask this. So the machines you have which don't describe 0xf as reserved also don't describe it as RAM? (I guess it's either a hole in the table or one of the other e820 types). Making 0xf bus addresses RAM is probably a bad idea anyway. Most OS's treat the E820 map

Re: Remove duplicate code from sched_fair.c

2008-02-22 Thread Ingo Molnar
* Balbir Singh [EMAIL PROTECTED] wrote: yield_task_fair has some duplicate code, that can be replaced with rb_last(). This code reuses rb_next and removes the duplicate code. As a side effect, we don't do an rb_entry for each node as we walk along the path. thanks, applied. Ingo

Re: Linux 2.6.24.1 - kernel does not boot; IRQ trouble?

2008-02-22 Thread Chris Rankin
--- Kay Sievers [EMAIL PROTECTED] wrote: Greg, it seems that: arch/x86/pci/legacy.c :: pci_legacy_init() tries to create already created bridge symlinks in 2.6.24. So we discover the same devices twice? Can this be a reason for the hang? No, it can't be because it's *not* hanging in this

Re: [PATCH] X86: don't print a warning when MTRR are blank and running in KVM

2008-02-22 Thread Ingo Molnar
* H. Peter Anvin [EMAIL PROTECTED] wrote: I'm not sure how we could detect pure Qemu instances - perhaps it should define some special MSR or something? Perhaps they should fix the Qemu BIOS to actually simulate working MSRs; if nothing else, they should set up the default MTRR to be

Re: acpi dsts loading and populate_rootfs

2008-02-22 Thread Andi Kleen
Which is probably a good idea. AFAIK Numa, possibly Apic tables must be available quite early. NUMA setup does not use the DSDT, but separate special tables (SRAT/SLIT). It also doesn't require the ACPI interpreter, these are all simple static tables. -Andi -- To unsubscribe from this list:

Re: ndiswrapper tainting

2008-02-22 Thread Alan Cox
On Thu, 21 Feb 2008 20:02:55 -0500 Pavel Roskin [EMAIL PROTECTED] wrote: Hello! What are the chances that incorrect tainting of ndiswrapper will be fixed in 2.6.25? I'm worried that it still hasn't happened in the mainline repository. It's unfortunate to see that a long discussion didn't

Re: [PATCH] Make sysctl a separate filesystem

2008-02-22 Thread Mikael Pettersson
Al Viro writes: On Fri, Feb 15, 2008 at 12:35:23PM +0100, Mikael Pettersson wrote: Andi Kleen writes: Pavel Emelyanov [EMAIL PROTECTED] writes: this subdir; 3. sysctl inodes are now smaller than the procfs ones. That's always a good thing. Note:

Re: [PATCH 2/3] exporting capability name/code pairs (final)

2008-02-22 Thread Li Zefan
Kohei KaiGai 写道: [2/3] Exporting capability code/name pairs This patch enables to export code/name pairs of capabilities the running kernel supported. supported or supports ? A newer kernel sometimes adds new capabilities, like CAP_MAC_ADMIN at 2.6.25. However, we have no interface to

Re: [PATCH] atmel_spi: support zero length transfer

2008-02-22 Thread Marc Pignat
Hi Dave! On Thursday 21 February 2008, David Brownell wrote: David, do you think writing 0 bytes is a valid use of this API? Just a zero byte transfer ... no, though it depends what you mean by valid. (I'm not sure I'd expect all controller drivers to reject such requests.) That has no

[PATCH] Add DECLARE_PCI_DEVICE_TABLE macro

2008-02-22 Thread Jonas Bonn
The definitions of struct pci_device_id arrays should generally follow the same pattern across the entire kernel. This macro defines this array as const and puts it into the __devinitconst section. There are currently many definitions scattered about the kernel that omit the __devinitdata

Re: [PATCH] 2.4: Back-port of pl2303.c from 2.6.24.1

2008-02-22 Thread Willy Tarreau
On Fri, Feb 22, 2008 at 12:03:50PM +1030, David Newall wrote: Greg KH wrote: On Thu, Feb 21, 2008 at 10:00:58PM +0100, Willy Tarreau wrote: I too agree to merge, it especially since it fixed several problems for David. However, I would like to know first if the same problems also

Re: 2.6.25-rc1 xen pvops regression

2008-02-22 Thread Alan Cox
Actually I switched 64bit over to trust e820 completely and not reserve 640k-1MB explicitly some time ago and AFAIK there hasn't been any reports that it causes problems. So presumably trusting e802 is ok on modern systems (2003+) Apparently so - at least 64bit capable ones. We do still

Re: GAK!!!! Re: PCI: AMD SATA IDE mode quirk

2008-02-22 Thread Alan Cox
On Fri, 22 Feb 2008 09:48:28 + Alan Cox [EMAIL PROTECTED] wrote: Signed-off-by: Crane Cai [EMAIL PROTECTED] Acked-by: Jeff Garzik [EMAIL PROTECTED] Signed-off-by: Greg Kroah-Hartman [EMAIL PROTECTED] Vomitted-upon-by: Alan Cox [EMAIL PROTECTED] - if ((pdev-class 8)

Re: 2.6.25-rc1 xen pvops regression

2008-02-22 Thread Andi Kleen
Alan Cox wrote: Actually I switched 64bit over to trust e820 completely and not reserve 640k-1MB explicitly some time ago and AFAIK there hasn't been any reports that it causes problems. So presumably trusting e802 is ok on modern systems (2003+) Apparently so - at least 64bit capable

RE: [patch 1/2] x86, ptrace: support pebs in ds.c

2008-02-22 Thread Metzger, Markus T
-Original Message- From: Ingo Molnar [mailto:[EMAIL PROTECTED] Sent: Freitag, 22. Februar 2008 10:53 To: Metzger, Markus T The ptrace API is the user interface for the debugging/BTS aspect of it. As such, it will remain stable. your last patch does this to arch/x86/kernel/ptrace.c:

Re: Merging of completely unreviewed drivers

2008-02-22 Thread Alan Cox
On Fri, 22 Feb 2008 01:05:26 +0100 Krzysztof Halasa [EMAIL PROTECTED] wrote: Jeff Garzik [EMAIL PROTECTED] writes: If a driver is full of lines of length 80, that's a problem. I'm not sure. We all have more than 80-chars wide displays for years, don't we? The Even a vt132 serial

Re: [patch 1/2] x86, ptrace: support pebs in ds.c

2008-02-22 Thread Ingo Molnar
* Metzger, Markus T [EMAIL PROTECTED] wrote: The ptrace API is the user interface for the debugging/BTS aspect of it. As such, it will remain stable. your last patch does this to arch/x86/kernel/ptrace.c: 266 insertions(+), 174 deletions(-) doesnt that change the ptrace bits and the

Re: [PATCH] X86: don't print a warning when MTRR are blank and running in KVM

2008-02-22 Thread Ingo Molnar
* H. Peter Anvin [EMAIL PROTECTED] wrote: Ingo Molnar wrote: * H. Peter Anvin [EMAIL PROTECTED] wrote: I'm not sure how we could detect pure Qemu instances - perhaps it should define some special MSR or something? Perhaps they should fix the Qemu BIOS to actually simulate working MSRs;

GAK!!!! Re: PCI: AMD SATA IDE mode quirk

2008-02-22 Thread Alan Cox
Signed-off-by: Crane Cai [EMAIL PROTECTED] Acked-by: Jeff Garzik [EMAIL PROTECTED] Signed-off-by: Greg Kroah-Hartman [EMAIL PROTECTED] Vomitted-upon-by: Alan Cox [EMAIL PROTECTED] - if ((pdev-class 8) == PCI_CLASS_STORAGE_IDE) { - u8 tmp; + /* set

Re: 2.6.25-rc1 xen pvops regression

2008-02-22 Thread Andi Kleen
Alan Cox wrote: I'd been meaning to ask this. So the machines you have which don't describe 0xf as reserved also don't describe it as RAM? (I guess it's either a hole in the table or one of the other e820 types). Making 0xf bus addresses RAM is probably a bad idea anyway. Most OS's

Re: tty pid problems

2008-02-22 Thread Alan Cox
I've added locks in my test tree and now I've finally got -mm to build will do some testing then push more stuff upstream Thanks. At the tty layer that was probably me. Most of the instances already appear to be nested in some other kind of locking, but that doesn't make no additional

Re: [PATCH] X86: don't print a warning when MTRR are blank and running in KVM

2008-02-22 Thread H. Peter Anvin
Ingo Molnar wrote: * H. Peter Anvin [EMAIL PROTECTED] wrote: I'm not sure how we could detect pure Qemu instances - perhaps it should define some special MSR or something? Perhaps they should fix the Qemu BIOS to actually simulate working MSRs; if nothing else, they should set up the default

Re: [PATCH 2/3] exporting capability name/code pairs (final)

2008-02-22 Thread Kohei KaiGai
Andrew G. Morgan wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 KaiGai, I've just tried to build this with a separate obj tree: make O=/path.../ ~ the build failed as follows: ~ CC security/dummy.o ~ CC security/inode.o ~ CAPSsecurity/cap_names.h /bin/sh:

Re: [PATCH] X86: don't print a warning when MTRR are blank and running in KVM

2008-02-22 Thread H. Peter Anvin
Ingo Molnar wrote: * H. Peter Anvin [EMAIL PROTECTED] wrote: Ingo Molnar wrote: * H. Peter Anvin [EMAIL PROTECTED] wrote: I'm not sure how we could detect pure Qemu instances - perhaps it should define some special MSR or something? Perhaps they should fix the Qemu BIOS to actually simulate

Re: New 2.6.24.2 SG_IO SCSI problems

2008-02-22 Thread Mark Hounschell
Mark Hounschell wrote: James Bottomley wrote: On Thu, 2008-02-21 at 10:15 -0500, Mark Hounschell wrote: I seem to have run into some sort of regression in the SG_IO interface of 2.6.24.2. I have an application that up until 2.6.24 worked fine. The 2.6.23.16 kernel works fine. During

Re: [PATCH 2/2] make work have a static address in do_boot_cpu()

2008-02-22 Thread Ingo Molnar
* Glauber Costa [EMAIL PROTECTED] wrote: Looks way overkill. Doesn't something like: struct create_idle create_idle = { - .work = __WORK_INITIALIZER(create_idle.work, do_fork_idle), .cpu = cpu, .done =

Re: [PATCH] Document huge memory/cache overhead of memory controller in Kconfig

2008-02-22 Thread Andi Kleen
Balbir Singh wrote: Andi Kleen wrote: 1. We could create something similar to mem_map, we would need to handle 4 4? At least x86 mainline only has two ways now. flatmem and vmemmap. different ways of creating mem_map. Well it would be only a single way to create the aux memory controller

Re: Hyperthreading performance oddities

2008-02-22 Thread Frederik Deweerdt
Hello Henk, On Fri, Feb 22, 2008 at 10:36:01AM +0100, belcampo wrote: Kernel 2.6.22.9 smp hyperthreading BENCHMARKs: VC: 334.042s VO: 0.053s A: 0.000s Sys: 4.049s = 338.143s Kernel 2.6.22.9 nonsmp/hyperthreading BENCHMARKs: VC: 262.008s VO: 0.031s A: 0.000s Sys: 3.528s =

Re: GAK!!!! Re: PCI: AMD SATA IDE mode quirk

2008-02-22 Thread Jiri Slaby
On 02/22/2008 11:02 AM, Alan Cox wrote: On Fri, 22 Feb 2008 09:48:28 + Alan Cox [EMAIL PROTECTED] wrote: Signed-off-by: Crane Cai [EMAIL PROTECTED] Acked-by: Jeff Garzik [EMAIL PROTECTED] Signed-off-by: Greg Kroah-Hartman [EMAIL PROTECTED] Vomitted-upon-by: Alan Cox [EMAIL

Re: Regression [Was: Boot hang with stack protector on x86_64]

2008-02-22 Thread James Morris
On Fri, 22 Feb 2008, Ingo Molnar wrote: * Sam Ravnborg [EMAIL PROTECTED] wrote: This is on an x86_64 system (actually an Intel SDV -- so it might be special). This is a regression. Can you please revert this commit. We can redo it wehn the -fstack-protector stuff are properly

Re: arch/x86/kernel/vsyscall_64.c: overeager NOP of syscalls

2008-02-22 Thread Arne Georg Gleditsch
Andi Kleen [EMAIL PROTECTED] writes: On Wed, Feb 20, 2008 at 02:57:34PM +0100, Arne Georg Gleditsch wrote: Hi, I'm looking at 2.6.25-rc2. vsyscall_sysctl_change contains code to NOP out the actual system call instructions of the vsyscall page when vsyscall64 is enabled. This seems to

bcm43xx regression in 2.6.24 (with patch)

2008-02-22 Thread Alexey Zaytsev
Hello. The bcm43xx driver won't work any more, if the b44 Ethernet driver is enabled. This happens because the b44 driver needlessly enables the b43_pci_bridge code, which claims the same pci ids as the bcm43xx driver. The b43_pci_bridge code is needed for the b43{legacy} drivers, but for the

Re: [Suspend-devel] 2.6.25-rc2 System no longer powers off aftersuspend-to-disk. Screen becomes green.

2008-02-22 Thread Matthew Garrett
On Fri, Feb 22, 2008 at 08:42:15AM +0800, Jeff Chua wrote: On Fri, Feb 22, 2008 at 8:23 AM, Jesse Barnes [EMAIL PROTECTED] wrote: Your system (either your distro suspend/resume scripts or your platform) must be running the video BIOS at resume time, otherwise it would probably come

Re: usb/serial/io_ti.c: inconsequent NULL checking

2008-02-22 Thread Alan Cox
Either the test of port-tty here is unneeded: if (port-tty) port-tty-low_latency = low_latency; ...or the lack of test of port-tty here is a mistake: edge_set_termios (port, port-tty-termios); Interesting - so coverity doesn't understand the BKL. It's producing

Re: [PATCH 03/10] PCI: AMD SATA IDE mode quirk

2008-02-22 Thread Matthew Wilcox
On Fri, Feb 22, 2008 at 01:49:20PM +0800, Cai, Crane wrote: On Thu, Feb 21, 2008 at 03:47:33PM -0800, Greg Kroah-Hartman wrote: +static void __devinit quirk_amd_ide_mode(struct pci_dev *pdev) { - /* set sb600 sata to ahci mode */ - if ((pdev-class 8) == PCI_CLASS_STORAGE_IDE) {

Re: lockdep warning

2008-02-22 Thread Jiri Kosina
On Fri, 22 Feb 2008, Anders Eriksson wrote: I found this is a newly booted 2.6.25-rc2's syslog. Feb 21 20:46:33 tippex BUG: rwlock wrong owner on CPU#0, runscript.sh/2633, d2c04084 Feb 21 20:46:33 tippex Pid: 2633, comm: runscript.sh Not tainted 2.6.25-rc2 #3 Feb 21 20:46:33 tippex

Re: [PATCH] X86: don't print a warning when MTRR are blank and running in KVM

2008-02-22 Thread Joerg Roedel
On Fri, Feb 22, 2008 at 11:00:44AM +0100, Ingo Molnar wrote: * H. Peter Anvin [EMAIL PROTECTED] wrote: Ingo Molnar wrote: * H. Peter Anvin [EMAIL PROTECTED] wrote: I'm not sure how we could detect pure Qemu instances - perhaps it should define some special MSR or something?

Re: [PATCHv4 2.6.25] i2c: adds support for i2c bus on Freescale CPM1/CPM2 controllers

2008-02-22 Thread Jochen Friedrich
Hi Jean, +/* + * Wait for patch from Jon Smirl + * #include powerpc-common.h + */ It doesn't make sense to merge this comment upstream. I know you don't like the patch from Jon Smirl and you also explained your reasons. Fortunately, I2c no longer uses numeric device IDs but names. So

lockdep warning

2008-02-22 Thread Anders Eriksson
I found this is a newly booted 2.6.25-rc2's syslog. Feb 21 20:46:33 tippex BUG: rwlock wrong owner on CPU#0, runscript.sh/2633, d2c04084 Feb 21 20:46:33 tippex Pid: 2633, comm: runscript.sh Not tainted 2.6.25-rc2 #3 Feb 21 20:46:33 tippex [c02342d0] rwlock_bug+0x50/0x60 Feb 21 20:46:33 tippex

Re: [PATCH] X86: don't print a warning when MTRR are blank and running in KVM

2008-02-22 Thread Joerg Roedel
On Thu, Feb 21, 2008 at 11:54:00AM -0800, Yinghai Lu wrote: On Thu, Feb 21, 2008 at 6:50 AM, Joerg Roedel [EMAIL PROTECTED] wrote: Inside a KVM virtual machine the MTRRs are usually blank. This confuses Linux and causes a warning message at boot. This patch removes that warning message

[PATCH] let XEN depend on PAE

2008-02-22 Thread Arnd Hannemann
Hi, As paravirtualized xen guests won't work with !X86_PAE, change the Kconfig accordingly. Signed-off-by: Arnd Hannemann [EMAIL PROTECTED] diff --git a/arch/x86/xen/Kconfig b/arch/x86/xen/Kconfig index 4d5f264..2035238 100644 --- a/arch/x86/xen/Kconfig +++ b/arch/x86/xen/Kconfig @@ -6,7 +6,7

Re: Kernel oops with bluetooth usb dongle

2008-02-22 Thread David Woodhouse
On Fri, 2008-02-22 at 08:23 +0100, Thomas Gleixner wrote: + del_timer(conn-info_timer); + hcon-l2cap_data = NULL; kfree(conn); Shouldn't that be del_timer_sync() ? -- dwmw2 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a

Re: Kernel oops with bluetooth usb dongle

2008-02-22 Thread Thomas Gleixner
On Fri, 22 Feb 2008, David Woodhouse wrote: On Fri, 2008-02-22 at 08:23 +0100, Thomas Gleixner wrote: + del_timer(conn-info_timer); + hcon-l2cap_data = NULL; kfree(conn); Shouldn't that be del_timer_sync() ? Hmm, probably yes. tglx -- To unsubscribe

Re: [PATCH sched-devel 0/7] CPU isolation extensions

2008-02-22 Thread Peter Zijlstra
On Thu, 2008-02-21 at 18:38 -0800, Max Krasnyanskiy wrote: As you suggested I'm sending CPU isolation patches for review/inclusion into sched-devel tree. They are against 2.6.25-rc2. You can also pull them from my GIT tree at

Re: Module loading/unloading and The Stop Machine

2008-02-22 Thread Andi Kleen
Max Krasnyanskiy [EMAIL PROTECTED] writes: static struct module *load_module(void __user *umod, unsigned long len, const char __user *uargs) { ... /* Now sew it into the lists so we can get lockdep and oops

Re: [RFC] [PATCH] Fix b43 driver build for arm

2008-02-22 Thread Gordon Farquharson
On Thu, Feb 21, 2008 at 9:24 PM, Gordon Farquharson [EMAIL PROTECTED] wrote: Hi Sam On Wed, Feb 20, 2008 at 12:37 PM, Sam Ravnborg [EMAIL PROTECTED] wrote: Option 1) is the worst of the three as that can cost of many hours bug-hunting. Option 3) may seem optimal but I do not like

Re: distributed module configuration

2008-02-22 Thread Pavel Machek
Hi! Does this fit what you had in mind? Yes it does. Now I'll ask if you think embedding this information in one of the C files for a module would be even nicer? I kind of like to be able to grep over just Kconfig files, to find out what is going on... -- (english)

Re: [Suspend-devel] 2.6.25-rc2 System no longer powers off after suspend-to-disk. Screen becomes green.

2008-02-22 Thread Pavel Machek
Hi! It's snapshot-and-restore, and my opinion is that: - it should *never* call suspend()/resume() at all (that should be reserved purely for suspend-to-RAM and has real power management issues!) Hmm, entering S4 seems like good place to call suspend() for... unless you want

[PATCH] tags: add menuconfig symbols as well

2008-02-22 Thread Alexey Dobriyan
Steps to reproduce: vi -t NETFILTER Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED] --- Makefile |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/Makefile +++ b/Makefile @@ -1396,7 +1396,7 @@ define xtags $(all-kconfigs) | xargs $1 -a \

Re: Plans for mISDN? Was: [PATCH 00/14] [ISDN] ...

2008-02-22 Thread Karsten Keil
Hi, sorry that I step in so late, procmail sorted this thread in the wrong box. Normally I reserved the complete last week for working on mISDN to get it ready to submit it to -mm, but reality did hit me and I had to do some other importent stuff :-( On Thu, Feb 21, 2008 at 11:33:04AM +0100,

Re: [PATCH] x86_64: make amd quad core 8 socket system not be clustered_box

2008-02-22 Thread Andi Kleen
Yinghai Lu [EMAIL PROTECTED] writes: quad core 8 socket system will have apic id lifting.the apic id range could be [4, 0x23]. or [8, 0x27]. apic_is_clustered_box will think that need to three clusters and that is large than 2. So it is treated as clustered_box. and will get Marking TSC

Re: [PATCH 09/16] um: use get_personality()

2008-02-22 Thread WANG Cong
From: Jeff Dike [EMAIL PROTECTED] Subject: Re: [PATCH 09/16] um: use get_personality() Date: Wed, 20 Feb 2008 11:27:34 -0500 Message-ID: [EMAIL PROTECTED] On Wed, Feb 20, 2008 at 07:19:13PM +0800, WANG Cong wrote: Signed-off-by: WANG Cong [EMAIL PROTECTED] Looks good - you should add some

[PATCH 1/3] Consolidate checks for whether or not to ignore a signal

2008-02-22 Thread Pavel Emelyanov
Both sig_ignored() and do_sigactoin() check for signr to be explicitly or implicitly ignored. Introduce a helper for them. This patch is aimed to help handling signals by pid namespace's init, and was derived from one of Oleg's patches

Re: [PATCH] X86: don't print a warning when MTRR are blank and running in KVM

2008-02-22 Thread Ingo Molnar
* Joerg Roedel [EMAIL PROTECTED] wrote: ok. Then i guess we should just leave the warning and the backtrace in place until they get a fix done? No. I don't agree. The MTRRs are set up by the BIOS because it knows the hardware best (I know this is only true in theory). The OS should

Re: 2.6.25-rc[1,2]: failed to setup dm-crypt key mapping

2008-02-22 Thread Herbert Xu
On Thu, Feb 21, 2008 at 01:58:19AM +0800, Herbert Xu wrote: On Wed, Feb 20, 2008 at 06:47:58PM +0100, Milan Broz wrote: I just tested one affected configuration and problem was in missing chainiv.ko module on ramdisk. Ah OK. We probably should merge chainiv into the blkcipher module

Re: Regression [Was: Boot hang with stack protector on x86_64]

2008-02-22 Thread Ingo Molnar
* James Morris [EMAIL PROTECTED] wrote: works fine for you? That has all the current stackprotector fixes. I plan to send a separate pull request with just the stackprotector fixes to Linus, they are looking good in testing so far. Nope, same problem. (I followed your instructions

Re: [ofa-general] Re: Merging of completely unreviewed drivers

2008-02-22 Thread Bart Van Assche
On Fri, Feb 22, 2008 at 2:46 AM, David Newall [EMAIL PROTECTED] wrote: Krzysztof Halasa wrote: Perhaps we should increase line length limit, 132 should be fine. Especially useful with long printk() lines and long arithmetic expressions. Yes; or even longer. 80 characters might have

Re: [PATCH] Document huge memory/cache overhead of memory controller in Kconfig

2008-02-22 Thread Balbir Singh
Andi Kleen wrote: Balbir Singh wrote: Andi Kleen wrote: 1. We could create something similar to mem_map, we would need to handle 4 4? At least x86 mainline only has two ways now. flatmem and vmemmap. different ways of creating mem_map. Well it would be only a single way to create the aux

Re: [PATCH] xen: Implement getgeo for Xen virtual block device.

2008-02-22 Thread Andi Kleen
Linus Torvalds [EMAIL PROTECTED] writes: (*) I keed, I keed. Of *course* I'll have to fix things like this in the future too. But hopefully not quite as often. The pragmatic solution would be to just fix the scripts to accept From everywhere @) -Andi -- To unsubscribe from this list: send

Re: [PATCH 00/37] Permit filesystem local caching

2008-02-22 Thread David Howells
Daniel Phillips [EMAIL PROTECTED] wrote: The way the client works is like this: Thanks for the excellent ascii art, that cleared up the confusion right away. You know what they say about pictures... :-) What are you trying to do exactly? Are you actually playing with it, or just

[PATCH 2/3] Clean dequeue_signal from excess checks and assignments

2008-02-22 Thread Pavel Emelyanov
The signr variable may be declared without initialization - it is set ro the return value from __dequeue_signal() right at the function beginning. Besides, after recalc_sigpending() two checks for signr to be not 0 may be merged into one. Both if-s become easier to read. Thanks to Oleg for

Re: arch/x86/kernel/vsyscall_64.c: overeager NOP of syscalls

2008-02-22 Thread Andi Kleen
On Thu, Feb 21, 2008 at 09:59:24PM +0100, Thomas Gleixner wrote: On Thu, 21 Feb 2008, Thomas Gleixner wrote: That or we need to do the NOP/un-NOP part in the update_vsyscall code dependent on if the current clocksource supports vread, instead of on the /proc entry access. That won't

Re: [PATCH] Document huge memory/cache overhead of memory controller in Kconfig

2008-02-22 Thread Andi Kleen
On Fri, Feb 22, 2008 at 05:44:47PM +0530, Balbir Singh wrote: My concern with all the points you mentioned is that this solution might need to change again, No why would it need to change again? depending on the factors you've mentioned. vmalloc() is good and straightforward, but it has

Re: Regression [Was: Boot hang with stack protector on x86_64]

2008-02-22 Thread James Morris
On Fri, 22 Feb 2008, Ingo Molnar wrote: * James Morris [EMAIL PROTECTED] wrote: works fine for you? That has all the current stackprotector fixes. I plan to send a separate pull request with just the stackprotector fixes to Linus, they are looking good in testing so far.

Re: [Suspend-devel] 2.6.25-rc2 System no longer powers off aftersuspend-to-disk. Screen becomes green.

2008-02-22 Thread Ingo Molnar
* Matthew Garrett [EMAIL PROTECTED] wrote: The s2ram command has a built-in whitelist used to set up video rePOSTing. If you want to test, reboot and do echo mem /sys/power/state without i915 being loaded. If you get a console back on resume then the platform is reinitialising video

Re: [PATCH 09/37] Security: Allow kernel services to override LSM settings for task actions

2008-02-22 Thread David Howells
Casey Schaufler [EMAIL PROTECTED] wrote: +static int smack_task_kernel_act_as(struct task_struct *p, + struct task_security *sec, u32 secid) +{ + return -ENOTSUPP; +} ... +static int smack_task_create_files_as(struct task_struct *p, +

Re: [RFC] [PATCH] Fix b43 driver build for arm

2008-02-22 Thread Matthieu CASTET
Sam Ravnborg sam at ravnborg.org writes: In at least 99% of the cases this is OK and the check has found several bugs where things would not have worked due to different alignmnet between kernel and userland. Just think about the issues in a mixed 32/64 bit world. I don't see how this

Re: arch/x86/kernel/vsyscall_64.c: overeager NOP of syscalls

2008-02-22 Thread Andi Kleen
On Thu, Feb 21, 2008 at 08:45:53PM +0100, Thomas Gleixner wrote: On Thu, 21 Feb 2008, Andi Kleen wrote: On Wed, Feb 20, 2008 at 02:57:34PM +0100, Arne Georg Gleditsch wrote: Hi, I'm looking at 2.6.25-rc2. vsyscall_sysctl_change contains code to NOP out the actual system call

Re: lockdep warning

2008-02-22 Thread Anders Eriksson
[EMAIL PROTECTED] said: This needs to be CCed to netdev. Any chance that git revert 69cc64d8d92 makes this report go away? I'll have to install a git repo to check, or maybe you can send me the diff to reverse vs. 2.6.25-rc2? -- To unsubscribe from this list: send the line

[PATCH 3/3] Consolidate send_sigqueue and send_group_sigqueue

2008-02-22 Thread Pavel Emelyanov
Both function do the same thing after proper locking, but with different sigpening structs, so move the common code into a helper. After this we have 4 places that look very similar: send_sigqueue: calls do_send_sigqueue and signal_wakeup send_group_sigqueue: calls do_send_sigqueue and

[RFC/PATCH] Update coding standard to avoid ungrepable printk format strings

2008-02-22 Thread Andi Kleen
RFC: Update coding standard to avoid split up printk format strings Common occurrence: You see some error message in the kernel log you don't understand, Standard way to handle this is to grep the kernel source code for that error message and then look at the code and figure out what is wrong

Re: [PATCH [RT] 05/14] rearrange rt_spin_lock sleep

2008-02-22 Thread Steven Rostedt
On Fri, 22 Feb 2008, Gregory Haskins wrote: Gregory Haskins wrote: @@ -732,14 +741,15 @@ rt_spin_lock_slowlock(struct rt_mutex *lock) debug_rt_mutex_print_deadlock(waiter); - schedule_rt_mutex(lock); + update_current(TASK_UNINTERRUPTIBLE,

Re: [PATCH [RT] 05/14] rearrange rt_spin_lock sleep

2008-02-22 Thread Ingo Molnar
* Gregory Haskins [EMAIL PROTECTED] wrote: My assumption is that the xchg() (inside update_current()) acts as an effective wmb(). If xchg() does not have this property, then this code is broken and patch 6/14 should also add a: xchg() is a strong implicit memory barrier, it implies

Re: [PATCH] let XEN depend on PAE

2008-02-22 Thread Ian Campbell
On Fri, 2008-02-22 at 12:00 +0100, Arnd Hannemann wrote: As paravirtualized xen guests won't work with !X86_PAE, change the Kconfig accordingly. Really? Xen guests should work on non-PAE if you have a non-PAE hypervisor (which most distros don't ship but which does exist). Ian. -- Ian

Re: [PATCH sched-devel 0/7] CPU isolation extensions

2008-02-22 Thread Mark Hounschell
Peter Zijlstra wrote: On Thu, 2008-02-21 at 18:38 -0800, Max Krasnyanskiy wrote: As you suggested I'm sending CPU isolation patches for review/inclusion into sched-devel tree. They are against 2.6.25-rc2. You can also pull them from my GIT tree at

Re: [PATCH [RT] 05/14] rearrange rt_spin_lock sleep

2008-02-22 Thread Peter Zijlstra
On Fri, 2008-02-22 at 08:35 -0500, Steven Rostedt wrote: My assumption is that the xchg() (inside update_current()) acts as an effective wmb(). If xchg() does not have this property, then this code is broken and patch 6/14 should also add a: + smp_wmb(); I believe

Re: [PATCH [RT] 05/14] rearrange rt_spin_lock sleep

2008-02-22 Thread Steven Rostedt
On Fri, 22 Feb 2008, Ingo Molnar wrote: * Gregory Haskins [EMAIL PROTECTED] wrote: My assumption is that the xchg() (inside update_current()) acts as an effective wmb(). If xchg() does not have this property, then this code is broken and patch 6/14 should also add a: xchg() is a

Re: [PATCH [RT] 05/14] rearrange rt_spin_lock sleep

2008-02-22 Thread Steven Rostedt
Gregory, I guess we should have just read Documentation/memory-barriers.text Here's the snippet: Any atomic operation that modifies some state in memory and returns information about the state (old or new) implies an SMP-conditional general memory barrier (smp_mb()) on each side of the actual

Re: [PATCH [RT] 05/14] rearrange rt_spin_lock sleep

2008-02-22 Thread Gregory Haskins
Gregory Haskins wrote: @@ -732,14 +741,15 @@ rt_spin_lock_slowlock(struct rt_mutex *lock) debug_rt_mutex_print_deadlock(waiter); - schedule_rt_mutex(lock); + update_current(TASK_UNINTERRUPTIBLE, saved_state); I have a question for everyone out there about this particular

  1   2   3   4   5   6   7   8   9   10   >