Re: [PATCH] act_mirred: do not drop packets when fails to mirror it

2012-08-15 Thread Jason Wang
On 08/15/2012 08:35 PM, Jamal Hadi Salim wrote: On Wed, 2012-08-15 at 17:37 +0800, Jason Wang wrote: We drop packet unconditionally when we fail to mirror it. This is not intended in some cases. Hi Jason, Did you actually notice the behavior you described or were you going by the XXX comment I

Re: [PATCH 02/16] user_ns: use new hashtable implementation

2012-08-15 Thread Sasha Levin
On 08/15/2012 05:31 AM, Mathieu Desnoyers wrote: > * Eric W. Biederman (ebied...@xmission.com) wrote: >> Sasha Levin writes: >> >>> On 08/15/2012 03:08 AM, Eric W. Biederman wrote: > I can offer the following: I'll write a small module that will hash > 1...1 >> into a hashtable

Re: [PATCH v2 04/31] arm64: MMU definitions

2012-08-15 Thread Catalin Marinas
Hi Arnd, On Wed, Aug 15, 2012 at 02:30:01PM +0100, Arnd Bergmann wrote: > On Tuesday 14 August 2012, Catalin Marinas wrote: > > +/* > > + * TCR flags. > > + */ > > +#define TCR_TxSZ(x)(((64 - (x)) << 16) | ((64 - (x)) << 0)) > > +#define TCR_IRGN_NC((0 << 8) | (0

Re: [PATCH v2 07/11] mm: Allocate kernel pages to the right memcg

2012-08-15 Thread Glauber Costa
>> >> As for the type, do you think using struct mem_cgroup would be less >> confusing? >> > > Yes and returning the mem_cgroup or NULL instead of bool. Ok. struct mem_cgroup it is. > >> The placeholder is there, but it is later patched >> to the final thing. >> With that explained, if you

Re: [PATCH 1/2] debugfs: Allow debugfs_create_dir() to take data

2012-08-15 Thread Greg Kroah-Hartman
On Wed, Aug 15, 2012 at 08:40:08AM +0300, Hiroshi Doyu wrote: > On Thu, 9 Aug 2012 14:56:24 +0200 > Hiroshi Doyu wrote: > > > Hi Greg, Felipe, > > > > On Wed, 8 Aug 2012 15:34:27 +0200 > > Greg Kroah-Hartman wrote: > > > > > On Wed, Aug 08, 2012 at 09:24:32AM +0300, Hiroshi Doyu wrote: > > >

Re: [PATCH] select GENERIC_ATOMIC64 for c6x/score/unicore32 archs

2012-08-15 Thread Mark Salter
On Wed, 2012-08-15 at 10:36 +0800, Fengguang Wu wrote: > > -#define L1_CACHE_BYTESL2_CACHE_BYTES > > +#define L1_CACHE_SHIFTL2_CACHE_SHIFT > > +#define L1_CACHE_BYTES(1 << L2_CACHE_SHIFT) > > Nitpick: the last line could better be: > > +#define L1_CACHE_BYTES(1 <<

Re: [discussion]sched: a rough proposal to enable power saving in scheduler

2012-08-15 Thread Arjan van de Ven
On 8/15/2012 4:05 AM, Peter Zijlstra wrote: > Yay, ideally we'd also provide a 3rd option: auto, which simply switches > between the two based on AC/BAT, UPS nooo! anything but this. if anyone thinks that AC/Battery matters for power sensitivity... they need to go talk to a datacenter

Re: [PATCH v2 05/31] arm64: MMU initialisation

2012-08-15 Thread Arnd Bergmann
On Tuesday 14 August 2012, Catalin Marinas wrote: > This patch contains the initialisation of the memory blocks, MMU > attributes and the memory map. Only five memory types are defined: > Device nGnRnE (equivalent to Strongly Ordered), Device nGnRE (classic > Device memory), Device GRE, Normal

Re: [PATCH v2 06/31] arm64: MMU fault handling and page table management

2012-08-15 Thread Arnd Bergmann
On Tuesday 14 August 2012, Catalin Marinas wrote: > + > +pgd_t *pgd_alloc(struct mm_struct *mm) > +{ > + pgd_t *new_pgd; > + > + new_pgd = (pgd_t *)__get_free_pages(GFP_KERNEL, PGD_ORDER); > + if (!new_pgd) > + return NULL; > + > + memset(new_pgd, 0, PAGE_SIZE <<

[PATCH 0/3] audit-tree fixes (resend)

2012-08-15 Thread Miklos Szeredi
Short series to fix refcounting in audit-tree. Please apply. Thanks, Miklos --- Miklos Szeredi (3): audit: don't free_chunk() after fsnotify_add_mark() audit: fix refcounting in audit-tree audit: clean up refcounting in audit-tree --- kernel/audit_tree.c | 19

[PATCH 1/3] audit: don't free_chunk() after fsnotify_add_mark()

2012-08-15 Thread Miklos Szeredi
From: Miklos Szeredi Don't do free_chunk() after fsnotify_add_mark(). That one does a delayed unref via the destroy list and this results in use-after-free. Signed-off-by: Miklos Szeredi Acked-by: Eric Paris CC: sta...@vger.kernel.org --- kernel/audit_tree.c |6 +++--- 1 files changed,

[PATCH 2/3] audit: fix refcounting in audit-tree

2012-08-15 Thread Miklos Szeredi
From: Miklos Szeredi Refcounting of fsnotify_mark in audit tree is broken. E.g: refcount create_chunk alloc_chunk 1 fsnotify_add_mark 2 untag_chunk fsnotify_get_mark 3 fsnotify_destroy_mark audit_tree_freeing_mark

Re: [PATCH v8 3/6] kvm: Add IRQ source ID option to KVM_IRQFD

2012-08-15 Thread Michael S. Tsirkin
On Fri, Aug 10, 2012 at 04:37:33PM -0600, Alex Williamson wrote: > This allows specifying an IRQ source ID to be used when injecting an > interrupt. When not specified KVM_USERSPACE_IRQ_SOURCE_ID is used. > > Signed-off-by: Alex Williamson > --- > > Documentation/virtual/kvm/api.txt |5

Re: [PATCH] crypto: twofish - add x86_64/avx assembler implementation

2012-08-15 Thread Jussi Kivilinna
Quoting Borislav Petkov : Ok, here we go. Raw data below. Thanks alot! Twofish-avx appears somewhat slower than 3way, ~9% slower with 256byte blocks to ~3% slower with 8kb blocks. Let me know if you need more tests. I posted patch that optimize twofish-avx few weeks ago:

[PATCH 3/3] audit: clean up refcounting in audit-tree

2012-08-15 Thread Miklos Szeredi
From: Miklos Szeredi Drop the initial reference by fsnotify_init_mark early instead of audit_tree_freeing_mark() at destroy time. In the cases we destroy the mark before we drop the initial reference we need to get rid of the get_mark that balances the put_mark in audit_tree_freeing_mark().

Re: [PATCH v2 07/11] mm: Allocate kernel pages to the right memcg

2012-08-15 Thread Glauber Costa
On 08/15/2012 05:22 PM, Mel Gorman wrote: >> I believe it >> > to be a better and less complicated approach then letting a page appear >> > and then charging it. Besides being consistent with the rest of memcg, >> > it won't create unnecessary disturbance in the page allocator >> > when the

Re: [PATCH v2 07/31] arm64: Process management

2012-08-15 Thread Arnd Bergmann
On Tuesday 14 August 2012, Catalin Marinas wrote: > +#define THREAD_SIZE_ORDER1 > +#define THREAD_SIZE 8192 > +#define THREAD_START_SP (THREAD_SIZE - 16) THREAD_SIZE_ORDER looks wrong for 64kb-page kernels. It also doesn't seem to be used, so better remove it.

Re: [PATCH v2 08/31] arm64: CPU support

2012-08-15 Thread Arnd Bergmann
On Tuesday 14 August 2012, Catalin Marinas wrote: > diff --git a/arch/arm64/include/asm/procinfo.h > b/arch/arm64/include/asm/procinfo.h > new file mode 100644 > index 000..81fece9 > --- /dev/null > +++ b/arch/arm64/include/asm/procinfo.h > @@ -0,0 +1,44 @@ > +/* > + * Based on

Re: [ 20/82] ARM: 7467/1: mutex: use generic xchg-based implementation for ARMv6+

2012-08-15 Thread Ben Hutchings
On Mon, 2012-08-13 at 13:18 -0700, Greg Kroah-Hartman wrote: > From: Greg KH > > 3.5-stable review patch. If anyone has any objections, please let me know. > > -- > > From: Will Deacon > > commit a76d7bd96d65fa5119adba97e1b58d95f2e78829 upstream. > > The open-coded mutex

Re: [PATCH 1/4] mtd_is_partition: struct mtd_info should be const

2012-08-15 Thread Artem Bityutskiy
On Tue, 2012-07-10 at 18:23 +0200, Richard Genoud wrote: > struct mtd_info is not modified by mtd_is_partition so it should be a > const. > > Signed-off-by: Richard Genoud I've pushed this and the next MTD patches to linux-ubi, thank you! I hope David does not mind if it goes in via the MTD, or

[PATCH 0/4] vfs: fix file creation mode bugs

2012-08-15 Thread Miklos Szeredi
This fixes a FUSE regression reported against 3.6-rc1 as well as an older bug (stable CC-d). Please apply. Thanks, Miklos --- Miklos Szeredi (4): vfs: canonicalize create mode in build_open_flags() vfs: atomic_open(): fix create mode usage vfs: pass right create mode to

[PATCH 3/4] vfs: pass right create mode to may_o_create()

2012-08-15 Thread Miklos Szeredi
From: Miklos Szeredi Pass the umask-ed create mode to may_o_create() instead of the original one. Signed-off-by: Miklos Szeredi Tested-by: Richard W.M. Jones --- fs/namei.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/namei.c b/fs/namei.c index

[PATCH 4/4] fuse: check create mode in atomic open

2012-08-15 Thread Miklos Szeredi
From: Miklos Szeredi Verify that the VFS is passing us a complete create mode with the S_IFREG to atomic open. Reported-by: Steve Reported-by: Richard W.M. Jones Signed-off-by: Miklos Szeredi Tested-by: Richard W.M. Jones --- fs/fuse/dir.c |3 +++ 1 files changed, 3 insertions(+), 0

Re: v3.5 nfsd4 regression; utime sometimes takes 40+ seconds to return

2012-08-15 Thread Jamie Heilman
Jamie Heilman wrote: > I'll try to get full rcpdebug traces on client and server as the delay > is occuring in the hopes that helps pin things down, and post them > separately. OK, here are the logs from client and server, where a run of my test program under strace -T resulted in:

[PATCH 1/4] vfs: canonicalize create mode in build_open_flags()

2012-08-15 Thread Miklos Szeredi
From: Miklos Szeredi Userspace can pass weird create mode in open(2) that we canonicalize to "(mode & S_IALLUGO) | S_IFREG" in vfs_create(). The problem is that we use the uncanonicalized mode before calling vfs_create() with unforseen consequences. So do the canonicalization early in

[PATCH V2] KVM: x86: disable stealtime on reboot to avoid mem corruption

2012-08-15 Thread Florian Westphal
else, host continues to update stealtime after reboot, which can corrupt e.g. initramfs area. found when tracking down initramfs unpack error on initial reboot (with qemu-kvm -smp 2, no problem with single-core). Signed-off-by: Florian Westphal --- arch/x86/kernel/kvm.c |1 + 1 files

[PATCH 2/4] vfs: atomic_open(): fix create mode usage

2012-08-15 Thread Miklos Szeredi
From: Miklos Szeredi Don't mask S_ISREG off the create mode before passing to ->atomic_open(). Other methods (->create, ->mknod) also get the complete file mode and filesystems expect it. Reported-by: Steve Reported-by: Richard W.M. Jones Signed-off-by: Miklos Szeredi Tested-by: Richard

Re: [PATCH 03/22] ASoC: ab8500: Inform SoC Core that we have our own I/O arrangements

2012-08-15 Thread Mark Brown
On Thu, Aug 09, 2012 at 04:47:29PM +0100, Lee Jones wrote: > If codec->control_data is not populated SoC Core assumes we want to > use regmap, which fails catastrophically, as we don't have one: *Always* submit code against the current code for the subsystem. -- To unsubscribe from this list:

Re: [PATCH v2 06/11] memcg: kmem controller infrastructure

2012-08-15 Thread Glauber Costa
On 08/15/2012 05:09 PM, Michal Hocko wrote: > On Wed 15-08-12 13:42:24, Glauber Costa wrote: > [...] + + ret = 0; + + if (!memcg) + return ret; + + _memcg = memcg; + ret = __mem_cgroup_try_charge(NULL, gfp, delta / PAGE_SIZE, +

Re: [ 06/44] ARM: 7467/1: mutex: use generic xchg-based implementation for ARMv6+

2012-08-15 Thread Ben Hutchings
On Mon, 2012-08-13 at 15:02 -0700, Greg Kroah-Hartman wrote: > From: Greg KH > > 3.0-stable review patch. If anyone has any objections, please let me know. > > -- > > From: Will Deacon > > commit a76d7bd96d65fa5119adba97e1b58d95f2e78829 upstream. > > The open-coded mutex

Re: [PATCH] crypto: twofish - add x86_64/avx assembler implementation

2012-08-15 Thread Borislav Petkov
On Wed, Aug 15, 2012 at 04:48:54PM +0300, Jussi Kivilinna wrote: > I posted patch that optimize twofish-avx few weeks ago: > http://marc.info/?l=linux-crypto-vger=134364845024825=2 > > I'd be interested to know, if this is patch helps on Bulldozer. Sure, can you inline it here too please. The

Re: [ 10/44] ALSA: hda - remove quirk for Dell Vostro 1015

2012-08-15 Thread Greg Kroah-Hartman
On Tue, Aug 14, 2012 at 07:17:43AM +0200, David Henningsson wrote: > On 08/14/2012 12:02 AM, Greg Kroah-Hartman wrote: > >From: Greg KH > > > >3.0-stable review patch. If anyone has any objections, please let me know. > > As my previous email states, I still object to this patch being > applied

[tip:timers/urgent] time: Improve sanity checking of timekeeping inputs

2012-08-15 Thread tip-bot for John Stultz
Commit-ID: 4e8b14526ca7fb046a81c94002c1c43b6fdf0e9b Gitweb: http://git.kernel.org/tip/4e8b14526ca7fb046a81c94002c1c43b6fdf0e9b Author: John Stultz AuthorDate: Wed, 8 Aug 2012 15:36:20 -0400 Committer: Thomas Gleixner CommitDate: Wed, 15 Aug 2012 15:54:01 +0200 time: Improve sanity

Re: [PATCH v8 5/6] kvm: KVM_IRQ_ACKFD

2012-08-15 Thread Michael S. Tsirkin
On Fri, Aug 10, 2012 at 04:37:48PM -0600, Alex Williamson wrote: > Enable a mechanism for IRQ ACKs to be exposed through an eventfd. The > user can specify the GSI and optionally an IRQ source ID and have the > provided eventfd trigger whenever the irqchip resamples it's inputs, > for instance on

Re: [ 07/44] ARM: 7477/1: vfp: Always save VFP state in vfp_pm_suspend on UP

2012-08-15 Thread Greg Kroah-Hartman
On Tue, Aug 14, 2012 at 05:01:11PM -0300, Herton Ronaldo Krzesinski wrote: > On Mon, Aug 13, 2012 at 03:02:14PM -0700, Greg Kroah-Hartman wrote: > > From: Greg KH > > > [...] > > --- a/arch/arm/vfp/vfpmodule.c > > +++ b/arch/arm/vfp/vfpmodule.c > > @@ -412,6 +412,12 @@ static int

Re: [ 36/44] x86, microcode: Sanitize per-cpu microcode reloading interface

2012-08-15 Thread Greg Kroah-Hartman
On Tue, Aug 14, 2012 at 09:26:54PM -0300, Henrique de Moraes Holschuh wrote: > I believe the patch bellow, which was required on 3.2, will also be > necessary. Will it be necessary to apply this before this patch goes in the series, or after it? thanks, greg k-h -- To unsubscribe from this

Re: [ 20/82] ARM: 7467/1: mutex: use generic xchg-based implementation for ARMv6+

2012-08-15 Thread Greg Kroah-Hartman
On Wed, Aug 15, 2012 at 02:56:22PM +0100, Ben Hutchings wrote: > On Mon, 2012-08-13 at 13:18 -0700, Greg Kroah-Hartman wrote: > > From: Greg KH > > > > 3.5-stable review patch. If anyone has any objections, please let me know. > > > > -- > > > > From: Will Deacon > > > >

Re: [PATCH v8 6/6] kvm: Add de-assert option to KVM_IRQ_ACKFD

2012-08-15 Thread Michael S. Tsirkin
On Fri, Aug 10, 2012 at 04:37:56PM -0600, Alex Williamson wrote: > It's likely (vfio) that one of the reasons to watch for an IRQ ACK > is to de-assert and re-enable an interrupt. As the IRQ ACK notfier > is already watching a GSI for an IRQ source ID we can easily couple > these together. > >

Re: [PATCH v2 04/11] kmem accounting basic infrastructure

2012-08-15 Thread Michal Hocko
On Wed 15-08-12 17:31:24, Glauber Costa wrote: > On 08/15/2012 05:26 PM, Michal Hocko wrote: > > On Wed 15-08-12 17:04:31, Glauber Costa wrote: > >> On 08/15/2012 05:02 PM, Michal Hocko wrote: > >>> On Wed 15-08-12 16:53:40, Glauber Costa wrote: > >>> [...] > >>> This doesn't check for the

Re: [PATCH v2 04/11] kmem accounting basic infrastructure

2012-08-15 Thread Glauber Costa
> OK, I missed an important point that kmem_accounted is not exported to > the userspace (I thought it would be done later in the series) which > is not the case so actually nobody get's confused by the inconsistency > because it is about RESOURCE_MAX which they see in both cases. > Sorry about

Re: [ 20/82] ARM: 7467/1: mutex: use generic xchg-based implementation for ARMv6+

2012-08-15 Thread Ben Hutchings
On Wed, 2012-08-15 at 07:08 -0700, Greg Kroah-Hartman wrote: > On Wed, Aug 15, 2012 at 02:56:22PM +0100, Ben Hutchings wrote: > > On Mon, 2012-08-13 at 13:18 -0700, Greg Kroah-Hartman wrote: > > > From: Greg KH > > > > > > 3.5-stable review patch. If anyone has any objections, please let me >

Re: [PATCH] select GENERIC_ATOMIC64 for c6x/score/unicore32 archs

2012-08-15 Thread Fengguang Wu
On Wed, Aug 15, 2012 at 09:42:58AM -0400, Mark Salter wrote: > On Wed, 2012-08-15 at 10:36 +0800, Fengguang Wu wrote: > > > -#define L1_CACHE_BYTESL2_CACHE_BYTES > > > +#define L1_CACHE_SHIFTL2_CACHE_SHIFT > > > +#define L1_CACHE_BYTES(1 << L2_CACHE_SHIFT) > > > > Nitpick:

Re: [PATCH v2 16/31] arm64: ELF definitions

2012-08-15 Thread Arnd Bergmann
On Tuesday 14 August 2012, Catalin Marinas wrote: > + > +void elf_set_personality(int personality) > +{ > + switch (personality & PER_MASK) { > + case PER_LINUX: > + clear_thread_flag(TIF_32BIT); > + break; > + case PER_LINUX32: > +

Re: [PATCH] select GENERIC_ATOMIC64 for c6x/score/unicore32 archs

2012-08-15 Thread Mark Salter
On Wed, 2012-08-15 at 22:12 +0800, Fengguang Wu wrote: > > Should I push this through the c6x tree? > > That'd be good. For consistency, will you also include the > GENERIC_ATOMIC64 chunk in the titled patch? > > I can send Andrew an updated series (reducing the c6x changes, and > possibly the

Re: [discussion]sched: a rough proposal to enable power saving in scheduler

2012-08-15 Thread Arjan van de Ven
On 8/15/2012 4:05 AM, Peter Zijlstra wrote: > I'm not sure this is a valid assumption. I've had it explained to me by > various people that race-to-idle isn't always the best thing. it's not so much race to idle (which is more about frequency than anything else) it's about the situation that in

Re: [PATCH] crypto: twofish - add x86_64/avx assembler implementation

2012-08-15 Thread Jussi Kivilinna
> On Wed, Aug 15, 2012 at 04:48:54PM +0300, Jussi Kivilinna wrote: > > I posted patch that optimize twofish-avx few weeks ago: > > http://marc.info/?l=linux-crypto-vger=134364845024825=2 > > > > I'd be interested to know, if this is patch helps on Bulldozer. > > Sure, can you inline it here too

Re: [PATCH v2 17/31] arm64: System calls handling

2012-08-15 Thread Arnd Bergmann
On Tuesday 14 August 2012, Catalin Marinas wrote: > + > +/* This matches struct stat64 in glibc2.1, hence the absolutely > + * insane amounts of padding around dev_t's. > + * Note: The kernel zero's the padded region because glibc might read them > + * in the hope that the kernel has stretched to

Re: [PATCH v2 06/11] memcg: kmem controller infrastructure

2012-08-15 Thread Michal Hocko
On Wed 15-08-12 18:01:51, Glauber Costa wrote: > On 08/15/2012 05:09 PM, Michal Hocko wrote: > > On Wed 15-08-12 13:42:24, Glauber Costa wrote: > > [...] > + > +ret = 0; > + > +if (!memcg) > +return ret; > + > +_memcg =

Re: [discussion]sched: a rough proposal to enable power saving in scheduler

2012-08-15 Thread Rakib Mullick
On 8/13/12, Alex Shi wrote: > Since there is no power saving consideration in scheduler CFS, I has a > very rough idea for enabling a new power saving schema in CFS. > > It bases on the following assumption: > 1, If there are many task crowd in system, just let few domain cpus > running and let

[PATCH v3 6/6] workqueue: use system_highpri_wq for unbind_work

2012-08-15 Thread Joonsoo Kim
To speed cpu down processing up, use system_highpri_wq. As scheduling priority of workers on it is higher than system_wq and it is not contended by other normal works on this cpu, work on it is processed faster than system_wq. Signed-off-by: Joonsoo Kim diff --git a/kernel/workqueue.c

[PATCH v3 4/6] workqueue: introduce system_highpri_wq

2012-08-15 Thread Joonsoo Kim
Commit 3270476a6c0ce322354df8679652f060d66526dc ('workqueue: reimplement WQ_HIGHPRI using a separate worker_pool') introduce separate worker pool for HIGHPRI. When we handle busyworkers for gcwq, it can be normal worker or highpri worker. But, we don't consider this difference in rebind_workers(),

[PATCH v3 5/6] workqueue: use system_highpri_wq for highpri workers in rebind_workers()

2012-08-15 Thread Joonsoo Kim
In rebind_workers(), we do inserting a work to rebind to cpu for busy workers. Currently, in this case, we use only system_wq. This makes a possible error situation as there is mismatch between cwq->pool and worker->pool. To prevent this, we should use system_highpri_wq for highpri worker to

Re: [PATCH v8 0/6] kvm: level irqfd support

2012-08-15 Thread Michael S. Tsirkin
On Fri, Aug 10, 2012 at 04:37:08PM -0600, Alex Williamson wrote: > v8: > > Trying a new approach. Nobody seems to like the internal IRQ > source ID object and the interactions it implies between irqfd > and eoifd, so let's get rid of it. Instead, simply expose > IRQ source IDs to userspace.

[PATCH v3 0/6] system_highpri_wq

2012-08-15 Thread Joonsoo Kim
Change from v2 [1/6] No change [2/6] Change local variable name and use it directly for TP [3/6] Add a comment. [4/6] No change [5/6] Add a comment. Fix ugly indentation. [6/6] No change Change from v1 [ALL] Add cover-letter [ALL] Rebase on git://git.kernel.org/pub/scm/linux/kernel/git/tj/wq.git

[PATCH v3 2/6] workqueue: correct req_cpu in trace_workqueue_queue_work()

2012-08-15 Thread Joonsoo Kim
When we do tracing workqueue_queue_work(), it records requested cpu. But, if !(@wq->flag & WQ_UNBOUND) and @cpu is WORK_CPU_UNBOUND, requested cpu is changed as local cpu. In case of @wq->flag & WQ_UNBOUND, above change is not occured, therefore it is reasonable to correct it. Use temporary local

Re: [PATCH v2 06/11] memcg: kmem controller infrastructure

2012-08-15 Thread Glauber Costa
>> >> I see now, you seem to be right. > > No I am not because it seems that I am really blind these days... > We were doing this in mem_cgroup_do_charge for ages: > if (!(gfp_mask & __GFP_WAIT)) > return CHARGE_WOULDBLOCK; > > /me goes to hide and get with further

[PATCH v3 3/6] workqueue: change value of lcpu in __queue_delayed_work_on()

2012-08-15 Thread Joonsoo Kim
We assign cpu id into work struct's data field in __queue_delayed_work_on(). In current implementation, when work is come in first time, current running cpu id is assigned. If we do __queue_delayed_work_on() with CPU A on CPU B, __queue_work() invoked in delayed_work_timer_fn() go into the

[PATCH v3 1/6] workqueue: use enum value to set array size of pools in gcwq

2012-08-15 Thread Joonsoo Kim
Commit 3270476a6c0ce322354df8679652f060d66526dc ('workqueue: reimplement WQ_HIGHPRI using a separate worker_pool') introduce separate worker_pool for HIGHPRI. Although there is NR_WORKER_POOLS enum value which represent size of pools, definition of worker_pool in gcwq doesn't use it. Using it

Re: yama_ptrace_access_check(): possible recursive locking detected

2012-08-15 Thread Peter Zijlstra
On Wed, 2012-08-15 at 15:01 +0200, Oleg Nesterov wrote: > BTW, set_task_comm()->wmb() and memset() should die. There are > not needed afaics, and the comment is misleading. As long as we guarantee there's always a terminating '\0', now strlcpy() doesn't pad the result, however if we initialize

Re: [PATCH 0/4] promote zcache from staging

2012-08-15 Thread Seth Jennings
On 08/15/2012 04:38 AM, Konrad Rzeszutek Wilk wrote: > On Fri, Aug 10, 2012 at 01:14:01PM -0500, Seth Jennings wrote: >> On 08/09/2012 03:20 PM, Dan Magenheimer wrote >>> I also wonder if you have anything else unusual in your >>> test setup, such as a fast swap disk (mine is a partition >>> on

Re: [PATCH v2 21/31] arm64: 32-bit (compat) applications support

2012-08-15 Thread Arnd Bergmann
On Tuesday 14 August 2012, Catalin Marinas wrote: > +#ifdef CONFIG_AARCH32_EMULATION > +#include > + > +#define AARCH32_KERN_SIGRET_CODE_OFFSET 0x500 > + > +extern const compat_ulong_t aarch32_sigret_code[6]; > + > +int compat_setup_frame(int usig, struct k_sigaction *ka, sigset_t *set, > +

Re: [PATCH v2 22/31] arm64: Floating point and SIMD

2012-08-15 Thread Arnd Bergmann
On Tuesday 14 August 2012, Catalin Marinas wrote: > This patch adds support for FP/ASIMD register bank saving and restoring > during context switch and FP exception handling to generate SIGFPE. > There are 32 128-bit registers and the context switching is currently > done non-lazily. Benchmarks on

Re: [PATCH 5/5] drivers/usb/host/ehci-platform.c: fix error return code

2012-08-15 Thread Alan Stern
On Tue, 14 Aug 2012, Julia Lawall wrote: > From: Julia Lawall > > Convert a possibly 0 error return code to a negative one, as returned > elsewhere in the function. ... > diff --git a/drivers/usb/host/ehci-platform.c > b/drivers/usb/host/ehci-platform.c > index 91acdde..764e010 100644 > ---

Re: [PATCH 4/5] drivers/usb/host/ohci-platform.c: fix error return code

2012-08-15 Thread Alan Stern
On Tue, 14 Aug 2012, Julia Lawall wrote: > From: Julia Lawall > > Convert a possibly 0 error return code to a negative one, as returned > elsewhere in the function. > diff --git a/drivers/usb/host/ohci-platform.c > b/drivers/usb/host/ohci-platform.c > index 10d85b9..e24ec9f 100644 > ---

Re: [PATCH] perf: Let O= makes handle relative paths

2012-08-15 Thread Peter Zijlstra
On Wed, 2012-08-15 at 15:18 +0200, Borislav Petkov wrote: > On Wed, Aug 15, 2012 at 10:06:34AM -0300, Arnaldo Carvalho de Melo wrote: > > That was the case in the past, but IIRC PeterZ advocated not to and I > > agreed. > > Maybe you guys need to explain yourselves :) I mean, the dir is not >

Re: [discussion]sched: a rough proposal to enable power saving in scheduler

2012-08-15 Thread Peter Zijlstra
On Wed, 2012-08-15 at 06:45 -0700, Arjan van de Ven wrote: > On 8/15/2012 4:05 AM, Peter Zijlstra wrote: > > Yay, ideally we'd also provide a 3rd option: auto, which simply switches > > between the two based on AC/BAT, UPS > > nooo! > > anything but this. > if anyone thinks that AC/Battery

Re: [PATCH v7 2/4] virtio_balloon: introduce migration primitives to balloon pages

2012-08-15 Thread Michael S. Tsirkin
On Wed, Aug 15, 2012 at 09:34:58AM -0300, Rafael Aquini wrote: > On Tue, Aug 14, 2012 at 10:31:09PM +0300, Michael S. Tsirkin wrote: > > > > now CPU1 executes the next instruction: > > > > > > > > } > > > > > > > > which would normally return to function's caller, > > > > but it has been

Re: [PATCH] perf: Let O= makes handle relative paths

2012-08-15 Thread Borislav Petkov
On Wed, Aug 15, 2012 at 04:38:05PM +0200, Peter Zijlstra wrote: > Because you're an idiot and made a typo ;-) Happens to me all the time. I'm not an idiot - I'm perfection at its purest! :-) > The regular kernel build doesn't create non-existent O= targets either > iirc. Ok, I see. The kernel

Re: [discussion]sched: a rough proposal to enable power saving in scheduler

2012-08-15 Thread Peter Zijlstra
On Wed, 2012-08-15 at 15:15 +0200, Borislav Petkov wrote: > On Wed, Aug 15, 2012 at 01:05:38PM +0200, Peter Zijlstra wrote: > > On Mon, 2012-08-13 at 20:21 +0800, Alex Shi wrote: > > > Since there is no power saving consideration in scheduler CFS, I has a > > > very rough idea for enabling a new

Re: [discussion]sched: a rough proposal to enable power saving in scheduler

2012-08-15 Thread Arjan van de Ven
On 8/15/2012 7:39 AM, Peter Zijlstra wrote: > On Wed, 2012-08-15 at 06:45 -0700, Arjan van de Ven wrote: >> On 8/15/2012 4:05 AM, Peter Zijlstra wrote: >>> Yay, ideally we'd also provide a 3rd option: auto, which simply switches >>> between the two based on AC/BAT, UPS >> >> nooo! >> >>

Re: [discussion]sched: a rough proposal to enable power saving in scheduler

2012-08-15 Thread Peter Zijlstra
On Wed, 2012-08-15 at 07:19 -0700, Arjan van de Ven wrote: > Ideally the scheduler builds up some history of the typical run > duration of the task (with a bias to more recent runs). > But... even then, the past is only a poor predictor for the future. PJTs patches do this. But yes, a

Re: [discussion]sched: a rough proposal to enable power saving in scheduler

2012-08-15 Thread Thomas Gleixner
On Wed, 15 Aug 2012, Peter Zijlstra wrote: > On Wed, 2012-08-15 at 07:19 -0700, Arjan van de Ven wrote: > > Ideally the scheduler builds up some history of the typical run > > duration of the task (with a bias to more recent runs). > > But... even then, the past is only a poor predictor for the

Re: [ 20/82] ARM: 7467/1: mutex: use generic xchg-based implementation for ARMv6+

2012-08-15 Thread Nicolas Pitre
On Wed, 15 Aug 2012, Ben Hutchings wrote: > On Wed, 2012-08-15 at 07:08 -0700, Greg Kroah-Hartman wrote: > > On Wed, Aug 15, 2012 at 02:56:22PM +0100, Ben Hutchings wrote: > > > On Mon, 2012-08-13 at 13:18 -0700, Greg Kroah-Hartman wrote: > > > > From: Greg KH > > > > > > > > 3.5-stable review

Re: [PATCH v2 20/31] arm64: User access library function

2012-08-15 Thread Arnd Bergmann
On Tuesday 14 August 2012, Catalin Marinas wrote: > +/* > + * Single-value transfer routines. They automatically use the right > + * size if we just have the right pointer type. Note that the functions > + * which read from user space (*get_*) need to take care not to leak > + * kernel data

Re: [ 07/44] ARM: 7477/1: vfp: Always save VFP state in vfp_pm_suspend on UP

2012-08-15 Thread Herton Ronaldo Krzesinski
On Wed, Aug 15, 2012 at 07:05:41AM -0700, Greg Kroah-Hartman wrote: > On Tue, Aug 14, 2012 at 05:01:11PM -0300, Herton Ronaldo Krzesinski wrote: > > On Mon, Aug 13, 2012 at 03:02:14PM -0700, Greg Kroah-Hartman wrote: > > > From: Greg KH > > > > > [...] > > > --- a/arch/arm/vfp/vfpmodule.c > > >

Re: [ 20/82] ARM: 7467/1: mutex: use generic xchg-based implementation for ARMv6+

2012-08-15 Thread Greg Kroah-Hartman
On Wed, Aug 15, 2012 at 03:11:41PM +0100, Ben Hutchings wrote: > On Wed, 2012-08-15 at 07:08 -0700, Greg Kroah-Hartman wrote: > > On Wed, Aug 15, 2012 at 02:56:22PM +0100, Ben Hutchings wrote: > > > On Mon, 2012-08-13 at 13:18 -0700, Greg Kroah-Hartman wrote: > > > > From: Greg KH > > > > > > >

Re: [PATCH 4/4] UBI: replace MTD_UBI_BEB_LIMIT with user-space parameter

2012-08-15 Thread Artem Bityutskiy
On Tue, 2012-07-10 at 18:23 +0200, Richard Genoud wrote: > This patch provides the possibility to adjust the "maximum expected number of > bad blocks per 1024 blocks" (max_beb_per1024) for each mtd device. > > The majority of NAND devices have their max_beb_per1024 equal to 20, but > sometimes

Re: [discussion]sched: a rough proposal to enable power saving in scheduler

2012-08-15 Thread Peter Zijlstra
On Wed, 2012-08-15 at 20:24 +0600, Rakib Mullick wrote: > How do you plan to test this power saving scheme? Using powertop? Or, > is there any other tools? We should start out simple enough that we can validate it by looking at task placement by hand, eg. 4 tasks on a dual socket quad-core,

Re: [ 20/82] ARM: 7467/1: mutex: use generic xchg-based implementation for ARMv6+

2012-08-15 Thread Will Deacon
On Wed, Aug 15, 2012 at 03:49:56PM +0100, Greg Kroah-Hartman wrote: > > Will Deacon wrote: > > > The additional patch should also be CC'd to stable and is sitting in -tip > > > somewhere I believe, so it shouldn't be long before it does hit mainline. > > > > > > Without this patch there's a

Re: [PATCH v2 04/11] kmem accounting basic infrastructure

2012-08-15 Thread Christoph Lameter
On Wed, 15 Aug 2012, Michal Hocko wrote: > > That is not what the kernel does, in general. We assume that if he wants > > that memory and we can serve it, we should. Also, not all kernel memory > > is unreclaimable. We can shrink the slabs, for instance. Ying Han > > claims she has patches for

[PATCH 1/5] perf ui: Introduce struct perf_helpline

2012-08-15 Thread Namhyung Kim
Add struct perf_helpline in order to provide flexible implementation of helpline APIs. And convert existing TUI implementation to use it. Signed-off-by: Namhyung Kim --- tools/perf/Makefile |5 ++-- tools/perf/ui/helpline.c | 56 ++--

[PATCH 3/5] perf ui/gtk: Implement helpline_fns

2012-08-15 Thread Namhyung Kim
Add helpline API implementation to GTK front-end. Cc: Pekka Enberg Signed-off-by: Namhyung Kim --- tools/perf/Makefile |1 + tools/perf/ui/gtk/gtk.h |2 ++ tools/perf/ui/gtk/helpline.c | 31 +++ tools/perf/ui/gtk/setup.c|1 + 4 files

[PATCH 4/5] perf ui/gtk: Use helpline API in browser

2012-08-15 Thread Namhyung Kim
As we now have a helpline implementation, use it for displaying help messages. Cc: Pekka Enberg Signed-off-by: Namhyung Kim --- tools/perf/ui/gtk/browser.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/perf/ui/gtk/browser.c b/tools/perf/ui/gtk/browser.c index

[PATCH 5/5] perf ui/gtk: Add perf_gtk__show_helpline() for pr_*

2012-08-15 Thread Namhyung Kim
Use helpline for printing error/debug messages. The code resembles a TUI counter part and only print the first line of the message. Cc: Pekka Enberg Signed-off-by: Namhyung Kim --- tools/perf/ui/gtk/helpline.c | 26 ++ tools/perf/ui/gtk/util.c |5 -

[PATCH 2/5] perf ui/tui: Add tui.h header

2012-08-15 Thread Namhyung Kim
Consolidate TUI-relate header files and declarations into tui.h. Signed-off-by: Namhyung Kim --- tools/perf/Makefile |1 + tools/perf/ui/helpline.h |2 -- tools/perf/ui/tui/helpline.c |5 + tools/perf/ui/tui/setup.c| 12 +--- tools/perf/ui/tui/tui.h

Re: [PATCH] perf: Let O= makes handle relative paths

2012-08-15 Thread Arnaldo Carvalho de Melo
Em Wed, Aug 15, 2012 at 04:42:55PM +0200, Borislav Petkov escreveu: > On Wed, Aug 15, 2012 at 04:38:05PM +0200, Peter Zijlstra wrote: > > Because you're an idiot and made a typo ;-) Happens to me all the time. > > I'm not an idiot - I'm perfection at its purest! :-) > > > The regular kernel

Re: [NEW DRIVER V2 5/7] DA9058 GPIO driver

2012-08-15 Thread Linus Walleij
On Wed, Aug 15, 2012 at 12:08 PM, Opensource [Anthony Olech] wrote: > [Me] >> > + if (offset > 1) >> > + return -EINVAL; >> So there are two GPIO pins, 0 and 1? That seems odd, but OK. > > That is a feature of the hardware. I believe that calling them "0" and > "1" is the

Re: [PATCH] net: add new QCA alx ethernet driver

2012-08-15 Thread Stephen Hemminger
On Wed, 15 Aug 2012 05:39:11 + "Ren, Cloud" wrote: > From: David Miller [mailto:da...@davemloft.net] > Sent: Wednesday, August 15, 2012 1:33 PM > > >From: "Ren, Cloud" > >Date: Wed, 15 Aug 2012 03:29:26 + > > > +strncpy(netdev->name, pci_name(pdev), sizeof(netdev->name) -

Re: v3.5 nfsd4 regression; utime sometimes takes 40+ seconds to return

2012-08-15 Thread J. Bruce Fields
On Wed, Aug 15, 2012 at 01:58:54PM +, Jamie Heilman wrote: > Jamie Heilman wrote: > > I'll try to get full rcpdebug traces on client and server as the delay > > is occuring in the hopes that helps pin things down, and post them > > separately. > > OK, here are the logs from client and server,

Re: [PATCH 1/4] cputime: Generalize CONFIG_VIRT_CPU_ACCOUNTING

2012-08-15 Thread Martin Schwidefsky
On Tue, 14 Aug 2012 16:16:47 +0200 Frederic Weisbecker wrote: > S390, ia64 and powerpc all define their own version > of CONFIG_VIRT_CPU_ACCOUNTING. Generalize the config > and its description to a single place to avoid > duplication. For S390 CONFIG_VIRT_CPU_ACCOUNTING is not configurable, it

[PATCH 1/2] slub: reduce failure of this_cpu_cmpxchg in put_cpu_partial() after unfreezing

2012-08-15 Thread Joonsoo Kim
In current implementation, after unfreezing, we doesn't touch oldpage, so it remain 'NOT NULL'. When we call this_cpu_cmpxchg() with this old oldpage, this_cpu_cmpxchg() is mostly be failed. We can change value of oldpage to NULL after unfreezing, because unfreeze_partial() ensure that all the

Re: [PATCH 3/4] UBI: use the whole MTD device size to get bad_peb_limit

2012-08-15 Thread Artem Bityutskiy
On Tue, 2012-07-10 at 18:23 +0200, Richard Genoud wrote: > + /* we are using here the whole MTD device size and not > + * the MTD partition size because the maximum number of > + * bad blocks is a percentage of the whole device and > +

[PATCH 2/2] slub: remove one code path and reduce lock contention in __slab_free()

2012-08-15 Thread Joonsoo Kim
When we try to free object, there is some of case that we need to take a node lock. This is the necessary step for preventing a race. After taking a lock, then we try to cmpxchg_double_slab(). But, there is a possible scenario that cmpxchg_double_slab() is failed with taking a lock. Following

Re: [discussion]sched: a rough proposal to enable power saving in scheduler

2012-08-15 Thread Peter Zijlstra
On Wed, 2012-08-15 at 07:43 -0700, Arjan van de Ven wrote: > > Servers in a datacenter have battery? > > they have AC, and sometimes a battery called "UPS". > DC is getting much more prevalent in datacenters in general. AC/DC (/me slams a riff on his air-guitar)... > >> seriously, there are

Re: [PATCH 2/4] sched: Move cputime code to its own file

2012-08-15 Thread Martin Schwidefsky
On Tue, 14 Aug 2012 16:16:48 +0200 Frederic Weisbecker wrote: > Extract cputime code from the giant sched/core.c and > put it in its own file. This make it easier to deal with > this particular area and de-bloat a bit more core.c To move the cputime accouting code to its own file makes sense.

Re: [PATCH v2 23/31] arm64: Debugging support

2012-08-15 Thread Arnd Bergmann
On Tuesday 14 August 2012, Catalin Marinas wrote: > +const struct user_regset_view *task_user_regset_view(struct task_struct > *task) > +{ > +#ifdef CONFIG_AARCH32_EMULATION > + if (test_tsk_thread_flag(task, TIF_32BIT)) > + return _aarch32_view; > +#endif > + return

Re: [PATCH v2 24/31] arm64: Add support for /proc/sys/debug/exception-trace

2012-08-15 Thread Arnd Bergmann
On Tuesday 14 August 2012, Catalin Marinas wrote: > > This patch allows setting of the show_unhandled_signals variable via > /proc/sys/debug/exception-trace. The default value is currently 1 > showing unhandled user faults (undefined instructions, data aborts) and > invalid signal stack frames. >

Re: [PATCH] act_mirred: do not drop packets when fails to mirror it

2012-08-15 Thread Jamal Hadi Salim
On Wed, 2012-08-15 at 21:42 +0800, Jason Wang wrote: > > I met it actually through the following steps: > > - start a kvm guest with tap and make it to be an interface of the bridge > - mirror the ingress traffic of the bridge to the tap > - terminate the qemu process, the tap device is then

Re: [PATCH] sched: Support compiling out real-time scheduling with REALTIME_SCHED.

2012-08-15 Thread Josh Triplett
On Wed, Aug 15, 2012 at 09:12:20AM +0200, Mike Galbraith wrote: > On Tue, 2012-08-14 at 13:50 -0700, Trevor Brandt wrote: > > diff --git a/init/Kconfig b/init/Kconfig > > index 3f42cd6..768dc76 100644 > > --- a/init/Kconfig > > +++ b/init/Kconfig > > @@ -27,6 +27,13 @@ config IRQ_WORK > > bool

Re: [PATCH v2 25/31] arm64: Performance counters support

2012-08-15 Thread Arnd Bergmann
On Tuesday 14 August 2012, Catalin Marinas wrote: > From: Will Deacon > > This patch adds support for the AArch64 performance counters. > > Signed-off-by: Will Deacon > Signed-off-by: Catalin Marinas > --- > arch/arm64/include/asm/perf_event.h | 22 + > arch/arm64/include/asm/pmu.h

<    5   6   7   8   9   10   11   12   13   14   >